From patchwork Sun Dec 9 05:20:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 10719829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09F6714E2 for ; Sun, 9 Dec 2018 05:20:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF8092863E for ; Sun, 9 Dec 2018 05:20:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E33532AB09; Sun, 9 Dec 2018 05:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FDB22AB07 for ; Sun, 9 Dec 2018 05:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbeLIFUs (ORCPT ); Sun, 9 Dec 2018 00:20:48 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40794 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbeLIFUs (ORCPT ); Sun, 9 Dec 2018 00:20:48 -0500 Received: by mail-pg1-f195.google.com with SMTP id z10so3474300pgp.7 for ; Sat, 08 Dec 2018 21:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WBQlmUFigG6XjRPhVyNz9kgraxu7zwYVtMWk1l0gYuk=; b=kU59vhinSQqPf0hyKHR7b0XMnickmmURWrRJzOrGShynxnUnZeHnmewgSrxLWlSnSr 8YtmSjXjHN89lUWZQ/ZX+M03YNVp2c248t/2xi/NItcz0tVakF106w4xGL+GeSQYVKUI +7GM01n8lcXZkLcN5jfR9HZdGhL04Vr6pU4JMtnJF9r9AMJ7K+Tk5mFZhLb+vL54ZSLJ 3OQ+rkC1wjcjSWIV2doZ4hGa6yvro+YvzKOMRNVT9lzvhvrrzAf2ix7wunK+ugGfMMb4 WRlccWVo1yH5zU/2oBK4xXoe3XbmAoL6fNBmw+QPX1qA7JdY9EyjiQLQOavNa1K0QFmz pTxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WBQlmUFigG6XjRPhVyNz9kgraxu7zwYVtMWk1l0gYuk=; b=SxU9AADyNw0bXLnK7bwN7h+zTH+idHbFTATXvItfkD+Boz1B7qAmAg/NHmJrc9Mde2 4V3uo4q13jZllCWlUINWNr64cTGPA8TlMmtnA+EMZEov8L6w/hvhMflHVpUn8FxneCkx wejkbAOfR6LNHg8Pd6VC8B85EtX9djdxyFTzI+cVXx9RAr2zV9PN22NlhuPLNxSCU0qx cZhjd0IMPh5XXn0vmSZGfZDD/+Pm4ZBlvBtyVcUheSOX7HQFtCQfUENfzhIXwKvJhDJv VvQYscHa3w5MwGItF0Rpw1TW8bz9ZyEIRx82+MygfMtStNMMvuOSIhHkSHcDdPfurOIp AySQ== X-Gm-Message-State: AA+aEWYm7UyMVkzSeouPrXcI5VB4HXKE0qa2QWgC8DwGl2uAo1/ZXOzJ 44/g793+wvbc7zJxVJRsFWYmjKmWhgE= X-Google-Smtp-Source: AFSGD/VKVlMPRceVe5eGGaO5I7QN1GxcWhH0Iu3/mZ1NgRPoxQNyKAciBcXZbBjZyN0+o3UHzqkFiw== X-Received: by 2002:a63:a84a:: with SMTP id i10mr7045181pgp.263.1544332847211; Sat, 08 Dec 2018 21:20:47 -0800 (PST) Received: from localhost.localdomain ([240f:34:212d:1:a17f:ba11:defa:e2d1]) by smtp.gmail.com with ESMTPSA id v14sm14973270pgf.3.2018.12.08.21.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 08 Dec 2018 21:20:46 -0800 (PST) From: Akinobu Mita To: linux-media@vger.kernel.org Cc: Akinobu Mita , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH v2 1/3] media: ov2640: set default window and format code at probe time Date: Sun, 9 Dec 2018 14:20:31 +0900 Message-Id: <1544332833-10369-2-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> References: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Set default window and format code at probe time instead of always checking if they have not been set yet when VIDIOC_SUBDEV_G_FMT ioctl is called. This change simplifies the next patch (make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY). Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov2640.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index d8e91bc..a07e6f2 100644 --- a/drivers/media/i2c/ov2640.c +++ b/drivers/media/i2c/ov2640.c @@ -842,9 +842,6 @@ static int ov2640_set_params(struct i2c_client *client, u8 val; int ret; - if (!win) - return -EINVAL; - switch (code) { case MEDIA_BUS_FMT_RGB565_2X8_BE: dev_dbg(&client->dev, "%s: Selected cfmt RGB565 BE", __func__); @@ -929,10 +926,6 @@ static int ov2640_get_fmt(struct v4l2_subdev *sd, if (format->pad) return -EINVAL; - if (!priv->win) { - priv->win = ov2640_select_win(SVGA_WIDTH, SVGA_HEIGHT); - priv->cfmt_code = MEDIA_BUS_FMT_UYVY8_2X8; - } mf->width = priv->win->width; mf->height = priv->win->height; @@ -1193,6 +1186,9 @@ static int ov2640_probe(struct i2c_client *client, if (ret) goto err_clk; + priv->win = ov2640_select_win(SVGA_WIDTH, SVGA_HEIGHT); + priv->cfmt_code = MEDIA_BUS_FMT_UYVY8_2X8; + v4l2_i2c_subdev_init(&priv->subdev, client, &ov2640_subdev_ops); priv->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; From patchwork Sun Dec 9 05:20:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 10719831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D8D2014E2 for ; Sun, 9 Dec 2018 05:20:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC4DC2864E for ; Sun, 9 Dec 2018 05:20:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0F192AB0D; Sun, 9 Dec 2018 05:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3DB52864E for ; Sun, 9 Dec 2018 05:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbeLIFUu (ORCPT ); Sun, 9 Dec 2018 00:20:50 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36900 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbeLIFUu (ORCPT ); Sun, 9 Dec 2018 00:20:50 -0500 Received: by mail-pf1-f195.google.com with SMTP id y126so3815977pfb.4 for ; Sat, 08 Dec 2018 21:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=70DbESgLDPFe2SN/wMlNagvbRhufvVJ1zpuon0k3zRQ=; b=LJ8kN6U46vCZZOQ1fWrWWjrLQTfDoD/CC1w0CRiNr32iQF34iGbE/mJmefRo0Rx1qP 62bOrCgO8Ykjuy4+UODoc32ot582o3g9c/XVEmH+myYQsS7WsJTnADiLDa5P6R4zja7a 1EWASXEm/lGFpjhTPX+LXWLSB42EUIsN/rBIB7K/TBzdGmj4RqWZ5IJ5oP+N5xsQg2iY FyAfrItNhRl07eYLzj04GGnjwWfDmLvHECPUEchVFgEa3+y9AjQeK5/I44dL8ERMcgpq 2JwIe4dRBynzfcWIWy5OQg0OM31h8PPk4ZJRjOqvmawZverA8PEJ3aJnsCpEHyUjGVWU Gzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=70DbESgLDPFe2SN/wMlNagvbRhufvVJ1zpuon0k3zRQ=; b=OaBEt0TNd54KTaSStXE8FElkuSWMicHlUQSQvBHUHbr9v0sdRotpMY/EG581JHKSrB 7cf8WEvw/JOU26TDhyCGefY19t1+DqO/C5paMKdXk/JtRVlUpV+6kZ5AqnyXZLo4Se+A qFs+iMqpwL36kTGg4cTorl/rI03C7gaU7vy+bJ9ThjZh/XO9PPki/gH4RRkGzeKRDIyu hwK+vzNXnrmT36NvMlvbPfXBzCP6bDCX2R52eMuVvYLPSqxmXNyFzjZTcrNkkl7o9Hyn 8Brj6fOglPnL18QOFbcynPTni/1x0S78XClFvhLthSDnV4aeG3AjONR6akzSxCKGVME0 pH3g== X-Gm-Message-State: AA+aEWaCocUl7+oGsHvWh/jpkz8jUnl1doKl0LqXhgryU0HJvv3slZgj C8lBpaHysxTSb6dRMwUKI+166v9PKJY= X-Google-Smtp-Source: AFSGD/WSlufX40RFujwqjCBprMk7vGQ0ahNZXk3mYQVnmnq5gG+/FIOyoLzKGTyP7BnWeUaviNOUaA== X-Received: by 2002:a65:4b82:: with SMTP id t2mr6982116pgq.189.1544332849162; Sat, 08 Dec 2018 21:20:49 -0800 (PST) Received: from localhost.localdomain ([240f:34:212d:1:a17f:ba11:defa:e2d1]) by smtp.gmail.com with ESMTPSA id v14sm14973270pgf.3.2018.12.08.21.20.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 08 Dec 2018 21:20:48 -0800 (PST) From: Akinobu Mita To: linux-media@vger.kernel.org Cc: Akinobu Mita , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH v2 2/3] media: ov2640: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY Date: Sun, 9 Dec 2018 14:20:32 +0900 Message-Id: <1544332833-10369-3-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> References: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE is specified. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - fix build error when CONFIG_VIDEO_V4L2_SUBDEV_API is not defined, reported by kbuild test robot. drivers/media/i2c/ov2640.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index a07e6f2..84b1b15 100644 --- a/drivers/media/i2c/ov2640.c +++ b/drivers/media/i2c/ov2640.c @@ -926,6 +926,15 @@ static int ov2640_get_fmt(struct v4l2_subdev *sd, if (format->pad) return -EINVAL; + if (format->which == V4L2_SUBDEV_FORMAT_TRY) { +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API + mf = v4l2_subdev_get_try_format(sd, cfg, 0); + format->format = *mf; + return 0; +#else + return -ENOTTY; +#endif + } mf->width = priv->win->width; mf->height = priv->win->height; @@ -992,6 +1001,27 @@ static int ov2640_set_fmt(struct v4l2_subdev *sd, return ret; } +static int ov2640_init_cfg(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg) +{ +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API + struct i2c_client *client = v4l2_get_subdevdata(sd); + struct ov2640_priv *priv = to_ov2640(client); + struct v4l2_mbus_framefmt *try_fmt = + v4l2_subdev_get_try_format(sd, cfg, 0); + + try_fmt->width = priv->win->width; + try_fmt->height = priv->win->height; + try_fmt->code = priv->cfmt_code; + try_fmt->colorspace = V4L2_COLORSPACE_SRGB; + try_fmt->field = V4L2_FIELD_NONE; + try_fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; + try_fmt->quantization = V4L2_QUANTIZATION_DEFAULT; + try_fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT; +#endif + return 0; +} + static int ov2640_enum_mbus_code(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, struct v4l2_subdev_mbus_code_enum *code) @@ -1101,6 +1131,7 @@ static const struct v4l2_subdev_core_ops ov2640_subdev_core_ops = { }; static const struct v4l2_subdev_pad_ops ov2640_subdev_pad_ops = { + .init_cfg = ov2640_init_cfg, .enum_mbus_code = ov2640_enum_mbus_code, .get_selection = ov2640_get_selection, .get_fmt = ov2640_get_fmt, From patchwork Sun Dec 9 05:20:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 10719833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 37EA813AF for ; Sun, 9 Dec 2018 05:20:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A5A02AA8B for ; Sun, 9 Dec 2018 05:20:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1DCD02AB0E; Sun, 9 Dec 2018 05:20:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C64E12AB07 for ; Sun, 9 Dec 2018 05:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726085AbeLIFUw (ORCPT ); Sun, 9 Dec 2018 00:20:52 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43430 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbeLIFUw (ORCPT ); Sun, 9 Dec 2018 00:20:52 -0500 Received: by mail-pf1-f195.google.com with SMTP id w73so3801184pfk.10 for ; Sat, 08 Dec 2018 21:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lsvy49nH5IXtq41XXl8DV28el6imeukEJl4FbYDY1Ck=; b=U0m1/tUjrvEUwqFoMYWT4qtnl8ZsCil13Fuyityv3ORXowUK+Udm3uwhdG8mMUUHN0 VN3J3jLFOjKPHniB+36N0cvILunqt13+fKP6LPldXzfVt3XdT8u/O7FtC2HU3p/GNqtq Xifo/ar5UheCcy1Pi29wnGDf45chYYGZIhzxxCDj0r2lwNoMpe+P9NkoPIeFlmCiJmVT z3W/EU0wulJGttjvKx7NDVznHZG+bFxx3SaOLJ0GmstagiiQ7OmItAeDX2hKDLOkdYNG 2otKJenXYw9zHVvWBU1IU7yEkgNiDfwXmeSiY0KHKZ/2LSu0RrxRBdzoQEZNO7jKamDL snOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lsvy49nH5IXtq41XXl8DV28el6imeukEJl4FbYDY1Ck=; b=RjEBcvCVaa9P6kEszcbiDca90hVABoWiXi3NQlpIO7qmU0aRbLn39HbF6d0EwxBeLE qYPRqETo8q22v5N7XepGRf94viXzwNuKdnTggSAiyymOsQrEDMcw7PHOEGMsrVdDL1zx lqgY/7DlKMAYatr810uc1CzT78/0/saril3ZgZMgFagoHlwKOqXgjFLczIRlXEOK8xW7 sucq+CctFLvhsa+mjeoxAtZkblLlwnO3uac1ItwjHIR6TxRtgmyCbl7pWBzeZonxBswh 6qil1JZC6v5hAYDiEe0aqPMvp8OhKEChqYbOhgGR47MAfZg06r/CTUwJZDIh4RyQHKSl wg9Q== X-Gm-Message-State: AA+aEWat8KOISJSUGLVkq7LVGb1D/LKC88IFg8YmMf1C4UesNVbAPG0P FrTtyIryA+GmBZ9T1d4CcXa49l2genQ= X-Google-Smtp-Source: AFSGD/XXWZN6BKW4z/O+Y6KTdqkl+eEc8LvnZ572sqccQUVAcGPoVOdjGeTDWLe/snITf2rHrMEYbQ== X-Received: by 2002:a63:4e41:: with SMTP id o1mr7121424pgl.282.1544332851170; Sat, 08 Dec 2018 21:20:51 -0800 (PST) Received: from localhost.localdomain ([240f:34:212d:1:a17f:ba11:defa:e2d1]) by smtp.gmail.com with ESMTPSA id v14sm14973270pgf.3.2018.12.08.21.20.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 08 Dec 2018 21:20:50 -0800 (PST) From: Akinobu Mita To: linux-media@vger.kernel.org Cc: Akinobu Mita , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH v2 3/3] media: ov2640: set all mbus format field when G_FMT and S_FMT ioctls Date: Sun, 9 Dec 2018 14:20:33 +0900 Message-Id: <1544332833-10369-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> References: <1544332833-10369-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This driver doesn't set all members of mbus format field when the VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. This is detected by v4l2-compliance. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov2640.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index 84b1b15..09325da 100644 --- a/drivers/media/i2c/ov2640.c +++ b/drivers/media/i2c/ov2640.c @@ -941,6 +941,9 @@ static int ov2640_get_fmt(struct v4l2_subdev *sd, mf->code = priv->cfmt_code; mf->colorspace = V4L2_COLORSPACE_SRGB; mf->field = V4L2_FIELD_NONE; + mf->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; + mf->quantization = V4L2_QUANTIZATION_DEFAULT; + mf->xfer_func = V4L2_XFER_FUNC_DEFAULT; return 0; } @@ -967,6 +970,9 @@ static int ov2640_set_fmt(struct v4l2_subdev *sd, mf->field = V4L2_FIELD_NONE; mf->colorspace = V4L2_COLORSPACE_SRGB; + mf->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; + mf->quantization = V4L2_QUANTIZATION_DEFAULT; + mf->xfer_func = V4L2_XFER_FUNC_DEFAULT; switch (mf->code) { case MEDIA_BUS_FMT_RGB565_2X8_BE: