From patchwork Sun Dec 9 08:04:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 10719981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F65914E2 for ; Sun, 9 Dec 2018 11:42:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E58712A6F7 for ; Sun, 9 Dec 2018 11:42:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D288B2A6F9; Sun, 9 Dec 2018 11:42:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CCAB2A6F7 for ; Sun, 9 Dec 2018 11:42:49 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 8F8B92678D5; Sun, 9 Dec 2018 09:04:33 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1EF0926796C; Sun, 9 Dec 2018 09:04:32 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by alsa0.perex.cz (Postfix) with ESMTP id EB88A26751A for ; Sun, 9 Dec 2018 09:04:27 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id a14so3764413plm.12 for ; Sun, 09 Dec 2018 00:04:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/jh92Uph5nOHxk7hIf9Z7QMf0oSAWHM/I1bZlZSkblo=; b=gWqYH8NGlrgdgQe9zomLxCbH+EXXnP3lIowNpBCtg6tLDVAjDILx1LyAxZ9hfQgfiR WEdVOVcvjsVaiKhNCIAiQAd169X2s5a1R6C+aQlBNLhsYEQJkfr0RMnvLFsuJOY670pf DFzA0EfbN4/mi2iUcWeKzU6LIgZsLrqLd5WuGFGldLwFiygRnvm0UOfk5IN3iRGAEyuX qCb3COXSSKMoVbpuTD3+PjTCwtj4vNs1Oi0q/yvXUS1gAvSTil9oveLlaJiRB9gPAssD wwN5U6Bif7rvEH/KFNdkDEAx9awzAEDIeu3DsUk+ZY6S4bdled6rNpUmtlV9OFcLmaYT EA8g== X-Gm-Message-State: AA+aEWYwn0BJehAa/ruF5JnxGgw4vmgkNash4LW2kn4yJtjjdPrdlenM irxUqktWoP/SCe17W/WvDR8ToB0R X-Google-Smtp-Source: AFSGD/WHAqi+TqbPeHaDcEeG+N2o3gJwHPyZlS8WOxo+AYTJe6A15yfBBodUXBJGV90WrxNRmkVHYA== X-Received: by 2002:a17:902:8346:: with SMTP id z6mr7927344pln.340.1544342666899; Sun, 09 Dec 2018 00:04:26 -0800 (PST) Received: from localhost.localdomain ([2405:6580:9660:3200:78c8:dfdd:d907:679f]) by smtp.gmail.com with ESMTPSA id p67sm17130864pfi.85.2018.12.09.00.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Dec 2018 00:04:26 -0800 (PST) From: Takashi Sakamoto To: clemens@ladisch.de, tiwai@suse.de Date: Sun, 9 Dec 2018 17:04:19 +0900 Message-Id: <20181209080419.9554-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: [alsa-devel] [PATCH] ALSA: fireface: fix reference to wrong register for clock configuration X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP In an initial commit, 'SYNC_STATUS' register is referred to get clock configuration, however this is wrong, according to my local note at hand for reverse-engineering about packet dump. It should be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config() is correctly programmed. This commit fixes the bug. Cc: # v4.12+ Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400') Signed-off-by: Takashi Sakamoto --- sound/firewire/fireface/ff-protocol-ff400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/fireface/ff-protocol-ff400.c b/sound/firewire/fireface/ff-protocol-ff400.c index 64c3cb0fb926..654a50319198 100644 --- a/sound/firewire/fireface/ff-protocol-ff400.c +++ b/sound/firewire/fireface/ff-protocol-ff400.c @@ -30,7 +30,7 @@ static int ff400_get_clock(struct snd_ff *ff, unsigned int *rate, int err; err = snd_fw_transaction(ff->unit, TCODE_READ_QUADLET_REQUEST, - FF400_SYNC_STATUS, ®, sizeof(reg), 0); + FF400_CLOCK_CONFIG, ®, sizeof(reg), 0); if (err < 0) return err; data = le32_to_cpu(reg);