From patchwork Mon Aug 30 10:39:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 12464905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC8FC432BE for ; Mon, 30 Aug 2021 10:43:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1E606023E for ; Mon, 30 Aug 2021 10:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A1E606023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1JLYRvtdwy5NxhxXl63o/WfYpH9kWLfkYbKnkGGNDkY=; b=D4vvXfOasv8ohb tR6AUlSq+Lb3Q0Zt55uxzw5mHZKR+A3EElYsldO6/Lzh+WbvWWOWnBinZ83iSgSkashaEprg7gkZi 1ff30GFFbFzZVdKHjrvg5TGqYTwQxcTlaE/IcBes3UnWY4TWh3RtKkpMzSzCB8ucz/cAEuqitYN/3 3YmyrAa8j6uYZh+tMtsQwT04cU6wYaZ0O18WMpzJYa+FHXYyV13LmvARp9hjSzYyxdXfvEC9aTaZ0 ipQRZy0BgRJD12bQofKjudh2mm+TARCHQoGjBRCeLobg5FH0ipwgxdmVETYs+O/1+49ScdJ0Wevat /7tixB/Eaq+IWfcbFvdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKehg-00H0au-0s; Mon, 30 Aug 2021 10:39:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKehO-00H0ZV-2U for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 10:39:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630319967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9UdhdlCXAumNKGumRgixdjPkcUszwAPFwDnuB62lb9Y=; b=XYk9fzDfkjmtc5koe2YeTZXFLdbGKasuUF8waLsjVM93iGi1c2wM7hMgwfeJ3itUzu59Wa BjZg6lwUqKfUTk2ICOzfpBu+XgnE52lbhgjYofn8kpEroKKyoJfxwS55bYqbGRYr5izD5c H0mVHLnBo03/XZly/J+2luqjslzmUcA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-CFZ7sCWiPeKw8wa__BFlCw-1; Mon, 30 Aug 2021 06:39:25 -0400 X-MC-Unique: CFZ7sCWiPeKw8wa__BFlCw-1 Received: by mail-wm1-f72.google.com with SMTP id f17-20020a05600c155100b002f05f30ff03so2187996wmg.3 for ; Mon, 30 Aug 2021 03:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9UdhdlCXAumNKGumRgixdjPkcUszwAPFwDnuB62lb9Y=; b=Jx+THx6u4KrIMsZKbnvdNBent8wQDLMqUsGeJ6ZKGyTUa/5PFSWIhU/83sr6S0Gq9s j+68cafk9XNRjOz+Y8XIn5znwpQPoIVV6DBl0pWCz16f0U/wX94b9Ohv38SrHBng8TTe W1BdzBRCTrvHosrwxLw/Po8fNRUIOUFBBnKtbnHodPcL3OM7oiCFry795XiuL7H6XO3W z7qcNbmqiXl2bbxisx85cdu4peiJuozV63phbzFi0X2lgvkvCDSvTrXbsAz9rMMyVZBu 7T5t141T7R+k2lkD4wD6ziUfrUXhLNAyMQ/aAp6ZcWVhQbbRpITCoMlT+Az+Bm51l4kS Nl2Q== X-Gm-Message-State: AOAM5331WI5/lq35yqP8/AKZCY8iIqwY8NM79Wn0ug5eQDiIrpYwb1F0 GERYVs1jTiWX6Tr1s5bqxXxHbzxv/xEU+elnsgzf3qL/ZoNVH/anm6WyoYvZvcadu2WJbyrrcj4 ZNpA7SNB/O1UvecWef4tR/eJ2PKE6wtFmepU= X-Received: by 2002:a05:600c:1d29:: with SMTP id l41mr30280781wms.177.1630319964250; Mon, 30 Aug 2021 03:39:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwALzuPla4B1S2RZz1MtMKVuunqRTTV1sR92kQFdy2K3D+8LhOpR7gk+2lXiLEJkwumT7k36w== X-Received: by 2002:a05:600c:1d29:: with SMTP id l41mr30280771wms.177.1630319964077; Mon, 30 Aug 2021 03:39:24 -0700 (PDT) Received: from vian.redhat.com ([2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de]) by smtp.gmail.com with ESMTPSA id n18sm16594169wmc.22.2021.08.30.03.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 03:39:23 -0700 (PDT) From: Nicolas Saenz Julienne To: robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, Nicolas Saenz Julienne Subject: [PATCH] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address Date: Mon, 30 Aug 2021 12:39:09 +0200 Message-Id: <20210830103909.323356-1-nsaenzju@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=nsaenzju@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_033930_239554_0D21263F X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dtbs_check currently complains that: arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0" Unsurprisingly pci@0,0 is the right address, as illustrated by its reg property: &pcie0 { pci@0,0 { /* * As defined in the IEEE Std 1275-1994 document, * reg is a five-cell address encoded as (phys.hi * phys.mid phys.lo size.hi size.lo). phys.hi * should contain the device's BDF as 0b00000000 * bbbbbbbb dddddfff 00000000. The other cells * should be zero. */ reg = <0 0 0 0 0>; }; }; The bus is clearly 0. So fix it. Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index f24bdd0870a5..8a77f9e942be 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -217,7 +217,7 @@ phy1: ethernet-phy@1 { }; &pcie0 { - pci@1,0 { + pci@0,0 { #address-cells = <3>; #size-cells = <2>; ranges;