From patchwork Tue Aug 31 13:35:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01DEC4320E for ; Tue, 31 Aug 2021 13:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEAD860FE6 for ; Tue, 31 Aug 2021 13:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236957AbhHaNgq (ORCPT ); Tue, 31 Aug 2021 09:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236497AbhHaNgo (ORCPT ); Tue, 31 Aug 2021 09:36:44 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA84EC061575 for ; Tue, 31 Aug 2021 06:35:48 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id u16so27773733wrn.5 for ; Tue, 31 Aug 2021 06:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=coVD9R/luMgosIRRbyMg0iC14HZfpu09sgVkGJXs0+s=; b=mxuX2+PPizSaw0lYIUKuEKl2HJi3pi8Uej8fauTCaYR+0twH3hty2PykUk3e/zYryn +WkUOVO8k14FNElKRQh77UWpY5Evvaqlu5Y4cHhnMpcdsE9eedoQJ6HMCiJnXd5ctiVw RUot3nHO8jvN13gUjRAJ/v9pJ9gfOzBu5n48J12yajr2DWda6bG6hiQfMk+BUFjKO0Vn IwalKRE+fh00xWQn7xu48td5ODpfjDhIaP5SMvKXQkJvZpVGyqwRKaObm8fIhvwvJyEP q0CZXptxFsC3UeDUwtvysvXYbxZSAer6VrRhQx9SG1e8n5HnKUrqfq4IXrNsySkP/DIk ugeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=coVD9R/luMgosIRRbyMg0iC14HZfpu09sgVkGJXs0+s=; b=RpFAgRjgCaRD//aA5rVIIcefDo16MYd2NfH0G39+RnNd4XQENBLKnkNbqCQ5Z5GB0/ hCnEgO6JtdjTbv4W+o25f1P6HwIy3jgTluB3WQTpceoa5v2HY1R+IXI8geNikvh23iFI IR37o8ClJ0QgFv1QoUbHqf9DoeA5itz12hF1HPaUAYfqkvgeg+hZwZUDRBnrTUrls7+m toRqC3JSFRGgTCVNVO/EZPkLaQNQuKrONhueVapAYkwlYS9tmPxSeL2plulO3/13mMZr 3F1nY3sk04PMlseEvFR8LtQvc+5QeM1MqnCgbKtPk+WTd61kYZBRM6CmTDKXaqcjNtuZ XdoQ== X-Gm-Message-State: AOAM530gMLD0tXnPz8zEBT6ON9Z4aJN9o3rnL3DByFvbRpLIJcATbwsK HesQLnLzlV2rlcV7fM4oz/9a6RdQBnGUOg== X-Google-Smtp-Source: ABdhPJxo7CtkX7AJjf2+hm8LDrNEdCxdQqPRD69f9hsxfRSBMpO9/PpD0ivt3XdNl8BJdxphMXbzZQ== X-Received: by 2002:a5d:4591:: with SMTP id p17mr31574044wrq.57.1630416947081; Tue, 31 Aug 2021 06:35:47 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:46 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 1/8] Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONS Date: Tue, 31 Aug 2021 15:35:35 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org When SANITIZE=leak is specified we'll now add a SANITIZE_LEAK flag to GIT-BUILD-OPTIONS, this can then be picked up by the test-lib.sh, which sets a SANITIZE_LEAK prerequisite. We can then skip specific tests that are known to fail under SANITIZE=leak, add one such annotation to t0004-unwritable.sh, which now passes under SANITIZE=leak. Signed-off-by: Ævar Arnfjörð Bjarmason --- Makefile | 5 +++++ t/t0004-unwritable.sh | 2 +- t/test-lib.sh | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d1feab008fc..005d647d46e 100644 --- a/Makefile +++ b/Makefile @@ -1221,6 +1221,9 @@ PTHREAD_CFLAGS = SPARSE_FLAGS ?= SP_EXTRA_FLAGS = -Wno-universal-initializer +# For informing GIT-BUILD-OPTIONS of the SANITIZE=leak target +SANITIZE_LEAK = + # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will # usually result in less CPU usage at the cost of higher peak memory. # Setting it to 0 will feed all files in a single spatch invocation. @@ -1265,6 +1268,7 @@ BASIC_CFLAGS += -DSHA1DC_FORCE_ALIGNED_ACCESS endif ifneq ($(filter leak,$(SANITIZERS)),) BASIC_CFLAGS += -DSUPPRESS_ANNOTATED_LEAKS +SANITIZE_LEAK = YesCompiledWithIt endif ifneq ($(filter address,$(SANITIZERS)),) NO_REGEX = NeededForASAN @@ -2812,6 +2816,7 @@ GIT-BUILD-OPTIONS: FORCE @echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst ','\'',$(NO_UNIX_SOCKETS)))'\' >>$@+ @echo PAGER_ENV=\''$(subst ','\'',$(subst ','\'',$(PAGER_ENV)))'\' >>$@+ @echo DC_SHA1=\''$(subst ','\'',$(subst ','\'',$(DC_SHA1)))'\' >>$@+ + @echo SANITIZE_LEAK=\''$(subst ','\'',$(subst ','\'',$(SANITIZE_LEAK)))'\' >>$@+ @echo X=\'$(X)\' >>$@+ ifdef TEST_OUTPUT_DIRECTORY @echo TEST_OUTPUT_DIRECTORY=\''$(subst ','\'',$(subst ','\'',$(TEST_OUTPUT_DIRECTORY)))'\' >>$@+ diff --git a/t/t0004-unwritable.sh b/t/t0004-unwritable.sh index e3137d638ee..fbdcb926b3a 100755 --- a/t/t0004-unwritable.sh +++ b/t/t0004-unwritable.sh @@ -21,7 +21,7 @@ test_expect_success POSIXPERM,SANITY 'write-tree should notice unwritable reposi test_must_fail git write-tree ' -test_expect_success POSIXPERM,SANITY 'commit should notice unwritable repository' ' +test_expect_success POSIXPERM,SANITY,!SANITIZE_LEAK 'commit should notice unwritable repository' ' test_when_finished "chmod 775 .git/objects .git/objects/??" && chmod a-w .git/objects .git/objects/?? && test_must_fail git commit -m second diff --git a/t/test-lib.sh b/t/test-lib.sh index abcfbed6d61..4ab18914a3d 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1533,6 +1533,7 @@ test -z "$NO_PYTHON" && test_set_prereq PYTHON test -n "$USE_LIBPCRE2" && test_set_prereq PCRE test -n "$USE_LIBPCRE2" && test_set_prereq LIBPCRE2 test -z "$NO_GETTEXT" && test_set_prereq GETTEXT +test -n "$SANITIZE_LEAK" && test_set_prereq SANITIZE_LEAK if test -z "$GIT_TEST_CHECK_CACHE_TREE" then From patchwork Tue Aug 31 13:35:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7F9C4320A for ; Tue, 31 Aug 2021 13:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EB9860462 for ; Tue, 31 Aug 2021 13:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237165AbhHaNgr (ORCPT ); Tue, 31 Aug 2021 09:36:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236733AbhHaNgp (ORCPT ); Tue, 31 Aug 2021 09:36:45 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32594C061575 for ; Tue, 31 Aug 2021 06:35:50 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id c129-20020a1c35870000b02902e6b6135279so2632160wma.0 for ; Tue, 31 Aug 2021 06:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6+uQqfMk30ReBKcI9toiWoTbuAOCXFdtzq1CGzD8Yec=; b=q9x/AWYeXuoZwm4t3PyQw5HdsV4M/JkLaoYEzqjP0elDXPg7mgecG+L0hSZCg4TgPA 1DXltOViW/uiCuSoV+97wTXpEHbUp25lFHqsR6QITRZFHARWpJUhoR5LB/0JnWNKpHeJ bhxYR+xm5NaZtDdON3dS7nDbw+kut7X3E0C2zuftZfGsApM/xs3UGaU0jNdpOtVcCs+k padvB94SjCatP1ppB7S9l8IBXI2Y5pqPY4/YbHDhNRr2peJ/Zjt+Ey/q1N1kIoccHPoj 6Zz4PNGL8CPejI8nuMz8n7Y0kwpWMRlZOM5RrdAIYwSuYUbujORK6K7M+425FXA8Vj+e aFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6+uQqfMk30ReBKcI9toiWoTbuAOCXFdtzq1CGzD8Yec=; b=MIw/FLG4MRpAMuiida4s8IVhmXuv6gijr46L2SBlCk/rvioOu9gyx/Ue2PcMnJ/i7p beoSqK0m6pHuMNYCQ7Y8zpYtpFtjbZnNamOX0dBiUO5Lqbo39cqjQMU7ZZe3fCD0Sxyf 315hyZow85Qb680x288UgK8Mc/Rkx5+euWBBysR4RTqqp1utTVjuzwjsJBrwD2AaWf+y K4xxDUGaH59zm+ivid0468FXxKZbsdrZJV1Wx/kDpxRzUcCXbr8sZ9Xn6UCdmfeXnTZa 6TFV8nkFCHT/j0ECKg76nhb9O++DncZ4db2r193ve2kleFYhFI17SKz1HeqHeFNSPjzb P89Q== X-Gm-Message-State: AOAM531vGTqBc8Lb8UMFk8af/nYDUHWpLgpiGP4T98eGKAcR1Fg4MGp6 /yR5JtivjI9Mv1JCv3GNqHN1BMAs92cplg== X-Google-Smtp-Source: ABdhPJwv/8c6p08odA+w3m05PCuMv68CNjRVq7oKMTV9PHdRMRb+IYVa7FrD/4J2kqXvVkW6KYzAoA== X-Received: by 2002:a05:600c:4304:: with SMTP id p4mr4281393wme.18.1630416948188; Tue, 31 Aug 2021 06:35:48 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:47 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 2/8] CI: refactor "if" to "case" statement Date: Tue, 31 Aug 2021 15:35:36 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Refactor an "if" statement for "linux-gcc" to a "case" statement in preparation for another case being added to it, and do the same for the "osx-gcc" just below it for consistency. Signed-off-by: Ævar Arnfjörð Bjarmason --- ci/lib.sh | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/ci/lib.sh b/ci/lib.sh index 476c3f369f5..33b9777ab7e 100755 --- a/ci/lib.sh +++ b/ci/lib.sh @@ -184,13 +184,15 @@ export SKIP_DASHED_BUILT_INS=YesPlease case "$jobname" in linux-clang|linux-gcc) - if [ "$jobname" = linux-gcc ] - then + case "$jobname" in + linux-gcc) export CC=gcc-8 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python3" - else + ;; + *) MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python2" - fi + ;; + esac export GIT_TEST_HTTPD=true @@ -207,13 +209,15 @@ linux-clang|linux-gcc) export PATH="$GIT_LFS_PATH:$P4_PATH:$PATH" ;; osx-clang|osx-gcc) - if [ "$jobname" = osx-gcc ] - then + case "$jobname" in + osx-gcc) export CC=gcc-9 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)" - else + ;; + *) MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)" - fi + ;; + esac # t9810 occasionally fails on Travis CI OS X # t9816 occasionally fails with "TAP out of sequence errors" on From patchwork Tue Aug 31 13:35:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DECBC43216 for ; Tue, 31 Aug 2021 13:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7660E60462 for ; Tue, 31 Aug 2021 13:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236733AbhHaNgs (ORCPT ); Tue, 31 Aug 2021 09:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237006AbhHaNgq (ORCPT ); Tue, 31 Aug 2021 09:36:46 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BCEC061760 for ; Tue, 31 Aug 2021 06:35:51 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id n5so27676253wro.12 for ; Tue, 31 Aug 2021 06:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EOlWBdgIKEQxY/5QvMOqnYoNQ8ncU74Zf5cam8TkHCw=; b=n2MXbPwg31eXlQrRKJCYMs9S6b7KE92pBkSdR7r6xBw236vPfLzcnzeZWfruGTkk1K WzU90uCDVLRQuXjdiNjnhRYx3RRvVvp1lCQ2UFTVdpwOHbzVoqoL2drhDQgEEqe+ZP37 yxkxkI3zd42sYGa6bTSITGIDqa/5HsqWelSWt3ytBERsx+fw/6lvondQHYApAHw5Xunw iDBcjrzrwiyMw9eA7wcQcqZzezdQawMyftkYZSVqeySzO540OrBTJ9NRxvJ3pPQIgrKt AMqtWBJWqPrI3cCqWhImE9Lcyp6fcV3/UZQ54McQ+lld2rYiTolwmlKvBZCrch4gGnwM LiMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EOlWBdgIKEQxY/5QvMOqnYoNQ8ncU74Zf5cam8TkHCw=; b=nPnHmGEpkF9Q6TH2Q8dBs4RYz5m+Uhimk3JqpHlwb82gyuVrcDnfUTgeHjRx0Sq5Vn bhgx+Sf1cLkZ1h4s5BEhNp++D1TLv5REnWhFVKC6FKHpoQAjzhrwpmup7vSM5xLzU9NI 6BcstdacPH6QRrfih6KAIRo6WQRVCh7fs4CR449qMhE1Z9PBgbGDvutqIku2tGmAtgFw F3npYhWzEK1VAa8XEvmu9GWZUWG8fgxyXKfMfQs0DM67/+fM4oosxkn6DpTJwkn/FyAU Gxy9sG/mA5LLk1pQT5bIOA55lI3TCm5lYokp9IWvrSN0BSN75tByTzkcDctxy2Fp58Ix bdOg== X-Gm-Message-State: AOAM533RriBnEsuh+XCY7zfpYkWuwJeQFpyS96BIioql2QzN43vrCLI+ VEJQffeTr6K9uDljMPA9NGi08UNNv/jyUg== X-Google-Smtp-Source: ABdhPJwmI5etsKLDAGCvYItQo5brVj0At83oweUhokSNKMQ/aKff29+67y5AXFotbTptW5mpl2sUnQ== X-Received: by 2002:adf:9e48:: with SMTP id v8mr14973209wre.141.1630416949767; Tue, 31 Aug 2021 06:35:49 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:49 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 3/8] tests: add a test mode for SANITIZE=leak, run it in CI Date: Tue, 31 Aug 2021 15:35:37 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org While git can be compiled with SANITIZE=leak there has been no corresponding GIT_TEST_* mode for it, i.e. memory leaks have been fixed as one-offs without structured regression testing. This change add such a mode, and a new linux-SANITIZE=leak CI target. The test mode and CI target only runs a whitelist of known-good tests using a mechanism discussed below, to ensure that we won't add regressions to code that's had its memory leaks fixed. The CI target uses a new GIT_TEST_PASSING_SANITIZE_LEAK=true test mode. When running in that mode all tests except those that have opted themselves in to running by setting and exporting TEST_PASSES_SANITIZE_LEAK=true before sourcing test-lib.sh. I'm adding a "test-pragma-SANITIZE=leak-ok.sh" wrapper for setting and exporting that variable, as the assignment/export boilerplate would otherwise get quite verbose and repetitive in subsequent commits. The tests using the "test-pragma-SANITIZE=leak-ok.sh" pragma can in turn make use of the "SANITIZE_LEAK" prerequisite added in a preceding commit, should they wish to selectively skip tests even under "GIT_TEST_PASSING_SANITIZE_LEAK=true". Now tests that don't set the "test-pragma-SANITIZE=leak-ok.sh" pragma will be skipped under GIT_TEST_PASSING_SANITIZE_LEAK=true: $ GIT_TEST_PASSING_SANITIZE_LEAK=true ./t0001-init.sh 1..0 # SKIP skip all tests in t0001 under SANITIZE=leak, TEST_PASSES_SANITIZE_LEAK not set In subsequents commit we'll conservatively add more TEST_PASSES_SANITIZE_LEAK=true annotations. The idea is that as memory leaks are fixed we can add more known-good tests to this CI target, to ensure that we won't have regressions. As of writing this we've got major regressions between master..seen, i.e. the t000*.sh tests and more fixed since 31f9acf9ce2 (Merge branch 'ah/plugleaks', 2021-08-04) have regressed recently. See the discussion at <87czsv2idy.fsf@evledraar.gmail.com> about the lack of this sort of test mode, and 0e5bba53af (add UNLEAK annotation for reducing leak false positives, 2017-09-08) for the initial addition of SANITIZE=leak. See also 09595ab381 (Merge branch 'jk/leak-checkers', 2017-09-19), 7782066f67 (Merge branch 'jk/apache-lsan', 2019-05-19) and the recent 936e58851a (Merge branch 'ah/plugleaks', 2021-05-07) for some of the past history of "one-off" SANITIZE=leak (and more) fixes. Signed-off-by: Ævar Arnfjörð Bjarmason --- .github/workflows/main.yml | 2 ++ ci/install-dependencies.sh | 4 ++-- ci/lib.sh | 11 +++++++++-- ci/run-build-and-tests.sh | 4 ++-- t/README | 7 +++++++ t/t0000-basic.sh | 1 + t/test-lib.sh | 21 +++++++++++++++++++++ t/test-pragma-SANITIZE=leak-ok.sh | 8 ++++++++ 8 files changed, 52 insertions(+), 6 deletions(-) create mode 100644 t/test-pragma-SANITIZE=leak-ok.sh diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 47876a4f02e..d11b971f970 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -232,6 +232,8 @@ jobs: - jobname: linux-gcc-default cc: gcc pool: ubuntu-latest + - jobname: linux-SANITIZE=leak + pool: ubuntu-latest env: CC: ${{matrix.vector.cc}} jobname: ${{matrix.vector.jobname}} diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 5772081b6e5..30276ae1e00 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -12,13 +12,13 @@ UBUNTU_COMMON_PKGS="make libssl-dev libcurl4-openssl-dev libexpat-dev libemail-valid-perl libio-socket-ssl-perl libnet-smtp-ssl-perl" case "$jobname" in -linux-clang|linux-gcc) +linux-clang|linux-gcc|linux-SANITIZE=leak) sudo apt-add-repository -y "ppa:ubuntu-toolchain-r/test" sudo apt-get -q update sudo apt-get -q -y install language-pack-is libsvn-perl apache2 \ $UBUNTU_COMMON_PKGS case "$jobname" in - linux-gcc) + linux-gcc|linux-SANITIZE=leak) sudo apt-get -q -y install gcc-8 ;; esac diff --git a/ci/lib.sh b/ci/lib.sh index 33b9777ab7e..d86b83ed203 100755 --- a/ci/lib.sh +++ b/ci/lib.sh @@ -183,9 +183,9 @@ export GIT_TEST_CLONE_2GB=true export SKIP_DASHED_BUILT_INS=YesPlease case "$jobname" in -linux-clang|linux-gcc) +linux-clang|linux-gcc|linux-SANITIZE=leak) case "$jobname" in - linux-gcc) + linux-gcc|linux-SANITIZE=leak) export CC=gcc-8 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python3" ;; @@ -237,4 +237,11 @@ linux-musl) ;; esac +case "$jobname" in +linux-SANITIZE=leak) + export SANITIZE=leak + export GIT_TEST_PASSING_SANITIZE_LEAK=true + ;; +esac + MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}" diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index 3ce81ffee94..f0b9775b6c7 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh @@ -12,7 +12,7 @@ esac make case "$jobname" in -linux-gcc) +linux-gcc|linux-SANITIZE=leak) export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main make test export GIT_TEST_SPLIT_INDEX=yes @@ -29,7 +29,7 @@ linux-gcc) export GIT_TEST_CHECKOUT_WORKERS=2 make test ;; -linux-clang) +linux-clang|linux-SANITIZE=leak) export GIT_TEST_DEFAULT_HASH=sha1 make test export GIT_TEST_DEFAULT_HASH=sha256 diff --git a/t/README b/t/README index 9e701223020..f5dfac568d1 100644 --- a/t/README +++ b/t/README @@ -448,6 +448,13 @@ GIT_TEST_CHECKOUT_WORKERS= overrides the 'checkout.workers' setting to and 'checkout.thresholdForParallelism' to 0, forcing the execution of the parallel-checkout code. +GIT_TEST_PASSING_SANITIZE_LEAK= when compiled with +SANITIZE=leak will run only those tests that have whitelisted +themselves as passing with no memory leaks. Do this by sourcing +"test-pragma-SANITIZE=leak-ok.sh" before sourcing "test-lib.sh" itself +at the top of the test script. This test mode is used by the +"linux-SANITIZE=leak" CI target. + Naming Tests ------------ diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index cb87768513c..14836c97cc6 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -18,6 +18,7 @@ swapping compression and hashing order, the person who is making the modification *should* take notice and update the test vectors here. ' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh try_local_xy () { diff --git a/t/test-lib.sh b/t/test-lib.sh index 4ab18914a3d..332dd59257d 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1379,6 +1379,27 @@ then test_done fi +# Aggressively skip non-whitelisted tests when compiled with +# SANITIZE=leak +if test -n "$SANITIZE_LEAK" +then + if test_bool_env GIT_TEST_PASSING_SANITIZE_LEAK false + then + # We need to see it in "git env--helper" (via + # test_bool_env) + export TEST_PASSES_SANITIZE_LEAK + + if ! test_bool_env TEST_PASSES_SANITIZE_LEAK false + then + skip_all="skipping $this_test under GIT_TEST_PASSING_SANITIZE_LEAK=true" + test_done + fi + fi +elif test_bool_env GIT_TEST_PASSING_SANITIZE_LEAK false +then + error "GIT_TEST_PASSING_SANITIZE_LEAK=true has no effect except when compiled with SANITIZE=leak" +fi + # Last-minute variable setup HOME="$TRASH_DIRECTORY" GNUPGHOME="$HOME/gnupg-home-not-used" diff --git a/t/test-pragma-SANITIZE=leak-ok.sh b/t/test-pragma-SANITIZE=leak-ok.sh new file mode 100644 index 00000000000..5f03397075d --- /dev/null +++ b/t/test-pragma-SANITIZE=leak-ok.sh @@ -0,0 +1,8 @@ +#!/bin/sh + +## This "pragma" (as in "perldoc perlpragma") declares that the test +## will pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. Source this +## before sourcing test-lib.sh + +TEST_PASSES_SANITIZE_LEAK=true +export TEST_PASSES_SANITIZE_LEAK From patchwork Tue Aug 31 13:35:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18461C432BE for ; Tue, 31 Aug 2021 13:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEBF760462 for ; Tue, 31 Aug 2021 13:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237306AbhHaNgt (ORCPT ); Tue, 31 Aug 2021 09:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237099AbhHaNgr (ORCPT ); Tue, 31 Aug 2021 09:36:47 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601BCC061760 for ; Tue, 31 Aug 2021 06:35:52 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id j14-20020a1c230e000000b002e748b9a48bso1918719wmj.0 for ; Tue, 31 Aug 2021 06:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fMIUUqpRmcOIVsAmoPZUiQSn77rxtiKG7esDDCKFh4U=; b=aaof8rew+9gMVlY97agn7BZ31Wcl/SWE2YEtQjZ+XSw6AFADJJRdDKlPbbsFvf8hQS JxWGY6DRiI8bL/5rZYP3UEMF9rX+B7Sr2MZwkucfBv3pE0nhTo2+kIyWbqMdSd32TVwV 9GyWqY5WEqaE6bl+KqqZDHoZC57icQe2xHDNkRs5+y9+4YdUtCxAp1eRZPBiyZwbaKUN 4rH4tL3cezxOcwOhbk+vkntaqY2CmD2d0RNwEHStxTNt+IIXkSX4Tnd5QgdK4enT6J1e h/q4X9dhk8UaTHtJvi7Ba5i5ML0GM4e5tHXfRVvUV04xuX3e8N4UC5xohG9gRktikkvA aPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fMIUUqpRmcOIVsAmoPZUiQSn77rxtiKG7esDDCKFh4U=; b=XDmQVrMM4vV2VDVqYbV6vOSVjV6x6SNfobv1OsQ8Y1Xbo5TCahz75YysNgAMb/+d+W mJBoPVz7ZLZYam8wAi90m/z83P5DTAZLVst/MjoJ8X9k0lUeBldKpGYAC1eCfww6+9lS xDtSM6OVfUbD93tyd8Rg1SgHdvhk0JigugOsaF/WmuMwGHgvpn0MHJabEP+/reARuc6F 3Z3jFmqevX+C5Lm84B2B1g6aH92wWlTRyU7+u2egs5Q9fZCcY/7U0Xt8sNRa4Y7f7nlI 8SUqaDeGoma22mnOUJY3VzywCErfdgsBVrNMJ4VhwwWuVa+5H6RKuZ6+309PEdLDYr/v Xhvg== X-Gm-Message-State: AOAM532OwHIEMy03CnxtY3yE81TFlfdav16LsOlXhYiOKjsW0aMBc0E0 6QBPNnvhmjdl5ugqWqham6AFL3eVMuUDWQ== X-Google-Smtp-Source: ABdhPJzR3BznlUSWfDle/Vkxz1YIXY8lrBMA32Q3QPXTk18Nz4gKt2TJ/X1b8ukKy8G5g7rSOY3GXQ== X-Received: by 2002:a05:600c:a05:: with SMTP id z5mr4404677wmp.73.1630416950702; Tue, 31 Aug 2021 06:35:50 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:50 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 4/8] tests: annotate t000*.sh with TEST_PASSES_SANITIZE_LEAK=true Date: Tue, 31 Aug 2021 15:35:38 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Annotate the t000*.sh tests that pass under SANITIZE=leak, these tests now pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. We skip t0006-date.sh and t0009-prio-queue.sh due to outstanding memory leaks. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t0001-init.sh | 1 + t/t0002-gitfile.sh | 1 + t/t0003-attributes.sh | 1 + t/t0004-unwritable.sh | 1 + t/t0005-signals.sh | 2 ++ t/t0007-git-var.sh | 2 ++ t/t0008-ignores.sh | 1 + 7 files changed, 9 insertions(+) diff --git a/t/t0001-init.sh b/t/t0001-init.sh index df544bb321f..8ce04bcabd2 100755 --- a/t/t0001-init.sh +++ b/t/t0001-init.sh @@ -2,6 +2,7 @@ test_description='git init' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh check_config () { diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh index 8440e6add12..3dcb3d16944 100755 --- a/t/t0002-gitfile.sh +++ b/t/t0002-gitfile.sh @@ -7,6 +7,7 @@ Verify that plumbing commands work when .git is a file GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh objpath() { diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 1e4c672b84a..4ef24a35ab5 100755 --- a/t/t0003-attributes.sh +++ b/t/t0003-attributes.sh @@ -2,6 +2,7 @@ test_description=gitattributes +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh attr_check_basic () { diff --git a/t/t0004-unwritable.sh b/t/t0004-unwritable.sh index fbdcb926b3a..35571947ec5 100755 --- a/t/t0004-unwritable.sh +++ b/t/t0004-unwritable.sh @@ -2,6 +2,7 @@ test_description='detect unwritable repository and fail correctly' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success setup ' diff --git a/t/t0005-signals.sh b/t/t0005-signals.sh index 4c214bd11c4..cd3ecf403e0 100755 --- a/t/t0005-signals.sh +++ b/t/t0005-signals.sh @@ -1,6 +1,8 @@ #!/bin/sh test_description='signals work as we expect' + +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh cat >expect < X-Patchwork-Id: 12467249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CB3C432BE for ; Tue, 31 Aug 2021 13:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F58760F6B for ; Tue, 31 Aug 2021 13:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237622AbhHaNgx (ORCPT ); Tue, 31 Aug 2021 09:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237238AbhHaNgs (ORCPT ); Tue, 31 Aug 2021 09:36:48 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C11C061760 for ; Tue, 31 Aug 2021 06:35:53 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso2586110wmi.5 for ; Tue, 31 Aug 2021 06:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NkaMF66/gxPvxQklQ1iRKnwee5Pfa5Lmuwpu9cV8T/4=; b=a1bDW0b8peV7P78p8LbLTmFjHpmX2P1WarTxD8rNupudD1P1vp11yaZGgsY+xvIbEr 6BxBy8FDjoPRJr3UetVBk2ps1dZOV43rJFxeWdP9dNyWEQtDONg9/K7bZ0BYCYM1QKnc MpRCHWJo2qjGes0hmnyghCnSn9GIa12/0TryMTst9oBviqGT8Ct/UOg6fjisII85j3vA aOuDaV/fXVSCShkPzxy7jqaKelP6fu4COyN6yreryjuxiyJ0oCvYyYKl2OSkqgRmBw3o DOrpVcIIQPD+p1yV0Vn8wwQZttiJUbbclYq1xFgtvkY9Q5Vlj2hE8zn92q7HCZROt/2+ ci9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NkaMF66/gxPvxQklQ1iRKnwee5Pfa5Lmuwpu9cV8T/4=; b=rF/gOn9srr0g5yfOQNVQ31+8AknhWe+VGadxl89ttizBtiN8hqcicNFrTAXN07nL8P KYs4NCyIjLqj4cx1I0GdbRq3LmWkuO9gFXCIYGSV3QbCBRJ1zuZ3HLJMHCprToc1PFhQ zowj46JEL84iOP/HURDVX707CR1z75MnGCL1gZGdoruC0LOWXTGX0iqZMZtfAHdJYb7n thztn6ZnczLaNYInN4bNC4mVKyfcpIdkDyq8aIzKwujqpC14uBavWmaX2AvfOOV9WyH/ i8R5pe9qliEYsINMTKhKVu10jz6kkZ0Xcavh79RE3P35u2mLNazjOd5f0ow0Kk9Le/ye zHRQ== X-Gm-Message-State: AOAM5312gU/7+TwmJNa//gSAZTzdGXdbBbKSGpgaWAG1iVVSQsbTOObA uvgfCSHzlCGzDBsIWUy7UsmcJONAXwi7Ow== X-Google-Smtp-Source: ABdhPJwFOeFYs3dY0xOCF7MEzAo6C5SQAvtdeD7IurciLbJLcZHLeIbXpWWGL2tb9hXMkuiNH+hfWw== X-Received: by 2002:a05:600c:1912:: with SMTP id j18mr4362120wmq.29.1630416951755; Tue, 31 Aug 2021 06:35:51 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:51 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 5/8] tests: annotate t001*.sh with TEST_PASSES_SANITIZE_LEAK=true Date: Tue, 31 Aug 2021 15:35:39 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Annotate the t001*.sh tests that pass under SANITIZE=leak, these tests now pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. We skip t0012-help.sh, t0014-alias.sh, t0015-hash.sh and t0019-json-writer.sh due to outstanding memory leaks. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t0010-racy-git.sh | 1 + t/t0011-hashmap.sh | 1 + t/t0013-sha1dc.sh | 1 + t/t0016-oidmap.sh | 1 + t/t0017-env-helper.sh | 1 + t/t0018-advice.sh | 1 + 6 files changed, 6 insertions(+) diff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh index 5657c5a87b6..9a627077be4 100755 --- a/t/t0010-racy-git.sh +++ b/t/t0010-racy-git.sh @@ -2,6 +2,7 @@ test_description='racy GIT' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh # This test can give false success if your machine is sufficiently diff --git a/t/t0011-hashmap.sh b/t/t0011-hashmap.sh index 5343ffd3f92..02b07ffa75c 100755 --- a/t/t0011-hashmap.sh +++ b/t/t0011-hashmap.sh @@ -1,6 +1,7 @@ #!/bin/sh test_description='test hashmap and string hash functions' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_hashmap() { diff --git a/t/t0013-sha1dc.sh b/t/t0013-sha1dc.sh index 419f31a8f7d..812b5fcaff3 100755 --- a/t/t0013-sha1dc.sh +++ b/t/t0013-sha1dc.sh @@ -1,6 +1,7 @@ #!/bin/sh test_description='test sha1 collision detection' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh TEST_DATA="$TEST_DIRECTORY/t0013" diff --git a/t/t0016-oidmap.sh b/t/t0016-oidmap.sh index 31f8276ba82..a9e135d859b 100755 --- a/t/t0016-oidmap.sh +++ b/t/t0016-oidmap.sh @@ -1,6 +1,7 @@ #!/bin/sh test_description='test oidmap' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh # This purposefully is very similar to t0011-hashmap.sh diff --git a/t/t0017-env-helper.sh b/t/t0017-env-helper.sh index 4a159f99e44..14bb6797b30 100755 --- a/t/t0017-env-helper.sh +++ b/t/t0017-env-helper.sh @@ -2,6 +2,7 @@ test_description='test env--helper' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh index 39e5e4b34f8..326752a9711 100755 --- a/t/t0018-advice.sh +++ b/t/t0018-advice.sh @@ -2,6 +2,7 @@ test_description='Test advise_if_enabled functionality' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success 'advice should be printed when config variable is unset' ' From patchwork Tue Aug 31 13:35:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D48CC4320E for ; Tue, 31 Aug 2021 13:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70A4B60FED for ; Tue, 31 Aug 2021 13:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237099AbhHaNgy (ORCPT ); Tue, 31 Aug 2021 09:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237314AbhHaNgw (ORCPT ); Tue, 31 Aug 2021 09:36:52 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89E32C06179A for ; Tue, 31 Aug 2021 06:35:54 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso2591394wmr.1 for ; Tue, 31 Aug 2021 06:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OH+vHxqj/oGTZ7r4j8345oYcOc9T9YF/lETqg3Q34ro=; b=Hn8eAokQuuPsUqZj9UfH9pzp02CdESprcJjHvV06CkT7ZKhEd7ZAiEZh/gGNaoqDEv WZDGR9rxAgIWov6a6y0MtLtjPwcbEcPLwRKzdhHvtMwCy6stONtHe6b55r+trJY8o25/ yIB8c/gdrXOmIfKLXvMNSLG8yRIcl7AgWRk27Oh1QWITSbTosikVQH+E8qI5MtNlnM4z WT74eRaFr+dcgy2ZDtsOgcUdqBPsmGBV09P/knGdCYoWHd6XiduwfGBb+UEUshEBmNc0 d55TqxAZcgbTjhKys0IVynJRFRgUNtP6QmCypHyWH8gfnbKTL/nLzTjH1f7E4sbBgegA nvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OH+vHxqj/oGTZ7r4j8345oYcOc9T9YF/lETqg3Q34ro=; b=uLCucTwYlJ3u8sGmVQILCBlySIbTmVincVoBxfF63kVJqsCCmq8wNrYEZRigptrSNN itAaxgz+JfU5IzBUmK1dLTrMdRPzA6QUcub6tRtaekpurMr3JXQN6lrhIsBNu3LtsMUL 6baQTzQls/69sc6XPx5Dzx7DoIHxX5+r5B6L/fG9t3vVk4rrSUgzGfzx1yom2wBrmMC9 44CYLcb67kRQtvylehCod5NO821uzhHcW5q6T/0S89HoKZZVUQ36S9ItoHjbZgCTKJ4l G3sV1B5GNOsMtVasl+OaQftGQvIMAs7LDXb6No3f+XmvkUzm8wTwsLLC49rznN2h7kwE S/Rg== X-Gm-Message-State: AOAM533xl/WOTFo7dtbdo+LytHspaHj9qR/T7FgT6FL54q+dXXxlO4Nz qu2b0dzSg9cxLDKmq7ZxpEWB5SnP7T//Zg== X-Google-Smtp-Source: ABdhPJygRLSNK8RnGeG8D5pPfOhryecrZkbfZr9Knb9O1xFhVmCCCRBnpHmCDL8ZwJRDDF/gT6Zs7w== X-Received: by 2002:a7b:c316:: with SMTP id k22mr4259846wmj.56.1630416952884; Tue, 31 Aug 2021 06:35:52 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:52 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 6/8] tests: annotate t002*.sh with TEST_PASSES_SANITIZE_LEAK=true Date: Tue, 31 Aug 2021 15:35:40 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Annotate the t002*.sh tests that pass under SANITIZE=leak, these tests now pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. We skip t0020-crlf.sh, t0021-conversion.sh, t0023-crlf-am.sh and t0028-working-tree-encoding.sh due to outstanding memory leaks. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t0022-crlf-rename.sh | 1 + t/t0024-crlf-archive.sh | 1 + t/t0025-crlf-renormalize.sh | 1 + t/t0026-eol-config.sh | 1 + t/t0029-core-unsetenvvars.sh | 1 + 5 files changed, 5 insertions(+) diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh index 7af3fbcc7b9..d8ae0879bdb 100755 --- a/t/t0022-crlf-rename.sh +++ b/t/t0022-crlf-rename.sh @@ -2,6 +2,7 @@ test_description='ignore CR in CRLF sequence while computing similiarity' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success setup ' diff --git a/t/t0024-crlf-archive.sh b/t/t0024-crlf-archive.sh index 4e9fa3cd684..95913032524 100755 --- a/t/t0024-crlf-archive.sh +++ b/t/t0024-crlf-archive.sh @@ -2,6 +2,7 @@ test_description='respect crlf in git archive' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success setup ' diff --git a/t/t0025-crlf-renormalize.sh b/t/t0025-crlf-renormalize.sh index e13363ade5c..88cbdc5ed3a 100755 --- a/t/t0025-crlf-renormalize.sh +++ b/t/t0025-crlf-renormalize.sh @@ -2,6 +2,7 @@ test_description='CRLF renormalization' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success setup ' diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh index c5203e232c8..3be010e2f12 100755 --- a/t/t0026-eol-config.sh +++ b/t/t0026-eol-config.sh @@ -2,6 +2,7 @@ test_description='CRLF conversion' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh has_cr() { diff --git a/t/t0029-core-unsetenvvars.sh b/t/t0029-core-unsetenvvars.sh index 24ce46a6ea1..87566900c2b 100755 --- a/t/t0029-core-unsetenvvars.sh +++ b/t/t0029-core-unsetenvvars.sh @@ -2,6 +2,7 @@ test_description='test the Windows-only core.unsetenvvars setting' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh if ! test_have_prereq MINGW From patchwork Tue Aug 31 13:35:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A48CC432BE for ; Tue, 31 Aug 2021 13:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0190A60FE6 for ; Tue, 31 Aug 2021 13:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237735AbhHaNg4 (ORCPT ); Tue, 31 Aug 2021 09:36:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237364AbhHaNgw (ORCPT ); Tue, 31 Aug 2021 09:36:52 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D3B8C0617AE for ; Tue, 31 Aug 2021 06:35:55 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so2595761wml.3 for ; Tue, 31 Aug 2021 06:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vJUiFiQnOYXNrJhMFNz7x9dwblmPjepxzZP0urzB/2M=; b=RbSlS158m0CO4vdhzfuauZc4DUOoCUnQnAwZZ0LxX77eA9Fnu28iFOQYD/CwmWkh+e a3wd9fjT+/Ei8weGaOKz8o8uP45ZTXbdMdfMJXS5kWox7kCjiniHmF4v19RBJCKd0aCn Eytn1ycRTso9uheYm/4nmK6nCfq1MNS0WK5aLn1Vj4wrjGrhgX++S60ujwLhib0bIJ+m vJfbV3jECgYuonAV9YfgTEw8FrjMRbev637YjVPws+BCe5+10BJS3nH3bOB8S/xs950o XbEF3L/vR3dJMmBTmT/BfwIDDzmpCYc6PtzmFilNgnZSi39q7J0H/4WuSDdFGqzx2TTB r3Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vJUiFiQnOYXNrJhMFNz7x9dwblmPjepxzZP0urzB/2M=; b=ljKbttPKG8zMzZsQtMId3VQk/3GKURLllvlw00LHVwoYVafJnqA1c/K7NOlNO2iq4e APjqry37g/gaNyjQLtt2A4xx739EvjRXR300RtMl5/JfKhJavnwf2Nfvk/8EDQILh9cq hnRQRZmYDBjePPyxU2TnnLtqNhh65xPPNpasEFfPGCG+X+29wcSintmOdgXPvaFOPUgs zTgfEuARfDOjChssgkuStt32/IS3ITadoNvzPwoD3tckBWy5RAUrY1Lb1gZt65R9w7Z9 jVjT3aE0SBz/qXDNGl0YhYLRDr/bTknnqxxuZmiVFx302jgH/hJFR/l1bzVA209i4lel qzSg== X-Gm-Message-State: AOAM533TG/W+Lc2stq2ZPjFTKT1IztveX0hwcHd3VQbYqvPaD/r0ETy6 DN3MM1iEV3+A9sVWedo9jgpHZeotBmJxqw== X-Google-Smtp-Source: ABdhPJyld57hfp9IS2Obzjn+lZiaiNmsocy2R67aAv58vbWqFyTMvNjzXMhT5unuCFMW1SJf80IyIQ== X-Received: by 2002:a1c:f206:: with SMTP id s6mr4176033wmc.102.1630416953880; Tue, 31 Aug 2021 06:35:53 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:53 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 7/8] tests: annotate select t0*.sh with TEST_PASSES_SANITIZE_LEAK=true Date: Tue, 31 Aug 2021 15:35:41 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Annotate a few t0*.sh tests that pass with SANITIZE=leak, these tests now pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. These aren't all of the ones in t0*.sh that pass, I'm selecting a few ones that test some core APIs, and the simple "git bugreport" built-in. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t0030-stripspace.sh | 1 + t/t0052-simple-ipc.sh | 1 + t/t0061-run-command.sh | 1 + t/t0063-string-list.sh | 1 + t/t0066-dir-iterator.sh | 1 + t/t0067-parse_pathspec_file.sh | 1 + t/t0091-bugreport.sh | 1 + 7 files changed, 7 insertions(+) diff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh index 0c24a0f9a37..d00f7dd01e8 100755 --- a/t/t0030-stripspace.sh +++ b/t/t0030-stripspace.sh @@ -5,6 +5,7 @@ test_description='git stripspace' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh t40='A quick brown fox jumps over the lazy do' diff --git a/t/t0052-simple-ipc.sh b/t/t0052-simple-ipc.sh index ff98be31a51..f76a1f5e249 100755 --- a/t/t0052-simple-ipc.sh +++ b/t/t0052-simple-ipc.sh @@ -2,6 +2,7 @@ test_description='simple command server' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test-tool simple-ipc SUPPORTS_SIMPLE_IPC || { diff --git a/t/t0061-run-command.sh b/t/t0061-run-command.sh index 7d599675e35..89fd3b18e52 100755 --- a/t/t0061-run-command.sh +++ b/t/t0061-run-command.sh @@ -5,6 +5,7 @@ test_description='Test run command' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh cat >hello-script <<-EOF diff --git a/t/t0063-string-list.sh b/t/t0063-string-list.sh index c6ee9f66b11..0bd69de4f75 100755 --- a/t/t0063-string-list.sh +++ b/t/t0063-string-list.sh @@ -5,6 +5,7 @@ test_description='Test string list functionality' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_split () { diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh index 92910e4e6c1..edafdbbe7dc 100755 --- a/t/t0066-dir-iterator.sh +++ b/t/t0066-dir-iterator.sh @@ -2,6 +2,7 @@ test_description='Test the dir-iterator functionality' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success 'setup' ' diff --git a/t/t0067-parse_pathspec_file.sh b/t/t0067-parse_pathspec_file.sh index 7bab49f361a..cc2540db9f9 100755 --- a/t/t0067-parse_pathspec_file.sh +++ b/t/t0067-parse_pathspec_file.sh @@ -2,6 +2,7 @@ test_description='Test parse_pathspec_file()' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success 'one item from stdin' ' diff --git a/t/t0091-bugreport.sh b/t/t0091-bugreport.sh index 526304ff95b..946909dbfde 100755 --- a/t/t0091-bugreport.sh +++ b/t/t0091-bugreport.sh @@ -2,6 +2,7 @@ test_description='git bugreport' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh # Headers "[System Info]" will be followed by a non-empty line if we put some From patchwork Tue Aug 31 13:35:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12467255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF94C43216 for ; Tue, 31 Aug 2021 13:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CA0E6103D for ; Tue, 31 Aug 2021 13:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237797AbhHaNg5 (ORCPT ); Tue, 31 Aug 2021 09:36:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237379AbhHaNgw (ORCPT ); Tue, 31 Aug 2021 09:36:52 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 859EBC0613A3 for ; Tue, 31 Aug 2021 06:35:56 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id u15so11270275wmj.1 for ; Tue, 31 Aug 2021 06:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=joLoA6cd3bdp+72HkYlzf+FNL7NMFefZp1UABiSPpWE=; b=Dp9cmu3xTX0pt3f+Jmj7mee/773RJEy5SKNtgXYNnsrU+qjUOiqcF9PUtd6QFRcgXt 7g53IP1cn40RW4ta1B8wynM5mzraIonzX54mXgwGI3TM37cO58UnymGlyXhaR7bEoDDA ZIF7sfadjg7FDQp95VNpV6HXkopY6MNppM61Tkfw1nTonB6Pv+jjCyxMxCgHQEGRRhns d6Mz0K4PnMdDa74S8+cx+u6uQ0VV3qD+8jYA84WEjmjXg8cF6vp+DqwrRwAGWZKK8u4M ZFeOktC5mp+M/0uKT1hK9zhQaA3eTIHH07bK5w9Mhdup5wUnEjYURZzPJwc3rpSOFH9y 4ChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=joLoA6cd3bdp+72HkYlzf+FNL7NMFefZp1UABiSPpWE=; b=JJutF4Ps7fGSxwJe4uNmkNziuUsSbVTwGPGWDVXvG+fsFFK7cBwabs0ABdMu/yZHn4 oNrOtEnCCetPkPLZD9rMqrJDyEqf6PRRcvEDgcRGAs6o2sr3jVDDXed3io+ZUz6UN/W3 7vQI49X2fOfV29Dd54/Kzxu2taGdpHDUGBaeEOWeP78Kv8RSxXrijShKQArnVOsqpVSp 5NujuubonDu7lehBfmaax3Ld8fs4NtLALzkPfrTy5h3cUx1NMJkICb7FkiAOOPwGgMrX k8ch0+rfaIgGpyXgkZRs0oX49D5uemy/WmgCQwbKCrhAe8q8T4RKwONo9NQUZfG5hrWp QVfw== X-Gm-Message-State: AOAM53325VbbtaAlBQvQUa2ORiUI6F/yonTNhfaUXb+7MTYxedOhQFPv XUNOvH5LSkBilKVTi5lX+Q0UiY/mI0Oi3Q== X-Google-Smtp-Source: ABdhPJzKh8rT6+uqP9Fu8+izJCSZ6QQIdG888igj/FebiskTDeRTqzr5wUiVOeyK3y3cMrNaexg7Sg== X-Received: by 2002:a1c:7506:: with SMTP id o6mr4481927wmc.112.1630416954885; Tue, 31 Aug 2021 06:35:54 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id u27sm19073451wru.2.2021.08.31.06.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:35:54 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Andrzej Hunt , =?utf-8?b?TMOpbmHDr2MgSHVhcmQ=?= , Derrick Stolee , Felipe Contreras , =?utf-8?q?SZEDER_G=C3=A1bor?= , =?utf-8?b?xJBvw6Bu?= =?utf-8?b?IFRy4bqnbiBDw7RuZyBEYW5o?= , Eric Sunshine , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH v3 8/8] tests: annotate select t*.sh with TEST_PASSES_SANITIZE_LEAK=true Date: Tue, 31 Aug 2021 15:35:42 +0200 Message-Id: X-Mailer: git-send-email 2.33.0.805.g739b16c2189 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Annotate a few t*.sh tests that pass with SANITIZE=leak, these tests now pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. These aren't all of the ones in t*.sh that pass, I'm selecting a few arbitrary passing ones that stress a few common commands and APIs. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t1010-mktree.sh | 1 + t/t1100-commit-tree-options.sh | 1 + t/t1308-config-set.sh | 1 + t/t1309-early-config.sh | 1 + t/t1420-lost-found.sh | 1 + t/t1430-bad-ref-name.sh | 1 + t/t1509-root-work-tree.sh | 1 + t/t2002-checkout-cache-u.sh | 1 + t/t2050-git-dir-relative.sh | 1 + t/t2081-parallel-checkout-collisions.sh | 1 + t/t2100-update-cache-badpath.sh | 1 + t/t2200-add-update.sh | 1 + t/t2201-add-update-typechange.sh | 1 + t/t2202-add-addremove.sh | 1 + t/t2204-add-ignored.sh | 1 + t/t2300-cd-to-toplevel.sh | 1 + t/t3000-ls-files-others.sh | 1 + t/t3004-ls-files-basic.sh | 1 + t/t3006-ls-files-long.sh | 1 + t/t3008-ls-files-lazy-init-name-hash.sh | 1 + t/t3100-ls-tree-restrict.sh | 1 + t/t3101-ls-tree-dirname.sh | 1 + t/t3102-ls-tree-wildcards.sh | 1 + t/t3103-ls-tree-misc.sh | 1 + t/t3205-branch-color.sh | 1 + t/t3211-peel-ref.sh | 1 + t/t3300-funny-names.sh | 1 + t/t3902-quoted.sh | 1 + t/t4002-diff-basic.sh | 1 + t/t4026-color.sh | 1 + t/t4300-merge-tree.sh | 1 + 31 files changed, 31 insertions(+) diff --git a/t/t1010-mktree.sh b/t/t1010-mktree.sh index b946f876864..3912625cfad 100755 --- a/t/t1010-mktree.sh +++ b/t/t1010-mktree.sh @@ -2,6 +2,7 @@ test_description='git mktree' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh test_expect_success setup ' diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh index ae66ba5babf..d603d9a8544 100755 --- a/t/t1100-commit-tree-options.sh +++ b/t/t1100-commit-tree-options.sh @@ -12,6 +12,7 @@ Also make sure that command line parser understands the normal "flags first and then non flag arguments" command line. ' +. ./test-pragma-SANITIZE=leak-ok.sh . ./test-lib.sh cat >expected <