From patchwork Wed Sep 1 00:12:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12467921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BF1C432BE for ; Wed, 1 Sep 2021 00:12:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DF4F61041 for ; Wed, 1 Sep 2021 00:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243247AbhIAANb (ORCPT ); Tue, 31 Aug 2021 20:13:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243242AbhIAANb (ORCPT ); Tue, 31 Aug 2021 20:13:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D0E261008; Wed, 1 Sep 2021 00:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630455155; bh=5zEHfJY16KIaUJlnHuFtMeQ8taovR8wySqvC4DeuyN8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=f1/NkFb+ex7p2pAEFGhG+cub4S1pgbYUsTX0oF9Twyk/MfjtvXU+OiIHAn5VkKaoe JpSsOacx58ZzoM/SRcb8syi6jbk8SQAWPHktackiShxYmcV5kEgxK+8dUw6OB03hYE t8pZJpjd14Dg7uwMx6sSb0lxPjAy3A/M3a1e2owAfeDue8u2KLIdEv49+AvSrnQh6E +CFYc/Bxk3SQbY6s9BnQhs5DTy2+27+oRMycVVtPG+2SDAqv49PSWrkKOFwqwn1qSd lRx/x+1j848FmfCuK+Dhph7TPuRbrZODGOJUoHO1dNQyg7pV8syuIf/hI8IblOi+dK mx8eESeS5jXNg== Subject: [PATCH 1/5] ceph: re-tag copy_file_range as being in the copy_range group From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Tue, 31 Aug 2021 17:12:35 -0700 Message-ID: <163045515529.771564.6600748735943731783.stgit@magnolia> In-Reply-To: <163045514980.771564.6282165259140399788.stgit@magnolia> References: <163045514980.771564.6282165259140399788.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong copy_range is the group name for copy_file_range tests, so reclassify these tests. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- tests/ceph/001 | 2 +- tests/ceph/002 | 2 +- tests/ceph/003 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ceph/001 b/tests/ceph/001 index aca77168..c00de308 100755 --- a/tests/ceph/001 +++ b/tests/ceph/001 @@ -11,7 +11,7 @@ # file and 3) the middle of the dst file. # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter diff --git a/tests/ceph/002 b/tests/ceph/002 index 428f23a9..9bc728fd 100755 --- a/tests/ceph/002 +++ b/tests/ceph/002 @@ -20,7 +20,7 @@ # linux kernel: 78beb0ff2fec ("ceph: use copy-from2 op in copy_file_range") # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter diff --git a/tests/ceph/003 b/tests/ceph/003 index 9f8c6068..faedb48c 100755 --- a/tests/ceph/003 +++ b/tests/ceph/003 @@ -7,7 +7,7 @@ # Test copy_file_range with infile = outfile # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter From patchwork Wed Sep 1 00:12:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12467989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9B1C432BE for ; Wed, 1 Sep 2021 00:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 755806103D for ; Wed, 1 Sep 2021 00:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243249AbhIAANj (ORCPT ); Tue, 31 Aug 2021 20:13:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:47174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243245AbhIAANg (ORCPT ); Tue, 31 Aug 2021 20:13:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0C4D56102A; Wed, 1 Sep 2021 00:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630455161; bh=UTa46hKvumgBDKbs3/0GuZY6WwZqlrceo2oBhIUCyR8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=JkvE5XoFfZgRzsc8QqS6NMfDiEeW15mNWFjWarRNDaPcRYkN9i8cXlUGdvRbaYo5y XP7BOSwNC92xcpHNZBeSpbe2bPxjVGFzl2PZiYfynRJlZ5d1rseh2dhxdqB2d7bcBO lyyGObWX8NTBU4rjbgmMG8EMDfRF8GK99Q+kSGc/apzxqNBllO5tmcHON58UWM5UmZ 5nHSV1T01jKY0MlZPz61/chMpP29tJLvV1OQ/Y/EPKqjs8O2Sks9oZsf40ecKQbDG8 4B/7rymBoeT4dEO6g15/eVEx3qxMFeJSHftj0Jb/5Xk0P62IOy6UN4b9HsdZn6ozZT T4BKzv60wBATw== Subject: [PATCH 2/5] xfs: move reflink tests into the clone group From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Tue, 31 Aug 2021 17:12:40 -0700 Message-ID: <163045516076.771564.422157391342318386.stgit@magnolia> In-Reply-To: <163045514980.771564.6282165259140399788.stgit@magnolia> References: <163045514980.771564.6282165259140399788.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong "clone" is the group for tests that exercise FICLONERANGE, so move these tests. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- tests/xfs/519 | 2 +- tests/xfs/520 | 2 +- tests/xfs/535 | 2 +- tests/xfs/536 | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/xfs/519 b/tests/xfs/519 index 675ec07e..49c62b56 100755 --- a/tests/xfs/519 +++ b/tests/xfs/519 @@ -9,7 +9,7 @@ # flushing the log and then remounting to check file contents. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter diff --git a/tests/xfs/520 b/tests/xfs/520 index 8410f2ba..2fceb07c 100755 --- a/tests/xfs/520 +++ b/tests/xfs/520 @@ -12,7 +12,7 @@ # is included in the current kernel. # . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Override the default cleanup function. _cleanup() diff --git a/tests/xfs/535 b/tests/xfs/535 index 4c883675..1a5da61b 100755 --- a/tests/xfs/535 +++ b/tests/xfs/535 @@ -7,7 +7,7 @@ # Verify that XFS does not cause inode fork's extent count to overflow when # writing to a shared extent. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter diff --git a/tests/xfs/536 b/tests/xfs/536 index e5f904f5..64fa4fbf 100755 --- a/tests/xfs/536 +++ b/tests/xfs/536 @@ -7,7 +7,7 @@ # Verify that XFS does not cause inode fork's extent count to overflow when # remapping extents from one file's inode fork to another. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter From patchwork Wed Sep 1 00:12:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12467991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE7FC432BE for ; Wed, 1 Sep 2021 00:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 766E961008 for ; Wed, 1 Sep 2021 00:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243242AbhIAANm (ORCPT ); Tue, 31 Aug 2021 20:13:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:47204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243241AbhIAANm (ORCPT ); Tue, 31 Aug 2021 20:13:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 846406102A; Wed, 1 Sep 2021 00:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630455166; bh=vv3taoie8ul1L8HHj2xb8VOfSmARQrFndjaLNn81Orc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ELaIR7cnZtHTDpFtrXChK18wPXLy20ObW0DnTjQjR1QKCZYTS9XUB9D+B2Iy2Q09j b3s7Qo2PBJ4M23ycKklUWDtZ/IeSgJs4GrpL27rKKCWSdPG+3HzB7pEn1yVgqg7Rvq CeIevDxFwf3lD0WlU+fNn/M0OJ6gb36ambdTintEKWk7O6xEHU8aUkULu2Oz/t2ii2 IAZPeKry331XHpWdmsfFMEefW+5JCCg/SVYPnIYrZMJe9W74AJk8cEtYiLk7sIZnOO t7LT9vz2YJlbYyP+gL5kB79JuxQrDSTfS4Eph0zayeFer8rNB7uJydWIW3xjCcockZ Br2xpsWC1Cq+A== Subject: [PATCH 3/5] xfs: fix incorrect fuzz test group name From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Tue, 31 Aug 2021 17:12:46 -0700 Message-ID: <163045516624.771564.3811466819215120895.stgit@magnolia> In-Reply-To: <163045514980.771564.6282165259140399788.stgit@magnolia> References: <163045514980.771564.6282165259140399788.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong The group name for fuzz tests is 'fuzzers'. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- tests/xfs/491 | 2 +- tests/xfs/492 | 2 +- tests/xfs/493 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/xfs/491 b/tests/xfs/491 index 5c7c5d1f..7402b09a 100755 --- a/tests/xfs/491 +++ b/tests/xfs/491 @@ -7,7 +7,7 @@ # Test detection & fixing of bad summary block counts at mount time. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter diff --git a/tests/xfs/492 b/tests/xfs/492 index 8258e5d8..514ac1e4 100755 --- a/tests/xfs/492 +++ b/tests/xfs/492 @@ -7,7 +7,7 @@ # Test detection & fixing of bad summary inode counts at mount time. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter diff --git a/tests/xfs/493 b/tests/xfs/493 index 58fd9c99..58091ad7 100755 --- a/tests/xfs/493 +++ b/tests/xfs/493 @@ -8,7 +8,7 @@ # Corrupt the AGFs to test mount failure when mount-fixing fails. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter From patchwork Wed Sep 1 00:12:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12467993 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277B8C432BE for ; Wed, 1 Sep 2021 00:12:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE546103D for ; Wed, 1 Sep 2021 00:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243245AbhIAANs (ORCPT ); Tue, 31 Aug 2021 20:13:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:47234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243244AbhIAANr (ORCPT ); Tue, 31 Aug 2021 20:13:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0522761008; Wed, 1 Sep 2021 00:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630455172; bh=tbZVqxzdmFSJ8lgQEcy0hJJjpblBK8GAtB+wuD26C9w=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gHR2L+7wl8Rh2uVcVUq92Badklqb5a8mdJehZeuRobUa9/gz/tSNCu6fWAu9o9ZQA 6sC/nMu0aHomSlYQDWJrjeDAoZSNOVd/DgFItt1XP0ZmxMkNalmxfbOUeyUagPtWhr KAgsG8pR3w0aXjFcprlPFwl+ApcEmRBz0WYz4ntGlNvjJgcr0Je0gdScmfW2tFoX53 oVi2+CsXhD0SFHqb8NtIWNbVZ95QuG9Dk0PApOUvBNAOjwtmUmedrS2DhoxtAEUsUO 83lsSpEQmT5eoAGDnwIW4KuVy9S++rPyvlOQ7Mh4xiSJYmQhR2bByjMWRqAtXP9olO 2iZcendNLLQmQ== Subject: [PATCH 4/5] tools: make sure that test groups are described in the documentation From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Tue, 31 Aug 2021 17:12:51 -0700 Message-ID: <163045517173.771564.1524162806861567173.stgit@magnolia> In-Reply-To: <163045514980.771564.6282165259140399788.stgit@magnolia> References: <163045514980.771564.6282165259140399788.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong Create a file to document the purpose of each test group that is currently defined in fstests, and add a build script to check that every group mentioned in the tests is also mentioned in the documentation. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- doc/group-names.txt | 136 ++++++++++++++++++++++++++++++++++++++++++++++++ include/buildgrouplist | 1 tools/check-groups | 33 ++++++++++++ 3 files changed, 170 insertions(+) create mode 100644 doc/group-names.txt create mode 100755 tools/check-groups diff --git a/doc/group-names.txt b/doc/group-names.txt new file mode 100644 index 00000000..ae517328 --- /dev/null +++ b/doc/group-names.txt @@ -0,0 +1,136 @@ +======================= ======================================================= +Group Name: Description: +======================= ======================================================= +all All known tests, automatically generated by ./check at + runtime +auto Tests that should be run automatically. These should + not require more than ~5 minutes to run. +quick Tests that should run in under 30 seconds. +deprecated Old tests that should not be run. + +acl Access Control Lists +admin xfs_admin functionality +aio general libaio async io tests +atime file access time +attr extended attributes +attr2 xfs v2 extended aributes +balance btrfs tree rebalance +bigtime timestamps beyond the year 2038 +blockdev block device functionality +broken broken tests +cap Linux capabilities +casefold directory name casefolding +ci ASCII case-insensitive directory name lookups +clone FICLONE/FICLONERANGE ioctls +clone_stress stress testing FICLONE/FICLONERANGE +collapse fallocate collapse_range +compress file compression +convert btrfs ext[34] conversion tool +copy xfs_copy functionality +copy_range copy_file_range syscall +copyup overlayfs copyup support +dangerous dangerous test that can crash the system +dangerous_bothrepair fuzzers to evaluate xfs_scrub + xfs_repair repair +dangerous_fuzzers fuzzers that can crash your computer +dangerous_norepair fuzzers to evaluate kernel metadata verifiers +dangerous_online_repair fuzzers to evaluate xfs_scrub online repair +dangerous_repair fuzzers to evaluate xfs_repair offline repair +dangerous_scrub fuzzers to evaluate xfs_scrub checking +data data loss checkers +dax direct access mode for persistent memory files +db xfs_db functional tests +dedupe FIEDEDUPERANGE ioctl +defrag filesystem defragmenters +dir directory test functions +dump dump and restore utilities +eio IO error reporting +encrypt encrypted file contents +enospc ENOSPC error reporting +exportfs file handles +filestreams XFS filestreams allocator +freeze filesystem freeze tests +fsck general fsck tests +fsmap FS_IOC_GETFSMAP ioctl +fsr XFS free space reorganizer +fuzzers filesystem fuzz tests +growfs increasing the size of a filesystem +hardlink hardlinks +health XFS health reporting +idmapped idmapped mount functionality +inobtcount XFS inode btree count tests +insert fallocate insert_range +ioctl general ioctl tests +io_uring general io_uring async io tests +label filesystem labelling +limit resource limits +locks file locking +log metadata logging +logprint xfs_logprint functional tests +long_rw long-soak read write IO path exercisers +metacopy overlayfs metadata-only copy-up +metadata filesystem metadata update exercisers +metadump xfs_metadump/xfs_mdrestore functionality +mkfs filesystem formatting tools +mount mount option and functionality checks +nested nested overlayfs instances +nfs4_acl NFSv4 access control lists +nonsamefs overlayfs layers on different filesystems +online_repair online repair functionality tests +other dumping ground, do not add more tests to this group +overlay using overlayfs on top of FSTYP +pattern specific IO pattern tests +perms access control and permission checking +pipe pipe functionality +pnfs PNFS +posix POSIX behavior conformance +prealloc fallocate +preallocrw fallocate, then read and write +punch fallocate punch_hole +qgroup btrfs qgroup feature +quota filesystem usage quotas +raid btrfs RAID +realtime XFS realtime volumes +recoveryloop crash recovery loops +redirect overlayfs redirect_dir feature +remote dump and restore with a remote tape +remount remounting filesystems +rename rename system call +repair xfs_repair functional tests +replace btrfs device replace +replay dm-logwrites replays +resize resize2fs functionality tests +richacl rich ACL feature +rmap XFS reverse mapping exercisers +rotate overlayfs feature of some sort +rw read/write IO tests +samefs overlayfs when all layers are on the same fs +scrub filesystem metadata scrubbers +seed btrfs seeded filesystems +seek llseek functionality +send btrfs send/receive +shrinkfs decreasing the size of a filesystem +shutdown FS_IOC_SHUTDOWN ioctl +snapshot btrfs snapshots +soak long soak tests of any kind +spaceman xfs_spaceman functional tests +splice splice system call +stress fsstress filesystem exerciser +subvol btrfs subvolumes +subvolume btrfs subvolumes (again?) +swap swap files +symlink symbolic links +tape dump and restore with a tape +thin thin provisioning +trim FITRIM ioctl +udf UDF functionality tests +union tests from the unionmount test suite +unlink O_TMPFILE unlinked files +unshare fallocate unshare_range +v2log XFS v2 log format tests +verity fsverity +volume btrfs volume management +whiteout overlayfs whiteout functionality +xino overlayfs xino feature +zero fallocate zero_range +zone zoned (SMR) device support +======================= ======================================================= diff --git a/include/buildgrouplist b/include/buildgrouplist index d898efa3..489de965 100644 --- a/include/buildgrouplist +++ b/include/buildgrouplist @@ -6,3 +6,4 @@ group.list: @echo " [GROUP] $$PWD/$@" $(Q)$(TOPDIR)/tools/mkgroupfile $@ + $(Q)$(TOPDIR)/tools/check-groups $(TOPDIR)/doc/group-names.txt $@ diff --git a/tools/check-groups b/tools/check-groups new file mode 100755 index 00000000..bac45bbd --- /dev/null +++ b/tools/check-groups @@ -0,0 +1,33 @@ +#!/bin/bash + +# Make sure that all groups listed in a group.list file are mentioned in the +# group description file. + +if [ -z "$1" ] || [ "$1" = "--help" ]; then + echo "Usage: $0 path_to_group_names [group.list files...]" + exit 1 +fi + +groups_doc_file="$1" +shift + +get_group_list() { + for file in "$@"; do + while read testname groups; do + test -z "${testname}" && continue + test "${testname:0:1}" = "#" && continue + + echo "${groups}" | tr ' ' '\n' + done < "${file}" + done | sort | uniq +} + +ret=0 +while read group; do + if ! grep -q "^${group}[[:space:]]" "${groups_doc_file}"; then + echo "${group}: group not mentioned in documentation." 1>&2 + ret=1 + fi +done < <(get_group_list "$@") + +exit "${ret}" From patchwork Wed Sep 1 00:12:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12467995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECC1C432BE for ; Wed, 1 Sep 2021 00:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8F0E6103D for ; Wed, 1 Sep 2021 00:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243241AbhIAANx (ORCPT ); Tue, 31 Aug 2021 20:13:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243255AbhIAANx (ORCPT ); Tue, 31 Aug 2021 20:13:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 743006102A; Wed, 1 Sep 2021 00:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630455177; bh=uzrJuvAexq7Vha9Ux6CnGAP6zIYRGWaVJRhiEHwuOjI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=YQ4D+6sq2ew06V9yr8dFy8Mz6KRRnkIkMMhvsUscCnLVuQGIEEeC9TcMy8Sgsy7R6 5Lri0N0nH03ET1XXb/Jck+V+BGIOesuSAGoYV9MxtiJJZsNsKB9IdCgqRBH72ozete OYgwhFIAFfYR3AsTUP++VP13sJsOxiiIyjhGRAk6f19IKiciHFqVrwrSktQ8+/B++0 XeqZWXFiRYQozzhcvgIXCa+NEYFvP+Af06XkcARmfmbVUXCmviuwaAQrxsWkVwqnxs /LmnsXQ2x+lWN9BbR13qQqbp90KTC3gGNj16UgNJnKl+J2diIeBfrRBd1+j9muWgWj oHMNvN22rzNAg== Subject: [PATCH 5/5] new: only allow documented test group names From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Tue, 31 Aug 2021 17:12:57 -0700 Message-ID: <163045517721.771564.12357505876401888990.stgit@magnolia> In-Reply-To: <163045514980.771564.6282165259140399788.stgit@magnolia> References: <163045514980.771564.6282165259140399788.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong Now that we require all group names to be listed in doc/group-names.txt, we can use that (instead of running mkgroupfile) to check if the group name(s) supplied by the user actually exist. This has the secondary effect of being a second nudge towards keeping the description of groups up to date. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- new | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/new b/new index 2097a883..44777bd6 100755 --- a/new +++ b/new @@ -83,6 +83,14 @@ then exit 1 fi +# Extract group names from the documentation. +group_names() { + grep '^[[:lower:][:digit:]_]' doc/group-names.txt | awk ' +{if ($1 != "" && $1 != "Group" && $2 != "Name:" && $1 != "all") + printf("%s\n", $1); +}' +} + if [ $# -eq 0 ] then @@ -93,16 +101,7 @@ then [ -z "$ans" ] && ans=other if [ "X$ans" = "X?" ] then - for d in $SRC_GROUPS; do - (cd "tests/$d/" ; ../../tools/mkgroupfile "$tmpfile") - l=$(sed -n < "$tmpfile" \ - -e 's/#.*//' \ - -e 's/$/ /' \ - -e 's;\(^[0-9][0-9][0-9]\)\(.*$\);\2;p') - grpl="$grpl $l" - done - lst=`for word in $grpl; do echo $word; done | sort| uniq ` - echo $lst + echo $(group_names) else # only allow lower cases, spaces, digits and underscore in group inval=`echo $ans | tr -d '[:lower:][:space:][:digit:]_'` @@ -120,11 +119,10 @@ then else # expert mode, groups are on the command line # - (cd "$tdir" ; ../../tools/mkgroupfile "$tmpfile") for g in $* do - if ! grep -q "[[:space:]]$g" "$tmpfile"; then - echo "Warning: group \"$g\" not defined in $tdir tests" + if ! grep -q "^$g" doc/group-names.txt; then + echo "Warning: group \"$g\" not defined in documentation" fi done ans="$*"