From patchwork Wed Sep 8 18:13:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481655 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C11F4C433FE for ; Wed, 8 Sep 2021 18:14:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8857361100 for ; Wed, 8 Sep 2021 18:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8857361100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2Lurg0/voFi6LxNfPjaqqdcKBr2c4BOdO+Ox2j/jCMU=; b=Jt32BBIa+VWwQc jmMsIH2Iv+r0yS36S6TsMivEFw4coDVwnMLz80Sr61n+tvRejN5aLP4mrYtNAB06c/iHiqMwX14WZ 42tkcVsw+wKAi+EDUej6RbD9yS1x8YM4nUr3ccfQZocg3tNTVMeIbpLE7IsMsc2bhvKX11xlgH0gt y4iUhoMNGmuSyMGElfyYGbiW8RIjzHVOcVbpM8v1EG5HHR7TPwl9uDeDTjSror4+S5oScSjIwfDo1 UH1srfYIfNgp43pv+KkByE83dijit6PD6yGPcWC74Kaa/Gd1EgtM6YIiFY2GoDoI9fgCpLG2UhbLM stY81Mbu0C+9CEedn7ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25R-007NBf-KK; Wed, 08 Sep 2021 18:14:17 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25F-007N7b-PG for linux-rockchip@lists.infradead.org; Wed, 08 Sep 2021 18:14:07 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 17so3491065pgp.4 for ; Wed, 08 Sep 2021 11:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uzvU0TWDqoO4AhItKda+Ka4vpknel8tSLxFVqVBoaHc=; b=dWLekvtSO0q46ozawqJd+04F7FuB57Cc0/SYjtEAJ/zPKT1iReWuzDc8VmgpGffCxq 74mKvOXwSMsvA3xgPC5At98vactbCz5vxbdwYWaPWteBLn2zgIWeJjocuti+bMFGoqk3 gXkiZClJdgCsQVK/pYBE9UTCRL4aEhZ4ZENpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uzvU0TWDqoO4AhItKda+Ka4vpknel8tSLxFVqVBoaHc=; b=gcxEyYrt5zIklO3ZNFDhNTxjF1tFRJDgikWDw10InAVO5b4ku7oXUDsfVAjifwYK6M WUCqcwyIQeB+4v7kL1zD5cdhHW1Y9PxsoB+xXmYT17AYuI3+Rgwu9OO52889mAkIRCDQ PIYi57tm5EDK/srLDXNeOkdvFAUFKsK2EymPmvQYWgBQeTXqxfyh8SWR1gcRVFuOdRSL PaJoKL05XQiHOKcHuPu3ky/F5iPsvqh31ntco1YxRgtzhKMcpcxPmxYIz2+6kIrzHQ/D +UfyKuKB/3W7NzU94uKyaWe8Vw25wQc9nzS+9JFPliPs1uNliEpfPcf4Pgl/gXdwA0d/ KO4w== X-Gm-Message-State: AOAM531emoFMRJ5gzGC9yTq3JSaQnhlK5Z66LcyH9RdNcVTrC2vEyyYo g1NVodOTB1FW0rgsBdd54o43tA== X-Google-Smtp-Source: ABdhPJyDQMGH0+RxUGQtHUeCYv4lJd35HOoioyP4NMAPxkHx4TB4s0fz74029ULAwuaRpQEaZQyUDw== X-Received: by 2002:a63:584:: with SMTP id 126mr4916161pgf.165.1631124839684; Wed, 08 Sep 2021 11:13:59 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id o3sm2709858pji.26.2021.09.08.11.13.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:13:58 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical Date: Wed, 8 Sep 2021 11:13:38 -0700 Message-Id: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111405_852779_03A110AF X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't enable() them -- and even if it did, it's not early enough compared to other consumers -- nor does arch/arm64/kernel/smp.c), and instead are simply assumed to be "on" all the time. They are also parents of a few other clocks which haven't been previously exposed for other devices to consume. If we want to expose those clocks, then the common clock framework may eventually choose to disable their parents (including the CPU PLLs) -- which is no fun for anyone. Thus, mark the CPU clocks as critical, to prevent them from being disabled implicitly. Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson Reviewed-by: Chen-Yu Tsai --- Changes in v2: - New, split from the patch that requires this change drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 62a4f2543960..0ac9c72c4ee8 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -1514,7 +1514,10 @@ static const char *const rk3399_cru_critical_clocks[] __initconst = { "aclk_vio_noc", /* ddrc */ - "sclk_ddrc" + "sclk_ddrc", + + "armclkl", + "armclkb", }; static const char *const rk3399_pmucru_critical_clocks[] __initconst = { @@ -1549,9 +1552,6 @@ static void __init rk3399_clk_init(struct device_node *np) rockchip_clk_register_branches(ctx, rk3399_clk_branches, ARRAY_SIZE(rk3399_clk_branches)); - rockchip_clk_protect_critical(rk3399_cru_critical_clocks, - ARRAY_SIZE(rk3399_cru_critical_clocks)); - rockchip_clk_register_armclk(ctx, ARMCLKL, "armclkl", mux_armclkl_p, ARRAY_SIZE(mux_armclkl_p), &rk3399_cpuclkl_data, rk3399_cpuclkl_rates, @@ -1562,6 +1562,9 @@ static void __init rk3399_clk_init(struct device_node *np) &rk3399_cpuclkb_data, rk3399_cpuclkb_rates, ARRAY_SIZE(rk3399_cpuclkb_rates)); + rockchip_clk_protect_critical(rk3399_cru_critical_clocks, + ARRAY_SIZE(rk3399_cru_critical_clocks)); + rockchip_register_softrst(np, 21, reg_base + RK3399_SOFTRST_CON(0), ROCKCHIP_SOFTRST_HIWORD_MASK); From patchwork Wed Sep 8 18:13:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8324C433F5 for ; Wed, 8 Sep 2021 18:14:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AB806113D for ; Wed, 8 Sep 2021 18:14:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6AB806113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CuOEBidpp4x9Rqu2/YaFlY24OOyJtvOCEz8FMbJyaL4=; b=TLRx1Kwb62HwOr HPYe0SQKtyBFCgA8m7lRP8z3Q8GhRRAdaNhe8XUVCD+D4LqSEcT1+m6d2Mbyiq+QVY+1+Mu6UUYFT Ui5Kb0Lbf3pg659/R1sJrf79RE7gjMl7SJh/TLyOZkuEx1nGrHTqqEvFY1FhLFJNdMChS5ExbrEed ky4MOKhC1kackgJf1DC43eCc1ulONCwQ6VDd/6LfFHQsjzzDbnreT53ZMe/RPIbpK6L6xL+pQMbRm q5xAq1uqSA+BGvag3Dab35MVCdtHG+Nxr2dGYfBUr5Bzle4o3sAwQqqKc7ZwyysWDwKNLJWRRPLuX EEIczJO0pyPAc2hrbkpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25Q-007NBF-BR; Wed, 08 Sep 2021 18:14:16 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25C-007N7v-Aw for linux-rockchip@lists.infradead.org; Wed, 08 Sep 2021 18:14:03 +0000 Received: by mail-pg1-x533.google.com with SMTP id e7so3502934pgk.2 for ; Wed, 08 Sep 2021 11:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YmaBqKj8o4HmKcMeIl0Rd4QT1PMQFox+evWowfdT4pM=; b=LhDZLw+XEOIsX47v4NpnWSsriew4EbKSYY+nTXSZ9TmzNi61j7u4637SNRUlYjyoO8 4R4YpmU0eL3um0lTV+i052dCvVbo4xV0OYKht0oajmhCceVIlOxvjPyxbVM/YbGWSWBS ZIRkmc+hJiyaUDFaiaiH2UcD7B2bPGrHAFmv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YmaBqKj8o4HmKcMeIl0Rd4QT1PMQFox+evWowfdT4pM=; b=oToijH7nxoxAt2Hk1ca0t2V25x8LD6DfzJJqJgsxtCQmt/QTPdjfqXIDKrY7imel0w 2TBEFkRHiNaQUYHCe+D25I+iNToP3Ohp4nlePMTnC67REIVJD2kkgNC0knRrJw1zpolY gW9G6CBTZajdR2uqs+e+ffvlpkSsOsFSQqxysxavzdyF9lpnXj21Uhdexqd4uPlJsipx lDDpW/c50GjwR4JKzoKLBBeQK3cwRLK6fkIGaxqEBvY6qpZEDGWHPKoF1VQoQkt1ORiz sFKKcDmFFB+M5wZT4ty8TF+9jO9YUqNW1ketcsapRaVl3B5kQ+UtL8v4JQLlXg9HXPnA 5chg== X-Gm-Message-State: AOAM532bpXBFIQXHNZ0jJAW5H7upPZCIZp1nANGReZo+KZPkL4Pw8VBA vUyh3baU7Q+pmlNyIbrDwoJzdA== X-Google-Smtp-Source: ABdhPJz7vRfq/pAFYK+fNsy+aJ/Sx1OQI+A2rftCimRi2r9//7V/EaLJIn03rX6MPvX0ZYsKroiejA== X-Received: by 2002:a63:ef58:: with SMTP id c24mr4826337pgk.299.1631124841813; Wed, 08 Sep 2021 11:14:01 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id e19sm2982086pfi.139.2021.09.08.11.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:14:01 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v2 2/3] clk: rockchip: rk3399: expose PCLK_COREDBG_{B,L} Date: Wed, 8 Sep 2021 11:13:39 -0700 Message-Id: <20210908111337.v2.2.If29cd838efbcee4450a62b8d84a99b23c86e0a3f@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111402_439954_C87849AC X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org We have DT IDs for PCLK_COREDBG_L and PCLK_COREDBG_B, but we don't actually expose them. Note that this requires the previous patch (making "armclkl" and "armclkb" into "critical" clocks) to prevent these clocks from taking down the CPU. Reviewed-by: Chen-Yu Tsai Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson --- Changes in v2: - Split "CPU clocks are critical" to a new patch, to make it more obvious drivers/clk/rockchip/clk-rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 0ac9c72c4ee8..53ed5cca335b 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -481,7 +481,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { COMPOSITE_NOMUX(0, "atclk_core_l", "armclkl", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(1), 0, 5, DFLAGS | CLK_DIVIDER_READ_ONLY, RK3399_CLKGATE_CON(0), 5, GFLAGS), - COMPOSITE_NOMUX(0, "pclk_dbg_core_l", "armclkl", CLK_IGNORE_UNUSED, + COMPOSITE_NOMUX(PCLK_COREDBG_L, "pclk_dbg_core_l", "armclkl", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(1), 8, 5, DFLAGS | CLK_DIVIDER_READ_ONLY, RK3399_CLKGATE_CON(0), 6, GFLAGS), @@ -531,7 +531,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { GATE(ACLK_GIC_ADB400_CORE_B_2_GIC, "aclk_core_adb400_core_b_2_gic", "armclkb", CLK_IGNORE_UNUSED, RK3399_CLKGATE_CON(14), 4, GFLAGS), - DIV(0, "pclken_dbg_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, + DIV(PCLK_COREDBG_B, "pclken_dbg_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(3), 13, 2, DFLAGS | CLK_DIVIDER_READ_ONLY), GATE(0, "pclk_dbg_cxcs_pd_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, From patchwork Wed Sep 8 18:13:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481653 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017DBC433EF for ; Wed, 8 Sep 2021 18:14:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B80BC61100 for ; Wed, 8 Sep 2021 18:14:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B80BC61100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DZw1RdON0p4pUvOqR5h0QJALBlWq3880PsujOU+fA1I=; b=ENLNKlDeohpjKd qWgy70TgSpjtZtrcbq916KByZYpXBtZcS7FufgewCjXQKCjP8TFI9+b2wH+n/7zmP1EsrLf08Nn+K qdpgQMzHwB4YJZ4r16yQ7++eA50/kVkJt9tM25KRJ2V8tSCXNE0/vx+77JcncuYQ7nrdX8gHoWqPu 2btTcg1GyMG7Wj0sjKnY/YAu0zfvik9gou+2DqN4r+VFaFR2mQso7b0Pfy9GvFtLgxCJnWuS9keQ6 BUMeOGj6t3Y2BQ2FQSvO2xtx+XqB9kiAk23j5C6wpTuJB0Rwr0lA2pD/V8iE5Hc0dSInCJD09bN2t vh486GNqZ2sQGZBE1low==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25Q-007NBQ-V5; Wed, 08 Sep 2021 18:14:16 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25E-007N8h-Qv for linux-rockchip@lists.infradead.org; Wed, 08 Sep 2021 18:14:06 +0000 Received: by mail-pf1-x42a.google.com with SMTP id 18so2748625pfh.9 for ; Wed, 08 Sep 2021 11:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/7V7rRemEpda86gCcDXaw5uz6xMLDav/RoQNN2RSOuU=; b=jbFgaVCKgsth2Y9eV65+J3eCvsvNnESvcC/38soujbnVAZbIves1S8586ELAEnx/ID A5sxB4nM77/ls5NTbEsxSlx8qIWyPGI+vnIqe+DUiCNLmiPcXL5zS6ex55pZBLAJEuSt 3j3hlsVfGVIHw1ntIBzcRfPc+OpG472RPgryk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/7V7rRemEpda86gCcDXaw5uz6xMLDav/RoQNN2RSOuU=; b=i9OVRkxhrsd6WyoMcpx5Uauc9DopqOdJ0PJzk9Rq/SVmlxH6O/m7blFgVRi536w7Nz D0wFTrYIJO2MwZH+TuTTV3N+rITIOfC97D1ReLl5OOakFREjtSbbuP+Ho+xL3Zsf8zTG ouOP5+TBG8s2CDrvEeq/yhyroAMgGJu+2D0L25EYSRwZHxSWoAoJNaq2FUzblfu+FzJK n2DVMISTdZsKC0RVh1dZAV/zXDyXrfaeAmy4BWY3rDvAau2idDyDQVsqB/F2jDBcRVJO EJ49zvhOjyqpDgMCxk7crO61T3BCB7VEfYVD3xiH2otRl9ILjIJQYltFm+SJvDLhbUkk FhPA== X-Gm-Message-State: AOAM532oSc3//LovLZWD0HKRflkp2c5aE/69a7vOE2gp9X2M0HyYrPcj J6A3sA1tN054ybrJ9CrWz4uIeA== X-Google-Smtp-Source: ABdhPJzS2hRYQ/VhBHUhz7s035X8SA+E503rKFk/O4ISrGfbPXO5LNPQ7UfPtBSGHGxa3j0HeaCRPQ== X-Received: by 2002:a63:d814:: with SMTP id b20mr5014888pgh.268.1631124844338; Wed, 08 Sep 2021 11:14:04 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id k190sm3564254pgc.11.2021.09.08.11.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:14:03 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris , Leo Yan Subject: [PATCH v2 3/3] arm64: dts: rockchip: add Coresight debug range for RK3399 Date: Wed, 8 Sep 2021 11:13:40 -0700 Message-Id: <20210908111337.v2.3.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111404_945509_828C8AE0 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. This IP block can be used for sampling the PC of any given CPU, which is useful in certain panic scenarios where you can't get the CPU to stop cleanly (e.g., hard lockup). Reviewed-by: Leo Yan Reviewed-by: Chen-Yu Tsai Reviewed-by: Douglas Anderson Signed-off-by: Brian Norris --- Changes in v2: - Sort properly arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 3871c7fd83b0..c5fe2d440114 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -361,6 +361,54 @@ usb_host1_ohci: usb@fe3e0000 { status = "disabled"; }; + debug@fe430000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe430000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l0>; + }; + + debug@fe432000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe432000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l1>; + }; + + debug@fe434000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe434000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l2>; + }; + + debug@fe436000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe436000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l3>; + }; + + debug@fe610000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe610000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b0>; + }; + + debug@fe710000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe710000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b1>; + }; + usbdrd3_0: usb@fe800000 { compatible = "rockchip,rk3399-dwc3"; #address-cells = <2>;