From patchwork Wed Sep 8 18:13:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481657 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87057C433F5 for ; Wed, 8 Sep 2021 18:16:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5047260ED8 for ; Wed, 8 Sep 2021 18:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5047260ED8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QQ3yCy/PPTnrsYvojSGhwQS+GsB36CO3Vj7bth7tPRI=; b=uISQx9k2o+QjTl OsrJFZ3IJ5xsFmgUO+utGsaHghHFA3JmMgxpgXlvyVfwcuacsO3/fMvX20mXrlqBczgipkCi2+dfs wShtWzv7Y/5BbjQrs2OVMzeBgQIYrsKgbee5d7cMH4BOGsD/aq+lRjLNiA3cXKuBl/vMMwNJ5ZWUY A+3WLJBnyNM1SmXmJNMhSwC5WtHm8XXW8UVvAkbcuDJdXuH0UuneoZ0yWWVbRc7qBfQjM3yaSnlsX /7N4rwCbON30AlPMwc+q7dh5wz9BCNJ0oSxhRVyqFrStKJnCrIvftwKFSLQg7eqflW34Eha9sBCiL A7M/5Y8dMYolbjL9HwgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25F-007N8c-1q; Wed, 08 Sep 2021 18:14:05 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25A-007N7a-FN for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 18:14:02 +0000 Received: by mail-pg1-x530.google.com with SMTP id f129so3511189pgc.1 for ; Wed, 08 Sep 2021 11:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uzvU0TWDqoO4AhItKda+Ka4vpknel8tSLxFVqVBoaHc=; b=dWLekvtSO0q46ozawqJd+04F7FuB57Cc0/SYjtEAJ/zPKT1iReWuzDc8VmgpGffCxq 74mKvOXwSMsvA3xgPC5At98vactbCz5vxbdwYWaPWteBLn2zgIWeJjocuti+bMFGoqk3 gXkiZClJdgCsQVK/pYBE9UTCRL4aEhZ4ZENpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uzvU0TWDqoO4AhItKda+Ka4vpknel8tSLxFVqVBoaHc=; b=2mYKVQ6vwUAN8KowC0wIaPt8FlVJTd+MTCdDhDAHF65LHi5gZ/7bz7cTlUgNp9PmWm tAXFN1+l5cUo3ftOeAn59Z8XD71VAMZjGP3mSIKM8Vet6FbtfhWQMgrBjgMxBzNMrKVE lcg7NK6Y+sxjUxD9o0Q4nnhkEog+vDOq08Kob5o5MS+IUDXk3o7XYVjtI6zFthd81wtt BtTIWptK9o7DatACDWzUfrYId6XaBBf3tlzgME9AdcMIQoiRDojkgYzarzal/1TzW1N2 LvbMipOS+o9GtTNF4j9SiE3vCGHtn4qapG4oKtlXHDhgvFkkhvbNlLuJx4Vur3OpXNVD 5kYQ== X-Gm-Message-State: AOAM5336QPu74053/K6/+ItUm+wHRE0ltDi1Y8lH7pAjftj5slaZ8My/ c1b9Dvg1RxycziiYkdcW7TkZ683X3sZ41Q== X-Google-Smtp-Source: ABdhPJyDQMGH0+RxUGQtHUeCYv4lJd35HOoioyP4NMAPxkHx4TB4s0fz74029ULAwuaRpQEaZQyUDw== X-Received: by 2002:a63:584:: with SMTP id 126mr4916161pgf.165.1631124839684; Wed, 08 Sep 2021 11:13:59 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id o3sm2709858pji.26.2021.09.08.11.13.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:13:58 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical Date: Wed, 8 Sep 2021 11:13:38 -0700 Message-Id: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111400_561653_3581E60F X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't enable() them -- and even if it did, it's not early enough compared to other consumers -- nor does arch/arm64/kernel/smp.c), and instead are simply assumed to be "on" all the time. They are also parents of a few other clocks which haven't been previously exposed for other devices to consume. If we want to expose those clocks, then the common clock framework may eventually choose to disable their parents (including the CPU PLLs) -- which is no fun for anyone. Thus, mark the CPU clocks as critical, to prevent them from being disabled implicitly. Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson Reviewed-by: Chen-Yu Tsai --- Changes in v2: - New, split from the patch that requires this change drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 62a4f2543960..0ac9c72c4ee8 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -1514,7 +1514,10 @@ static const char *const rk3399_cru_critical_clocks[] __initconst = { "aclk_vio_noc", /* ddrc */ - "sclk_ddrc" + "sclk_ddrc", + + "armclkl", + "armclkb", }; static const char *const rk3399_pmucru_critical_clocks[] __initconst = { @@ -1549,9 +1552,6 @@ static void __init rk3399_clk_init(struct device_node *np) rockchip_clk_register_branches(ctx, rk3399_clk_branches, ARRAY_SIZE(rk3399_clk_branches)); - rockchip_clk_protect_critical(rk3399_cru_critical_clocks, - ARRAY_SIZE(rk3399_cru_critical_clocks)); - rockchip_clk_register_armclk(ctx, ARMCLKL, "armclkl", mux_armclkl_p, ARRAY_SIZE(mux_armclkl_p), &rk3399_cpuclkl_data, rk3399_cpuclkl_rates, @@ -1562,6 +1562,9 @@ static void __init rk3399_clk_init(struct device_node *np) &rk3399_cpuclkb_data, rk3399_cpuclkb_rates, ARRAY_SIZE(rk3399_cpuclkb_rates)); + rockchip_clk_protect_critical(rk3399_cru_critical_clocks, + ARRAY_SIZE(rk3399_cru_critical_clocks)); + rockchip_register_softrst(np, 21, reg_base + RK3399_SOFTRST_CON(0), ROCKCHIP_SOFTRST_HIWORD_MASK); From patchwork Wed Sep 8 18:13:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517A2C433F5 for ; Wed, 8 Sep 2021 18:16:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B6461153 for ; Wed, 8 Sep 2021 18:16:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 21B6461153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FV0g/EHXbKNziw/jCnE0Wyq8rGRsaC8jiIp6LONQzhM=; b=4HIsroaJTwYXGe mghdpDSOHv4im0hMyLaxwIrD+wcKGxd+aD3G2Bkqo5pOEL5Ybg4ZtZ/+qD3Pgd4Fa2s3DAM5DQoj7 acRyIZ7TarRn3ooh3EqmQGhbNEedZrAPRYqKldnZ+mjKQ2KR6vzh5TerykLHrk69Z09PkR7ItEiXd ih3rFco4r7pMu1aswlGa7bS7XUJz41IfPwsbr0dkDjmRJ94JeP0nxtTtgbRhwO1IH1CxgRsvjM1J9 0zOJG2zTonPIIY2LXTqxjQfqtKhel/Nfh1MeqYpL/4aUU5fABe1+Qnbh05iyO8yoaTo7kdGCqw4NJ oiT5li2DFHLZNOocqe7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25T-007NBy-GF; Wed, 08 Sep 2021 18:14:19 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25G-007N7w-1U for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 18:14:07 +0000 Received: by mail-pg1-x52b.google.com with SMTP id w7so3458525pgk.13 for ; Wed, 08 Sep 2021 11:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YmaBqKj8o4HmKcMeIl0Rd4QT1PMQFox+evWowfdT4pM=; b=LhDZLw+XEOIsX47v4NpnWSsriew4EbKSYY+nTXSZ9TmzNi61j7u4637SNRUlYjyoO8 4R4YpmU0eL3um0lTV+i052dCvVbo4xV0OYKht0oajmhCceVIlOxvjPyxbVM/YbGWSWBS ZIRkmc+hJiyaUDFaiaiH2UcD7B2bPGrHAFmv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YmaBqKj8o4HmKcMeIl0Rd4QT1PMQFox+evWowfdT4pM=; b=o7uvZJKXk9D3xJ5U5r6NJpH1fPD9YjMNnsM3HaTJhSanH67vptRsz22547/S7n+CAx p8P4aYw3eY/5KUGB060tRrJIHgNyiKEI1ihfetEJSecoOBFpGhMw0quUbs1+ptCHo0Sl +MtGSqUpjw+z+bXY9HFGHA07nV+ao+8lcWDQtMZlZfljN5R7SS8lT0iLRZYzACMoLXdx nlJ6ezF2DMfcrh/0HNFWEI3iV4KJbNmChMgUJ2Be3BoIP9c543vHmAsio471MVQ3NnO0 9U4fGDfgchr8fZ75Ad+5+NYo8m20yP2fvUEfYHpTsqjaL3FI6+wRQot/sEOaAGS8NrNB SuQw== X-Gm-Message-State: AOAM531b6Av47ldb3GxGUHr0rUTTKjhm8AXdbews0c+046nnCjZT8OLQ 8dyyFWbl6pWcVxMlxsVIkJDViw== X-Google-Smtp-Source: ABdhPJz7vRfq/pAFYK+fNsy+aJ/Sx1OQI+A2rftCimRi2r9//7V/EaLJIn03rX6MPvX0ZYsKroiejA== X-Received: by 2002:a63:ef58:: with SMTP id c24mr4826337pgk.299.1631124841813; Wed, 08 Sep 2021 11:14:01 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id e19sm2982086pfi.139.2021.09.08.11.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:14:01 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v2 2/3] clk: rockchip: rk3399: expose PCLK_COREDBG_{B,L} Date: Wed, 8 Sep 2021 11:13:39 -0700 Message-Id: <20210908111337.v2.2.If29cd838efbcee4450a62b8d84a99b23c86e0a3f@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111406_114476_2ACB6969 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We have DT IDs for PCLK_COREDBG_L and PCLK_COREDBG_B, but we don't actually expose them. Note that this requires the previous patch (making "armclkl" and "armclkb" into "critical" clocks) to prevent these clocks from taking down the CPU. Reviewed-by: Chen-Yu Tsai Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson --- Changes in v2: - Split "CPU clocks are critical" to a new patch, to make it more obvious drivers/clk/rockchip/clk-rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index 0ac9c72c4ee8..53ed5cca335b 100644 --- a/drivers/clk/rockchip/clk-rk3399.c +++ b/drivers/clk/rockchip/clk-rk3399.c @@ -481,7 +481,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { COMPOSITE_NOMUX(0, "atclk_core_l", "armclkl", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(1), 0, 5, DFLAGS | CLK_DIVIDER_READ_ONLY, RK3399_CLKGATE_CON(0), 5, GFLAGS), - COMPOSITE_NOMUX(0, "pclk_dbg_core_l", "armclkl", CLK_IGNORE_UNUSED, + COMPOSITE_NOMUX(PCLK_COREDBG_L, "pclk_dbg_core_l", "armclkl", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(1), 8, 5, DFLAGS | CLK_DIVIDER_READ_ONLY, RK3399_CLKGATE_CON(0), 6, GFLAGS), @@ -531,7 +531,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { GATE(ACLK_GIC_ADB400_CORE_B_2_GIC, "aclk_core_adb400_core_b_2_gic", "armclkb", CLK_IGNORE_UNUSED, RK3399_CLKGATE_CON(14), 4, GFLAGS), - DIV(0, "pclken_dbg_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, + DIV(PCLK_COREDBG_B, "pclken_dbg_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, RK3399_CLKSEL_CON(3), 13, 2, DFLAGS | CLK_DIVIDER_READ_ONLY), GATE(0, "pclk_dbg_cxcs_pd_core_b", "pclk_dbg_core_b", CLK_IGNORE_UNUSED, From patchwork Wed Sep 8 18:13:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12481659 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58044C433F5 for ; Wed, 8 Sep 2021 18:16:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2723D6113D for ; Wed, 8 Sep 2021 18:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2723D6113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WUfP+4O5QLCueoUcLFsznHFINdO1jZ2DPmilf+/tT50=; b=zQePj06OjkpqPh prhzqUyB4iyOBXxcZoPMeC90l78r1Olrwv5ISupbEYbZDxtfRJJUgtpFuH/J8VwfcPWPTHRH046nR QoqVg2wV3fqMc+3ZrTHnrzqJSnU80AsM2M+95WloQINuNDM1ib7HPiy+k8ovp4TBi9oIZYtp15jsi o9CWN7j60TTeQX3nwREjy5r/V9QKN9K5v4HCBsyfUtdT41O60XqXfXHY9EvmnhA82fTWWl3qyFJti UeA5kKwgMpZUD533Ifox7F9zIo+GbY8PHiG7TAUdbOjWcC/pmVtn0mnmG20fwkJGUXIMTv1mIs9FO cqHNauqjZLCwIiJTfTqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25f-007NIm-NX; Wed, 08 Sep 2021 18:14:31 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO25G-007N8g-51 for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 18:14:07 +0000 Received: by mail-pf1-x42e.google.com with SMTP id v123so2745729pfb.11 for ; Wed, 08 Sep 2021 11:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/7V7rRemEpda86gCcDXaw5uz6xMLDav/RoQNN2RSOuU=; b=jbFgaVCKgsth2Y9eV65+J3eCvsvNnESvcC/38soujbnVAZbIves1S8586ELAEnx/ID A5sxB4nM77/ls5NTbEsxSlx8qIWyPGI+vnIqe+DUiCNLmiPcXL5zS6ex55pZBLAJEuSt 3j3hlsVfGVIHw1ntIBzcRfPc+OpG472RPgryk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/7V7rRemEpda86gCcDXaw5uz6xMLDav/RoQNN2RSOuU=; b=iAfO8M4jr7B0cgVED/9AMmx4IytHp/JO298bNeeVsVbvb8I45KSYsNgafI2y0f/Tly +CdcJaZxf1tjB/UD48JeiZm3TXoL0acthdE44DgFr/iBB4YpgOVg5hwZYJqARlpM5+7D h50UlLfCSddIqEYyfErZ5+ZR6ZztfWsOcMP/1BMNbfOn8MC1BAoEEoe8INusoglzkaXm LslxE4+ez+IzVWuJGmPH+/yY6E5b+ftE8KY6ud5nz332Dt0otWeSvwvkEMVR6QmABTnE ia3K2ykEF/EzLBMLcDwZJV2i+2B0cyFYsO88lVqrznkVXu2ezz6dRsMWWmPAzc9F6AOu Rc1g== X-Gm-Message-State: AOAM530cg6Rv3AnR0dBJ2mD+DJ0vGD6IBBMvQBOcyGLNeXcf93A3JW17 6mwzU4OUjEOGg2ijYh16ttNRwQ== X-Google-Smtp-Source: ABdhPJzS2hRYQ/VhBHUhz7s035X8SA+E503rKFk/O4ISrGfbPXO5LNPQ7UfPtBSGHGxa3j0HeaCRPQ== X-Received: by 2002:a63:d814:: with SMTP id b20mr5014888pgh.268.1631124844338; Wed, 08 Sep 2021 11:14:04 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7556:e88d:6fba:e1d0]) by smtp.gmail.com with UTF8SMTPSA id k190sm3564254pgc.11.2021.09.08.11.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 11:14:03 -0700 (PDT) From: Brian Norris To: Heiko Stuebner , Michael Turquette , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Chen-Yu Tsai , Douglas Anderson , linux-kernel@vger.kernel.org, Brian Norris , Leo Yan Subject: [PATCH v2 3/3] arm64: dts: rockchip: add Coresight debug range for RK3399 Date: Wed, 8 Sep 2021 11:13:40 -0700 Message-Id: <20210908111337.v2.3.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_111406_223683_DFFFEC58 X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. This IP block can be used for sampling the PC of any given CPU, which is useful in certain panic scenarios where you can't get the CPU to stop cleanly (e.g., hard lockup). Reviewed-by: Leo Yan Reviewed-by: Chen-Yu Tsai Reviewed-by: Douglas Anderson Signed-off-by: Brian Norris --- Changes in v2: - Sort properly arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 3871c7fd83b0..c5fe2d440114 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -361,6 +361,54 @@ usb_host1_ohci: usb@fe3e0000 { status = "disabled"; }; + debug@fe430000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe430000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l0>; + }; + + debug@fe432000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe432000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l1>; + }; + + debug@fe434000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe434000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l2>; + }; + + debug@fe436000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe436000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l3>; + }; + + debug@fe610000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe610000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b0>; + }; + + debug@fe710000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe710000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b1>; + }; + usbdrd3_0: usb@fe800000 { compatible = "rockchip,rk3399-dwc3"; #address-cells = <2>;