From patchwork Wed Sep 15 23:42:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC3FC433F5 for ; Wed, 15 Sep 2021 23:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 655F4610E8 for ; Wed, 15 Sep 2021 23:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232836AbhIOXoD (ORCPT ); Wed, 15 Sep 2021 19:44:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:46002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233046AbhIOXoC (ORCPT ); Wed, 15 Sep 2021 19:44:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3681D60F25; Wed, 15 Sep 2021 23:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749363; bh=akhkseP0HxlKQgboG45vrPGrtJzRdIda17AZwq8T3eo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UCYNwoYxK2wHgZvfm4XuISKD5XFvQNvSqKUWdKNu0yS0+Fs8xcve16BX7p9hlLZMQ K93cpceW9SKOH0aSKB7ZowA2j9RLqb3BsRLgE6qQTE/9ECEHy7eFV7ZOC/0WWo34F5 Eu+3s6BKR4tTDBeyU+8Si2UPkXnJeMsAd+Ka5k2xPKQ08EDflGYleP59QVG14nzha4 ebh2PfeE7jLV3StyBPGMNHsyG57UTX3yn07JbnmmwEfASoXEn03sgjaVveQF8Vph6S j83wju+fzT2jx7NoUEVaWhAkXpA6qW9dSDDP5tQYwD2wyw8tGJthzk/lt4IxNlgiyV PaRi6kTAV9gSg== Subject: [PATCH 1/9] ceph: re-tag copy_file_range as being in the copy_range group From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:42:42 -0700 Message-ID: <163174936296.380880.5004927987240020121.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong copy_range is the group name for copy_file_range tests, so reclassify these tests. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Amir Goldstein --- tests/ceph/001 | 2 +- tests/ceph/002 | 2 +- tests/ceph/003 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ceph/001 b/tests/ceph/001 index aca77168..c00de308 100755 --- a/tests/ceph/001 +++ b/tests/ceph/001 @@ -11,7 +11,7 @@ # file and 3) the middle of the dst file. # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter diff --git a/tests/ceph/002 b/tests/ceph/002 index 428f23a9..9bc728fd 100755 --- a/tests/ceph/002 +++ b/tests/ceph/002 @@ -20,7 +20,7 @@ # linux kernel: 78beb0ff2fec ("ceph: use copy-from2 op in copy_file_range") # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter diff --git a/tests/ceph/003 b/tests/ceph/003 index 9f8c6068..faedb48c 100755 --- a/tests/ceph/003 +++ b/tests/ceph/003 @@ -7,7 +7,7 @@ # Test copy_file_range with infile = outfile # . ./common/preamble -_begin_fstest auto quick copy +_begin_fstest auto quick copy_range # get standard environment . common/filter From patchwork Wed Sep 15 23:42:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793ECC433F5 for ; Wed, 15 Sep 2021 23:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A370610E8 for ; Wed, 15 Sep 2021 23:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232982AbhIOXoM (ORCPT ); Wed, 15 Sep 2021 19:44:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233280AbhIOXoI (ORCPT ); Wed, 15 Sep 2021 19:44:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AE4EF60F25; Wed, 15 Sep 2021 23:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749368; bh=tT/mGLd4kItwm7Ge6257Bqs1Xr0PhVhHfPEySTspvHA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=N+ht+hpLeMe3oqlIcDSoJMdTgm5Y1MEn2VXoBHipDUVCAgjeccTpcX/Qo40dDUKxD hyXrlU8GEm1UXh1n1U/W5GLMZ8dc+8Tt5fTNY6Iwwl+jFalPtjg7pWGJLZe9waGhCF uZpEpH02iUhMZKlOdNObF0iZVKQqZPHL4w9hb0cL60uStxuvg+8Br+0ibzncVLpr/k 4m4u/DNEofmR2Vs3gNnopIrkY8mDf5U1VQ+i6OFI51oRnAMUaV9PJZr14qXcAXDUp0 q5jFjmg3BCpuzCKXqdMGpZ5/RbgCbb7Wylbu/MUaCGBGJXsueRglVcWHpxNiy68waK v5rUILxCD8XlQ== Subject: [PATCH 2/9] xfs: move reflink tests into the clone group From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:42:48 -0700 Message-ID: <163174936843.380880.4944637627844574386.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong "clone" is the group for tests that exercise FICLONERANGE, so move these tests. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Amir Goldstein --- tests/xfs/519 | 2 +- tests/xfs/520 | 2 +- tests/xfs/535 | 2 +- tests/xfs/536 | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/xfs/519 b/tests/xfs/519 index 675ec07e..49c62b56 100755 --- a/tests/xfs/519 +++ b/tests/xfs/519 @@ -9,7 +9,7 @@ # flushing the log and then remounting to check file contents. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter diff --git a/tests/xfs/520 b/tests/xfs/520 index 8410f2ba..2fceb07c 100755 --- a/tests/xfs/520 +++ b/tests/xfs/520 @@ -12,7 +12,7 @@ # is included in the current kernel. # . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Override the default cleanup function. _cleanup() diff --git a/tests/xfs/535 b/tests/xfs/535 index 4c883675..1a5da61b 100755 --- a/tests/xfs/535 +++ b/tests/xfs/535 @@ -7,7 +7,7 @@ # Verify that XFS does not cause inode fork's extent count to overflow when # writing to a shared extent. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter diff --git a/tests/xfs/536 b/tests/xfs/536 index e5f904f5..64fa4fbf 100755 --- a/tests/xfs/536 +++ b/tests/xfs/536 @@ -7,7 +7,7 @@ # Verify that XFS does not cause inode fork's extent count to overflow when # remapping extents from one file's inode fork to another. . ./common/preamble -_begin_fstest auto quick reflink +_begin_fstest auto quick clone # Import common functions. . ./common/filter From patchwork Wed Sep 15 23:42:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0744C433EF for ; Wed, 15 Sep 2021 23:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7A9D610E8 for ; Wed, 15 Sep 2021 23:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232836AbhIOXoQ (ORCPT ); Wed, 15 Sep 2021 19:44:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:46222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233046AbhIOXoO (ORCPT ); Wed, 15 Sep 2021 19:44:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 25E1960F8F; Wed, 15 Sep 2021 23:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749374; bh=rxk/t4cR1g4piI1VKbOEcrL83pmv/7seWPEVoC2Ns3s=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Mqe2Rc8mdkkaVqdZ/tuFLqtb9Sf3m7jj+RYwixWZYeZLgQKJalldUSqaw8WXzRJzL AuZLsrOXCdqYpuTl9PuaWk6UfgRSEjoyCRUDq4nq2nzJUQ96XWSnS1yfHPxksbUSKQ wVcQegHdJD+phjYpaYLZyQ9a6ijHqH8zyf2Z2EnSqX3dmKuvJ0ivsLGFh6eA/Kcmh0 R3clduMlYiygabJR6ZR/YZI8Wgx2CggAo74+V+X3iMtIPx0I8o4dARDP0trzHsFllv FGR5vYkr62OLoqJL8exe4s/iDhH6fa7AYH5ws52yJKLow0hgSNeeRU6z9GcgwUdcoM 63yy7Xk9BwJBQ== Subject: [PATCH 3/9] xfs: fix incorrect fuzz test group name From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:42:53 -0700 Message-ID: <163174937390.380880.10714985927715519622.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong The group name for fuzz tests is 'fuzzers'. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Amir Goldstein --- tests/xfs/491 | 2 +- tests/xfs/492 | 2 +- tests/xfs/493 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/xfs/491 b/tests/xfs/491 index 5c7c5d1f..7402b09a 100755 --- a/tests/xfs/491 +++ b/tests/xfs/491 @@ -7,7 +7,7 @@ # Test detection & fixing of bad summary block counts at mount time. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter diff --git a/tests/xfs/492 b/tests/xfs/492 index 8258e5d8..514ac1e4 100755 --- a/tests/xfs/492 +++ b/tests/xfs/492 @@ -7,7 +7,7 @@ # Test detection & fixing of bad summary inode counts at mount time. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter diff --git a/tests/xfs/493 b/tests/xfs/493 index 58fd9c99..58091ad7 100755 --- a/tests/xfs/493 +++ b/tests/xfs/493 @@ -8,7 +8,7 @@ # Corrupt the AGFs to test mount failure when mount-fixing fails. # . ./common/preamble -_begin_fstest auto quick fuzz +_begin_fstest auto quick fuzzers # Import common functions. . ./common/filter From patchwork Wed Sep 15 23:42:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0516CC433F5 for ; Wed, 15 Sep 2021 23:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2973610FF for ; Wed, 15 Sep 2021 23:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233067AbhIOXoT (ORCPT ); Wed, 15 Sep 2021 19:44:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:46326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232982AbhIOXoT (ORCPT ); Wed, 15 Sep 2021 19:44:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 930C160F25; Wed, 15 Sep 2021 23:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749379; bh=HnvHdXUFsYt+iyC811yisJQSfgq/QzkZiKdK/DhqPRw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=lWrIrE8VG9TJ2Uj0cBKhUHy9aRY77p49i41ZZrtuby6fwo0Qt6Sn9olBEZIkkWpn2 cEzwbzXV53dYbq6C0mG3mOBfcb3nDJnPp+jjkMpKuTH4t/apvHnhMcTYcM/zP2G0HV vp2exG8yWNrvXzUUa6tAnyJ3xtHgSF88mjO5ZyOoExrJV4Gt/dZBrPGpgLArLDkyuq g+3q6a3NX76ZnwiBytdlJ1WYDFqIn++TzG+5f39kH9byMefX17vbGjkfnKyEor1Aiz SH/ejiKVFfAIwmulWzdwHTamivIvtOoZNlcd733Cq12H88kRD9xejCHQGLrH9Lz9Ga N9kMMgK5c+b8A== Subject: [PATCH 4/9] btrfs: fix incorrect subvolume test group name From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:42:59 -0700 Message-ID: <163174937934.380880.8949346653026672201.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong The group for testing subvolume functionality is 'subvol', not 'subvolume'. Signed-off-by: Darrick J. Wong Reviewed-by: Amir Goldstein --- tests/btrfs/233 | 2 +- tests/btrfs/245 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/btrfs/233 b/tests/btrfs/233 index f3e3762c..6a414443 100755 --- a/tests/btrfs/233 +++ b/tests/btrfs/233 @@ -9,7 +9,7 @@ # performed. # . ./common/preamble -_begin_fstest auto quick subvolume +_begin_fstest auto quick subvol # Override the default cleanup function. _cleanup() diff --git a/tests/btrfs/245 b/tests/btrfs/245 index 2b9c63c7..f3380ac2 100755 --- a/tests/btrfs/245 +++ b/tests/btrfs/245 @@ -8,7 +8,7 @@ # as subvolume and snapshot creation and deletion. # . ./common/preamble -_begin_fstest auto quick idmapped subvolume +_begin_fstest auto quick idmapped subvol # get standard environment, filters and checks . ./common/rc From patchwork Wed Sep 15 23:43:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A43C9C433F5 for ; Wed, 15 Sep 2021 23:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ACB760F25 for ; Wed, 15 Sep 2021 23:43:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbhIOXo0 (ORCPT ); Wed, 15 Sep 2021 19:44:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:46426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232740AbhIOXoZ (ORCPT ); Wed, 15 Sep 2021 19:44:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0950260F8F; Wed, 15 Sep 2021 23:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749385; bh=nzD09Q/tAZ4eU7/GUDYfiWz1uRucqWOZNgFTCrx3700=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Sjg09MUZolXnCuheVwKi70hNvToBeJW3LKoLwedp4NeN8uKGkYc85miA70d+drGlv qXRk13cM6FCwAOjHlng3UNQFoSAQ8gd67ZErwE+qK9RZWgmHZ+J44ZS7x84qqOLeyy 17GLZ86rPTTS+vsxgOe2PkkbC4/OagNoMskWsDGM+h3oFcUVAsesU641Yghav/Dq4Z kUZNij2k3HealWyRKusd5Je9tI67VwULwsHLprV8Xkn8gil16cjPCqqPE00SJNDWhl zXNL7J2YtKEkPyv4jUeoEhnpo5n8rIDUcvfVr8ajWb6IHGA2qz1FbfKMvTXqEGmvg8 12YsA6SnBjphw== Subject: [PATCH 5/9] generic/631: change this test to use the 'whiteout' group From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:43:04 -0700 Message-ID: <163174938478.380880.9077916198891395416.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong This test isn't really an overlay test; it's a regression test for a bug that someone found in xfs handling of whiteout files. Since the 'overlay' group has one member, let's move it to 'whiteout'. Signed-off-by: Darrick J. Wong Reviewed-by: Amir Goldstein --- tests/generic/631 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/631 b/tests/generic/631 index a1acdedb..aae181dd 100755 --- a/tests/generic/631 +++ b/tests/generic/631 @@ -22,7 +22,7 @@ # in xfs_rename"). . ./common/preamble -_begin_fstest auto rw overlay rename +_begin_fstest auto rw whiteout rename # Override the default cleanup function. _cleanup() From patchwork Wed Sep 15 23:43:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A349CC433F5 for ; Wed, 15 Sep 2021 23:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D256610FF for ; Wed, 15 Sep 2021 23:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232740AbhIOXoa (ORCPT ); Wed, 15 Sep 2021 19:44:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:46524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232836AbhIOXoa (ORCPT ); Wed, 15 Sep 2021 19:44:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7429E60F8F; Wed, 15 Sep 2021 23:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749390; bh=vFdU1gYYNcZXvqyxGHUrERl+DiKStdLv+nCK/u3nZ6g=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=NRpDQr0dRkQhmTq3u4gUW42ncZSc5NNGkdeYGNRqwxXUyKU6uhf38iFq7wEvwS/TC YuOM0OoEDvULmHq4GKVcAnKa4dwSLdal8LN0uWqWKuT3loRUtHJvB5f7TXLJvq8QNs AiKIJ1IaVcGE2AOonHQtUcKgn84aIEvURIdtz/187SBwJ3z05mUoaoCettiiyKO3HM yVQwSFGLu3ArAUrq5tyYCObh1b3ctJDAk3coGmspOSyWQr4iSiSSPOyNXGPeoUe81V 09LxIppmiUOj6kgu/3nBfi8XnxaTqSAcl3Z3a+535M8vZTJYrJg7FD0MRZkyOq2szJ V3xDa9QBSP0nA== Subject: [PATCH 6/9] tools: make sure that test groups are described in the documentation From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:43:10 -0700 Message-ID: <163174939022.380880.4370326262613244115.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong Create a file to document the purpose of each test group that is currently defined in fstests, and change mkgroupfile to check that every group mentioned in the tests is also mentioned in the documentation. Signed-off-by: Darrick J. Wong Reviewed-by: Amir Goldstein --- common/preamble | 21 ++++++++ doc/group-names.txt | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++ tools/mkgroupfile | 33 +++++++++--- 3 files changed, 181 insertions(+), 8 deletions(-) create mode 100644 doc/group-names.txt diff --git a/common/preamble b/common/preamble index 66b0ed05..64d79385 100644 --- a/common/preamble +++ b/common/preamble @@ -23,6 +23,26 @@ _register_cleanup() trap "${cleanup}exit \$status" EXIT HUP INT QUIT TERM $* } +# Make sure each group is in the documentation file. +_check_groups() { + test -n "$GROUPNAME_DOC_FILE" || return 0 + + local testname="$(echo "$0" | sed -e 's/^.*tests\///g')" + declare -a missing=() + + for group in "$@"; do + if ! grep -q "^${group}[[:space:]]" "$GROUPNAME_DOC_FILE"; then + missing+=("\"${group}\"") + fi + done + test "${#missing}" -eq 0 && return 0 + + local suffix= + test "${#missing}" -gt 1 && suffix="s" + echo "$testname: group$suffix ${missing[@]} not mentioned in documentation." 1>&2 + return 1 +} + # Prepare to run a fstest by initializing the required global variables to # their defaults, sourcing common functions, registering a cleanup function, # and removing the $seqres.full file. @@ -42,6 +62,7 @@ _begin_fstest() # If we're only running the test to generate a group.list file, # spit out the group data and exit. if [ -n "$GENERATE_GROUPS" ]; then + _check_groups "$@" || exit 1 echo "$seq $@" exit 0 fi diff --git a/doc/group-names.txt b/doc/group-names.txt new file mode 100644 index 00000000..e8e3477e --- /dev/null +++ b/doc/group-names.txt @@ -0,0 +1,135 @@ +======================= ======================================================= +Group Name: Description: +======================= ======================================================= +all All known tests, automatically generated by ./check at + runtime +auto Tests that should be run automatically. These should + not require more than ~5 minutes to run. +quick Tests that should run in under 30 seconds. +deprecated Old tests that should not be run. + +acl Access Control Lists +admin xfs_admin functionality +aio general libaio async io tests +atime file access time +attr extended attributes +attr2 xfs v2 extended aributes +balance btrfs tree rebalance +bigtime timestamps beyond the year 2038 +blockdev block device functionality +broken broken tests +cap Linux capabilities +casefold directory name casefolding +ci ASCII case-insensitive directory name lookups +clone FICLONE/FICLONERANGE ioctls +clone_stress stress testing FICLONE/FICLONERANGE +collapse fallocate FALLOC_FL_COLLAPSE_RANGE +compress file compression +convert btrfs ext[34] conversion tool +copy xfs_copy functionality +copy_range copy_file_range syscall +copyup overlayfs copyup +dangerous dangerous test that can crash the system +dangerous_bothrepair fuzzers to evaluate xfs_scrub + xfs_repair repair +dangerous_fuzzers fuzzers that can crash your computer +dangerous_norepair fuzzers to evaluate kernel metadata verifiers +dangerous_online_repair fuzzers to evaluate xfs_scrub online repair +dangerous_repair fuzzers to evaluate xfs_repair offline repair +dangerous_scrub fuzzers to evaluate xfs_scrub checking +data data loss checkers +dax direct access mode for persistent memory files +db xfs_db functional tests +dedupe FIEDEDUPERANGE ioctl +defrag filesystem defragmenters +dir directory test functions +dump dump and restore utilities +eio IO error reporting +encrypt encrypted file contents +enospc ENOSPC error reporting +exportfs file handles +filestreams XFS filestreams allocator +freeze filesystem freeze tests +fsck general fsck tests +fsmap FS_IOC_GETFSMAP ioctl +fsr XFS free space reorganizer +fuzzers filesystem fuzz tests +growfs increasing the size of a filesystem +hardlink hardlinks +health XFS health reporting +idmapped idmapped mount functionality +inobtcount XFS inode btree count tests +insert fallocate FALLOC_FL_INSERT_RANGE +ioctl general ioctl tests +io_uring general io_uring async io tests +label filesystem labelling +limit resource limits +locks file locking +log metadata logging +logprint xfs_logprint functional tests +long_rw long-soak read write IO path exercisers +metacopy overlayfs metadata-only copy-up +metadata filesystem metadata update exercisers +metadump xfs_metadump/xfs_mdrestore functionality +mkfs filesystem formatting tools +mount mount option and functionality checks +nested nested overlayfs instances +nfs4_acl NFSv4 access control lists +nonsamefs overlayfs layers on different filesystems +online_repair online repair functionality tests +other dumping ground, do not add more tests to this group +pattern specific IO pattern tests +perms access control and permission checking +pipe pipe functionality +pnfs PNFS +posix POSIX behavior conformance +prealloc fallocate for preallocating unwritten space +preallocrw fallocate, then read and write +punch fallocate FALLOC_FL_PUNCH_HOLE +qgroup btrfs qgroup feature +quota filesystem usage quotas +raid btrfs RAID +realtime XFS realtime volumes +recoveryloop crash recovery loops +redirect overlayfs redirect_dir feature +remote dump and restore with a remote tape +remount remounting filesystems +rename rename system call +repair xfs_repair functional tests +replace btrfs device replace +replay dm-logwrites replays +resize resize2fs functionality tests +richacl rich ACL feature +rmap XFS reverse mapping exercisers +rotate overlayfs upper layer rotate tests from the unionmount + test suite +rw read/write IO tests +samefs overlayfs when all layers are on the same fs +scrub filesystem metadata scrubbers +seed btrfs seeded filesystems +seek llseek functionality +send btrfs send/receive +shrinkfs decreasing the size of a filesystem +shutdown FS_IOC_SHUTDOWN ioctl +snapshot btrfs snapshots +soak long running soak tests of any kind +spaceman xfs_spaceman functional tests +splice splice system call +stress fsstress filesystem exerciser +subvol btrfs subvolumes +swap swap files +symlink symbolic links +tape dump and restore with a tape +thin thin provisioning +trim FITRIM ioctl +udf UDF functionality tests +union tests from the unionmount test suite +unlink O_TMPFILE unlinked files +unshare fallocate FALLOC_FL_UNSHARE_RANGE +v2log XFS v2 log format tests +verity fsverity +volume btrfs volume management +whiteout overlayfs whiteout functionality +xino overlayfs xino feature +zero fallocate FALLOC_FL_ZERO_RANGE +zone zoned (SMR) device support +======================= ======================================================= diff --git a/tools/mkgroupfile b/tools/mkgroupfile index 0681e5d2..e4244507 100755 --- a/tools/mkgroupfile +++ b/tools/mkgroupfile @@ -9,12 +9,28 @@ fi test_dir="$PWD" groupfile="$1" +GROUPNAME_DOC_FILE="$(readlink -m ../../doc/group-names.txt)" +export GROUPNAME_DOC_FILE if [ ! -x ../../check ]; then echo "$0: Run this from tests/XXX/." exit 1 fi +cleanup() { + test -z "$groupfile" && return + test -z "$ngroupfile" && return + + if [ $ret -eq 0 ]; then + mv "$ngroupfile" "$groupfile" + else + rm -f "$ngroupfile" + fi +} + +ret=1 # trigger cleanup of temporary files unless we succeed +trap 'cleanup; exit $ret' EXIT INT TERM QUIT + generate_groupfile() { cat << ENDL # QA groups control file, automatically generated. @@ -24,19 +40,20 @@ ENDL cd ../../ export GENERATE_GROUPS=yes grep -R -l "^_begin_fstest" "$test_dir/" 2>/dev/null | while read testfile; do - test -x "$testfile" && "$testfile" + test -x "$testfile" && "$testfile" || return 1 done | sort -g + ret="${PIPESTATUS[1]}" cd "$test_dir" } if [ -z "$groupfile" ] || [ "$groupfile" = "-" ]; then # Dump the group file to stdout and exit + unset groupfile generate_groupfile - exit 0 +else + # Otherwise, write the group file to disk somewhere. + ngroupfile="${groupfile}.new" + rm -f "$ngroupfile" + generate_groupfile >> "$ngroupfile" + # let cleanup rename or delete ngroupfile fi - -# Otherwise, write the group file to disk somewhere. -ngroupfile="${groupfile}.new" -rm -f "$ngroupfile" -generate_groupfile >> "$ngroupfile" -mv "$ngroupfile" "$groupfile" From patchwork Wed Sep 15 23:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F8BC433EF for ; Wed, 15 Sep 2021 23:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CF7B60F8F for ; Wed, 15 Sep 2021 23:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229769AbhIOXog (ORCPT ); Wed, 15 Sep 2021 19:44:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:46626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233088AbhIOXof (ORCPT ); Wed, 15 Sep 2021 19:44:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E115A60F25; Wed, 15 Sep 2021 23:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749396; bh=Aem0n8k7yKOwaFfh9ieEOEKzi9tgK38YiIxKjHcKQ9I=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=EBL+kcdy3r+/6okeGFip45zqf6USP6b1kGZQ+ksOs9ZKqkEjSCJQAnd9Nk1yW6Smb Q26rtsTpRbweJRaOEi1fj0ZN0CRAx++IRWmcOHpV2WljGTHZ3F+hQGOn7Np8wa21Re LLKxhnzxbDHdQVpJiMx7zA5uzzZy99wjJOWFunl3jQyYp3lQKC2NKxr+B8R+iojtRX CFnKCjmUFlSRqExkbp7cYXnb0ynqvKfS5DcMFoX9rFZszPBTmik6AGJQsEiKR57KKg Is+OvFFwKwhaRJFPB6X3uwD1qlNCi9Fg52LkcPS0XYp1nPbAU9QIvvffJDgmi6/uU8 WxyOJCSq9N0eg== Subject: [PATCH 7/9] tools: add missing license tags to my scripts From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: "Darrick J. Wong" , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:43:15 -0700 Message-ID: <163174939566.380880.290670167130749389.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong I forgot to add spdx license tags and copyright statements to some of the tools that I've contributed to fstests. Fix this to be explicit. Signed-off-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Reviewed-by: Amir Goldstein --- tools/mkgroupfile | 4 +++- tools/mvtest | 5 ++++- tools/nextid | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/mkgroupfile b/tools/mkgroupfile index e4244507..634ec92c 100755 --- a/tools/mkgroupfile +++ b/tools/mkgroupfile @@ -1,5 +1,7 @@ #!/bin/bash - +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 Oracle. All Rights Reserved. +# # Generate a group file from the _begin_fstest call in each test. if [ "$1" = "--help" ]; then diff --git a/tools/mvtest b/tools/mvtest index 5088b45f..99b15414 100755 --- a/tools/mvtest +++ b/tools/mvtest @@ -1,6 +1,9 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2015 Oracle. All Rights Reserved. +# +# Move a test and update the golden output file. -# Renumber a test dir="$(dirname "$0")" if [ -z "$1" ] || [ "$1" = "--help" ]; then diff --git a/tools/nextid b/tools/nextid index 9507de29..9e31718c 100755 --- a/tools/nextid +++ b/tools/nextid @@ -1,5 +1,7 @@ #!/bin/bash - +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2015 Oracle. All Rights Reserved. +# # Compute the next available test id in a given test directory. if [ $# != 1 ] || [ "$1" = "--help" ] || [ ! -d "tests/$1/" ]; then From patchwork Wed Sep 15 23:43:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C347BC433F5 for ; Wed, 15 Sep 2021 23:43:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB835610FF for ; Wed, 15 Sep 2021 23:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232836AbhIOXol (ORCPT ); Wed, 15 Sep 2021 19:44:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhIOXok (ORCPT ); Wed, 15 Sep 2021 19:44:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FDD260F25; Wed, 15 Sep 2021 23:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749401; bh=GRcPOIw1lNn1TdWhOuyKf5aex8PKCEBHDTJwOCI6KVw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Zv0oMebsl+DDyapzqVB15uBYImCcJEHa7aK4fKhjSjm75aEDqI3YKaXUYsJMeimrM xhY+CinkHOAj6IoXoelKRNcdxguJ5Gp3qZqwXseean6sCsaz2Q9/SWzbbwscRYF06q 8qtBZJa2I3m6b8vjIz9XLug5CRHm0RFkdsjV76TAuYVEashcJBXbOmzeBtqzbjHAcw 9kobXSt3MUIoaanTgkgVX4Lj6PB0Ij8rFVptsxCHGqKvVJiRCrj9jEaaUrkz35BQBa +SdJU6A204CEibJZQyPVviJkoUEmN45s/uuD20JyuyDR0rBTDRezTe7XGHeDs4p/xo nGUv+E8/WfvwQ== Subject: [PATCH 8/9] new: only allow documented test group names From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:43:21 -0700 Message-ID: <163174940111.380880.3160888950588893158.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong Now that we require all group names to be listed in doc/group-names.txt, we can use that (instead of running mkgroupfile) to check if the group name(s) supplied by the user actually exist. This has the secondary effect of being a second nudge towards keeping the description of groups up to date. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Amir Goldstein --- new | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/new b/new index 2097a883..6b7dc5d4 100755 --- a/new +++ b/new @@ -83,6 +83,14 @@ then exit 1 fi +# Extract group names from the documentation. +group_names() { + awk '/^[[:lower:][:digit:]_]/ { + if ($1 != "" && $1 != "Group" && $2 != "Name:" && $1 != "all") + printf("%s\n", $1); + }' doc/group-names.txt +} + if [ $# -eq 0 ] then @@ -93,16 +101,7 @@ then [ -z "$ans" ] && ans=other if [ "X$ans" = "X?" ] then - for d in $SRC_GROUPS; do - (cd "tests/$d/" ; ../../tools/mkgroupfile "$tmpfile") - l=$(sed -n < "$tmpfile" \ - -e 's/#.*//' \ - -e 's/$/ /' \ - -e 's;\(^[0-9][0-9][0-9]\)\(.*$\);\2;p') - grpl="$grpl $l" - done - lst=`for word in $grpl; do echo $word; done | sort| uniq ` - echo $lst + echo $(group_names) else # only allow lower cases, spaces, digits and underscore in group inval=`echo $ans | tr -d '[:lower:][:space:][:digit:]_'` @@ -120,11 +119,10 @@ then else # expert mode, groups are on the command line # - (cd "$tdir" ; ../../tools/mkgroupfile "$tmpfile") for g in $* do - if ! grep -q "[[:space:]]$g" "$tmpfile"; then - echo "Warning: group \"$g\" not defined in $tdir tests" + if ! grep -q "^$g" doc/group-names.txt; then + echo "Warning: group \"$g\" not defined in documentation" fi done ans="$*" From patchwork Wed Sep 15 23:43:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12497911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2FDC433F5 for ; Wed, 15 Sep 2021 23:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A82BE60F25 for ; Wed, 15 Sep 2021 23:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232749AbhIOXou (ORCPT ); Wed, 15 Sep 2021 19:44:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:46836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhIOXoq (ORCPT ); Wed, 15 Sep 2021 19:44:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D071960F25; Wed, 15 Sep 2021 23:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631749406; bh=Wwnf7Myvevd+6SzfYQlIGdUlsu5mvL+Va58aS8i5qYg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=VnI/EJ52VVfIog8KBu4tfDc7TO1DoN9yO8P2JTbzXchdrm8ptuil5FfKAZDQy40S2 QLDsHA/afmA1njtVbykUeB+OZb36WeNmsXuO2biJ0UG3xQ1ofZJ/v+U9hSYYVJiUxM cJCrIbe/FlFgckZ4rO+C36Vdz9OMI7Dipgf0GrXWPDMcMzEyXMA9mznpxFlLqbWPGg 1pZ8Dscg02ZjA7PR6WR/E30vy5s71L4EfFxoVZlnBQP3SIVI8FONZcJTOfDJMhKjKN mzzmOi+1H9tJ0EgkBzWoLnzhlOVHJWQc4VLlGvV8OJneTm8WA3/sf1eGli8f4/MG0M cBKKoHsqNyAiw== Subject: [PATCH 9/9] new: don't allow new tests in group 'other' From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Wed, 15 Sep 2021 16:43:26 -0700 Message-ID: <163174940659.380880.14564845266535022734.stgit@magnolia> In-Reply-To: <163174935747.380880.7635671692624086987.stgit@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong The 'other' group is vaguely defined at best -- other than what? It's not clear what tests belong in this group, and it has become a dumping ground for random stuff that are classified in other groups. Don't let people create new other group tests. Signed-off-by: Darrick J. Wong --- new | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/new b/new index 6b7dc5d4..5cf96c50 100755 --- a/new +++ b/new @@ -96,9 +96,9 @@ then while true do - echo -n "Add to group(s) [other] (separate by space, ? for list): " + echo -n "Add to group(s) [auto] (separate by space, ? for list): " read ans - [ -z "$ans" ] && ans=other + [ -z "$ans" ] && ans=auto if [ "X$ans" = "X?" ] then echo $(group_names) @@ -109,6 +109,9 @@ then echo "Invalid characters in group(s): $inval" echo "Only lower cases, digits and underscore are allowed in groups, separated by space" continue + elif echo "$ans" | grep -q -w "other"; then + echo "Do not add more tests to group \"other\"." + continue else # remove redundant spaces/tabs ans=`echo "$ans" | sed 's/\s\+/ /g'`