From patchwork Thu Sep 16 07:37:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cai,Huoqing" X-Patchwork-Id: 12498163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4CCC433F5 for ; Thu, 16 Sep 2021 07:39:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C53F660E76 for ; Thu, 16 Sep 2021 07:39:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C53F660E76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baidu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BuWwgJ6MZ3Vnxh3cRsXtV0E8D7udpwT+3B2gXBQJd1g=; b=N5aYaIkRr/5L8R gkmn2DFot0Ax1VeKr11a+U5YUFLuilE7/DY5i7IOM6VBfsWGJJGdDhThz0UYCpkMnGRHnqJ3YO4Ji NAcfC0So7US7mAxk0ofQCs14j8npmZ9suOPA2FXENQv4ntJQDXGZwf/6NZQGn4Cov+IOiWwpBpq8W zDIMxFOzyxJkb+TfNH5/GdEaUJjbr9sPrkwb7d9izNs9jSfK5wihwoMH+R3kHXHU5G8796dtRgPmY m9YnNg99BxFa2pBP/g41AiwWCtFXElLvh9eXYB699yXEAKoqjpKfKG91hT3vyVGWuWoWCGHDZgK+9 dGnio7uWbamrc8gkyGlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQlxe-00AUP5-UX; Thu, 16 Sep 2021 07:37:35 +0000 Received: from mx22.baidu.com ([220.181.50.185] helo=baidu.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQlxa-00AUN3-81 for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 07:37:32 +0000 Received: from BC-Mail-Ex03.internal.baidu.com (unknown [172.31.51.43]) by Forcepoint Email with ESMTPS id 3F30E44C953BCB3ABA48; Thu, 16 Sep 2021 15:37:20 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BC-Mail-Ex03.internal.baidu.com (172.31.51.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Thu, 16 Sep 2021 15:37:19 +0800 Received: from LAPTOP-UKSR4ENP.internal.baidu.com (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 16 Sep 2021 15:37:19 +0800 From: Cai Huoqing To: CC: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , David Airlie , "Daniel Vetter" , Maxime Coquelin , Alexandre Torgue , , , , Subject: [PATCH] drm/stm: dsi: Improve use of dev_err_probe() Date: Thu, 16 Sep 2021 15:37:13 +0800 Message-ID: <20210916073714.9057-1-caihuoqing@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BC-Mail-EX04.internal.baidu.com (172.31.51.44) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_003730_496570_DCC4745E X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Return dev_err_probe() directly, because the return value of dev_err_probe() is the appropriate error code, and it can reduce code size, simplify the code. Signed-off-by: Cai Huoqing --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index 32cb41b2202f..6e9e42d069c9 100644 --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c @@ -370,11 +370,9 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) } dsi->vdd_supply = devm_regulator_get(dev, "phy-dsi"); - if (IS_ERR(dsi->vdd_supply)) { - ret = PTR_ERR(dsi->vdd_supply); - dev_err_probe(dev, ret, "Failed to request regulator\n"); - return ret; - } + if (IS_ERR(dsi->vdd_supply)) + return dev_err_probe(dev, PTR_ERR(dsi->vdd_supply), + "Failed to request regulator\n"); ret = regulator_enable(dsi->vdd_supply); if (ret) {