From patchwork Sun Sep 19 16:28:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 12504377 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7303FC433EF for ; Sun, 19 Sep 2021 17:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59E6760FA0 for ; Sun, 19 Sep 2021 17:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234261AbhISRB5 (ORCPT ); Sun, 19 Sep 2021 13:01:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbhISRBv (ORCPT ); Sun, 19 Sep 2021 13:01:51 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A267C061757; Sun, 19 Sep 2021 10:00:25 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id v22so46877088edd.11; Sun, 19 Sep 2021 10:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=21nowariD76inilnHAN+GS6tHZVsucKQkxTmpZSNO8A=; b=nI/ZfIrdiRZshKrX22QsXyQ23dbOqePQ1iP7RfIgIi8nT5A/wHc5ouYD4zeE87NyFL 9AydgrNVvhC+N72x99S2hHOH9rnyJYeukbP9LkzzGvEiLFw0t3RgiD3G3mvLcQHRxeqB y5Vyit+uEB5MWoUH/10FtmDw5E3OnWgJZ5SbUwIG2S7WvH1z5lVfPW0CRx1REk65YDrv CXSOCqbN82/+wL3KDnYtlIY1gCADynFYS5/nLczAeFa/oPry00jygdjUmQNqPiQ1bnfT WbJLkEaF6A+LEvVRXEf37hKefA8qjcGUPMJKkNHAjo2OQu6l5QOmn0ggrLlp6Rx5imv9 7qkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=21nowariD76inilnHAN+GS6tHZVsucKQkxTmpZSNO8A=; b=ZRYWgNCXVHb7w8/8iBh3CyBZ1/foOxa/NWwdxmvMnX9G906AhUZ8Y4hwMmcZevDvah 9wW5hN/oSPav2tXIR/icWc1APMkuJekYYo6a+Xs6XQGH8pUbyWoT/s59alese7Ja2Mfm jankKyn7kpWmbVz6p/NljQBDppJvrs/pj1klJWXosqD8FrX1lkoLN0RVKhrgUCz9H1ji /rVXK80bql+5pQOYge+x7nnv9MhPUpgzh0RppmoxPzIYQb3YnL1lSwq0IxcZwwVbsGRk C4YZMCyUBmydylAjTwwXjFgkcdlMzfW2wUMyal/+2XnXbQX+3IT+3mCevmBujZX1TgJf 9VBA== X-Gm-Message-State: AOAM531KmvVS3M6goDv+TklwNuqmg7rGRaWjNyunKKSrZrex4bKO3JkQ lcF2LxVhsU660TSzqhAmUUs= X-Google-Smtp-Source: ABdhPJxCVSP7egl5HChJYGQpu3F4RbQ11G0dgLFCNCQdJESOXPiCYyOpVFGzf3doPMaLBdusNhZfFg== X-Received: by 2002:a17:906:aeda:: with SMTP id me26mr24259557ejb.83.1632070823924; Sun, 19 Sep 2021 10:00:23 -0700 (PDT) Received: from Ansuel-xps.localdomain (93-42-67-254.ip85.fastwebnet.it. [93.42.67.254]) by smtp.googlemail.com with ESMTPSA id a15sm6101760edr.2.2021.09.19.10.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 10:00:23 -0700 (PDT) From: Ansuel Smith To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ansuel Smith Subject: [net-next PATCH v2 1/3] net: phy: at803x: add support for qca 8327 A variant internal phy Date: Sun, 19 Sep 2021 18:28:15 +0200 Message-Id: <20210919162817.26924-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210919162817.26924-1-ansuelsmth@gmail.com> References: <20210919162817.26924-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For qca8327 internal phy there are 2 different switch variant with 2 different phy id. Add this missing variant so the internal phy can be correctly identified and fixed. Signed-off-by: Ansuel Smith Reviewed-by: Andrew Lunn --- drivers/net/phy/at803x.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 719860a93d7c..618e014abd2f 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -150,7 +150,8 @@ #define ATH8035_PHY_ID 0x004dd072 #define AT8030_PHY_ID_MASK 0xffffffef -#define QCA8327_PHY_ID 0x004dd034 +#define QCA8327_A_PHY_ID 0x004dd033 +#define QCA8327_B_PHY_ID 0x004dd034 #define QCA8337_PHY_ID 0x004dd036 #define QCA8K_PHY_ID_MASK 0xffffffff @@ -1421,10 +1422,23 @@ static struct phy_driver at803x_driver[] = { .get_strings = at803x_get_strings, .get_stats = at803x_get_stats, }, { - /* QCA8327 */ - .phy_id = QCA8327_PHY_ID, + /* QCA8327-A from switch QCA8327-AL1A */ + .phy_id = QCA8327_A_PHY_ID, .phy_id_mask = QCA8K_PHY_ID_MASK, - .name = "QCA PHY 8327", + .name = "QCA PHY 8327-A", + /* PHY_GBIT_FEATURES */ + .probe = at803x_probe, + .flags = PHY_IS_INTERNAL, + .config_init = qca83xx_config_init, + .soft_reset = genphy_soft_reset, + .get_sset_count = at803x_get_sset_count, + .get_strings = at803x_get_strings, + .get_stats = at803x_get_stats, +}, { + /* QCA8327-B from switch QCA8327-BL1A */ + .phy_id = QCA8327_B_PHY_ID, + .phy_id_mask = QCA8K_PHY_ID_MASK, + .name = "QCA PHY 8327-B", /* PHY_GBIT_FEATURES */ .probe = at803x_probe, .flags = PHY_IS_INTERNAL, @@ -1444,7 +1458,8 @@ static struct mdio_device_id __maybe_unused atheros_tbl[] = { { PHY_ID_MATCH_EXACT(ATH8035_PHY_ID) }, { PHY_ID_MATCH_EXACT(ATH9331_PHY_ID) }, { PHY_ID_MATCH_EXACT(QCA8337_PHY_ID) }, - { PHY_ID_MATCH_EXACT(QCA8327_PHY_ID) }, + { PHY_ID_MATCH_EXACT(QCA8327_A_PHY_ID) }, + { PHY_ID_MATCH_EXACT(QCA8327_B_PHY_ID) }, { } }; From patchwork Sun Sep 19 16:28:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 12504379 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16BAC433FE for ; Sun, 19 Sep 2021 17:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D48ED610FB for ; Sun, 19 Sep 2021 17:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234305AbhISRB6 (ORCPT ); Sun, 19 Sep 2021 13:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231271AbhISRBv (ORCPT ); Sun, 19 Sep 2021 13:01:51 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67795C06175F; Sun, 19 Sep 2021 10:00:26 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id c22so51169205edn.12; Sun, 19 Sep 2021 10:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=19lsN6f/KlOPR5hqb4/mwEXZyNouLZoH3YnozNMBbu4=; b=Fk6pLsojfxzs3j5NpN8mKdOPdNs85bxweJ5SOcvWW2FDEe48xUlh0XF2IvDc9oXDtJ VJ/V+7Ujhvp/TsXsclp5Fvjj4tPU2b5n2iOOViS2W4uJRdvpTK7iYfnr+tfoj/yMn6No 8XxZrC8sFHpMBREoTVe8A2pc5THnc9+kDu8FXuM8CYS1ZXNYqf6UycxXoSOIqHYUSYoE lqQ1lv7Nm/qoHpC0fhObl8teiJ6HME0JZb5ze/ndyrC/A+9WFCNCjakd54YL+FgwW/gZ fxLv7UBxtT+0FV4k+Tc+jCRkh2vJKqWShPrj15lyDr4FNQLYG5O+VLOR4+ysfhj3PKeJ o4eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=19lsN6f/KlOPR5hqb4/mwEXZyNouLZoH3YnozNMBbu4=; b=KkZdNT+xVw+K1EeOfFrKac/r2d2Wg0TR4Q86AfMTHeuqPH5cm1saVCRamKW5JSbtji vf2Xj9XyJyRAye538EAuIpkNgH4CrmdktvXQ98rXE4bSFwwJQ+i2GybWGyz1b0wvemB3 iMOfhHJ+FqBjbpGpJCB71J0SaZ6WK36W9SdYIDONXcJafNZztozaTqH8GgicFsm74U5+ gkDk+d5atUfG2hfxyM2pAzgwbFafN6ps9Aga6M/KXDGiWVhyF0Mj04e9rLOGGaCDAmhS GFC7kHfAuyXxOzpQw3U5KshUcX983wNTQH2yal9McgNEeCIEFYel6iVb043imNW1Clb4 Db0w== X-Gm-Message-State: AOAM532JBRd6L0n0OnoDyl8LtrF+D/mQWwqz6Z6/micgz4Nna4szyEm5 AfdX4VgLkdApapeSffcSiB8= X-Google-Smtp-Source: ABdhPJxklihdxhOkeKnWjxZjebLyIhtURDNz+tfpk2gJ9n4mVFL2lWaMB+oNyh/lBRptqGb9iiyEvQ== X-Received: by 2002:a17:906:cc0e:: with SMTP id ml14mr23081516ejb.395.1632070824898; Sun, 19 Sep 2021 10:00:24 -0700 (PDT) Received: from Ansuel-xps.localdomain (93-42-67-254.ip85.fastwebnet.it. [93.42.67.254]) by smtp.googlemail.com with ESMTPSA id a15sm6101760edr.2.2021.09.19.10.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 10:00:24 -0700 (PDT) From: Ansuel Smith To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ansuel Smith Subject: [net-next PATCH v2 2/3] net: phy: at803x: add resume/suspend function to qca83xx phy Date: Sun, 19 Sep 2021 18:28:16 +0200 Message-Id: <20210919162817.26924-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210919162817.26924-1-ansuelsmth@gmail.com> References: <20210919162817.26924-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Add resume/suspend function to qca83xx internal phy. We can't use the at803x generic function as the documentation lacks of any support for WoL regs. Signed-off-by: Ansuel Smith Reviewed-by: Andrew Lunn --- drivers/net/phy/at803x.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 618e014abd2f..db432d228d07 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -1421,6 +1421,8 @@ static struct phy_driver at803x_driver[] = { .get_sset_count = at803x_get_sset_count, .get_strings = at803x_get_strings, .get_stats = at803x_get_stats, + .suspend = genphy_suspend, + .resume = genphy_resume, }, { /* QCA8327-A from switch QCA8327-AL1A */ .phy_id = QCA8327_A_PHY_ID, @@ -1434,6 +1436,8 @@ static struct phy_driver at803x_driver[] = { .get_sset_count = at803x_get_sset_count, .get_strings = at803x_get_strings, .get_stats = at803x_get_stats, + .suspend = genphy_suspend, + .resume = genphy_resume, }, { /* QCA8327-B from switch QCA8327-BL1A */ .phy_id = QCA8327_B_PHY_ID, @@ -1447,6 +1451,8 @@ static struct phy_driver at803x_driver[] = { .get_sset_count = at803x_get_sset_count, .get_strings = at803x_get_strings, .get_stats = at803x_get_stats, + .suspend = genphy_suspend, + .resume = genphy_resume, }, }; module_phy_driver(at803x_driver); From patchwork Sun Sep 19 16:28:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 12504381 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9A5C433EF for ; Sun, 19 Sep 2021 17:00:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E6B8610FB for ; Sun, 19 Sep 2021 17:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234355AbhISRCA (ORCPT ); Sun, 19 Sep 2021 13:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbhISRBx (ORCPT ); Sun, 19 Sep 2021 13:01:53 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F144C061574; Sun, 19 Sep 2021 10:00:27 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id g8so51245223edt.7; Sun, 19 Sep 2021 10:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FWSZ0ScdX9/vFWzS9q81FlnqYgwmAD2fUqhq1c6CFi4=; b=VnLfLkfhU4W9W/apJuUjRraKmWJuth6e9BJg4ygIs8ft6/NsmkQL7KLXZO2T4KcgSe OciXYe9RSLo5ZndAZlZ9J9jiJ/Lw5/hmmQZzezQBak8BD0vCZ3BKXKmE4AB1905VYXU9 SUsBC6Jzef9cvPcDQ3ZJDOH+vcsFluTItzNqagwrpBqHDMWs1UbuwRrWJrBdViFjzVUe vvTLf9NiuHEZOLh/94dsiMx0H4tuk5feDmRR7wy/q7CBEGqW8y6wugKcoxgIUbHLwbpg iiQ8JIxNVFSdc1nXEBcWd5OgxBG6v+fQoYXIO82mVVysWq3Vi8SpYS3l23Olipz6PYWt hwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FWSZ0ScdX9/vFWzS9q81FlnqYgwmAD2fUqhq1c6CFi4=; b=qhfjHeUknxZmRvrnFnT5811XnCHSgLWrXVsUIwA7qCDSoCw38UWujl7c20sHlqGh08 wUmw2w0XRLRvmWqd8bR0Fg2kwZYU41Bd9HabsB67ozMUyBT699IfP7+58L33KXz59Eot slgju9qoGn5HWGpA52sZ+mb/yI8hg8PuxFm7M+H4AXvZl47sbvfFFwy+8A9m5GNLyEiS f/c+jaBAECcZSAKSUVs2Qlt38NRUIa6b4nuPTCK/N7gZS9MeYpAXFmP1dkGsKU4IjhPl udxnV9eLWsr39NuwOY/lY8BdaIonuOSIsJQ9qEeiTkFeZn0vtBZRZhS9EQp33zUzcU4G ygSw== X-Gm-Message-State: AOAM532SQBal+XzBdSpK7E4e70EJB5gdoHCv1pELMj8qFWtp2cWbjd3l 5/MEE4vAUjI1nN+7E8g9+d2JKvXXddE= X-Google-Smtp-Source: ABdhPJyyu9Y7ZhAHoQSx4pjam8aHz0XEKp1SgNs4uR0NbE40NPvG1d/5ajR23tA5s/PLqoauANILpg== X-Received: by 2002:a17:906:1510:: with SMTP id b16mr25101733ejd.332.1632070825756; Sun, 19 Sep 2021 10:00:25 -0700 (PDT) Received: from Ansuel-xps.localdomain (93-42-67-254.ip85.fastwebnet.it. [93.42.67.254]) by smtp.googlemail.com with ESMTPSA id a15sm6101760edr.2.2021.09.19.10.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 10:00:25 -0700 (PDT) From: Ansuel Smith To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ansuel Smith Subject: [net-next PATCH v2 3/3] net: phy: at803x: fix spacing and improve name for 83xx phy Date: Sun, 19 Sep 2021 18:28:17 +0200 Message-Id: <20210919162817.26924-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210919162817.26924-1-ansuelsmth@gmail.com> References: <20210919162817.26924-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fix spacing and improve name for 83xx phy following other phy in the same driver. Signed-off-by: Ansuel Smith Reviewed-by: Andrew Lunn --- drivers/net/phy/at803x.c | 60 ++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index db432d228d07..3feee4d59030 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -1410,47 +1410,47 @@ static struct phy_driver at803x_driver[] = { .config_aneg = at803x_config_aneg, }, { /* QCA8337 */ - .phy_id = QCA8337_PHY_ID, - .phy_id_mask = QCA8K_PHY_ID_MASK, - .name = "QCA PHY 8337", + .phy_id = QCA8337_PHY_ID, + .phy_id_mask = QCA8K_PHY_ID_MASK, + .name = "Qualcomm Atheros 8337 internal PHY", /* PHY_GBIT_FEATURES */ - .probe = at803x_probe, - .flags = PHY_IS_INTERNAL, - .config_init = qca83xx_config_init, - .soft_reset = genphy_soft_reset, - .get_sset_count = at803x_get_sset_count, - .get_strings = at803x_get_strings, - .get_stats = at803x_get_stats, + .probe = at803x_probe, + .flags = PHY_IS_INTERNAL, + .config_init = qca83xx_config_init, + .soft_reset = genphy_soft_reset, + .get_sset_count = at803x_get_sset_count, + .get_strings = at803x_get_strings, + .get_stats = at803x_get_stats, .suspend = genphy_suspend, .resume = genphy_resume, }, { /* QCA8327-A from switch QCA8327-AL1A */ - .phy_id = QCA8327_A_PHY_ID, - .phy_id_mask = QCA8K_PHY_ID_MASK, - .name = "QCA PHY 8327-A", + .phy_id = QCA8327_A_PHY_ID, + .phy_id_mask = QCA8K_PHY_ID_MASK, + .name = "Qualcomm Atheros 8327-A internal PHY", /* PHY_GBIT_FEATURES */ - .probe = at803x_probe, - .flags = PHY_IS_INTERNAL, - .config_init = qca83xx_config_init, - .soft_reset = genphy_soft_reset, - .get_sset_count = at803x_get_sset_count, - .get_strings = at803x_get_strings, - .get_stats = at803x_get_stats, + .probe = at803x_probe, + .flags = PHY_IS_INTERNAL, + .config_init = qca83xx_config_init, + .soft_reset = genphy_soft_reset, + .get_sset_count = at803x_get_sset_count, + .get_strings = at803x_get_strings, + .get_stats = at803x_get_stats, .suspend = genphy_suspend, .resume = genphy_resume, }, { /* QCA8327-B from switch QCA8327-BL1A */ - .phy_id = QCA8327_B_PHY_ID, - .phy_id_mask = QCA8K_PHY_ID_MASK, - .name = "QCA PHY 8327-B", + .phy_id = QCA8327_B_PHY_ID, + .phy_id_mask = QCA8K_PHY_ID_MASK, + .name = "Qualcomm Atheros 8327-B internal PHY", /* PHY_GBIT_FEATURES */ - .probe = at803x_probe, - .flags = PHY_IS_INTERNAL, - .config_init = qca83xx_config_init, - .soft_reset = genphy_soft_reset, - .get_sset_count = at803x_get_sset_count, - .get_strings = at803x_get_strings, - .get_stats = at803x_get_stats, + .probe = at803x_probe, + .flags = PHY_IS_INTERNAL, + .config_init = qca83xx_config_init, + .soft_reset = genphy_soft_reset, + .get_sset_count = at803x_get_sset_count, + .get_strings = at803x_get_strings, + .get_stats = at803x_get_stats, .suspend = genphy_suspend, .resume = genphy_resume, }, };