From patchwork Mon Sep 27 06:43:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo Ren X-Patchwork-Id: 12519179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3932AC433EF for ; Mon, 27 Sep 2021 06:44:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC4F36113D for ; Mon, 27 Sep 2021 06:44:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC4F36113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 27E2D6B0071; Mon, 27 Sep 2021 02:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22E1A900002; Mon, 27 Sep 2021 02:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F57F6B0073; Mon, 27 Sep 2021 02:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id F39866B0071 for ; Mon, 27 Sep 2021 02:44:55 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8B65A181AC544 for ; Mon, 27 Sep 2021 06:44:55 +0000 (UTC) X-FDA: 78632415750.36.6732142 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id 339071902 for ; Mon, 27 Sep 2021 06:44:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FF8A60F4A; Mon, 27 Sep 2021 06:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632725094; bh=Ld1vVAFmYNZcXK+8yISPfBNEddduEPZhsJnF3sCzD4M=; h=From:To:Cc:Subject:Date:From; b=uYdz6qI0fThLYpXL1ZqwyNfVvPKflst0ywOhiGaSm0mmlpLVnoPs5qKju6I3K8xGr X9NsUfcdaAYkeUtU7lSWhkIzfGTsernqempr36+vCSjLtzjX1aKjPOhkxh1Bamq6CL Yg6LqRnGFYFsPVqB/T/wferp5/CM69xbi0TPDFhqcCXoVVHxyFUicL2u0lAdOrq5uw Tr0q0PenJY75JwU2ENW4wniSNnpr3eYY6vq4hsCTz94vFPbDnFBwcdg5ma94b/o7FV c7r86gJ/obfrDTY77Up3fXstg7wh4yzqE6H+CCPVuylRQWq/YwAO/HVXG0MbL91egZ nO1Jf3q7d55tA== From: guoren@kernel.org To: guoren@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Guo Ren , Anshuman Khandual , Christoph Hellwig Subject: [PATCH V3] mm: debug_vm_pgtable: Don't use __P000 directly Date: Mon, 27 Sep 2021 14:43:40 +0800 Message-Id: <20210927064340.2411397-1-guoren@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 339071902 X-Stat-Signature: ay78nrjaa844g1ahzx5yryyghoohnnpa Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uYdz6qI0; spf=pass (imf22.hostedemail.com: domain of guoren@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-HE-Tag: 1632725095-777975 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Guo Ren The __Pxxx/__Sxxx macros are only for protection_map[] init. All usage of them in linux should come from protection_map array. Because a lot of architectures would re-initilize protection_map[] array, eg: x86-mem_encrypt, m68k-motorola, mips, arm, sparc. Using __P000 is not rigorous. Signed-off-by: Guo Ren Reviewed-by: Andrew Morton Reviewed-by: Anshuman Khandual Cc: Christoph Hellwig --- Changes since V3: - Add Reviewed-by: Anshuman Khandual - Add Cc: Christoph Hellwig Changes since V2: - s/init protection_map[]/protection_map[] init/ - s/Becasue/Because/ - Remove unclear part - Replace __P000 and __S000 with protection_map[0] and protection_map[8] --- mm/debug_vm_pgtable.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 1403639302e4..228e3954b90c 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -1104,13 +1104,14 @@ static int __init init_args(struct pgtable_debug_args *args) /* * Initialize the debugging data. * - * __P000 (or even __S000) will help create page table entries with - * PROT_NONE permission as required for pxx_protnone_tests(). + * protection_map[0] (or even protection_map[8]) will help create + * page table entries with PROT_NONE permission as required for + * pxx_protnone_tests(). */ memset(args, 0, sizeof(*args)); args->vaddr = get_random_vaddr(); args->page_prot = vm_get_page_prot(VMFLAGS); - args->page_prot_none = __P000; + args->page_prot_none = protection_map[0]; args->is_contiguous_page = false; args->pud_pfn = ULONG_MAX; args->pmd_pfn = ULONG_MAX;