From patchwork Mon Sep 27 11:23:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 12519587 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF91DC433EF for ; Mon, 27 Sep 2021 11:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F1F260F4F for ; Mon, 27 Sep 2021 11:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbhI0LZW (ORCPT ); Mon, 27 Sep 2021 07:25:22 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:55638 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233959AbhI0LZV (ORCPT ); Mon, 27 Sep 2021 07:25:21 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mUojW-0004A4-Pj; Mon, 27 Sep 2021 19:23:42 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mUojW-0005r0-3W; Mon, 27 Sep 2021 19:23:42 +0800 Date: Mon, 27 Sep 2021 19:23:42 +0800 From: Herbert Xu To: Stephen Rothwell Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: [PATCH] crypto: api - Export crypto_boot_test_finished Message-ID: <20210927112341.GA22483@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210927143229.543749f4@canb.auug.org.au> X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel Organization: Core User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Stephen Rothwell wrote: > [-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --] > > Hi all, > > After merging the crypto tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined! > > Caused by commit > > adad556efcdd ("crypto: api - Fix built-in testing dependency failures") > > I have reverted that commit for today. Oops, does this patch fix the problem? ---8<--- We need to export crypto_boot_test_finished in case api.c is built-in while algapi.c is built as a module. Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures") Reported-by: Stephen Rothwell Signed-off-by: Herbert Xu Tested-by: Stephen Rothwell # ppc32 build diff --git a/crypto/api.c b/crypto/api.c index 1cf1f03347cc..ee5991fe11f8 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -32,6 +32,7 @@ BLOCKING_NOTIFIER_HEAD(crypto_chain); EXPORT_SYMBOL_GPL(crypto_chain); DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished); +EXPORT_SYMBOL_GPL(crypto_boot_test_finished); static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg);