From patchwork Tue Sep 28 02:20:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12521515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910F1C433FE for ; Tue, 28 Sep 2021 02:20:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AC3861262 for ; Tue, 28 Sep 2021 02:20:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238652AbhI1CWD (ORCPT ); Mon, 27 Sep 2021 22:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238656AbhI1CWC (ORCPT ); Mon, 27 Sep 2021 22:22:02 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17056C061769 for ; Mon, 27 Sep 2021 19:20:24 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 75so3239567pga.3 for ; Mon, 27 Sep 2021 19:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NYqezzVsApLcG6o8A6nHf5azw/hdK7Hyfm4V2m2anYE=; b=ktEgcMjNRerbDRlQjW54gIRGhF9RrTp5S+D9vZR7qXJhk/vYJwKDeewlR70iO4VsmR HShmITge9HqC/yfj4wq6+pqlvXlFf+fM6Znpd68LvZ3M77397J2/5xM9LdJL/C5y7Xt6 an0j2Ge9ID6jmgvOsLXLCkBZRffpNPYdu8D5GcS0lK7fIgULZqB4EfgUo2v0OQdqFXzR hIuUq7G9mHjL/p7gUW8SQPz8G1CGymjtuA94xt5YfkJFK40FijiL6VoB7DNmBYaVPyfw nd+C9r19WRK+LUHGf09jyMsJtKxnci9oQt+1+dK9+VABpLgSAexdXIvyjkJo7B1MZONk s61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NYqezzVsApLcG6o8A6nHf5azw/hdK7Hyfm4V2m2anYE=; b=vkNH8GY1yGeJmpYZVmYHJEPxc6qnEjm6SxoKbzwcZvNlym4APaIIvi74G4FDZq2GCL 3rPjIDIil6EB1z3P8SYaqra1p21HmSh4/SuF/Siysx+0YL/MI+AQI/Sg3g3mnmesyRm8 68GIUFzOuVT9v0FW2SZSlvIBKwJXEfg3kjnG5+LWKD/PLNYaYuvAx/of0eyUn6UWYENV deUuSY7AZbzzAXSudIeZk16Dq51qvoPBI79562l20UgaZcnrJtbmI4IpA/4RPRtPZr1f h0OSdNUSxQvNUf2nIN1Shy+OQz7v0Gqdc/20fv8x6jKaC34QxL5JcBJP7alkbM0Nmzmr hhOg== X-Gm-Message-State: AOAM530MDPjM1zkKEcoYw9CaL7vaUveFDYWTJJOEJhmJc9YONns175tc 33OGvRnJYho1k1B2zPH9LcA86g== X-Google-Smtp-Source: ABdhPJxtkhkcETWROWusxFox1a51j3uHtyRo8hzT6t77fL1kJ0MDx4Rzp4PMmrb6aL2EFka98H0kUg== X-Received: by 2002:a63:6e03:: with SMTP id j3mr2371457pgc.465.1632795623623; Mon, 27 Sep 2021 19:20:23 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id u12sm19178729pgi.21.2021.09.27.19.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 19:20:23 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v2 1/3] dt-bindings: phy: qcom,qusb2: Add missing vdd-supply Date: Tue, 28 Sep 2021 10:20:00 +0800 Message-Id: <20210928022002.26286-2-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210928022002.26286-1-shawn.guo@linaro.org> References: <20210928022002.26286-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for PHY digital circuit operation. Add it for correctness and completeness. Signed-off-by: Shawn Guo Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml index ec9ccaaba098..e49fa4ce18c8 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml @@ -50,6 +50,10 @@ properties: - const: ref - const: iface + vdd-supply: + description: + Phandle to 0.9V regulator supply to PHY digital circuit. + vdda-pll-supply: description: Phandle to 1.8V regulator supply to PHY refclk pll block. @@ -156,6 +160,7 @@ required: - "#phy-cells" - clocks - clock-names + - vdd-supply - vdda-pll-supply - vdda-phy-dpdm-supply - resets @@ -174,6 +179,7 @@ examples: <&gcc GCC_RX1_USB2_CLKREF_CLK>; clock-names = "cfg_ahb", "ref"; + vdd-supply = <&pm8994_l28>; vdda-pll-supply = <&pm8994_l12>; vdda-phy-dpdm-supply = <&pm8994_l24>; From patchwork Tue Sep 28 02:20:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12521517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D52C4332F for ; Tue, 28 Sep 2021 02:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2A961247 for ; Tue, 28 Sep 2021 02:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238672AbhI1CWK (ORCPT ); Mon, 27 Sep 2021 22:22:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238695AbhI1CWI (ORCPT ); Mon, 27 Sep 2021 22:22:08 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39C0CC06176C for ; Mon, 27 Sep 2021 19:20:27 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id y8so17607760pfa.7 for ; Mon, 27 Sep 2021 19:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qHSumsFttLNe13vy2J2oY9G24Uv+x+gtP2uj1qdWakg=; b=XFaKrbicAE6MOpmf9fQ/3JJ+kZkW/PeuWDB5ZjnQ0QGs1Mp5Di/jwitdHQM2indyCa Z/9j+E+QPCa37kz8uaMUWSbYLL7qWCmimkX2x4PtZ0rcKS/5yV5ZowVP0g44ins406Rc cy3ay2TAsVjifjTOP2TMsP0LfGHBrml14J7UqenNeJvd1A0dR2LmR5doGNa5nSUWOz5A 9HOIiQY+SsLLGtjVYk2p/rcndvoJ92oGoDclxtB1JPkN3WRaozOISMsRfB4W2ZCk0QaN p/emf1cqbkNXM2sDuCcRieUeMgHs12sgWlMO/pwmNph9acuVaoILE3qQOD5emHhOQDMi oq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qHSumsFttLNe13vy2J2oY9G24Uv+x+gtP2uj1qdWakg=; b=4AgfxjF2mPr0gYawz7cgrbA0ILVD/4A4T2/YCzxYnjPrY/nZNs+sHyjrtDcEipDTeg kPTpyMA50peAmFQijF35oLkN53ccPDRXwg224Vjb2WKvVuEmpv1FCv8pZJRc87jonlBg WbI1shkmP01/oYz25h73ZPdAuhqKLFLI2pZH+pGWiYD0iumHUn8R6FJZzERUkZEwn/ba VL9rjfNyuhNju88pOWNqlClOJQvpvzbMgs4xB6Nw6n06omQun04nRjrXuobf/E+bBnzz 89BCH+iNLWv+3pOxGnfDvt9ivgU7+qgOuHxRy0SK3w0mzACuha/JZgGikL25FhJKw5vu 5DuA== X-Gm-Message-State: AOAM530xDvjSzo+VCs9seuBasiIWPXPCCkFscudRLzD86wZv1I1fQek4 CVJXlu95avNBonbXSoJa1zmYzQ== X-Google-Smtp-Source: ABdhPJzXL8A2F3RqJqnz6h6cJYNbXuaeta2bLaHDKzTDqrS9svQq+oMfQ0pUUulrGexEbWkEB74vyQ== X-Received: by 2002:a63:af4b:: with SMTP id s11mr2351998pgo.185.1632795626732; Mon, 27 Sep 2021 19:20:26 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id u12sm19178729pgi.21.2021.09.27.19.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 19:20:26 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v2 2/3] phy: qcom-qusb2: Add missing vdd supply Date: Tue, 28 Sep 2021 10:20:01 +0800 Message-Id: <20210928022002.26286-3-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210928022002.26286-1-shawn.guo@linaro.org> References: <20210928022002.26286-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Per downstream kernel, beside vdda-pll and vdda-phy-dpdm, vdd is also a required supply for QUSB2 PHY digital circuit operation. The driver works right now likely because firmware already sets it up. Add it for correctness and completeness. Signed-off-by: Shawn Guo --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 3c1d3b71c825..02845e08dac0 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -371,7 +371,7 @@ static const struct qusb2_phy_cfg sm6115_phy_cfg = { }; static const char * const qusb2_phy_vreg_names[] = { - "vdda-pll", "vdda-phy-dpdm", + "vdd", "vdda-pll", "vdda-phy-dpdm", }; #define QUSB2_NUM_VREGS ARRAY_SIZE(qusb2_phy_vreg_names) From patchwork Tue Sep 28 02:20:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12521519 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECA3C4332F for ; Tue, 28 Sep 2021 02:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBB8661279 for ; Tue, 28 Sep 2021 02:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238718AbhI1CWL (ORCPT ); Mon, 27 Sep 2021 22:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238700AbhI1CWJ (ORCPT ); Mon, 27 Sep 2021 22:22:09 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C56FC061765 for ; Mon, 27 Sep 2021 19:20:30 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id h3so19597472pgb.7 for ; Mon, 27 Sep 2021 19:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KEllPcS5Xq9Pyinz9uhBulFqCz5TInIHturtjFlsWfM=; b=T87rTQzEU62NuU3FOhvPREGW7/nPgaG5Bzo+GXN2I0O/jz2fHahkOXybbH4MdRKvCP WJEjY8UZ7c3qBpCP7kfotW2esh3XCYpDqtX+BxtU/rBeUaUMgJO7N6DBYuhBoG4deGjt qGFLAJW3fjE1vFb5YF3JySkjjDRQew9M5nF6lE+Q/o7SBJuhhJv93Jzw3snGguRos0dO RsIXhZdioVhosWYH4Ov0asxioE4XHit85mCroKr3NYGgNBij1/tw49ogg3VmoeD8EcwU ZL4Zl9FytxEunl+sr8hsbQKXEsUYYKtJvzESv/tkQZf1mLLWSYo5ylP0QezLY2wle8b9 sq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KEllPcS5Xq9Pyinz9uhBulFqCz5TInIHturtjFlsWfM=; b=cjZjIJ2rHwP4/eiu+MijGBeC+FF0w5aqfFEz6dVfnLYgorR6YvoVbRgN8Zzh+yNRPC QHe8pjhtUe73gsr3nDln8+Cywy151IikPwKlsAS3ZFQHrq7/6nk7rkRoDW6yuH3rUawT jxWGMw0Z/ymHcSdt5gYlNCQUeszCpaYqSQAoZNNKaKDSVLvCW5Y1a7CzVoaVqNGvJ8v1 Aj9UgXGRFM1IzguV3RLKuUJt7Y+tbkwL/THpDcudYkUBqP0ZZODAd/XPS680hyCquGKs +pMXmr5Ru1ETfdVZTOMS85QK5R5zpbwWCjhxkyzde91AQe7XJyrcNw6cXXIs2NGcWILi yo0w== X-Gm-Message-State: AOAM532dAswrbo/iJK8isshMHB5q3M1X5yUsPVa7fVg+UBWi/VPlaIDW c8BzgylT4sYqTptK2ROfTZVv9A== X-Google-Smtp-Source: ABdhPJy4QvjIvE5bquuYcb7fMbqGz4cZlG5kaauiiTmBYpbUf2ig1Y5Xi+Wqm45331UsVXUZzzKj+Q== X-Received: by 2002:a62:4d42:0:b0:44b:3078:7387 with SMTP id a63-20020a624d42000000b0044b30787387mr2859388pfb.27.1632795630041; Mon, 27 Sep 2021 19:20:30 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id u12sm19178729pgi.21.2021.09.27.19.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 19:20:29 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v2 3/3] arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY Date: Tue, 28 Sep 2021 10:20:02 +0800 Message-Id: <20210928022002.26286-4-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210928022002.26286-1-shawn.guo@linaro.org> References: <20210928022002.26286-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org QUSB2 PHY requires vdd-supply for digital circuit operation. Add it for platforms that miss it. Signed-off-by: Shawn Guo Acked-By: Vinod Koul --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 ++ arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 1 + 4 files changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi index 51e17094d7b1..d9826ce27e50 100644 --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi @@ -230,6 +230,7 @@ &hsusb_phy1 { status = "okay"; + vdd-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; @@ -237,6 +238,7 @@ &hsusb_phy2 { status = "okay"; + vdd-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi index 507396c4d23b..61ea6d4ef8ac 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi @@ -184,6 +184,7 @@ &hsusb_phy1 { status = "okay"; + vdd-supply = <&pm8994_l28>; vdda-pll-supply = <&pm8994_l12>; vdda-phy-dpdm-supply = <&pm8994_l24>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi index 125d7923d713..4f823974559b 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi @@ -102,6 +102,7 @@ &qusb2phy { status = "okay"; + vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi index 0f5c7828a901..243f4ee5da8c 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi @@ -260,6 +260,7 @@ &qusb2phy { status = "okay"; + vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; };