From patchwork Wed Dec 12 12:44:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minas Harutyunyan X-Patchwork-Id: 10726235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0765B14E2 for ; Wed, 12 Dec 2018 12:45:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC5AD2AC2B for ; Wed, 12 Dec 2018 12:45:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E06F72ACC7; Wed, 12 Dec 2018 12:45:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AD982AC2B for ; Wed, 12 Dec 2018 12:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbeLLMpj (ORCPT ); Wed, 12 Dec 2018 07:45:39 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:38788 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbeLLMpj (ORCPT ); Wed, 12 Dec 2018 07:45:39 -0500 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id E86C110C0DF1; Wed, 12 Dec 2018 04:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1544618738; bh=twFL13/Pig9TiAbtckD1q/wGtffpCBRBjfyP7L4txlc=; h=Date:From:Subject:To:CC:From; b=j5XBZ1CEbelcxgruuPmTuU68RrCu4f5poEEyqMXuEUBKSXXtXb+DRXaMseOjib3vD sHoA5b2owKEv+l4PEA7PlQ6UygAw8ZCEu/OayPvOU5QYhf85CDddZTvquNQZVdiK7W NUlrcfnW6MeX8NMdWOXibXlIQfW8fMNYrAdfn1YWcreGTxikip/VqPDF3z5wzkQs8Y 8FWZdtvX3MR9QQFIofbnlIZj1inrtK8sBhqnHPf8pzEalp47HePcCBITKwy+6u/GH1 jT0xcfH6ApOmiSW1OC7gIjTCfKCX8Qrb1VKZNdKFCLVZt08wfMxT4zrxAYZ/Tz35Bf JK5mVuUnqzXGw== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id D2B0953DF; Wed, 12 Dec 2018 04:45:38 -0800 (PST) Received: from US01WEHTC1.internal.synopsys.com (10.12.239.236) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 04:44:38 -0800 Received: from hminas-z420 (10.13.184.20) by us01wehtc1.internal.synopsys.com (10.12.239.236) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 04:44:36 -0800 Received: by hminas-z420 (sSMTP sendmail emulation); Wed, 12 Dec 2018 16:44:32 +0400 Date: Wed, 12 Dec 2018 16:44:32 +0400 Message-ID: From: Minas Harutyunyan Subject: [PATCH] usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing To: Felipe Balbi , Greg Kroah-Hartman , Minas Harutyunyan , CC: John Youn , Grigor Tovmasyan MIME-Version: 1.0 X-Originating-IP: [10.13.184.20] Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register require to write 1. This bit is implemented as "Write to clear". Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt") Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 68ad75a7460d..55ef3cc2701b 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT); dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG); } }