From patchwork Tue Oct 5 19:47:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 12537589 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F24C433EF for ; Tue, 5 Oct 2021 19:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3FE261409 for ; Tue, 5 Oct 2021 19:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235789AbhJETvH (ORCPT ); Tue, 5 Oct 2021 15:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235157AbhJETvG (ORCPT ); Tue, 5 Oct 2021 15:51:06 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B425C061749 for ; Tue, 5 Oct 2021 12:49:15 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id j5so562080lfg.8 for ; Tue, 05 Oct 2021 12:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6cOBj8Ho+R4A3czQgOztHyGCDFY9XNMJ6+Udhy+QpXk=; b=W0p1TIfPeZBJIzpESMXdx9qvlAwqgecetFByDKVbe9Lc8YHQRNfm8xP0u063ZL4eq3 RbDtAWAOe7UAo5AT/9Nfsjl9DbS+XCZfVcUttEbuteSWuCJIvnqsCI8ZtuGQCdtEARou MIKRKJ/aPA/I2jR+xz4BjkEWurAp/JtqqQf2h4/zVuD5vFYwoxArv9lmcWTHGUnf5Da7 VB0HlCGln8AVFfeSwCfoV3aWlWh0XkQSCtroAkRowGPI89xi/uq1XOB5KUb7+5NXGj5a 3wzeYllfwtD4eqPDPvVPhCcDxJBg5xw6Pb1kZ1CTB600I1PuGxvvH2Kyvqtm17rYB2pR qC5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6cOBj8Ho+R4A3czQgOztHyGCDFY9XNMJ6+Udhy+QpXk=; b=3r4Z4cYtbn1owBiIvcchBMiBov8RkEvphBPNP8pStB8JtjBmo9huePfukEFeEExUTE Gied9cx8PHtAw6FIKYr1KyqLPiUGcSXiWItXh7cvNgWFyesU0d3W0NScBlxY1BPH28pP 3XPHLjUB4CA8pu8hBQuVsGw14g552LtITMS6VjEj9kvxrwp5ihcANVzA1sOsIvZ/8HX6 R12BhXpLmod4tqQpH7PDMp7kQ7gQvZpiQklQ3625U9GklqhM+YOdC2T3Ns+f7sJYJ08H wRQhhKMJdIOPtq/m1Cx4qvbTt5oZhpyV+p72FAEmnHFocfGh6lSmIaF0naO924qeUXI8 zTvg== X-Gm-Message-State: AOAM532jFddiTSmlQjlJRY0hk5t71PC/1tWcpmO9I6EOK9l4D65H4wqR Ur5tUb7D0mxCqpZcO9JdZsrx1Q== X-Google-Smtp-Source: ABdhPJzY80DsKARaQhVvfa8bLVVeGLI7Jq6SnN5CV2lObpv3ZKw6BDYtXOsUmVxF/nbhyveRixT8eQ== X-Received: by 2002:ac2:4251:: with SMTP id m17mr5539862lfl.514.1633463353635; Tue, 05 Oct 2021 12:49:13 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id k28sm2083577ljn.57.2021.10.05.12.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 12:49:13 -0700 (PDT) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Mauri Sandberg , DENG Qingfang Subject: [PATCH net-next 1/3 v5] net: dsa: rtl8366rb: Support disabling learning Date: Tue, 5 Oct 2021 21:47:02 +0200 Message-Id: <20211005194704.342329-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211005194704.342329-1-linus.walleij@linaro.org> References: <20211005194704.342329-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The RTL8366RB hardware supports disabling learning per-port so let's make use of this feature. Rename some unfortunately named registers in the process. Suggested-by: Vladimir Oltean Cc: Alvin Šipraga Cc: Mauri Sandberg Cc: Florian Fainelli Cc: DENG Qingfang Reviewed-by: Vladimir Oltean Signed-off-by: Linus Walleij --- ChangeLog v4->v5: - Collect Vladimir's review tag. ChangeLog v3->v4: - No changes, rebased on other patches. ChangeLog v2->v3: - Disable learning by default, learning will be turned on selectively using the callback. ChangeLog v1->v2: - New patch suggested by Vladimir. --- drivers/net/dsa/rtl8366rb.c | 50 ++++++++++++++++++++++++++++++++----- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c index bb9d017c2f9f..b3056064b937 100644 --- a/drivers/net/dsa/rtl8366rb.c +++ b/drivers/net/dsa/rtl8366rb.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -42,9 +43,12 @@ /* Port Enable Control register */ #define RTL8366RB_PECR 0x0001 -/* Switch Security Control registers */ -#define RTL8366RB_SSCR0 0x0002 -#define RTL8366RB_SSCR1 0x0003 +/* Switch per-port learning disablement register */ +#define RTL8366RB_PORT_LEARNDIS_CTRL 0x0002 + +/* Security control, actually aging register */ +#define RTL8366RB_SECURITY_CTRL 0x0003 + #define RTL8366RB_SSCR2 0x0004 #define RTL8366RB_SSCR2_DROP_UNKNOWN_DA BIT(0) @@ -927,13 +931,14 @@ static int rtl8366rb_setup(struct dsa_switch *ds) /* layer 2 size, see rtl8366rb_change_mtu() */ rb->max_mtu[i] = 1532; - /* Enable learning for all ports */ - ret = regmap_write(smi->map, RTL8366RB_SSCR0, 0); + /* Disable learning for all ports */ + ret = regmap_write(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL, + RTL8366RB_PORT_ALL); if (ret) return ret; /* Enable auto ageing for all ports */ - ret = regmap_write(smi->map, RTL8366RB_SSCR1, 0); + ret = regmap_write(smi->map, RTL8366RB_SECURITY_CTRL, 0); if (ret) return ret; @@ -1272,6 +1277,37 @@ static int rtl8366rb_vlan_filtering(struct dsa_switch *ds, int port, return ret; } +static int +rtl8366rb_port_pre_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + /* We support enabling/disabling learning */ + if (flags.mask & ~(BR_LEARNING)) + return -EINVAL; + + return 0; +} + +static int +rtl8366rb_port_bridge_flags(struct dsa_switch *ds, int port, + struct switchdev_brport_flags flags, + struct netlink_ext_ack *extack) +{ + struct realtek_smi *smi = ds->priv; + int ret; + + if (flags.mask & BR_LEARNING) { + ret = regmap_update_bits(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL, + BIT(port), + (flags.val & BR_LEARNING) ? 0 : BIT(port)); + if (ret) + return ret; + } + + return 0; +} + static int rtl8366rb_change_mtu(struct dsa_switch *ds, int port, int new_mtu) { struct realtek_smi *smi = ds->priv; @@ -1682,6 +1718,8 @@ static const struct dsa_switch_ops rtl8366rb_switch_ops = { .port_vlan_del = rtl8366_vlan_del, .port_enable = rtl8366rb_port_enable, .port_disable = rtl8366rb_port_disable, + .port_pre_bridge_flags = rtl8366rb_port_pre_bridge_flags, + .port_bridge_flags = rtl8366rb_port_bridge_flags, .port_change_mtu = rtl8366rb_change_mtu, .port_max_mtu = rtl8366rb_max_mtu, }; From patchwork Tue Oct 5 19:47:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 12537591 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D916FC43217 for ; Tue, 5 Oct 2021 19:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B99F861371 for ; Tue, 5 Oct 2021 19:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235837AbhJETvJ (ORCPT ); Tue, 5 Oct 2021 15:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235793AbhJETvH (ORCPT ); Tue, 5 Oct 2021 15:51:07 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B41C061762 for ; Tue, 5 Oct 2021 12:49:16 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id u18so476319lfd.12 for ; Tue, 05 Oct 2021 12:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DpxUMZjEmbxwlgRUpAcp+St9BsqthlNtt9JsygSxW+o=; b=NItpHXRHgiq33607CdbclkJ/3iYXWL8iQwjOqx4tweEMNnJw/aXQhMnyvX9Pav05ab 8tyelQGc8qU+rXPL6CpWcoZy7UTV4Ru2huT95KInCFw2+MzHYqeTezZ5I754XOQ72yQJ masF7BIjWrClAhsluduG89Ztseoc1azIWVAhiQ6+CWOA3te8Ij8gcO0c0uuvZiZIPfiD fmlGfze2G2C/gQgs0C7kWYaq1FxhWobfLZyLCBz9MBRgD4wfHZVONq+Yn+eSAaWQMkZ9 p9AFdC88n9xdMHbXRlvpXZfZLhyRmX0UluVO44wzAqZz/hzugzbo4vcXih8K81i5pFSb irNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DpxUMZjEmbxwlgRUpAcp+St9BsqthlNtt9JsygSxW+o=; b=pYZ6bZ0OcvZKt0nly9FwZHI05EYolb8n7spVpHspYohvg8iVBS6g1VRkaIQxJbNkCE 75+Esao/XmrBw/mSAQtlNHk8Aq4jN8ioixmq0PFJMYsF7CWMj7CSGGBeV4FJrwljReXa rzsSWcUaG4e/VpsFEneUXtqQNvUiKDTPtfNnGajFdp+6pmWrAlWwlioJkAaQTjhAlLaI EA89prWEDUKY+gkEyKeNSXlaJVYxy5pAXmmNpLWweToItzYf4B6vaWGVnBgppNFkslxk oyk3B3G5bbN14SIwq95iYGykcbLgh2bRDlJCHmqPrPoHLocsT3zCrat7amxoB5gFfxKI ay+Q== X-Gm-Message-State: AOAM531aWWzhauqi/GZKnUmkd5feEOC6hFQmQsMiOJUdlD4nno1ZxPv+ GM9Ck2/c+zyne/SJd6LWTR/G4w== X-Google-Smtp-Source: ABdhPJx2Tt7FPg+9G7A1zHKb3UIl7O+5AIRaP4Vi5RXdWlwI0aGPyqWqd8w1EWW/Xl3WVg6M5acemg== X-Received: by 2002:ac2:5e9c:: with SMTP id b28mr5292950lfq.468.1633463355147; Tue, 05 Oct 2021 12:49:15 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id k28sm2083577ljn.57.2021.10.05.12.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 12:49:14 -0700 (PDT) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij , Mauri Sandberg , DENG Qingfang , =?utf-8?q?Alvin_=C5=A0ipraga?= Subject: [PATCH net-next 2/3 v5] net: dsa: rtl8366rb: Support fast aging Date: Tue, 5 Oct 2021 21:47:03 +0200 Message-Id: <20211005194704.342329-3-linus.walleij@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211005194704.342329-1-linus.walleij@linaro.org> References: <20211005194704.342329-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This implements fast aging per-port using the special "security" register, which will flush any learned L2 LUT entries on a port. The vendor API just enabled setting and clearing this bit, so we set it to age out any entries on the port and then we clear it again. Suggested-by: Vladimir Oltean Cc: Mauri Sandberg Cc: DENG Qingfang Cc: Florian Fainelli Reviewed-by: Alvin Šipraga Signed-off-by: Linus Walleij Reviewed-by: Vladimir Oltean --- ChangeLog v4->v5: - Update changelog a bit what else can we do. ChangeLog v3->v4: - No changes, rebased on the other patches. ChangeLog v2->v3: - Underscore that this only affects learned L2 entries, not static ones. ChangeLog v1->v2: - New patch suggested by Vladimir. --- drivers/net/dsa/rtl8366rb.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c index b3056064b937..c78e4220ddd1 100644 --- a/drivers/net/dsa/rtl8366rb.c +++ b/drivers/net/dsa/rtl8366rb.c @@ -1308,6 +1308,19 @@ rtl8366rb_port_bridge_flags(struct dsa_switch *ds, int port, return 0; } +static void +rtl8366rb_port_fast_age(struct dsa_switch *ds, int port) +{ + struct realtek_smi *smi = ds->priv; + + /* This will age out any learned L2 entries */ + regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL, + BIT(port), BIT(port)); + /* Restore the normal state of things */ + regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL, + BIT(port), 0); +} + static int rtl8366rb_change_mtu(struct dsa_switch *ds, int port, int new_mtu) { struct realtek_smi *smi = ds->priv; @@ -1720,6 +1733,7 @@ static const struct dsa_switch_ops rtl8366rb_switch_ops = { .port_disable = rtl8366rb_port_disable, .port_pre_bridge_flags = rtl8366rb_port_pre_bridge_flags, .port_bridge_flags = rtl8366rb_port_bridge_flags, + .port_fast_age = rtl8366rb_port_fast_age, .port_change_mtu = rtl8366rb_change_mtu, .port_max_mtu = rtl8366rb_max_mtu, }; From patchwork Tue Oct 5 19:47:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 12537593 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB6BC433FE for ; Tue, 5 Oct 2021 19:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2501A613B5 for ; Tue, 5 Oct 2021 19:49:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235878AbhJETvM (ORCPT ); Tue, 5 Oct 2021 15:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235830AbhJETvJ (ORCPT ); Tue, 5 Oct 2021 15:51:09 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B10C061749 for ; Tue, 5 Oct 2021 12:49:18 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id u18so476552lfd.12 for ; Tue, 05 Oct 2021 12:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pku09rj7/VU7FTxKbOt83SUvrPCcVT0ttGrANV0CkWQ=; b=dBimG1esq4CMK92UHmrupXVB8h7YFyYHBsFKUQGK7zt08Wu7fEbNBp/BUyxMTmDKJT 0nNPWDAcBz+uqekxNevz6Ryr+BYlT5KTlb7osscGCVBL33yR/J8jdO1ARXUlFKY4gi7H +RFl21XvOfevpZmPnMij/u+0cwRfAM5DGBQoOxBuuTuiQhD1WyBhLrSmbTTtll9fdk7n ZoFiEquSJLMlzUrWxJov7Ht6+rxVD5DiUPQm7+wkEWpCfogIsFgh3wzeKagNJOnr+wT0 WfD45MLYPLaE1BFLUcJUEvzDBvht4Bf/NaHCDvRnCP42+776ZGxGnkF1hqdC/BwfZ6RU ILow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pku09rj7/VU7FTxKbOt83SUvrPCcVT0ttGrANV0CkWQ=; b=ZGsgNlbLgGktQlK5z57h/gpA3HP277up+XyyKuk9QgPRPIContT0umKVBCL4AlxVbj KREI5nKOtKG9UfxHKyg769AjGIvUPa7SfxudyMv7jD8t+xfym+0kQZvfPbjkgOs3sEAc 0H4NAaNMfn/0pJfwpMYMRj/0xyl86ypgCnbO5sI6UpIxIjR/d5d1sO/tL+bDOP2F3mUh fWFCRy9gJiiwvbCzeICs8EzzIMD4b+BicAL5vh7K/4f9QWzsMsW2ZvRbHf17j77qRtjO ZJmLU6SRPcoTyT6cNge68K0wCcXj45Mj1Uq6m1gL4RGAOsROutYr1u1yYTOh3WKuDOjp dUvw== X-Gm-Message-State: AOAM533JQ+ACa4Wk4JqCX81Cy0beLvKbpjPJNOsk5BcQggEm4Bovjlwe 5XWsq3vdmXEphxydQw0oFYPKGQ== X-Google-Smtp-Source: ABdhPJzjmya5A89pSlQzt2eG+uYlDqstfzi5q9zl5E69P0RGAQrwuiyXvkQiUo10a/s2cn1nqBpSBg== X-Received: by 2002:a2e:544a:: with SMTP id y10mr24851671ljd.323.1633463356559; Tue, 05 Oct 2021 12:49:16 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id k28sm2083577ljn.57.2021.10.05.12.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 12:49:16 -0700 (PDT) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Mauri Sandberg , DENG Qingfang Subject: [PATCH net-next 3/3 v5] net: dsa: rtl8366rb: Support setting STP state Date: Tue, 5 Oct 2021 21:47:04 +0200 Message-Id: <20211005194704.342329-4-linus.walleij@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211005194704.342329-1-linus.walleij@linaro.org> References: <20211005194704.342329-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This adds support for setting the STP state to the RTL8366RB DSA switch. This rids the following message from the kernel on e.g. OpenWrt: DSA: failed to set STP state 3 (-95) Since the RTL8366RB has one STP state register per FID with two bit per port in each, we simply loop over all the FIDs and set the state on all of them. Cc: Vladimir Oltean Cc: Alvin Šipraga Cc: Mauri Sandberg Cc: DENG Qingfang Signed-off-by: Linus Walleij Reviewed-by: Vladimir Oltean --- ChangeLog v4->v5: - Rename register from RTL8368S* to RTL8366RB as all other registers. (RTL8368S is some similar ASIC maybe the same.) - Rename registers from "SPT" to "STP", we assume this is just a typo in the vendor tree. - Create RTL8366RB_STP_STATE_MASK() and RTL8366RB_STP_STATE() macros and use these. ChangeLog v1->v4: - New patch after discovering that we can do really nice bridge offloading with these bits. --- drivers/net/dsa/rtl8366rb.c | 48 +++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c index c78e4220ddd1..d2370cda4be0 100644 --- a/drivers/net/dsa/rtl8366rb.c +++ b/drivers/net/dsa/rtl8366rb.c @@ -110,6 +110,18 @@ #define RTL8366RB_POWER_SAVING_REG 0x0021 +/* Spanning tree status (STP) control, two bits per port per FID */ +#define RTL8366RB_STP_STATE_BASE 0x0050 /* 0x0050..0x0057 */ +#define RTL8366RB_STP_STATE_DISABLED 0x0 +#define RTL8366RB_STP_STATE_BLOCKING 0x1 +#define RTL8366RB_STP_STATE_LEARNING 0x2 +#define RTL8366RB_STP_STATE_FORWARDING 0x3 +#define RTL8366RB_STP_MASK GENMASK(1, 0) +#define RTL8366RB_STP_STATE(port, state) \ + ((state) << ((port) * 2)) +#define RTL8366RB_STP_STATE_MASK(port) \ + RTL8366RB_STP_STATE((port), RTL8366RB_STP_MASK) + /* CPU port control reg */ #define RTL8368RB_CPU_CTRL_REG 0x0061 #define RTL8368RB_CPU_PORTS_MSK 0x00FF @@ -234,6 +246,7 @@ #define RTL8366RB_NUM_LEDGROUPS 4 #define RTL8366RB_NUM_VIDS 4096 #define RTL8366RB_PRIORITYMAX 7 +#define RTL8366RB_NUM_FIDS 8 #define RTL8366RB_FIDMAX 7 #define RTL8366RB_PORT_1 BIT(0) /* In userspace port 0 */ @@ -1308,6 +1321,40 @@ rtl8366rb_port_bridge_flags(struct dsa_switch *ds, int port, return 0; } +static void +rtl8366rb_port_stp_state_set(struct dsa_switch *ds, int port, u8 state) +{ + struct realtek_smi *smi = ds->priv; + u32 val; + int i; + + switch (state) { + case BR_STATE_DISABLED: + val = RTL8366RB_STP_STATE_DISABLED; + break; + case BR_STATE_BLOCKING: + case BR_STATE_LISTENING: + val = RTL8366RB_STP_STATE_BLOCKING; + break; + case BR_STATE_LEARNING: + val = RTL8366RB_STP_STATE_LEARNING; + break; + case BR_STATE_FORWARDING: + val = RTL8366RB_STP_STATE_FORWARDING; + break; + default: + dev_err(smi->dev, "unknown bridge state requested\n"); + return; + }; + + /* Set the same status for the port on all the FIDs */ + for (i = 0; i < RTL8366RB_NUM_FIDS; i++) { + regmap_update_bits(smi->map, RTL8366RB_STP_STATE_BASE + i, + RTL8366RB_STP_STATE_MASK(port), + RTL8366RB_STP_STATE(port, val)); + } +} + static void rtl8366rb_port_fast_age(struct dsa_switch *ds, int port) { @@ -1733,6 +1780,7 @@ static const struct dsa_switch_ops rtl8366rb_switch_ops = { .port_disable = rtl8366rb_port_disable, .port_pre_bridge_flags = rtl8366rb_port_pre_bridge_flags, .port_bridge_flags = rtl8366rb_port_bridge_flags, + .port_stp_state_set = rtl8366rb_port_stp_state_set, .port_fast_age = rtl8366rb_port_fast_age, .port_change_mtu = rtl8366rb_change_mtu, .port_max_mtu = rtl8366rb_max_mtu,