From patchwork Thu Sep 23 21:54:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 12537777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84198C433F5 for ; Thu, 23 Sep 2021 21:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6080B61214 for ; Thu, 23 Sep 2021 21:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243400AbhIWVz5 (ORCPT ); Thu, 23 Sep 2021 17:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235503AbhIWVz5 (ORCPT ); Thu, 23 Sep 2021 17:55:57 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594F3C061574 for ; Thu, 23 Sep 2021 14:54:25 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id e7so7750040pgk.2 for ; Thu, 23 Sep 2021 14:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rO5fvWaAZTv31oC9ovhV41R9OYan3E5Hn4Me7MlHqao=; b=PdHGDU8L54UaLJCl120uuECenLtn0S4ozb35+4bYoAq1fUqCCwbpP2gBaj0KTFzYTQ Sgrnk3uox0p/1HC8ml/Mld6J4i5VH7np3Dr7QdNEgV9LRr2VpU/g4h+3eiYsdxEdhtfl 18ZawluARpGS6r6nmGk5zVdSW1AWolmSZSAMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rO5fvWaAZTv31oC9ovhV41R9OYan3E5Hn4Me7MlHqao=; b=2nGAjk5kIbPV4Q7K1SIVE6U88hXISolySgOPhZkhB9mk7Zf7xeJUu7jTkwGjAZCaUb r/Kx+L+EXj/qrG7qgno7zZFysvb79sqZNBVWUehzztYDCPnAG2gD4e1KJ2OmPnFfQSR4 4P+G7W25R3pnR4O8MkF124tVXHdz3N2nM0UOofMwi8bk5A05XQKPXIS1awDrmwQXnRwR 5CUvPpCbpXs5wToq02chcTrPVPrH1fOe8fTDXeBN4uNTcdUmn7RT/4P0fvOxLs3oMfuv bAGq2wQzgF5nm6ea0tjUJQKkRsFwcGrzx6nuLAdNLxDpiolLipNRZeRkDOlUIdN5e/Io MWLw== X-Gm-Message-State: AOAM533PETLiBLb18uFbtF6WCnOHFH9L+yzo2TiRKs7nKOYVRp34WLNY uGHRTxFS3WKtu7voJqDk8rH6Wg== X-Google-Smtp-Source: ABdhPJz5pVycUAUnPkUoOj5EEeIyMN3UD7MqL9edoLVG3kOmI/4nCNwkI7uYkijol2fWRb/a5DtjVw== X-Received: by 2002:a62:b515:0:b0:42c:1d6e:3697 with SMTP id y21-20020a62b515000000b0042c1d6e3697mr6728074pfe.23.1632434064858; Thu, 23 Sep 2021 14:54:24 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s4sm6474569pfw.182.2021.09.23.14.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 14:54:24 -0700 (PDT) From: Kees Cook To: "David S. Miller" Cc: Kees Cook , Masahiro Yamada , sparclinux@vger.kernel.org, Nicolas Schier , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] sparc: Add missing "FORCE" target when using if_changed Date: Thu, 23 Sep 2021 14:54:18 -0700 Message-Id: <20210923215418.3936726-1-keescook@chromium.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1740; h=from:subject; bh=Hi7mcbZQHql8JSSHs4df7iME4Qh5LyRhGPXmEIr0KIM=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBhTPeK0F/lnHe1QtyWqYJaRZ7GdQ4iM4IHlTaipc+D HmZ0Y06JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYUz3igAKCRCJcvTf3G3AJpdaD/ 9CSsUqhdMc08Bxkzl4r+hGn7L0dUJO/0ix9wg5V3/6Dbh+mB/eqcwCvq9kGRbvGCWt6O/V62mxv4Vl SbJGH5PTiDVkCArO/liNSHWtJ5KxsK4qyPveSCi2p+yNjgH6kezcnft6x2jUG24XDHund4Go9P06V5 wRlFBaqQFUF6BqnG3vEcKlOir0nAxSE6q6KkBnZc6v8fYp6wpg0Yppe+wZ6IIZN8wNSgoC2SnjirVz nqD6eq/kbu8U9S+SAUP/vDN5W7hoSSBigBmiuMX4hSTjICopx2bUZFLT88rw1MuWtb4+AKbuMkITiW 3WTptPf1hhI2bPayOMW8+whe23hba/Qlrgq0PjuT92CpYAjUB/MFbfaS5fhwhN9w8seCKmxPTCCGJD iDyuIo2oPMwUW6zVP9wsf1HGhmaNmEBVvcN3SzPRR/xkfhJgEnbpFOU/Py1RzDY9yUs/DJ2v1Pu8Bi KnU1plyHY4P/IE0Ai8EZwvY0Lm0p2CTJ/zAcWvEj/yrfZ7Zux+luanfw6lEePxyLQhRgW3wZL/4FMZ 1rH2w/KfbbtU6w9biWSpduSNz+e91L4ftIy+oS33AlRZAXK/CoX1aZtu6CbLvHZozK+vFxkck9pdJw dLNMRNRKGkWUE36n6XVs0vUkPLGAUk0b145ol/m0ssFMO+P4tuSpclAVoQzw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Fix observed warning: /builds/linux/arch/sparc/boot/Makefile:35: FORCE prerequisite is missing Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk") Cc: "David S. Miller" Cc: Masahiro Yamada Cc: sparclinux@vger.kernel.org Signed-off-by: Kees Cook Acked-by: Nicolas Schier --- I'm not sure if this should go via sparc or via kbuild. :) --- arch/sparc/boot/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile index 849236d4eca4..45e5c76d449e 100644 --- a/arch/sparc/boot/Makefile +++ b/arch/sparc/boot/Makefile @@ -22,7 +22,7 @@ ifeq ($(CONFIG_SPARC64),y) # Actual linking -$(obj)/zImage: $(obj)/image +$(obj)/zImage: $(obj)/image FORCE $(call if_changed,gzip) @echo ' kernel: $@ is ready' @@ -31,7 +31,7 @@ $(obj)/vmlinux.aout: vmlinux FORCE @echo ' kernel: $@ is ready' else -$(obj)/zImage: $(obj)/image +$(obj)/zImage: $(obj)/image FORCE $(call if_changed,strip) @echo ' kernel: $@ is ready' @@ -44,7 +44,7 @@ OBJCOPYFLAGS_image.bin := -S -O binary -R .note -R .comment $(obj)/image.bin: $(obj)/image FORCE $(call if_changed,objcopy) -$(obj)/image.gz: $(obj)/image.bin +$(obj)/image.gz: $(obj)/image.bin FORCE $(call if_changed,gzip) UIMAGE_LOADADDR = $(CONFIG_UBOOT_LOAD_ADDR) @@ -56,7 +56,7 @@ quiet_cmd_uimage.o = UIMAGE.O $@ -r -b binary $@ -o $@.o targets += uImage -$(obj)/uImage: $(obj)/image.gz +$(obj)/uImage: $(obj)/image.gz FORCE $(call if_changed,uimage) $(call if_changed,uimage.o) @echo ' Image $@ is ready'