From patchwork Wed Oct 6 09:44:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antoine Tenart X-Patchwork-Id: 12538895 X-Patchwork-Delegate: stephen@networkplumber.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEEBC433F5 for ; Wed, 6 Oct 2021 09:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D70061042 for ; Wed, 6 Oct 2021 09:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237851AbhJFJq5 (ORCPT ); Wed, 6 Oct 2021 05:46:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbhJFJqu (ORCPT ); Wed, 6 Oct 2021 05:46:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFEFA610C9; Wed, 6 Oct 2021 09:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633513498; bh=USn8x5LupaSji3uWzQG5LeIP/8bYvr2cT9Xsg+kViAw=; h=From:To:Cc:Subject:Date:From; b=Ka/D+4rJ7WQuFa9lBKV4/GALGrQuyJ1s22JwaiYCmz3TAOZI8ozWBst+hykVbB4hR v3n617SKNcoyNLuGYtaqgkVvgabHgI6RdxS2Zr1jNLl/XSL6l3yZIvM9/3zYnV7VzY dL9bp0O/jIN0UQmjq/HUGwaYn7IoRxM4G28iJT8SxMp8mtdrJfLggxg+F7iVnfoYz4 ybPpgU3sUwNdsHMERhmJlsuJMF1/tvRwZNvcizJ2rtnJU5nfWR/qLdPu0gvGa0J0Nz 7vD1qZzGNscR7AJ9EV5BZZUERtta48l3Sna9ShULu+ZLb9e78axvk2X5olq3/2VARb RjwzAwmIztBGQ== From: Antoine Tenart To: jiri@nvidia.com, stephen@networkplumber.org, dsahern@gmail.com Cc: Antoine Tenart , netdev@vger.kernel.org Subject: [PATCH iproute2-next 1/3] man: devlink-port: fix the devlink port add synopsis Date: Wed, 6 Oct 2021 11:44:53 +0200 Message-Id: <20211006094455.138504-1-atenart@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: dsahern@gmail.com When configuring a devlink PCI SF port, the sfnumber can be specified using 'sfnum' and not 'pcisf' as stated in the man page. Fix this. Signed-off-by: Antoine Tenart --- man/man8/devlink-port.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/devlink-port.8 b/man/man8/devlink-port.8 index 147c8e271d79..4d2ff5d87144 100644 --- a/man/man8/devlink-port.8 +++ b/man/man8/devlink-port.8 @@ -53,7 +53,7 @@ devlink-port \- devlink port configuration .RB "[ " pcipf .IR PFNUMBER " ]" .br -.RB "{ " pcisf +.RB "{ " sfnum .IR SFNUMBER " }" .br .RB "[ " controller From patchwork Wed Oct 6 09:44:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antoine Tenart X-Patchwork-Id: 12538897 X-Patchwork-Delegate: stephen@networkplumber.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB2FC433FE for ; Wed, 6 Oct 2021 09:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD29D610E5 for ; Wed, 6 Oct 2021 09:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237928AbhJFJq7 (ORCPT ); Wed, 6 Oct 2021 05:46:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237929AbhJFJqw (ORCPT ); Wed, 6 Oct 2021 05:46:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ACEE761042; Wed, 6 Oct 2021 09:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633513501; bh=XD9jOi/4VXMDIlLVjQpA9rBxSsl9vrWX6SL0fFsrimk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f5/e1PaBSFJ6bbwUFgM8hgK1a0z4ca6OLuVQ+VjHBjb+zdgC1t4QMeemMNBBq6SQW cCT9RDBkrcFrucnBIJE+9B239sC8mmmdrS9u43B7R8LPh6p4jtyff0midv9pQTRm0D ePDwpFBZFUBk+fNRSBkCi37DRZc9L4yFZ9MRpkFgsf+W95/aAujDqIwSuKxUP/bhLt BLSgVacFmhKyyLa8+p83GobctmW3AKNh7/dETSIxrgIZSHTbkhsruM0xhsBWi/NecT fwoamBN/zDmtyaqJP6YWotpBG7JOTyd51VqUAXGBKSatDvt8N4JnQvMMTfZK4dzRrs zFVXcukAOKF7w== From: Antoine Tenart To: jiri@nvidia.com, stephen@networkplumber.org, dsahern@gmail.com Cc: Antoine Tenart , netdev@vger.kernel.org Subject: [PATCH iproute2-next 2/3] man: devlink-port: fix style Date: Wed, 6 Oct 2021 11:44:54 +0200 Message-Id: <20211006094455.138504-2-atenart@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211006094455.138504-1-atenart@kernel.org> References: <20211006094455.138504-1-atenart@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: dsahern@gmail.com Values should be .I, square brackets should be used for optional values, curly brackets for lists. Follow this in the devlink-port man page. Signed-off-by: Antoine Tenart --- man/man8/devlink-port.8 | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/man/man8/devlink-port.8 b/man/man8/devlink-port.8 index 4d2ff5d87144..e5686deae573 100644 --- a/man/man8/devlink-port.8 +++ b/man/man8/devlink-port.8 @@ -45,16 +45,16 @@ devlink-port \- devlink port configuration .ti -8 .BI "devlink port add" -.RB "[" +.RB "{" .IR "DEV | DEV/PORT_INDEX" -.RB "] " +.RB "} " .RB "[ " flavour .IR FLAVOUR " ]" .RB "[ " pcipf .IR PFNUMBER " ]" .br -.RB "{ " sfnum -.IR SFNUMBER " }" +.RB "[ " sfnum +.IR SFNUMBER " ]" .br .RB "[ " controller .IR CNUM " ]" @@ -102,7 +102,7 @@ devlink-port \- devlink port configuration .SS devlink port set - change devlink port attributes .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .in +4 @@ -126,7 +126,7 @@ set port type .SS devlink port split - split devlink port into more .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .TP @@ -137,7 +137,7 @@ number of ports to split to. Could be performed on any split port of the same split group. .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .SS devlink port show - display devlink port attributes @@ -154,11 +154,11 @@ Is an alias for .ti -8 .SS devlink port add - add a devlink port .PP -.B "DEV" +.I "DEV" - specifies the devlink device to operate on. or .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port index to use for the requested new port. This is optional. When omitted, driver allocates unique port index. @@ -173,17 +173,17 @@ set port flavour - PCI SF port .TP -.BR pfnum " { " pfnumber " } " +.BI pfnum " PFNUMBER " Specifies PCI pfnumber to use on which a SF device to create .TP -.BR sfnum " { " sfnumber " } " +.BI sfnum " SFNUMBER " Specifies sfnumber to assign to the device of the SF. This field is optional for those devices which supports auto assignment of the SF number. .TP -.BR controller " { " controller " } " +.BI controller " CNUM " Specifies controller number for which the SF port is created. This field is optional. It is used only when SF port is created for the external controller. @@ -192,17 +192,17 @@ external controller. .SS devlink port function set - Set the port function attribute(s). .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .TP -.BR hw_addr " ADDR" -- hardware address of the function to set. This is a Ethernet MAC address when +.BI hw_addr " ADDR" +Hardware address of the function to set. This is a Ethernet MAC address when port type is Ethernet. .TP .BR state " { " active " | " inactive " } " -- new state of the function to change to. +New state of the function to change to. .I active - Once configuration of the function is done, activate the function. @@ -213,13 +213,13 @@ port type is Ethernet. .ti -8 .SS devlink port del - delete a devlink port .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to delete. .ti -8 .SS devlink port param set - set new value to devlink port configuration parameter .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .TP @@ -246,7 +246,7 @@ Configuration mode in which the new value is set. .SS devlink port param show - display devlink port supported configuration parameters attributes .PP -.B "DEV/PORT_INDEX" +.I "DEV/PORT_INDEX" - specifies the devlink port to operate on. .B name From patchwork Wed Oct 6 09:44:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antoine Tenart X-Patchwork-Id: 12538899 X-Patchwork-Delegate: stephen@networkplumber.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E41C433EF for ; Wed, 6 Oct 2021 09:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07F2D610C9 for ; Wed, 6 Oct 2021 09:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbhJFJrI (ORCPT ); Wed, 6 Oct 2021 05:47:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:46088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237966AbhJFJqz (ORCPT ); Wed, 6 Oct 2021 05:46:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5ACAE61042; Wed, 6 Oct 2021 09:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633513503; bh=XowIppL/KzHC69bciPwXEUNPJLCa8thkeUAi+9/glwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nGPeBQN5rLCQ3BQREXSbD8SW7uB2BxK64ZO+oiaUw2/NX/UjkPen980D00T2ztdit cT/rUXG5GaLy87m05uuKFvMarc73Nz7qX4Xx8oKYu8FTtyVw9wviig+02BVPFM/eT5 16iAZml2nKFMrtvqBXXrYpEzJk+9OPx9z5KJFCDxdwFdrYLKg2mWIEATOfohBeJIP8 fFu4NoMcx8bX8IrEgwKTEJyN/gzwAVccq26NsiZ2ZG+9Pm2bKNiu/rSofuhRQvFHv9 9Xe7g2Wf7Y9ag64b6rcM2qfquUDyPMtIFU/VndcM6fWR0Y4VmNpoYCExIuApQczDYs ybPOjtyjHkWIQ== From: Antoine Tenart To: jiri@nvidia.com, stephen@networkplumber.org, dsahern@gmail.com Cc: Antoine Tenart , netdev@vger.kernel.org Subject: [PATCH iproute2-next 3/3] man: devlink-port: remove extra .br Date: Wed, 6 Oct 2021 11:44:55 +0200 Message-Id: <20211006094455.138504-3-atenart@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211006094455.138504-1-atenart@kernel.org> References: <20211006094455.138504-1-atenart@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: dsahern@gmail.com br. were added between options of the same command. That is not needed and makes the output to be one 3 lines for no particular reason. Signed-off-by: Antoine Tenart --- man/man8/devlink-port.8 | 2 -- 1 file changed, 2 deletions(-) diff --git a/man/man8/devlink-port.8 b/man/man8/devlink-port.8 index e5686deae573..e48c573578ca 100644 --- a/man/man8/devlink-port.8 +++ b/man/man8/devlink-port.8 @@ -52,10 +52,8 @@ devlink-port \- devlink port configuration .IR FLAVOUR " ]" .RB "[ " pcipf .IR PFNUMBER " ]" -.br .RB "[ " sfnum .IR SFNUMBER " ]" -.br .RB "[ " controller .IR CNUM " ]" .br