From patchwork Wed Oct 6 07:47:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12539637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E72C433F5 for ; Wed, 6 Oct 2021 15:44:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A12A3610A3 for ; Wed, 6 Oct 2021 15:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A12A3610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A5AB6ED17; Wed, 6 Oct 2021 15:43:57 +0000 (UTC) X-Greylist: delayed 430 seconds by postgrey-1.36 at gabe; Wed, 06 Oct 2021 07:54:34 UTC Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4924E6E509 for ; Wed, 6 Oct 2021 07:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1633506874; x=1665042874; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iG2jS+y/WSgcYwDoervvp4SA4wH8TDN8lILJ7OYWWWY=; b=Veo7EI8eCgrAIUFHS0tPaxpi+sjOAg9ymf7D08KbAd1J1mgr3iNuTJzx Idfa/6Q6pD2vzLs6Atjt9WGoUcRNUWuM6ubxaumdNpWw8FJ8Tfu49APDR UI//kbZmxoFTjh9eQv+ShDfUw7Nnu3jNe2Y5Sku/lL62ghhKZk44oZpcK JA+3tR1YCBmnyrpNWjUMfKLCSkFnH/jZsd4ZrHCEoFzSZ7yQUgxBgM1BY GMy/UDtqkZiH69k/BDmVpxiDfoY/j92rF/vUWZwiwevkMfMyXDDSlv26O PgwtvVzqjp0gT+zfJPqEXkUscvjLqK6/OZfUc4GZuu27UQxYjjD6v45he A==; X-IronPort-AV: E=Sophos;i="5.85,350,1624312800"; d="scan'208";a="19887676" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 06 Oct 2021 09:47:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 06 Oct 2021 09:47:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 06 Oct 2021 09:47:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1633506438; x=1665042438; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iG2jS+y/WSgcYwDoervvp4SA4wH8TDN8lILJ7OYWWWY=; b=jP4K0bij3UsTdRik7yyYu8w3xhjcRHuj9kkfT51NXIQu1RdIU5giJlzd YRhZ7ZWOFpPaiWnF6Ux5jUhYNpZolsP5iUeGvPTs/rnilJ/qDwWNPTemz U9udc2j1HfXSwj08QzoHn7sAosVZ0POAZqj27diGTLRM3sy7O0a7LS/cm E+Lr4anxMwBXHIocPdgTyQwxb9Rg01zLZ0wi7y10OB07Ew7eFyGny/qbg vLUprQTeoj+qqfNiID8v4wtG/aqO+YIsO0ssB7wRbQsGxoyMBJJ0tVh27 ickrjrUkHcvLE/emQkPW00Tk+vm88GTUJWzEDNB/fysBE+6PIQwrfsDi+ A==; X-IronPort-AV: E=Sophos;i="5.85,350,1624312800"; d="scan'208";a="19887675" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Oct 2021 09:47:18 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 82E24280065; Wed, 6 Oct 2021 09:47:18 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: [PATCH 1/3] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support Date: Wed, 6 Oct 2021 09:47:11 +0200 Message-Id: <20211006074713.1094396-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 06 Oct 2021 15:43:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VCC needs to be enabled before releasing the enable GPIO. Signed-off-by: Alexander Stein Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index a32f70bc68ea..5fab0fabcd15 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include @@ -143,6 +144,7 @@ struct sn65dsi83 { struct mipi_dsi_device *dsi; struct drm_bridge *panel_bridge; struct gpio_desc *enable_gpio; + struct regulator *vcc; int dsi_lanes; bool lvds_dual_link; bool lvds_dual_link_even_odd_swap; @@ -647,6 +649,12 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model) ctx->panel_bridge = panel_bridge; + ctx->vcc = devm_regulator_get(dev, "vcc"); + if (IS_ERR(ctx->vcc)) + return dev_err_probe(dev, PTR_ERR(ctx->vcc), + "Failed to get supply 'vcc': %pe\n", + ERR_PTR(ret)); + return 0; } @@ -690,7 +698,11 @@ static int sn65dsi83_probe(struct i2c_client *client, ctx->bridge.of_node = dev->of_node; drm_bridge_add(&ctx->bridge); - return 0; + ret = regulator_enable(ctx->vcc); + if (ret) + dev_err(dev, "Failed to enable vcc\n"); + + return ret; } static int sn65dsi83_remove(struct i2c_client *client) @@ -701,6 +713,7 @@ static int sn65dsi83_remove(struct i2c_client *client) mipi_dsi_device_unregister(ctx->dsi); drm_bridge_remove(&ctx->bridge); of_node_put(ctx->host_node); + regulator_disable(ctx->vcc); return 0; } From patchwork Wed Oct 6 07:47:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12539639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C965CC433EF for ; Wed, 6 Oct 2021 15:44:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F55F610A3 for ; Wed, 6 Oct 2021 15:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F55F610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60BFC6ECFD; Wed, 6 Oct 2021 15:43:57 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 360556E509 for ; Wed, 6 Oct 2021 07:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1633506875; x=1665042875; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TLwy29Z74qOt7jxrwkFUfPbnsEScBrPBXFyKkjDo208=; b=Z2XOidny/Ir0ht/HBGoLMrg4M4VALHGGKZU+RLuQO9VzuA6F3uata5Ct Pfy1a/PSgCjRUhseKEAczP6EF3KGjtDWVBFPiAW2hemte1IbOqIvynFhR Wms/uoFUaKAUOSC4qKwwDhtpXLOzcKZs6B2NAmFrUEL9BNbn7cC9iE6Sb zNyy4iGEdfG9aEiLwGZAgZQwbIympaC9IrD4uJdEdbYNosZMOe/6MNHaP YXQhEbrIa3t1gFjezevaSC143UjGID+1vntig6jzi6g6LZivGY6sj0xKB aQ1DfP3M+FizMUilRMFVJ8KZDF/r3Wt+4Pbj1LdFlc84WjF4B0Ed+HES3 w==; X-IronPort-AV: E=Sophos;i="5.85,350,1624312800"; d="scan'208";a="19887680" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 06 Oct 2021 09:47:21 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 06 Oct 2021 09:47:22 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 06 Oct 2021 09:47:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1633506442; x=1665042442; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TLwy29Z74qOt7jxrwkFUfPbnsEScBrPBXFyKkjDo208=; b=RMEtELz91l1Aj+RHticl46UJH1cMMbzNv6X1munzMHQIC/BYK+RI0WXV h5v36cmKuh65+MDHHNEAQj4IzNTzenMG+J3KEo1eIliW/Npp2l2uExkk9 7FibsIZjrvuopo2cdWd6J3G9DQGkRflZXcV3oBvDFrETtR3mFAepWKCx4 /Cw9oTVKcSdYgQP20dpnz/thjtUJGEKmdJHLlETZ3OS35i7zA1Hrp/d7X r3FUY2zioIC8YXU8Rvc3nimPdJFIvGbVEQM1gh5m4qPHfT882kN5pVWuZ kLtG8rC+/8ARlj1giybvuN90eCnoZJ59gdpm+YAK8+fNoWxO5CV+Hi/eX g==; X-IronPort-AV: E=Sophos;i="5.85,350,1624312800"; d="scan'208";a="19887679" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Oct 2021 09:47:21 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id B11E0280065; Wed, 6 Oct 2021 09:47:21 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings Date: Wed, 6 Oct 2021 09:47:12 +0200 Message-Id: <20211006074713.1094396-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006074713.1094396-1-alexander.stein@ew.tq-group.com> References: <20211006074713.1094396-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 06 Oct 2021 15:43:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add a VCC regulator which needs to be enabled before the EN pin is released. Signed-off-by: Alexander Stein Reviewed-by: Sam Ravnborg --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index 07b20383cbca..149cff3233c2 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -32,6 +32,9 @@ properties: maxItems: 1 description: GPIO specifier for bridge_en pin (active high). + vcc-supply: + description: A 1.8V power supply (see regulator/regulator.yaml). + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -94,6 +97,7 @@ required: - compatible - reg - enable-gpios + - vcc-supply - ports allOf: @@ -135,6 +139,7 @@ examples: reg = <0x2d>; enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; + vcc-supply = <®_sn65dsi83_1v8>; ports { #address-cells = <1>;