From patchwork Wed Dec 12 20:47:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rgen_Storvist?= X-Patchwork-Id: 10727095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 611AE15A6 for ; Wed, 12 Dec 2018 20:47:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 489512BA8C for ; Wed, 12 Dec 2018 20:47:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C2942BA8E; Wed, 12 Dec 2018 20:47:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAAEA2BA8C for ; Wed, 12 Dec 2018 20:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726297AbeLLUrr (ORCPT ); Wed, 12 Dec 2018 15:47:47 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:33107 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbeLLUrr (ORCPT ); Wed, 12 Dec 2018 15:47:47 -0500 Received: by mail-lj1-f195.google.com with SMTP id v1-v6so17567693ljd.0 for ; Wed, 12 Dec 2018 12:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=w/xwksgNfaMAwKPRqIQOoc9AL0FHNoEjU6qNMS7ruTw=; b=uZmHGySaDnIc0MHw6dZ03tAWIBVKhGN5jqdL+R3yMIQDaBcy5ZdDKPe5R7K27VnwMP DaCFI+5LwhDz4hfB0YnKVeW/K905y1FSiZBQwmIT3gbldDcl8kaSku5jFra40mbYfZ6N p9Bo+81/nEcpnSi83bERr9wQVfd2kaPSW4SqDmozxLJKspnVuxWajoEI263s2HlPjyiu nBVJ6kOZ35KyQ8UcRJcUR5Es3zsm1TxscNLuL0f191aRGcJQ+Nb85/xgvZZ3RvazBK9+ frEsbUp7N/XNIaKelHuMNc7QyhWHffxkUP6VPQztGOR2kPY2Tih7t/q7s36aFoDhx5ve +D/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=w/xwksgNfaMAwKPRqIQOoc9AL0FHNoEjU6qNMS7ruTw=; b=d27d6rV0WNHpQHW6clH6GYghsNNBYgy5pnlVlRNlC1PEFQNLDddzr8R5y+HtPbnBo4 MCoqpEqH1Mm22976W+zsJkb2rx00BnyiRUFYgvzf1/3QNr/hPuq+9c/gyviEo0XKiVVB ohIQsad2iZmAYWvPgJRM7jqScW+MmeXRhWRF3WMU4NFV8l8x3mxKtr+tGFhkoiWFqSt5 vaOHstCrDbMxxzyhCeWg+sqngiSl/UfgcnMHS2LpZCGlCGlZYrlyQRkrjh+KaPMn2FUG 4TdBBlO+lszKhxaKCtWw4nrCDU524kQEj6M1K7WxHqHFtLlRKb1Ad35aA9bdD91izuIA xLow== X-Gm-Message-State: AA+aEWZWL76KfP5r3WuvP6m9w/qXjZnibImRrtfBf/JL0pX6/9ujJLUw 26GEGnEGczeF8S0h9BrWPRz2/bq0vbYRng== X-Google-Smtp-Source: AFSGD/UZXgnU9sDTcjEJaGNOGuRfLQjm4Vv5GS/4PEkXlO7BzSog5cRRW35Ajf8Lt07kYJl2LlT4LQ== X-Received: by 2002:a2e:484:: with SMTP id a4-v6mr13286326ljf.27.1544647664046; Wed, 12 Dec 2018 12:47:44 -0800 (PST) Received: from localhost (213-67-189-66-no148.tbcn.telia.com. [213.67.189.66]) by smtp.gmail.com with ESMTPSA id v17-v6sm3397652ljg.32.2018.12.12.12.47.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 12:47:43 -0800 (PST) Date: Wed, 12 Dec 2018 21:47:36 +0100 From: =?utf-8?q?J=C3=B6rgen?= Storvist To: linux-usb@vger.kernel.org Cc: johan@kernel.org Subject: [PATCH v2] USB: serial: option: add Fibocom NL668 series Message-ID: <20181212214736.00007b29@gmail.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Added USB serial option driver support for Fibocom NL668 series cellular modules. Reserved USB endpoints 4, 5 and 6 for network + ADB interfaces. usb-devices output (QMI mode) T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 16 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1508 ProdID=1001 Rev=03.18 S: Manufacturer=Nodecom NL668 Modem S: Product=Nodecom NL668-CN Modem S: SerialNumber= C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan I: If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) usb-devices output (ECM mode) T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 17 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1508 ProdID=1001 Rev=03.18 S: Manufacturer=Nodecom NL668 Modem S: Product=Nodecom NL668-CN Modem S: SerialNumber= C: #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#= 4 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether I: If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether I: If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) Signed-off-by: Jörgen Storvist --- Changelog: Fixed line break issues Added reservation for ADB interface also Updated source option.c file to latest in usb-linus branch Thanks Johan for the inputs, here goes: diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 53e8de5..ff2e635 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1949,6 +1949,8 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x13) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x14) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x1b) }, + { USB_DEVICE(0x1508, 0x1001), /* Fibocom NL668 series */ + .driver_info = RSVD(4) | RSVD(5) | RSVD(6) }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids);