From patchwork Sat Oct 9 02:20:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E608C433EF for ; Sat, 9 Oct 2021 03:06:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E98FB60FC3 for ; Sat, 9 Oct 2021 03:06:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E98FB60FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r3p/2FpQ/HCPoEcUgtvRJR2A0QvYdg6cCV0S+tMckTU=; b=xolThFcxp1aNHz oJxIiFRM57Wy2kdG51rElZT9rCLUkdDuwvB7g4flzcdOlDiU9l+5CYUrJO9XEwQzGcf63qD8+JvkI 2kQVmmG0cX3xsxgfSrZ4IfWzPy7vg8aNRGH9fV8swX8LDpSuT+Z3YkI5UBVeD5N1GIunSQST1h6xS gD5t7bRAyXjzSAko03AXfn8qzlU22fip7XlLfv9V5qPv0a8GoXiYjyXR8NSJZB04vJwZakq/pVCWH LKVo9cEgDZ4VmpeTHX4HqccXEi4Sua3o0kIX1STLA/wmGIL5yVHW4ogx3ilpX1dALsTdFNEl6o8TC tgeaycIkzNujEe9XKzjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2fH-004osi-1g; Sat, 09 Oct 2021 03:04:48 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yR-004Xpj-BI for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:32 +0000 Received: by mail-pl1-x62a.google.com with SMTP id 21so1088565plo.13 for ; Fri, 08 Oct 2021 19:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=znmARRiQVkqC85lKLifIrCv0U2JcIdQKNsLQ6jRH+xY=; b=HuYOJMsuZ5Li1XRjQJpwwVLmkPRJfGKnjBoRjBAS5zeqnc8lCWIKTWTvwbCvJ+o4ZI +RQdB5JwpQaPDtiOy5+m8gnQRWXS85ZK+5nMSrR/lx8mp5xPEkfpH/GS4kopN/na2yjJ 29DMDXouNvov8TA+Am+SPb8wzBAtsN84V6iiF+9CdzLwUIqB18URDBIncmoB3MQyieX8 4lMSZQVgu0HOEPdvSDpEjcyXSNy/k6gSaJXSrtTRyYmuWRbCVzpJu5JmMxpExAhcfQPz 5FGqZYZEi3gi6Fo4cuwjI7pOBfDN8qmpnIwkiYGNk8nFC5C9P6mz8rreMrCGpx4DUzoQ /yuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=znmARRiQVkqC85lKLifIrCv0U2JcIdQKNsLQ6jRH+xY=; b=HvFa610U0qkuMgp3dl1dq8ltA00reN7xmcm+O92hlCSVG80KtHoN8S6guvCNbBjpFk 2KP04R9aWLehAbokXFC/USfAPDd+GaySSJ1Ss0AnswjOi0MLEJgjvLEYspGnPIbHVVKv cQCVhRsRlNxCHLDYSauRvJFV5HZgdU7bqTiA0AUkywKNLodHJ/JMKv5V9jsPj6h6rwA1 HlNxuLD79dhLaSYf/xrdtW1J9q6jYD3gnDon6TL7kbH91s0hjJ/mxb1nx3OWfFTMee2E HbMOXH967G9ViIlL7P7CQVnr9EOSm2pDCmXgJCc4qv3l7X++xfWNFiQ0nN+0GCrpXR2O e8og== X-Gm-Message-State: AOAM532HfxXrWr+NoP8XoXVQm6OCtyfoXTFfFJl+0OGBm+hLZ7qcq0K6 5BjtCWfLefm953UYhpdz9JVHaLtpjS8= X-Google-Smtp-Source: ABdhPJynV9gKczr8GslI4IAihm3p6jxKMIoLFMgQtYbWS/Y0NWCgFTjd2R0DmPdtmlaURv8r5n4D9w== X-Received: by 2002:a17:902:e793:b0:13b:9cae:5dcd with SMTP id cp19-20020a170902e79300b0013b9cae5dcdmr12772844plb.53.1633746030043; Fri, 08 Oct 2021 19:20:30 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:29 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Thomas Gleixner , Thomas Bogendoerfer , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 01/14] MIPS: BMIPS: Remove use of irq_cpu_offline Date: Fri, 8 Oct 2021 19:20:10 -0700 Message-Id: <20211009022023.3796472-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192031_445284_4C6F0072 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org irq_cpu_offline() is only used by MIPS and we should instead use irq_migrate_all_off_this_cpu(). This will be helpful in order to remove drivers/irqchip/irq-bcm7038-l1.c irq_cpu_offline callback which would have got in the way of making this driver modular. Suggested-by: Thomas Gleixner Acked-by: Thomas Bogendoerfer Signed-off-by: Florian Fainelli --- arch/mips/Kconfig | 1 + arch/mips/kernel/smp-bmips.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 771ca53af06d..2c03b27cec02 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -1782,6 +1782,7 @@ config CPU_BMIPS select CPU_HAS_PREFETCH select CPU_SUPPORTS_CPUFREQ select MIPS_EXTERNAL_TIMER + select GENERIC_IRQ_MIGRATION if HOTPLUG_CPU help Support for BMIPS32/3300/4350/4380 and BMIPS5000 processors. diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c index b6ef5f7312cf..f5d7bfa3472a 100644 --- a/arch/mips/kernel/smp-bmips.c +++ b/arch/mips/kernel/smp-bmips.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -373,7 +374,7 @@ static int bmips_cpu_disable(void) set_cpu_online(cpu, false); calculate_cpu_foreign_map(); - irq_cpu_offline(); + irq_migrate_all_off_this_cpu(); clear_c0_status(IE_IRQ5); local_flush_tlb_all(); From patchwork Sat Oct 9 02:20:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2285C433F5 for ; Sat, 9 Oct 2021 03:07:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BCA960F39 for ; Sat, 9 Oct 2021 03:07:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BCA960F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dX7z4Kl/qXNg24Rf2jbO+TrgQCc2vwgDm0pndgG8lAM=; b=a0xEDQDYsbtRwN L7ThkQJqyhCZCFZfTi24sfD3rD++sUknAI9q2DoyzSpWpgvbwHe4z6v2nXwBgDpE3tQmWQtS39Zis eIGxd5ocyY4c1CeQOdCJb1VN5GPnzsr0/Dt93sVL4SphnCiu/fLqJJO6wKXPRt27aQXEqHQCw9/Qx qO9FMaBvK2MzL1tgogShbh0XK4V5DL62ddD/AVyA8yBk1IBfr46pvgbGfd53YiRL6wgY1Ruma6bmM LiCtTrfW20O9Dtq/22VhfJ/qT8lGSZzJ0Q6+AWAKIVBJChDOXhGh4+4YOLlLRM94qohpzQYIr7IJA TjVJSY9gQzFX92LGKtZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2gA-004pCL-FL; Sat, 09 Oct 2021 03:05:42 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yS-004Xqs-VS for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:34 +0000 Received: by mail-pj1-x1032.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so10601907pjb.1 for ; Fri, 08 Oct 2021 19:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=PMSUeeAYM+oSOKVpdeZKASGuomG/1VnuqZk/Uq6pcXRsTS+Ue+dL7ctnmO7CK4cyo+ uQEnzGeBaaKpmwDCTEhtv2mddWa3KWk2qvOcvE5ysHODe3eZ6fH5Z5Gl1Ic4OcEpBHFa lmi3ZYd1NXuS5I8nzIYe4ikN+QGK3JoE8T4KDkTGQ4Tmfdp5r3Kjz0h5ENzqMOXIQ8jB 3k4RpZ8vLi8FK+8yhQrdl2zJ4DdUTZjIRZkrwoFyKrMAyG+FkqXkN/VT/z/oP6H82ag/ mGJEdxxE56MvHnr5fX5ZrgbdcyKX3LKtrpHDxkj//f5OUKjzTXFHv1uX/mF9fSejdcKQ i26g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=LB1NGzn2DN28zRA5PkCuqVXcCWIDvIsTXBOmuOXYjE+mA/ITKsFuePH8XX+tKgULIv SXFLRLbwP8ipg/8KJxSKGM83W3RzwRQwu8bdqq2wmv1NKQ6u1KPTyhiKpFY4K0GS0GAs nCFYdlP59dyDT5QlbHqPkY2A+g4kST7HlvtsADZ17KvAuNHrbCgjCM+bx2uieGsMtMwl xmPbiZUSJZF4o1aM63TEEXEfzDbk5GG83EwTUbjFJs0TyBqAM3hL1PNbsevc33lT6iKP 1wcZk3PGZryD39snnhrThHM+Fd1hz3hAYtQfhFH8pchc60t68N/W7H6SnCEIuVaNQems iKNQ== X-Gm-Message-State: AOAM530+NVl6q7HIuZbDVBbmKhgtkej/6t7rHYCyHS7xs8fmtDqoTiSi rVGg56d4TrrxBnN8vL4u6tA= X-Google-Smtp-Source: ABdhPJzg2OrVUx8X7+f5WBVJ9F/oWRwsNiIZF7TwFPVn4Cq0sLkiujyN2p8LDToBroMMnAdUY/oE0A== X-Received: by 2002:a17:90a:7d11:: with SMTP id g17mr15405247pjl.19.1633746031721; Fri, 08 Oct 2021 19:20:31 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:31 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 02/14] irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() Date: Fri, 8 Oct 2021 19:20:11 -0700 Message-Id: <20211009022023.3796472-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192033_052456_0A6F7445 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With arch/mips/kernel/smp-bmips.c having been migrated away from irq_cpu_offline() and use irq_migrate_all_off_this_cpu() instead, we no longer need to implement an .irq_cpu_offline() callback. This is a necessary change to facilitate the building of this driver as a module. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index a035c385ca7a..750156217c82 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -221,33 +221,6 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, return 0; } -#ifdef CONFIG_SMP -static void bcm7038_l1_cpu_offline(struct irq_data *d) -{ - struct cpumask *mask = irq_data_get_affinity_mask(d); - int cpu = smp_processor_id(); - cpumask_t new_affinity; - - /* This CPU was not on the affinity mask */ - if (!cpumask_test_cpu(cpu, mask)) - return; - - if (cpumask_weight(mask) > 1) { - /* - * Multiple CPU affinity, remove this CPU from the affinity - * mask - */ - cpumask_copy(&new_affinity, mask); - cpumask_clear_cpu(cpu, &new_affinity); - } else { - /* Only CPU, put on the lowest online CPU */ - cpumask_clear(&new_affinity); - cpumask_set_cpu(cpumask_first(cpu_online_mask), &new_affinity); - } - irq_set_affinity_locked(d, &new_affinity, false); -} -#endif - static int __init bcm7038_l1_init_one(struct device_node *dn, unsigned int idx, struct bcm7038_l1_chip *intc) @@ -396,9 +369,6 @@ static struct irq_chip bcm7038_l1_irq_chip = { .irq_mask = bcm7038_l1_mask, .irq_unmask = bcm7038_l1_unmask, .irq_set_affinity = bcm7038_l1_set_affinity, -#ifdef CONFIG_SMP - .irq_cpu_offline = bcm7038_l1_cpu_offline, -#endif #ifdef CONFIG_PM_SLEEP .irq_set_wake = bcm7038_l1_set_wake, #endif From patchwork Sat Oct 9 02:20:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E091C433EF for ; Sat, 9 Oct 2021 03:08:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6930060FC1 for ; Sat, 9 Oct 2021 03:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6930060FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n9reuRIPVjKqnJmb4/HFW15pg1LEXrSsoTLiQ4fWpMM=; b=dPsTkg1uvC4+L+ RSCEuBwDZn2WoQHCSIhZsiswjjBX1T4O/Qb85Wnqx4l1xmL+2paGK+q4Av2XQ5bt9Fl/2Uuq0c3G+ lSc4Wo84t65wewyL3Bo0uCB8HxTl98MEEjiMuk/ycXtm+YLGU37p0ciNmfoOloNe5w2+TDQY0ZhiK nP5Btvo9hwu1IU2zsKQBGJq+FxbDT8m5JANdZW4aZXD45gyn/8K/0XZs8W5l24XiIs7erWoA8G7UK URlFweq/Fa5TCvjhmh6AN5Xlcxy9TuAOfqLFwwFjaou9LgmgmkCyY70puyigvHO59nNP+jXwgNoUL LUsZ5pwJlsuKgpHMpRhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2gy-004pTQ-1X; Sat, 09 Oct 2021 03:06:32 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yU-004Xrs-M3 for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:36 +0000 Received: by mail-pl1-x630.google.com with SMTP id c4so7296887pls.6 for ; Fri, 08 Oct 2021 19:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b+ZBi3anDomFQV4e/giygkqAUlU4kNEpUMbqtcbvyD0=; b=GKRgrW9QFKOioBZo1RI+VKpq5uf6LGwK5q2jelZH/Z4LPF+xgZGOXxs+VqGU75R2mw weK4TN90FEmgYCwy+FrjrPTzqXgn0hPizTkv/FatD5UAQTuxvB8FTZIJRlsiyaht1kbC Gh0cEbcYbCQVluL6JW7zuZzLSeenNyRaBlKJVA4T48RZIsGf0Vzza11FXZ3mDfttKj5a YukxssY7uYec/Z9/Nb7S+uPhzw8i9B3549I3bal2AuTmL3vbku/RhSHownMTh5ewCRkt EyKfDAW+vlNqwxK2k1hZaQRhAjcqE/j7o3DvFevoW1jTk7DVxFSB94ANqQy0bLz0aTkf GN3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b+ZBi3anDomFQV4e/giygkqAUlU4kNEpUMbqtcbvyD0=; b=jCYkU95mVonWE8/OFvTd78RJXfUkTS/rWDaLS607fGykk6Ua/GAKr62rWVF6STZXsZ ajevBfxiDR1U5bt6BTaBzTWyQn/WdbS+pMT/v65JCKLJUcXSDDt+HHG9pStfnp7KeylX AgvsgwcY8H65ieV20kXP/WEbC+u4esVNxzV7XT+hL62ECuwU4/E1Br3FBb8Tb0KjCJ2+ tJrqGNeWcXKxEWlRDTzMDeNyneFFfFqqxop3Gwcf+h5TG9zSUDoienrRPdnLgK0QmXge cebA1UVZYMG9fHfqjyW0FAK47FZ17r2Z7MSLg3SEUMkiDb+GODjLwSlh2l+zjWO7JQk0 sqHQ== X-Gm-Message-State: AOAM533kYS+0FMWPRcWkTLFS2Mw3WnGWaa/DiUtAaSZ1LfdDVXcA7s+f IvCfPb9ZnS7kWvytiaO3yT4= X-Google-Smtp-Source: ABdhPJyEJoQPpWTVdtBiJLwZn89ZXiyoahAuHDNGpbSqabP7fCIHLAdNqD7QVHIdSxf9qwDLs0VGYQ== X-Received: by 2002:a17:90a:a585:: with SMTP id b5mr16001989pjq.97.1633746033454; Fri, 08 Oct 2021 19:20:33 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:32 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 03/14] irqchip/irq-bcm7038-l1: Use irq_get_irq_data() Date: Fri, 8 Oct 2021 19:20:12 -0700 Message-Id: <20211009022023.3796472-4-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192034_756302_7673495D X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using irq_desc_get_irq_data(irq_to_desc()) to retrieve the irq_data structure from a virtual interrupt number is going to be problematic to make irq-bcm7038-l1 a module because irq_to_desc() is not exported, and there is no intent to export it to modules, see 64a1b95bb9fe ("genirq: Restrict export of irq_to_desc()"). Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index 750156217c82..14caf32dc23e 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -386,7 +386,7 @@ static int bcm7038_l1_map(struct irq_domain *d, unsigned int virq, irq_set_chip_and_handler(virq, &bcm7038_l1_irq_chip, handle_level_irq); irq_set_chip_data(virq, d->host_data); - irqd_set_single_target(irq_desc_get_irq_data(irq_to_desc(virq))); + irqd_set_single_target(irq_get_irq_data(virq)); return 0; } From patchwork Sat Oct 9 02:20:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F0AC433EF for ; Sat, 9 Oct 2021 03:10:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94E3C60FC1 for ; Sat, 9 Oct 2021 03:10:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94E3C60FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cbXc//a3QKMZb5S6hDJlArxbGE2QXmiK2nSjyVtT4AY=; b=b/a6qsP33a2fZn qTfl2B6bqPYl1rDTyFejhOJpXXPDz/5MXJX0M624larMVka5IJ+Uaic9WeAMTvybDUg1Pl3XMmt1N 1Nt4W9RIFBGw/ZpY5CGSPucy5YjVt2o2ZFz3aMyH4N9wHu68CTGFIw8q4NiTmWUie1itax8Gns3V6 o5QK+fEI5Wtt8Gzl9qXJn822OhZAzDgHqBqsNPd10TGAErV1MDQWuJzCZFi1HcPzm5MKJZHhIH9b0 hODEKTWJE9U/g8kT9o98LIEi3h/m6nhTNktHmKLUIEzRxCeIkP7Po/n0nAoWsjBcYVUfpXc2tggLy Xhfpw9tx9pOVt9OI2hnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2iq-004qBA-HN; Sat, 09 Oct 2021 03:08:29 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yW-004Xsn-G5 for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:37 +0000 Received: by mail-pl1-x629.google.com with SMTP id x8so7256592plv.8 for ; Fri, 08 Oct 2021 19:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G1RiT4GRKPcXSkOjyrks/jOWZL3DTQpMJtRhCsgVjY8=; b=bJ9KuSL5TgeWyqKaNO+GyL79xvaPjqlHFkgNvb4kUgxAmLsjpp8VRQ+Gx7VrYcypLZ abv3tPhR4NhdT1ba5/pktaJs0V2aQ0bulDU+3q7PxtU0kLZbKHktoBROaTbyBPqU56Ob 2KDuqvy30PtmXSomEAvNea3kdOxaoNSBnz3/JgNyxLRqBLvP45gpHGDPaL3+suQaP92s d1MlnJUTc5eAEd4YjTFmAu8icn5KR72wyfbVCe7FqXlqsz1h5uNZ1ltr06TL5JqShMqu AerdQraWSF2a+EwBXrgumcUlnzD9Mr4vtYumZkHIu79I4Ja4vwvjCyK27QonQzMqUe0N gyGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G1RiT4GRKPcXSkOjyrks/jOWZL3DTQpMJtRhCsgVjY8=; b=6qlBB9YlRFpw9wO4h9/LKUcZ+/oJI+cLaaimN2Qilbmicq/nG5RpAJizHk1iAnNg+N eLQ1jRjdzTJ7yJ1IDpTT6GiJtyvU6ia9mBKILo42yRgy5aZ8AMYB4VwYjuuaiuSM5vRi gKy6Xwpux160p7qZdXZQakPSsXBFZUsWeUFd733+sgCalnD7/bpVYbbStH5lUkA0CWC5 2/gbs3uacqRyFOI4+ACCgVIS/JVirDyZ0sYD/bFylzYjRE/Mijm8QVXIwHUYU3TUU05G fOlTm0d+YHZ6i8Y+MYgkl9oUZXuW6v8qv9+QVWJoO2zjWcDN7Yp/3rRE5yIeEbFnWQ+7 hH+Q== X-Gm-Message-State: AOAM533HAfI2Nxiytt/LOQLPqIC9ROWEI7b4GuL7DsRWB1igsJT67QUx rX3CjzQ4y9vudp3RrfPCwo4= X-Google-Smtp-Source: ABdhPJzt3cUT0qN+Y44kkLg1/73jsgwdfZQ+cXkdb/8YqpQ6audqUIfOzS1omAW67biNzXtaW92lFA== X-Received: by 2002:a17:90b:390d:: with SMTP id ob13mr15368899pjb.49.1633746035050; Fri, 08 Oct 2021 19:20:35 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:34 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 04/14] irqchip/irq-bcm7038-l1: Gate use of CPU logical map to MIPS Date: Fri, 8 Oct 2021 19:20:13 -0700 Message-Id: <20211009022023.3796472-5-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192036_609126_16A4E692 X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The use of the cpu_logical_map[] array is only relevant for MIPS based platform where this driver is used as a first level interrupt controller and contains multiple register groups to map with an associated CPU. On ARM/ARM64 based systems this interrupt controller is present and used as a second level interrupt controller hanging off the ARM GIC. That copy of the interrupt controller contains a single group, resulting in the intc->cpus[] array to be of size 1. Things happened to work in that case because we install that interrupt controller as a chained handler which does not allow it to be affine to any CPU but the boot CPU which happens to be 0, therefore we never de-reference past intc->cpus[] but with the current code in place, we do leave a chance of de-referencing the array past its bounds. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index 14caf32dc23e..3c4e348c661e 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -28,9 +28,6 @@ #include #include #include -#ifdef CONFIG_ARM -#include -#endif #define IRQS_PER_WORD 32 #define REG_BYTES_PER_IRQ_WORD (sizeof(u32) * 4) @@ -127,7 +124,7 @@ static void bcm7038_l1_irq_handle(struct irq_desc *desc) struct irq_chip *chip = irq_desc_get_chip(desc); unsigned int idx; -#ifdef CONFIG_SMP +#if defined(CONFIG_SMP) && defined(CONFIG_MIPS) cpu = intc->cpus[cpu_logical_map(smp_processor_id())]; #else cpu = intc->cpus[0]; @@ -301,7 +298,7 @@ static int bcm7038_l1_suspend(void) u32 val; /* Wakeup interrupt should only come from the boot cpu */ -#ifdef CONFIG_SMP +#if defined(CONFIG_SMP) && defined(CONFIG_MIPS) boot_cpu = cpu_logical_map(0); #else boot_cpu = 0; @@ -325,7 +322,7 @@ static void bcm7038_l1_resume(void) struct bcm7038_l1_chip *intc; int boot_cpu, word; -#ifdef CONFIG_SMP +#if defined(CONFIG_SMP) && defined(CONFIG_MIPS) boot_cpu = cpu_logical_map(0); #else boot_cpu = 0; From patchwork Sat Oct 9 02:20:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76572C433F5 for ; Sat, 9 Oct 2021 03:09:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3665B60FC1 for ; Sat, 9 Oct 2021 03:09:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3665B60FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uwYt1LbcutwbTHmo21nE6BAa4F3WOOaI7MOYHYOC3yU=; b=2ccyXAClKKGJd5 9FHg77/zmArceHsh3kvNxOHPX1rgPMzOvbf4JqZE2fJOrLbXUnI5/kTmu5606QQItkCtjiDI1jBAr 7d5vhdgRN+Eqkuf8hRF7BKt21mFgP4z44IPKHxW5opzah7ldG6Eqb2r6fzPCU6d1OWyocEqgRiyf9 lVe/VfU2MuoItgXAiRpOujqj7jAF4oOQAxVnyyOv6TBtGdnEVMpIXtcTZhoXs8GqlsUXgZzV4vTvM OuQGMYHizPnw+gkzdpbflJ5nQJqoDNYAZs+AJzK96jE1iDYh7TcEZeMZciuz5M4Y3FJP+Bjc9nLRw fkqlWZF5OW0L2iWXIMug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2hq-004pny-UC; Sat, 09 Oct 2021 03:07:28 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yY-004Xtx-44 for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:39 +0000 Received: by mail-pj1-x1033.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so9151922pjb.0 for ; Fri, 08 Oct 2021 19:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eUj8nxm+KdP0d5VfXzrEXZEp4lkprKHXeVwPIifh+Cg=; b=c3kSTNU5BJ5QJ8JFiLbKzy/A99Z9toAXdm8flW49HTdq+mK8b6A7ui+km1TYuw8W+N 5+vQc53uz6VTLSSGmQd3YezfNXwoErRNKVSe0OKKkNje2y9rvVwCQHfRFqiejMI91MWY 1ntrMG6PNrlUvm6tyTuQIPpftoTaATluQibOUCeOfx9gLuSQ7+lzSWvEaJFxHcpgYO5h We7BGG2kamEbC2Cg+uMSjwJoSd/CgEqTvCjM0FB5Gj/lBa4MEP/WKQd/L5ZmjLJt4/0t bh2DjPtu8X0s+rEjCTZcKOagnohQmQ6OSCa1fqKmZ0+QwBJE369PCCeoHqNlkl+comGp FEpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eUj8nxm+KdP0d5VfXzrEXZEp4lkprKHXeVwPIifh+Cg=; b=5cvYuTWdN9N/JVZRdq5Yqkkk/RgAYn7cJXo5JFlJFkRLHZshLiHVdbOvbio4qZHynl EsteNbxvrtz//6pfVw/kau9EzDEDvg+LZfCRW+kKHIrpRt0GbiyRJ4g5MbJIy/G+4oJK Rt5cBJfWyMUEdswHuepSRiS808WnpUtCGvh0y7x2xy5M2do4FGkvJUyPDFrW5MNkDcOc HRhavllbpU/+b0thpGJilvcPa1PqYgCJnN6utejI1vvlmb0F1J9GCgxOAeyDnl7NE7RW 6FxBgCc4O2x5fG/K/QjMB96C0guDk12JUdD/V2XMg/bZfeMLopLEQJEDS40O8bOPE5tA glmQ== X-Gm-Message-State: AOAM533a+UKB9pE4/gSYWuCSoC7olaQy3qGQCpiawZYYWNqLR92YRjAu D3UIzJw30Zbijk4g5OU51P4= X-Google-Smtp-Source: ABdhPJylbltqq722kc9cPzBDT4GPP7LV4CG7AB61SJI6JZWdbUgJzjWWOuuGBYhxg/9m938uUnCb/Q== X-Received: by 2002:a17:902:f691:b0:13f:2034:7613 with SMTP id l17-20020a170902f69100b0013f20347613mr2540590plg.81.1633746036946; Fri, 08 Oct 2021 19:20:36 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:36 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 05/14] irqchip/irq-bcm7038-l1: Restrict affinity setting to MIPS Date: Fri, 8 Oct 2021 19:20:14 -0700 Message-Id: <20211009022023.3796472-6-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192038_216858_BF4EBED9 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Only MIPS based platforms using this interrupt controller as first level interrupt controller can actually change the affinity of interrupts by re-programming the affinity mask of the interrupt controller and use another word group to have another CPU process the interrupt. When this interrupt is used as a second level interrupt controller on ARM/ARM64 there is no way to change the interrupt affinity. This fixes a NULL pointer de-reference while trying to change the affinity since there is only a single word group in that case, and we would have been overruning the intc->cpus[] array. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index 3c4e348c661e..357570dd8780 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -191,6 +191,7 @@ static void bcm7038_l1_mask(struct irq_data *d) raw_spin_unlock_irqrestore(&intc->lock, flags); } +#if defined(CONFIG_MIPS) && defined(CONFIG_SMP) static int bcm7038_l1_set_affinity(struct irq_data *d, const struct cpumask *dest, bool force) @@ -217,6 +218,7 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, return 0; } +#endif static int __init bcm7038_l1_init_one(struct device_node *dn, unsigned int idx, @@ -365,7 +367,9 @@ static struct irq_chip bcm7038_l1_irq_chip = { .name = "bcm7038-l1", .irq_mask = bcm7038_l1_mask, .irq_unmask = bcm7038_l1_unmask, +#if defined(CONFIG_SMP) && defined(CONFIG_MIPS) .irq_set_affinity = bcm7038_l1_set_affinity, +#endif #ifdef CONFIG_PM_SLEEP .irq_set_wake = bcm7038_l1_set_wake, #endif From patchwork Sat Oct 9 02:20:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 961F9C433EF for ; Sat, 9 Oct 2021 03:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C95460FC2 for ; Sat, 9 Oct 2021 03:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C95460FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qztGlhJMB9Km7Yp6PpvERY24qCHnd73E6qGjtptqDQw=; b=bt/pWJVZYqf9nW hePp0xFufpOYpVZLgDxb71Fx4Ierorixb+XpeXU6p4AZdYjTYkkBUn+PyWfWVwKlXMPvJYlFlVu+E t5BsUhldcJCkvKPSp7nqxoStA51i5jqb8M718p61wjsixE2MJbIC+kTan2Etti9+97wL8QQ4Ry7Bm KxxfSbnnmvv3AfGVPyguRtSJVoxW6DUQE1DTdLdBdmuT2eL9Xc8HCegjI6UWjQGtA3oifAX7XaZiJ Rp1kdwSW0t4lBWCihtor1IR/qS6UG5s7GccrX7DZzg91yVjeOI82ZUx3wW30fg2HbTqcg6V+5IYfy q8HLrMnA/yVxVe+lKuCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2jg-004qUl-HK; Sat, 09 Oct 2021 03:09:21 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1ya-004Xv5-2s for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:41 +0000 Received: by mail-pl1-x62d.google.com with SMTP id l6so7258603plh.9 for ; Fri, 08 Oct 2021 19:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IqTvFkxEB42F4FY7x5fTTUp3BY0gcheCImqFREsoxYU=; b=k0+o3REhJGZc03nzXzkRd9Oio+6a3BR7RuZnftlFNI6R3hc4lz/gKSB3aByCVzQ80n TKD8iHe7A8CRJHpTYEQtbXKKHFfSY/Jj7d6EhKesZAoiFgGQE+oMekunYBq0PaSRfKmZ NBt7Q1k+5ZbrIaJPhCARgjiLPcy+i2jIAH49h6z/zml6Afq7fQtEoFT+xzcxD4YrqdjG 9+pROqJT03lnLivwp6BfFiS3fnZI11xAwVJ8Z2LkUGnC3Q/OPSUYIoY5E68EXLgPlVl0 NpDvmj/XBJKUBTXAKusu+ZbXMP71NeHvf5Z3sZ8YpHcwuLxpvn1KKSVwT7TanuScHgWq gxHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IqTvFkxEB42F4FY7x5fTTUp3BY0gcheCImqFREsoxYU=; b=jsMxJIE2VLzTB2tZKYOwg8ak/qdQNuadQZ3WwHf6e5ylFhRMDw+EkQlQviyyKObBcs wbIt7QNAUOJqzqKSUYBpFVk/iU7OQjWI9Mij1Ia0t3Bu7XYfIEQX9w6H4BXvWPd6WGhs HBYafBIdjeRU/kyfqBj9lD5DFP/2QyQcIvMG8Lw0NcwVyn5ShJhk/LEetMGDBe5iM0AW i6ZGq5c7e+ZQLtKFZ+5WidJ28OvcWHtMVNQ15i73W2ZtRY0LVIMb1AmY4no3B041wzte KOup/wuLnOIIhMqyt9+XGur3tLn+LH1pdUY8DXH9iKcXLIqhm6LYd4Qc9DXB7BzcPbjJ jisA== X-Gm-Message-State: AOAM530AGN9/HfJ1FsnI9vb6QQwWF+UC7AR+sqsNdHN2+b+scCLePSfa JvSfsdwxRq2810VbN1G+A0A= X-Google-Smtp-Source: ABdhPJzf9Q1oZfg5pPn97RR5PTRl6yYlUHYfjjRwh0BfIT2/Gwm/ScNxwnrnOSDAYZ337GekmMQA4w== X-Received: by 2002:a17:902:6b0b:b0:13a:18bf:1ece with SMTP id o11-20020a1709026b0b00b0013a18bf1ecemr12351269plk.49.1633746038565; Fri, 08 Oct 2021 19:20:38 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:38 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 06/14] irqchip/irq-bcm7038-l1: Switch to IRQCHIP_PLATFORM_DRIVER Date: Fri, 8 Oct 2021 19:20:15 -0700 Message-Id: <20211009022023.3796472-7-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192040_169073_0E32ED84 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow the user selection and building of this interrupt controller driver as a module since it is used on ARM/ARM64 based systems as a second level interrupt controller hanging off the ARM GIC and is therefore loadable during boot. Signed-off-by: Florian Fainelli --- drivers/irqchip/Kconfig | 4 +++- drivers/irqchip/irq-bcm7038-l1.c | 6 +++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 4d5924e9f766..3022f6137096 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -115,7 +115,9 @@ config BCM6345_L1_IRQ select GENERIC_IRQ_EFFECTIVE_AFF_MASK config BCM7038_L1_IRQ - bool + tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver" + depends on ARCH_BRCMSTB || BMIPS_GENERIC + default ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN select GENERIC_IRQ_EFFECTIVE_AFF_MASK diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index 357570dd8780..a62b96237b82 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -455,4 +455,8 @@ static int __init bcm7038_l1_of_init(struct device_node *dn, return ret; } -IRQCHIP_DECLARE(bcm7038_l1, "brcm,bcm7038-l1-intc", bcm7038_l1_of_init); +IRQCHIP_PLATFORM_DRIVER_BEGIN(bcm7038_l1) +IRQCHIP_MATCH("brcm,bcm7038-l1-intc", bcm7038_l1_of_init) +IRQCHIP_PLATFORM_DRIVER_END(bcm7038_l1) +MODULE_DESCRIPTION("Broadcom STB 7038-style L1/L2 interrupt controller"); +MODULE_LICENSE("GPL v2"); From patchwork Sat Oct 9 02:20:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547269 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD05DC433EF for ; Sat, 9 Oct 2021 03:13:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A838560F38 for ; Sat, 9 Oct 2021 03:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A838560F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zp0p34aRBR+FtXcEY33TrVNXmBrkAw1zRoraIIipP3w=; b=4SwDwFkFFTEayy MswvjFB3448XGbgORenBl3NJ+8rZgpri0mAgPKC84E+wTydFVCwx9hpUd/D0XEaYpk26wK4td4oox p4+X9KnAZeDciKfW6fCa/9J2bHRhHmrOWFZZBikFUrYMTn6684jmfckgG3eghA8rX8oeUcYDqXoCp 3J4GZekPxvaLDxGWw7/5WWHZYn+SA84koJNs8i3AnXQb+tJe5m+aOa5LiBhvFzLhQYMd2AB0sgmvb OL3DCYSKyn8lqUoyYljUK0kcwcaERwqnpgfSfGmG8ejmcMp04vb8rG+KSbC8yJD9h4s2o2bs6a5gv 8oiF5cZ+Fzv5R635fouA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2lY-004rFP-He; Sat, 09 Oct 2021 03:11:19 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yc-004Xw7-6T for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:43 +0000 Received: by mail-pj1-x1029.google.com with SMTP id ls14-20020a17090b350e00b001a00e2251c8so9089995pjb.4 for ; Fri, 08 Oct 2021 19:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cLaNe7Oyl1seZD/HRHq9xGsMnTdlxwayLK+zY+0ZWyA=; b=gLZsVmimLpwdtSBi4C9L0jfoIeRjzgLq1tNByCwcf/Pgmt8XK6gt3GE25RbSb+aujd 1RAq+b0Cw56Hdb1CUCjtznchKAhDAGNN03iTmuRHXbhl0D1+RdUSFuFSyGXYg7DE+yJi Y5fkROAfSMIrAQW5gNYVpmMUoSanPPLDit+e/S/uJb8Zzp6TfxlDVPokMfEdT0RhOZ7y VhjTy2oTMuYqM+CDyQJDhw7r6RoKw+CQ1wnOo5B97k/91L2kgIfMN0H6iNQSv2qCGLqj G5x5eVnUNOEe/g+WWD+mYhM++op2NIVQd57wlQxOIFafjFFZhLD1cO/ocjfibA2RvSat PWbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cLaNe7Oyl1seZD/HRHq9xGsMnTdlxwayLK+zY+0ZWyA=; b=TBgtdU0g6dtW8XZTGPuWBKCYzBHInoumhE7BcegLkdNMLT2g4dY0+rvHIch1RCmpRd Q011Z2OTxbpzwUJT3RHenqLNF535VqGYcfTaTa+pV160uHpmEgNuhFafRxW8wgF0RwyC jyLb6t4qsDfM7yb7tk78g/djYx+W6ZT+97cuV3vHEQI3UtCelnjYjxc2yG5ZUX/Vnrx1 iY58PHUy1FKC9G9fPSsHAVBAzPLki0q/XqZ+XRwztaL6x41J86cdbgh2zGhqKwcwdl5I rgTAi4wNaDoLRYJWOWO0V5rwrPQ3fAbEb0PQywjFios+wh5pJMAu8iRsNq1Kk/J0x/p9 5jAA== X-Gm-Message-State: AOAM532aSKXV8PVFvMvmZf0Kt4JYFJs0wWEwsg6gKPRTsQlrG94fhixw uFAczUn+1r7MuHOeqGDOoKU= X-Google-Smtp-Source: ABdhPJz9L3vfDpAsutWUnZSpQUlLafnW1o2LTEFqy0TfbDnkzKBU2FxszoAr1cMPr3hzm1B9TszXCQ== X-Received: by 2002:a17:903:1ca:b0:13e:f367:9361 with SMTP id e10-20020a17090301ca00b0013ef3679361mr12635742plh.3.1633746040278; Fri, 08 Oct 2021 19:20:40 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:39 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 07/14] genirq: Export irq_gc_{unmask_enable, mask_disable}_reg Date: Fri, 8 Oct 2021 19:20:16 -0700 Message-Id: <20211009022023.3796472-8-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192042_277455_A452CD36 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In order to allow drivers/irqchip/irq-brcmstb-l2.c to be built as a module we need to export: irq_gc_unmask_enable_reg() and irq_gc_mask_disable_reg(). Signed-off-by: Florian Fainelli --- kernel/irq/generic-chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c index cc7cdd26e23e..4c011c21bb1a 100644 --- a/kernel/irq/generic-chip.c +++ b/kernel/irq/generic-chip.c @@ -44,6 +44,7 @@ void irq_gc_mask_disable_reg(struct irq_data *d) *ct->mask_cache &= ~mask; irq_gc_unlock(gc); } +EXPORT_SYMBOL_GPL(irq_gc_mask_disable_reg); /** * irq_gc_mask_set_bit - Mask chip via setting bit in mask register @@ -103,6 +104,7 @@ void irq_gc_unmask_enable_reg(struct irq_data *d) *ct->mask_cache |= mask; irq_gc_unlock(gc); } +EXPORT_SYMBOL_GPL(irq_gc_unmask_enable_reg); /** * irq_gc_ack_set_bit - Ack pending interrupt via setting bit From patchwork Sat Oct 9 02:20:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A70CC433F5 for ; Sat, 9 Oct 2021 03:12:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05A7760F38 for ; Sat, 9 Oct 2021 03:12:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 05A7760F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3qnRbArCl4gqMMKVot0gFktSVXCRf53Q+4rvw7V2aZo=; b=f6exsRs/FDng4Z eDp3s3LidPSlTEmT32toc5TsFxkxoNMxTb4lu+U5Wtt2N9KE6T/xoQZ269bPHajxWA4Z1PkM37y6F ylgBV25qRyMFB7RfdiVmTguZCIQplBouvkl5XFx8ds9RZfPdTjBD9775LX5zfdIwzgaGMOot+ZTVr GeFgF83VJdPONFUQtEamG4oWbeQw3ZSVVroCa97M6YpvHbvw8PGswMKPnoEdmx1RZ/P+FXpdHcJT1 2LeNBIHWwL7E58iAP9pWgnORpzNBqYMa2+GrdHYyzGxN8MXwtKelHD504MFVCy+fAKkCmKljpfxhw dAg0XvqSPJC7AwSY+xAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2kf-004qte-GU; Sat, 09 Oct 2021 03:10:22 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yd-004Xx9-4j for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:44 +0000 Received: by mail-pg1-x531.google.com with SMTP id s11so4789106pgr.11 for ; Fri, 08 Oct 2021 19:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9fJWAIDZMBnqyaJKloz+swm+vHzzjwQ8q/tXjCn73F0=; b=SzJB32ERexKcnc4C4x9hDpIfy0O4VItzue50HM4cKKD5Gadnyhf8uXegzSTrezL3Z7 XowA8CHweVmv5m4Lpu733cs506OqQyJSJzoKvxwelE2U4MrGUPeeOdOohNLpBqxWvUNj 90DHq8ceh0Uf2xf75KOWmPj4v7vt99MSjLsaKeaZncTaVLBrjAEfCYGCjegNC1IgcFto HyFUYoN/UJ8oJ61ToBbsmg48ayMjbmkcbS7RcREaRMKZM5lb6us/cTw8AxtcqAfVE2kl oWGa8fNcIrx4+Q0TBt055dUHyTX+CaRPufbLStJBcNF/jesBGKJBeY/Wl0ac/23bTkwU XwTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9fJWAIDZMBnqyaJKloz+swm+vHzzjwQ8q/tXjCn73F0=; b=T5iW7f/aDzLKaxarK0nYG0O0ZLPidQbQ35djHO8P7fDpOBqGqurl5Zp+IphQrLO2nF 88GWMzTR6xTnHFjFx5qyap4RzdE3fOMZnIbJUTaAK8f7MMGcDuhuU1Qj8f1epPE/iEqB mObFqz9952Q2SBwBQxlc6SDZcS0KsV7TEhed2AD7JW28HB7ZowYn4Q48FhkkisE/JZQF 9GB9IatRBaBXEz4yQiElGXbXwfvMztHk30bW8/UHi/6M/5iVFS0FvA4nQVF3VlCUgzCx HsvKzSH7ovbi6aFBH0lJmJcKfX1bndk8NMaV7MJ+UZD7CTZRE4VahVSYFIGDwtq7aSqo EAQg== X-Gm-Message-State: AOAM531rbKymfvbRplpSUIe+AtpVLQla2CrZ22CUPQj/gyvXchhKoa5B W5Z37N5HdYGg17qQ1ueowZI= X-Google-Smtp-Source: ABdhPJzXy+7f0es9EghURGg8TvHh1mVwIe6bucOdCVqh1OIUwlGNbp2R3VsYxzh1zfze0kMlkdhPIA== X-Received: by 2002:a63:ed4f:: with SMTP id m15mr7567625pgk.471.1633746041911; Fri, 08 Oct 2021 19:20:41 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:41 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 08/14] irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER Date: Fri, 8 Oct 2021 19:20:17 -0700 Message-Id: <20211009022023.3796472-9-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192043_246976_2018AF53 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow the user selection and building of this interrupt controller driver as a module since it is used on ARM/ARM64 based systems as a second level interrupt controller hanging off the ARM GIC and is therefore loadable during boot. Signed-off-by: Florian Fainelli --- drivers/irqchip/Kconfig | 4 +++- drivers/irqchip/irq-brcmstb-l2.c | 16 +++++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 3022f6137096..dfe54bf9b35f 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -128,7 +128,9 @@ config BCM7120_L2_IRQ select IRQ_DOMAIN config BRCMSTB_L2_IRQ - bool + tristate "Broadcom STB generic L2 interrupt controller driver" + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC + default ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index 8e0911561f2d..e4efc08ac594 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -275,16 +275,18 @@ static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np, { return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init); } -IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init); -IRQCHIP_DECLARE(brcmstb_hif_spi_l2_intc, "brcm,hif-spi-l2-intc", - brcmstb_l2_edge_intc_of_init); -IRQCHIP_DECLARE(brcmstb_upg_aux_aon_l2_intc, "brcm,upg-aux-aon-l2-intc", - brcmstb_l2_edge_intc_of_init); static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np, struct device_node *parent) { return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init); } -IRQCHIP_DECLARE(bcm7271_l2_intc, "brcm,bcm7271-l2-intc", - brcmstb_l2_lvl_intc_of_init); + +IRQCHIP_PLATFORM_DRIVER_BEGIN(brcmstb_l2) +IRQCHIP_MATCH("brcm,l2-intc", brcmstb_l2_edge_intc_of_init) +IRQCHIP_MATCH("brcm,hif-spi-l2-intc", brcmstb_l2_edge_intc_of_init) +IRQCHIP_MATCH("brcm,upg-aux-aon-l2-intc", brcmstb_l2_edge_intc_of_init) +IRQCHIP_MATCH("brcm,bcm7271-l2-intc", brcmstb_l2_lvl_intc_of_init) +IRQCHIP_PLATFORM_DRIVER_END(brcmstb_l2) +MODULE_DESCRIPTION("Broadcom STB generic L2 interrupt controller"); +MODULE_LICENSE("GPL v2"); From patchwork Sat Oct 9 02:20:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A85FC433EF for ; Sat, 9 Oct 2021 03:15:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E235760FC2 for ; Sat, 9 Oct 2021 03:15:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E235760FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UGB1O4i99J9EkRC75hTxBJ/n+neyFDOGlpEOFNcIrz0=; b=S6ByknsZ/GGEp6 0ouO48+aiuxP6mMAP8JStqYJtytJdSBnnASnPHNW1GgCsES8dR1KOPQHSLV+8gCiNeKGwbkjdWZyz LjcBYBZHZK47ijjlzKlleeLgYm/TXELRYhX2TZz72ofAiuJ6JfJL6TBoUn7WALV42Umkn36ecewc3 0HDqb502Vertv/B1POUJXBsmpHh4EjeKPj3W+j15fxFQ+B7PyQ6HqNlZGe6MBmzE1O2HYjNzy8XrI fGCtq2L/0010cdaUT4LXW55H2G2gxUm58cpMabrSo/JIVrkACBPXBFhhEmr52RGJK+P2fsDNtoc0x gkBGk2NBWry5WvBb69iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2nV-004s12-Ut; Sat, 09 Oct 2021 03:13:19 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yf-004Xy2-BR for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:46 +0000 Received: by mail-pl1-x633.google.com with SMTP id k8so1850336pls.3 for ; Fri, 08 Oct 2021 19:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dv8ie/kzP99OSKx2zPfoLqRlI0izEadzKVnoX+2n0Ow=; b=XmVZQ8ecVe8ssNoW3ri/l0xaim8HSgzUF8wAV4y3HLNJpdveIMz6JlwIUVyEiWgj4R vr5X0u6sk9Ca5Pdw8C2ckmHkm7tibgMWWAyshNNen99epCOx6IOsEbbTa8+mOPrxucl3 F4YxOKSlw0G1DTsjnFtxO3exNW2jwZcpe8otVI6WAtvF75bryFrdxpZSI6lhiuL/aYzT ZnQbqJOogyH8DTx4Yg2JW0vqrn+jkoV+YPOnUcLEteYbAJAaIyahNwX/ZTGs14GLPE2p I0t73KD1eIZAGOLNopwuBzjzneID8YRilac4sz4oe9MNBQ8AA/ljepB4ytxjTREo432T JoiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dv8ie/kzP99OSKx2zPfoLqRlI0izEadzKVnoX+2n0Ow=; b=EaVe9oHweppA3rbyg3gZm9yelZvnKnMIvH023ukNIpOyGgjp832vq1rfIxLCNLfJ6e +GaggMwhTHnQbRp8Yq1W/izZ+H37RuMK4WHr8bvlLRqbw5NZHFrVJEQfV7CKoiHI2fBz VWAMjGeIiND9+kEFDEvwXCa8STPNkKwyrLKpo2wmByUCUrK3CXagwMqrm+jKp+XVtN5i or7mqhOuwZnsp4Y/lJ9RlUod3Hhcz1dNJIZ2QH+MLr/qXyciFUPV5hE0W7xPojP4qt0l CRAue1MPJFqqNtiLSl1PpJnxfEW+4BaI0Q66RVScrdyo77fxUN5unJjVaImRoR6fV0Ae HSfw== X-Gm-Message-State: AOAM533NMF/SQbJcPqGwzQTFJRw6qYUxE1XaD60mwfdWM5qwrUYOc3aq BFfIAgS5xrczIlBPSZhbPc4= X-Google-Smtp-Source: ABdhPJzF3gI7qfa3LWqIKHoJ03LLsWPTSCV4u1fVS3qzFGwkcYas6/EtejS42d9w4UMRoGhUfYAlzw== X-Received: by 2002:a17:90b:1d0d:: with SMTP id on13mr15716331pjb.118.1633746043559; Fri, 08 Oct 2021 19:20:43 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:43 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 09/14] irqchip: Provide platform_device to of_irq_init_cb_t Date: Fri, 8 Oct 2021 19:20:18 -0700 Message-Id: <20211009022023.3796472-10-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192045_432772_5BA7FBB9 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Provide the platform device mapping to the interrupt controller node to the of_irq_init_cb_t callback such that drivers can make use of it. Reviewed-by: Rob Herring Signed-off-by: Florian Fainelli --- drivers/irqchip/irqchip.c | 2 +- drivers/irqchip/qcom-pdc.c | 3 ++- drivers/of/irq.c | 2 +- include/linux/of_irq.h | 5 ++++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c index 3570f0a588c4..289784eefd00 100644 --- a/drivers/irqchip/irqchip.c +++ b/drivers/irqchip/irqchip.c @@ -55,6 +55,6 @@ int platform_irqchip_probe(struct platform_device *pdev) if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY)) return -EPROBE_DEFER; - return irq_init_cb(np, par_np); + return irq_init_cb(np, par_np, pdev); } EXPORT_SYMBOL_GPL(platform_irqchip_probe); diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index 173e6520e06e..819a93360b96 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -359,7 +359,8 @@ static int pdc_setup_pin_mapping(struct device_node *np) return 0; } -static int qcom_pdc_init(struct device_node *node, struct device_node *parent) +static int qcom_pdc_init(struct device_node *node, struct device_node *parent, + struct platform_device *pdev) { struct irq_domain *parent_domain, *pdc_domain, *pdc_gpio_domain; int ret; diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 352e14b007e7..18f3f5c00c87 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -538,7 +538,7 @@ void __init of_irq_init(const struct of_device_id *matches) desc->dev, desc->dev, desc->interrupt_parent); ret = desc->irq_init_cb(desc->dev, - desc->interrupt_parent); + desc->interrupt_parent, NULL); if (ret) { of_node_clear_flag(desc->dev, OF_POPULATED); kfree(desc); diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h index aaf219bd0354..89acc8b089f0 100644 --- a/include/linux/of_irq.h +++ b/include/linux/of_irq.h @@ -9,7 +9,10 @@ #include #include -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); +struct platform_device; + +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *, + struct platform_device *); /* * Workarounds only applied to 32bit powermac machines From patchwork Sat Oct 9 02:20:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A46C433F5 for ; Sat, 9 Oct 2021 03:14:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94B2C60FC2 for ; Sat, 9 Oct 2021 03:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94B2C60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IVcA6d0LEGX9QAguQ3JTJJAQ3jpS8RGXOJZxcRXOqT0=; b=cp+W+c8ymR5v9r h+Cm2cz8tuy4qPlXFTetsV9DzoFg5rM4EJGwHBS7xX4cjri+pbJyRU5Y9DNrH5Ma+IOGVUhcnfETF wTMyAGXbquvklk0mQZGirTjciCdd242Ygz8dBMQYf2sUWJcy4edf2ViRtzXgvCGmuDIJdYIbI5vNI HHQDC3ZVnRPYVrC6YuZSLro367GIvAHI6Bgw0gxVkasF4GVFBhti8xYNYCs2IagTB6+Zjqzc4G1vP b8NQaaKaY4hJIPf2CCC7/8F9smOTLNPfyKgg5pFll3LnhJJdGtpnJO3dvoxblb08mo/+0HuTivXSl gVWWTlaYGvylivLDVR9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2mU-004rbF-Mw; Sat, 09 Oct 2021 03:12:15 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yg-004Xz3-EV for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:47 +0000 Received: by mail-pg1-x535.google.com with SMTP id a73so4860651pge.0 for ; Fri, 08 Oct 2021 19:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HFON70fhXDszaD5v9yYPo/8gY6ecjeQthvGng5DXIkI=; b=ausIkCFGPbENw4fedQTfZPBRbHku2qqNzrF2dJaGXzJy/KWRfzy1m5YE3L4MIOQ8Ly inkTJv1ZYWR6QHIu01MeDGWQvHn831m8ZoEiKPbZy8nzBXC0Z7ImNduozSOBX0WrWB+V d5bG0dSAoBkEQhlW8aEdkJOpw4+g3FKlTrP6ONLjtQd5/maQuirUVJgiIL81QktZFU1M XlYC2/ET4kZFIl6YO3vvRNJauJAWS/3VUwoRIl8QIUGOTQv/okMNZpxSUP+Nbe0Agl+M 4o+6gGnwiPxQc7M4KlIsIkGC218ChGodQZTCqSQdvjY2tLsSumL74wDaQyDC+D0xMJLv 5U7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HFON70fhXDszaD5v9yYPo/8gY6ecjeQthvGng5DXIkI=; b=m+b5JD/ClExE9VuFpzRXeWxYExYAdjEKVmp82RPuJjNGNEAo6s6zKr7DkP+kdx+ioF 3Y+T/Z3uKwH3VrGpDg8iR+V7Rwrl8yTIJuF6QCAnlXQMLrCydL1nwUM/bjFBp5Zqlu8r etpeKXhKNA6GRw8Oz857PbZKzalvXcWBYMcB1+AAo22KsNDb6wg36wC5Eh12ECK16FcM 0At8LzU06+/E8WCW3WiPXjQ+8JRk34t2JI0DsRepYa5q7yQew2rLycg17LUMDNr/bzzM VhoITGUQqfr7AoLDGn+zd1bjGNp29hDUz9ZwVi9+mVMhJ9L+cNWt9XH2/I/J3XrT3tGw famQ== X-Gm-Message-State: AOAM533nuCKtBLuMk03p9JUYbKSoMhUqLjAD68D6pz3TdTHkdGtMD7in DySUfiayDR+3dgm8V08pCrc= X-Google-Smtp-Source: ABdhPJzvROA2sOizAdWSh8eS2axz46xfjaBZ2sui7arqkGPAV1Aqc0JHKkBn+v1NulMnuGscFyLqfg== X-Received: by 2002:a63:470b:: with SMTP id u11mr7494988pga.441.1633746045144; Fri, 08 Oct 2021 19:20:45 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:44 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 10/14] genirq: Export irq_gc_noop() Date: Fri, 8 Oct 2021 19:20:19 -0700 Message-Id: <20211009022023.3796472-11-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192046_542532_179F1337 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In order to build drivers/irqchip/irq-bcm7120-l2.c as a module which references irq_gc_noop(), we need to export it towards modules. Signed-off-by: Florian Fainelli --- kernel/irq/generic-chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c index 4c011c21bb1a..6f29bf4c8515 100644 --- a/kernel/irq/generic-chip.c +++ b/kernel/irq/generic-chip.c @@ -25,6 +25,7 @@ static DEFINE_RAW_SPINLOCK(gc_lock); void irq_gc_noop(struct irq_data *d) { } +EXPORT_SYMBOL_GPL(irq_gc_noop); /** * irq_gc_mask_disable_reg - Mask chip via disable register From patchwork Sat Oct 9 02:20:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99F6C433EF for ; Sat, 9 Oct 2021 03:16:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A48A60FC2 for ; Sat, 9 Oct 2021 03:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A48A60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Mit3rxaLxBibsUkuwdhvLpDPKmT8un7Ku31iGk+h24=; b=MrinPRezLN8jkY E5GLi18xB/fvkgi/5TIxHgfmMjeUujaOqvyp3qg7Gs/Nk8HvH5+qyVyvKFTX6+eDMfNLkTjpXaf52 FYKADwFhzuIW/nZwDlqUHxuZywaC8ZTrCEwyvYxqAww5RLxCp8HBjF7iGGXQ1uYTxu+S682c9PV+Y yS/zN5YOpoOzJ0HDLbPt+wiAMXtwK51YwnsM1ydMqBRu4U+sfZkDGn3cgzGIv+SQuQ0NwXouV49gt NsYWY52MT61S1QIQM8xaVNZvh4bCd4aoiqkj29MeqP4a9cqVYCtRoXbXmkvZjuzq7gn8Uf5wHYBME MT95ze/gJNPo72ZSltcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2oL-004sHb-KC; Sat, 09 Oct 2021 03:14:11 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yi-004Y0G-Lf for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:50 +0000 Received: by mail-pf1-x42b.google.com with SMTP id y7so93297pfg.8 for ; Fri, 08 Oct 2021 19:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T+nuZjtMi8lifdnlhi4/+fNb2Wj4qKRZZKIw/UMDjOI=; b=PpcBimyin5Ej1RL/hbX3YfaP6uvHOyuQ2APIZRjh0TYg8b9xfHmJ8kfayiYH9Flg63 C8tARaCoaqfNSTDQZEJcIyIQaQ/dxi0ZJPrVb4VixDeZKZp4JZJXgHx/yfxlOFU/jQtC IjTZ1eWvfqla518XdNlLtUvwPz1JjOfECdUgQb/QePJ1fqRTnxkL4WcznbFZYj1EfteW 6pJgcbIPSD5PZGJ243SNzsWTiriLB11+XXHgQeABobg11Ln5ocON54nVzzMK1nLhVeJc orShxsK9PZH0LsGZHATZ9cZ0bBIrDcNf4LOkaaicBLD8jNxzTmZNxNnmDL/vp3FWirdp BEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T+nuZjtMi8lifdnlhi4/+fNb2Wj4qKRZZKIw/UMDjOI=; b=0vuJwqMXYK7BbAt8MSXb56X6RjOibzC8Izcjs2AcqOKSAPQPCS5cDV0a0o4Yhu/Skx S8QI12uSx/xdRP1YhIoCoxMFYimvK5kjJEW0dnCIzQ+GEp10XOU6j2R+8mqvsoiqG9l0 upUi0hUfMuF+7rT1oURgy+51bQih1xC5D+5uC/Gs1l3MXu+yIYfU5USbLOrErvwD7kLa NB9QmvOJWwH0uW6NI8gCy/MJE05hn69i8/2Q9l/HIvkQuj4/Ksy2rtNPg7u7OKVVxTDL E31b1nnzCGt8mG9IbjthlP7PkkndKErG1mumFCRCgh5AuL8hgeK5b34WahyUDK6PcxEF HnSw== X-Gm-Message-State: AOAM533YQ7UNPVvYb0tbZU1AjcCWQ7155eBNxO6OhZBo2RZyCR8V4ITy 3VzK3BLrk13J9GjCXZHK8HU= X-Google-Smtp-Source: ABdhPJzyNux7TjxdeK/+G14//P/gTbXH1+cv4k91jYMW0VDllt/pYAjrkv2fXLEl/cUoMu0W93Q0Tg== X-Received: by 2002:a63:4717:: with SMTP id u23mr7514059pga.359.1633746047052; Fri, 08 Oct 2021 19:20:47 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:46 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 11/14] irqchip/irq-bcm7120-l2: Switch to IRQCHIP_PLATFORM_DRIVER Date: Fri, 8 Oct 2021 19:20:20 -0700 Message-Id: <20211009022023.3796472-12-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192048_757473_E5A0C7DE X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow the user selection and building of this interrupt controller driver as a module since it is used on ARM/ARM64 based systems as a second level interrupt controller hanging off the ARM GIC and is therefore loadable during boot. To avoid using of_irq_count() which is not exported towards module, switch the driver to use the platform_device provided by the irqchip platform driver code and resolve the number of interrupts using platform_irq_count(). Signed-off-by: Florian Fainelli --- drivers/irqchip/Kconfig | 4 +++- drivers/irqchip/irq-bcm7120-l2.c | 28 ++++++++++++++++------------ 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index dfe54bf9b35f..c7320bed5668 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -123,7 +123,9 @@ config BCM7038_L1_IRQ select GENERIC_IRQ_EFFECTIVE_AFF_MASK config BCM7120_L2_IRQ - bool + tristate "Broadcom STB 7120-style L2 interrupt controller driver" + depends on ARCH_BRCMSTB || BMIPS_GENERIC + default ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c index f23d7651ea84..9b1edf7747fd 100644 --- a/drivers/irqchip/irq-bcm7120-l2.c +++ b/drivers/irqchip/irq-bcm7120-l2.c @@ -214,6 +214,7 @@ static int __init bcm7120_l2_intc_iomap_3380(struct device_node *dn, static int __init bcm7120_l2_intc_probe(struct device_node *dn, struct device_node *parent, + struct platform_device *pdev, int (*iomap_regs_fn)(struct device_node *, struct bcm7120_l2_intc_data *), const char *intc_name) @@ -230,7 +231,7 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn, if (!data) return -ENOMEM; - data->num_parent_irqs = of_irq_count(dn); + data->num_parent_irqs = platform_irq_count(pdev); if (data->num_parent_irqs <= 0) { pr_err("invalid number of parent interrupts\n"); ret = -ENOMEM; @@ -334,21 +335,24 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn, } static int __init bcm7120_l2_intc_probe_7120(struct device_node *dn, - struct device_node *parent) + struct device_node *parent, + struct platform_device *pdev) { - return bcm7120_l2_intc_probe(dn, parent, bcm7120_l2_intc_iomap_7120, - "BCM7120 L2"); + return bcm7120_l2_intc_probe(dn, parent, pdev, + bcm7120_l2_intc_iomap_7120, "BCM7120 L2"); } static int __init bcm7120_l2_intc_probe_3380(struct device_node *dn, - struct device_node *parent) + struct device_node *parent, + struct platform_device *pdev) { - return bcm7120_l2_intc_probe(dn, parent, bcm7120_l2_intc_iomap_3380, - "BCM3380 L2"); + return bcm7120_l2_intc_probe(dn, parent, pdev, + bcm7120_l2_intc_iomap_3380, "BCM3380 L2"); } -IRQCHIP_DECLARE(bcm7120_l2_intc, "brcm,bcm7120-l2-intc", - bcm7120_l2_intc_probe_7120); - -IRQCHIP_DECLARE(bcm3380_l2_intc, "brcm,bcm3380-l2-intc", - bcm7120_l2_intc_probe_3380); +IRQCHIP_PLATFORM_DRIVER_BEGIN(bcm7120_l2) +IRQCHIP_MATCH("brcm,bcm7120-l2-intc", bcm7120_l2_intc_probe_7120) +IRQCHIP_MATCH("brcm,bcm3380-l2-intc", bcm7120_l2_intc_probe_3380) +IRQCHIP_PLATFORM_DRIVER_END(bcm7120_l2) +MODULE_DESCRIPTION("Broadcom STB 7120-style L2 interrupt controller driver"); +MODULE_LICENSE("GPL v2"); From patchwork Sat Oct 9 02:20:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C945DC433EF for ; Sat, 9 Oct 2021 03:18:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95D5160FC2 for ; Sat, 9 Oct 2021 03:18:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95D5160FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LY4Q00sZLX3QRTvo/lwIuTenkMggTQmiDELEy4+X+/4=; b=gf3s8iZ2MiVVwg o/OCd2oC8v5LZWtVxJ3AjwHzlsZuOkjvl2aWWOgzPgRFKqbHWV58OxuBVpflN8Pt1DtqUV+cwRcL8 zbh2CdTA9WY0Yu5ScU3p8PN269DecItICMs0H/yjolcTa1k8UER2twWZr3F6traymaJ8C4XfVjyJa O7s8lieGf/1WYASgnmx6u3HIfn2uwhGqQz+Wfo142f+pQCC92ZAoF6xQB++eKa52xEjkZDpY9LbRT wbJmi+HLpmJrvI1DZx/4B+qz60jGsZhvwqtJnUe+BMul31Hf45NmuubAxbyTFHMvcq8NAFbjyjEkZ Asaq4fIMH+924Zi5HoaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2qJ-004t1K-5Q; Sat, 09 Oct 2021 03:16:11 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yo-004Y3B-Hs for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:56 +0000 Received: by mail-pl1-x635.google.com with SMTP id x4so7305169pln.5 for ; Fri, 08 Oct 2021 19:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ALk99V/yV50Q7B1PyIb1+nfNEsL1ZZBgIrsEIIgD/g=; b=hwzgru1aZMAwfrvVGh2qdKu+NGHgUvHLDHdM3vQvgCU6/2UOJCtSZXDCaYHNkc7V4R QT0uCUn/oPzdmxKJ0a9QqIDSFtIq1ztTmQo61VZLUadSm8fgP8xS8Dp8s2JLkUAO4Cs8 3GTSxvgHBsyqzTAiGeqsPA7JpngNisT9lz2L6ST+U3bxN6blPYNbr6ggPt+iypJgcASx Xvayj6OzIYId5Geaq2cRJ2ZhrRMrkE7Twtkpf1VJMfDcqEbzmqkhb9qj3kNCJfVmmwqN n6miuCaYiJohks8Vgjus/az9ok3SvoIfn7V1gbLS+mmu75KgCYg7Satzf5blrxX22hfS pVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ALk99V/yV50Q7B1PyIb1+nfNEsL1ZZBgIrsEIIgD/g=; b=uv78dAyLBro/Tr0Sb/QLnxRxGga/y4PoL0UWhOiDBg659iQhagod7OdxoQmWd5kca6 GzPdfFUJjfojzd4D0fvcMhiOd9jVZOV9mAigWAX0gGS6JQD/VGEP2P1exlq6Hbp66kGO 7z/M7KX3U6sxlhFQZkA/5SFymMl7SAfRHVgWdCKKf+sswBgHaEc9/mvw+PL1a1M3N2W7 QHU7pdOSGXLc01fmKGgy7XSmZqSSxIcuj2NXps6MQQIg/hyT4JPSeULkV6oEPQvrH4so mNrgiYo1xSdnVUUsOOcNK31K/tQinALz04uCY6FSLB1KZG+rfLq2gjANwbX411zm7Qjw hGvw== X-Gm-Message-State: AOAM532J+S/7gLpl4+7QAcnVKdVpN2G099KUDp0VhbhMAEVFcsIAui3e Q73eoG3quLxBQChCdWMY7bQ= X-Google-Smtp-Source: ABdhPJx46q70MQN9RfNnUCvx1o4/5BP6Zn3gnlrWX1/ENSBxwfbhZqwBEZHKsgKnnTa8dDDQJ4CSlg== X-Received: by 2002:a17:90a:39c5:: with SMTP id k5mr16170324pjf.211.1633746048546; Fri, 08 Oct 2021 19:20:48 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:48 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 12/14] arm64: broadcom: Removed forced select of interrupt controllers Date: Fri, 8 Oct 2021 19:20:21 -0700 Message-Id: <20211009022023.3796472-13-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192054_634147_8B917492 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that the various second level interrupt controllers have been moved to IRQCHIP_PLATFORM_DRIVER and they do default to ARCH_BRCMSTB and ARCH_BCM2835 where relevant, remove their forced selection from the machine entry to allow an user to build them as modules. Signed-off-by: Florian Fainelli --- arch/arm64/Kconfig.platforms | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index b0ce18d4cc98..2e9440f2da22 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -44,7 +44,6 @@ config ARCH_BCM2835 select ARM_AMBA select ARM_GIC select ARM_TIMER_SP804 - select BRCMSTB_L2_IRQ help This enables support for the Broadcom BCM2837 and BCM2711 SoC. These SoCs are used in the Raspberry Pi 3 and 4 devices. @@ -82,8 +81,6 @@ config ARCH_BITMAIN config ARCH_BRCMSTB bool "Broadcom Set-Top-Box SoCs" select ARCH_HAS_RESET_CONTROLLER - select BCM7038_L1_IRQ - select BRCMSTB_L2_IRQ select GENERIC_IRQ_CHIP select PINCTRL help From patchwork Sat Oct 9 02:20:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A473C433F5 for ; Sat, 9 Oct 2021 03:19:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 365E360FC2 for ; Sat, 9 Oct 2021 03:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 365E360FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IjtZu2/XIwIRVQMS5fIHdj8UCLdos7xLH5lYbfZ9fJA=; b=L/Wo4GjE24edu0 09N+uIeqgzps8VF+ypXK7qJCTn79RJuwy172n2b2IOf1H4K/mw5/5h9qMe1eDhXhYlZseBI8MhCDL /9hOLvle/FzR0tZp5dWpG6FV/dsVkgsQieuJzR4RKckqYXAAX3Qdk87frjttQQmhsssSxz9qMpulK V87YX+ot7SqnfsUzRQA0F/Yf8KbdII7Dj8WHg727oiQU2t1YQ/F3rbd56ke/qBOzOMFV907/2dmRU zn9vQWAHBFqMtVkEQEcvMchQFGVx39dJUS+N5ymitDTt7NmghblD8ukKijpT7qVKVHBnCx8VqPYN5 LJvN00iozkJjXhxW3E5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2rS-004tSJ-WA; Sat, 09 Oct 2021 03:17:23 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yn-004Y24-H6 for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:55 +0000 Received: by mail-pj1-x102a.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so10602252pjb.1 for ; Fri, 08 Oct 2021 19:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cvv2iZxij6FWrFEEKivGkcFAPGtCwuGKeJ0S/lB+6EU=; b=m+yu50ed2jVSOX0M9sHuJNhXc/nCyPAK8gkjfh8Md+/1g1DX2amYjYPMjtpTwTPXY5 Gs7HlVsnh0le0O2GjbBDvD1NpMwUKlDWCtbjVDDYeHncDRkYsbtrbTCmAncoE+g2HO2N wWn+Hi4B1CiA4U11YZHBUxnWQUfTKDH/Zx8tQ4zqCDk7rWMQxqa5GNo+DTsOUZwqueqG vqWoPlnY5MJ2H//RaNRbeIH43FXhBeniJnEKolir1M4ZcP2VHEyhIJHPaRpgmH68UyEV 00fag0vdS6sLiSorNyYSadp78Ee/oXQ7TKZ8J2oGlog3YAbAglb3oVvoHedmZwk1cqFr xDBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cvv2iZxij6FWrFEEKivGkcFAPGtCwuGKeJ0S/lB+6EU=; b=bPclJfVjfelS1QOPGByh54KvW1GDA7VMQl5GJyeK6+8XCeSLI0Fx+HPuMzn8CMERtq 3T5egxTN9B+1BxbcHfjEoCn/3E/nq/OhZm0HaEs3rpB3xzBcT/e1QPVJ091iRDVEzt6P u+9au6+uQHWGUOxK8r0LUZEqbMu4lH7E7gQ2pP85us3/tthVrYrmofTUwZhjbkPsAEKc fTTP7KFxPd/yhThzBBBh3ore9QVyNxXt2TY/Um3k+jZ0bydu/02Tle5wT+baWCZ1BrNd QMq/iq7GOK7nQGHCENWMszcvwuTJlWEiUknp3mBteeCEG3JYWfUGcIOfSuILLFN5plG9 i+Yg== X-Gm-Message-State: AOAM533I0qwpFK8gofMgpO143tQFL2nFFpTwr8/cbQgb+Fmh5e9syZHn zBLXT/lu5/kRErf0gy1fKyM= X-Google-Smtp-Source: ABdhPJzvTTzmfKXKSi4ia/rXDIDQdlTEWkuf3Sjm3NpkIWpoiQe/9W6A+86jjjFfVyWVz+ZauROyQA== X-Received: by 2002:a17:90a:1548:: with SMTP id y8mr16621507pja.151.1633746050443; Fri, 08 Oct 2021 19:20:50 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:49 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 13/14] ARM: bcm: Removed forced select of interrupt controllers Date: Fri, 8 Oct 2021 19:20:22 -0700 Message-Id: <20211009022023.3796472-14-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192053_620047_D796E654 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that the various second level interrupt controllers have been moved to IRQCHIP_PLATFORM_DRIVER and they do default to ARCH_BRCMSTB and ARCH_BCM2835 where relevant, remove their forced selection from the machine entry to allow an user to build them as modules. Signed-off-by: Florian Fainelli --- arch/arm/mach-bcm/Kconfig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 2890e61b2b46..bd3f82788ebc 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -161,7 +161,6 @@ config ARCH_BCM2835 select ARM_TIMER_SP804 select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7 select BCM2835_TIMER - select BRCMSTB_L2_IRQ select PINCTRL select PINCTRL_BCM2835 select MFD_CORE @@ -209,9 +208,6 @@ config ARCH_BRCMSTB select ARM_GIC select ARM_ERRATA_798181 if SMP select HAVE_ARM_ARCH_TIMER - select BCM7038_L1_IRQ - select BRCMSTB_L2_IRQ - select BCM7120_L2_IRQ select ZONE_DMA if ARM_LPAE select SOC_BRCMSTB select SOC_BUS From patchwork Sat Oct 9 02:20:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12547277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1672C433EF for ; Sat, 9 Oct 2021 03:17:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C73E60FC2 for ; Sat, 9 Oct 2021 03:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C73E60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yEwxeIQc+UU+L7yj3eECEoI06gerT965sLE+23vm7OY=; b=vxGrBc7Tt9muEx LEVZgsj8JKoyopVM5FFJc+/83XcrTMlbRORWCtClz8txwaQUoA7lv43MprZYEe2Omk4KLBCdVed6C PFUFU6FrtdHzeJo/fXhhpy8wzhW+9xu65uobFmrXAWBukKjoR91n09oe7fKunHN/lO59+R1F90RL/ PLKoi0g3lNCIHxCPx/MtORuP0EkAb0rOVc3IByttjUez6apspZbHBMXLdHhi3edVz70RHP2YNSCAW zDTmBOJr4h9oTBoXVxvDEkC8fQerJfS+/lur+lXCoI4zyUCZnaeqDmcBaVIOqFlPJoNECCVL+fBZh DiloXSSs1btGDAkNkxEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ2pG-004scm-RA; Sat, 09 Oct 2021 03:15:08 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ1yn-004Y2b-AT for linux-arm-kernel@lists.infradead.org; Sat, 09 Oct 2021 02:20:54 +0000 Received: by mail-pj1-x102b.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so10602276pjb.1 for ; Fri, 08 Oct 2021 19:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2G1kdri23kWnlj1enPufIZN1leyxpMasJ2EyRU0acfw=; b=CfX1XQ9OItoC+Tck4KAw3dX6II/+kBQdyoYgzKxz7SbcfRxZRwW/6EdJYv7NEYHCBs my1ca7Qgs4lOy4TQWZYFbVw8rz2Le1VIt9aadwb6p0eMsbhussjUrnXIiIhityMik7q1 /zpGuL2BwJBMwVNCjPMMYks/EKT8COzsVTHA6zbb7JrfzlMDRoleh44YMllSGX8KBD8y HdQqqjjjtOiU2Rgc1oB4PaUD7ulGDvsKp6WZ35I1EGat0Z9eWuX1OnPQ5hdYdCT0pDFj CiS0r1f/FwCfkTFsVeZrqPIsag+JDjjCrmtnMGXHAg5ag87bYTRE6yXRdHLLd3eJVTP3 a7FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2G1kdri23kWnlj1enPufIZN1leyxpMasJ2EyRU0acfw=; b=g9BBFZ3tMpeUxAw1IJXnFcR5s94c+JGu9sFuN8xKaNqciCBVpONcXdCBHNVzf282YT 38t5y4VX7aNEI6kKGQ+utLAq64mqaLfHGKuazhW4kG+lXKWJ3tY5nXwu8VnOzZsQnJpM /YC8ESJ5bCtBz6VL+dmS228OYhXViJJ+g9mgdSsKl2dYN2jVnpbGPr703e2N8fnKnk+v 7wGFR/nSEkvYrQOjOFzTBhn41XgA6dpGHbW35Dr2tpam4wS2P0FLTC+0gsLCyoV8otDD YDSkZ+sVFIBtWC1WmuFHj2tNrLNR+JRfrY+6tkaU6talXLo4Ce2/YP5cIq1JSJoujzDF VlIg== X-Gm-Message-State: AOAM531zqktcj2I0fdH/rPsX2IHoLmFwyGyIzCZ6nZvtopQfTi3V3xSq 43iQzFU7LJ7fcKXUyREYfsc8PNw59cI= X-Google-Smtp-Source: ABdhPJyhyJrlh/qrD1jpXbGniDULsoIKlimYb+RyOYtlOTE14n47zNMHqFBwjExwM0cBXcvomzkauQ== X-Received: by 2002:a17:903:2287:b0:13e:5d9f:1ebf with SMTP id b7-20020a170903228700b0013e5d9f1ebfmr12380907plh.75.1633746052048; Fri, 08 Oct 2021 19:20:52 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id pi9sm444692pjb.31.2021.10.08.19.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 19:20:51 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v4 14/14] irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE Date: Fri, 8 Oct 2021 19:20:23 -0700 Message-Id: <20211009022023.3796472-15-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211009022023.3796472-1-f.fainelli@gmail.com> References: <20211009022023.3796472-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_192053_433681_10460BF7 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The documentation refers to "compstr" when we have the parameter named "compat", fix the typo. Signed-off-by: Florian Fainelli --- include/linux/irqchip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h index 67351aac65ef..ccf32758ea85 100644 --- a/include/linux/irqchip.h +++ b/include/linux/irqchip.h @@ -23,7 +23,7 @@ * * @name: name that must be unique across all IRQCHIP_DECLARE of the * same file. - * @compstr: compatible string of the irqchip driver + * @compat: compatible string of the irqchip driver * @fn: initialization function */ #define IRQCHIP_DECLARE(name, compat, fn) OF_DECLARE_2(irqchip, name, compat, fn)