From patchwork Wed Oct 13 14:46:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43477C433EF for ; Wed, 13 Oct 2021 14:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2339361177 for ; Wed, 13 Oct 2021 14:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236474AbhJMOtB (ORCPT ); Wed, 13 Oct 2021 10:49:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:52960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbhJMOtA (ORCPT ); Wed, 13 Oct 2021 10:49:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4CC2461166; Wed, 13 Oct 2021 14:46:57 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 1/6] svcrdma: Remove dprintk() call sites in module handlers Date: Wed, 13 Oct 2021 10:46:56 -0400 Message-Id: <163413641616.6408.5066105649819002503.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1392; h=from:subject:message-id; bh=BR5geGc6pgqOYwr1XgHbnHSOKXn49/1oY3gm/WvKgZ4=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvFgHf5DrKFwyAfMiORCtbAn6ShpjP9nv9Xo6diH stxOHgSJAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxYAAKCRAzarMzb2Z/lx/MEA CHHPjgYH/RVD7ww22wkOv+aPw6Ekl92OHvHCIRvMsQutiBcWWA4pcdRAXfXLu05vKQm1BsPjEvoU0h X3q9yC/+17BlG1J8pu7bUYz0ZIeSACReJSXcL9GRJ3vTqdkYYE84q60G4ffXHaW05tPHC2US+wJRT+ z40K3W7U6UlSqL3H46U+4p5k4EowysC7dBMpbdyFmUcTB5Rd5IXmumYLQ+E2j5Jpe8XJuepHz+X56h ivVGchZIywthab+pH1CpLgGv48TLETjwfZ528ytQb3w9/yfX+jn5TYPh/Ygacrfo7y4PxhfRSWfqzE 4vYQ+H3FEFz5PCKaVydK+SOnwC30/4qEMzk8WBy/DVAoLbNbpYRUFHF2PWEKgVEImi4uwxRgREskIV /1hEKQIV7OhyluBt6zX0TGEzK292t997Ok+UETpDjn3Ha8j8vQBBypQIOgtObuvlwZfdz91hwqDmCV 3OkVDBsrTEUKW0mLEye5rJ1PXtbr/ZY5iABb6FHNd/KfBAorgfXV2I1jVOv++1c79VZPh0mCImtgvC EaxMvIciwHqwb332yrB+6HbAghnxfCTy6Qj6pcZOY1JQ4Uxbd6xVECpvS7pwRxBXXOFdGlcbpWon2F 2P3i13uJkK7mEf44aKqr5SFGl2DWQHbvFnSgqmac+12iZfDAxaq3W4dW7dmA== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org As part of the deprecation of dprintk, remove low-value dprintk call sites in the module init and clean-up functions. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c index 5bc20e9d09cd..2470a7926469 100644 --- a/net/sunrpc/xprtrdma/svc_rdma.c +++ b/net/sunrpc/xprtrdma/svc_rdma.c @@ -49,8 +49,6 @@ #include #include -#define RPCDBG_FACILITY RPCDBG_SVCXPRT - /* RPC/RDMA parameters */ unsigned int svcrdma_ord = 16; /* historical default */ static unsigned int min_ord = 1; @@ -275,7 +273,6 @@ static int svc_rdma_proc_init(void) void svc_rdma_cleanup(void) { - dprintk("SVCRDMA Module Removed, deregister RPC RDMA transport\n"); svc_unreg_xprt_class(&svc_rdma_class); svc_rdma_proc_cleanup(); } @@ -284,12 +281,6 @@ int svc_rdma_init(void) { int rc; - dprintk("SVCRDMA Module Init, register RPC RDMA transport\n"); - dprintk("\tsvcrdma_ord : %d\n", svcrdma_ord); - dprintk("\tmax_requests : %u\n", svcrdma_max_requests); - dprintk("\tmax_bc_requests : %u\n", svcrdma_max_bc_requests); - dprintk("\tmax_inline : %d\n", svcrdma_max_req_size); - rc = svc_rdma_proc_init(); if (rc) return rc; From patchwork Wed Oct 13 14:47:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC79C433EF for ; Wed, 13 Oct 2021 14:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 961E860E09 for ; Wed, 13 Oct 2021 14:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235047AbhJMOtH (ORCPT ); Wed, 13 Oct 2021 10:49:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:52980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbhJMOtH (ORCPT ); Wed, 13 Oct 2021 10:49:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D279E61130; Wed, 13 Oct 2021 14:47:03 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 2/6] svcrdma: Remove dprintk call site in svc_rdma_create_xprt() Date: Wed, 13 Oct 2021 10:47:02 -0400 Message-Id: <163413642271.6408.118012829392169503.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=988; h=from:subject:message-id; bh=ik04DHwnDbOcw4LYRYI9K7hscvAobiJpvns68OLdLpA=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvFmrgaF0T/hlLGUTHNShlrKh9ixl9rzzWgdH6kd ZfZm50KJAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxZgAKCRAzarMzb2Z/lz5cEA C/WB+Ab87k6v4ozLInhfCkb33D2oNY5CQdiBMDInhIKyXZmtCb8kpFEGpVQ7RSa5DNrKwn12wwphn3 DzaIC9ytUIoWrwrlRQtvRfRkp/UEa82VHuEPlR7Nrn/wK1brbaypG8Hyk2lVl67pOZAEHESHMieazZ CyJdrAa++Sspryu8Wu5yowttwhL+ByUh2srlWQ/urj/2yAb2xba0iXSbAWkuzL/XUVlCcIxuKOTz7v PbtaEp6OLmdokSevYzc+QJYkQjLcDEq/8r9BGR7gkPvCJvUz0xmMkmG9QB03wN5IK31DTgAEN5Wgtk IoV35AUJSp1wwiXsrhPDPtIwVsRUL980FVIKNCIysNbiuTTwlQE9QudT2QTtrdk0GczB65qFgaZGYn rl2UM6NIft6vSlo/GO9qBvgiS8f3CO6aQlbwLX8mXP41+oeOQZ4HO3Ejov4R0S3biqBbdO4b4HQBWB 2SLT0+Qg5tbzKxmEpqxSEYYipVU3jUfNOjm50AI4vv49f24hdZl5+GP6x1NkF3Gy0DB1PcmJ3ZD/9f TaWXQED7dS0VHekUEJP88dXA0B0KWXnY5VBmNWPdTJIfe8bRnirp2vuu0jioKtXacctiWf1TaD2sdr DPGvOyCy+Nb30BtBuzUG6hpmZoM90+HUuzpWqCJiLFuzbrK6cPqCCJj8F22Q== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Deprecation. Generally a dprintk() that appears during a memory exhaustion scenario is unnecessary and can even be counterproductive. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 94b20fb47135..9aea253af2da 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -129,10 +129,9 @@ static struct svcxprt_rdma *svc_rdma_create_xprt(struct svc_serv *serv, { struct svcxprt_rdma *cma_xprt = kzalloc(sizeof *cma_xprt, GFP_KERNEL); - if (!cma_xprt) { - dprintk("svcrdma: failed to create new transport\n"); + if (!cma_xprt) return NULL; - } + svc_xprt_init(net, &svc_rdma_class, &cma_xprt->sc_xprt, serv); INIT_LIST_HEAD(&cma_xprt->sc_accept_q); INIT_LIST_HEAD(&cma_xprt->sc_rq_dto_q); From patchwork Wed Oct 13 14:47:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BEEC433EF for ; Wed, 13 Oct 2021 14:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9507E60F21 for ; Wed, 13 Oct 2021 14:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237049AbhJMOtQ (ORCPT ); Wed, 13 Oct 2021 10:49:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:53096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237207AbhJMOtN (ORCPT ); Wed, 13 Oct 2021 10:49:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69E2D60E09; Wed, 13 Oct 2021 14:47:10 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 3/6] svcrdma: Remove dprintk call site in svc_rdma_parse_connect_private() Date: Wed, 13 Oct 2021 10:47:09 -0400 Message-Id: <163413642926.6408.7192303522581995956.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1101; h=from:subject:message-id; bh=XgzUEXukK7N05z1x+gmSa1b0g5Fm+Il9JOCAcTMKrlo=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvFtTrLFswUBkMgn76fs9muBCG81tPBTD3A9/GRY MN9zsG+JAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxbQAKCRAzarMzb2Z/l4AEEA CacOtonyz77k68sXOQBm9zDc131QIkokrdD5kS0lVM9VVSET9cYaqrwrkmHBDN04AAmNIOTMd78/yt KkOeMOTu4a9m2A8jEVhOwNEe2fBLBHueCJe4V+e/kKFmg+hA3wtd9mB8D6fKqvHqQjaG1rVXHZSjOH AWH12O+9SffJ6p7fdla3M5GLboO3nEcoS/OZuCGsqnYXwgLRR2fDg7JuxbRyi4D0dRFktkKjKAgsg5 jPWUPULy6r2AfPEvesKaVmaBkCzzT4UuLTUDHnCwuPbcuj4Ha4Z8GqTn8rYUse7YpViHyV2aHPIDQM w8UK65/LQyjMFUCDlcuwa2WbpXMJSdqJlS5MZ/wEbkXyJwXBuy/aK0IKbFTUBGHkQTQYfznVqWFt81 ctGqdEcXlgB1AFC+aPkD4Wu/8MbHVT36GsLuNdRngMgL6cQ60HEFQ/jgSsGW1xYqu93PLvVqOu90r7 pLbDs+ghLO/D0gzvpoT6CjV/JN5KS66WGYnPwTeD+U6BPt4rE/6a6jEdXAYKeHItR3zbzdZO47qqcU b9gIHbP9UsK/7+H+p1lMl6oytVVI0eGI4b4X1W53PIN0IBlOU/vuSbtvxAZKNRJaEFgZMmPnElGifZ a9/5WVhQNDkiJAet9ZpS1gyCdA4PniwbZo68p+mrKZYJF3+MZOUWlZgjswww== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Deprecation. The effect of the RPCRDMA_CMP_F_SND_W_INV_OK setting is obvious from subsequent server activity. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 9aea253af2da..11cecfb7761a 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -164,16 +164,9 @@ svc_rdma_parse_connect_private(struct svcxprt_rdma *newxprt, if (pmsg && pmsg->cp_magic == rpcrdma_cmp_magic && - pmsg->cp_version == RPCRDMA_CMP_VERSION) { + pmsg->cp_version == RPCRDMA_CMP_VERSION) newxprt->sc_snd_w_inv = pmsg->cp_flags & RPCRDMA_CMP_F_SND_W_INV_OK; - - dprintk("svcrdma: client send_size %u, recv_size %u " - "remote inv %ssupported\n", - rpcrdma_decode_buffer_size(pmsg->cp_send_size), - rpcrdma_decode_buffer_size(pmsg->cp_recv_size), - newxprt->sc_snd_w_inv ? "" : "un"); - } } /* From patchwork Wed Oct 13 14:47:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB189C433EF for ; Wed, 13 Oct 2021 14:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9118B60E09 for ; Wed, 13 Oct 2021 14:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237207AbhJMOtU (ORCPT ); Wed, 13 Oct 2021 10:49:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:53136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233971AbhJMOtU (ORCPT ); Wed, 13 Oct 2021 10:49:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF7B860F21; Wed, 13 Oct 2021 14:47:16 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 4/6] svcrdma: Remove dprintk call sites during QP creation Date: Wed, 13 Oct 2021 10:47:16 -0400 Message-Id: <163413643583.6408.15197434543794100032.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1208; h=from:subject:message-id; bh=FRC2h1RBBN/Po84WMyVhVKnP8xRRkGCjDJn70Hg9lWM=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvFzDYVkOvfPo+rOVbAy9U1mpYFUivxAqxxXgDxL drq0aruJAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxcwAKCRAzarMzb2Z/l5SjEA C1U6BtF6XytmZ3ytya9dGWbNpimiP8+bFsretEqU215ZgJ38H0P7pA54dQrgSytU2sAS4NJUtdvAYR 1jx7OX37jxi/05Vk+TAeg6y5pCsUCQHI8Sm2m4CRpZFCunk+W+Mu01khHBcN0ftx7uNqEwzR44Ep6v 9jpRxzhbOAJXUhIXxfNePwuLti675JWATegJ82L3RFCBRGxpmp3ZLnIrmtNBDDtl7QDBUi/A6O0qMD ukmMHF8W22i2X4E3edcPkjdTno63j4kqgjCBt1pWY6hAXDS6XxkI7rX94bdHXUWAEB6EW1vj3rkbjF rLXyUuNN+OkNlOB5bxI1LTMRU6Y7YrulHShxBpWJHTb4uj4rXDMe/HIc1nKm6WxZxPcevzNdede5mE CZrhsGZCJ26E/+PVDEnLicTvHBTcpxB6FDJiaoJ2KDVBEmsGQx1Xr/16pbJY7rlhxHWjmi6o5iW6yP 80d3ak8XBu6TQI5YQ4FMSf8vms3iTwnutqXi7Egz47yOvF0xBSejdQAkwe1FNYEDPmSCtAmf1vSxI3 fHh8gZxACuYBqjbrwCvruffSlRplCGmMhl3Grs5+LxQDpHpktRImdk8XidoPBXPTsvN9uki+/3XMPU yw/jKPaqR/VklquSHmex28vkbQH1/nXn/vyRlpJr8Pyq3J0M7naJQZOZOpig== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Deprecation. Printing pointer addresses in the log isn't valuable, and the other information is now available from the core's qp_create tracepoint. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 11cecfb7761a..e105e2d89b9b 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -445,13 +445,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) qp_attr.qp_type = IB_QPT_RC; qp_attr.send_cq = newxprt->sc_sq_cq; qp_attr.recv_cq = newxprt->sc_rq_cq; - dprintk("svcrdma: newxprt->sc_cm_id=%p, newxprt->sc_pd=%p\n", - newxprt->sc_cm_id, newxprt->sc_pd); - dprintk(" cap.max_send_wr = %d, cap.max_recv_wr = %d\n", - qp_attr.cap.max_send_wr, qp_attr.cap.max_recv_wr); - dprintk(" cap.max_send_sge = %d, cap.max_recv_sge = %d\n", - qp_attr.cap.max_send_sge, qp_attr.cap.max_recv_sge); - ret = rdma_create_qp(newxprt->sc_cm_id, newxprt->sc_pd, &qp_attr); if (ret) { trace_svcrdma_qp_err(newxprt, ret); From patchwork Wed Oct 13 14:47:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6D3C433FE for ; Wed, 13 Oct 2021 14:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 629D160E09 for ; Wed, 13 Oct 2021 14:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237030AbhJMOtb (ORCPT ); Wed, 13 Oct 2021 10:49:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbhJMOt0 (ORCPT ); Wed, 13 Oct 2021 10:49:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 807D0610C9; Wed, 13 Oct 2021 14:47:23 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 5/6] svcrdma: Remove dprintk call sites during accept Date: Wed, 13 Oct 2021 10:47:22 -0400 Message-Id: <163413644238.6408.10635937247771604119.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2050; h=from:subject:message-id; bh=h6zqwSVQn+NWKJoOaKIqAaEcOL9OpKdXPKCk6VxK1tY=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvF6+vh00eJbnd+9s+acqU2jL8V31Nk42HwbocsS zpmUXm2JAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxegAKCRAzarMzb2Z/lz1WD/ 9k/mYXYZkh/04MrjJXVgrpUyVdY3Qwq74L+7G5eA/NUSIfCRS/va2k3ahsQaSyNvrbVWyeSkXQr23Y ly05VhZOB1x6OINpvbu5Mxv0A9+WXjcRQbU04re5Ma3liWRrqLzvYsVjt0keoLP1h2K2rU4mHg4cNt 2+cdFC9yRdvrunILhago+5wAkElwpxHUPy6UAqQ9vGl08EmJnWQ1ybzHyfv6r70BmchdTg2mYwd49t xdZ4Up6qeoNDcJyMmQv2xEXyW/WyX0qXKbniYLBVN+3KYK3NKwo3QsNe/QYYfZ4ZyDqUr5osFGOiqQ ANuxnoEZcI+431XvX57HeDQZWRceizFRTLgDbxt/1kdw9tzE72Ed1oaZMk7fyGQvbFSjhTOtJDteA+ Vh3r77lNd0Q5jS1It4Q1lxNItHg+ZDUSmzFC9G0f1P7m/g4JFzZsKc3Ak6cDBC+9YnhBKT/F1ug3My dnyXzwTxBw/O7gmTqEYfP9Fxz40IeYDmR4Zfiwmj/4oWYnQSsWEJ3CnWXuRw56lg5OPo39TWFMQLjb hrTnQoWRo2Huuf/h4FiSSP3uO1/HhO6idbfHas1dihf1UJraU0uf3TxdoE/DxQYXfiVNrG9ChZVmUQ Fg1B4tVgiPddmvn7Q+mjm3pCkFEcr6WT/oCxJZkv8kgaXi4dELOHwSLqJFBw== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Deprecation. Most of this information is available from other tracepoints. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index e105e2d89b9b..acfde6e1594c 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -54,14 +54,12 @@ #include #include -#include #include #include #include "xprt_rdma.h" #include -#define RPCDBG_FACILITY RPCDBG_SVCXPRT static struct svcxprt_rdma *svc_rdma_create_xprt(struct svc_serv *serv, struct net *net); @@ -365,7 +363,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) unsigned int ctxts, rq_depth; struct ib_device *dev; int ret = 0; - RPC_IFDEBUG(struct sockaddr *sap); listen_rdma = container_of(xprt, struct svcxprt_rdma, sc_xprt); clear_bit(XPT_CONN, &xprt->xpt_flags); @@ -492,19 +489,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) goto errout; } -#if IS_ENABLED(CONFIG_SUNRPC_DEBUG) - dprintk("svcrdma: new connection %p accepted:\n", newxprt); - sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); - sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; - dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); - dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); - dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); - dprintk(" rdma_rw_ctxs : %d\n", ctxts); - dprintk(" max_requests : %d\n", newxprt->sc_max_requests); - dprintk(" ord : %d\n", conn_param.initiator_depth); -#endif - return &newxprt->sc_xprt; errout: From patchwork Wed Oct 13 14:47:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 12556077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A44C433EF for ; Wed, 13 Oct 2021 14:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DABAC60F21 for ; Wed, 13 Oct 2021 14:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233971AbhJMOte (ORCPT ); Wed, 13 Oct 2021 10:49:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbhJMOtd (ORCPT ); Wed, 13 Oct 2021 10:49:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C29F60E09; Wed, 13 Oct 2021 14:47:30 +0000 (UTC) From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 6/6] svcrdma: Remove include/linux/sunrpc/debug.h Date: Wed, 13 Oct 2021 10:47:29 -0400 Message-Id: <163413644893.6408.14362581680618135243.stgit@bazille.1015granger.net> X-Mailer: git-send-email 2.33.0.113.g6c40894d24 In-Reply-To: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> References: <163413628188.6408.17033105928649076434.stgit@bazille.1015granger.net> User-Agent: StGit/1.1+62.ged16 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1071; h=from:subject:message-id; bh=SU2fc6xO44rJcYeJ7Q/XgB3v712PexCLQSi7NQz1QL8=; b=owEBbQKS/ZANAwAIATNqszNvZn+XAcsmYgBhZvGBtEQPMImssMNu5v1sxxG36HWwUubl8xCyZ0kq P/OYz5mJAjMEAAEIAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCYWbxgQAKCRAzarMzb2Z/lyFPEA CvLeNHVKaoFGOfwKgoEPq7KrLUkimqqTnrujOdA3ICP5csH+3ZKykBuaetl6wUOIwf3xchQ3t8HR5a SXvOgdtaN+4LNC9eJH8DLNLcKcZM8cvT+wLwo1n9nwHMHrXQOLAi8jnuw/w97MgkhD1EPDwM1JlWeK iaUJHUcABCgtBy5udCW5z5mBEzGdzugnZpFrzZuCy6d9kROy9tkUcJ92MO+cgd7EEzBZmNLWshHXV9 Xhe/XeI6NrU1QVojiV+1KMcwyiW2U1EUud0vbGiOr3yzEHur1FcfN8uceApdbs2oClYBHeCg/Nln6M l/H2LYTtMQ5ul7WzF8wd6GpYIVV6sodAk16/sz6IC+YgmC7GrBsgDMg4x/br4uO9F27Bfmf6XNuFy0 aCj+eYzsMpG6ExaQlH1Q7Lch25Maagwgq9+/d2FTLQO8Un+gq3ea5Khi/11at79TuDKitTUtklISoh //oUGAnxiAMGaGIH+DBFD7cKaJP/S3KeHtPMkje0qUXDLy5mrDVODj4OiztBxdIwr2RBpHrNkNju0B ELXNqcfdlIpN7h71boyemrKs3orMLjo5Cheg1ZDeOOrriy1SC97d6jltxpcXqrdq6jztveig22MWyN 3rn8Y8/u3YTUHbgRYDM6t7C52x8al7r5d5pty8Crat6g7LziDI0tKU5cBFyw== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Deprecation. svcrdma no longer uses dprintk. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 1 - net/sunrpc/xprtrdma/svc_rdma_sendto.c | 1 - 2 files changed, 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c index cf76a6ad127b..3be39fc5cec4 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c @@ -99,7 +99,6 @@ #include #include -#include #include #include diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c index 22a871e6fe4d..e973e5b3ce08 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c +++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c @@ -105,7 +105,6 @@ #include #include -#include #include #include "xprt_rdma.h"