From patchwork Tue Oct 19 09:34:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 12569251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630A0C433FE for ; Tue, 19 Oct 2021 09:37:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F3BA608FE for ; Tue, 19 Oct 2021 09:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F3BA608FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+wuxk7HnkqbeLKOHtSUhl3LKrLrZhlmZlshFFk69aDU=; b=ITJSpx1Brx152l q4IwyCYTFzq+NDjPdmRMTk4yniAXBlHWm/K53zGvhDtp3MLnv1pvOuroVOgSwW+onOY9u59uk0lQ1 SRiOmC0T6MrOKdWa2i/ndMWqThXXkzJAZKwX6xf0XOn1kv2F5ZbO7qyzfYqfaCEEFxEQWLlNNwVF6 AhZ/Ui9gdOvHZiAXZ9JP9BOyKO0WZ1IkXcr48qruOIu2Yqmlfqi1klGLZFG80mtf6puPdWu0BVDZY WQPFlkVWuz4Zg0OtyQSroUYopNvroEJZJUBZkSwl1kWxYdVt7q/iHG8ZZRoLUZGyss01pokxUN+2D eidxd0FT9IzSG/Pvgo3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclYF-000gJl-P9; Tue, 19 Oct 2021 09:36:55 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclXp-000gAa-B5 for linux-mediatek@lists.infradead.org; Tue, 19 Oct 2021 09:36:32 +0000 Received: by mail-wm1-x330.google.com with SMTP id a140-20020a1c7f92000000b0030d8315b593so1980964wmd.5 for ; Tue, 19 Oct 2021 02:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CJsCWcU0YdDyrwMeRQ7adfzbBn9rJ1IRoawBpqp6LUY=; b=a4CDa4TY8RYsyf7Ov/rhPNU9JCjBEheWYFGjZ6M0fICmzqhK5+vkmDMKU/YI/iPSAe dhQdYbJ5sngCM+Yg0WcU+C1SnMh7BBiM7XI8Y4zFepF/ek5KXIV2uFha4YAd+n89I4fd hAkiABx3Q3nVhuCHGuvvTldrFhel/udGiW5h33GXk4Vh/NmEIOUMeZoSOcRPSnEzHhpr e9nRg3t/1KKxaflSVB4zdNl6a8RS7Tbp6DaHUriiI7T1AZQyW5+F/y4xjmzQzqE1yjxP 0zfmI8Wwr3FkiwXL37JohYx0k0eXxdkKvxEHEnvohFXM52RGPKtwcu5WjB0TK3fouwbs 5wUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CJsCWcU0YdDyrwMeRQ7adfzbBn9rJ1IRoawBpqp6LUY=; b=H26UOjsa7Q7AAr4lTcVAjJHWXF7eLvdzw0cQtAP6MG/Cn/aUP2VTgCUB26C3aIHtCB CksdxxCXAvNyFpxKdwhnv21+eL5j7fiIR43RI0RDQcQBQXjZ16iHzcLT9TeycTmLL7cv EnbTbC0+ul6S7ZH5ahzBTzdUj9naOyFw5OTgICsMUulFwuecZ+/JL/CGN0lnt7mRSgII LTCOUcEwDSzAGElWZIkn7RtqXF5UUJm0Q3Ly26uNwARsKqhpPT0sE6q/bw7+XFnu2Hxk vPmKTOqEhabdPqW2M2sWWNvhBrt27VE3ud5ohoYkIV1opzriO0N1hueXGJBPefZMM/zm OtxA== X-Gm-Message-State: AOAM5327XfXMpruYVn5qiwP3u4YN2F6PN/1oGHO/+f4GxjMoq6ZHLX05 X2V13EkE6irJxbdcAOFEbOQa5A== X-Google-Smtp-Source: ABdhPJzhrEXmzMbsOs77lioFuMQGNrVk6F0Mecc/zs/NbpM2tEsMZAwoONXUBlPSFvrPfNoD8x+fiA== X-Received: by 2002:a1c:cc0f:: with SMTP id h15mr4821476wmb.37.1634636187595; Tue, 19 Oct 2021 02:36:27 -0700 (PDT) Received: from blmsp.lan ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id o23sm1765765wms.18.2021.10.19.02.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 02:36:27 -0700 (PDT) From: Markus Schneider-Pargmann To: Zhang Rui , Daniel Lezcano , Matthias Brugger , Rob Herring Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fparent@baylibre.com, khilman@baylibre.com, Markus Schneider-Pargmann Subject: [PATCH v2 1/4] dt-bindings: thermal: mediatek: Add mt8365 Date: Tue, 19 Oct 2021 11:34:01 +0200 Message-Id: <20211019093404.1913357-2-msp@baylibre.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211019093404.1913357-1-msp@baylibre.com> References: <20211019093404.1913357-1-msp@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_023629_388214_F98B406B X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org This unit is present on the mt8365 SoC as well. But there is a difference in the usage of an apmixed register. This patch adds a distinct mt8365 to the list of compatibles. Signed-off-by: Markus Schneider-Pargmann Acked-by: Rob Herring --- Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt index 5c7e7bdd029a..ba4ebffeade4 100644 --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt @@ -14,6 +14,7 @@ Required properties: - "mediatek,mt2712-thermal" : For MT2712 family of SoCs - "mediatek,mt7622-thermal" : For MT7622 SoC - "mediatek,mt8183-thermal" : For MT8183 family of SoCs + - "mediatek,mt8365-thermal" : For MT8365 family of SoCs - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs - reg: Address range of the thermal controller - interrupts: IRQ for the thermal controller From patchwork Tue Oct 19 09:34:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 12569249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A759C433F5 for ; Tue, 19 Oct 2021 09:36:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E22DA6138F for ; Tue, 19 Oct 2021 09:36:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E22DA6138F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GWuFKR+2eQymSUFXXjWEkqG+HfFOmC1STJvdrCk/7Vo=; b=OqPBrtCvQbBPh8 xEbytIM8NxpuCtuC+8s+6yEakodl1o9ChxyeA44ifWwHYt0DTDGIU5VnNOfT6ABFZhIFCD0LyT89G dGdXk7SMnNQYhpdYTsSTjwJ+RJQSpX3KK06nhiInN15ThVHbDLSgqOywClDBX+w3/l3QCCRuq0B7M J5I5Ev/Wgd0KM75RxdnXOZPMaeb7YAwkCjq+jA90lG7mu4osqQPm+oawWkiQ1umWE2bZYeMTohRoX tDyzP/EFV5D41kZGDGag9+sybPXXoCADzkMjfadEdyekB7tJJm7YkB/hgCmXiBI4in5uPkLdzBaYa gA7Or+IX0g32LGuqMowA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclY3-000gFw-No; Tue, 19 Oct 2021 09:36:43 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclXq-000gBA-4K for linux-mediatek@lists.infradead.org; Tue, 19 Oct 2021 09:36:32 +0000 Received: by mail-wr1-x42c.google.com with SMTP id e12so46579652wra.4 for ; Tue, 19 Oct 2021 02:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=31i1xoK4zj6WYEXJeZOG+hCuryOlTysPNDj29OD14Qs=; b=Y2eamLP67cGTLHdzxPbLdUPEYihkfZRXjLmtnxWMV7V8ha/xCyyiXWo24W7cKen6+2 AGmoxk8bAW1ZE6wRgyRZos2ZQJMvNmw3sEuikrcYvIIJYL03YACYQOa86okD3Erk21lV zAulkyr2f+gShgG97UnqzhdNrdO4Ua/xG4LPoWuamUHLjChfopvT3lP+voMhWfkt75tD zuNwqbKJobK755qHzpRhFHg3/uXIWAqhCAsc34J2OyIwWG2lZJkVUYczpRjmhcaddgYi S+iJFqHmqysc2aP70TNig3aAyHEkcBamDT9NGvGMwzizmPHMQZX9kKJlZVFcn3mFIdL5 Ioew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=31i1xoK4zj6WYEXJeZOG+hCuryOlTysPNDj29OD14Qs=; b=NQ4bWbVDR4KK1lHb2aSziE3Y9r8eOkE2vNjbxpLPcS1tWSaiCYJh8U6eVHtn1QEAP0 y551VwUtfjIFzFftfAA0k7LcXc2b5wtxvEljkld5Q7YOsm+qlHpsrKGj1kJhW5t4tbrO nkrrIsdGhx4hX/BIHRbVvv4eMhZ+1GSLKLtVFuoPzHTLOFMGCU0GoSIeIurRDFjSJ+Z2 Ub2cdszY8Bj0Bo+S5ckqsKH45IWDHBvbsFCqxWi7GjekRmnp3ZDOI65LbapB//Brw/ic BPS7ArJfHqbgfWnmCJBDkQX3trIAzGu41ARsPaQGhILmVPuYIGOvwpxfGA0XHzRoPllc m/Qw== X-Gm-Message-State: AOAM530GgL3U+QVtPWc4H1IKeTbaWut/QoDU092iP07umu1xIsr9J1iV k8hYwWZdyzP4vYTfwfwu+yVljQ== X-Google-Smtp-Source: ABdhPJw4NYs7gbiGNwWpmbKhDuahGeNvec/NydYON0RX/wR9CskYqy79yYN2c7zZkDO3NcrXwh+8DA== X-Received: by 2002:adf:f812:: with SMTP id s18mr5519018wrp.347.1634636188391; Tue, 19 Oct 2021 02:36:28 -0700 (PDT) Received: from blmsp.lan ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id o23sm1765765wms.18.2021.10.19.02.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 02:36:28 -0700 (PDT) From: Markus Schneider-Pargmann To: Zhang Rui , Daniel Lezcano , Matthias Brugger , Rob Herring Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fparent@baylibre.com, khilman@baylibre.com, Markus Schneider-Pargmann Subject: [PATCH v2 2/4] thermal: mediatek: Fix apmixed error message Date: Tue, 19 Oct 2021 11:34:02 +0200 Message-Id: <20211019093404.1913357-3-msp@baylibre.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211019093404.1913357-1-msp@baylibre.com> References: <20211019093404.1913357-1-msp@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_023630_194406_77CB5563 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Seems to be a copy and paste mistake, this is the apmixed address, not auxadc. Signed-off-by: Markus Schneider-Pargmann Fixes: a92db1c8089e (thermal: Add Mediatek thermal controller support) --- drivers/thermal/mtk_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index ede94eadddda..93ee043d70da 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -1050,7 +1050,7 @@ static int mtk_thermal_probe(struct platform_device *pdev) of_node_put(apmixedsys); if (apmixed_phys_base == OF_BAD_ADDR) { - dev_err(&pdev->dev, "Can't get auxadc phys address\n"); + dev_err(&pdev->dev, "Can't get apmixed phys address\n"); return -EINVAL; } From patchwork Tue Oct 19 09:34:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 12569253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27BCC433EF for ; Tue, 19 Oct 2021 09:37:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C19CF60F44 for ; Tue, 19 Oct 2021 09:37:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C19CF60F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H1YXDxGUbES2eheWiMWuH+eYXcl+kjn3MKgt7PwHCwA=; b=JXdWEOHRnTZBcp EVdvYGynmZKw/hYUgZg5zlYqfQpHRYjU5IBZFq3HhfPpOydmsveUj6RY4kVhV5+j2XTClfJ7mXTkT 2N7s7uj4IFX4+txbmLxyjcqPVTGQPrLLJBobuwCZZFx6GFxuG54dDcEU/AJLlCl+/mw27mxWF/v68 qt7oRSTbvjM2NgQXpp2kqK+vlQhHcIQpvdGxz8PYeOh4BsCHKEyciGiH7UUJyW8OzibTZ0z4uLn5N qg4s0Rq098fkELpC5lBlJIdFS1HmszkbqvZTnuu9hA4V8fgiCX0fN3IrofrsmCDR1X0kidCSqPRSm OXXLrig0nOtjKUPHt18Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclYe-000gUe-EE; Tue, 19 Oct 2021 09:37:20 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclXr-000gBh-8V for linux-mediatek@lists.infradead.org; Tue, 19 Oct 2021 09:36:34 +0000 Received: by mail-wm1-x32e.google.com with SMTP id y74-20020a1c7d4d000000b00322f53b9bbfso1994685wmc.3 for ; Tue, 19 Oct 2021 02:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4iBt5PaBb/SQkmIAGIPWPkHg9L+YHvcMfnSpD3LPoVg=; b=RK+5r5PwEA/nuA6SQzYqBleLenuGSzS9bmVPSgmr30nYakGL83fg5O29IqmUhqTMSz 7Gcz6od5O0ScvHxpYw0qK/0TwGLi3UWhkIfrTfMGbSwCLg5oaQx9td5xU7dA+1t42YNS u5hERCsAx9QENchxYFqV61KzePoxXK+NZXQ+e9kBphHBFw/qeQ0V6w5NeIVUthLNaA5e xHwd3UTYdP3K4iZYTZcCrBuz2qpb/+kToloaGtsFIYqF1Tr9+OavLKXW99ZOKyJFtmg9 buEnZ1+oqdBqcvf30QXT0uh+is2HrMukQHi68HyrBp6FuwEVzhWH0SaghAHfuqtjPo6Z Faew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4iBt5PaBb/SQkmIAGIPWPkHg9L+YHvcMfnSpD3LPoVg=; b=Ip9wgFd87rFtMc/OVjlOf2AcH8fRO1YclPBzcoh0fUIhSng50SPtckgHfcjH8nOytj U8V1wuoM7ROcRGYmF5SGlRxt+e6X6mPIkRnUNm+3SCRXK50I0eVfg0Kkqd7qGmfJ+FPB rEKULAk934RWNLV0F+Ytt60orK9M70qoa7dq1W656fKNZeFnIqziG3o46Q4/ueliCxhg OoY4e5V3mTLkhegcL9xo1jJyj3yUOLMylr0hrXFK7bD9L8Dts317/MSuGvz6eh1oCijP 4rV0jzQ1Epb/uWhvpovEbrVbw/nDpKTHmnaRnJXrlDVqj4D0JSYADQT02tWnX5tl0L64 ou/Q== X-Gm-Message-State: AOAM533KzTHLP9BSdTiFyYInyob0dMr6hYjkrZ4HWXFuDjAsf+VkFigL PHpE77MHuiUyu4/DGk0HhCjDiA== X-Google-Smtp-Source: ABdhPJyWlQB++OW76/yEH4NmsYV5AtI/qYWUDcxm+rP4W3MU5xU76g2eBRuPCVnJT3D8VtWE+sU+Ow== X-Received: by 2002:a1c:4b08:: with SMTP id y8mr5016066wma.98.1634636189302; Tue, 19 Oct 2021 02:36:29 -0700 (PDT) Received: from blmsp.lan ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id o23sm1765765wms.18.2021.10.19.02.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 02:36:28 -0700 (PDT) From: Markus Schneider-Pargmann To: Zhang Rui , Daniel Lezcano , Matthias Brugger , Rob Herring Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fparent@baylibre.com, khilman@baylibre.com, Markus Schneider-Pargmann Subject: [PATCH v2 3/4] thermal: mediatek: Remove data void casts Date: Tue, 19 Oct 2021 11:34:03 +0200 Message-Id: <20211019093404.1913357-4-msp@baylibre.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211019093404.1913357-1-msp@baylibre.com> References: <20211019093404.1913357-1-msp@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_023631_311973_FA8BF899 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org It is not necessary to cast struct mtk_thermal_data to (void*). This patch removes these casts. Signed-off-by: Markus Schneider-Pargmann --- drivers/thermal/mtk_thermal.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index 93ee043d70da..af6cd11eb221 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -941,23 +941,23 @@ static int mtk_thermal_get_calibration_data(struct device *dev, static const struct of_device_id mtk_thermal_of_match[] = { { .compatible = "mediatek,mt8173-thermal", - .data = (void *)&mt8173_thermal_data, + .data = &mt8173_thermal_data, }, { .compatible = "mediatek,mt2701-thermal", - .data = (void *)&mt2701_thermal_data, + .data = &mt2701_thermal_data, }, { .compatible = "mediatek,mt2712-thermal", - .data = (void *)&mt2712_thermal_data, + .data = &mt2712_thermal_data, }, { .compatible = "mediatek,mt7622-thermal", - .data = (void *)&mt7622_thermal_data, + .data = &mt7622_thermal_data, }, { .compatible = "mediatek,mt8183-thermal", - .data = (void *)&mt8183_thermal_data, + .data = &mt8183_thermal_data, }, { }, }; From patchwork Tue Oct 19 09:34:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 12569255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498E2C433F5 for ; Tue, 19 Oct 2021 09:37:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE236137E for ; Tue, 19 Oct 2021 09:37:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BE236137E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jwJdkj055yCnWvlzhhQkTTT10lwQVML1s97SOcsVK2w=; b=HU8BHRa4ZnSefi FYn+QZkDPIvGMCthBgIeWyJTNXcrOfPQH04V1KKEZ8XCsV0UWaHavE3f0HlLYFQs8eG30O+LFxYwu zTVR+VPuVa6DtIwoEbj963rgjeZN/pnwjR+QWsWSXjqzKmbbC+naBBpY0SqYkZNF6OmyvT26GWo3P pj65vEeDy9oBs05x3ZVlOWB1CszgrGlKFvcNFdjZ87t0vjMlmHJonApTmvUMYGm3JnVbDBHmsR+qr RiaKcWbnLY3biTK0kqm0nGWhHUA2zf1C+hA6K/JCrULJ28virekx1yLzNdFwRcA+8QWYzTTM3SJ8/ HZA+aZDPYQllAVercvrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclYz-000giz-Q9; Tue, 19 Oct 2021 09:37:41 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mclXs-000gCO-3p for linux-mediatek@lists.infradead.org; Tue, 19 Oct 2021 09:36:35 +0000 Received: by mail-wm1-x329.google.com with SMTP id b189-20020a1c1bc6000000b0030da052dd4fso2428659wmb.3 for ; Tue, 19 Oct 2021 02:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kPR+h/6eM3ZX03Np34xb39M/9vUCOohBgw0tAFYVvnI=; b=AlhVW9hgjnNo39uedKxH3u/l7uXlvHUiWRAtDIywHDFbDxoH9XM514c6T010eEV0Gw Hx3eh5o1avyNyUnJerOvt/yuNRKPYauKG8VMR1Svm7rPUAIkAa+d71SrM50oUZffW67T tNjHhv4o+BYdq9I1Ko2yde5jj7WuONT4DXXpY8Y2FWtlRD+5tzkH42qaYaGyGAtiIcth AOO3Bj5S0a40Wa3GuMd/h+GVBjH1/zw15FQIyUj6zUFcWXXw9PJoO/I7XMo7ngcxPG0A 0qgTUbknsGi3as/uoTS/AJdecefZ82mLCFZ4Fx/Y0BcL2Q0TdY2MkqDdwtliHYfMWYpm Z8fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kPR+h/6eM3ZX03Np34xb39M/9vUCOohBgw0tAFYVvnI=; b=09U6kD88vm21R18m6DG613/Ks0d/qC5dcYs4iRTXAVWONdA8U1lMFs1grwgc+Quipa gSZaDPpuvwTlKwX3Wl5pvHYUBVV1k1vhuaaRVrby3ckCqo6eGsIty1rUE0ktonkURM1i w1Fg94GtmRo4soPoYuao/80gh3kqQVGiRstlLQTOHFWYkHwwgSglObqyN5+lOOOlghXJ LHV6pcAn2463wPcAkAd7/AOTx3pnpN6Yu9WfVWBrQLo1JnG4uHmg57eRcjfw8csNuukB zbukwtaoydy5PksADwsgpDx6j3Cnsc8rsKucD9/3/NllPZcEYujb9/+8LWdnOCzUUHrH aHdA== X-Gm-Message-State: AOAM530Ylkrqcbl4eg12OgTEl8XngWr2oeCJE3jHACDqZy24+3zv4Sk/ TH2b94brq7XH6dSU8+S3Pqqz8Q== X-Google-Smtp-Source: ABdhPJwifFC0iTsTwueKnvIl8ODRc0aF//CslFuTXsMtJAk4sgpmd+AnEWyhwpfRTCFq/rxKEA2hrw== X-Received: by 2002:a05:600c:4f53:: with SMTP id m19mr4826223wmq.118.1634636190220; Tue, 19 Oct 2021 02:36:30 -0700 (PDT) Received: from blmsp.lan ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id o23sm1765765wms.18.2021.10.19.02.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 02:36:29 -0700 (PDT) From: Markus Schneider-Pargmann To: Zhang Rui , Daniel Lezcano , Matthias Brugger , Rob Herring Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fparent@baylibre.com, khilman@baylibre.com, Markus Schneider-Pargmann Subject: [PATCH v2 4/4] thermal: mediatek: add MT8365 thermal driver support Date: Tue, 19 Oct 2021 11:34:04 +0200 Message-Id: <20211019093404.1913357-5-msp@baylibre.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211019093404.1913357-1-msp@baylibre.com> References: <20211019093404.1913357-1-msp@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_023632_245265_8747CAE1 X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Fabien Parent mt8365 is similar to the other SoCs supported by the driver. It has only one bank and 3 sensors that can be multiplexed. Additionally the buffer has to be enabled and connected to AUXADC similar to the V2 version but at a different register offset. That's why I added three new configuration values to define the register, mask and bits to be set to be able to use it for both V2 and mt8365. Signed-off-by: Fabien Parent [Added apmixed control register logic] Signed-off-by: Markus Schneider-Pargmann --- Notes: Changes v1 -> v2: - Use of ARRAY_SIZE to avoid NUM macros. - Remove (void*) cast. - Use macros for mt7622 buffer_ctl operations. drivers/thermal/mtk_thermal.c | 90 ++++++++++++++++++++++++++++++++--- 1 file changed, 84 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index af6cd11eb221..fc4ea58d00ec 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -31,6 +31,7 @@ #define AUXADC_CON2_V 0x010 #define AUXADC_DATA(channel) (0x14 + (channel) * 4) +#define APMIXED_SYS_TS_CON0 0x600 #define APMIXED_SYS_TS_CON1 0x604 /* Thermal Controller Registers */ @@ -212,6 +213,8 @@ enum mtk_thermal_version { #define MT7622_NUM_SENSORS_PER_ZONE 1 #define MT7622_TS1 0 #define MT7622_NUM_CONTROLLER 1 +#define MT7622_BUFFER_CTL_MASK ~0x37 +#define MT7622_BUFFER_CTL_SET 0x1 /* The maximum number of banks */ #define MAX_NUM_ZONES 8 @@ -245,6 +248,14 @@ enum mtk_thermal_version { /* The calibration coefficient of sensor */ #define MT8183_CALIBRATION 153 +/* MT8365 */ +#define MT8365_TEMP_AUXADC_CHANNEL 11 +#define MT8365_CALIBRATION 164 +#define MT8365_NUM_BANKS 1 +#define MT8365_TS1 0 +#define MT8365_TS2 1 +#define MT8365_TS3 2 + struct mtk_thermal; struct thermal_bank_cfg { @@ -271,6 +282,9 @@ struct mtk_thermal_data { bool need_switch_bank; struct thermal_bank_cfg bank_data[MAX_NUM_ZONES]; enum mtk_thermal_version version; + u32 apmixed_buffer_ctl_reg; + u32 apmixed_buffer_ctl_mask; + u32 apmixed_buffer_ctl_set; }; struct mtk_thermal { @@ -386,6 +400,25 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; +/* MT8365 thermal sensor data */ +static const int mt8365_bank_data[] = { + MT8365_TS1, MT8365_TS2, MT8365_TS3 +}; + +static const int mt8365_msr[ARRAY_SIZE(mt8365_bank_data)] = { + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2 +}; + +static const int mt8365_adcpnp[ARRAY_SIZE(mt8365_bank_data)] = { + TEMP_ADCPNP0, TEMP_ADCPNP1, TEMP_ADCPNP2 +}; + +static const int mt8365_mux_values[ARRAY_SIZE(mt8365_bank_data)] = { 0, 1, 2 }; +static const int mt8365_tc_offset[] = { 0 }; + +static const int mt8365_vts_index[ARRAY_SIZE(mt8365_bank_data)] = { VTS1, VTS2, + VTS3 }; + /* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 @@ -460,6 +493,39 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .version = MTK_THERMAL_V1, }; +/* + * The MT8365 thermal controller has one bank, which can read up to + * four temperature sensors simultaneously. The MT8365 has a total of 3 + * temperature sensors. + * + * The thermal core only gets the maximum temperature of this one bank, + * so the bank concept wouldn't be necessary here. However, the SVS (Smart + * Voltage Scaling) unit makes its decisions based on the same bank + * data. + */ +static const struct mtk_thermal_data mt8365_thermal_data = { + .auxadc_channel = MT8365_TEMP_AUXADC_CHANNEL, + .num_banks = MT8365_NUM_BANKS, + .num_sensors = ARRAY_SIZE(mt8365_bank_data), + .vts_index = mt8365_vts_index, + .cali_val = MT8365_CALIBRATION, + .num_controller = ARRAY_SIZE(mt8365_tc_offset), + .controller_offset = mt8365_tc_offset, + .need_switch_bank = false, + .bank_data = { + { + .num_sensors = ARRAY_SIZE(mt8365_bank_data), + .sensors = mt8365_bank_data + }, + }, + .msr = mt8365_msr, + .adcpnp = mt8365_adcpnp, + .sensor_mux_values = mt8365_mux_values, + .version = MTK_THERMAL_V1, + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON0, + .apmixed_buffer_ctl_mask = ~(u32)GENMASK(29, 28), +}; + /* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 @@ -514,6 +580,9 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .adcpnp = mt7622_adcpnp, .sensor_mux_values = mt7622_mux_values, .version = MTK_THERMAL_V2, + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1, + .apmixed_buffer_ctl_mask = MT7622_BUFFER_CTL_MASK, + .apmixed_buffer_ctl_set = MT7622_BUFFER_CTL_SET, }; /* @@ -958,19 +1027,27 @@ static const struct of_device_id mtk_thermal_of_match[] = { { .compatible = "mediatek,mt8183-thermal", .data = &mt8183_thermal_data, + }, + { + .compatible = "mediatek,mt8365-thermal", + .data = &mt8365_thermal_data, }, { }, }; MODULE_DEVICE_TABLE(of, mtk_thermal_of_match); -static void mtk_thermal_turn_on_buffer(void __iomem *apmixed_base) +static void mtk_thermal_turn_on_buffer(struct mtk_thermal *mt, + void __iomem *apmixed_base) { int tmp; - tmp = readl(apmixed_base + APMIXED_SYS_TS_CON1); - tmp &= ~(0x37); - tmp |= 0x1; - writel(tmp, apmixed_base + APMIXED_SYS_TS_CON1); + if (!mt->conf->apmixed_buffer_ctl_reg) + return; + + tmp = readl(apmixed_base + mt->conf->apmixed_buffer_ctl_reg); + tmp &= mt->conf->apmixed_buffer_ctl_mask; + tmp |= mt->conf->apmixed_buffer_ctl_set; + writel(tmp, apmixed_base + mt->conf->apmixed_buffer_ctl_reg); udelay(200); } @@ -1070,8 +1147,9 @@ static int mtk_thermal_probe(struct platform_device *pdev) goto err_disable_clk_auxadc; } + mtk_thermal_turn_on_buffer(mt, apmixed_base); + if (mt->conf->version == MTK_THERMAL_V2) { - mtk_thermal_turn_on_buffer(apmixed_base); mtk_thermal_release_periodic_ts(mt, auxadc_base); }