From patchwork Thu Oct 21 12:18:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiabing Wan X-Patchwork-Id: 12574853 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879E8C433EF for ; Thu, 21 Oct 2021 12:20:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 561F36135F for ; Thu, 21 Oct 2021 12:20:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 561F36135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yRh7KfQ/mAJ7Oo/s1n985xRsfYqz26TGa7W2dubdMh0=; b=FdJxSqbxZvlPGm oPEs/FmUc1QfHQjoa4k6BbwZl7kWGGpndvyl0MfADIyG6+ciPO81kkkkUx3qOjw1NFRRm6eartkTy NSdGgC8DV5DoXF68hbTl7/ANKe0gTyMmEASTgbzT67n9uW7ncoBdfqW2joonGXNsizukw5ghbfe7Z wUNAcWfYU/EYw9Me57ANQkdGM7eNJLzj7XKu3rQz8mn63yvR/1NSqPkIGsbhH9wPm6Uh7X3VGSBqX N1tGeA6ljiFIPbLd8nEvgKNDDJ59ORjvYSAKx9C2+68e03zqk2OG3gKykVt0rRAo9anrN4cWoTslc j0Jdtg5AE5FD3TrHSBtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdX2G-007RcC-Sd; Thu, 21 Oct 2021 12:19:05 +0000 Received: from mail-eopbgr1320090.outbound.protection.outlook.com ([40.107.132.90] helo=APC01-PU1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdX2D-007Rbg-IM for linux-arm-kernel@lists.infradead.org; Thu, 21 Oct 2021 12:19:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PibFH96BpkHsLXtC5jSmukuefQiFdaN84pVHYjbDwnhpEUFGLJMXObw4e7qDrkXUQcVhI8f8nMdVX0TW6cquscETBGJFVGdsDm1534X091bnydUOXXcfyrKGJU/TbQMknxrQVc4OJvVHBz5/ogrf9nKZjNobrA91te0SmUt32PDwt86+S2DEF84yS1YojUXkr175qUQU4YOqNZJcIaRbUtUlpdBIYBte9VKTt//xQM+ElreQnZ4/8f5k5HOYVPw25uaxec7iIaXtjKRdiS1I+1wRMK2C8otjY3DwC3Kjs7XfVepxTOl3p4VsY6nz3+LeKHUNxPsQFfviOPS0iYRTVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gg1DKBKbx6Dp6ZpamFMafV2FR4uocIao9rF73lqP7n4=; b=Bu23FDKObkM8JLp2TcwUC3YKZsB55uyMdMS/t+kDmmpoh2rl+X4PAOeXY1dYiRJqNlJnQOaz5VEUMOptAmM04QngX6+zL+OKq0Acld0nu8IsI6bOG16cYkPijR6P0vtnea2NqV2W0AhrxP8m0CAVLFzcTUJ+er4Oze3ez+GL5Oao8OLpkkiYaDqtPGk/HjICmIXXqeNilzJqzdc6HnCl4eubTHfShWPvwj++6WOKD55VChonWLvqGUTjhLOQRpRXseF6n5Cw0lbo86fJ23JR10erTgWXsLWkNtPaiX4NfZQvn85JSBafobnd3ftEWZoBOQruEdfFh70zrpA3CjatIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gg1DKBKbx6Dp6ZpamFMafV2FR4uocIao9rF73lqP7n4=; b=ov21w0Q/lFxiFGV/iUx2q3eWchMMh9mWvFOEH6CDzv8Ek2We2b4ua2Ve2tdeDk8q9ViIeAj/4SZy+UKVPrA0NvzbtpmJ9Ji4ZUO5yNEN+Sedd6iAv22g3xOXog3NM8L9BIB2KwrgT7ExCMKtuDPxuWFm/2BC3KWBlmvWjZ+Tg3c= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by SG2PR06MB3727.apcprd06.prod.outlook.com (2603:1096:4:d9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct 2021 12:18:43 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::fc12:4e1b:cc77:6c0]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::fc12:4e1b:cc77:6c0%6]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021 12:18:42 +0000 From: Wan Jiabing To: Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , Fabrice Gasnier , Olivier Moysan , Mauro Carvalho Chehab , Xu Wang , Ahmad Fatoum , Wan Jiabing , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net Subject: [PATCH v2] iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc Date: Thu, 21 Oct 2021 08:18:23 -0400 Message-Id: <20211021121826.6339-1-wanjiabing@vivo.com> X-Mailer: git-send-email 2.20.1 X-ClientProxiedBy: HK2PR02CA0191.apcprd02.prod.outlook.com (2603:1096:201:21::27) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 Received: from localhost.localdomain (218.213.202.190) by HK2PR02CA0191.apcprd02.prod.outlook.com (2603:1096:201:21::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15 via Frontend Transport; Thu, 21 Oct 2021 12:18:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f69f6b86-b303-4a05-6543-08d9948cebec X-MS-TrafficTypeDiagnostic: SG2PR06MB3727: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0XUnmcxkwa15Nga4HHOttigCQjd+GPjg/GtPWwx+o5CP368DS+Rz1aILn9lOJcnZVLwCcv4S7XFEqnPKK3gE8ghLllb3HS3BsTQMYw5r5wpKRtRBaD3V+rAqiJ3WP8RAhbn1jfil/IvG7d6N58qf68rJzNkDxWXtpDxPQdzldRdWISWe1WM91d01naukz4H4PQxfjmnRsA6gJt/vl+c5wyD2wi2xkwHQ37Y8BXlVpi90qsSltdo8kFvTzr948QAaAicvtbJ/ODdrKbwHb7yi/WBRnxmkcTHhdh26II6RxoRkd37vN1YubdlMeM0lvOCbUVmsAJdvUwpBTDNsocqtxczxNFtXiMzeZNX2v9gwDza+IHpM64lbnW7b58I6vGoIqasFxKDd9FFMqaXail+EI6jyT/dccELSo1Y9hgaq9cRH254u0OeGAjdNwzee3dFxwkjWwIP3CAjlt8UIjr61pw5tC3RRYjq2/hbdVitfJk02WJLAddjc+MpjpPuIZN1thbBvwR/Rq/pLVKuTVZCYRiSOa7qyyaj3p4iU8zGtXdQ4IUBiiy0xyvb2/fKoCIfZ6JD+qirR9nwPrDcp+zNhZJR5YFY5ytSbpA2w+91UyWIUeB1ZhzaaSmeBhi7xgg3w91iJTXct6kaytKswETXLFs8mkqHTMaS74HmEcUfqtB19BdF5dL2TSIjCdu9HaUTrg/HF5RmmC+n1Tnvz7hnVgJst8OggJMEWkioEqRICg/8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SG2PR06MB3367.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(110136005)(2906002)(36756003)(316002)(26005)(2616005)(186003)(66946007)(66476007)(6486002)(66556008)(83380400001)(52116002)(956004)(508600001)(38350700002)(38100700002)(1076003)(6512007)(6506007)(8936002)(5660300002)(4326008)(7416002)(86362001)(6666004)(921005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DB1Jy4r89lc9BJkZ5o3vqXjc/9HIBXo/ZzKYtXH0YHmZm1QqvBlqt4m+J27Z2canYFQ8Tc2x/v657MuUgbGSbcoIEyRJPofamwoaC0g64xMcBcoZoXF6xnxNmp1MLxD+80fCSVCeBl+qcjs+KQs8AIAvDHgz+dPLCVMFM1mnyIjGO116qVUaYVGlyd0clAOACl7sARlBGSiIkiNqBQZlgOIF3UdfSXkhriWttU4aUPgUbdip5LAg2CBSaZQVPd1AGjmigqOGsCsyJHRg+xm+evShhbZkhg3e6mHvocuLESQLJoMXZFVhptXjsYZQmmESfHc5F7sEYmozSjFgR7Z17kGjOxsbDxVdg0nCIF5JgBM7JaQgGUN7KktJKINhHpHJM6BdJXyHlVbmycOk5ZGEPASVbGAdUgbyyvOXnZ6uYf846QwUAYNaYktv2g1QOehybHjgEAH0g+/oJFwQVTKCpGIWAoOqXHZWfwCrwbT9whddp7V7u7/GWTfSI8hDNK7qwhSt3Gfp2jheKAhVfgHUd30PBJ/N9vn77vV2Byre8N1fYIJZEAmAaRsBckt3FGZNaAlQzMOFyhT22uXd01Cadt96WgZIt/b8lejSxE2mR9X0NFACqj8VPkhw9x0oX1km6bToRhAFThWi2bGWncgiS0W3KO2g2ED30s9/fNXY3+1HgLzbHvsQCHrqQhr1g7Ds1gSv1Ik4pAF5kSDr7z/VYJqQE6X+X3nJc/5P2mZNO3piO7ocjaBXgSNgGJYzPAwM4acVeu703Uc0IOroTd9vjBug4rv416PfvA1qr+/hXWStIYgtVJeqwxE5C6tMFt/5j2Y/7ABP8nDecqegwfZsRzxCrvkGd0/C0dBUoCj94lBkXVhNALmhMNkEKBJcpz6Dt0AU1yw5oXaJbafds5mqZuDsBR8Kpuosrn0Ywt/+7YvMPbTOeWrQ9nG0E/r7lb7NTMSe9g7KDDUQXJpwMJ43ud8X4oQOfjsM5yQmVZjTOUQ6uA5oLXK4VgiB8oZmUrAgdHQuH4fM8nn3mCr1rTaMAnNMq6hv3u3vey4u88LSsXLOkWAMLknVI3uGYr+s0JkwYWD6IAZIjFTmrTlVZNQXcwT0qy/tZt0rRRtaFHYl6+YDW2uIjTmT2jOxuDco/nTdVhsgNex9M4MoJWt6DjB/ftxjFP/JvAWr573EgwqADYzRqDL0gMOJP2w0uZlRMtbXLM5BhxvUp4Y/gzxldNU0+rprDh3O/BP9N8sQBO2xOpMFXvGMwtBeSWtwalzzY4mdueW1C85nNd43vEwFIlCyWtDqGoRutENtzKEVNN2tJBJoELVAlSHyiWFTBgKqp0Pkki25wuOwZvuT3QFyN4TcWsJeN9nWyjYyvgk3qkwO1arUASsE3Nfe42fLRr19JzEzGnbYu/d8PeLoqoQgNFxb+KTWoU0DAOylLepFVVxO4ts= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f69f6b86-b303-4a05-6543-08d9948cebec X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 12:18:42.6275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 11126903@vivo.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3727 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_051901_619098_AF48FF8A X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix following coccicheck warning: ./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before return. Early exits from for_each_available_child_of_node should decrement the node reference counter. Repalce return by goto here. Reviewed-by: Fabrice Gasnier Signed-off-by: Wan Jiabing --- Changelog: v2: - Fix typo and add reviewed-by. --- drivers/iio/adc/stm32-adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c index 6245434f8377..7f1fb36c747c 100644 --- a/drivers/iio/adc/stm32-adc.c +++ b/drivers/iio/adc/stm32-adc.c @@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev, if (strlen(name) >= STM32_ADC_CH_SZ) { dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n", name, STM32_ADC_CH_SZ); - return -EINVAL; + ret = -EINVAL; + goto err; } strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ); ret = stm32_adc_populate_int_ch(indio_dev, name, val);