From patchwork Mon Oct 25 07:28:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christian_K=C3=B6nig?= X-Patchwork-Id: 12580889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9601C433EF for ; Mon, 25 Oct 2021 07:28:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97C5260F4F for ; Mon, 25 Oct 2021 07:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 97C5260F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B69CF89C69; Mon, 25 Oct 2021 07:28:40 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE48589C69 for ; Mon, 25 Oct 2021 07:28:38 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id k7so6397228wrd.13 for ; Mon, 25 Oct 2021 00:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/KnA63M6s12GSIiSZQ+VKmCZZ5SYH2ewEjUZZjZe3Dc=; b=V9/H9rFq07ZWu9X7sZOr17KADFhWpONR9njdMHofDF0MAqTMBCHW22mgtNzDxQhppi JeEgcN00e/tjSoNtG7GKCavuwnUBcnbWrOiFi1DBgtDVeN67I3wJ2MonlmSrpzP9ZwTZ D+TfK/WwHVI71NvelC6iPIVHS95hRwMTnLCT17HxyOAsRdb22H84VnvrhDwDR+m+h20L 0IT99fXL7kzAWBguwncJzftbcai/TWcs/qsy7T1Hcpj1VmGcqff3PvnhtU/bHbeU3/tD xq+Kvn9EfIOp5e8bJF7GggSi+CPgDJoMnvgmnRDyJrQY81wOwwj9kURPziUJc+Xu0Aec blSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/KnA63M6s12GSIiSZQ+VKmCZZ5SYH2ewEjUZZjZe3Dc=; b=MhYlkt9WBcAleVTkV2nvFQQ620EQvSrZC3kakMiAvbYCDBEMuaooQEGLDwVTuCnBQQ 2k68wNWzm7QqH2YruCy9XIztaI88vpkq4hfQyiqECH4FogFxVd0+glvXKeVwGVZ6bDVd oGt1oGhuHXD17ZEMJQhvvlKJyG7h+13DurcpAN28w1dJFw9oolxpffmDZJPeCDNMH1a0 B7PR/S6bywRnoBFLE54nHCXlEWmw7vKmDBjwQjJRkEH9P4xJIvVSxgiB/2/hOONrT854 P9mxUGirYs8M9Y7bt0krPYuUdu5njRggKmPdsjcHt+m3cMIBCoz5c7T8NaTlVo003ncO Gn3w== X-Gm-Message-State: AOAM5330XOcG4KPpSvPtSC67IpUmFXABflM+lv/LLquQSGdB9Ww6WWOr a95Jz4KdUuBjFlf6zW7Gg6SP4aqUqXU= X-Google-Smtp-Source: ABdhPJwD5z0c2YhOxWRJbhrUSUEniMr4DJ/fSnDBawSJsXVSVYbSDIwE/IICnKlX4m6YPSo9VC48Hw== X-Received: by 2002:adf:8b41:: with SMTP id v1mr21337216wra.255.1635146917527; Mon, 25 Oct 2021 00:28:37 -0700 (PDT) Received: from abel.fritz.box (p5b0ea1b5.dip0.t-ipconnect.de. [91.14.161.181]) by smtp.gmail.com with ESMTPSA id f7sm14089322wmg.14.2021.10.25.00.28.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 00:28:37 -0700 (PDT) From: " =?utf-8?q?Christian_K=C3=B6nig?= " X-Google-Original-From: =?utf-8?q?Christian_K=C3=B6nig?= To: dri-devel@lists.freedesktop.org Subject: [PATCH] dma-buf: fix uninitialized variable usage in selftests Date: Mon, 25 Oct 2021 09:28:35 +0200 Message-Id: <20211025072835.176805-1-christian.koenig@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" "i" can be used uninitialized in one of the error branches. Fix this. Signed-off-by: Christian König Reported-by: kernel test robot Acked-by: Alex Deucher Reviewed-by: Nathan Chancellor --- drivers/dma-buf/st-dma-resv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/st-dma-resv.c b/drivers/dma-buf/st-dma-resv.c index 6f3ba756da3e..bc2265807f6c 100644 --- a/drivers/dma-buf/st-dma-resv.c +++ b/drivers/dma-buf/st-dma-resv.c @@ -295,7 +295,7 @@ static int test_get_fences(void *arg, bool shared) if (r) { pr_err("Resv shared slot allocation failed\n"); dma_resv_unlock(&resv); - goto err_free; + goto err_fini; } dma_resv_add_shared_fence(&resv, f); @@ -336,6 +336,7 @@ static int test_get_fences(void *arg, bool shared) while (i--) dma_fence_put(fences[i]); kfree(fences); +err_fini: dma_resv_fini(&resv); dma_fence_put(f); return r;