From patchwork Mon Oct 25 12:45:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 12581745 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B8FC433F5 for ; Mon, 25 Oct 2021 12:37:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AEFC660551 for ; Mon, 25 Oct 2021 12:37:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEFC660551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F3B6B6B006C; Mon, 25 Oct 2021 08:37:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC42A6B0072; Mon, 25 Oct 2021 08:37:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8AA66B0073; Mon, 25 Oct 2021 08:37:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id C67B96B006C for ; Mon, 25 Oct 2021 08:37:10 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7C45E31E6B for ; Mon, 25 Oct 2021 12:37:10 +0000 (UTC) X-FDA: 78734909820.18.AD75E25 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf28.hostedemail.com (Postfix) with ESMTP id 9E55A90000A7 for ; Mon, 25 Oct 2021 12:37:09 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HdDqZ1VkwzbnQQ; Mon, 25 Oct 2021 20:32:26 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 25 Oct 2021 20:37:03 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 25 Oct 2021 20:37:03 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] mm/damon: fix error return code in damon_reclaim_turn() Date: Mon, 25 Oct 2021 20:45:00 +0800 Message-ID: <20211025124500.2758060-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected X-Stat-Signature: pqja15zpecn6ie5fcqxk6c83gstkcx5w X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9E55A90000A7 Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of yangyingliang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yangyingliang@huawei.com X-HE-Tag: 1635165429-508828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If damon_reclaim_new_scheme() fails, it should return error code in damon_reclaim_turn() Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: SeongJae Park --- mm/damon/reclaim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index f5ae4c422555..dc1485044eaf 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -292,8 +292,10 @@ static int damon_reclaim_turn(bool on) /* Will be freed by 'damon_set_schemes()' below */ scheme = damon_reclaim_new_scheme(); - if (!scheme) + if (!scheme) { + err = -ENOMEM; goto free_region_out; + } err = damon_set_schemes(ctx, &scheme, 1); if (err) goto free_scheme_out;