From patchwork Wed Oct 27 11:31:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yanteng si X-Patchwork-Id: 12587049 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0F2C433FE for ; Wed, 27 Oct 2021 11:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A3136103C for ; Wed, 27 Oct 2021 11:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241653AbhJ0Len (ORCPT ); Wed, 27 Oct 2021 07:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241655AbhJ0Lem (ORCPT ); Wed, 27 Oct 2021 07:34:42 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA2AEC061570; Wed, 27 Oct 2021 04:32:17 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id o83so3007774oif.4; Wed, 27 Oct 2021 04:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ulhn4KODo+M8bQOCOaLaS+XZsUOCyPb8RqRWLn0FhBo=; b=NdNt/0mG63IMHrYdKrGRchjJA3NLl73blNkn2CLJ9iW1ZGGJ4MjZszel2piHsEUbqg fgJkDpG5l92TH9cRhCifTd3dJGqR9XvpH/s3lIz3TJQYunHu+bpJkkR5GyuJd4glmzNB MoeygbQ1FmfFSAd4XsZFnkJEpN7S5ohnzRxB9oy340onnnsQ92ug9E0NfVPwaQJM0p2H fkA00Po14HGp91tFWr71+2Cx+EFhyptZPPomx/++zsiPJDHj0OyNQiAhrUB2d5MZ5Lxs WeuOdKgc5Qki/ja4jIgfWIws7UAV5wdOydVxdhtqR8zZuXLxcC8AsaXp5v7b3N5g/F9w Rxzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ulhn4KODo+M8bQOCOaLaS+XZsUOCyPb8RqRWLn0FhBo=; b=oNLyE/51ITDO5ZbvQDrwjFXKq1FqbN+HPe1UFYhFMgKaVfzmx6ytrN/8sQ9I5Fq1CT 9AHOuklk2LFJabcSSgARp8AaHUWej07ON+6b5e4SK0fVRW85E5vgAq+cuaf7iTarA2+E OHRoWdWgGa7JHB320XhsiY0hGC9XA4I+fW5cYECaSp2dPMbN/oDufjXy9F0wdc2sdkMZ JGtgxV05jDu7VyR4/SoM1B3PwROQPrPuBe46Pi+5Qr27RWkAEDFh1qE5BnXOxm3enOoj fu5c1UU5uAd9Ij0c3s3zkGky8pED0lpfkFrNBL5ytZVIxQNeq/dTWS/KhyVU1C3R+qjc k8Jw== X-Gm-Message-State: AOAM533/H6QXA09akBnGNvdEp/JkfwZiZcQQ6YfzrgdZevJCFm/FB047 bG3NLV8pnVf7Fpm51yjT2nc= X-Google-Smtp-Source: ABdhPJyDtqXolJD9smrK9+TJiNjHaGA863agytaUNdu/NWWpgx1LiqcUGcw3mrk5rjhk7cXU0TEVEg== X-Received: by 2002:aca:3343:: with SMTP id z64mr3098600oiz.100.1635334337149; Wed, 27 Oct 2021 04:32:17 -0700 (PDT) Received: from localhost.localdomain ([8.26.182.170]) by smtp.gmail.com with ESMTPSA id e23sm5430106oih.40.2021.10.27.04.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 04:32:16 -0700 (PDT) From: Yanteng Si X-Google-Original-From: Yanteng Si To: sergio.paracuellos@gmail.com Cc: Yanteng Si , lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, matthias.bgg@gmail.com, p.zabel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, chenhuacai@kernel.org, sterlingteng@gmail.com Subject: [PATCH 1/2] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver Date: Wed, 27 Oct 2021 19:31:39 +0800 Message-Id: <50f5f509c15251fb10b0c87304d272e2c89841f0.1635333327.git.siyanteng@loongson.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") the MT7621 PCIe host controller driver is built as a module but no MODULE_*() attributes were specified, causing a build error due to missing license information. ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o Fix this by adding MODULE attributes to the driver. Signed-off-by: Yanteng Si Acked-by: Sergio Paracuellos --- drivers/pci/controller/pcie-mt7621.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c index b60dfb45ef7b..668b737f86fb 100644 --- a/drivers/pci/controller/pcie-mt7621.c +++ b/drivers/pci/controller/pcie-mt7621.c @@ -598,3 +598,5 @@ static struct platform_driver mt7621_pci_driver = { }, }; builtin_platform_driver(mt7621_pci_driver); + +MODULE_LICENSE("GPL v2"); \ No newline at end of file From patchwork Wed Oct 27 11:31:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yanteng si X-Patchwork-Id: 12587051 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C48C433FE for ; Wed, 27 Oct 2021 11:32:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32507610A0 for ; Wed, 27 Oct 2021 11:32:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241656AbhJ0Les (ORCPT ); Wed, 27 Oct 2021 07:34:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230336AbhJ0Les (ORCPT ); Wed, 27 Oct 2021 07:34:48 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F86C061570; Wed, 27 Oct 2021 04:32:23 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id o83so3008114oif.4; Wed, 27 Oct 2021 04:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kxnEh8qDpD3iOItAOuA1sNXr05vu5xRHywG7hStSzyY=; b=et5L9NEnejyIEGEiArFB9FLsIUGc9E6M2ykMKP8cUHxmtWWzQi8HPIaUhGmPly3ekg qPq2V/CPTW6nlwXzJTMjpkWHZIEfW9GO98NyOuEk9hTQvXfd2AH/rEEacXionCwTbIns 2wPxeLfhPiW7p96jDtMBAd/6ArqoPxPXOFP94j++YUjq9EICFvurwVGNPxUue4GQepeb XdqfClaaQoQHaWsCeR7TQtSzrpJgq6kNcdY8KmyjhD2GwehmjJj9i1HIiLTKwDiav4Xu BNkeRCqT99mRfLSn/8Pn7Fqzg2bN/vu4XfmHAIeTrtne9d7Zb3EuUIZM76u2VIbDB7BM WQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kxnEh8qDpD3iOItAOuA1sNXr05vu5xRHywG7hStSzyY=; b=Jj9jngoPc4HHX5EuStp8XYxP5Sx8i8+TkbQwefihVnMANC7oYikknId7PrhIQBfNrs KdGsNGYAo8xpcvldbIWNeZeqHB7gkc7JhGa7tEkRj62ZbRNhufG6UrEuiDQm1X/dw6iC Ahdxsbez6A60JHj3YrbUxC1zHQgCBVqe/SkGtVROxuVq7Szy9+MCQE4z9wHi9ubv/37d 2Hd+wM8OkV+YuX4YUegnT1OGrZepUXRg4H0F/KuqPymopLcw86QfJJ/ajh6BgF8tNDCu s0rDtGTkkUStJuViXEpHU7/eXisOvBUrA0NUkiqrlUg9xEzRAEVys8jxiBa/TgUB/aI1 m4ig== X-Gm-Message-State: AOAM530lqfoW+c9YU/+3WytnVx4Eu+UbdDCONG53DLVTB49Unbony1YI //nAzHjDr5L0/OV8crjBEO4= X-Google-Smtp-Source: ABdhPJz7y8144DGSg9tx87fxTtRWoMAHMm0FTUttcN539FMIs7jp7wK8pUrJKxA9JIdJZseZMkX37g== X-Received: by 2002:a05:6808:21a1:: with SMTP id be33mr3107402oib.161.1635334342419; Wed, 27 Oct 2021 04:32:22 -0700 (PDT) Received: from localhost.localdomain ([8.26.182.170]) by smtp.gmail.com with ESMTPSA id e23sm5430106oih.40.2021.10.27.04.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 04:32:22 -0700 (PDT) From: Yanteng Si X-Google-Original-From: Yanteng Si To: sergio.paracuellos@gmail.com Cc: Yanteng Si , lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, matthias.bgg@gmail.com, p.zabel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, chenhuacai@kernel.org, sterlingteng@gmail.com Subject: [PATCH 2/2] PCI: mt7621: Export mips_cm/cpc/gcr_* to modules Date: Wed, 27 Oct 2021 19:31:40 +0800 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org modpost complains once these drivers become modules. ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! Let's just export them. Signed-off-by: Yanteng Si --- arch/mips/kernel/mips-cm.c | 5 +++++ arch/mips/kernel/mips-cpc.c | 1 + 2 files changed, 6 insertions(+) diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c index 90f1c3df1f0e..b07f20323132 100644 --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -12,8 +12,11 @@ #include void __iomem *mips_gcr_base; +EXPORT_SYMBOL(mips_gcr_base); + void __iomem *mips_cm_l2sync_base; int mips_cm_is64; +EXPORT_SYMBOL(mips_cm_is64); static char *cm2_tr[8] = { "mem", "gcr", "gic", "mmio", @@ -353,6 +356,7 @@ void mips_cm_lock_other(unsigned int cluster, unsigned int core, */ mb(); } +EXPORT_SYMBOL(mips_cm_lock_other); void mips_cm_unlock_other(void) { @@ -369,6 +373,7 @@ void mips_cm_unlock_other(void) preempt_enable(); } +EXPORT_SYMBOL(mips_cm_unlock_other); void mips_cm_error_report(void) { diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c index 8d2535123f11..dfd3d58fd412 100644 --- a/arch/mips/kernel/mips-cpc.c +++ b/arch/mips/kernel/mips-cpc.c @@ -13,6 +13,7 @@ #include void __iomem *mips_cpc_base; +EXPORT_SYMBOL(mips_cpc_base); static DEFINE_PER_CPU_ALIGNED(spinlock_t, cpc_core_lock);