From patchwork Tue Nov 2 11:30:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 12598707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3D3C4332F for ; Tue, 2 Nov 2021 12:23:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EAC66109D for ; Tue, 2 Nov 2021 12:23:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EAC66109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhsp1-0002Ys-4i for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 08:23:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhs0B-0006MS-Lp for qemu-devel@nongnu.org; Tue, 02 Nov 2021 07:30:51 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:43624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhs08-0003yr-Nc for qemu-devel@nongnu.org; Tue, 02 Nov 2021 07:30:51 -0400 Received: by mail-wr1-x42a.google.com with SMTP id t30so7925310wra.10 for ; Tue, 02 Nov 2021 04:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5yNSJwwNFQr1nM3JfKLj4t6lpvOSUbaXW100csvtVKw=; b=SkdYyBM0Fb6xjY0LWdpAUA8O8GY5+eM57+YNEPvxkZh1NVv7uNH61x8HRULtsOYdUc iPwpNpxfBxdMTqBG89KPZx9BskQpWfgBNTpoo2/y7pMscoFV67TTrJrzcEZP0PjKd+jE wk5dfCbi5+q+8WAcJLGWygb2i/s9dC6124FYd0OeMxinvfXXDDtg3nhO40i6kYrb5JAm UAI/+7WTNZdSvSN71ZxE9NUBjD/U2v1BE5X5wzFxPC66NpgaPpNpOhJwZEWDnsiNenFv sx9fUqXBGmbMXhoiaDoX733Bp/0IAELqGxKPxuZBcoBk89scz7B2U1Yk0jl9sAtHdwLr U5Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=5yNSJwwNFQr1nM3JfKLj4t6lpvOSUbaXW100csvtVKw=; b=ZT2f1+1EQL+SV8XTgeiRIcGXb2HuK45YV0ndM1LD2hQ2CuktylDmldGtBrKiINRx/L 8uI0qaG8oRcxAax99/C5Khf7ZpB3+RkAhsIaafr1uUzLHhDzvIbM43RU87fwP+jLpLmR baNMGrjVOhgaHu97yNRYOtEl9ofk9DOFegfGKx8J4+djqsvqeGLliroaroNrVnRzb4XB ubxHetUlYQT26Z8p+2YWAcYCU8dWUeK1DknuZobV4rbcYCGlGmth0GGQhAbiP4fDB/8U wpKT2bjX5/l4vtebVA/AZFam3+uNfnt9iWBIHwBpKj8dPmxgudHa0AogXG4HHHvjUWiI 2asg== X-Gm-Message-State: AOAM53141SYjf4UMu4AQkr3YjQXTxNykp23EI2QjIkNkKaEYr7yUX8tm hvAx9YMe3yT6/YIxJcf+jbmpaMzy7ys= X-Google-Smtp-Source: ABdhPJwQdugOTHCemr9gUwCwPLMtFVQbJbQ1RptO4nADP4jmr1FgqBf1MnMY+0cbeySAX/i8lg8MGw== X-Received: by 2002:a05:6000:2ca:: with SMTP id o10mr45184313wry.383.1635852647390; Tue, 02 Nov 2021 04:30:47 -0700 (PDT) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id d7sm4750248wrw.87.2021.11.02.04.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 04:30:47 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] meson: remove unnecessary coreaudio test program Date: Tue, 2 Nov 2021 12:30:44 +0100 Message-Id: <20211102113044.204344-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=paolo.bonzini@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" AudioGetCurrentHostTime has been present forever, so the test is not enforcing a specific version of macOS. In fact the test was broken since it was not linking against the coreaudio dependency; just remove it. Fixes: 87430d5b13 ("configure, meson: move audio driver detection to Meson", 2021-10-14) Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- meson.build | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/meson.build b/meson.build index 3dadb245a8..d800b9c5fb 100644 --- a/meson.build +++ b/meson.build @@ -944,22 +944,6 @@ coreaudio = not_found if not get_option('coreaudio').auto() or (targetos == 'darwin' and have_system) coreaudio = dependency('appleframeworks', modules: 'CoreAudio', required: get_option('coreaudio')) - if coreaudio.found() and not cc.links(''' - #include - int main(void) - { - return (int)AudioGetCurrentHostTime(); - }''') - coreaudio = not_found - endif - - if not coreaudio.found() - if get_option('coreaudio').enabled() - error('CoreAudio not found') - else - warning('CoreAudio not found, disabling') - endif - endif endif opengl = not_found