From patchwork Wed Nov 3 05:04:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12600091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52878C433EF for ; Wed, 3 Nov 2021 05:08:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A42D6109F for ; Wed, 3 Nov 2021 05:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A42D6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B9B116AA; Wed, 3 Nov 2021 06:07:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B9B116AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635916078; bh=MEcaqvkVO1Spw4IWDI+6Zck9uK6F+X0X7P8PHcNiplQ=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CwCHiPxvi/eBX6XwfeKnnmh40dCILbWFKRjAiZSevQbe6djW/jLyXFBR0kZFyNmpt TC2Jx/gD/xvrtx8l0i6JwJ2OPM8RmToxPkb2GTzeofP3HX1MhDLug/S1CfskuGiYR8 TWpGpoE9qGrRodHsKahF8zOp5I519IBfkWrJs6aE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2BA1BF804EC; Wed, 3 Nov 2021 06:06:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7A824F802BE; Wed, 3 Nov 2021 06:06:16 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2082.outbound.protection.outlook.com [40.107.92.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D207EF800FA for ; Wed, 3 Nov 2021 06:06:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D207EF800FA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="q8Uacuy4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilzt9jXX6WFfYgGHj7qHK4MiEOabKl4ZEtIb6vCiAtoSLJpcLOepB3P0WpHBU2ojGHVf7OHCuwXqaPm9E5WQNV0Nbo8lOMJO/EdZL9LyxXFxLHxTUwjh7bBbRm7wpJSCGV87BwosevWNxYQ9Q3L9KEbywuehzWNmMKcQ2TBZVzCD2jzieX2/UVkeySYoZALhD0Qmt3bxQGYVG5QAplJoH3JSKRokO81AZq9R1v3PjCRp0wbgUwwdTnz/p5m9onoM1hr0szTtR9rfcVtS2Rbk2ryMNXXJ5hXOkkBiCBDReugHIYKMcAmJZYj6SSg11/oZI09AHf1eM7DYoeQOjp3E0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFiwC8SkpFk9PgpgmGvI9+Or4jCrnS/cJhXLUAHQtoc=; b=IwE9KiyMRsoQAOmL43g90Lnl+32bcefPW2oBgR49r9Zvb/grF8JdyyGIJTWTk2K+NQectN69IrQt/W3kSKMviMOwCw646RRm24SpLEJxDo2NW+egQKu6MMGe/i2zpAsGKSuj4xShjRMQ/KHRE0xSYvSYeyH/ayn4NlAlBjjtdiM7v7GZlXQMbx1UhpMv2D8qqidSypMQNTDcZJyht8cZjNiGt929wQ6Aspv8D8NZoVJz74A6vQU6MMqC/WpIlizMqvdrubvbJcIlynvdtiK3DoXoZyod80bggtxkmbh/1UTZ8n4wja2KP6Am3myq927jItkkB4MFY+WShpEMbwD5kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFiwC8SkpFk9PgpgmGvI9+Or4jCrnS/cJhXLUAHQtoc=; b=q8Uacuy46rRpuj9Bz/WOUFBdIG2b255bSInad5dKDMNk/Jqem6gD+nKH8j5Dd8LZjp0Pj1AXMsN4qOAWCBhBliYnUZwV2D63XmX0CgxqjNbX11iaOWmG1Lz41c1RmBuCqzRKMHBpihbH4SJPrmEgfEHtcE4ldK9n4uRBWUDKvvmzpjDeM8sRov3/q+NCFNZadz6xHIleQOWvI3LISNLsTTuzuPvBXJ89N7T7+XmZ6S68RWvW3n+JKdCiRxhmDUNNnmdJ59DK7Ug/recHwaOG6uWBailxzyLpfK+3txTcrQk2VAtaX5l6kEIwKSySc5l/JFYz4GasykzLV5cJcf7+ug== Received: from DS7PR06CA0050.namprd06.prod.outlook.com (2603:10b6:8:54::32) by BY5PR12MB4244.namprd12.prod.outlook.com (2603:10b6:a03:204::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 3 Nov 2021 05:06:05 +0000 Received: from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::bd) by DS7PR06CA0050.outlook.office365.com (2603:10b6:8:54::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:05 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 05:05:54 +0000 Received: from audio.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 05:05:52 +0000 From: Sameer Pujar To: , , , Subject: [PATCH 1/4] ASoC: tegra: Fix kcontrol put callback in ADMAIF Date: Wed, 3 Nov 2021 10:34:54 +0530 Message-ID: <1635915897-32313-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com> References: <1635915897-32313-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d86dd3a1-f340-410c-f99b-08d99e87a399 X-MS-TrafficTypeDiagnostic: BY5PR12MB4244: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wR6BrYAhRJ7CL5r7qFTZ1yW4E+cn8jcIA1YJmNst/AaRN20Z0oTLUG27WszmOLDBjO4xZB3HXdpV1qTsJLhEzuNyBSSYJaYENOZEKhGWQvmKSJlROCJBu2GcEtIZXz52XUfU0aqdHsCWyzsRmqQtp1JwXhjAMpG8qzeOItWgIypgLB28d/U8OY0JFDW+LmTBAjXkFAl33Q5Vrq2j0jm6q91MjBnA12/PT+CIKgNYuM8CqaPhDDPCyF6UPL/MS0JOl2lu5LjN2+8Zwej8WYhTpNblVDHEBsksgPXJBVF0gvdJ7zZIvwsuBPUNIZf18eV5QVJbgZAB451LMFl4yfGf2QLim85WkHul5UEMqybmQqj298YIHj86nyn5tAcTgSKnllL3v33FCoUcrV4zRJnpMWUUTXO13XTrqnaJZewMGynxsI2stHNmac9afXZSxSJRxeZ0gL8pOAvxqTYQkx1y5lPXhr+6whaqgSRPtK3fphX0eCa8JegbbHIUhskZcWAjJb3F4Fd0K3vSUW6BJ18k/5Kjov7jOva5rRTXRaN/uMTUc/zrHyKB//v3wnhcrSP/0pX236AQdXRYnjlmS6j4MMSk9n6v2aqtGejKmVO1ONwHAuYAoXUhUTfsOc1/jICFb77cnHTPKlTW8h80dQ55O+BJf1rJZQb/EuCtkJn9bTWqW6Ng/ZIv6zgw0EPCjhAJpekiGI8mzCNE6VQXC812BQ== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid04.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(83380400001)(7636003)(70206006)(7696005)(86362001)(508600001)(4326008)(5660300002)(8676002)(356005)(70586007)(82310400003)(47076005)(2906002)(426003)(36860700001)(36756003)(36906005)(26005)(186003)(2616005)(8936002)(316002)(110136005)(54906003)(336012)(107886003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:05.0847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d86dd3a1-f340-410c-f99b-08d99e87a399 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4244 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the ADMAIF driver accordingly Fixes: f74028e159bb ("ASoC: tegra: Add Tegra210 based ADMAIF driver") Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_admaif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra210_admaif.c b/sound/soc/tegra/tegra210_admaif.c index bcccdf3..36ba980 100644 --- a/sound/soc/tegra/tegra210_admaif.c +++ b/sound/soc/tegra/tegra210_admaif.c @@ -460,8 +460,10 @@ static int tegra_admaif_put_control(struct snd_kcontrol *kcontrol, admaif->stereo_to_mono[ADMAIF_TX_PATH][ec->reg] = value; else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) admaif->stereo_to_mono[ADMAIF_RX_PATH][ec->reg] = value; + else + return 0; - return 0; + return 1; } static int tegra_admaif_dai_probe(struct snd_soc_dai *dai) From patchwork Wed Nov 3 05:04:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12600121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD3EC433F5 for ; Wed, 3 Nov 2021 05:08:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5A66109F for ; Wed, 3 Nov 2021 05:08:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4E5A66109F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B34C71689; Wed, 3 Nov 2021 06:07:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B34C71689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635916106; bh=0Nn6nleMPwKV+7Mou8fjATp2dszaptp01WbT8Rt2nLk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KYatzK/fbwImip9Z3eq1Zj3LvoSi03kf4YeAPPzc3oOsAhXrwgSyAkfFzzcEAL219 5+0ZHCISWWlu/PZdH5xmMNaByknIBFP1zrHa/2eAQasqlo9TzN005Jv6l4x7z1FhvG a9fSA/4OeK7JqX+wKDFiiJnsDJ8g78QeuuICCu8s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5D3C8F804FD; Wed, 3 Nov 2021 06:06:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 306AAF804FA; Wed, 3 Nov 2021 06:06:22 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2044.outbound.protection.outlook.com [40.107.95.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1807FF80269 for ; Wed, 3 Nov 2021 06:06:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1807FF80269 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dtXqKRxf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIUJZZzRbj9nWo2pP08LTvvvuXYOMpXAUnXML9s2u8fOqXBUVISr72pQ0nIA5fcUzYPjVvLV2uaFPtVKMou5rvf8NB22A53sPGXghioJVRjHXpq+snUAiRL0KFPe/j4U5QspwPgBheJdbncp4qJgTNq54H0nNyhHBG1IClsKGjCRQcfakgIiwm1KEWm2u9tEknpH6ZnNhwvjOjJZs7G0WSuZKpRsSaTQdM0TU75+POqaxZedVBClLdRwnhwF9/LQc7X8ZahbUNGuKyiV2W3a0oIq5pzDpR7T6vlkhqh7gjEfAgyusSweFFqJJmcehDMTn1dTU0qzPFeHWGGMAuPDbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wfKfdezJ8Mfc/Hv6hBKDw1/i0Jrxb7Tf38wGUe6Xb/A=; b=muigjD3Uegtpupj0ohqdpSbqDMpsMF+NO+AXPFaLNXNSscOBmglUwA2dU1rmhT6MPEorJdkKhVHseE9p3Vi26YJAxRR51jDiaDS+pvuAm1WpX6qET2KO9eaRHMewlb2bZsv1Crq+1fbjML1hhlwtsoBtwRek4kDeyTOrE9WFNqK6FPcpUWXO27xeG0IX4+ACjE7y3n3YzZJa9b8ebkjOXnlJ+Y5XB/YFG82R8DflsTOcaUIr93XLIUYLAbazirO7sCpF7yGjDbYMH4Q5eO0j+X6rTQxV3IQQ38KKc9MJ5Zcp840ZI14hYj3Amv9GDnpMUYi1zAqEoxDtrGhIKvmVFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wfKfdezJ8Mfc/Hv6hBKDw1/i0Jrxb7Tf38wGUe6Xb/A=; b=dtXqKRxf+SeKMkCZ80wPgVX8q2b2oo4Nwj9VuvoFhiHTC6bLyVuCzVCsfChsuxN701tTjuDAQNzuTL534NiVKT0lGj2GLiMM3Yo5CNrmxvJ1ZAcrRZavYA76FvZdPrFVSVsf3LWOqXX+axFoPkeI6WFjnj87El38HGyDZX/R4HNXlfAgPrU2bkanxz7QpnXwhcmqtkzXJiGbL6IWUJam81PceYX+1Yv4MSyICX8f+MthXP57olagwvTqFwxcAspHtFOj+I2fMP9P86PjblAihpgUdF+mTz76ik2xFiFpdfG8/JhUmI2SMUE57xBolQX+BxYnO8xb8nkO7kMFx/0ogg== Received: from DM6PR11CA0042.namprd11.prod.outlook.com (2603:10b6:5:14c::19) by DM4PR12MB5263.namprd12.prod.outlook.com (2603:10b6:5:39b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 05:06:07 +0000 Received: from DM6NAM11FT037.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::d9) by DM6PR11CA0042.outlook.office365.com (2603:10b6:5:14c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Wed, 3 Nov 2021 05:06:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by DM6NAM11FT037.mail.protection.outlook.com (10.13.172.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:06 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 05:05:57 +0000 Received: from audio.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 05:05:55 +0000 From: Sameer Pujar To: , , , Subject: [PATCH 2/4] ASoC: tegra: Fix kcontrol put callback in I2S Date: Wed, 3 Nov 2021 10:34:55 +0530 Message-ID: <1635915897-32313-3-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com> References: <1635915897-32313-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62c2878a-8377-408f-a923-08d99e87a440 X-MS-TrafficTypeDiagnostic: DM4PR12MB5263: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fBHokq89fIhezIpQ7aNSfsSwDTqN0trMXTBvwfgd0O73d7Ph+ZvLOYtbiiNFKERNtyoURLzyBR/5LyP1ZbIR7qNnHXASE6s1FFmIyNFMRrFu2FGZXbu03a2HXtDHB85dmuG+s9id5M6RvOPsVr4fOM2kCjF9MIniHETZYTmDyd6A+fr4a0VczOSCdvaTvOkfhhQ+f4fYSutxzmpqsyA0fPi6MlAGYBOaqjBtmlnsdGWVtmLgG5Dqun/93k14xh9JUYsIjrSZgFJyLQpp9dTjSPlnA93qE9bkVpx5W1t1XMzy8sgD6KvxJAxXya7t6KgzJ6dT1EGvgORJ9sDBiwsjTlsmAlhnFT9eHIJYhYhZ8WYo5f3F0m1evH0F2GE7KPtpKEpkwoST3tXjgfHZrOzOBDl2PEmgyO+5V69pCxONYt1rVqNPF0rNgdngTw4+vjfbjMw9XCw/0D7gqcsDK5MH9oHEtOmlMctQjdvNDAVjh/n3i6tbfLt7+NsiDPLK86TiXVexTskES6lkmcqgcH8lGHCdpUGClpgNmqEx5FsP8eKZK0gl83PDeMvlrdObKYF2hlICmJLBq/yVVQFAnyIlMhjCtqmZ3jYdBUj5nVjfLqbjdAS0YkTnREIEPwYxyQusIGJap+f2cwqEN1aHeA+31t7UOO0k29iWg2S4Djabi2U9K598NGZFrkQrvRAkAH3swzyOZSkaAuNDODr+LHMwPQ== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid04.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(336012)(5660300002)(8676002)(426003)(7696005)(508600001)(4326008)(8936002)(70206006)(2906002)(36756003)(70586007)(2616005)(7636003)(36906005)(82310400003)(107886003)(54906003)(26005)(47076005)(86362001)(186003)(110136005)(356005)(316002)(83380400001)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:06.2121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62c2878a-8377-408f-a923-08d99e87a440 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT037.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5263 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the I2S driver accordingly. Fixes: c0bfa98349d1 ("ASoC: tegra: Add Tegra210 based I2S driver") Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_i2s.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra210_i2s.c b/sound/soc/tegra/tegra210_i2s.c index 45f31cc..b738b21 100644 --- a/sound/soc/tegra/tegra210_i2s.c +++ b/sound/soc/tegra/tegra210_i2s.c @@ -380,9 +380,11 @@ static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol, i2s->rx_fifo_th = value; } else if (strstr(kcontrol->id.name, "BCLK Ratio")) { i2s->bclk_ratio = value; + } else { + return 0; } - return 0; + return 1; } static int tegra210_i2s_set_timing_params(struct device *dev, From patchwork Wed Nov 3 05:04:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12600089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52994C433FE for ; Wed, 3 Nov 2021 05:08:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0B9B610E5 for ; Wed, 3 Nov 2021 05:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0B9B610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3756616AD; Wed, 3 Nov 2021 06:07:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3756616AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635916079; bh=LTDBfC6TZTUDk7MhP8NienszKKIRGQ/8NSl8FsOd5C4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y+m6bttJEtcdY/5RJsM1kk20kDT7I18DomuRz4PkT/pdJH0F1S8/4ejGAT+pak/Yx XcQgcEER6r7FTl14eQijYMl6MpQEuQ2L9cQLkclgTDI8n5yShMg/3vZwL/9vypHgFL q5Rb6OPSUxbm2us95SHS0lodhgnTA3zS1UXIxGsU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B3174F804F3; Wed, 3 Nov 2021 06:06:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3DE61F804F3; Wed, 3 Nov 2021 06:06:20 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2048.outbound.protection.outlook.com [40.107.100.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 05727F80224 for ; Wed, 3 Nov 2021 06:06:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05727F80224 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gsgcCjLq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZanBOCsSWHn6on8feXioCc2IUBN1kUKXL0bPq09JYQM81hLdnZTWofCY9lV7zRXpTwnwPZzH7cT7cWZ008jeW2xuBqzbtRdPib0+ZxX1Lk3g5m3xQEY2rvJaseZF8AUC07YvgMrowh7fusYVrv2JBV8/+sFndGV+kfbcySOoj9Mx+y49qv26wQ95CsbCEwXIIyU8QHEY8mUM+fgY1uVfSgsLU6VvP5SQY5N6OEoYbACA2rSiLxC5ecKHDqxA7FlwLalhCGk38CkzsepuzUc7lSzbtTB2Z0n4JTqUtc0nCyPqZ0ZIx4ptaKgh9zlaeLQxuftukOhK36A0ywMIMWsplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lv9qTG8Mk4JCkjZXIyqN+guo67FWeKDFErBSmO0HKNc=; b=cv/h0UwT2aaeU4WjHFIma0GrwPDaWD0+Qotyw04FW1o0YI9iJIGwzXFuTRtmKImultumWNkeDRpjQlFG2NgADVHPggMhdUZC6E4t9thNhIYRRjRYWgq5mwlfiLV+qTsP918eRmudefypk45Wv8rufTetqtGGDkOVFjGuvwbzffQJ9ZLgQf4oOGHhAfjS8sqFLeM0WypotWFdYCKs67qIHDqv9AogMuH30bFN8UaZEQorErS1K0r31zIwQpu9ubAy0IX/dYadx8/BilvS2jVETIWZByCrPmK2aPHtxJQnUr/5tahYQ7LM/12wlNNMv+4EbOgPtbU4BT17PE9YUHFXsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lv9qTG8Mk4JCkjZXIyqN+guo67FWeKDFErBSmO0HKNc=; b=gsgcCjLqifFyuLFKY94uiw3/5AeI+RX8XCM6F4tdGONOTvX42E/hrtGRGT79hspbdgfYSVuxiozrRtwMgwF2IbCPpEnlg5fM6la9fO7q1iH7yrg5a/a79V/WpgA6eKoo5B7MGJB2bKs7hUnWnPP5e05AH9wuyZ3Y67+b7wM+UDhI09G2JvLRdNaa8gHWToVvKYwG26herP5kM1TcRkYRsGV8JoQwZmbSV7TU/k4teYakj5Zm8kgRWxu65mmoao558pATHv8dtYRqrhOwFsZrH3pj3Y6q483x0bYtZiU5mjDfbI7GwBRHbf7pt6QNy2CB7M8/s78BLCEOYYbyGd7zmQ== Received: from DM6PR06CA0080.namprd06.prod.outlook.com (2603:10b6:5:336::13) by DM6PR12MB4976.namprd12.prod.outlook.com (2603:10b6:5:1ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 05:06:07 +0000 Received: from DM6NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::f4) by DM6PR06CA0080.outlook.office365.com (2603:10b6:5:336::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Wed, 3 Nov 2021 05:06:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by DM6NAM11FT051.mail.protection.outlook.com (10.13.172.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:06 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 05:06:00 +0000 Received: from audio.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 05:05:58 +0000 From: Sameer Pujar To: , , , Subject: [PATCH 3/4] ASoC: tegra: Fix kcontrol put callback in DMIC Date: Wed, 3 Nov 2021 10:34:56 +0530 Message-ID: <1635915897-32313-4-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com> References: <1635915897-32313-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3aa8b012-a37a-44d4-17f4-08d99e87a45e X-MS-TrafficTypeDiagnostic: DM6PR12MB4976: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0WUvdoxzWrPpbKzSFW7TJavW2yQH3gSsKD20ZjdfqY4pUGYxMkEGwVJKKZWSZ7j1stfMr2PoA3gKXqyuvMAHSBYe9INJv+Z8odaOs+dGtd/aWoFH7tzP02b1Bis53oHDY99Kil8bS5JrIZGzo6wmVB2mZGnK0PY6vnrOV9m/vBPH6Y6YumfL5YsAxyeOuboSNwL/vUlk3XFYkj5k6l/0ukV+xruRI5f4nIqBNZ0tBE9/U+bV/5Hy8GvK6Db9MzJp8qzeYlNwk1kUo0pwOHjxrqMRt29YmdWmYhCGvvmYAnXHcjce2he3JggI3zuj4MpcVtD+r/uoKgKhWjPOZZ7SJFLtiMXXnMr/sScygyVuRSTeKWscTjuYDDfMj/adLTgMovM2DWhZfB42+936Iu+qHWdIQ7IcTsBs5WB3XiQBnRQf0RMPC0YTQ8YmQQ76DSKx28uYNQR+ouBKoohNiYjvB9XuHjdj5jkW7ictcUW7zQscl+4l+qOLm+1D7iWUVQQGNXvkQEZe6bieK9Ph+oVysuuZltW9KRuHkOKI25BvEGVr3gGacy2q9umT6QYHKU3ywE8CHK4pUmjLMRRzU14cQrDDzs7Cda+i3Lt3ps3moknrjMhaN3xbLX2tZleMESoqBfdxPGbnVPt7zpOhsDrugNDQJGX+qQ0Hit3ol6di2ldFykAy7V1wKel9BN8WQYIuXHdB57RNAEqUTfjKlC2AWg== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid02.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(336012)(4326008)(426003)(2906002)(36756003)(186003)(8936002)(36860700001)(26005)(107886003)(86362001)(82310400003)(7696005)(508600001)(70206006)(47076005)(54906003)(316002)(7636003)(2616005)(36906005)(5660300002)(356005)(83380400001)(8676002)(70586007)(110136005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:06.3620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3aa8b012-a37a-44d4-17f4-08d99e87a45e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4976 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the DMIC driver accordingly. Fixes: 8c8ff982e9e2 ("ASoC: tegra: Add Tegra210 based DMIC driver") Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_dmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra210_dmic.c b/sound/soc/tegra/tegra210_dmic.c index b096478..133509f 100644 --- a/sound/soc/tegra/tegra210_dmic.c +++ b/sound/soc/tegra/tegra210_dmic.c @@ -197,8 +197,10 @@ static int tegra210_dmic_put_control(struct snd_kcontrol *kcontrol, dmic->osr_val = value; else if (strstr(kcontrol->id.name, "LR Polarity Select")) dmic->lrsel = value; + else + return 0; - return 0; + return 1; } static const struct snd_soc_dai_ops tegra210_dmic_dai_ops = { From patchwork Wed Nov 3 05:04:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12600123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 348F8C433F5 for ; Wed, 3 Nov 2021 05:08:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 828D760E90 for ; Wed, 3 Nov 2021 05:08:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 828D760E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE4EF167E; Wed, 3 Nov 2021 06:07:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE4EF167E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635916129; bh=PNqfgDcfSwZRltZuWAyctDmDSOK0MhFHzHDplktYwxk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uq7XhoAlaEwngZHRnf5R6ICiecenq9/cgf3SEBpyP2Aio4XxXepsNVavKmklfQT5Z bOg7COQmMCo8BYazsmIIYWdUTBM/qtNU/m8vSghEqkPJwYm0CFCCPjhtgVLPlmqX2B fck34bthyXaAoGt9yErFeKuIO+gSLc+vigKiMdSw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A890F8026A; Wed, 3 Nov 2021 06:07:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30FC5F804FC; Wed, 3 Nov 2021 06:07:06 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99A8BF804CA for ; Wed, 3 Nov 2021 06:06:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99A8BF804CA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="c0iiUG3y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZO5HZnLJ9wfjnYkml/ds5UL8YXn1fQKbBLrUWu8F54A/fD+e71Jn3/W2pu9RgyWMj9fzCktuf3qkTJ0ei5GVY30EZGsqv9DZYYO5g4GcDFwIJAFMUxGY6LV58JXgFaaWRMXbQ6GM+IfKPLgD80/TA1jzeD1SzMvWY8gnlvmkSbVZAGFqpgddZLTaY3fIuDoVxhnWLsBFsyuq0rD0lcyG99wrDFwv2ZKkSkexeDWHH7nhl9XbiLsRc9GjSiMZu7tAMOAW+8hmyGEi6uPuTvsC/6eLeYY35CELLGD8amE1+vujxQK2ATFJ6LN04UgFoSCHtAnCTwAxPWYZXMNq55Lcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mIPhphCbUKWY+QnSK6mE0owgWF+MEU/osPefBYcutKk=; b=hozQU57UkYZvPCHSu1F3meQVF4ZRvzL5/vr2+DyTmOK4WoXxacUVv7fsNqqxN5V60gmLCD3iSKSVlaqTgciDFkOQHF2PuaYPg3fYvSJbI/w6+UkexCIqid5CILQNPyerGXcGOB0wSr5aQhdv1AaLbXcs8Oary0AavXZGkBLB9PpWxAqQZ30cAAI2qO1hJjM5InW0S2qnZBt7iaY+Nf3kruYxU35QLJFCJf8BbXmYZqDAHUf3kkB2BGvRYOZlzuDNE28/YyXWJf5zctiso4wsRHRjf2k44ONlDkiisxqu6qro5qG2W8pWkQ4fjqlrUyy5V3y+S3AOBGGN+ygQDMN/Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mIPhphCbUKWY+QnSK6mE0owgWF+MEU/osPefBYcutKk=; b=c0iiUG3ynbzmMbwEw20e7+Uwh4xelkgzgW9crAgO4BMSQlVSV6zyGuovTEYZjGYI1Kzhag6vaqBKzKKmVcuK6xl97J5VmsJuEAABzkG0Ts6XXGvT91CfpzpLZ7shpwLUTKcNNrambHknSGgCKR5KG53Ge9ZhTnBViIi5+Tg02NGUMtUmR3I5zhm/niecw3dMfebeFw8Vejx3kU604hVjNpUgIvL9+6VXQLmuhzCk7qdjHaxa8oEyT3F8gVwtbLk3gZNcMv7a6Kw8VLlxkzU4suloIW/pSZ0Q5VgHmPkrEvIX2q+NnBmdD8LSMcT708OuBM0dovPygLCx3KF0sPC/ZA== Received: from DM6PR06CA0089.namprd06.prod.outlook.com (2603:10b6:5:336::22) by DM5PR12MB2519.namprd12.prod.outlook.com (2603:10b6:4:b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 05:06:08 +0000 Received: from DM6NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::49) by DM6PR06CA0089.outlook.office365.com (2603:10b6:5:336::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by DM6NAM11FT051.mail.protection.outlook.com (10.13.172.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:06:08 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 05:06:03 +0000 Received: from audio.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 05:06:01 +0000 From: Sameer Pujar To: , , , Subject: [PATCH 4/4] ASoC: tegra: Fix kcontrol put callback in DSPK Date: Wed, 3 Nov 2021 10:34:57 +0530 Message-ID: <1635915897-32313-5-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com> References: <1635915897-32313-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90056966-5fe8-472c-4466-08d99e87a5c1 X-MS-TrafficTypeDiagnostic: DM5PR12MB2519: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VI1o45MjHxQCl+Q46OII6vdZJWPwbZSqQGTa8x1X2LjpiB7L4IvT4S0cnOnqZAqOr0Jai0o8QbQUz+JR11SBqqA09rUlEq9c1AOEfij+qe1EE/QU4kkQMHYm9usQJioYF8P02V1H9cL1NPjWNutxBBfRgZHm3k6f4+P7q/v7yMr4Ijhl+auGWPzF8GFjbhPIkHXSAZprF8K6t3H1U1LDc7M92D0lbVpAZP86XbD1KjPh639hG0MLEDmQQp59UPVWJVdPn/h3BtZ9WfBpds5g0trvf2B4wDZYquQ8+ebFh/06SmgPR2Tavq6xcKjc4DAxvuMFjT1QagkcDMHhfbXziBxADdPVsfzhZ8ZRQ/jC444jbNLYI03v1DYNvYtLkDcPVvPhk/0mQlsFBsDR6ycY3eX7zCga4A1k3cmeEw2IvjgASU+KCXZPGbCDEH2iTHP47Uc85d/1PAIEYUehiUTdfXtv2dsYPX4j+Hht6k79I6w7ppWQmJE+1QLSjhICyw5nzjAhrhux55zr9n4376NRG7wzrtPXn7RS2V2MHfujkOh+pbNBsW8j5G6BlU/0HRKYzJ3mtq0pTYkU7iopDuAIDwtNerSI5afUowu//TqQDbo4c9QVr3ecgbFrTWGd6YyMHN0+m7oxJ+VrHnt2kJQ4YTyugS2QS8nShMUYUNJis1g+fwzomM575eryQ0xmIlMO+ksHBrKGnYeeNWz+DC2bhw== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid02.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8936002)(426003)(2616005)(86362001)(186003)(4326008)(2906002)(7696005)(356005)(107886003)(7636003)(336012)(6666004)(8676002)(5660300002)(36860700001)(82310400003)(47076005)(36906005)(83380400001)(316002)(110136005)(36756003)(70206006)(508600001)(54906003)(26005)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:06:08.7126 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90056966-5fe8-472c-4466-08d99e87a5c1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2519 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the DSPK driver accordingly. Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver") Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra186_dspk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c index 8ee9a77..3b1bdb7 100644 --- a/sound/soc/tegra/tegra186_dspk.c +++ b/sound/soc/tegra/tegra186_dspk.c @@ -67,8 +67,10 @@ static int tegra186_dspk_put_control(struct snd_kcontrol *kcontrol, dspk->mono_to_stereo = val; else if (strstr(kcontrol->id.name, "Stereo To Mono")) dspk->stereo_to_mono = val; + else + return 0; - return 0; + return 1; } static int __maybe_unused tegra186_dspk_runtime_suspend(struct device *dev)