From patchwork Wed Nov 10 15:46:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jay Foster X-Patchwork-Id: 12612447 X-Patchwork-Delegate: luiz.dentz@gmail.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD8BC433F5 for ; Wed, 10 Nov 2021 15:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA9CE61178 for ; Wed, 10 Nov 2021 15:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232124AbhKJPtx (ORCPT ); Wed, 10 Nov 2021 10:49:53 -0500 Received: from mail-dm6nam08on2051.outbound.protection.outlook.com ([40.107.102.51]:20993 "EHLO NAM04-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231795AbhKJPtx (ORCPT ); Wed, 10 Nov 2021 10:49:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e51qfhElCfWdTaJKXtoweObpQKPJjJP8u8krdWMvPfpQrGqtcG5Gwm+oAmbxPeRjd3icl5MD2WOP7LKzls38zRKIsNiU3nJ55s96BJyLopm0vanMVTuzDRGR+wqxlevoXSiL9BI2pDKdHmq5YYkLRDgsTg9WHCc0uoYzg/MvVxHJ2vVPozmOHqUVBHqLYtkKWG0CxicpPCBJm2WIFq3oUp+4P/Exmkw5JykanLd0KHNOGbjnn//4UlGvlKYasKIxKZMmAB5JOXNTWpDjxK4KPVPtBIVwdMGOf+wZcKYWMICiwA4qrTZb8kW8hIFrlDPtiNLjn2GVMvWzOE1bQNR6gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wWoZ8Up9u1H1hbiO+UfV+SknCnKWMpP8NtrP8OzeNSM=; b=lX/3MGHucN13oQFFN/32MORH+dVE/dKL9NzjNE9slHGT13HW73il19jADhy9jLYj8z+9PelZFhvAeYlWtSbg1Z9iA1F4t6t6vDmas9XP4ASlGN09iHbVV5D0koLfEQ2/fO6tD12kOkfkHUQBOzXE4VZdJ+SzCBPy11a7uAhFlm8KZD3FPj77c+SJxoux6SqMeXXE/ZPt8ci+KScQWPQRiR/QBS0rgMYHjSywik3UJi6MWBURiTFh/9pn9JaxIEY0VtUJ7jlXJENhxtXFNs5D3jbMH2XQ6g60998r5FKZMXQKo9YfDDo3/c0TWTm00nP75k4Qre/VAt72MD6hY2iV5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=systech.com; dmarc=pass action=none header.from=systech.com; dkim=pass header.d=systech.com; arc=none Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=systech.com; Received: from BYAPR20MB2664.namprd20.prod.outlook.com (2603:10b6:a03:fd::26) by BYAPR20MB2247.namprd20.prod.outlook.com (2603:10b6:a03:159::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Wed, 10 Nov 2021 15:46:58 +0000 Received: from BYAPR20MB2664.namprd20.prod.outlook.com ([fe80::ec43:56a9:6f54:d0be]) by BYAPR20MB2664.namprd20.prod.outlook.com ([fe80::ec43:56a9:6f54:d0be%3]) with mapi id 15.20.4690.016; Wed, 10 Nov 2021 15:46:58 +0000 Message-ID: Date: Wed, 10 Nov 2021 07:46:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: "linux-bluetooth@vger.kernel.org" Cc: Jay Foster From: Jay Foster Organization: Systech Corporation Subject: BlueZ hciconfig: Segmentation Fault X-ClientProxiedBy: SJ0PR03CA0386.namprd03.prod.outlook.com (2603:10b6:a03:3a1::31) To BYAPR20MB2664.namprd20.prod.outlook.com (2603:10b6:a03:fd::26) MIME-Version: 1.0 Received: from [172.16.4.182] (70.167.11.34) by SJ0PR03CA0386.namprd03.prod.outlook.com (2603:10b6:a03:3a1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 15:46:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9db6c878-2fa0-46ad-0153-08d9a46153d0 X-MS-TrafficTypeDiagnostic: BYAPR20MB2247: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8BPtYi0K/6X9FDPEUpjZh4/U4aStEAhAl9kT/aPe/nsl+F2eQgqnZ/l4MSFKIyqVTVw0+UIlRoY98AZfzalRbO987Gxir7xZsYWOhLOWAxuB/HuC9qYv1A9ly5pBhuBR8WsFIfV3skGNvlJoMr4E1hfvh8l+mSuUyHwzmAc5bHnxUdbNjI9Yh1pkuhm2BKGgPGpaI83Cc2fNeYDPFkYzxCASBPpG6LS7d/RblvtSPm5br91AP8y4qUkdph/iwdyqCxCf8q8sMxQTY2mUrFVzamBcaG2EHGJ/dRzF7LOLkOUjsk/ONbb4Cm1bI6Y//64mJkYlu11J+BIUzH/7T3AIuJJIW8dCio6tDelCynWRUlqA4eu+N5RMsJiFql5G7fl3Uwevs+Vc+1Z1npRzVFGR0s+BlqOSayCDEtn+yiyTx7cuv1dOeMNN9Jyn2AjABQ4eS+3cPLTNh0lPU+FymA88KT7iPF6mVw2nZGLy+fONLrlPoymsEP6HTc/bcyGDbdWavIZjaBe9Sd8xLXV5Eh3O3nJOzcMl/AF4bPQr4kJrpTGnfkgaHzlwHJdwPlar83CCbpl4raYEhUVmyxuQ4WrTB8q+ue9NSF6HeAFIjR5cHb+vd+tNEX9YEw/DGR3KXdOkTEkLRGue6vv/wWbvTZrIf+/pgd2ciRFJZ10/k9VqLZjShFI8LK4tyhbfISeE6g5tfa2XTFJuxsg2lgTbRmDY8MMFx3ZjZwtsSoM3kv2NaSpE5Be7tGhTCc6ToXLWQRg9QyfGfNmd27RKOLgr4CQc6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR20MB2664.namprd20.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(366004)(39840400004)(396003)(956004)(16576012)(107886003)(31696002)(5660300002)(508600001)(52116002)(4001150100001)(86362001)(6666004)(36916002)(2616005)(38100700002)(31686004)(38350700002)(8936002)(186003)(316002)(83380400001)(6486002)(26005)(66476007)(4744005)(66946007)(44832011)(36756003)(6916009)(2906002)(66556008)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?tCBHo8BaNmWZnnkoTXnjNSlVSmUl?= =?utf-8?q?cYA7NX51u9esvHVeI/Rso7T77InKZssdgV8TOxiLCJyMQ4WLDkzFHd3FngljlUx0d?= =?utf-8?q?9svSnCG2mrsdPj/Pa592/ifcc5f+/xmKIGisM0Bhn9xWkXQPD86XtfOVSMSqouYL9?= =?utf-8?q?xhRFZRXecewhWeKRKVht8HWi+iiltLmgb8rvI7Pnu07QabwIJlHjF5LuWMIh6oTuA?= =?utf-8?q?WDoOG+lYKiTV+5LqHw2KnWgaSSGhO5ipi541NS9YOH8ynnn3Q6TVgeFRaEPOBsWVl?= =?utf-8?q?xepBlLgQz7uOyIVjaFWTzRIOzMhY95lGkkfZ4EjbKktz+IKwbZJ3TqwANMBYo1Orz?= =?utf-8?q?1X4+9b8fLoP8GXMH49Fm2RQpwXlu1BFHcz3iwuTnjnidqR/xcu62X182w6FpraUlI?= =?utf-8?q?GH1r+/6Hi6R9J088yXsRK5P53kEIib9OjV7HcMSH2tPQoIyvKpeRak0leOvVlAHst?= =?utf-8?q?lqNzQXV6awurlt77xScSS2GoQPE4SxqBxeTJVN8Hsh3h67VgwI8q5zT7nwfKv7PzO?= =?utf-8?q?q9wyRgVUz8tnfnFQUEGwoULaab4UqMMBCSOriGuE/u6JXG8jszpH5N0VE4TKdYz1y?= =?utf-8?q?ZXv0h3qlUv+U7AMjTe3wOMMX6mFk4pFkIXUgFXegeNDI9udbjOWjj/sYHbGSnrhEk?= =?utf-8?q?Lt1J/kP60kS6W/qlskYu0hCMXO0bxhKPOApCn5a6lb30j6ODeXe6WpwI985UTCbYt?= =?utf-8?q?KTKSqrjKzkQDRJNnHmXIv8oCXRBIOf40py1FeYjPYPzOW0CwJiApiMDrz4PFzOVVC?= =?utf-8?q?nGBvMuKmB+IUz3xGIRs1XdiRkdZHlHZHaDE1rPXjyrev6hrc/DNLaDgIdeBTDiViQ?= =?utf-8?q?oIeTZF3ihGSkAd58ik+cy3ogXpOSKRAgvPr2HBBgPzJHRV+5uAtbXNnGjKzc7/6FY?= =?utf-8?q?sFLfgjU0FoKp8MROJgqJQZz1wMjjKu6fPSUEU0Ej9zlNi0ijmdL1LsbXn0aGlS5db?= =?utf-8?q?CxzjRThfo2FxoSXLsphbBMQptFlYvyTQNQE7QAWb5xHyBL5b9uB76SAAgNmVG+gG8?= =?utf-8?q?WlSHeWSevGTihfBXrW52r64dzwX6Tgu0A9gZ1Q7kX+DzcDuqlH5o69uxHIUwCEdZd?= =?utf-8?q?7KkfJCaB6G58sAdvlREUzaKIhnbZmKDZE8GaGFjQw+3SWi4FLhsAbjzc3c2c3nsbq?= =?utf-8?q?Wy7LX5JpOUb2DiJpVc6/iXzZGgeoaWDGll/Ag9i94trefGVRvPiGK9dOqO7J0J77J?= =?utf-8?q?ySMzD5v4EgxPsu6Oop6U4PFQjjRV9PaBoOo8X1abZ9A3uxMDQcH4xZ23juUVDUVwC?= =?utf-8?q?ciG9px+Ht5GGyClxMIxFWpBihbm+FbtRyxfBZLEsG7g9xCOh/JpYPajloHygNCMow?= =?utf-8?q?eJ8AQm1Zdb4vvXg9UJHx5Zkwun/7ukoG5MTgMRtHJArcgQFWgrAaKvKS9BLeQQ861?= =?utf-8?q?0SUS+7DVBuEcjzvIXgF2Jw3gOEClDxgs7CQlEfzHsRy9P87i/nciMOeGq8GUtkgir?= =?utf-8?q?aKh2QzCa89iNjNT+3auSDfVqc3pAXYKrjch3KixYxOTCE1NrYeCob2XzrtKOG/tP/?= =?utf-8?q?KPUBQJh0JpdmdvnqN0WEPV4Z0zgjPaCJj+xBg664wXvSoh2xts2xxBU=3D?= X-OriginatorOrg: systech.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9db6c878-2fa0-46ad-0153-08d9a46153d0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR20MB2664.namprd20.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 15:46:57.9466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 47224f68-59f8-42cf-9b0c-62ae261b2df6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V2Ym6eKSbdik1oBv90pwli4LsvOaA5af1mY4jTlLx3OW9KkpFfLg3VPCIxkSnVahufn4XaF/z5tjTwABAOo3LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR20MB2247 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Jay Foster hciconfig segfaults in the Bluez 5.62 release. The 'hciconfig lm' command, used to show the current link mode settings, de-references a NULL pointer when calling strcasestr().  This results in a segmentation fault.  This is a regression in release 5.62 from the updates to implement the appropriate language changes. The hci_str2bit() function handles a NULL str value, but strcasestr() does not. Signed-off-by: Jay Foster Signed-off-by: Jay Foster --- a/lib/hci.c    2021-10-13 11:38:34.000000000 -0700 +++ b/lib/hci.c    2021-11-08 09:19:59.880207913 -0800 @@ -323,7 +323,7 @@ int hci_strtolm(char *str, unsigned int      int ret = hci_str2bit(link_mode_map, str, val);      /* Deprecated name. Kept for compatibility. */ -    if (strcasestr(str, "MASTER")) { +    if (str && strcasestr(str, "MASTER")) {          ret = 1;          *val |= HCI_LM_MASTER;      }