From patchwork Wed Nov 10 21:11:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12613065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23B7C433F5 for ; Wed, 10 Nov 2021 21:14:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A31336124C for ; Wed, 10 Nov 2021 21:14:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A31336124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkuvC-0001ex-QR for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:14:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuss-00043g-VZ for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuso-0002Vl-QB for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636578708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMC66D+EJ+hrT/UBOk41MdZi04+cRd/w1xnlN0O59wk=; b=iyj5StgSNErxOoAQchWHKMwXa+lfzC3AOZAG/6/dTGYifAy4vNK6SOIkgXWMiNCK+Ymc6b 4C58ikk0bNJf+4aZc9pCBfvG7sbsX+I6tfm7/bW6rMjUjIAZOuGTl/Xkgj3G1GanoybFys bY9B8iKDzu5JRbdmPst87RQrm0XzXh4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-d09XQ2SYPpW9V-5k4U_4Qw-1; Wed, 10 Nov 2021 16:11:47 -0500 X-MC-Unique: d09XQ2SYPpW9V-5k4U_4Qw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F178718D6A2A; Wed, 10 Nov 2021 21:11:45 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 797DE67840; Wed, 10 Nov 2021 21:11:44 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Date: Wed, 10 Nov 2021 16:11:36 -0500 Message-Id: <20211110211140.3057199-2-imammedo@redhat.com> In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com> References: <20211110211140.3057199-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mapfelba@redhat.com, mst@redhat.com, jusual@redhat.com, qemu-stable@nongnu.org, kraxel@redhat.com, ani@anisinha.ca Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Mark property as experimental/internal adding 'x-' prefix. Property was introduced in 6.1 and it should have provided ability to turn on native PCIE hotplug on port even when ACPI PCI hotplug is in use is user explicitly sets property on CLI. However that never worked since slot is wired to ACPI hotplug controller. Another non-intended usecase: disable native hotplug on slot when APCI based hotplug is disabled, which works but slot has 'hotplug' property for this taks. It should be relatively safe to rename it to experimental as no users should exist for it and given that the property is broken we don't really want to leave it around for much longer lest users start using it. Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha --- CC: qemu-stable@nongnu.org --- hw/i386/pc_q35.c | 2 +- hw/pci/pcie_port.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 797e09500b..fc34b905ee 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine) NULL); if (acpi_pcihp) { - object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug", + object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug", "false", true); } diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c index da850e8dde..e95c1e5519 100644 --- a/hw/pci/pcie_port.c +++ b/hw/pci/pcie_port.c @@ -148,7 +148,7 @@ static Property pcie_slot_props[] = { DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0), DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0), DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true), - DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true), + DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true), DEFINE_PROP_END_OF_LIST() }; From patchwork Wed Nov 10 21:11:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12613059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B2FC433F5 for ; Wed, 10 Nov 2021 21:13:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C06661250 for ; Wed, 10 Nov 2021 21:13:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C06661250 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkuty-00069t-Ev for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:13:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuss-00043d-VW for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuso-0002Vv-QP for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636578710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYSprXGtGmazCDJ3imnjjpHsI2IC8XJyBYBlKcffw9M=; b=VaVWjHULCIzjqZhIZVXOP7B9uoDEZMWezFAo4/CFBZZNsN5SRFtyhm4c/KgaDEWywQJQz7 YcO+F45pOw73GGvb2lZ9Ed9F8/jHUi+RL4YuT5yBQhjc6Hp9NSPeF973NiuMzBX0y5ExsL 278iwxcGNj7MnTAoP/pt3RNweCVEwJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-Kim8RrpXN_CRczIOnr6LRw-1; Wed, 10 Nov 2021 16:11:48 -0500 X-MC-Unique: Kim8RrpXN_CRczIOnr6LRw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A13ED101796C; Wed, 10 Nov 2021 21:11:47 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4923567841; Wed, 10 Nov 2021 21:11:46 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Date: Wed, 10 Nov 2021 16:11:37 -0500 Message-Id: <20211110211140.3057199-3-imammedo@redhat.com> In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com> References: <20211110211140.3057199-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ani@anisinha.ca, mapfelba@redhat.com, jusual@redhat.com, kraxel@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Julia Suvorova To solve issues [1-2] the Hot Plug Capable bit in PCIe Slots will be turned on, while the switch to ACPI Hot-plug will be done in the DSDT table. Introducing 'x-keep-native-hpc' property disables the HPC bit only in 6.1 and as a result keeps the forced 'reserve-io' on pcie-root-ports in 6.1 too. [1] https://gitlab.com/qemu-project/qemu/-/issues/641 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409 Signed-off-by: Julia Suvorova Signed-off-by: Igor Mammedov --- v2: * s/native-hpc-bit/x-native-hotplug/ to fix conflict --- include/hw/acpi/ich9.h | 1 + hw/acpi/ich9.c | 18 ++++++++++++++++++ hw/i386/pc.c | 2 ++ hw/i386/pc_q35.c | 7 ++++++- 4 files changed, 27 insertions(+), 1 deletion(-) diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h index f04f1791bd..7ca92843c6 100644 --- a/include/hw/acpi/ich9.h +++ b/include/hw/acpi/ich9.h @@ -56,6 +56,7 @@ typedef struct ICH9LPCPMRegs { AcpiCpuHotplug gpe_cpu; CPUHotplugState cpuhp_state; + bool keep_pci_slot_hpc; bool use_acpi_hotplug_bridge; AcpiPciHpState acpi_pci_hotplug; MemHotplugState acpi_memory_hotplug; diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 1ee2ba2c50..ebe08ed831 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -419,6 +419,20 @@ static void ich9_pm_set_acpi_pci_hotplug(Object *obj, bool value, Error **errp) s->pm.use_acpi_hotplug_bridge = value; } +static bool ich9_pm_get_keep_pci_slot_hpc(Object *obj, Error **errp) +{ + ICH9LPCState *s = ICH9_LPC_DEVICE(obj); + + return s->pm.keep_pci_slot_hpc; +} + +static void ich9_pm_set_keep_pci_slot_hpc(Object *obj, bool value, Error **errp) +{ + ICH9LPCState *s = ICH9_LPC_DEVICE(obj); + + s->pm.keep_pci_slot_hpc = value; +} + void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) { static const uint32_t gpe0_len = ICH9_PMIO_GPE0_LEN; @@ -428,6 +442,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) pm->disable_s4 = 0; pm->s4_val = 2; pm->use_acpi_hotplug_bridge = true; + pm->keep_pci_slot_hpc = true; object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE, &pm->pm_io_base, OBJ_PROP_FLAG_READ); @@ -454,6 +469,9 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) object_property_add_bool(obj, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, ich9_pm_get_acpi_pci_hotplug, ich9_pm_set_acpi_pci_hotplug); + object_property_add_bool(obj, "x-keep-pci-slot-hpc", + ich9_pm_get_keep_pci_slot_hpc, + ich9_pm_set_keep_pci_slot_hpc); } void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2592a82148..a2ef40ecbc 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -98,6 +98,7 @@ GlobalProperty pc_compat_6_1[] = { { TYPE_X86_CPU, "hv-version-id-build", "0x1bbc" }, { TYPE_X86_CPU, "hv-version-id-major", "0x0006" }, { TYPE_X86_CPU, "hv-version-id-minor", "0x0001" }, + { "ICH9-LPC", "x-keep-pci-slot-hpc", "false" }, }; const size_t pc_compat_6_1_len = G_N_ELEMENTS(pc_compat_6_1); @@ -107,6 +108,7 @@ GlobalProperty pc_compat_6_0[] = { { "qemu64" "-" TYPE_X86_CPU, "stepping", "3" }, { TYPE_X86_CPU, "x-vendor-cpuid-only", "off" }, { "ICH9-LPC", ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, "off" }, + { "ICH9-LPC", "x-keep-pci-slot-hpc", "true" }, }; const size_t pc_compat_6_0_len = G_N_ELEMENTS(pc_compat_6_0); diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index fc34b905ee..e1e100316d 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -137,6 +137,7 @@ static void pc_q35_init(MachineState *machine) DriveInfo *hd[MAX_SATA_PORTS]; MachineClass *mc = MACHINE_GET_CLASS(machine); bool acpi_pcihp; + bool keep_pci_slot_hpc; /* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory * and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping @@ -242,7 +243,11 @@ static void pc_q35_init(MachineState *machine) ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, NULL); - if (acpi_pcihp) { + keep_pci_slot_hpc = object_property_get_bool(OBJECT(lpc), + "x-keep-pci-slot-hpc", + NULL); + + if (!keep_pci_slot_hpc && acpi_pcihp) { object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug", "false", true); } From patchwork Wed Nov 10 21:11:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12613061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5602FC433FE for ; Wed, 10 Nov 2021 21:13:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B774610A5 for ; Wed, 10 Nov 2021 21:13:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B774610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkuu1-0006Fz-3q for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:13:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuss-00043e-Vt for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42460) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkusq-0002W4-4z for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636578711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QeXktlsOJyxwL0ycrPB56ovTFAd+6QG8ipE36fCIQU4=; b=Pju3u+n1GNhoxCYJLUu0oG+eYNjeple01JBGxWpVRPEZDMNlXkrBaXdS09khR/RYo8T4SY BlD1IxHCMlYPcgJVJspzeazf0wwMf8Irk7yTjcsBpb71iOqWEpbzNe8c4osuJsFl49S1J6 e6uiGjbEqqburznql+gb+uH/kJ33NSk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-VjdkgCZ_OEuCx9130AXHuw-1; Wed, 10 Nov 2021 16:11:50 -0500 X-MC-Unique: VjdkgCZ_OEuCx9130AXHuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 466321006AA0; Wed, 10 Nov 2021 21:11:49 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA832197FC; Wed, 10 Nov 2021 21:11:47 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Date: Wed, 10 Nov 2021 16:11:38 -0500 Message-Id: <20211110211140.3057199-4-imammedo@redhat.com> In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com> References: <20211110211140.3057199-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ani@anisinha.ca, mapfelba@redhat.com, jusual@redhat.com, kraxel@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Julia Suvorova Prepare for changing the _OSC method in q35 DSDT. Signed-off-by: Julia Suvorova Signed-off-by: Igor Mammedov Acked-by: Ani Sinha --- tests/qtest/bios-tables-test-allowed-diff.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..48e5634d4b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,17 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/q35/DSDT", +"tests/data/acpi/q35/DSDT.tis", +"tests/data/acpi/q35/DSDT.bridge", +"tests/data/acpi/q35/DSDT.mmio64", +"tests/data/acpi/q35/DSDT.ipmibt", +"tests/data/acpi/q35/DSDT.cphp", +"tests/data/acpi/q35/DSDT.memhp", +"tests/data/acpi/q35/DSDT.acpihmat", +"tests/data/acpi/q35/DSDT.numamem", +"tests/data/acpi/q35/DSDT.dimmpxm", +"tests/data/acpi/q35/DSDT.nohpet", +"tests/data/acpi/q35/DSDT.tis.tpm2", +"tests/data/acpi/q35/DSDT.tis.tpm12", +"tests/data/acpi/q35/DSDT.multi-bridge", +"tests/data/acpi/q35/DSDT.ivrs", +"tests/data/acpi/q35/DSDT.xapic", From patchwork Wed Nov 10 21:11:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12613067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B4BC433EF for ; Wed, 10 Nov 2021 21:15:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BFBF61250 for ; Wed, 10 Nov 2021 21:15:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BFBF61250 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkuwn-0003Cb-AI for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:15:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkusw-00044x-GV for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkuss-0002WD-G7 for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:11:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636578713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pS+4xDNcZYt4ikFpHqXiWgz0JzNTvY4QfS51TJN1NBk=; b=Ee54XYwfY3l9d3MSNqCtU7OGIzdmtcfUsK8WlHsN6x5EWYD2c8n5oTI7VQZEW3GMRVAYDO lvtdOue3CVDDKqEYCtUkueISrinCOds+GEKi/bjvsdcnrV9mpup43DDvJ3Jqo+8pwnAXtM 7OYyucdTXgJ1ojciaXNomLWMy/Q1yhg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-P6AJlGsgN8uJxyWdjDlvnQ-1; Wed, 10 Nov 2021 16:11:51 -0500 X-MC-Unique: P6AJlGsgN8uJxyWdjDlvnQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6AA0804141; Wed, 10 Nov 2021 21:11:50 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9254867840; Wed, 10 Nov 2021 21:11:49 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Date: Wed, 10 Nov 2021 16:11:39 -0500 Message-Id: <20211110211140.3057199-5-imammedo@redhat.com> In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com> References: <20211110211140.3057199-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ani@anisinha.ca, mapfelba@redhat.com, jusual@redhat.com, kraxel@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Julia Suvorova There are two ways to enable ACPI PCI Hot-plug: * Disable the Hot-plug Capable bit on PCIe slots. This was the first approach which led to regression [1-2], as I/O space for a port is allocated only when it is hot-pluggable, which is determined by HPC bit. * Leave the HPC bit on and disable PCIe Native Hot-plug in _OSC method. This removes the (future) ability of hot-plugging switches with PCIe Native hotplug since ACPI PCI Hot-plug only works with cold-plugged bridges. If the user wants to explicitely use this feature, they can disable ACPI PCI Hot-plug with: --global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off Change the bit in _OSC method so that the OS selects ACPI PCI Hot-plug instead of PCIe Native. [1] https://gitlab.com/qemu-project/qemu/-/issues/641 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409 Signed-off-by: Julia Suvorova Signed-off-by: Igor Mammedov --- v2: - (mst) * drop local hotplug var and opencode it * rename acpi_pcihp parameter to enable_native_pcie_hotplug to reflect what it actually does tested: with hotplugging nic into 1 root port with seabios/ovmf/Fedora34 Windows tested only with seabios (using exiting images) (installer fails to install regardless on bios) --- hw/i386/acpi-build.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index a3ad6abd33..a99c6e4fe3 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1337,7 +1337,7 @@ static void build_x86_acpi_pci_hotplug(Aml *table, uint64_t pcihp_addr) aml_append(table, scope); } -static Aml *build_q35_osc_method(void) +static Aml *build_q35_osc_method(bool enable_native_pcie_hotplug) { Aml *if_ctx; Aml *if_ctx2; @@ -1359,8 +1359,10 @@ static Aml *build_q35_osc_method(void) /* * Always allow native PME, AER (no dependencies) * Allow SHPC (PCI bridges can have SHPC controller) + * Disable PCIe Native Hot-plug if ACPI PCI Hot-plug is enabled. */ - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl)); + aml_append(if_ctx, aml_and(a_ctrl, + aml_int(0x1E | (enable_native_pcie_hotplug ? 0x1 : 0x0)), a_ctrl)); if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1)))); /* Unknown revision */ @@ -1449,7 +1451,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03"))); aml_append(dev, aml_name_decl("_ADR", aml_int(0))); aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid))); - aml_append(dev, build_q35_osc_method()); + aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en)); aml_append(sb_scope, dev); if (mcfg_valid) { aml_append(sb_scope, build_q35_dram_controller(&mcfg)); @@ -1565,7 +1567,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, if (pci_bus_is_express(bus)) { aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08"))); aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03"))); - aml_append(dev, build_q35_osc_method()); + + /* Expander bridges do not have ACPI PCI Hot-plug enabled */ + aml_append(dev, build_q35_osc_method(true)); } else { aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03"))); } From patchwork Wed Nov 10 21:11:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12613069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8A9C433EF for ; Wed, 10 Nov 2021 21:17:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E6CB60E8D for ; Wed, 10 Nov 2021 21:17:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E6CB60E8D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkuyD-0004mS-Kt for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:17:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkut2-0004Ac-6F for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:12:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkusu-0002Wl-CB for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:12:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636578715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+/lEqgIo3stmsWSN/R54BUhJCSqTkkS5vfaF6RIjzo=; b=iRImMZVZgztvnZzd7hyvwTO9TUQ+TnnK6JjT6s+KCA/uJhcgEyLMQ8YfATAMVhBpUJk5l7 ILM6ppes0yJoleRFlK5lpNZ2m84k11h7aifdE0rcr3U+wjj7vAlvD7M+pamzr8RwYN7V7m 49a9pofkNKc+rdEJiTXl3ujd/SwT0Qc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-yGk9r1HuNf2PGUaydfqbZA-1; Wed, 10 Nov 2021 16:11:53 -0500 X-MC-Unique: yGk9r1HuNf2PGUaydfqbZA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5CE9804142; Wed, 10 Nov 2021 21:11:52 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CF7267841; Wed, 10 Nov 2021 21:11:51 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Date: Wed, 10 Nov 2021 16:11:40 -0500 Message-Id: <20211110211140.3057199-6-imammedo@redhat.com> In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com> References: <20211110211140.3057199-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ani@anisinha.ca, mapfelba@redhat.com, jusual@redhat.com, kraxel@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Julia Suvorova The changes are the result of 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC' and listed here: Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities { CreateDWordField (Arg3, Zero, CDW1) If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */)) { CreateDWordField (Arg3, 0x04, CDW2) CreateDWordField (Arg3, 0x08, CDW3) Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */ - Local0 &= 0x1F + Local0 &= 0x1E Signed-off-by: Julia Suvorova Signed-off-by: Igor Mammedov Acked-by: Ani Sinha --- tests/qtest/bios-tables-test-allowed-diff.h | 16 ---------------- tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes 20 files changed, 16 deletions(-) create mode 100644 tests/data/acpi/q35/DSDT.dmar create mode 100644 tests/data/acpi/q35/DSDT.nosmm create mode 100644 tests/data/acpi/q35/DSDT.smm-compat create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm GIT binary patch literal 8289 zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pFU+JE-@ z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_ zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8 z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G z{=1>&ghTt2LC6MSdNkT+!-Y=2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!( z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp` z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-gCN zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h| z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3 ziHZCi8{DXU;!2`tZ(;7kck z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ETW^QHJzre z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC z7$`#Yh+|=(0y~bz8ab2V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}dAz;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B zKouw%sDN@N87M-j69y``0?L_Wpa`W- z7^uKf}LawZul zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO zNd}5g>V$y`EN8+%6(|{~fN~}oC_PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn- z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0! zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R zVnDcU9O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc! zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R-NpK?-j+}CDUUxiugB>o zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rgp}D znMxBnMx*eGJ#k#Y44 zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!qzZ}jF`ql_#zKmvF zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(jfyqrA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq# z-r`OxahY%JRTFdS)s Cro3tZ literal 0 HcmV?d00001 diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12 index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644 GIT binary patch delta 24 gcmdnzy3du%CDyjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh delta 26 icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 48e5634d4b..dfb8523c8b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,17 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/q35/DSDT", -"tests/data/acpi/q35/DSDT.tis", -"tests/data/acpi/q35/DSDT.bridge", -"tests/data/acpi/q35/DSDT.mmio64", -"tests/data/acpi/q35/DSDT.ipmibt", -"tests/data/acpi/q35/DSDT.cphp", -"tests/data/acpi/q35/DSDT.memhp", -"tests/data/acpi/q35/DSDT.acpihmat", -"tests/data/acpi/q35/DSDT.numamem", -"tests/data/acpi/q35/DSDT.dimmpxm", -"tests/data/acpi/q35/DSDT.nohpet", -"tests/data/acpi/q35/DSDT.tis.tpm2", -"tests/data/acpi/q35/DSDT.tis.tpm12", -"tests/data/acpi/q35/DSDT.multi-bridge", -"tests/data/acpi/q35/DSDT.ivrs", -"tests/data/acpi/q35/DSDT.xapic", diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644 GIT binary patch delta 24 gcmaFp@X&$FCDET<0BnZ{w*UYD delta 24 gcmaFp@X&$FCDET<0BnK?w*UYD diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644 GIT binary patch delta 24 fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn delta 24 fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644 GIT binary patch delta 24 gcmewz`a6`%CDF$oF>WH)6-K#@_k$DxTWtqt delta 24 fcmdn!veAXhCDF$oF?J%?6-N1u_k$DxTWAMo diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644 GIT binary patch delta 24 gcmccad)=4ICDU+JE-@ z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_ zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8 z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G z{=1>&ghTt2LC6MSdNkT+!-Y=2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!( z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp` z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-gCN zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h| z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3 ziHZCi8{DXU;!2`tZ(;7kck z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ETW^QHJzre z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC z7$`#Yh+|=(0y~bz8ab2V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}dAz;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B zKouw%sDN@N87M-j69y``0?L_Wpa`W- z7^uKf}LawZul zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO zNd}5g>V$y`EN8+%6(|{~fN~}oC_PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn- z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0! zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R zVnDcU9O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc! zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R-NpK?-j+}CDUUxiugB>o zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rgp}D znMxBnMx*eGJ#k#Y44 zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!qzZ}jF`ql_#zKmvF zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(jfyqrA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq# z-r`OxahY%JRTFdS)s Cro3tZ literal 0 HcmV?d00001 diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644 GIT binary patch delta 24 gcmZ4ExWD~$3R?@yKo0BrFHn*aa+ diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644 GIT binary patch delta 24 gcmdnsy}_HyCD7Sg;8$f{S^uTTRaEr delta 24 fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644 GIT binary patch delta 24 gcmca?f7zbPCDU+JE-@ z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_ zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8 z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G z{=1>&ghTt2LC6MSdNkT+!-Y=2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!( z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp` z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-gCN zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h| z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3 ziHZCi8{DXU;!2`tZ(;7kck z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ETW^QHJzre z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC z7$`#Yh+|=(0y~bz8ab2V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}dAz;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B zKouw%sDN@N87M-j69y``0?L_Wpa`W- z7^uKf}LawZul zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO zNd}5g>V$y`EN8+%6(|{~fN~}oC_PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn- z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0! zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R zVnDcU9O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc! zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R-NpK?-j+}CDUUxiugB>o zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rgp}D znMxBnMx*eGJ#k#Y44 zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!qzZ}jF`ql_#zKmvF zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(jfyqrA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq# z-r`OxahY%JRTFdS)s Cro3tZ literal 0 HcmV?d00001 diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644 GIT binary patch delta 24 gcmaFv@Z5pRCDn+a delta 24 gcmaFv@Z5pRCDn+a diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat new file mode 100644 index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033 GIT binary patch literal 8289 zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pFU+JE-@ z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_ zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8 z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G z{=1>&ghTt2LC6MSdNkT+!-Y=2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!( z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp` z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-gCN zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h| z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3 ziHZCi8{DXU;!2`tZ(;7kck z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ETW^QHJzre z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC z7$`#Yh+|=(0y~bz8ab2V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}dAz;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B zKouw%sDN@N87M-j69y``0?L_Wpa`W- z7^uKf}LawZul zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO zNd}5g>V$y`EN8+%6(|{~fN~}oC_PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn- z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0! zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R zVnDcU9O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc! zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R-NpK?-j+}CDUUxiugB>o zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rgp}D znMxBnMx*eGJ#k#Y44 zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!qzZ}jF`ql_#zKmvF zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(jfyqrA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq# z-r`OxahY%JRTFdS)s Cro3tZ literal 0 HcmV?d00001 diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm new file mode 100644 index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033