From patchwork Tue Nov 16 10:39:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12621971 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E51D3C433F5 for ; Tue, 16 Nov 2021 10:40:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFBCB60F44 for ; Tue, 16 Nov 2021 10:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234461AbhKPKnq (ORCPT ); Tue, 16 Nov 2021 05:43:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:51658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234330AbhKPKm6 (ORCPT ); Tue, 16 Nov 2021 05:42:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E52960F44; Tue, 16 Nov 2021 10:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637059201; bh=XQNhhOwY7CNCcEEDeCs8Qr9sMVB4unBMSmPawoOiXGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KMNXEVQIj5ecNinUXIskocjhA5ebXZHxafEfWSSoyZKscqC676ixPWFVXGxkBLT4l E5V4djFgVl6Eru079C3HSPX4bHN84nfILjwqwcaIotCM58/65oICT9MHs2d2qI/E+1 +7AbIRZ2XiN3GYlbSaWGTjbViUCCWf2KbhD2gBxa+msiIc7+TSzccIUOwHUTNLYMGJ QglozS3sdAhomB74li73hx6STbgi1j6rK2OMouTx2492tPhhGK/5VWoNDcLgR6P8GR uuoDjp9wZXC9GNxs2KW4XIgMzNs7I5AX3RdHOErYN97xLn2K+LXqh/AgglAO1XX7Qs w5YdXj2KBE4mw== From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, Vinod Koul , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] phy: qualcomm: ipq806x-usb: Fix kernel-doc style Date: Tue, 16 Nov 2021 16:09:47 +0530 Message-Id: <20211116103951.34482-2-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211116103951.34482-1-vkoul@kernel.org> References: <20211116103951.34482-1-vkoul@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The functions are documented but there were style issues, so fix the style and add missing description for phy_dwc3 drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:130: drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:174: drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:212: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Vinod Koul Reviewed-by: Randy Dunlap --- drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 26 +++++++++++---------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c index bfff0c8c9130..e1b8fa911416 100644 --- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c @@ -127,12 +127,13 @@ struct phy_drvdata { }; /** - * Write register and read back masked value to confirm it is written + * usb_phy_write_readback - Write register and read back masked value to + * confirm it is written * - * @base - QCOM DWC3 PHY base virtual address. - * @offset - register offset. - * @mask - register bitmask specifying what should be updated - * @val - value to write. + * @phy_dwc3: QCOM DWC3 PHY base virtual address. + * @offset: register offset. + * @mask: register bitmask specifying what should be updated + * @val: value to write. */ static inline void usb_phy_write_readback(struct usb_phy *phy_dwc3, u32 offset, @@ -171,11 +172,11 @@ static int wait_for_latch(void __iomem *addr) } /** - * Write SSPHY register + * usb_ss_write_phycreg - Write SSPHY register * - * @base - QCOM DWC3 PHY base virtual address. - * @addr - SSPHY address to write. - * @val - value to write. + * @phy_dwc3: QCOM DWC3 PHY base virtual address. + * @addr: SSPHY address to write. + * @val: value to write. */ static int usb_ss_write_phycreg(struct usb_phy *phy_dwc3, u32 addr, u32 val) @@ -209,10 +210,11 @@ static int usb_ss_write_phycreg(struct usb_phy *phy_dwc3, } /** - * Read SSPHY register. + * usb_ss_read_phycreg - Read SSPHY register. * - * @base - QCOM DWC3 PHY base virtual address. - * @addr - SSPHY address to read. + * @phy_dwc3: QCOM DWC3 PHY base virtual address. + * @addr: SSPHY address to read. + * @val: pointer in which read is store. */ static int usb_ss_read_phycreg(struct usb_phy *phy_dwc3, u32 addr, u32 *val) From patchwork Tue Nov 16 10:39:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12621973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958D7C433EF for ; Tue, 16 Nov 2021 10:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D68761A58 for ; Tue, 16 Nov 2021 10:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234274AbhKPKns (ORCPT ); Tue, 16 Nov 2021 05:43:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:51664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234350AbhKPKnC (ORCPT ); Tue, 16 Nov 2021 05:43:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B1B36321B; Tue, 16 Nov 2021 10:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637059204; bh=LKtUNo+Ptcd/YQ16xYGBnhORd2bTIpSekrD4tpIsZdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UzwjbUFweX+788xhBrvLd9Xh/zFX58bQe92APMBTm8LEnJT7XzdLDoLnFFlZmsgzm M3x1dyTkT/VxEI5/6yQSp7RZxMnMtecpmx1mpVza27Ap8LVDGMmALiMjIHRxXIocRS 1sJgNAhUWMXmsaCsuKM5jLwn42e+UC0NnMKm7uW9F/q4YupjqZQCnvd89n6G3siOzu TRVyabPV5eBsYy8hEDW2T5ne3874s7tCYTJvkuIB/ulMyQqzreRCFuVSC+BXhq3PBM x2C/sOG/yvEyuViQwivz+llKeWUCemC1xqqCIXZ9X3AUlqd3ag7XKHxeDy+K7HGSoZ uJR1bBbrukSlA== From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, Vinod Koul , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] phy: qualcomm: qmp: Add missing struct documentation Date: Tue, 16 Nov 2021 16:09:48 +0530 Message-Id: <20211116103951.34482-3-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211116103951.34482-1-vkoul@kernel.org> References: <20211116103951.34482-1-vkoul@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org dp-* members were added to qmp_phy_combo_cfg but documentation was missed, so add that. drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_aux_cfg' not described in 'qmp_phy' drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_opts' not described in 'qmp_phy' drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_clks' not described in 'qmp_phy' Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 456a59d8c7d0..c96639d5f581 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -2973,6 +2973,9 @@ struct qmp_phy_combo_cfg { * @qmp: QMP phy to which this lane belongs * @lane_rst: lane's reset controller * @mode: current PHY mode + * @dp_aux_cfg: Display port aux config + * @dp_opts: Display port optional config + * @dp_clks: Display port clocks */ struct qmp_phy { struct phy *phy; From patchwork Tue Nov 16 10:39:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12621975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC888C433FE for ; Tue, 16 Nov 2021 10:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4D2460F44 for ; Tue, 16 Nov 2021 10:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234332AbhKPKnt (ORCPT ); Tue, 16 Nov 2021 05:43:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:51686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234355AbhKPKnF (ORCPT ); Tue, 16 Nov 2021 05:43:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AD4063220; Tue, 16 Nov 2021 10:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637059208; bh=Qc8ZBQhWfMzGFC9zpZm7g87nQ9jQMAL3DvjJ2hBhgmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzPqL3UyQcmcZiJX6U3NS438wu6gGJ1n5sDkidLASCsTuQS6gzeFIvT5RsAMrHNx2 Nf8q6PwMoO/Y7VOpSrAKYJe6hZbOS2Y792wKPu/CPeJOVShT+bqn7uIEJD2tKIRQkz m63fPTlvlkBwvvx91nSxXh/oqdTL/zyP//c95XclNT7scFNO6KOG1THq/UesFJS/EU ik70F4f0TjZ87JA7D1+gz+Zbh3hGE4Xa+bfS8cUWQxh9/S0T4qUZHocSRjgYPj/6nB 3j/24P2A00o0Q9dri5OusssRrvBxEie4HUj62Pg/DP8/1nEuTAmdSxvbRnf/M0f86u QGpSQ8S1D0iVg== From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, Vinod Koul , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] phy: qualcomm: usb-hsic: Fix the kernel-doc warn Date: Tue, 16 Nov 2021 16:09:49 +0530 Message-Id: <20211116103951.34482-4-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211116103951.34482-1-vkoul@kernel.org> References: <20211116103951.34482-1-vkoul@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The comment is not kernel-doc one and starts with /**, so fix that. drivers/phy/qualcomm/phy-qcom-usb-hsic.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson --- drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c index 04d18d52f700..716a77748ed8 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) 2016 Linaro Ltd */ #include