From patchwork Wed Dec 19 08:30:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emmanuel Grumbach X-Patchwork-Id: 10736837 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18B8E6C2 for ; Wed, 19 Dec 2018 08:31:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A20B2AD1B for ; Wed, 19 Dec 2018 08:31:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0568D2AD3A; Wed, 19 Dec 2018 08:31:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D73C2AD1B for ; Wed, 19 Dec 2018 08:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbeLSIa7 (ORCPT ); Wed, 19 Dec 2018 03:30:59 -0500 Received: from mga18.intel.com ([134.134.136.126]:6101 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725294AbeLSIa7 (ORCPT ); Wed, 19 Dec 2018 03:30:59 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 00:30:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="129083805" Received: from egrumbac-mobl1.jer.intel.com ([10.12.117.14]) by fmsmga004.fm.intel.com with ESMTP; 19 Dec 2018 00:30:56 -0800 From: Emmanuel Grumbach To: linux-wireless@vger.kernel.org Cc: sara.sharon@intel.com, sfr@canb.auug.org.au, kvalo@codeaurora.org, Emmanuel Grumbach Subject: [PATCH] iwlwifi: add missing break / fall-through in switch cases Date: Wed, 19 Dec 2018 10:30:53 +0200 Message-Id: <20181219083053.17530-1-emmanuel.grumbach@intel.com> X-Mailer: git-send-email 2.14.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Two switch cases that were added recently missed break statement and explicit fall-through. Fix this. Fixes: f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 5 +++++ drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c index bc1e4d4bb42d..b05fe75394fa 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c @@ -196,11 +196,16 @@ static int iwl_parse_fw_dbg_tlv(struct iwl_trans *trans, const u8 *data, switch (tlv_type) { case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION: + /* fall-through */ case IWL_UCODE_TLV_TYPE_HCMD: + /* fall-through */ case IWL_UCODE_TLV_TYPE_REGIONS: + /* fall-through */ case IWL_UCODE_TLV_TYPE_TRIGGERS: + /* fall-through */ case IWL_UCODE_TLV_TYPE_DEBUG_FLOW: iwl_fw_dbg_copy_tlv(trans, tlv, true); + break; default: WARN_ONCE(1, "Invalid TLV %x\n", tlv_type); break; diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index a65ba955783d..db95cb81c67d 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -1091,12 +1091,17 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv, break; } case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION: + /* fall-through */ case IWL_UCODE_TLV_TYPE_HCMD: + /* fall-through */ case IWL_UCODE_TLV_TYPE_REGIONS: + /* fall-through */ case IWL_UCODE_TLV_TYPE_TRIGGERS: + /* fall-through */ case IWL_UCODE_TLV_TYPE_DEBUG_FLOW: if (iwlwifi_mod_params.enable_ini) iwl_fw_dbg_copy_tlv(drv->trans, tlv, false); + break; default: IWL_DEBUG_INFO(drv, "unknown TLV: %d\n", tlv_type); break;