From patchwork Wed Dec  1 03:37:26 2021
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=
 <aleen42@vip.qq.com>
X-Patchwork-Id: 12648965
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 80761C433EF
	for <git@archiver.kernel.org>; Wed,  1 Dec 2021 03:37:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346493AbhLADlJ (ORCPT <rfc822;git@archiver.kernel.org>);
        Tue, 30 Nov 2021 22:41:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39232 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1346483AbhLADk6 (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 30 Nov 2021 22:40:58 -0500
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com
 [IPv6:2a00:1450:4864:20::434])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6E8C061748
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:33 -0800 (PST)
Received: by mail-wr1-x434.google.com with SMTP id s13so49026624wrb.3
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:in-reply-to:references:from:date:subject:mime-version
         :content-transfer-encoding:fcc:to:cc;
        bh=2wOIUyXvK6HBA37YvvgtpeXS/BCdUCODvPh5e+IWqzE=;
        b=Z/r/KVQMuKpy5po71rq77QPTovJOzl4h5ODO915XU+70dQruVdFp9M3tb9DDtVopKu
         Vl2wWz0cyfoB0p1kNrMIEzn9Jvy/1z9R3mWL+dEJMXOL+ovCH+92n1GWmmvxWcSvOJhU
         ZDPTb4xtmACbcuE5YMObC2xERy9ZTlZElH32Tc507kVbflJ5t1Gicpg38THylaA/l+Tp
         hS+AlQKCAhcgth/IG85oNM8gNAPOXx3mNlGC9f64G1zG7V21M6/fBMgONIHdOdXeE1rJ
         QcNrkLbH20ak0/Ox8Z1zaEnKyIwtB4CjcwpqmNdp3yI4QA/xn3vD5vHmqwbknLki28dT
         Ouvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:in-reply-to:references:from:date
         :subject:mime-version:content-transfer-encoding:fcc:to:cc;
        bh=2wOIUyXvK6HBA37YvvgtpeXS/BCdUCODvPh5e+IWqzE=;
        b=bF8NxIungzVYMGuKEdPC6j9BfdkJp8AjD/vVPw+yZUgylEvHGtGSQ/iaCn1r8X2YJc
         hiO25u3tK/E39riUCAIt6pq6Nyp7U27CwVyymPsq37Azklb3SZ6LxKkmy1ZM+BG6y2Pa
         GXu8TgIblkFu75AU18OjM+qAZNPknFF2uXECrPNzJBZ1oLMdFTTkQS5ltd+vSqnKmZvU
         fxbanvnnFPKbPYyYFCR8Bpsa/SZDfazuTvv+5UagnVE8RO4C4ZydXscOnlg9i/0agYcr
         sGLKXneqKHOJEEtnI1Ev0vanwhbX2Zb+B9WDQDdjXnIcEZkMrrk9CwT+gEZy8xEX+ojh
         XaFg==
X-Gm-Message-State: AOAM533GL4mBa52/ntezq1NDASvN6GxN9TX7Xa7tXiryI9bJMIE9SmNm
        +KPn2ZWOZyGHfBwKXguQMnW/2RFtXfU=
X-Google-Smtp-Source: 
 ABdhPJwW0ASOUgbgj+GWWmh/80R0kc7HV6i3mMs4SidP90yDCI+iyYHIUoN/E04FFTXIGMDPWdz3sQ==
X-Received: by 2002:a05:6000:248:: with SMTP id
 m8mr3781037wrz.404.1638329851637;
        Tue, 30 Nov 2021 19:37:31 -0800 (PST)
Received: from [127.0.0.1] ([13.74.141.28])
        by smtp.gmail.com with ESMTPSA id 9sm22856860wry.0.2021.11.30.19.37.30
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 30 Nov 2021 19:37:31 -0800 (PST)
Message-Id: 
 <a524ca6adfa2adc02e517b7be5199b0c071134c4.1638329848.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
References: <pull.1076.v13.git.1638266115.gitgitgadget@gmail.com>
        <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
Date: Wed, 01 Dec 2021 03:37:26 +0000
Subject: [PATCH v14 1/3] doc: git-format-patch: describe the option --always
MIME-Version: 1.0
Fcc: Sent
To: git@vger.kernel.org
Cc: =?utf-8?b?UmVuw6k=?= Scharfe <l.s.r@web.de>,
 Phillip Wood <phillip.wood123@gmail.com>,
 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
 Elijah Newren <newren@gmail.com>,
 Aleen =?utf-8?b?5b6Q5rKb5paH?= <pwxu@coremail.cn>,
 Aleen <aleen42@vip.qq.com>,
 =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=  <aleen42@vip.qq.com>
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
From: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?= <aleen42@vip.qq.com>

From: =?UTF-8?q?=E5=BE=90=E6=B2=9B=E6=96=87=20=28Aleen=29?=
 <aleen42@vip.qq.com>

This commit has described how to use '--always' option in the command
'git-format-patch' to include patches for commits that emit no changes.

Signed-off-by: 徐沛文 (Aleen) <aleen42@vip.qq.com>
---
 Documentation/git-format-patch.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
index 113eabc107c..be797d7a28f 100644
--- a/Documentation/git-format-patch.txt
+++ b/Documentation/git-format-patch.txt
@@ -18,7 +18,7 @@ SYNOPSIS
 		   [-n | --numbered | -N | --no-numbered]
 		   [--start-number <n>] [--numbered-files]
 		   [--in-reply-to=<message id>] [--suffix=.<sfx>]
-		   [--ignore-if-in-upstream]
+		   [--ignore-if-in-upstream] [--always]
 		   [--cover-from-description=<mode>]
 		   [--rfc] [--subject-prefix=<subject prefix>]
 		   [(--reroll-count|-v) <n>]
@@ -192,6 +192,10 @@ will want to ensure that threading is disabled for `git send-email`.
 	patches being generated, and any patch that matches is
 	ignored.
 
+--always::
+	Include patches for commits that do not introduce any change,
+	which are omitted by default.
+
 --cover-from-description=<mode>::
 	Controls which parts of the cover letter will be automatically
 	populated using the branch's description.

From patchwork Wed Dec  1 03:37:27 2021
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=
 <aleen42@vip.qq.com>
X-Patchwork-Id: 12648967
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D9826C433F5
	for <git@archiver.kernel.org>; Wed,  1 Dec 2021 03:37:56 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346500AbhLADlN (ORCPT <rfc822;git@archiver.kernel.org>);
        Tue, 30 Nov 2021 22:41:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39234 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1346488AbhLADk7 (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 30 Nov 2021 22:40:59 -0500
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [IPv6:2a00:1450:4864:20::431])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC67C06174A
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:34 -0800 (PST)
Received: by mail-wr1-x431.google.com with SMTP id d24so49050565wra.0
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:in-reply-to:references:from:date:subject:mime-version
         :content-transfer-encoding:fcc:to:cc;
        bh=vqb92b3g7asAMRf0S4ek+aRv5Ks1Wlyp8jv/nSGcTJI=;
        b=HMsJd5kLpBbJlcEmjMJy+1qXE+uY7NPwQRKrgL/NySifA/GW7T9+yLYqpyKERi1mpr
         mdEfkLGJri3umIv6yJsdA6hcyE6QWgO9gWmexXpkbt+jAzlwQ7wWKDB6R+YwH/C7FJwZ
         eANB/ww1btvU/hW6DU0zokJasCjrJjNbMTxsxj87vAVHinLQE3FgxdRXh1y2imTXEFFD
         gWJw/UFq4XQ0iRfHGMkkUvdqsRkUHgtfSeoZkMjt2DIhsNTvzjHVcpTWUkkOCO/n7ALE
         yrxVfRYD5PAoFFIlI/RJ2dwVQ85sRCDLeKLFi2V65yEZmulUybC45BNOoL+GTxLy0hnx
         ZnmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:in-reply-to:references:from:date
         :subject:mime-version:content-transfer-encoding:fcc:to:cc;
        bh=vqb92b3g7asAMRf0S4ek+aRv5Ks1Wlyp8jv/nSGcTJI=;
        b=fCYAJiQcMYNhddsoTKsRE97246E2Z6HebDWYdiFhlE/pnTtGbRcOTYe88nC6MiRpE3
         qOMC5+wZ4sV0X2M/naTNmh/74CvkjoCTwV8O0JwK1ZpxeGEK6Rh6wkipaWWacANkk9Up
         8BS4DxMXz/9WKRc9aM6g7VlTcbVvEuKURrVIzhiwFEYH9QVVbTQXWAzcnCtMOsnVldl5
         msAeH8t2/F3wtMGKLnDarlTeqGRm9nxmtsJBxniRHIf14PY5wVl9YLAwRCsfdIF7rO9j
         Tb9XnqqIh4A3OGydtnC/tyfsjFjl27pUeIIwLfuPCjWBJnZyg2I14ahWk65G5YLUFP27
         350Q==
X-Gm-Message-State: AOAM530gscXxoB3WmqSSi6qAyscgmZA6Dnl6uuag8AfVeLBQq98PzGO3
        AcjzOOva4OlzhNhmblJ/UB1PcZZBhTg=
X-Google-Smtp-Source: 
 ABdhPJzC43+AFHT5TtcbJGxJ1byGoNARoR970uWyjWTI+8SAPPL2zKSBsv79PcF3ZWOJwjWv1CSDVQ==
X-Received: by 2002:a05:6000:1010:: with SMTP id
 a16mr3603745wrx.155.1638329852536;
        Tue, 30 Nov 2021 19:37:32 -0800 (PST)
Received: from [127.0.0.1] ([13.74.141.28])
        by smtp.gmail.com with ESMTPSA id
 u15sm4004505wmq.13.2021.11.30.19.37.31
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 30 Nov 2021 19:37:32 -0800 (PST)
Message-Id: 
 <b6a04fc12dfd1680b81bc946b09d4519edf3555e.1638329848.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
References: <pull.1076.v13.git.1638266115.gitgitgadget@gmail.com>
        <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
Date: Wed, 01 Dec 2021 03:37:27 +0000
Subject: [PATCH v14 2/3] am: support --empty=<option> to handle empty patches
MIME-Version: 1.0
Fcc: Sent
To: git@vger.kernel.org
Cc: =?utf-8?b?UmVuw6k=?= Scharfe <l.s.r@web.de>,
 Phillip Wood <phillip.wood123@gmail.com>,
 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
 Elijah Newren <newren@gmail.com>,
 Aleen =?utf-8?b?5b6Q5rKb5paH?= <pwxu@coremail.cn>,
 Aleen <aleen42@vip.qq.com>,
 =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=  <aleen42@vip.qq.com>
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
From: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?= <aleen42@vip.qq.com>

From: =?UTF-8?q?=E5=BE=90=E6=B2=9B=E6=96=87=20=28Aleen=29?=
 <aleen42@vip.qq.com>

Since that the command 'git-format-patch' can include patches of
commits that emit no changes, the 'git-am' command should also
support an option, named as '--empty', to specify how to handle
those empty patches. In this commit, we have implemented three
valid options ('die', 'drop' and 'keep').

Signed-off-by: 徐沛文 (Aleen) <aleen42@vip.qq.com>
---
 Documentation/git-am.txt |  9 +++++++
 builtin/am.c             | 55 ++++++++++++++++++++++++++++++++++++----
 t/t4150-am.sh            | 49 +++++++++++++++++++++++++++++++++++
 3 files changed, 108 insertions(+), 5 deletions(-)

diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
index 0a4a984dfde..cf9cace9678 100644
--- a/Documentation/git-am.txt
+++ b/Documentation/git-am.txt
@@ -16,6 +16,7 @@ SYNOPSIS
 	 [--exclude=<path>] [--include=<path>] [--reject] [-q | --quiet]
 	 [--[no-]scissors] [-S[<keyid>]] [--patch-format=<format>]
 	 [--quoted-cr=<action>]
+	 [--empty=(die|drop|keep)]
 	 [(<mbox> | <Maildir>)...]
 'git am' (--continue | --skip | --abort | --quit | --show-current-patch[=(diff|raw)])
 
@@ -63,6 +64,14 @@ OPTIONS
 --quoted-cr=<action>::
 	This flag will be passed down to 'git mailinfo' (see linkgit:git-mailinfo[1]).
 
+--empty=(die|drop|keep)::
+	By default, or when the option is set to 'die', the command
+	errors out on an input e-mail message lacking a patch
+	and stops into the middle of the current am session. When this
+	option is set to 'drop', skip such an e-mail message instead.
+	When this option is set to 'keep', create an empty commit,
+	recording the contents of the e-mail message as its log.
+
 -m::
 --message-id::
 	Pass the `-m` flag to 'git mailinfo' (see linkgit:git-mailinfo[1]),
diff --git a/builtin/am.c b/builtin/am.c
index 8677ea2348a..cc6512275aa 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -87,6 +87,12 @@ enum show_patch_type {
 	SHOW_PATCH_DIFF = 1,
 };
 
+enum empty_action {
+	DIE_EMPTY_COMMIT = 0,  /* output errors */
+	DROP_EMPTY_COMMIT,     /* skip with a notice message, unless "--quiet" has been passed */
+	KEEP_EMPTY_COMMIT      /* keep recording as empty commits */
+};
+
 struct am_state {
 	/* state directory path */
 	char *dir;
@@ -118,6 +124,7 @@ struct am_state {
 	int message_id;
 	int scissors; /* enum scissors_type */
 	int quoted_cr; /* enum quoted_cr_action */
+	int empty_type; /* enum empty_action */
 	struct strvec git_apply_opts;
 	const char *resolvemsg;
 	int committer_date_is_author_date;
@@ -178,6 +185,25 @@ static int am_option_parse_quoted_cr(const struct option *opt,
 	return 0;
 }
 
+static int am_option_parse_empty(const struct option *opt,
+				     const char *arg, int unset)
+{
+	int *opt_value = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+
+	if (!strcmp(arg, "die"))
+		*opt_value = DIE_EMPTY_COMMIT;
+	else if (!strcmp(arg, "drop"))
+		*opt_value = DROP_EMPTY_COMMIT;
+	else if (!strcmp(arg, "keep"))
+		*opt_value = KEEP_EMPTY_COMMIT;
+	else
+		return error(_("Invalid value for --empty: %s"), arg);
+
+	return 0;
+}
+
 /**
  * Returns path relative to the am_state directory.
  */
@@ -1248,11 +1274,6 @@ static int parse_mail(struct am_state *state, const char *mail)
 		goto finish;
 	}
 
-	if (is_empty_or_missing_file(am_path(state, "patch"))) {
-		printf_ln(_("Patch is empty."));
-		die_user_resolve(state);
-	}
-
 	strbuf_addstr(&msg, "\n\n");
 	strbuf_addbuf(&msg, &mi.log_message);
 	strbuf_stripspace(&msg, 0);
@@ -1763,6 +1784,7 @@ static void am_run(struct am_state *state, int resume)
 	while (state->cur <= state->last) {
 		const char *mail = am_path(state, msgnum(state));
 		int apply_status;
+		int to_keep;
 
 		reset_ident_date();
 
@@ -1792,8 +1814,27 @@ static void am_run(struct am_state *state, int resume)
 		if (state->interactive && do_interactive(state))
 			goto next;
 
+		to_keep = 0;
+		if (is_empty_or_missing_file(am_path(state, "patch"))) {
+			switch (state->empty_type) {
+			case DROP_EMPTY_COMMIT:
+				say(state, stdout, _("Skipping: %.*s"), linelen(state->msg), state->msg);
+				goto next;
+				break;
+			case KEEP_EMPTY_COMMIT:
+				to_keep = 1;
+				break;
+			case DIE_EMPTY_COMMIT:
+				printf_ln(_("Patch is empty."));
+				die_user_resolve(state);
+				break;
+			}
+		}
+
 		if (run_applypatch_msg_hook(state))
 			exit(1);
+		if (to_keep)
+			goto commit;
 
 		say(state, stdout, _("Applying: %.*s"), linelen(state->msg), state->msg);
 
@@ -1827,6 +1868,7 @@ static void am_run(struct am_state *state, int resume)
 			die_user_resolve(state);
 		}
 
+commit:
 		do_commit(state);
 
 next:
@@ -2357,6 +2399,9 @@ int cmd_am(int argc, const char **argv, const char *prefix)
 		{ OPTION_STRING, 'S', "gpg-sign", &state.sign_commit, N_("key-id"),
 		  N_("GPG-sign commits"),
 		  PARSE_OPT_OPTARG, NULL, (intptr_t) "" },
+		OPT_CALLBACK_F(0, "empty", &state.empty_type, "{drop,keep,die}",
+		  N_("how to handle empty patches"),
+		  PARSE_OPT_NONEG, am_option_parse_empty),
 		OPT_HIDDEN_BOOL(0, "rebasing", &state.rebasing,
 			N_("(internal use for git-rebase)")),
 		OPT_END()
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 2aaaa0d7ded..8c8bd4db220 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -196,6 +196,12 @@ test_expect_success setup '
 
 	git format-patch -M --stdout lorem^ >rename-add.patch &&
 
+	git checkout -b empty-commit &&
+	git commit -m "empty commit" --allow-empty &&
+
+	: >empty.patch &&
+	git format-patch --always --stdout empty-commit^ >empty-commit.patch &&
+
 	# reset time
 	sane_unset test_tick &&
 	test_tick
@@ -1152,4 +1158,47 @@ test_expect_success 'apply binary blob in partial clone' '
 	git -C client am ../patch
 '
 
+test_expect_success 'an empty input file is error regardless of --empty option' '
+	test_when_finished "git am --abort || :" &&
+	test_must_fail git am --empty=drop empty.patch 2>actual &&
+	echo "Patch format detection failed." >expected &&
+	test_cmp expected actual
+'
+
+test_expect_success 'invalid when passing the --empty option alone' '
+	test_when_finished "git am --abort || :" &&
+	git checkout empty-commit^ &&
+	test_must_fail git am --empty empty-commit.patch 2>err &&
+	echo "error: Invalid value for --empty: empty-commit.patch" >expected &&
+	test_cmp expected err
+'
+
+test_expect_success 'a message without a patch is an error (default)' '
+	test_when_finished "git am --abort || :" &&
+	test_must_fail git am empty-commit.patch >err &&
+	grep "Patch is empty" err
+'
+
+test_expect_success 'a message without a patch is an error where an explicit "--empty=die" is given' '
+	test_when_finished "git am --abort || :" &&
+	test_must_fail git am --empty=die empty-commit.patch >err &&
+	grep "Patch is empty." err
+'
+
+test_expect_success 'a message without a patch will be skipped when "--empty=drop" is given' '
+	git am --empty=drop empty-commit.patch >output &&
+	git rev-parse empty-commit^ >expected &&
+	git rev-parse HEAD >actual &&
+	test_cmp expected actual &&
+	grep "Skipping: empty commit" output
+'
+
+test_expect_success 'record as an empty commit when meeting e-mail message that lacks a patch' '
+	git am --empty=keep empty-commit.patch &&
+	test_path_is_missing .git/rebase-apply &&
+	git show empty-commit --format="%s" >expected &&
+	git show HEAD --format="%s" >actual &&
+	test_cmp actual expected
+'
+
 test_done

From patchwork Wed Dec  1 03:37:28 2021
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=
 <aleen42@vip.qq.com>
X-Patchwork-Id: 12648969
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 56592C433EF
	for <git@archiver.kernel.org>; Wed,  1 Dec 2021 03:38:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346509AbhLADlU (ORCPT <rfc822;git@archiver.kernel.org>);
        Tue, 30 Nov 2021 22:41:20 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39238 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1346490AbhLADk7 (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 30 Nov 2021 22:40:59 -0500
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [IPv6:2a00:1450:4864:20::432])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC7DBC061756
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:34 -0800 (PST)
Received: by mail-wr1-x432.google.com with SMTP id v11so48981303wrw.10
        for <git@vger.kernel.org>; Tue, 30 Nov 2021 19:37:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:in-reply-to:references:from:date:subject:mime-version
         :content-transfer-encoding:fcc:to:cc;
        bh=ANq6GH0zHcMhta3OWbtpL2nORyHkXZfXTBczlP8Tjc4=;
        b=N1Fqn/flrAt4fnETRqLod4Zu2HL8f3SQ5hCyZwpIIcBjedIlxGkzdQ4sW+VOPGVagq
         Nm0PnqZJ5OIwq1j9LZi+IcCWTA368DzsDJHOBPsBe6B1rRZAhrKrYF+ALF+hJCXX3rMJ
         EvvE33SgTeTUzbKBUkLPxC4VC/OkiDzVF0OU/jKg7bjKSvDiNfhjI+yZNTrv0pHgBFSV
         GA0Iphm2NL6ofmaPpMYHEVTdNVl06dqv4LLfhrzdMxKQzHdRpk0d0W/pwq/sNphFcVS0
         XBdzruPXsMsnVzR0R3fbAuGMIj/wUZN8Yjus3lyDt7Y1d5fpqhPPJYYXlYEdvGKXY+6p
         /ojQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:in-reply-to:references:from:date
         :subject:mime-version:content-transfer-encoding:fcc:to:cc;
        bh=ANq6GH0zHcMhta3OWbtpL2nORyHkXZfXTBczlP8Tjc4=;
        b=wBZ/n431n833Xf5KiqJ4Yw+wUwBQIX8yDEf1UA+I/brnflUl3XjvPxGlaAhTlYavcB
         V0lvhoh+LOCsmi/zppaTZZibY91oVw3nY224R24+wW+MWyQUlTTZun+MIiX8wt+gF6pY
         abwvng/9gr/EOCBrT8YETiFxo3R/ZTg9A0wegmlLD5LJw0NVqYWvFgS4TuAyH16m+e74
         7keGxyBPUIzbqvMsXK/C+G3jvxuvOdy55wAtD3WF2RdItbpjIz0JJmOmNcuVZL37ND8z
         fxT+Quffh6H/DnfKw7Gqj0QvYVrps5f+0DS74ENRK0yELR183d447z/2dXuQNE/0lYez
         6v/w==
X-Gm-Message-State: AOAM533J6uRUL+EvYe328167K9tZghV2Zsx30gwUzPJCBPxWXFDDyN3k
        1k8b7CaLd+EPN5pcWI4oQuClkA2unE8=
X-Google-Smtp-Source: 
 ABdhPJw9G4mjJXldrdar8sQdAmwC79bNYDz2qvu9Fdbd+NbkR1IoxQHdcGGz5pXmNfdM4Cj2j/lS6Q==
X-Received: by 2002:a05:6000:1201:: with SMTP id
 e1mr3763562wrx.298.1638329853294;
        Tue, 30 Nov 2021 19:37:33 -0800 (PST)
Received: from [127.0.0.1] ([13.74.141.28])
        by smtp.gmail.com with ESMTPSA id
 m125sm4007161wmm.39.2021.11.30.19.37.32
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 30 Nov 2021 19:37:32 -0800 (PST)
Message-Id: 
 <cbd822d4340f8f3d832e9d6209ee8db6e538fca1.1638329848.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
References: <pull.1076.v13.git.1638266115.gitgitgadget@gmail.com>
        <pull.1076.v14.git.1638329848.gitgitgadget@gmail.com>
Date: Wed, 01 Dec 2021 03:37:28 +0000
Subject: [PATCH v14 3/3] am: support --allow-empty to record specific empty
 patches
MIME-Version: 1.0
Fcc: Sent
To: git@vger.kernel.org
Cc: =?utf-8?b?UmVuw6k=?= Scharfe <l.s.r@web.de>,
 Phillip Wood <phillip.wood123@gmail.com>,
 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
 Elijah Newren <newren@gmail.com>,
 Aleen =?utf-8?b?5b6Q5rKb5paH?= <pwxu@coremail.cn>,
 Aleen <aleen42@vip.qq.com>,
 =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?=  <aleen42@vip.qq.com>
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
From: =?utf-8?b?5b6Q5rKb5paHIChBbGVlbik=?= <aleen42@vip.qq.com>

From: =?UTF-8?q?=E5=BE=90=E6=B2=9B=E6=96=87=20=28Aleen=29?=
 <aleen42@vip.qq.com>

This option helps to record specific empty patches in the middle
of an am session.

Signed-off-by: 徐沛文 (Aleen) <aleen42@vip.qq.com>
---
 Documentation/git-am.txt |  7 ++++++-
 builtin/am.c             | 29 ++++++++++++++++++++---------
 t/t4150-am.sh            | 24 ++++++++++++++++++++++++
 t/t7512-status-help.sh   |  1 +
 wt-status.c              |  3 +++
 5 files changed, 54 insertions(+), 10 deletions(-)

diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
index cf9cace9678..b6c065b3f7a 100644
--- a/Documentation/git-am.txt
+++ b/Documentation/git-am.txt
@@ -18,7 +18,7 @@ SYNOPSIS
 	 [--quoted-cr=<action>]
 	 [--empty=(die|drop|keep)]
 	 [(<mbox> | <Maildir>)...]
-'git am' (--continue | --skip | --abort | --quit | --show-current-patch[=(diff|raw)])
+'git am' (--continue | --skip | --abort | --quit | --show-current-patch[=(diff|raw)] | --allow-empty)
 
 DESCRIPTION
 -----------
@@ -200,6 +200,11 @@ default.   You can use `--no-utf8` to override this.
 	the e-mail message; if `diff`, show the diff portion only.
 	Defaults to `raw`.
 
+--allow-empty::
+	After a patch failure on an input e-mail message lacking a patch,
+	the user can still record the empty patch as an empty commit with
+	the contents of the e-mail message as its log.
+
 DISCUSSION
 ----------
 
diff --git a/builtin/am.c b/builtin/am.c
index cc6512275aa..58c7638b9bc 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -1825,7 +1825,8 @@ static void am_run(struct am_state *state, int resume)
 				to_keep = 1;
 				break;
 			case DIE_EMPTY_COMMIT:
-				printf_ln(_("Patch is empty."));
+				printf_ln(_("Patch is empty.\n"
+					    "If you want to record it as an empty commit, run \"git am --allow-empty\"."));
 				die_user_resolve(state);
 				break;
 			}
@@ -1898,19 +1899,24 @@ next:
 /**
  * Resume the current am session after patch application failure. The user did
  * all the hard work, and we do not have to do any patch application. Just
- * trust and commit what the user has in the index and working tree.
+ * trust and commit what the user has in the index and working tree. If `allow_empty`
+ * is true, commit as an empty commit when there is no changes.
  */
-static void am_resolve(struct am_state *state)
+static void am_resolve(struct am_state *state, int allow_empty)
 {
 	validate_resume_state(state);
 
 	say(state, stdout, _("Applying: %.*s"), linelen(state->msg), state->msg);
 
 	if (!repo_index_has_changes(the_repository, NULL, NULL)) {
-		printf_ln(_("No changes - did you forget to use 'git add'?\n"
-			"If there is nothing left to stage, chances are that something else\n"
-			"already introduced the same changes; you might want to skip this patch."));
-		die_user_resolve(state);
+		if (allow_empty)
+			printf_ln(_("No changes - record it as an empty commit."));
+		else {
+			printf_ln(_("No changes - did you forget to use 'git add'?\n"
+				    "If there is nothing left to stage, chances are that something else\n"
+				    "already introduced the same changes; you might want to skip this patch."));
+			die_user_resolve(state);
+		}
 	}
 
 	if (unmerged_cache()) {
@@ -2237,7 +2243,8 @@ enum resume_type {
 	RESUME_SKIP,
 	RESUME_ABORT,
 	RESUME_QUIT,
-	RESUME_SHOW_PATCH
+	RESUME_SHOW_PATCH,
+	RESUME_ALLOW_EMPTY
 };
 
 struct resume_mode {
@@ -2390,6 +2397,9 @@ int cmd_am(int argc, const char **argv, const char *prefix)
 		  N_("show the patch being applied"),
 		  PARSE_OPT_CMDMODE | PARSE_OPT_OPTARG | PARSE_OPT_NONEG | PARSE_OPT_LITERAL_ARGHELP,
 		  parse_opt_show_current_patch, RESUME_SHOW_PATCH },
+		OPT_CMDMODE(0, "allow-empty", &resume.mode,
+			N_("record the empty patch as an empty commit"),
+			RESUME_ALLOW_EMPTY),
 		OPT_BOOL(0, "committer-date-is-author-date",
 			&state.committer_date_is_author_date,
 			N_("lie about committer date")),
@@ -2498,7 +2508,8 @@ int cmd_am(int argc, const char **argv, const char *prefix)
 		am_run(&state, 1);
 		break;
 	case RESUME_RESOLVED:
-		am_resolve(&state);
+	case RESUME_ALLOW_EMPTY:
+		am_resolve(&state, resume.mode == RESUME_ALLOW_EMPTY ? 1 : 0);
 		break;
 	case RESUME_SKIP:
 		am_skip(&state);
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 8c8bd4db220..3e60460022f 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -1201,4 +1201,28 @@ test_expect_success 'record as an empty commit when meeting e-mail message that
 	test_cmp actual expected
 '
 
+test_expect_success 'skip an empty patch in the middle of an am session' '
+	git checkout empty-commit^ &&
+	test_must_fail git am empty-commit.patch >err &&
+	grep "Patch is empty." err &&
+	grep "If you want to record it as an empty commit, run \"git am --allow-empty\"." err &&
+	git am --skip &&
+	test_path_is_missing .git/rebase-apply &&
+	git rev-parse empty-commit^ >expected &&
+	git rev-parse HEAD >actual &&
+	test_cmp expected actual
+'
+
+test_expect_success 'record an empty patch as an empty commit in the middle of an am session' '
+	git checkout empty-commit^ &&
+	test_must_fail git am empty-commit.patch >err &&
+	grep "Patch is empty." err &&
+	grep "If you want to record it as an empty commit, run \"git am --allow-empty\"." err &&
+	git am --allow-empty &&
+	test_path_is_missing .git/rebase-apply &&
+	git show empty-commit --format="%s" >expected &&
+	git show HEAD --format="%s" >actual &&
+	test_cmp actual expected
+'
+
 test_done
diff --git a/t/t7512-status-help.sh b/t/t7512-status-help.sh
index 7f2956d77ad..9309becfe03 100755
--- a/t/t7512-status-help.sh
+++ b/t/t7512-status-help.sh
@@ -658,6 +658,7 @@ test_expect_success 'status in an am session: empty patch' '
 On branch am_empty
 You are in the middle of an am session.
 The current patch is empty.
+  (use "git am --allow-empty" to record this patch as an empty commit)
   (use "git am --skip" to skip this patch)
   (use "git am --abort" to restore the original branch)
 
diff --git a/wt-status.c b/wt-status.c
index 5d215f4e4f1..d578a0e9192 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1227,6 +1227,9 @@ static void show_am_in_progress(struct wt_status *s,
 		if (!s->state.am_empty_patch)
 			status_printf_ln(s, color,
 				_("  (fix conflicts and then run \"git am --continue\")"));
+		else
+			status_printf_ln(s, color,
+				_("  (use \"git am --allow-empty\" to record this patch as an empty commit)"));
 		status_printf_ln(s, color,
 			_("  (use \"git am --skip\" to skip this patch)"));
 		status_printf_ln(s, color,