From patchwork Thu Dec 2 15:23:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652789 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C264C433F5 for ; Thu, 2 Dec 2021 15:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358948AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46460 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358901AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9C2752177B; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yQPKCbzaAg6zMuSNpgHZa4Q0dK8gulF3LOq3pSB3gCg=; b=p78qZUx8I6xiZk6DK6BwlkQ/SHIfC/pxcO5fh/0a7+cVN6AtPIeNpYO8U33HSCl5upQfnn n8e1B/5S8aW03pnLp99FQJEbqcm94MJWkxREFvJfJTIcQuPGEox9RmD6i8bU3k5nmjESlD M7v1NK0mOALPnwvev/d6WudHlcTRcqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yQPKCbzaAg6zMuSNpgHZa4Q0dK8gulF3LOq3pSB3gCg=; b=lcwfbIF8qEQAr6rp3n6fh/+lEIRVRtIDMYcArz3XRVFguJTyl+UOhH/XVo2ki/uFaPbAYk giY+8jNDTBTh6WBA== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id DCEFBA3B89; Thu, 2 Dec 2021 15:24:07 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 1F1265191DEA; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 01/12] crypto: add crypto_has_shash() Date: Thu, 2 Dec 2021 16:23:47 +0100 Message-Id: <20211202152358.60116-2-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add helper function to determine if a given synchronous hash is supported. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- crypto/shash.c | 6 ++++++ include/crypto/hash.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/crypto/shash.c b/crypto/shash.c index 0a0a50cb694f..4c88e63b3350 100644 --- a/crypto/shash.c +++ b/crypto/shash.c @@ -521,6 +521,12 @@ struct crypto_shash *crypto_alloc_shash(const char *alg_name, u32 type, } EXPORT_SYMBOL_GPL(crypto_alloc_shash); +int crypto_has_shash(const char *alg_name, u32 type, u32 mask) +{ + return crypto_type_has_alg(alg_name, &crypto_shash_type, type, mask); +} +EXPORT_SYMBOL_GPL(crypto_has_shash); + static int shash_prepare_alg(struct shash_alg *alg) { struct crypto_alg *base = &alg->base; diff --git a/include/crypto/hash.h b/include/crypto/hash.h index f140e4643949..f5841992dc9b 100644 --- a/include/crypto/hash.h +++ b/include/crypto/hash.h @@ -718,6 +718,8 @@ static inline void ahash_request_set_crypt(struct ahash_request *req, struct crypto_shash *crypto_alloc_shash(const char *alg_name, u32 type, u32 mask); +int crypto_has_shash(const char *alg_name, u32 type, u32 mask); + static inline struct crypto_tfm *crypto_shash_tfm(struct crypto_shash *tfm) { return &tfm->base; From patchwork Thu Dec 2 15:23:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652797 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C790AC433F5 for ; Thu, 2 Dec 2021 15:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358950AbhLBP1d (ORCPT ); Thu, 2 Dec 2021 10:27:33 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46462 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358937AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9A5B121763; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pd4ocUXI/VlB3vuv7rR7yhLZCHpe++aR5VAm0EWuRH8=; b=dNPImTPW15YKXQFewTIEIQfhlpX4aiYJvzzFNX/l0l4DnCpuh1lY2LrYJW7aeCJcz5ONr5 tNLzxa7TgmduZWr5xBfjgt8EcEvQ79HrNUtMdGXVOEIw+4eJMuyDELlzDNctXzvJdQtPUw pDTjTOI5sCGp3WmOfFEydS5IIw+Iao4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pd4ocUXI/VlB3vuv7rR7yhLZCHpe++aR5VAm0EWuRH8=; b=MDLgn7BlxhmRS4WtOLOGvPWR73Z4jmPNIKcMnuS20d4t5Kp5xL5jK3UL0ZIFBVgg4h4TJm 2e7/jGLJyNtd/kDQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id DCE30A3B88; Thu, 2 Dec 2021 15:24:07 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 239975191DEC; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 02/12] crypto: add crypto_has_kpp() Date: Thu, 2 Dec 2021 16:23:48 +0100 Message-Id: <20211202152358.60116-3-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add helper function to determine if a given key-agreement protocol primitive is supported. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- crypto/kpp.c | 6 ++++++ include/crypto/kpp.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/crypto/kpp.c b/crypto/kpp.c index 313b2c699963..416e8a1a03ee 100644 --- a/crypto/kpp.c +++ b/crypto/kpp.c @@ -87,6 +87,12 @@ struct crypto_kpp *crypto_alloc_kpp(const char *alg_name, u32 type, u32 mask) } EXPORT_SYMBOL_GPL(crypto_alloc_kpp); +int crypto_has_kpp(const char *alg_name, u32 type, u32 mask) +{ + return crypto_type_has_alg(alg_name, &crypto_kpp_type, type, mask); +} +EXPORT_SYMBOL_GPL(crypto_has_kpp); + static void kpp_prepare_alg(struct kpp_alg *alg) { struct crypto_alg *base = &alg->base; diff --git a/include/crypto/kpp.h b/include/crypto/kpp.h index cccceadc164b..24d01e9877c1 100644 --- a/include/crypto/kpp.h +++ b/include/crypto/kpp.h @@ -104,6 +104,8 @@ struct kpp_alg { */ struct crypto_kpp *crypto_alloc_kpp(const char *alg_name, u32 type, u32 mask); +int crypto_has_kpp(const char *alg_name, u32 type, u32 mask); + static inline struct crypto_tfm *crypto_kpp_tfm(struct crypto_kpp *tfm) { return &tfm->base; From patchwork Thu Dec 2 15:23:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652793 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF16C433EF for ; Thu, 2 Dec 2021 15:24:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358946AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42078 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358930AbhLBP1b (ORCPT ); Thu, 2 Dec 2021 10:27:31 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 9A9321FD39; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AsRpFy9NSHyV43uudz7V2ftKTRwPPo0j/nwa8DYYqCI=; b=fLZ4oF6dKHVADgb8PrQNdQGO2mLk/I9qUz/la4hQ/5dN7f5oXHqF3UVWRzWJN94APhQ8Sa BFFHhKoCsDFiT0GVBkCw98APy1aROfzgVp/1PlMK3x2R+YESMBo8ENPLQBcRtiGwX+i5dB ajid4mr3PtV9A1CF3LrLEec5KNDRRkI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AsRpFy9NSHyV43uudz7V2ftKTRwPPo0j/nwa8DYYqCI=; b=ePBDZNGtVZUs0x6ajJwJfsrdilrjEfYz+xhnA00ck/BZpVJpuEOBfxtqpVGNOrOfIP6+uz 8EdUoyRwrXvWU1BQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id E4E02A3B8C; Thu, 2 Dec 2021 15:24:07 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 2BA435191DEE; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Himanshu Madhani , Chaitanya Kulkarni Subject: [PATCH 03/12] crypto/ffdhe: Finite Field DH Ephemeral Parameters Date: Thu, 2 Dec 2021 16:23:49 +0100 Message-Id: <20211202152358.60116-4-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add helper functions to generaten Finite Field DH Ephemeral Parameters as specified in RFC 7919. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Himanshu Madhani Reviewed-by: Chaitanya Kulkarni --- crypto/Kconfig | 8 + crypto/Makefile | 1 + crypto/ffdhe_helper.c | 880 +++++++++++++++++++++++++++++++++++++++++ include/crypto/ffdhe.h | 24 ++ 4 files changed, 913 insertions(+) create mode 100644 crypto/ffdhe_helper.c create mode 100644 include/crypto/ffdhe.h diff --git a/crypto/Kconfig b/crypto/Kconfig index 285f82647d2b..0181d2a2982c 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -231,6 +231,14 @@ config CRYPTO_DH help Generic implementation of the Diffie-Hellman algorithm. +config CRYPTO_FFDHE + tristate "Finite Field DH (RFC 7919) ephemeral parameters" + select CRYPTO_DH + select CRYPTO_KPP + select CRYPTO_RNG_DEFAULT + help + Generic implementation of the Finite Field DH algorithm + config CRYPTO_ECC tristate select CRYPTO_RNG_DEFAULT diff --git a/crypto/Makefile b/crypto/Makefile index 429c4d57458c..2c4049ec12fc 100644 --- a/crypto/Makefile +++ b/crypto/Makefile @@ -178,6 +178,7 @@ obj-$(CONFIG_CRYPTO_OFB) += ofb.o obj-$(CONFIG_CRYPTO_ECC) += ecc.o obj-$(CONFIG_CRYPTO_ESSIV) += essiv.o obj-$(CONFIG_CRYPTO_CURVE25519) += curve25519-generic.o +obj-$(CONFIG_CRYPTO_FFDHE) += ffdhe_helper.o ecdh_generic-y += ecdh.o ecdh_generic-y += ecdh_helper.o diff --git a/crypto/ffdhe_helper.c b/crypto/ffdhe_helper.c new file mode 100644 index 000000000000..5d8da1291252 --- /dev/null +++ b/crypto/ffdhe_helper.c @@ -0,0 +1,880 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Finite Field DH Ephemeral Parameters + * Values are taken from RFC 7919 Appendix A + * + * Copyright (c) 2021, Hannes Reinecke, SUSE Software Products + */ + +#include +#include +#include +#include +#include +#include +/* + * ffdhe2048 generator (g), modulus (p) and group size (q) + */ +static const u8 ffdhe2048_g[] = { 0x02 }; + +static const u8 ffdhe2048_p[] = { + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, + 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, + 0xd8,0xb9,0xc5,0x83,0xce,0x2d,0x36,0x95, + 0xa9,0xe1,0x36,0x41,0x14,0x64,0x33,0xfb, + 0xcc,0x93,0x9d,0xce,0x24,0x9b,0x3e,0xf9, + 0x7d,0x2f,0xe3,0x63,0x63,0x0c,0x75,0xd8, + 0xf6,0x81,0xb2,0x02,0xae,0xc4,0x61,0x7a, + 0xd3,0xdf,0x1e,0xd5,0xd5,0xfd,0x65,0x61, + 0x24,0x33,0xf5,0x1f,0x5f,0x06,0x6e,0xd0, + 0x85,0x63,0x65,0x55,0x3d,0xed,0x1a,0xf3, + 0xb5,0x57,0x13,0x5e,0x7f,0x57,0xc9,0x35, + 0x98,0x4f,0x0c,0x70,0xe0,0xe6,0x8b,0x77, + 0xe2,0xa6,0x89,0xda,0xf3,0xef,0xe8,0x72, + 0x1d,0xf1,0x58,0xa1,0x36,0xad,0xe7,0x35, + 0x30,0xac,0xca,0x4f,0x48,0x3a,0x79,0x7a, + 0xbc,0x0a,0xb1,0x82,0xb3,0x24,0xfb,0x61, + 0xd1,0x08,0xa9,0x4b,0xb2,0xc8,0xe3,0xfb, + 0xb9,0x6a,0xda,0xb7,0x60,0xd7,0xf4,0x68, + 0x1d,0x4f,0x42,0xa3,0xde,0x39,0x4d,0xf4, + 0xae,0x56,0xed,0xe7,0x63,0x72,0xbb,0x19, + 0x0b,0x07,0xa7,0xc8,0xee,0x0a,0x6d,0x70, + 0x9e,0x02,0xfc,0xe1,0xcd,0xf7,0xe2,0xec, + 0xc0,0x34,0x04,0xcd,0x28,0x34,0x2f,0x61, + 0x91,0x72,0xfe,0x9c,0xe9,0x85,0x83,0xff, + 0x8e,0x4f,0x12,0x32,0xee,0xf2,0x81,0x83, + 0xc3,0xfe,0x3b,0x1b,0x4c,0x6f,0xad,0x73, + 0x3b,0xb5,0xfc,0xbc,0x2e,0xc2,0x20,0x05, + 0xc5,0x8e,0xf1,0x83,0x7d,0x16,0x83,0xb2, + 0xc6,0xf3,0x4a,0x26,0xc1,0xb2,0xef,0xfa, + 0x88,0x6b,0x42,0x38,0x61,0x28,0x5c,0x97, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +static const u8 ffdhe2048_q[] = { + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, + 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, + 0xec,0x5c,0xe2,0xc1,0xe7,0x16,0x9b,0x4a, + 0xd4,0xf0,0x9b,0x20,0x8a,0x32,0x19,0xfd, + 0xe6,0x49,0xce,0xe7,0x12,0x4d,0x9f,0x7c, + 0xbe,0x97,0xf1,0xb1,0xb1,0x86,0x3a,0xec, + 0x7b,0x40,0xd9,0x01,0x57,0x62,0x30,0xbd, + 0x69,0xef,0x8f,0x6a,0xea,0xfe,0xb2,0xb0, + 0x92,0x19,0xfa,0x8f,0xaf,0x83,0x37,0x68, + 0x42,0xb1,0xb2,0xaa,0x9e,0xf6,0x8d,0x79, + 0xda,0xab,0x89,0xaf,0x3f,0xab,0xe4,0x9a, + 0xcc,0x27,0x86,0x38,0x70,0x73,0x45,0xbb, + 0xf1,0x53,0x44,0xed,0x79,0xf7,0xf4,0x39, + 0x0e,0xf8,0xac,0x50,0x9b,0x56,0xf3,0x9a, + 0x98,0x56,0x65,0x27,0xa4,0x1d,0x3c,0xbd, + 0x5e,0x05,0x58,0xc1,0x59,0x92,0x7d,0xb0, + 0xe8,0x84,0x54,0xa5,0xd9,0x64,0x71,0xfd, + 0xdc,0xb5,0x6d,0x5b,0xb0,0x6b,0xfa,0x34, + 0x0e,0xa7,0xa1,0x51,0xef,0x1c,0xa6,0xfa, + 0x57,0x2b,0x76,0xf3,0xb1,0xb9,0x5d,0x8c, + 0x85,0x83,0xd3,0xe4,0x77,0x05,0x36,0xb8, + 0x4f,0x01,0x7e,0x70,0xe6,0xfb,0xf1,0x76, + 0x60,0x1a,0x02,0x66,0x94,0x1a,0x17,0xb0, + 0xc8,0xb9,0x7f,0x4e,0x74,0xc2,0xc1,0xff, + 0xc7,0x27,0x89,0x19,0x77,0x79,0x40,0xc1, + 0xe1,0xff,0x1d,0x8d,0xa6,0x37,0xd6,0xb9, + 0x9d,0xda,0xfe,0x5e,0x17,0x61,0x10,0x02, + 0xe2,0xc7,0x78,0xc1,0xbe,0x8b,0x41,0xd9, + 0x63,0x79,0xa5,0x13,0x60,0xd9,0x77,0xfd, + 0x44,0x35,0xa1,0x1c,0x30,0x94,0x2e,0x4b, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +/* + * ffdhe3072 generator (g), modulus (p) and group size (q) + */ + +static const u8 ffdhe3072_g[] = { 0x02 }; + +static const u8 ffdhe3072_p[] = { + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, + 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, + 0xd8,0xb9,0xc5,0x83,0xce,0x2d,0x36,0x95, + 0xa9,0xe1,0x36,0x41,0x14,0x64,0x33,0xfb, + 0xcc,0x93,0x9d,0xce,0x24,0x9b,0x3e,0xf9, + 0x7d,0x2f,0xe3,0x63,0x63,0x0c,0x75,0xd8, + 0xf6,0x81,0xb2,0x02,0xae,0xc4,0x61,0x7a, + 0xd3,0xdf,0x1e,0xd5,0xd5,0xfd,0x65,0x61, + 0x24,0x33,0xf5,0x1f,0x5f,0x06,0x6e,0xd0, + 0x85,0x63,0x65,0x55,0x3d,0xed,0x1a,0xf3, + 0xb5,0x57,0x13,0x5e,0x7f,0x57,0xc9,0x35, + 0x98,0x4f,0x0c,0x70,0xe0,0xe6,0x8b,0x77, + 0xe2,0xa6,0x89,0xda,0xf3,0xef,0xe8,0x72, + 0x1d,0xf1,0x58,0xa1,0x36,0xad,0xe7,0x35, + 0x30,0xac,0xca,0x4f,0x48,0x3a,0x79,0x7a, + 0xbc,0x0a,0xb1,0x82,0xb3,0x24,0xfb,0x61, + 0xd1,0x08,0xa9,0x4b,0xb2,0xc8,0xe3,0xfb, + 0xb9,0x6a,0xda,0xb7,0x60,0xd7,0xf4,0x68, + 0x1d,0x4f,0x42,0xa3,0xde,0x39,0x4d,0xf4, + 0xae,0x56,0xed,0xe7,0x63,0x72,0xbb,0x19, + 0x0b,0x07,0xa7,0xc8,0xee,0x0a,0x6d,0x70, + 0x9e,0x02,0xfc,0xe1,0xcd,0xf7,0xe2,0xec, + 0xc0,0x34,0x04,0xcd,0x28,0x34,0x2f,0x61, + 0x91,0x72,0xfe,0x9c,0xe9,0x85,0x83,0xff, + 0x8e,0x4f,0x12,0x32,0xee,0xf2,0x81,0x83, + 0xc3,0xfe,0x3b,0x1b,0x4c,0x6f,0xad,0x73, + 0x3b,0xb5,0xfc,0xbc,0x2e,0xc2,0x20,0x05, + 0xc5,0x8e,0xf1,0x83,0x7d,0x16,0x83,0xb2, + 0xc6,0xf3,0x4a,0x26,0xc1,0xb2,0xef,0xfa, + 0x88,0x6b,0x42,0x38,0x61,0x1f,0xcf,0xdc, + 0xde,0x35,0x5b,0x3b,0x65,0x19,0x03,0x5b, + 0xbc,0x34,0xf4,0xde,0xf9,0x9c,0x02,0x38, + 0x61,0xb4,0x6f,0xc9,0xd6,0xe6,0xc9,0x07, + 0x7a,0xd9,0x1d,0x26,0x91,0xf7,0xf7,0xee, + 0x59,0x8c,0xb0,0xfa,0xc1,0x86,0xd9,0x1c, + 0xae,0xfe,0x13,0x09,0x85,0x13,0x92,0x70, + 0xb4,0x13,0x0c,0x93,0xbc,0x43,0x79,0x44, + 0xf4,0xfd,0x44,0x52,0xe2,0xd7,0x4d,0xd3, + 0x64,0xf2,0xe2,0x1e,0x71,0xf5,0x4b,0xff, + 0x5c,0xae,0x82,0xab,0x9c,0x9d,0xf6,0x9e, + 0xe8,0x6d,0x2b,0xc5,0x22,0x36,0x3a,0x0d, + 0xab,0xc5,0x21,0x97,0x9b,0x0d,0xea,0xda, + 0x1d,0xbf,0x9a,0x42,0xd5,0xc4,0x48,0x4e, + 0x0a,0xbc,0xd0,0x6b,0xfa,0x53,0xdd,0xef, + 0x3c,0x1b,0x20,0xee,0x3f,0xd5,0x9d,0x7c, + 0x25,0xe4,0x1d,0x2b,0x66,0xc6,0x2e,0x37, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +static const u8 ffdhe3072_q[] = { + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, + 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, + 0xec,0x5c,0xe2,0xc1,0xe7,0x16,0x9b,0x4a, + 0xd4,0xf0,0x9b,0x20,0x8a,0x32,0x19,0xfd, + 0xe6,0x49,0xce,0xe7,0x12,0x4d,0x9f,0x7c, + 0xbe,0x97,0xf1,0xb1,0xb1,0x86,0x3a,0xec, + 0x7b,0x40,0xd9,0x01,0x57,0x62,0x30,0xbd, + 0x69,0xef,0x8f,0x6a,0xea,0xfe,0xb2,0xb0, + 0x92,0x19,0xfa,0x8f,0xaf,0x83,0x37,0x68, + 0x42,0xb1,0xb2,0xaa,0x9e,0xf6,0x8d,0x79, + 0xda,0xab,0x89,0xaf,0x3f,0xab,0xe4,0x9a, + 0xcc,0x27,0x86,0x38,0x70,0x73,0x45,0xbb, + 0xf1,0x53,0x44,0xed,0x79,0xf7,0xf4,0x39, + 0x0e,0xf8,0xac,0x50,0x9b,0x56,0xf3,0x9a, + 0x98,0x56,0x65,0x27,0xa4,0x1d,0x3c,0xbd, + 0x5e,0x05,0x58,0xc1,0x59,0x92,0x7d,0xb0, + 0xe8,0x84,0x54,0xa5,0xd9,0x64,0x71,0xfd, + 0xdc,0xb5,0x6d,0x5b,0xb0,0x6b,0xfa,0x34, + 0x0e,0xa7,0xa1,0x51,0xef,0x1c,0xa6,0xfa, + 0x57,0x2b,0x76,0xf3,0xb1,0xb9,0x5d,0x8c, + 0x85,0x83,0xd3,0xe4,0x77,0x05,0x36,0xb8, + 0x4f,0x01,0x7e,0x70,0xe6,0xfb,0xf1,0x76, + 0x60,0x1a,0x02,0x66,0x94,0x1a,0x17,0xb0, + 0xc8,0xb9,0x7f,0x4e,0x74,0xc2,0xc1,0xff, + 0xc7,0x27,0x89,0x19,0x77,0x79,0x40,0xc1, + 0xe1,0xff,0x1d,0x8d,0xa6,0x37,0xd6,0xb9, + 0x9d,0xda,0xfe,0x5e,0x17,0x61,0x10,0x02, + 0xe2,0xc7,0x78,0xc1,0xbe,0x8b,0x41,0xd9, + 0x63,0x79,0xa5,0x13,0x60,0xd9,0x77,0xfd, + 0x44,0x35,0xa1,0x1c,0x30,0x8f,0xe7,0xee, + 0x6f,0x1a,0xad,0x9d,0xb2,0x8c,0x81,0xad, + 0xde,0x1a,0x7a,0x6f,0x7c,0xce,0x01,0x1c, + 0x30,0xda,0x37,0xe4,0xeb,0x73,0x64,0x83, + 0xbd,0x6c,0x8e,0x93,0x48,0xfb,0xfb,0xf7, + 0x2c,0xc6,0x58,0x7d,0x60,0xc3,0x6c,0x8e, + 0x57,0x7f,0x09,0x84,0xc2,0x89,0xc9,0x38, + 0x5a,0x09,0x86,0x49,0xde,0x21,0xbc,0xa2, + 0x7a,0x7e,0xa2,0x29,0x71,0x6b,0xa6,0xe9, + 0xb2,0x79,0x71,0x0f,0x38,0xfa,0xa5,0xff, + 0xae,0x57,0x41,0x55,0xce,0x4e,0xfb,0x4f, + 0x74,0x36,0x95,0xe2,0x91,0x1b,0x1d,0x06, + 0xd5,0xe2,0x90,0xcb,0xcd,0x86,0xf5,0x6d, + 0x0e,0xdf,0xcd,0x21,0x6a,0xe2,0x24,0x27, + 0x05,0x5e,0x68,0x35,0xfd,0x29,0xee,0xf7, + 0x9e,0x0d,0x90,0x77,0x1f,0xea,0xce,0xbe, + 0x12,0xf2,0x0e,0x95,0xb3,0x63,0x17,0x1b, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +/* + * ffdhe4096 generator (g), modulus (p) and group size (q) + */ + +static const u8 ffdhe4096_g[] = { 0x02 }; + +static const u8 ffdhe4096_p[] = { + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, + 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, + 0xd8,0xb9,0xc5,0x83,0xce,0x2d,0x36,0x95, + 0xa9,0xe1,0x36,0x41,0x14,0x64,0x33,0xfb, + 0xcc,0x93,0x9d,0xce,0x24,0x9b,0x3e,0xf9, + 0x7d,0x2f,0xe3,0x63,0x63,0x0c,0x75,0xd8, + 0xf6,0x81,0xb2,0x02,0xae,0xc4,0x61,0x7a, + 0xd3,0xdf,0x1e,0xd5,0xd5,0xfd,0x65,0x61, + 0x24,0x33,0xf5,0x1f,0x5f,0x06,0x6e,0xd0, + 0x85,0x63,0x65,0x55,0x3d,0xed,0x1a,0xf3, + 0xb5,0x57,0x13,0x5e,0x7f,0x57,0xc9,0x35, + 0x98,0x4f,0x0c,0x70,0xe0,0xe6,0x8b,0x77, + 0xe2,0xa6,0x89,0xda,0xf3,0xef,0xe8,0x72, + 0x1d,0xf1,0x58,0xa1,0x36,0xad,0xe7,0x35, + 0x30,0xac,0xca,0x4f,0x48,0x3a,0x79,0x7a, + 0xbc,0x0a,0xb1,0x82,0xb3,0x24,0xfb,0x61, + 0xd1,0x08,0xa9,0x4b,0xb2,0xc8,0xe3,0xfb, + 0xb9,0x6a,0xda,0xb7,0x60,0xd7,0xf4,0x68, + 0x1d,0x4f,0x42,0xa3,0xde,0x39,0x4d,0xf4, + 0xae,0x56,0xed,0xe7,0x63,0x72,0xbb,0x19, + 0x0b,0x07,0xa7,0xc8,0xee,0x0a,0x6d,0x70, + 0x9e,0x02,0xfc,0xe1,0xcd,0xf7,0xe2,0xec, + 0xc0,0x34,0x04,0xcd,0x28,0x34,0x2f,0x61, + 0x91,0x72,0xfe,0x9c,0xe9,0x85,0x83,0xff, + 0x8e,0x4f,0x12,0x32,0xee,0xf2,0x81,0x83, + 0xc3,0xfe,0x3b,0x1b,0x4c,0x6f,0xad,0x73, + 0x3b,0xb5,0xfc,0xbc,0x2e,0xc2,0x20,0x05, + 0xc5,0x8e,0xf1,0x83,0x7d,0x16,0x83,0xb2, + 0xc6,0xf3,0x4a,0x26,0xc1,0xb2,0xef,0xfa, + 0x88,0x6b,0x42,0x38,0x61,0x1f,0xcf,0xdc, + 0xde,0x35,0x5b,0x3b,0x65,0x19,0x03,0x5b, + 0xbc,0x34,0xf4,0xde,0xf9,0x9c,0x02,0x38, + 0x61,0xb4,0x6f,0xc9,0xd6,0xe6,0xc9,0x07, + 0x7a,0xd9,0x1d,0x26,0x91,0xf7,0xf7,0xee, + 0x59,0x8c,0xb0,0xfa,0xc1,0x86,0xd9,0x1c, + 0xae,0xfe,0x13,0x09,0x85,0x13,0x92,0x70, + 0xb4,0x13,0x0c,0x93,0xbc,0x43,0x79,0x44, + 0xf4,0xfd,0x44,0x52,0xe2,0xd7,0x4d,0xd3, + 0x64,0xf2,0xe2,0x1e,0x71,0xf5,0x4b,0xff, + 0x5c,0xae,0x82,0xab,0x9c,0x9d,0xf6,0x9e, + 0xe8,0x6d,0x2b,0xc5,0x22,0x36,0x3a,0x0d, + 0xab,0xc5,0x21,0x97,0x9b,0x0d,0xea,0xda, + 0x1d,0xbf,0x9a,0x42,0xd5,0xc4,0x48,0x4e, + 0x0a,0xbc,0xd0,0x6b,0xfa,0x53,0xdd,0xef, + 0x3c,0x1b,0x20,0xee,0x3f,0xd5,0x9d,0x7c, + 0x25,0xe4,0x1d,0x2b,0x66,0x9e,0x1e,0xf1, + 0x6e,0x6f,0x52,0xc3,0x16,0x4d,0xf4,0xfb, + 0x79,0x30,0xe9,0xe4,0xe5,0x88,0x57,0xb6, + 0xac,0x7d,0x5f,0x42,0xd6,0x9f,0x6d,0x18, + 0x77,0x63,0xcf,0x1d,0x55,0x03,0x40,0x04, + 0x87,0xf5,0x5b,0xa5,0x7e,0x31,0xcc,0x7a, + 0x71,0x35,0xc8,0x86,0xef,0xb4,0x31,0x8a, + 0xed,0x6a,0x1e,0x01,0x2d,0x9e,0x68,0x32, + 0xa9,0x07,0x60,0x0a,0x91,0x81,0x30,0xc4, + 0x6d,0xc7,0x78,0xf9,0x71,0xad,0x00,0x38, + 0x09,0x29,0x99,0xa3,0x33,0xcb,0x8b,0x7a, + 0x1a,0x1d,0xb9,0x3d,0x71,0x40,0x00,0x3c, + 0x2a,0x4e,0xce,0xa9,0xf9,0x8d,0x0a,0xcc, + 0x0a,0x82,0x91,0xcd,0xce,0xc9,0x7d,0xcf, + 0x8e,0xc9,0xb5,0x5a,0x7f,0x88,0xa4,0x6b, + 0x4d,0xb5,0xa8,0x51,0xf4,0x41,0x82,0xe1, + 0xc6,0x8a,0x00,0x7e,0x5e,0x65,0x5f,0x6a, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +static const u8 ffdhe4096_q[] = { + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, + 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, + 0xec,0x5c,0xe2,0xc1,0xe7,0x16,0x9b,0x4a, + 0xd4,0xf0,0x9b,0x20,0x8a,0x32,0x19,0xfd, + 0xe6,0x49,0xce,0xe7,0x12,0x4d,0x9f,0x7c, + 0xbe,0x97,0xf1,0xb1,0xb1,0x86,0x3a,0xec, + 0x7b,0x40,0xd9,0x01,0x57,0x62,0x30,0xbd, + 0x69,0xef,0x8f,0x6a,0xea,0xfe,0xb2,0xb0, + 0x92,0x19,0xfa,0x8f,0xaf,0x83,0x37,0x68, + 0x42,0xb1,0xb2,0xaa,0x9e,0xf6,0x8d,0x79, + 0xda,0xab,0x89,0xaf,0x3f,0xab,0xe4,0x9a, + 0xcc,0x27,0x86,0x38,0x70,0x73,0x45,0xbb, + 0xf1,0x53,0x44,0xed,0x79,0xf7,0xf4,0x39, + 0x0e,0xf8,0xac,0x50,0x9b,0x56,0xf3,0x9a, + 0x98,0x56,0x65,0x27,0xa4,0x1d,0x3c,0xbd, + 0x5e,0x05,0x58,0xc1,0x59,0x92,0x7d,0xb0, + 0xe8,0x84,0x54,0xa5,0xd9,0x64,0x71,0xfd, + 0xdc,0xb5,0x6d,0x5b,0xb0,0x6b,0xfa,0x34, + 0x0e,0xa7,0xa1,0x51,0xef,0x1c,0xa6,0xfa, + 0x57,0x2b,0x76,0xf3,0xb1,0xb9,0x5d,0x8c, + 0x85,0x83,0xd3,0xe4,0x77,0x05,0x36,0xb8, + 0x4f,0x01,0x7e,0x70,0xe6,0xfb,0xf1,0x76, + 0x60,0x1a,0x02,0x66,0x94,0x1a,0x17,0xb0, + 0xc8,0xb9,0x7f,0x4e,0x74,0xc2,0xc1,0xff, + 0xc7,0x27,0x89,0x19,0x77,0x79,0x40,0xc1, + 0xe1,0xff,0x1d,0x8d,0xa6,0x37,0xd6,0xb9, + 0x9d,0xda,0xfe,0x5e,0x17,0x61,0x10,0x02, + 0xe2,0xc7,0x78,0xc1,0xbe,0x8b,0x41,0xd9, + 0x63,0x79,0xa5,0x13,0x60,0xd9,0x77,0xfd, + 0x44,0x35,0xa1,0x1c,0x30,0x8f,0xe7,0xee, + 0x6f,0x1a,0xad,0x9d,0xb2,0x8c,0x81,0xad, + 0xde,0x1a,0x7a,0x6f,0x7c,0xce,0x01,0x1c, + 0x30,0xda,0x37,0xe4,0xeb,0x73,0x64,0x83, + 0xbd,0x6c,0x8e,0x93,0x48,0xfb,0xfb,0xf7, + 0x2c,0xc6,0x58,0x7d,0x60,0xc3,0x6c,0x8e, + 0x57,0x7f,0x09,0x84,0xc2,0x89,0xc9,0x38, + 0x5a,0x09,0x86,0x49,0xde,0x21,0xbc,0xa2, + 0x7a,0x7e,0xa2,0x29,0x71,0x6b,0xa6,0xe9, + 0xb2,0x79,0x71,0x0f,0x38,0xfa,0xa5,0xff, + 0xae,0x57,0x41,0x55,0xce,0x4e,0xfb,0x4f, + 0x74,0x36,0x95,0xe2,0x91,0x1b,0x1d,0x06, + 0xd5,0xe2,0x90,0xcb,0xcd,0x86,0xf5,0x6d, + 0x0e,0xdf,0xcd,0x21,0x6a,0xe2,0x24,0x27, + 0x05,0x5e,0x68,0x35,0xfd,0x29,0xee,0xf7, + 0x9e,0x0d,0x90,0x77,0x1f,0xea,0xce,0xbe, + 0x12,0xf2,0x0e,0x95,0xb3,0x4f,0x0f,0x78, + 0xb7,0x37,0xa9,0x61,0x8b,0x26,0xfa,0x7d, + 0xbc,0x98,0x74,0xf2,0x72,0xc4,0x2b,0xdb, + 0x56,0x3e,0xaf,0xa1,0x6b,0x4f,0xb6,0x8c, + 0x3b,0xb1,0xe7,0x8e,0xaa,0x81,0xa0,0x02, + 0x43,0xfa,0xad,0xd2,0xbf,0x18,0xe6,0x3d, + 0x38,0x9a,0xe4,0x43,0x77,0xda,0x18,0xc5, + 0x76,0xb5,0x0f,0x00,0x96,0xcf,0x34,0x19, + 0x54,0x83,0xb0,0x05,0x48,0xc0,0x98,0x62, + 0x36,0xe3,0xbc,0x7c,0xb8,0xd6,0x80,0x1c, + 0x04,0x94,0xcc,0xd1,0x99,0xe5,0xc5,0xbd, + 0x0d,0x0e,0xdc,0x9e,0xb8,0xa0,0x00,0x1e, + 0x15,0x27,0x67,0x54,0xfc,0xc6,0x85,0x66, + 0x05,0x41,0x48,0xe6,0xe7,0x64,0xbe,0xe7, + 0xc7,0x64,0xda,0xad,0x3f,0xc4,0x52,0x35, + 0xa6,0xda,0xd4,0x28,0xfa,0x20,0xc1,0x70, + 0xe3,0x45,0x00,0x3f,0x2f,0x32,0xaf,0xb5, + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +/* + * ffdhe6144 generator (g), modulus (p) and group size (q) + */ + +static const u8 ffdhe6144_g[] = { 0x02 }; + +static const u8 ffdhe6144_p[] = { + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, + 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, + 0xd8,0xb9,0xc5,0x83,0xce,0x2d,0x36,0x95, + 0xa9,0xe1,0x36,0x41,0x14,0x64,0x33,0xfb, + 0xcc,0x93,0x9d,0xce,0x24,0x9b,0x3e,0xf9, + 0x7d,0x2f,0xe3,0x63,0x63,0x0c,0x75,0xd8, + 0xf6,0x81,0xb2,0x02,0xae,0xc4,0x61,0x7a, + 0xd3,0xdf,0x1e,0xd5,0xd5,0xfd,0x65,0x61, + 0x24,0x33,0xf5,0x1f,0x5f,0x06,0x6e,0xd0, + 0x85,0x63,0x65,0x55,0x3d,0xed,0x1a,0xf3, + 0xb5,0x57,0x13,0x5e,0x7f,0x57,0xc9,0x35, + 0x98,0x4f,0x0c,0x70,0xe0,0xe6,0x8b,0x77, + 0xe2,0xa6,0x89,0xda,0xf3,0xef,0xe8,0x72, + 0x1d,0xf1,0x58,0xa1,0x36,0xad,0xe7,0x35, + 0x30,0xac,0xca,0x4f,0x48,0x3a,0x79,0x7a, + 0xbc,0x0a,0xb1,0x82,0xb3,0x24,0xfb,0x61, + 0xd1,0x08,0xa9,0x4b,0xb2,0xc8,0xe3,0xfb, + 0xb9,0x6a,0xda,0xb7,0x60,0xd7,0xf4,0x68, + 0x1d,0x4f,0x42,0xa3,0xde,0x39,0x4d,0xf4, + 0xae,0x56,0xed,0xe7,0x63,0x72,0xbb,0x19, + 0x0b,0x07,0xa7,0xc8,0xee,0x0a,0x6d,0x70, + 0x9e,0x02,0xfc,0xe1,0xcd,0xf7,0xe2,0xec, + 0xc0,0x34,0x04,0xcd,0x28,0x34,0x2f,0x61, + 0x91,0x72,0xfe,0x9c,0xe9,0x85,0x83,0xff, + 0x8e,0x4f,0x12,0x32,0xee,0xf2,0x81,0x83, + 0xc3,0xfe,0x3b,0x1b,0x4c,0x6f,0xad,0x73, + 0x3b,0xb5,0xfc,0xbc,0x2e,0xc2,0x20,0x05, + 0xc5,0x8e,0xf1,0x83,0x7d,0x16,0x83,0xb2, + 0xc6,0xf3,0x4a,0x26,0xc1,0xb2,0xef,0xfa, + 0x88,0x6b,0x42,0x38,0x61,0x1f,0xcf,0xdc, + 0xde,0x35,0x5b,0x3b,0x65,0x19,0x03,0x5b, + 0xbc,0x34,0xf4,0xde,0xf9,0x9c,0x02,0x38, + 0x61,0xb4,0x6f,0xc9,0xd6,0xe6,0xc9,0x07, + 0x7a,0xd9,0x1d,0x26,0x91,0xf7,0xf7,0xee, + 0x59,0x8c,0xb0,0xfa,0xc1,0x86,0xd9,0x1c, + 0xae,0xfe,0x13,0x09,0x85,0x13,0x92,0x70, + 0xb4,0x13,0x0c,0x93,0xbc,0x43,0x79,0x44, + 0xf4,0xfd,0x44,0x52,0xe2,0xd7,0x4d,0xd3, + 0x64,0xf2,0xe2,0x1e,0x71,0xf5,0x4b,0xff, + 0x5c,0xae,0x82,0xab,0x9c,0x9d,0xf6,0x9e, + 0xe8,0x6d,0x2b,0xc5,0x22,0x36,0x3a,0x0d, + 0xab,0xc5,0x21,0x97,0x9b,0x0d,0xea,0xda, + 0x1d,0xbf,0x9a,0x42,0xd5,0xc4,0x48,0x4e, + 0x0a,0xbc,0xd0,0x6b,0xfa,0x53,0xdd,0xef, + 0x3c,0x1b,0x20,0xee,0x3f,0xd5,0x9d,0x7c, + 0x25,0xe4,0x1d,0x2b,0x66,0x9e,0x1e,0xf1, + 0x6e,0x6f,0x52,0xc3,0x16,0x4d,0xf4,0xfb, + 0x79,0x30,0xe9,0xe4,0xe5,0x88,0x57,0xb6, + 0xac,0x7d,0x5f,0x42,0xd6,0x9f,0x6d,0x18, + 0x77,0x63,0xcf,0x1d,0x55,0x03,0x40,0x04, + 0x87,0xf5,0x5b,0xa5,0x7e,0x31,0xcc,0x7a, + 0x71,0x35,0xc8,0x86,0xef,0xb4,0x31,0x8a, + 0xed,0x6a,0x1e,0x01,0x2d,0x9e,0x68,0x32, + 0xa9,0x07,0x60,0x0a,0x91,0x81,0x30,0xc4, + 0x6d,0xc7,0x78,0xf9,0x71,0xad,0x00,0x38, + 0x09,0x29,0x99,0xa3,0x33,0xcb,0x8b,0x7a, + 0x1a,0x1d,0xb9,0x3d,0x71,0x40,0x00,0x3c, + 0x2a,0x4e,0xce,0xa9,0xf9,0x8d,0x0a,0xcc, + 0x0a,0x82,0x91,0xcd,0xce,0xc9,0x7d,0xcf, + 0x8e,0xc9,0xb5,0x5a,0x7f,0x88,0xa4,0x6b, + 0x4d,0xb5,0xa8,0x51,0xf4,0x41,0x82,0xe1, + 0xc6,0x8a,0x00,0x7e,0x5e,0x0d,0xd9,0x02, + 0x0b,0xfd,0x64,0xb6,0x45,0x03,0x6c,0x7a, + 0x4e,0x67,0x7d,0x2c,0x38,0x53,0x2a,0x3a, + 0x23,0xba,0x44,0x42,0xca,0xf5,0x3e,0xa6, + 0x3b,0xb4,0x54,0x32,0x9b,0x76,0x24,0xc8, + 0x91,0x7b,0xdd,0x64,0xb1,0xc0,0xfd,0x4c, + 0xb3,0x8e,0x8c,0x33,0x4c,0x70,0x1c,0x3a, + 0xcd,0xad,0x06,0x57,0xfc,0xcf,0xec,0x71, + 0x9b,0x1f,0x5c,0x3e,0x4e,0x46,0x04,0x1f, + 0x38,0x81,0x47,0xfb,0x4c,0xfd,0xb4,0x77, + 0xa5,0x24,0x71,0xf7,0xa9,0xa9,0x69,0x10, + 0xb8,0x55,0x32,0x2e,0xdb,0x63,0x40,0xd8, + 0xa0,0x0e,0xf0,0x92,0x35,0x05,0x11,0xe3, + 0x0a,0xbe,0xc1,0xff,0xf9,0xe3,0xa2,0x6e, + 0x7f,0xb2,0x9f,0x8c,0x18,0x30,0x23,0xc3, + 0x58,0x7e,0x38,0xda,0x00,0x77,0xd9,0xb4, + 0x76,0x3e,0x4e,0x4b,0x94,0xb2,0xbb,0xc1, + 0x94,0xc6,0x65,0x1e,0x77,0xca,0xf9,0x92, + 0xee,0xaa,0xc0,0x23,0x2a,0x28,0x1b,0xf6, + 0xb3,0xa7,0x39,0xc1,0x22,0x61,0x16,0x82, + 0x0a,0xe8,0xdb,0x58,0x47,0xa6,0x7c,0xbe, + 0xf9,0xc9,0x09,0x1b,0x46,0x2d,0x53,0x8c, + 0xd7,0x2b,0x03,0x74,0x6a,0xe7,0x7f,0x5e, + 0x62,0x29,0x2c,0x31,0x15,0x62,0xa8,0x46, + 0x50,0x5d,0xc8,0x2d,0xb8,0x54,0x33,0x8a, + 0xe4,0x9f,0x52,0x35,0xc9,0x5b,0x91,0x17, + 0x8c,0xcf,0x2d,0xd5,0xca,0xce,0xf4,0x03, + 0xec,0x9d,0x18,0x10,0xc6,0x27,0x2b,0x04, + 0x5b,0x3b,0x71,0xf9,0xdc,0x6b,0x80,0xd6, + 0x3f,0xdd,0x4a,0x8e,0x9a,0xdb,0x1e,0x69, + 0x62,0xa6,0x95,0x26,0xd4,0x31,0x61,0xc1, + 0xa4,0x1d,0x57,0x0d,0x79,0x38,0xda,0xd4, + 0xa4,0x0e,0x32,0x9c,0xd0,0xe4,0x0e,0x65, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +static const u8 ffdhe6144_q[] = { + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, + 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, + 0xec,0x5c,0xe2,0xc1,0xe7,0x16,0x9b,0x4a, + 0xd4,0xf0,0x9b,0x20,0x8a,0x32,0x19,0xfd, + 0xe6,0x49,0xce,0xe7,0x12,0x4d,0x9f,0x7c, + 0xbe,0x97,0xf1,0xb1,0xb1,0x86,0x3a,0xec, + 0x7b,0x40,0xd9,0x01,0x57,0x62,0x30,0xbd, + 0x69,0xef,0x8f,0x6a,0xea,0xfe,0xb2,0xb0, + 0x92,0x19,0xfa,0x8f,0xaf,0x83,0x37,0x68, + 0x42,0xb1,0xb2,0xaa,0x9e,0xf6,0x8d,0x79, + 0xda,0xab,0x89,0xaf,0x3f,0xab,0xe4,0x9a, + 0xcc,0x27,0x86,0x38,0x70,0x73,0x45,0xbb, + 0xf1,0x53,0x44,0xed,0x79,0xf7,0xf4,0x39, + 0x0e,0xf8,0xac,0x50,0x9b,0x56,0xf3,0x9a, + 0x98,0x56,0x65,0x27,0xa4,0x1d,0x3c,0xbd, + 0x5e,0x05,0x58,0xc1,0x59,0x92,0x7d,0xb0, + 0xe8,0x84,0x54,0xa5,0xd9,0x64,0x71,0xfd, + 0xdc,0xb5,0x6d,0x5b,0xb0,0x6b,0xfa,0x34, + 0x0e,0xa7,0xa1,0x51,0xef,0x1c,0xa6,0xfa, + 0x57,0x2b,0x76,0xf3,0xb1,0xb9,0x5d,0x8c, + 0x85,0x83,0xd3,0xe4,0x77,0x05,0x36,0xb8, + 0x4f,0x01,0x7e,0x70,0xe6,0xfb,0xf1,0x76, + 0x60,0x1a,0x02,0x66,0x94,0x1a,0x17,0xb0, + 0xc8,0xb9,0x7f,0x4e,0x74,0xc2,0xc1,0xff, + 0xc7,0x27,0x89,0x19,0x77,0x79,0x40,0xc1, + 0xe1,0xff,0x1d,0x8d,0xa6,0x37,0xd6,0xb9, + 0x9d,0xda,0xfe,0x5e,0x17,0x61,0x10,0x02, + 0xe2,0xc7,0x78,0xc1,0xbe,0x8b,0x41,0xd9, + 0x63,0x79,0xa5,0x13,0x60,0xd9,0x77,0xfd, + 0x44,0x35,0xa1,0x1c,0x30,0x8f,0xe7,0xee, + 0x6f,0x1a,0xad,0x9d,0xb2,0x8c,0x81,0xad, + 0xde,0x1a,0x7a,0x6f,0x7c,0xce,0x01,0x1c, + 0x30,0xda,0x37,0xe4,0xeb,0x73,0x64,0x83, + 0xbd,0x6c,0x8e,0x93,0x48,0xfb,0xfb,0xf7, + 0x2c,0xc6,0x58,0x7d,0x60,0xc3,0x6c,0x8e, + 0x57,0x7f,0x09,0x84,0xc2,0x89,0xc9,0x38, + 0x5a,0x09,0x86,0x49,0xde,0x21,0xbc,0xa2, + 0x7a,0x7e,0xa2,0x29,0x71,0x6b,0xa6,0xe9, + 0xb2,0x79,0x71,0x0f,0x38,0xfa,0xa5,0xff, + 0xae,0x57,0x41,0x55,0xce,0x4e,0xfb,0x4f, + 0x74,0x36,0x95,0xe2,0x91,0x1b,0x1d,0x06, + 0xd5,0xe2,0x90,0xcb,0xcd,0x86,0xf5,0x6d, + 0x0e,0xdf,0xcd,0x21,0x6a,0xe2,0x24,0x27, + 0x05,0x5e,0x68,0x35,0xfd,0x29,0xee,0xf7, + 0x9e,0x0d,0x90,0x77,0x1f,0xea,0xce,0xbe, + 0x12,0xf2,0x0e,0x95,0xb3,0x4f,0x0f,0x78, + 0xb7,0x37,0xa9,0x61,0x8b,0x26,0xfa,0x7d, + 0xbc,0x98,0x74,0xf2,0x72,0xc4,0x2b,0xdb, + 0x56,0x3e,0xaf,0xa1,0x6b,0x4f,0xb6,0x8c, + 0x3b,0xb1,0xe7,0x8e,0xaa,0x81,0xa0,0x02, + 0x43,0xfa,0xad,0xd2,0xbf,0x18,0xe6,0x3d, + 0x38,0x9a,0xe4,0x43,0x77,0xda,0x18,0xc5, + 0x76,0xb5,0x0f,0x00,0x96,0xcf,0x34,0x19, + 0x54,0x83,0xb0,0x05,0x48,0xc0,0x98,0x62, + 0x36,0xe3,0xbc,0x7c,0xb8,0xd6,0x80,0x1c, + 0x04,0x94,0xcc,0xd1,0x99,0xe5,0xc5,0xbd, + 0x0d,0x0e,0xdc,0x9e,0xb8,0xa0,0x00,0x1e, + 0x15,0x27,0x67,0x54,0xfc,0xc6,0x85,0x66, + 0x05,0x41,0x48,0xe6,0xe7,0x64,0xbe,0xe7, + 0xc7,0x64,0xda,0xad,0x3f,0xc4,0x52,0x35, + 0xa6,0xda,0xd4,0x28,0xfa,0x20,0xc1,0x70, + 0xe3,0x45,0x00,0x3f,0x2f,0x06,0xec,0x81, + 0x05,0xfe,0xb2,0x5b,0x22,0x81,0xb6,0x3d, + 0x27,0x33,0xbe,0x96,0x1c,0x29,0x95,0x1d, + 0x11,0xdd,0x22,0x21,0x65,0x7a,0x9f,0x53, + 0x1d,0xda,0x2a,0x19,0x4d,0xbb,0x12,0x64, + 0x48,0xbd,0xee,0xb2,0x58,0xe0,0x7e,0xa6, + 0x59,0xc7,0x46,0x19,0xa6,0x38,0x0e,0x1d, + 0x66,0xd6,0x83,0x2b,0xfe,0x67,0xf6,0x38, + 0xcd,0x8f,0xae,0x1f,0x27,0x23,0x02,0x0f, + 0x9c,0x40,0xa3,0xfd,0xa6,0x7e,0xda,0x3b, + 0xd2,0x92,0x38,0xfb,0xd4,0xd4,0xb4,0x88, + 0x5c,0x2a,0x99,0x17,0x6d,0xb1,0xa0,0x6c, + 0x50,0x07,0x78,0x49,0x1a,0x82,0x88,0xf1, + 0x85,0x5f,0x60,0xff,0xfc,0xf1,0xd1,0x37, + 0x3f,0xd9,0x4f,0xc6,0x0c,0x18,0x11,0xe1, + 0xac,0x3f,0x1c,0x6d,0x00,0x3b,0xec,0xda, + 0x3b,0x1f,0x27,0x25,0xca,0x59,0x5d,0xe0, + 0xca,0x63,0x32,0x8f,0x3b,0xe5,0x7c,0xc9, + 0x77,0x55,0x60,0x11,0x95,0x14,0x0d,0xfb, + 0x59,0xd3,0x9c,0xe0,0x91,0x30,0x8b,0x41, + 0x05,0x74,0x6d,0xac,0x23,0xd3,0x3e,0x5f, + 0x7c,0xe4,0x84,0x8d,0xa3,0x16,0xa9,0xc6, + 0x6b,0x95,0x81,0xba,0x35,0x73,0xbf,0xaf, + 0x31,0x14,0x96,0x18,0x8a,0xb1,0x54,0x23, + 0x28,0x2e,0xe4,0x16,0xdc,0x2a,0x19,0xc5, + 0x72,0x4f,0xa9,0x1a,0xe4,0xad,0xc8,0x8b, + 0xc6,0x67,0x96,0xea,0xe5,0x67,0x7a,0x01, + 0xf6,0x4e,0x8c,0x08,0x63,0x13,0x95,0x82, + 0x2d,0x9d,0xb8,0xfc,0xee,0x35,0xc0,0x6b, + 0x1f,0xee,0xa5,0x47,0x4d,0x6d,0x8f,0x34, + 0xb1,0x53,0x4a,0x93,0x6a,0x18,0xb0,0xe0, + 0xd2,0x0e,0xab,0x86,0xbc,0x9c,0x6d,0x6a, + 0x52,0x07,0x19,0x4e,0x68,0x72,0x07,0x32, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +/* + * ffdhe8192 generator (g), modulus (p) and group size (q) + */ + +static const u8 ffdhe8192_g[] = { 0x02 }; + +static const u8 ffdhe8192_p[] = { + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, + 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, + 0xd8,0xb9,0xc5,0x83,0xce,0x2d,0x36,0x95, + 0xa9,0xe1,0x36,0x41,0x14,0x64,0x33,0xfb, + 0xcc,0x93,0x9d,0xce,0x24,0x9b,0x3e,0xf9, + 0x7d,0x2f,0xe3,0x63,0x63,0x0c,0x75,0xd8, + 0xf6,0x81,0xb2,0x02,0xae,0xc4,0x61,0x7a, + 0xd3,0xdf,0x1e,0xd5,0xd5,0xfd,0x65,0x61, + 0x24,0x33,0xf5,0x1f,0x5f,0x06,0x6e,0xd0, + 0x85,0x63,0x65,0x55,0x3d,0xed,0x1a,0xf3, + 0xb5,0x57,0x13,0x5e,0x7f,0x57,0xc9,0x35, + 0x98,0x4f,0x0c,0x70,0xe0,0xe6,0x8b,0x77, + 0xe2,0xa6,0x89,0xda,0xf3,0xef,0xe8,0x72, + 0x1d,0xf1,0x58,0xa1,0x36,0xad,0xe7,0x35, + 0x30,0xac,0xca,0x4f,0x48,0x3a,0x79,0x7a, + 0xbc,0x0a,0xb1,0x82,0xb3,0x24,0xfb,0x61, + 0xd1,0x08,0xa9,0x4b,0xb2,0xc8,0xe3,0xfb, + 0xb9,0x6a,0xda,0xb7,0x60,0xd7,0xf4,0x68, + 0x1d,0x4f,0x42,0xa3,0xde,0x39,0x4d,0xf4, + 0xae,0x56,0xed,0xe7,0x63,0x72,0xbb,0x19, + 0x0b,0x07,0xa7,0xc8,0xee,0x0a,0x6d,0x70, + 0x9e,0x02,0xfc,0xe1,0xcd,0xf7,0xe2,0xec, + 0xc0,0x34,0x04,0xcd,0x28,0x34,0x2f,0x61, + 0x91,0x72,0xfe,0x9c,0xe9,0x85,0x83,0xff, + 0x8e,0x4f,0x12,0x32,0xee,0xf2,0x81,0x83, + 0xc3,0xfe,0x3b,0x1b,0x4c,0x6f,0xad,0x73, + 0x3b,0xb5,0xfc,0xbc,0x2e,0xc2,0x20,0x05, + 0xc5,0x8e,0xf1,0x83,0x7d,0x16,0x83,0xb2, + 0xc6,0xf3,0x4a,0x26,0xc1,0xb2,0xef,0xfa, + 0x88,0x6b,0x42,0x38,0x61,0x1f,0xcf,0xdc, + 0xde,0x35,0x5b,0x3b,0x65,0x19,0x03,0x5b, + 0xbc,0x34,0xf4,0xde,0xf9,0x9c,0x02,0x38, + 0x61,0xb4,0x6f,0xc9,0xd6,0xe6,0xc9,0x07, + 0x7a,0xd9,0x1d,0x26,0x91,0xf7,0xf7,0xee, + 0x59,0x8c,0xb0,0xfa,0xc1,0x86,0xd9,0x1c, + 0xae,0xfe,0x13,0x09,0x85,0x13,0x92,0x70, + 0xb4,0x13,0x0c,0x93,0xbc,0x43,0x79,0x44, + 0xf4,0xfd,0x44,0x52,0xe2,0xd7,0x4d,0xd3, + 0x64,0xf2,0xe2,0x1e,0x71,0xf5,0x4b,0xff, + 0x5c,0xae,0x82,0xab,0x9c,0x9d,0xf6,0x9e, + 0xe8,0x6d,0x2b,0xc5,0x22,0x36,0x3a,0x0d, + 0xab,0xc5,0x21,0x97,0x9b,0x0d,0xea,0xda, + 0x1d,0xbf,0x9a,0x42,0xd5,0xc4,0x48,0x4e, + 0x0a,0xbc,0xd0,0x6b,0xfa,0x53,0xdd,0xef, + 0x3c,0x1b,0x20,0xee,0x3f,0xd5,0x9d,0x7c, + 0x25,0xe4,0x1d,0x2b,0x66,0x9e,0x1e,0xf1, + 0x6e,0x6f,0x52,0xc3,0x16,0x4d,0xf4,0xfb, + 0x79,0x30,0xe9,0xe4,0xe5,0x88,0x57,0xb6, + 0xac,0x7d,0x5f,0x42,0xd6,0x9f,0x6d,0x18, + 0x77,0x63,0xcf,0x1d,0x55,0x03,0x40,0x04, + 0x87,0xf5,0x5b,0xa5,0x7e,0x31,0xcc,0x7a, + 0x71,0x35,0xc8,0x86,0xef,0xb4,0x31,0x8a, + 0xed,0x6a,0x1e,0x01,0x2d,0x9e,0x68,0x32, + 0xa9,0x07,0x60,0x0a,0x91,0x81,0x30,0xc4, + 0x6d,0xc7,0x78,0xf9,0x71,0xad,0x00,0x38, + 0x09,0x29,0x99,0xa3,0x33,0xcb,0x8b,0x7a, + 0x1a,0x1d,0xb9,0x3d,0x71,0x40,0x00,0x3c, + 0x2a,0x4e,0xce,0xa9,0xf9,0x8d,0x0a,0xcc, + 0x0a,0x82,0x91,0xcd,0xce,0xc9,0x7d,0xcf, + 0x8e,0xc9,0xb5,0x5a,0x7f,0x88,0xa4,0x6b, + 0x4d,0xb5,0xa8,0x51,0xf4,0x41,0x82,0xe1, + 0xc6,0x8a,0x00,0x7e,0x5e,0x0d,0xd9,0x02, + 0x0b,0xfd,0x64,0xb6,0x45,0x03,0x6c,0x7a, + 0x4e,0x67,0x7d,0x2c,0x38,0x53,0x2a,0x3a, + 0x23,0xba,0x44,0x42,0xca,0xf5,0x3e,0xa6, + 0x3b,0xb4,0x54,0x32,0x9b,0x76,0x24,0xc8, + 0x91,0x7b,0xdd,0x64,0xb1,0xc0,0xfd,0x4c, + 0xb3,0x8e,0x8c,0x33,0x4c,0x70,0x1c,0x3a, + 0xcd,0xad,0x06,0x57,0xfc,0xcf,0xec,0x71, + 0x9b,0x1f,0x5c,0x3e,0x4e,0x46,0x04,0x1f, + 0x38,0x81,0x47,0xfb,0x4c,0xfd,0xb4,0x77, + 0xa5,0x24,0x71,0xf7,0xa9,0xa9,0x69,0x10, + 0xb8,0x55,0x32,0x2e,0xdb,0x63,0x40,0xd8, + 0xa0,0x0e,0xf0,0x92,0x35,0x05,0x11,0xe3, + 0x0a,0xbe,0xc1,0xff,0xf9,0xe3,0xa2,0x6e, + 0x7f,0xb2,0x9f,0x8c,0x18,0x30,0x23,0xc3, + 0x58,0x7e,0x38,0xda,0x00,0x77,0xd9,0xb4, + 0x76,0x3e,0x4e,0x4b,0x94,0xb2,0xbb,0xc1, + 0x94,0xc6,0x65,0x1e,0x77,0xca,0xf9,0x92, + 0xee,0xaa,0xc0,0x23,0x2a,0x28,0x1b,0xf6, + 0xb3,0xa7,0x39,0xc1,0x22,0x61,0x16,0x82, + 0x0a,0xe8,0xdb,0x58,0x47,0xa6,0x7c,0xbe, + 0xf9,0xc9,0x09,0x1b,0x46,0x2d,0x53,0x8c, + 0xd7,0x2b,0x03,0x74,0x6a,0xe7,0x7f,0x5e, + 0x62,0x29,0x2c,0x31,0x15,0x62,0xa8,0x46, + 0x50,0x5d,0xc8,0x2d,0xb8,0x54,0x33,0x8a, + 0xe4,0x9f,0x52,0x35,0xc9,0x5b,0x91,0x17, + 0x8c,0xcf,0x2d,0xd5,0xca,0xce,0xf4,0x03, + 0xec,0x9d,0x18,0x10,0xc6,0x27,0x2b,0x04, + 0x5b,0x3b,0x71,0xf9,0xdc,0x6b,0x80,0xd6, + 0x3f,0xdd,0x4a,0x8e,0x9a,0xdb,0x1e,0x69, + 0x62,0xa6,0x95,0x26,0xd4,0x31,0x61,0xc1, + 0xa4,0x1d,0x57,0x0d,0x79,0x38,0xda,0xd4, + 0xa4,0x0e,0x32,0x9c,0xcf,0xf4,0x6a,0xaa, + 0x36,0xad,0x00,0x4c,0xf6,0x00,0xc8,0x38, + 0x1e,0x42,0x5a,0x31,0xd9,0x51,0xae,0x64, + 0xfd,0xb2,0x3f,0xce,0xc9,0x50,0x9d,0x43, + 0x68,0x7f,0xeb,0x69,0xed,0xd1,0xcc,0x5e, + 0x0b,0x8c,0xc3,0xbd,0xf6,0x4b,0x10,0xef, + 0x86,0xb6,0x31,0x42,0xa3,0xab,0x88,0x29, + 0x55,0x5b,0x2f,0x74,0x7c,0x93,0x26,0x65, + 0xcb,0x2c,0x0f,0x1c,0xc0,0x1b,0xd7,0x02, + 0x29,0x38,0x88,0x39,0xd2,0xaf,0x05,0xe4, + 0x54,0x50,0x4a,0xc7,0x8b,0x75,0x82,0x82, + 0x28,0x46,0xc0,0xba,0x35,0xc3,0x5f,0x5c, + 0x59,0x16,0x0c,0xc0,0x46,0xfd,0x82,0x51, + 0x54,0x1f,0xc6,0x8c,0x9c,0x86,0xb0,0x22, + 0xbb,0x70,0x99,0x87,0x6a,0x46,0x0e,0x74, + 0x51,0xa8,0xa9,0x31,0x09,0x70,0x3f,0xee, + 0x1c,0x21,0x7e,0x6c,0x38,0x26,0xe5,0x2c, + 0x51,0xaa,0x69,0x1e,0x0e,0x42,0x3c,0xfc, + 0x99,0xe9,0xe3,0x16,0x50,0xc1,0x21,0x7b, + 0x62,0x48,0x16,0xcd,0xad,0x9a,0x95,0xf9, + 0xd5,0xb8,0x01,0x94,0x88,0xd9,0xc0,0xa0, + 0xa1,0xfe,0x30,0x75,0xa5,0x77,0xe2,0x31, + 0x83,0xf8,0x1d,0x4a,0x3f,0x2f,0xa4,0x57, + 0x1e,0xfc,0x8c,0xe0,0xba,0x8a,0x4f,0xe8, + 0xb6,0x85,0x5d,0xfe,0x72,0xb0,0xa6,0x6e, + 0xde,0xd2,0xfb,0xab,0xfb,0xe5,0x8a,0x30, + 0xfa,0xfa,0xbe,0x1c,0x5d,0x71,0xa8,0x7e, + 0x2f,0x74,0x1e,0xf8,0xc1,0xfe,0x86,0xfe, + 0xa6,0xbb,0xfd,0xe5,0x30,0x67,0x7f,0x0d, + 0x97,0xd1,0x1d,0x49,0xf7,0xa8,0x44,0x3d, + 0x08,0x22,0xe5,0x06,0xa9,0xf4,0x61,0x4e, + 0x01,0x1e,0x2a,0x94,0x83,0x8f,0xf8,0x8c, + 0xd6,0x8c,0x8b,0xb7,0xc5,0xc6,0x42,0x4c, + 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +static const u8 ffdhe8192_q[] = { + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, + 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, + 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, + 0xec,0x5c,0xe2,0xc1,0xe7,0x16,0x9b,0x4a, + 0xd4,0xf0,0x9b,0x20,0x8a,0x32,0x19,0xfd, + 0xe6,0x49,0xce,0xe7,0x12,0x4d,0x9f,0x7c, + 0xbe,0x97,0xf1,0xb1,0xb1,0x86,0x3a,0xec, + 0x7b,0x40,0xd9,0x01,0x57,0x62,0x30,0xbd, + 0x69,0xef,0x8f,0x6a,0xea,0xfe,0xb2,0xb0, + 0x92,0x19,0xfa,0x8f,0xaf,0x83,0x37,0x68, + 0x42,0xb1,0xb2,0xaa,0x9e,0xf6,0x8d,0x79, + 0xda,0xab,0x89,0xaf,0x3f,0xab,0xe4,0x9a, + 0xcc,0x27,0x86,0x38,0x70,0x73,0x45,0xbb, + 0xf1,0x53,0x44,0xed,0x79,0xf7,0xf4,0x39, + 0x0e,0xf8,0xac,0x50,0x9b,0x56,0xf3,0x9a, + 0x98,0x56,0x65,0x27,0xa4,0x1d,0x3c,0xbd, + 0x5e,0x05,0x58,0xc1,0x59,0x92,0x7d,0xb0, + 0xe8,0x84,0x54,0xa5,0xd9,0x64,0x71,0xfd, + 0xdc,0xb5,0x6d,0x5b,0xb0,0x6b,0xfa,0x34, + 0x0e,0xa7,0xa1,0x51,0xef,0x1c,0xa6,0xfa, + 0x57,0x2b,0x76,0xf3,0xb1,0xb9,0x5d,0x8c, + 0x85,0x83,0xd3,0xe4,0x77,0x05,0x36,0xb8, + 0x4f,0x01,0x7e,0x70,0xe6,0xfb,0xf1,0x76, + 0x60,0x1a,0x02,0x66,0x94,0x1a,0x17,0xb0, + 0xc8,0xb9,0x7f,0x4e,0x74,0xc2,0xc1,0xff, + 0xc7,0x27,0x89,0x19,0x77,0x79,0x40,0xc1, + 0xe1,0xff,0x1d,0x8d,0xa6,0x37,0xd6,0xb9, + 0x9d,0xda,0xfe,0x5e,0x17,0x61,0x10,0x02, + 0xe2,0xc7,0x78,0xc1,0xbe,0x8b,0x41,0xd9, + 0x63,0x79,0xa5,0x13,0x60,0xd9,0x77,0xfd, + 0x44,0x35,0xa1,0x1c,0x30,0x8f,0xe7,0xee, + 0x6f,0x1a,0xad,0x9d,0xb2,0x8c,0x81,0xad, + 0xde,0x1a,0x7a,0x6f,0x7c,0xce,0x01,0x1c, + 0x30,0xda,0x37,0xe4,0xeb,0x73,0x64,0x83, + 0xbd,0x6c,0x8e,0x93,0x48,0xfb,0xfb,0xf7, + 0x2c,0xc6,0x58,0x7d,0x60,0xc3,0x6c,0x8e, + 0x57,0x7f,0x09,0x84,0xc2,0x89,0xc9,0x38, + 0x5a,0x09,0x86,0x49,0xde,0x21,0xbc,0xa2, + 0x7a,0x7e,0xa2,0x29,0x71,0x6b,0xa6,0xe9, + 0xb2,0x79,0x71,0x0f,0x38,0xfa,0xa5,0xff, + 0xae,0x57,0x41,0x55,0xce,0x4e,0xfb,0x4f, + 0x74,0x36,0x95,0xe2,0x91,0x1b,0x1d,0x06, + 0xd5,0xe2,0x90,0xcb,0xcd,0x86,0xf5,0x6d, + 0x0e,0xdf,0xcd,0x21,0x6a,0xe2,0x24,0x27, + 0x05,0x5e,0x68,0x35,0xfd,0x29,0xee,0xf7, + 0x9e,0x0d,0x90,0x77,0x1f,0xea,0xce,0xbe, + 0x12,0xf2,0x0e,0x95,0xb3,0x4f,0x0f,0x78, + 0xb7,0x37,0xa9,0x61,0x8b,0x26,0xfa,0x7d, + 0xbc,0x98,0x74,0xf2,0x72,0xc4,0x2b,0xdb, + 0x56,0x3e,0xaf,0xa1,0x6b,0x4f,0xb6,0x8c, + 0x3b,0xb1,0xe7,0x8e,0xaa,0x81,0xa0,0x02, + 0x43,0xfa,0xad,0xd2,0xbf,0x18,0xe6,0x3d, + 0x38,0x9a,0xe4,0x43,0x77,0xda,0x18,0xc5, + 0x76,0xb5,0x0f,0x00,0x96,0xcf,0x34,0x19, + 0x54,0x83,0xb0,0x05,0x48,0xc0,0x98,0x62, + 0x36,0xe3,0xbc,0x7c,0xb8,0xd6,0x80,0x1c, + 0x04,0x94,0xcc,0xd1,0x99,0xe5,0xc5,0xbd, + 0x0d,0x0e,0xdc,0x9e,0xb8,0xa0,0x00,0x1e, + 0x15,0x27,0x67,0x54,0xfc,0xc6,0x85,0x66, + 0x05,0x41,0x48,0xe6,0xe7,0x64,0xbe,0xe7, + 0xc7,0x64,0xda,0xad,0x3f,0xc4,0x52,0x35, + 0xa6,0xda,0xd4,0x28,0xfa,0x20,0xc1,0x70, + 0xe3,0x45,0x00,0x3f,0x2f,0x06,0xec,0x81, + 0x05,0xfe,0xb2,0x5b,0x22,0x81,0xb6,0x3d, + 0x27,0x33,0xbe,0x96,0x1c,0x29,0x95,0x1d, + 0x11,0xdd,0x22,0x21,0x65,0x7a,0x9f,0x53, + 0x1d,0xda,0x2a,0x19,0x4d,0xbb,0x12,0x64, + 0x48,0xbd,0xee,0xb2,0x58,0xe0,0x7e,0xa6, + 0x59,0xc7,0x46,0x19,0xa6,0x38,0x0e,0x1d, + 0x66,0xd6,0x83,0x2b,0xfe,0x67,0xf6,0x38, + 0xcd,0x8f,0xae,0x1f,0x27,0x23,0x02,0x0f, + 0x9c,0x40,0xa3,0xfd,0xa6,0x7e,0xda,0x3b, + 0xd2,0x92,0x38,0xfb,0xd4,0xd4,0xb4,0x88, + 0x5c,0x2a,0x99,0x17,0x6d,0xb1,0xa0,0x6c, + 0x50,0x07,0x78,0x49,0x1a,0x82,0x88,0xf1, + 0x85,0x5f,0x60,0xff,0xfc,0xf1,0xd1,0x37, + 0x3f,0xd9,0x4f,0xc6,0x0c,0x18,0x11,0xe1, + 0xac,0x3f,0x1c,0x6d,0x00,0x3b,0xec,0xda, + 0x3b,0x1f,0x27,0x25,0xca,0x59,0x5d,0xe0, + 0xca,0x63,0x32,0x8f,0x3b,0xe5,0x7c,0xc9, + 0x77,0x55,0x60,0x11,0x95,0x14,0x0d,0xfb, + 0x59,0xd3,0x9c,0xe0,0x91,0x30,0x8b,0x41, + 0x05,0x74,0x6d,0xac,0x23,0xd3,0x3e,0x5f, + 0x7c,0xe4,0x84,0x8d,0xa3,0x16,0xa9,0xc6, + 0x6b,0x95,0x81,0xba,0x35,0x73,0xbf,0xaf, + 0x31,0x14,0x96,0x18,0x8a,0xb1,0x54,0x23, + 0x28,0x2e,0xe4,0x16,0xdc,0x2a,0x19,0xc5, + 0x72,0x4f,0xa9,0x1a,0xe4,0xad,0xc8,0x8b, + 0xc6,0x67,0x96,0xea,0xe5,0x67,0x7a,0x01, + 0xf6,0x4e,0x8c,0x08,0x63,0x13,0x95,0x82, + 0x2d,0x9d,0xb8,0xfc,0xee,0x35,0xc0,0x6b, + 0x1f,0xee,0xa5,0x47,0x4d,0x6d,0x8f,0x34, + 0xb1,0x53,0x4a,0x93,0x6a,0x18,0xb0,0xe0, + 0xd2,0x0e,0xab,0x86,0xbc,0x9c,0x6d,0x6a, + 0x52,0x07,0x19,0x4e,0x67,0xfa,0x35,0x55, + 0x1b,0x56,0x80,0x26,0x7b,0x00,0x64,0x1c, + 0x0f,0x21,0x2d,0x18,0xec,0xa8,0xd7,0x32, + 0x7e,0xd9,0x1f,0xe7,0x64,0xa8,0x4e,0xa1, + 0xb4,0x3f,0xf5,0xb4,0xf6,0xe8,0xe6,0x2f, + 0x05,0xc6,0x61,0xde,0xfb,0x25,0x88,0x77, + 0xc3,0x5b,0x18,0xa1,0x51,0xd5,0xc4,0x14, + 0xaa,0xad,0x97,0xba,0x3e,0x49,0x93,0x32, + 0xe5,0x96,0x07,0x8e,0x60,0x0d,0xeb,0x81, + 0x14,0x9c,0x44,0x1c,0xe9,0x57,0x82,0xf2, + 0x2a,0x28,0x25,0x63,0xc5,0xba,0xc1,0x41, + 0x14,0x23,0x60,0x5d,0x1a,0xe1,0xaf,0xae, + 0x2c,0x8b,0x06,0x60,0x23,0x7e,0xc1,0x28, + 0xaa,0x0f,0xe3,0x46,0x4e,0x43,0x58,0x11, + 0x5d,0xb8,0x4c,0xc3,0xb5,0x23,0x07,0x3a, + 0x28,0xd4,0x54,0x98,0x84,0xb8,0x1f,0xf7, + 0x0e,0x10,0xbf,0x36,0x1c,0x13,0x72,0x96, + 0x28,0xd5,0x34,0x8f,0x07,0x21,0x1e,0x7e, + 0x4c,0xf4,0xf1,0x8b,0x28,0x60,0x90,0xbd, + 0xb1,0x24,0x0b,0x66,0xd6,0xcd,0x4a,0xfc, + 0xea,0xdc,0x00,0xca,0x44,0x6c,0xe0,0x50, + 0x50,0xff,0x18,0x3a,0xd2,0xbb,0xf1,0x18, + 0xc1,0xfc,0x0e,0xa5,0x1f,0x97,0xd2,0x2b, + 0x8f,0x7e,0x46,0x70,0x5d,0x45,0x27,0xf4, + 0x5b,0x42,0xae,0xff,0x39,0x58,0x53,0x37, + 0x6f,0x69,0x7d,0xd5,0xfd,0xf2,0xc5,0x18, + 0x7d,0x7d,0x5f,0x0e,0x2e,0xb8,0xd4,0x3f, + 0x17,0xba,0x0f,0x7c,0x60,0xff,0x43,0x7f, + 0x53,0x5d,0xfe,0xf2,0x98,0x33,0xbf,0x86, + 0xcb,0xe8,0x8e,0xa4,0xfb,0xd4,0x22,0x1e, + 0x84,0x11,0x72,0x83,0x54,0xfa,0x30,0xa7, + 0x00,0x8f,0x15,0x4a,0x41,0xc7,0xfc,0x46, + 0x6b,0x46,0x45,0xdb,0xe2,0xe3,0x21,0x26, + 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, +}; + +struct ffdhe_group { + int bits; + int minsize; + const u8 *p; + const u8 *q; + const u8 *g; +} ffdhe_group_map[] = { + { + .bits = 2048, + .minsize = 225, + .p = ffdhe2048_p, + .q = ffdhe2048_q, + .g = ffdhe2048_g, + }, + { + .bits = 3072, + .minsize = 275, + .p = ffdhe3072_p, + .q = ffdhe3072_q, + .g = ffdhe3072_g, + }, + { + .bits = 4096, + .minsize = 325, + .p = ffdhe4096_p, + .q = ffdhe4096_q, + .g = ffdhe4096_g, + }, + { + .bits = 6144, + .minsize = 375, + .p = ffdhe6144_p, + .q = ffdhe6144_q, + .g = ffdhe6144_g, + }, + { + .bits = 8192, + .minsize = 400, + .p = ffdhe8192_p, + .q = ffdhe8192_q, + .g = ffdhe8192_g, + }, +}; + +int crypto_ffdhe_params(struct dh *p, int bits) +{ + struct ffdhe_group *grp = NULL; + int i; + + for (i = 0; i < ARRAY_SIZE(ffdhe_group_map); i++) { + if (ffdhe_group_map[i].bits == bits) { + grp = &ffdhe_group_map[i]; + break; + } + } + if (!grp || !p) + return -EINVAL; + + p->p_size = grp->bits / 8; + p->p = (u8 *)grp->p; + p->g_size = 1; + p->g = (u8 *)grp->g; + p->q_size = grp->bits / 8; + p->q = (u8 *)grp->q; + + return 0; +} +EXPORT_SYMBOL_GPL(crypto_ffdhe_params); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("FFDHE ephemeral parameters"); diff --git a/include/crypto/ffdhe.h b/include/crypto/ffdhe.h new file mode 100644 index 000000000000..6cb9253ddb34 --- /dev/null +++ b/include/crypto/ffdhe.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Finite-Field Diffie-Hellman definition according to RFC 7919 + * + * Copyright (c) 2021, SUSE Software Products + * Authors: Hannes Reinecke + */ +#ifndef _CRYPTO_FFDHE_ +#define _CRYPTO_FFDHE_ + +/** + * crypto_ffdhe_params() - Generate FFDHE params + * @params: DH params + * @bits: Bitsize of the FFDHE parameters + * + * This functions sets the FFDHE parameter for @bits in @params. + * Valid bit sizes are 2048, 3072, 4096, 6144, or 8194. + * + * Returns: 0 on success, errno on failure. + */ + +int crypto_ffdhe_params(struct dh *p, int bits); + +#endif /* _CRYPTO_FFDHE_H */ From patchwork Thu Dec 2 15:23:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652799 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515BDC43219 for ; Thu, 2 Dec 2021 15:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358954AbhLBP1f (ORCPT ); Thu, 2 Dec 2021 10:27:35 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46490 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358941AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9A3652170C; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8Qbo2fngQHipAYE3FGwgL+Z3ZBEEH39Dg3B5tQ1+pI=; b=WxbC5iQR8i1nlzOxaFnq+2B1s+zJmkkHDbdhslW60HaWsPd4cwCmBU5CFN+cocjXdvTM3H XebmcddPMfVtPwF9TE7ZbMRlOubDCzdN/GVUtMj9YfNAdWRMB5GKQh8j1oC7rb8w8+ppKS t3y3pHPNRhfnvN9UCyoXz2hlyQbd/GI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8Qbo2fngQHipAYE3FGwgL+Z3ZBEEH39Dg3B5tQ1+pI=; b=uZFurLqLnHn5f3o1cEdcUqHdH/t5d6At/p1MK5ooC9fY44PwFpaR6kFtk1DX9MpD9gmzce tA0BKkzBTuYhKWAA== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id E2517A3B8B; Thu, 2 Dec 2021 15:24:07 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 308155191DF0; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Himanshu Madhani Subject: [PATCH 04/12] lib/base64: RFC4648-compliant base64 encoding Date: Thu, 2 Dec 2021 16:23:50 +0100 Message-Id: <20211202152358.60116-5-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add RFC4648-compliant base64 encoding and decoding routines, based on the base64url encoding in fs/crypto/fname.c. Signed-off-by: Hannes Reinecke Reviewed-by: Himanshu Madhani Reviewed-by: Sagi Grimberg --- include/linux/base64.h | 16 +++++++ lib/Makefile | 2 +- lib/base64.c | 103 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 120 insertions(+), 1 deletion(-) create mode 100644 include/linux/base64.h create mode 100644 lib/base64.c diff --git a/include/linux/base64.h b/include/linux/base64.h new file mode 100644 index 000000000000..660d4cb1ef31 --- /dev/null +++ b/include/linux/base64.h @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * base64 encoding, lifted from fs/crypto/fname.c. + */ + +#ifndef _LINUX_BASE64_H +#define _LINUX_BASE64_H + +#include + +#define BASE64_CHARS(nbytes) DIV_ROUND_UP((nbytes) * 4, 3) + +int base64_encode(const u8 *src, int len, char *dst); +int base64_decode(const char *src, int len, u8 *dst); + +#endif /* _LINUX_BASE64_H */ diff --git a/lib/Makefile b/lib/Makefile index 364c23f15578..ddc5cb4c6eb8 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -46,7 +46,7 @@ obj-y += bcd.o sort.o parser.o debug_locks.o random32.o \ bust_spinlocks.o kasprintf.o bitmap.o scatterlist.o \ list_sort.o uuid.o iov_iter.o clz_ctz.o \ bsearch.o find_bit.o llist.o memweight.o kfifo.o \ - percpu-refcount.o rhashtable.o \ + percpu-refcount.o rhashtable.o base64.o \ once.o refcount.o usercopy.o errseq.o bucket_locks.o \ generic-radix-tree.o obj-$(CONFIG_STRING_SELFTEST) += test_string.o diff --git a/lib/base64.c b/lib/base64.c new file mode 100644 index 000000000000..b736a7a431c5 --- /dev/null +++ b/lib/base64.c @@ -0,0 +1,103 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * base64.c - RFC4648-compliant base64 encoding + * + * Copyright (c) 2020 Hannes Reinecke, SUSE + * + * Based on the base64url routines from fs/crypto/fname.c + * (which are using the URL-safe base64 encoding), + * modified to use the standard coding table from RFC4648 section 4. + */ + +#include +#include +#include +#include +#include + +static const char base64_table[65] = + "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; + +/** + * base64_encode() - base64-encode some binary data + * @src: the binary data to encode + * @srclen: the length of @src in bytes + * @dst: (output) the base64-encoded string. Not NUL-terminated. + * + * Encodes data using base64 encoding, i.e. the "Base 64 Encoding" specified + * by RFC 4648, including the '='-padding. + * + * Return: the length of the resulting base64-encoded string in bytes. + */ +int base64_encode(const u8 *src, int srclen, char *dst) +{ + u32 ac = 0; + int bits = 0; + int i; + char *cp = dst; + + for (i = 0; i < srclen; i++) { + ac = (ac << 8) | src[i]; + bits += 8; + do { + bits -= 6; + *cp++ = base64_table[(ac >> bits) & 0x3f]; + } while (bits >= 6); + } + if (bits) { + *cp++ = base64_table[(ac << (6 - bits)) & 0x3f]; + bits -= 6; + } + while (bits < 0) { + *cp++ = '='; + bits += 2; + } + return cp - dst; +} +EXPORT_SYMBOL_GPL(base64_encode); + +/** + * base64_decode() - base64-decode a string + * @src: the string to decode. Doesn't need to be NUL-terminated. + * @srclen: the length of @src in bytes + * @dst: (output) the decoded binary data + * + * Decodes a string using base64 encoding, i.e. the "Base 64 Encoding" + * specified by RFC 4648, including the '='-padding. + * + * This implementation hasn't been optimized for performance. + * + * Return: the length of the resulting decoded binary data in bytes, + * or -1 if the string isn't a valid base64 string. + */ +int base64_decode(const char *src, int srclen, u8 *dst) +{ + u32 ac = 0; + int bits = 0; + int i; + u8 *bp = dst; + + for (i = 0; i < srclen; i++) { + const char *p = strchr(base64_table, src[i]); + + if (src[i] == '=') { + ac = (ac << 6); + bits += 6; + if (bits >= 8) + bits -= 8; + continue; + } + if (p == NULL || src[i] == 0) + return -1; + ac = (ac << 6) | (p - base64_table); + bits += 6; + if (bits >= 8) { + bits -= 8; + *bp++ = (u8)(ac >> bits); + } + } + if (ac & ((1 << bits) - 1)) + return -1; + return bp - dst; +} +EXPORT_SYMBOL_GPL(base64_decode); From patchwork Thu Dec 2 15:23:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652803 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7BDFC433FE for ; Thu, 2 Dec 2021 15:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358943AbhLBP1g (ORCPT ); Thu, 2 Dec 2021 10:27:36 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46518 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358944AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A7D6B218A4; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FJG465KfwdElrV0bTBUGPXoVhIfTfLAXHvVyDhAj6Zg=; b=oO0MudD3fQS19jmqIC/rOJ7x33n7EZzc+UKmL1aicslwp+8BpuQATu+Z8FSQBnO/p2of2O YXxTWStyqENrrx3jqh1Kl/0jeiiL2oO2iMJwOZqz6C9UI5WVsqt/SWtugsncwcyqR8o3qr lMNcYcgQwcbodMbo5Crei4FifoeZFp0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FJG465KfwdElrV0bTBUGPXoVhIfTfLAXHvVyDhAj6Zg=; b=YTBrrRnYTIDtbO7nJUfqJE7CvtTHMj2OIgVeGoM3kSOkXfE6qx0oQAHFLdHVuStr4nyO1q 9QIlyd8LbMag2wDg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 98AAAA3B90; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 366E85191DF2; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Himanshu Madhani , Chaitanya Kulkarni Subject: [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication Date: Thu, 2 Dec 2021 16:23:51 +0100 Message-Id: <20211202152358.60116-6-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add new definitions for NVMe In-band authentication as defined in the NVMe Base Specification v2.0. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Himanshu Madhani Reviewed-by: Chaitanya Kulkarni --- include/linux/nvme.h | 188 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 187 insertions(+), 1 deletion(-) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 855dd9b3e84b..d84594426e85 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -19,6 +19,7 @@ #define NVMF_TRSVCID_SIZE 32 #define NVMF_TRADDR_SIZE 256 #define NVMF_TSAS_SIZE 256 +#define NVMF_AUTH_HASH_LEN 64 #define NVME_DISC_SUBSYS_NAME "nqn.2014-08.org.nvmexpress.discovery" @@ -1278,6 +1279,8 @@ enum nvmf_capsule_command { nvme_fabrics_type_property_set = 0x00, nvme_fabrics_type_connect = 0x01, nvme_fabrics_type_property_get = 0x04, + nvme_fabrics_type_auth_send = 0x05, + nvme_fabrics_type_auth_receive = 0x06, }; #define nvme_fabrics_type_name(type) { type, #type } @@ -1285,7 +1288,9 @@ enum nvmf_capsule_command { __print_symbolic(type, \ nvme_fabrics_type_name(nvme_fabrics_type_property_set), \ nvme_fabrics_type_name(nvme_fabrics_type_connect), \ - nvme_fabrics_type_name(nvme_fabrics_type_property_get)) + nvme_fabrics_type_name(nvme_fabrics_type_property_get), \ + nvme_fabrics_type_name(nvme_fabrics_type_auth_send), \ + nvme_fabrics_type_name(nvme_fabrics_type_auth_receive)) /* * If not fabrics command, fctype will be ignored. @@ -1415,6 +1420,185 @@ struct nvmf_property_get_command { __u8 resv4[16]; }; +struct nvmf_auth_send_command { + __u8 opcode; + __u8 resv1; + __u16 command_id; + __u8 fctype; + __u8 resv2[19]; + union nvme_data_ptr dptr; + __u8 resv3; + __u8 spsp0; + __u8 spsp1; + __u8 secp; + __le32 tl; + __u8 resv4[16]; +}; + +struct nvmf_auth_receive_command { + __u8 opcode; + __u8 resv1; + __u16 command_id; + __u8 fctype; + __u8 resv2[19]; + union nvme_data_ptr dptr; + __u8 resv3; + __u8 spsp0; + __u8 spsp1; + __u8 secp; + __le32 al; + __u8 resv4[16]; +}; + +/* Value for secp */ +enum { + NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER = 0xe9, +}; + +/* Defined value for auth_type */ +enum { + NVME_AUTH_COMMON_MESSAGES = 0x00, + NVME_AUTH_DHCHAP_MESSAGES = 0x01, +}; + +/* Defined messages for auth_id */ +enum { + NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE = 0x00, + NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE = 0x01, + NVME_AUTH_DHCHAP_MESSAGE_REPLY = 0x02, + NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1 = 0x03, + NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2 = 0x04, + NVME_AUTH_DHCHAP_MESSAGE_FAILURE2 = 0xf0, + NVME_AUTH_DHCHAP_MESSAGE_FAILURE1 = 0xf1, +}; + +struct nvmf_auth_dhchap_protocol_descriptor { + __u8 authid; + __u8 rsvd; + __u8 halen; + __u8 dhlen; + __u8 idlist[60]; +}; + +enum { + NVME_AUTH_DHCHAP_AUTH_ID = 0x01, +}; + +/* Defined hash functions for DH-HMAC-CHAP authentication */ +enum { + NVME_AUTH_HASH_SHA256 = 0x01, + NVME_AUTH_HASH_SHA384 = 0x02, + NVME_AUTH_HASH_SHA512 = 0x03, + NVME_AUTH_HASH_INVALID = 0xff, +}; + +/* Defined Diffie-Hellman group identifiers for DH-HMAC-CHAP authentication */ +enum { + NVME_AUTH_DHGROUP_NULL = 0x00, + NVME_AUTH_DHGROUP_2048 = 0x01, + NVME_AUTH_DHGROUP_3072 = 0x02, + NVME_AUTH_DHGROUP_4096 = 0x03, + NVME_AUTH_DHGROUP_6144 = 0x04, + NVME_AUTH_DHGROUP_8192 = 0x05, + NVME_AUTH_DHGROUP_INVALID = 0xff, +}; + +union nvmf_auth_protocol { + struct nvmf_auth_dhchap_protocol_descriptor dhchap; +}; + +struct nvmf_auth_dhchap_negotiate_data { + __u8 auth_type; + __u8 auth_id; + __le16 rsvd; + __le16 t_id; + __u8 sc_c; + __u8 napd; + union nvmf_auth_protocol auth_protocol[]; +}; + +struct nvmf_auth_dhchap_challenge_data { + __u8 auth_type; + __u8 auth_id; + __u16 rsvd1; + __le16 t_id; + __u8 hl; + __u8 rsvd2; + __u8 hashid; + __u8 dhgid; + __le16 dhvlen; + __le32 seqnum; + /* 'hl' bytes of challenge value */ + __u8 cval[]; + /* followed by 'dhvlen' bytes of DH value */ +}; + +struct nvmf_auth_dhchap_reply_data { + __u8 auth_type; + __u8 auth_id; + __le16 rsvd1; + __le16 t_id; + __u8 hl; + __u8 rsvd2; + __u8 cvalid; + __u8 rsvd3; + __le16 dhvlen; + __le32 seqnum; + /* 'hl' bytes of response data */ + __u8 rval[]; + /* followed by 'hl' bytes of Challenge value */ + /* followed by 'dhvlen' bytes of DH value */ +}; + +enum { + NVME_AUTH_DHCHAP_RESPONSE_VALID = (1 << 0), +}; + +struct nvmf_auth_dhchap_success1_data { + __u8 auth_type; + __u8 auth_id; + __le16 rsvd1; + __le16 t_id; + __u8 hl; + __u8 rsvd2; + __u8 rvalid; + __u8 rsvd3[7]; + /* 'hl' bytes of response value if 'rvalid' is set */ + __u8 rval[]; +}; + +struct nvmf_auth_dhchap_success2_data { + __u8 auth_type; + __u8 auth_id; + __le16 rsvd1; + __le16 t_id; + __u8 rsvd2[10]; +}; + +struct nvmf_auth_dhchap_failure_data { + __u8 auth_type; + __u8 auth_id; + __le16 rsvd1; + __le16 t_id; + __u8 rescode; + __u8 rescode_exp; +}; + +enum { + NVME_AUTH_DHCHAP_FAILURE_REASON_FAILED = 0x01, +}; + +enum { + NVME_AUTH_DHCHAP_FAILURE_FAILED = 0x01, + NVME_AUTH_DHCHAP_FAILURE_NOT_USABLE = 0x02, + NVME_AUTH_DHCHAP_FAILURE_CONCAT_MISMATCH = 0x03, + NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE = 0x04, + NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE = 0x05, + NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD = 0x06, + NVME_AUTH_DHCHAP_FAILURE_INCORRECT_MESSAGE = 0x07, +}; + + struct nvme_dbbuf { __u8 opcode; __u8 flags; @@ -1458,6 +1642,8 @@ struct nvme_command { struct nvmf_connect_command connect; struct nvmf_property_set_command prop_set; struct nvmf_property_get_command prop_get; + struct nvmf_auth_send_command auth_send; + struct nvmf_auth_receive_command auth_receive; struct nvme_dbbuf dbbuf; struct nvme_directive_cmd directive; }; From patchwork Thu Dec 2 15:23:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652807 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE06EC4332F for ; Thu, 2 Dec 2021 15:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358962AbhLBP1i (ORCPT ); Thu, 2 Dec 2021 10:27:38 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42160 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358947AbhLBP1d (ORCPT ); Thu, 2 Dec 2021 10:27:33 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id ACD261FE05; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=WSBaC6fcenKftbVqzpYR1kLRTBABJw+g3S8sO9nNsOOx7WB8B87Rbrh0gBMCXEetENCh0A q70SZ6yVt4OG0L9o1prl9oZr6eMzVJZC1rquGNtdCkE0qcP1H/xIgfBg55U6V3ANEAH1oi E3D50B4MYjFB1KWeEUGwYxojslCaiGY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=x0qG8tGZZPbVT0uPoiziITRamUCsgttPVQ0tvz2SpDoVEqUvP+pDKWteJm1LfifdsNW+9z 1Ao+7auP7caiO0BQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 9B604A3B93; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 3ADE45191DF4; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error Date: Thu, 2 Dec 2021 16:23:52 +0100 Message-Id: <20211202152358.60116-7-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index c5a2b71c5268..a1343a0790f6 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n", From patchwork Thu Dec 2 15:23:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652811 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4028C433F5 for ; Thu, 2 Dec 2021 15:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358940AbhLBP1h (ORCPT ); Thu, 2 Dec 2021 10:27:37 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46528 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358945AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A74A921891; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WmIpR3yrbPb3X5Gx4+u4qy9wb+Kqqj9GOHJDtr4MZvE=; b=bD8W0J1HspkojbjAPnkHgeTSynbWf/JtOsNyWN3o3MPIt8PilW/Ueylw+4hyaLa7upEZOG rUHVtdxgS8qDFa5RBsgX5l3ESfg3g+xv4vwO5bMfYtCyJjRup7btqs6MwYFPz7x0N7bM+C c67kNTJb+KQMkBQmtWfVw/qnhYSCqew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WmIpR3yrbPb3X5Gx4+u4qy9wb+Kqqj9GOHJDtr4MZvE=; b=apqJojH9pFALDLCvriALM0ZHKqDZslnDeaZwtdCH5wkLRlqrTzz2AaFL75MdvDK8t5jePd Ob606WCNijNsuODg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 99EB7A3B91; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 43D225191DF6; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 07/12] nvme: Implement In-Band authentication Date: Thu, 2 Dec 2021 16:23:53 +0100 Message-Id: <20211202152358.60116-8-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Implement NVMe-oF In-Band authentication according to NVMe TPAR 8006. This patch adds two new fabric options 'dhchap_secret' to specify the pre-shared key (in ASCII respresentation according to NVMe 2.0 section 8.13.5.8 'Secret representation') and 'dhchap_ctrl_secret' to specify the pre-shared controller key for bi-directional authentication of both the host and the controller. Re-authentication can be triggered by writing the PSK into the new controller sysfs attribute 'dhchap_secret' or 'dhchap_ctrl_secret'. Signed-off-by: Hannes Reinecke --- drivers/nvme/host/Kconfig | 11 + drivers/nvme/host/Makefile | 1 + drivers/nvme/host/auth.c | 1169 +++++++++++++++++++++++++++++++++++ drivers/nvme/host/auth.h | 34 + drivers/nvme/host/core.c | 141 ++++- drivers/nvme/host/fabrics.c | 79 ++- drivers/nvme/host/fabrics.h | 7 + drivers/nvme/host/nvme.h | 31 + drivers/nvme/host/rdma.c | 1 + drivers/nvme/host/tcp.c | 1 + drivers/nvme/host/trace.c | 32 + 11 files changed, 1500 insertions(+), 7 deletions(-) create mode 100644 drivers/nvme/host/auth.c create mode 100644 drivers/nvme/host/auth.h diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index dc0450ca23a3..49269c581ec4 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -83,3 +83,14 @@ config NVME_TCP from https://github.com/linux-nvme/nvme-cli. If unsure, say N. + +config NVME_AUTH + bool "NVM Express over Fabrics In-Band Authentication" + depends on NVME_CORE + select CRYPTO_HMAC + select CRYPTO_SHA256 + select CRYPTO_SHA512 + help + This provides support for NVMe over Fabrics In-Band Authentication. + + If unsure, say N. diff --git a/drivers/nvme/host/Makefile b/drivers/nvme/host/Makefile index dfaacd472e5d..4bae2a4a8d8c 100644 --- a/drivers/nvme/host/Makefile +++ b/drivers/nvme/host/Makefile @@ -15,6 +15,7 @@ nvme-core-$(CONFIG_NVME_MULTIPATH) += multipath.o nvme-core-$(CONFIG_BLK_DEV_ZONED) += zns.o nvme-core-$(CONFIG_FAULT_INJECTION_DEBUG_FS) += fault_inject.o nvme-core-$(CONFIG_NVME_HWMON) += hwmon.o +nvme-core-$(CONFIG_NVME_AUTH) += auth.o nvme-y += pci.o diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c new file mode 100644 index 000000000000..774085e4f400 --- /dev/null +++ b/drivers/nvme/host/auth.c @@ -0,0 +1,1169 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2020 Hannes Reinecke, SUSE Linux + */ + +#include +#include +#include +#include +#include +#include +#include +#include "nvme.h" +#include "fabrics.h" +#include "auth.h" + +static u32 nvme_dhchap_seqnum; +static DEFINE_MUTEX(nvme_dhchap_mutex); + +struct nvme_dhchap_queue_context { + struct list_head entry; + struct work_struct auth_work; + struct nvme_ctrl *ctrl; + struct crypto_shash *shash_tfm; + void *buf; + size_t buf_size; + int qid; + int error; + u32 s1; + u32 s2; + u16 transaction; + u8 status; + u8 hash_id; + size_t hash_len; + u8 dhgroup_id; + u8 c1[64]; + u8 c2[64]; + u8 response[64]; + u8 *host_response; +}; + +u32 nvme_auth_get_seqnum(void) +{ + u32 seqnum; + + mutex_lock(&nvme_dhchap_mutex); + if (!nvme_dhchap_seqnum) + nvme_dhchap_seqnum = prandom_u32(); + else { + nvme_dhchap_seqnum++; + if (!nvme_dhchap_seqnum) + nvme_dhchap_seqnum++; + } + seqnum = nvme_dhchap_seqnum; + mutex_unlock(&nvme_dhchap_mutex); + return seqnum; +} +EXPORT_SYMBOL_GPL(nvme_auth_get_seqnum); + +static struct nvme_auth_dhgroup_map { + u8 id; + const char name[16]; + const char kpp[16]; + size_t privkey_size; + size_t pubkey_size; +} dhgroup_map[] = { + { .id = NVME_AUTH_DHGROUP_NULL, + .name = "null", .kpp = "null", + .privkey_size = 0, .pubkey_size = 0 }, + { .id = NVME_AUTH_DHGROUP_2048, + .name = "ffdhe2048", .kpp = "dh", + .privkey_size = 256, .pubkey_size = 256 }, + { .id = NVME_AUTH_DHGROUP_3072, + .name = "ffdhe3072", .kpp = "dh", + .privkey_size = 384, .pubkey_size = 384 }, + { .id = NVME_AUTH_DHGROUP_4096, + .name = "ffdhe4096", .kpp = "dh", + .privkey_size = 512, .pubkey_size = 512 }, + { .id = NVME_AUTH_DHGROUP_6144, + .name = "ffdhe6144", .kpp = "dh", + .privkey_size = 768, .pubkey_size = 768 }, + { .id = NVME_AUTH_DHGROUP_8192, + .name = "ffdhe8192", .kpp = "dh", + .privkey_size = 1024, .pubkey_size = 1024 }, +}; + +const char *nvme_auth_dhgroup_name(u8 dhgroup_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(dhgroup_map); i++) { + if (dhgroup_map[i].id == dhgroup_id) + return dhgroup_map[i].name; + } + return NULL; +} +EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_name); + +size_t nvme_auth_dhgroup_pubkey_size(u8 dhgroup_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(dhgroup_map); i++) { + if (dhgroup_map[i].id == dhgroup_id) + return dhgroup_map[i].pubkey_size; + } + return 0; +} +EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_pubkey_size); + +size_t nvme_auth_dhgroup_privkey_size(u8 dhgroup_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(dhgroup_map); i++) { + if (dhgroup_map[i].id == dhgroup_id) + return dhgroup_map[i].privkey_size; + } + return 0; +} +EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_privkey_size); + +const char *nvme_auth_dhgroup_kpp(u8 dhgroup_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(dhgroup_map); i++) { + if (dhgroup_map[i].id == dhgroup_id) + return dhgroup_map[i].kpp; + } + return NULL; +} +EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_kpp); + +u8 nvme_auth_dhgroup_id(const char *dhgroup_name) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(dhgroup_map); i++) { + if (!strncmp(dhgroup_map[i].name, dhgroup_name, + strlen(dhgroup_map[i].name))) + return dhgroup_map[i].id; + } + return NVME_AUTH_DHGROUP_INVALID; +} +EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_id); + +static struct nvme_dhchap_hash_map { + int id; + int len; + const char hmac[15]; + const char digest[15]; +} hash_map[] = { + {.id = NVME_AUTH_HASH_SHA256, .len = 32, + .hmac = "hmac(sha256)", .digest = "sha256" }, + {.id = NVME_AUTH_HASH_SHA384, .len = 48, + .hmac = "hmac(sha384)", .digest = "sha384" }, + {.id = NVME_AUTH_HASH_SHA512, .len = 64, + .hmac = "hmac(sha512)", .digest = "sha512" }, +}; + +const char *nvme_auth_hmac_name(u8 hmac_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(hash_map); i++) { + if (hash_map[i].id == hmac_id) + return hash_map[i].hmac; + } + return NULL; +} +EXPORT_SYMBOL_GPL(nvme_auth_hmac_name); + +const char *nvme_auth_digest_name(u8 hmac_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(hash_map); i++) { + if (hash_map[i].id == hmac_id) + return hash_map[i].digest; + } + return NULL; +} +EXPORT_SYMBOL_GPL(nvme_auth_digest_name); + +u8 nvme_auth_hmac_id(const char *hmac_name) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(hash_map); i++) { + if (!strncmp(hash_map[i].hmac, hmac_name, + strlen(hash_map[i].hmac))) + return hash_map[i].id; + } + return NVME_AUTH_HASH_INVALID; +} +EXPORT_SYMBOL_GPL(nvme_auth_hmac_id); + +size_t nvme_auth_hmac_hash_len(u8 hmac_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(hash_map); i++) { + if (hash_map[i].id == hmac_id) + return hash_map[i].len; + } + return 0; +} +EXPORT_SYMBOL_GPL(nvme_auth_hmac_hash_len); + +struct nvme_dhchap_key *nvme_auth_extract_key(unsigned char *secret, + u8 key_hash) +{ + struct nvme_dhchap_key *key; + unsigned char *p; + u32 crc; + int ret, key_len; + size_t allocated_len = strlen(secret); + + /* Secret might be affixed with a ':' */ + p = strrchr(secret, ':'); + if (p) + allocated_len = p - secret; + key = kzalloc(sizeof(*key), GFP_KERNEL); + if (!key) + return ERR_PTR(-ENOMEM); + key->key = kzalloc(allocated_len, GFP_KERNEL); + if (!key->key) { + ret = -ENOMEM; + goto out_free_key; + } + + key_len = base64_decode(secret, allocated_len, key->key); + if (key_len < 0) { + pr_debug("base64 key decoding error %d\n", + key_len); + ret = key_len; + goto out_free_secret; + } + + if (key_len != 36 && key_len != 52 && + key_len != 68) { + pr_err("Invalid DH-HMAC-CHAP key len %d\n", + key_len); + ret = -EINVAL; + goto out_free_secret; + } + + if (key_hash > 0 && + (key_len - 4) != nvme_auth_hmac_hash_len(key_hash)) { + pr_err("Invalid DH-HMAC-CHAP key len %d for %s\n", key_len, + nvme_auth_hmac_name(key_hash)); + ret = -EINVAL; + goto out_free_secret; + } + + /* The last four bytes is the CRC in little-endian format */ + key_len -= 4; + /* + * The linux implementation doesn't do pre- and post-increments, + * so we have to do it manually. + */ + crc = ~crc32(~0, key->key, key_len); + + if (get_unaligned_le32(key->key + key_len) != crc) { + pr_err("DH-HMAC-CHAP key crc mismatch (key %08x, crc %08x)\n", + get_unaligned_le32(key->key + key_len), crc); + ret = -EKEYREJECTED; + goto out_free_secret; + } + key->len = key_len; + key->hash = key_hash; + return key; +out_free_secret: + kfree_sensitive(key->key); +out_free_key: + kfree(key); + return ERR_PTR(ret); +} +EXPORT_SYMBOL_GPL(nvme_auth_extract_key); + +void nvme_auth_free_key(struct nvme_dhchap_key *key) +{ + if (!key) + return; + kfree_sensitive(key->key); + kfree(key); +} +EXPORT_SYMBOL_GPL(nvme_auth_free_key); + +u8 *nvme_auth_transform_key(struct nvme_dhchap_key *key, char *nqn) +{ + const char *hmac_name = nvme_auth_hmac_name(key->hash); + struct crypto_shash *key_tfm; + struct shash_desc *shash; + u8 *transformed_key; + int ret; + + if (key->hash == 0) { + transformed_key = kmemdup(key->key, key->len, GFP_KERNEL); + return transformed_key ? transformed_key : ERR_PTR(-ENOMEM); + } + + if (!key || !key->key) { + pr_warn("No key specified\n"); + return ERR_PTR(-ENOKEY); + } + if (!hmac_name) { + pr_warn("Invalid key hash id %d\n", key->hash); + return ERR_PTR(-EINVAL); + } + + key_tfm = crypto_alloc_shash(hmac_name, 0, 0); + if (IS_ERR(key_tfm)) + return (u8 *)key_tfm; + + shash = kmalloc(sizeof(struct shash_desc) + + crypto_shash_descsize(key_tfm), + GFP_KERNEL); + if (!shash) { + ret = -ENOMEM; + goto out_free_key; + } + + transformed_key = kzalloc(crypto_shash_digestsize(key_tfm), GFP_KERNEL); + if (!transformed_key) { + ret = -ENOMEM; + goto out_free_shash; + } + + shash->tfm = key_tfm; + ret = crypto_shash_setkey(key_tfm, key->key, key->len); + if (ret < 0) + goto out_free_shash; + ret = crypto_shash_init(shash); + if (ret < 0) + goto out_free_shash; + ret = crypto_shash_update(shash, nqn, strlen(nqn)); + if (ret < 0) + goto out_free_shash; + ret = crypto_shash_update(shash, "NVMe-over-Fabrics", 17); + if (ret < 0) + goto out_free_shash; + ret = crypto_shash_final(shash, transformed_key); +out_free_shash: + kfree(shash); +out_free_key: + crypto_free_shash(key_tfm); + if (ret < 0) { + kfree_sensitive(transformed_key); + return ERR_PTR(ret); + } + return transformed_key; +} +EXPORT_SYMBOL_GPL(nvme_auth_transform_key); + +#define nvme_auth_flags_from_qid(qid) \ + (qid == NVME_QID_ANY) ? 0 : BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED +#define nvme_auth_queue_from_qid(ctrl, qid) \ + (qid == NVME_QID_ANY) ? (ctrl)->fabrics_q : (ctrl)->connect_q + +static int nvme_auth_send(struct nvme_ctrl *ctrl, int qid, + void *data, size_t tl) +{ + struct nvme_command cmd = {}; + blk_mq_req_flags_t flags = nvme_auth_flags_from_qid(qid); + struct request_queue *q = nvme_auth_queue_from_qid(ctrl, qid); + int ret; + + cmd.auth_send.opcode = nvme_fabrics_command; + cmd.auth_send.fctype = nvme_fabrics_type_auth_send; + cmd.auth_send.secp = NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER; + cmd.auth_send.spsp0 = 0x01; + cmd.auth_send.spsp1 = 0x01; + cmd.auth_send.tl = cpu_to_le32(tl); + + ret = __nvme_submit_sync_cmd(q, &cmd, NULL, data, tl, 0, qid, + 0, flags); + if (ret > 0) + dev_warn(ctrl->device, + "qid %d auth_send failed with status %d\n", qid, ret); + else if (ret < 0) + dev_err(ctrl->device, + "qid %d auth_send failed with error %d\n", qid, ret); + return ret; +} + +static int nvme_auth_receive(struct nvme_ctrl *ctrl, int qid, + void *buf, size_t al) +{ + struct nvme_command cmd = {}; + blk_mq_req_flags_t flags = nvme_auth_flags_from_qid(qid); + struct request_queue *q = nvme_auth_queue_from_qid(ctrl, qid); + int ret; + + cmd.auth_receive.opcode = nvme_fabrics_command; + cmd.auth_receive.fctype = nvme_fabrics_type_auth_receive; + cmd.auth_receive.secp = NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER; + cmd.auth_receive.spsp0 = 0x01; + cmd.auth_receive.spsp1 = 0x01; + cmd.auth_receive.al = cpu_to_le32(al); + + ret = __nvme_submit_sync_cmd(q, &cmd, NULL, buf, al, 0, qid, + 0, flags); + if (ret > 0) { + dev_warn(ctrl->device, + "qid %d auth_recv failed with status %x\n", qid, ret); + ret = -EIO; + } else if (ret < 0) { + dev_err(ctrl->device, + "qid %d auth_recv failed with error %d\n", qid, ret); + } + + return ret; +} + +static int nvme_auth_receive_validate(struct nvme_ctrl *ctrl, int qid, + struct nvmf_auth_dhchap_failure_data *data, + u16 transaction, u8 expected_msg) +{ + dev_dbg(ctrl->device, "%s: qid %d auth_type %d auth_id %x\n", + __func__, qid, data->auth_type, data->auth_id); + + if (data->auth_type == NVME_AUTH_COMMON_MESSAGES && + data->auth_id == NVME_AUTH_DHCHAP_MESSAGE_FAILURE1) { + return data->rescode_exp; + } + if (data->auth_type != NVME_AUTH_DHCHAP_MESSAGES || + data->auth_id != expected_msg) { + dev_warn(ctrl->device, + "qid %d invalid message %02x/%02x\n", + qid, data->auth_type, data->auth_id); + return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_MESSAGE; + } + if (le16_to_cpu(data->t_id) != transaction) { + dev_warn(ctrl->device, + "qid %d invalid transaction ID %d\n", + qid, le16_to_cpu(data->t_id)); + return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_MESSAGE; + } + return 0; +} + +static int nvme_auth_set_dhchap_negotiate_data(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_negotiate_data *data = chap->buf; + size_t size = sizeof(*data) + sizeof(union nvmf_auth_protocol); + + if (chap->buf_size < size) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return -EINVAL; + } + memset((u8 *)chap->buf, 0, size); + data->auth_type = NVME_AUTH_COMMON_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE; + data->t_id = cpu_to_le16(chap->transaction); + data->sc_c = 0; /* No secure channel concatenation */ + data->napd = 1; + data->auth_protocol[0].dhchap.authid = NVME_AUTH_DHCHAP_AUTH_ID; + data->auth_protocol[0].dhchap.halen = 3; + data->auth_protocol[0].dhchap.dhlen = 6; + data->auth_protocol[0].dhchap.idlist[0] = NVME_AUTH_HASH_SHA256; + data->auth_protocol[0].dhchap.idlist[1] = NVME_AUTH_HASH_SHA384; + data->auth_protocol[0].dhchap.idlist[2] = NVME_AUTH_HASH_SHA512; + data->auth_protocol[0].dhchap.idlist[30] = NVME_AUTH_DHGROUP_NULL; + data->auth_protocol[0].dhchap.idlist[31] = NVME_AUTH_DHGROUP_2048; + data->auth_protocol[0].dhchap.idlist[32] = NVME_AUTH_DHGROUP_3072; + data->auth_protocol[0].dhchap.idlist[33] = NVME_AUTH_DHGROUP_4096; + data->auth_protocol[0].dhchap.idlist[34] = NVME_AUTH_DHGROUP_6144; + data->auth_protocol[0].dhchap.idlist[35] = NVME_AUTH_DHGROUP_8192; + + return size; +} + +static int nvme_auth_process_dhchap_challenge(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_challenge_data *data = chap->buf; + u16 dhvlen = le16_to_cpu(data->dhvlen); + size_t size = sizeof(*data) + data->hl + dhvlen; + const char *hmac_name, *kpp_name; + + if (chap->buf_size < size) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return NVME_SC_INVALID_FIELD; + } + + hmac_name = nvme_auth_hmac_name(data->hashid); + if (!hmac_name) { + dev_warn(ctrl->device, + "qid %d: invalid HASH ID %d\n", + chap->qid, data->hashid); + chap->status = NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + return NVME_SC_INVALID_FIELD; + } + + if (chap->hash_id == data->hashid && chap->shash_tfm && + !strcmp(crypto_shash_alg_name(chap->shash_tfm), hmac_name) && + crypto_shash_digestsize(chap->shash_tfm) == data->hl) { + dev_dbg(ctrl->device, + "qid %d: reuse existing hash %s\n", + chap->qid, hmac_name); + goto select_kpp; + } + + /* Reset if hash cannot be reused */ + if (chap->shash_tfm) { + crypto_free_shash(chap->shash_tfm); + chap->hash_id = 0; + chap->hash_len = 0; + } + chap->shash_tfm = crypto_alloc_shash(hmac_name, 0, + CRYPTO_ALG_ALLOCATES_MEMORY); + if (IS_ERR(chap->shash_tfm)) { + dev_warn(ctrl->device, + "qid %d: failed to allocate hash %s, error %ld\n", + chap->qid, hmac_name, PTR_ERR(chap->shash_tfm)); + chap->shash_tfm = NULL; + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + return NVME_SC_AUTH_REQUIRED; + } + + if (crypto_shash_digestsize(chap->shash_tfm) != data->hl) { + dev_warn(ctrl->device, + "qid %d: invalid hash length %d\n", + chap->qid, data->hl); + crypto_free_shash(chap->shash_tfm); + chap->shash_tfm = NULL; + chap->status = NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + return NVME_SC_AUTH_REQUIRED; + } + + /* Reset host response if the hash had been changed */ + if (chap->hash_id != data->hashid) { + kfree(chap->host_response); + chap->host_response = NULL; + } + + chap->hash_id = data->hashid; + chap->hash_len = data->hl; + dev_dbg(ctrl->device, "qid %d: selected hash %s\n", + chap->qid, hmac_name); + +select_kpp: + kpp_name = nvme_auth_dhgroup_kpp(data->dhgid); + if (!kpp_name) { + dev_warn(ctrl->device, + "qid %d: invalid DH group id %d\n", + chap->qid, data->dhgid); + chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + return NVME_SC_AUTH_REQUIRED; + } + + if (data->dhgid != NVME_AUTH_DHGROUP_NULL) { + dev_warn(ctrl->device, + "qid %d: unsupported DH group %s\n", + chap->qid, kpp_name); + chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + return NVME_SC_AUTH_REQUIRED; + } else if (dhvlen != 0) { + dev_warn(ctrl->device, + "qid %d: invalid DH value for NULL DH\n", + chap->qid); + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return NVME_SC_INVALID_FIELD; + } + chap->dhgroup_id = data->dhgid; + + chap->s1 = le32_to_cpu(data->seqnum); + memcpy(chap->c1, data->cval, chap->hash_len); + + return 0; +} + +static int nvme_auth_set_dhchap_reply_data(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_reply_data *data = chap->buf; + size_t size = sizeof(*data); + + size += 2 * chap->hash_len; + + if (chap->buf_size < size) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return -EINVAL; + } + + memset(chap->buf, 0, size); + data->auth_type = NVME_AUTH_DHCHAP_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_REPLY; + data->t_id = cpu_to_le16(chap->transaction); + data->hl = chap->hash_len; + data->dhvlen = 0; + memcpy(data->rval, chap->response, chap->hash_len); + if (ctrl->opts->dhchap_ctrl_secret) { + get_random_bytes(chap->c2, chap->hash_len); + data->cvalid = 1; + chap->s2 = nvme_auth_get_seqnum(); + memcpy(data->rval + chap->hash_len, chap->c2, + chap->hash_len); + dev_dbg(ctrl->device, "%s: qid %d ctrl challenge %*ph\n", + __func__, chap->qid, (int)chap->hash_len, chap->c2); + } else { + memset(chap->c2, 0, chap->hash_len); + chap->s2 = 0; + } + data->seqnum = cpu_to_le32(chap->s2); + return size; +} + +static int nvme_auth_process_dhchap_success1(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_success1_data *data = chap->buf; + size_t size = sizeof(*data); + + if (ctrl->opts->dhchap_ctrl_secret) + size += chap->hash_len; + + if (chap->buf_size < size) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return NVME_SC_INVALID_FIELD; + } + + if (data->hl != chap->hash_len) { + dev_warn(ctrl->device, + "qid %d: invalid hash length %u\n", + chap->qid, data->hl); + chap->status = NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + return NVME_SC_INVALID_FIELD; + } + + /* Just print out information for the admin queue */ + if (chap->qid == -1) + dev_info(ctrl->device, + "qid 0: authenticated with hash %s dhgroup %s\n", + nvme_auth_hmac_name(chap->hash_id), + nvme_auth_dhgroup_name(chap->dhgroup_id)); + + if (!data->rvalid) + return 0; + + /* Validate controller response */ + if (memcmp(chap->response, data->rval, data->hl)) { + dev_dbg(ctrl->device, "%s: qid %d ctrl response %*ph\n", + __func__, chap->qid, (int)chap->hash_len, data->rval); + dev_dbg(ctrl->device, "%s: qid %d host response %*ph\n", + __func__, chap->qid, (int)chap->hash_len, + chap->response); + dev_warn(ctrl->device, + "qid %d: controller authentication failed\n", + chap->qid); + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + return NVME_SC_AUTH_REQUIRED; + } + + /* Just print out information for the admin queue */ + if (chap->qid == -1) + dev_info(ctrl->device, + "qid 0: controller authenticated\n"); + return 0; +} + +static int nvme_auth_set_dhchap_success2_data(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_success2_data *data = chap->buf; + size_t size = sizeof(*data); + + memset(chap->buf, 0, size); + data->auth_type = NVME_AUTH_DHCHAP_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2; + data->t_id = cpu_to_le16(chap->transaction); + + return size; +} + +static int nvme_auth_set_dhchap_failure2_data(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + struct nvmf_auth_dhchap_failure_data *data = chap->buf; + size_t size = sizeof(*data); + + memset(chap->buf, 0, size); + data->auth_type = NVME_AUTH_DHCHAP_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_FAILURE2; + data->t_id = cpu_to_le16(chap->transaction); + data->rescode = NVME_AUTH_DHCHAP_FAILURE_REASON_FAILED; + data->rescode_exp = chap->status; + + return size; +} + +static int nvme_auth_dhchap_setup_host_response(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + SHASH_DESC_ON_STACK(shash, chap->shash_tfm); + u8 buf[4], *challenge = chap->c1; + int ret; + + dev_dbg(ctrl->device, "%s: qid %d host response seq %u transaction %d\n", + __func__, chap->qid, chap->s1, chap->transaction); + + if (!chap->host_response) { + chap->host_response = nvme_auth_transform_key(ctrl->host_key, + ctrl->opts->host->nqn); + if (IS_ERR(chap->host_response)) { + ret = PTR_ERR(chap->host_response); + chap->host_response = NULL; + return ret; + } + } else { + dev_dbg(ctrl->device, "%s: qid %d re-using host response\n", + __func__, chap->qid); + } + + ret = crypto_shash_setkey(chap->shash_tfm, + chap->host_response, ctrl->host_key->len); + if (ret) { + dev_warn(ctrl->device, "qid %d: failed to set key, error %d\n", + chap->qid, ret); + goto out; + } + + shash->tfm = chap->shash_tfm; + ret = crypto_shash_init(shash); + if (ret) + goto out; + ret = crypto_shash_update(shash, challenge, chap->hash_len); + if (ret) + goto out; + put_unaligned_le32(chap->s1, buf); + ret = crypto_shash_update(shash, buf, 4); + if (ret) + goto out; + put_unaligned_le16(chap->transaction, buf); + ret = crypto_shash_update(shash, buf, 2); + if (ret) + goto out; + memset(buf, 0, sizeof(buf)); + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, "HostHost", 8); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->opts->host->nqn, + strlen(ctrl->opts->host->nqn)); + if (ret) + goto out; + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->opts->subsysnqn, + strlen(ctrl->opts->subsysnqn)); + if (ret) + goto out; + ret = crypto_shash_final(shash, chap->response); +out: + if (challenge != chap->c1) + kfree(challenge); + return ret; +} + +static int nvme_auth_dhchap_setup_ctrl_response(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + SHASH_DESC_ON_STACK(shash, chap->shash_tfm); + u8 *ctrl_response; + u8 buf[4], *challenge = chap->c2; + int ret; + + ctrl_response = nvme_auth_transform_key(ctrl->ctrl_key, + ctrl->opts->subsysnqn); + if (IS_ERR(ctrl_response)) { + ret = PTR_ERR(ctrl_response); + return ret; + } + ret = crypto_shash_setkey(chap->shash_tfm, + ctrl_response, ctrl->ctrl_key->len); + if (ret) { + dev_warn(ctrl->device, "qid %d: failed to set key, error %d\n", + chap->qid, ret); + goto out; + } + + dev_dbg(ctrl->device, "%s: qid %d ctrl response seq %u transaction %d\n", + __func__, chap->qid, chap->s2, chap->transaction); + dev_dbg(ctrl->device, "%s: qid %d challenge %*ph\n", + __func__, chap->qid, (int)chap->hash_len, challenge); + dev_dbg(ctrl->device, "%s: qid %d subsysnqn %s\n", + __func__, chap->qid, ctrl->opts->subsysnqn); + dev_dbg(ctrl->device, "%s: qid %d hostnqn %s\n", + __func__, chap->qid, ctrl->opts->host->nqn); + shash->tfm = chap->shash_tfm; + ret = crypto_shash_init(shash); + if (ret) + goto out; + ret = crypto_shash_update(shash, challenge, chap->hash_len); + if (ret) + goto out; + put_unaligned_le32(chap->s2, buf); + ret = crypto_shash_update(shash, buf, 4); + if (ret) + goto out; + put_unaligned_le16(chap->transaction, buf); + ret = crypto_shash_update(shash, buf, 2); + if (ret) + goto out; + memset(buf, 0, 4); + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, "Controller", 10); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->opts->subsysnqn, + strlen(ctrl->opts->subsysnqn)); + if (ret) + goto out; + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->opts->host->nqn, + strlen(ctrl->opts->host->nqn)); + if (ret) + goto out; + ret = crypto_shash_final(shash, chap->response); +out: + if (challenge != chap->c2) + kfree(challenge); + return ret; +} + +int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key) +{ + struct nvme_dhchap_key *key; + u8 key_hash; + + if (!secret) { + *ret_key = NULL; + return 0; + } + + if (sscanf(secret, "DHHC-1:%hhd:%*s:", &key_hash) != 1) + return -EINVAL; + + /* Pass in the secret without the 'DHHC-1:XX:' prefix */ + key = nvme_auth_extract_key(secret + 10, key_hash); + if (IS_ERR(key)) { + return PTR_ERR(key); + } + + *ret_key = key; + return 0; +} +EXPORT_SYMBOL_GPL(nvme_auth_generate_key); + +static void __nvme_auth_reset(struct nvme_dhchap_queue_context *chap) +{ + chap->status = 0; + chap->error = 0; + chap->s1 = 0; + chap->s2 = 0; + chap->transaction = 0; + memset(chap->c1, 0, sizeof(chap->c1)); + memset(chap->c2, 0, sizeof(chap->c2)); +} + +static void __nvme_auth_free(struct nvme_dhchap_queue_context *chap) +{ + if (chap->shash_tfm) + crypto_free_shash(chap->shash_tfm); + kfree_sensitive(chap->host_response); + kfree(chap->buf); + kfree(chap); +} + +static void __nvme_auth_work(struct work_struct *work) +{ + struct nvme_dhchap_queue_context *chap = + container_of(work, struct nvme_dhchap_queue_context, auth_work); + struct nvme_ctrl *ctrl = chap->ctrl; + size_t tl; + int ret = 0; + + chap->transaction = ctrl->transaction++; + + /* DH-HMAC-CHAP Step 1: send negotiate */ + dev_dbg(ctrl->device, "%s: qid %d send negotiate\n", + __func__, chap->qid); + ret = nvme_auth_set_dhchap_negotiate_data(ctrl, chap); + if (ret < 0) { + chap->error = ret; + return; + } + tl = ret; + ret = nvme_auth_send(ctrl, chap->qid, chap->buf, tl); + if (ret) { + chap->error = ret; + return; + } + + /* DH-HMAC-CHAP Step 2: receive challenge */ + dev_dbg(ctrl->device, "%s: qid %d receive challenge\n", + __func__, chap->qid); + + memset(chap->buf, 0, chap->buf_size); + ret = nvme_auth_receive(ctrl, chap->qid, chap->buf, chap->buf_size); + if (ret) { + dev_warn(ctrl->device, + "qid %d failed to receive challenge, %s %d\n", + chap->qid, ret < 0 ? "error" : "nvme status", ret); + chap->error = ret; + return; + } + ret = nvme_auth_receive_validate(ctrl, chap->qid, chap->buf, chap->transaction, + NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE); + if (ret) { + chap->status = ret; + chap->error = NVME_SC_AUTH_REQUIRED; + return; + } + + ret = nvme_auth_process_dhchap_challenge(ctrl, chap); + if (ret) { + /* Invalid challenge parameters */ + goto fail2; + } + + dev_dbg(ctrl->device, "%s: qid %d host response\n", + __func__, chap->qid); + ret = nvme_auth_dhchap_setup_host_response(ctrl, chap); + if (ret) + goto fail2; + + /* DH-HMAC-CHAP Step 3: send reply */ + dev_dbg(ctrl->device, "%s: qid %d send reply\n", + __func__, chap->qid); + ret = nvme_auth_set_dhchap_reply_data(ctrl, chap); + if (ret < 0) + goto fail2; + + tl = ret; + ret = nvme_auth_send(ctrl, chap->qid, chap->buf, tl); + if (ret) + goto fail2; + + /* DH-HMAC-CHAP Step 4: receive success1 */ + dev_dbg(ctrl->device, "%s: qid %d receive success1\n", + __func__, chap->qid); + + memset(chap->buf, 0, chap->buf_size); + ret = nvme_auth_receive(ctrl, chap->qid, chap->buf, chap->buf_size); + if (ret) { + dev_warn(ctrl->device, + "qid %d failed to receive success1, %s %d\n", + chap->qid, ret < 0 ? "error" : "nvme status", ret); + chap->error = ret; + return; + } + ret = nvme_auth_receive_validate(ctrl, chap->qid, + chap->buf, chap->transaction, + NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1); + if (ret) { + chap->status = ret; + chap->error = NVME_SC_AUTH_REQUIRED; + return; + } + + if (ctrl->opts->dhchap_ctrl_secret) { + dev_dbg(ctrl->device, + "%s: qid %d controller response\n", + __func__, chap->qid); + ret = nvme_auth_dhchap_setup_ctrl_response(ctrl, chap); + if (ret) + goto fail2; + } + + ret = nvme_auth_process_dhchap_success1(ctrl, chap); + if (ret) { + /* Controller authentication failed */ + goto fail2; + } + + /* DH-HMAC-CHAP Step 5: send success2 */ + dev_dbg(ctrl->device, "%s: qid %d send success2\n", + __func__, chap->qid); + tl = nvme_auth_set_dhchap_success2_data(ctrl, chap); + ret = nvme_auth_send(ctrl, chap->qid, chap->buf, tl); + if (!ret) { + chap->error = 0; + return; + } + +fail2: + dev_dbg(ctrl->device, "%s: qid %d send failure2, status %x\n", + __func__, chap->qid, chap->status); + tl = nvme_auth_set_dhchap_failure2_data(ctrl, chap); + ret = nvme_auth_send(ctrl, chap->qid, chap->buf, tl); + if (!ret) + ret = -EPROTO; + chap->error = ret; +} + +int nvme_auth_negotiate(struct nvme_ctrl *ctrl, int qid) +{ + struct nvme_dhchap_queue_context *chap; + + if (!ctrl->host_key) { + dev_warn(ctrl->device, "qid %d: no key\n", qid); + return -ENOKEY; + } + + mutex_lock(&ctrl->dhchap_auth_mutex); + /* Check if the context is already queued */ + list_for_each_entry(chap, &ctrl->dhchap_auth_list, entry) { + WARN_ON(!chap->buf); + if (chap->qid == qid) { + dev_dbg(ctrl->device, "qid %d: re-using context\n", qid); + mutex_unlock(&ctrl->dhchap_auth_mutex); + flush_work(&chap->auth_work); + __nvme_auth_reset(chap); + queue_work(nvme_wq, &chap->auth_work); + return 0; + } + } + chap = kzalloc(sizeof(*chap), GFP_KERNEL); + if (!chap) { + mutex_unlock(&ctrl->dhchap_auth_mutex); + return -ENOMEM; + } + chap->qid = qid; + chap->ctrl = ctrl; + + /* + * Allocate a large enough buffer for the entire negotiation: + * 4k should be enough to ffdhe8192. + */ + chap->buf_size = 4096; + chap->buf = kzalloc(chap->buf_size, GFP_KERNEL); + if (!chap->buf) { + mutex_unlock(&ctrl->dhchap_auth_mutex); + kfree(chap); + return -ENOMEM; + } + + INIT_WORK(&chap->auth_work, __nvme_auth_work); + list_add(&chap->entry, &ctrl->dhchap_auth_list); + mutex_unlock(&ctrl->dhchap_auth_mutex); + queue_work(nvme_wq, &chap->auth_work); + return 0; +} +EXPORT_SYMBOL_GPL(nvme_auth_negotiate); + +int nvme_auth_wait(struct nvme_ctrl *ctrl, int qid) +{ + struct nvme_dhchap_queue_context *chap; + int ret; + + mutex_lock(&ctrl->dhchap_auth_mutex); + list_for_each_entry(chap, &ctrl->dhchap_auth_list, entry) { + if (chap->qid != qid) + continue; + mutex_unlock(&ctrl->dhchap_auth_mutex); + flush_work(&chap->auth_work); + ret = chap->error; + __nvme_auth_reset(chap); + return ret; + } + mutex_unlock(&ctrl->dhchap_auth_mutex); + return -ENXIO; +} +EXPORT_SYMBOL_GPL(nvme_auth_wait); + +void nvme_auth_reset(struct nvme_ctrl *ctrl) +{ + struct nvme_dhchap_queue_context *chap; + + mutex_lock(&ctrl->dhchap_auth_mutex); + list_for_each_entry(chap, &ctrl->dhchap_auth_list, entry) { + mutex_unlock(&ctrl->dhchap_auth_mutex); + flush_work(&chap->auth_work); + __nvme_auth_reset(chap); + } + mutex_unlock(&ctrl->dhchap_auth_mutex); +} +EXPORT_SYMBOL_GPL(nvme_auth_reset); + +static void nvme_dhchap_auth_work(struct work_struct *work) +{ + struct nvme_ctrl *ctrl = + container_of(work, struct nvme_ctrl, dhchap_auth_work); + int ret, q; + + /* Authenticate admin queue first */ + ret = nvme_auth_negotiate(ctrl, NVME_QID_ANY); + if (ret) { + dev_warn(ctrl->device, + "qid 0: error %d setting up authentication\n", ret); + return; + } + ret = nvme_auth_wait(ctrl, NVME_QID_ANY); + if (ret) { + dev_warn(ctrl->device, + "qid 0: authentication failed\n"); + return; + } + + for (q = 1; q < ctrl->queue_count; q++) { + ret = nvme_auth_negotiate(ctrl, q); + if (ret) { + dev_warn(ctrl->device, + "qid %d: error %d setting up authentication\n", + q, ret); + break; + } + } + + /* + * Failure is a soft-state; credentials remain valid until + * the controller terminates the connection. + */ +} + +void nvme_auth_init_ctrl(struct nvme_ctrl *ctrl) +{ + INIT_LIST_HEAD(&ctrl->dhchap_auth_list); + INIT_WORK(&ctrl->dhchap_auth_work, nvme_dhchap_auth_work); + mutex_init(&ctrl->dhchap_auth_mutex); + nvme_auth_generate_key(ctrl->opts->dhchap_secret, &ctrl->host_key); + nvme_auth_generate_key(ctrl->opts->dhchap_ctrl_secret, &ctrl->ctrl_key); +} +EXPORT_SYMBOL_GPL(nvme_auth_init_ctrl); + +void nvme_auth_stop(struct nvme_ctrl *ctrl) +{ + struct nvme_dhchap_queue_context *chap = NULL, *tmp; + + cancel_work_sync(&ctrl->dhchap_auth_work); + mutex_lock(&ctrl->dhchap_auth_mutex); + list_for_each_entry_safe(chap, tmp, &ctrl->dhchap_auth_list, entry) + cancel_work_sync(&chap->auth_work); + mutex_unlock(&ctrl->dhchap_auth_mutex); +} +EXPORT_SYMBOL_GPL(nvme_auth_stop); + +void nvme_auth_free(struct nvme_ctrl *ctrl) +{ + struct nvme_dhchap_queue_context *chap = NULL, *tmp; + + mutex_lock(&ctrl->dhchap_auth_mutex); + list_for_each_entry_safe(chap, tmp, &ctrl->dhchap_auth_list, entry) { + list_del_init(&chap->entry); + flush_work(&chap->auth_work); + __nvme_auth_free(chap); + } + mutex_unlock(&ctrl->dhchap_auth_mutex); + if (ctrl->host_key) { + nvme_auth_free_key(ctrl->host_key); + ctrl->host_key = NULL; + } + if (ctrl->ctrl_key) { + nvme_auth_free_key(ctrl->ctrl_key); + ctrl->ctrl_key = NULL; + } +} +EXPORT_SYMBOL_GPL(nvme_auth_free); diff --git a/drivers/nvme/host/auth.h b/drivers/nvme/host/auth.h new file mode 100644 index 000000000000..2f39d17296d1 --- /dev/null +++ b/drivers/nvme/host/auth.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2021 Hannes Reinecke, SUSE Software Solutions + */ + +#ifndef _NVME_AUTH_H +#define _NVME_AUTH_H + +#include + +struct nvme_dhchap_key { + u8 *key; + size_t len; + u8 hash; +}; + +u32 nvme_auth_get_seqnum(void); +const char *nvme_auth_dhgroup_name(u8 dhgroup_id); +size_t nvme_auth_dhgroup_pubkey_size(u8 dhgroup_id); +size_t nvme_auth_dhgroup_privkey_size(u8 dhgroup_id); +const char *nvme_auth_dhgroup_kpp(u8 dhgroup_id); +u8 nvme_auth_dhgroup_id(const char *dhgroup_name); + +const char *nvme_auth_hmac_name(u8 hmac_id); +const char *nvme_auth_digest_name(u8 hmac_id); +size_t nvme_auth_hmac_hash_len(u8 hmac_id); +u8 nvme_auth_hmac_id(const char *hmac_name); + +struct nvme_dhchap_key *nvme_auth_extract_key(unsigned char *secret, + u8 key_hash); +void nvme_auth_free_key(struct nvme_dhchap_key *key); +u8 *nvme_auth_transform_key(struct nvme_dhchap_key *key, char *nqn); + +#endif /* _NVME_AUTH_H */ diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 4b5de8f5435a..db9c8bc1cf50 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -24,6 +24,7 @@ #include "nvme.h" #include "fabrics.h" +#include "auth.h" #define CREATE_TRACE_POINTS #include "trace.h" @@ -303,6 +304,7 @@ enum nvme_disposition { COMPLETE, RETRY, FAILOVER, + AUTHENTICATE, }; static inline enum nvme_disposition nvme_decide_disposition(struct request *req) @@ -310,6 +312,9 @@ static inline enum nvme_disposition nvme_decide_disposition(struct request *req) if (likely(nvme_req(req)->status == 0)) return COMPLETE; + if ((nvme_req(req)->status & 0x7ff) == NVME_SC_AUTH_REQUIRED) + return AUTHENTICATE; + if (blk_noretry_request(req) || (nvme_req(req)->status & NVME_SC_DNR) || nvme_req(req)->retries >= nvme_max_retries) @@ -346,11 +351,13 @@ static inline void nvme_end_req(struct request *req) void nvme_complete_rq(struct request *req) { + struct nvme_ctrl *ctrl = nvme_req(req)->ctrl; + trace_nvme_complete_rq(req); nvme_cleanup_cmd(req); - if (nvme_req(req)->ctrl->kas) - nvme_req(req)->ctrl->comp_seen = true; + if (ctrl->kas) + ctrl->comp_seen = true; switch (nvme_decide_disposition(req)) { case COMPLETE: @@ -362,6 +369,14 @@ void nvme_complete_rq(struct request *req) case FAILOVER: nvme_failover_req(req); return; + case AUTHENTICATE: +#ifdef CONFIG_NVME_AUTH + queue_work(nvme_wq, &ctrl->dhchap_auth_work); + nvme_retry_req(req); +#else + nvme_end_req(req); +#endif + return; } } EXPORT_SYMBOL_GPL(nvme_complete_rq); @@ -699,7 +714,9 @@ bool __nvme_check_ready(struct nvme_ctrl *ctrl, struct request *rq, switch (ctrl->state) { case NVME_CTRL_CONNECTING: if (blk_rq_is_passthrough(rq) && nvme_is_fabrics(req->cmd) && - req->cmd->fabrics.fctype == nvme_fabrics_type_connect) + (req->cmd->fabrics.fctype == nvme_fabrics_type_connect || + req->cmd->fabrics.fctype == nvme_fabrics_type_auth_send || + req->cmd->fabrics.fctype == nvme_fabrics_type_auth_receive)) return true; break; default: @@ -3494,6 +3511,108 @@ static ssize_t nvme_ctrl_fast_io_fail_tmo_store(struct device *dev, static DEVICE_ATTR(fast_io_fail_tmo, S_IRUGO | S_IWUSR, nvme_ctrl_fast_io_fail_tmo_show, nvme_ctrl_fast_io_fail_tmo_store); +#ifdef CONFIG_NVME_AUTH +static ssize_t nvme_ctrl_dhchap_secret_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct nvme_ctrl *ctrl = dev_get_drvdata(dev); + struct nvmf_ctrl_options *opts = ctrl->opts; + + if (!opts->dhchap_secret) + return sysfs_emit(buf, "none\n"); + return sysfs_emit(buf, "%s\n", opts->dhchap_secret); +} + +static ssize_t nvme_ctrl_dhchap_secret_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) +{ + struct nvme_ctrl *ctrl = dev_get_drvdata(dev); + struct nvmf_ctrl_options *opts = ctrl->opts; + char *dhchap_secret; + + if (!ctrl->opts->dhchap_secret) + return -EINVAL; + if (count < 7) + return -EINVAL; + if (memcmp(buf, "DHHC-1:", 7)) + return -EINVAL; + + dhchap_secret = kzalloc(count + 1, GFP_KERNEL); + if (!dhchap_secret) + return -ENOMEM; + memcpy(dhchap_secret, buf, count); + nvme_auth_stop(ctrl); + if (strcmp(dhchap_secret, opts->dhchap_secret)) { + int ret; + + ret = nvme_auth_generate_key(dhchap_secret, &ctrl->host_key); + if (ret) + return ret; + kfree(opts->dhchap_secret); + opts->dhchap_secret = dhchap_secret; + /* Key has changed; re-authentication with new key */ + nvme_auth_reset(ctrl); + } + /* Start re-authentication */ + dev_info(ctrl->device, "re-authenticating controller\n"); + queue_work(nvme_wq, &ctrl->dhchap_auth_work); + + return count; +} +DEVICE_ATTR(dhchap_secret, S_IRUGO | S_IWUSR, + nvme_ctrl_dhchap_secret_show, nvme_ctrl_dhchap_secret_store); + +static ssize_t nvme_ctrl_dhchap_ctrl_secret_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct nvme_ctrl *ctrl = dev_get_drvdata(dev); + struct nvmf_ctrl_options *opts = ctrl->opts; + + if (!opts->dhchap_ctrl_secret) + return sysfs_emit(buf, "none\n"); + return sysfs_emit(buf, "%s\n", opts->dhchap_ctrl_secret); +} + +static ssize_t nvme_ctrl_dhchap_ctrl_secret_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) +{ + struct nvme_ctrl *ctrl = dev_get_drvdata(dev); + struct nvmf_ctrl_options *opts = ctrl->opts; + char *dhchap_secret; + + if (!ctrl->opts->dhchap_ctrl_secret) + return -EINVAL; + if (count < 7) + return -EINVAL; + if (memcmp(buf, "DHHC-1:", 7)) + return -EINVAL; + + dhchap_secret = kzalloc(count + 1, GFP_KERNEL); + if (!dhchap_secret) + return -ENOMEM; + memcpy(dhchap_secret, buf, count); + nvme_auth_stop(ctrl); + if (strcmp(dhchap_secret, opts->dhchap_ctrl_secret)) { + int ret; + + ret = nvme_auth_generate_key(dhchap_secret, &ctrl->ctrl_key); + if (ret) + return ret; + kfree(opts->dhchap_ctrl_secret); + opts->dhchap_ctrl_secret = dhchap_secret; + /* Key has changed; re-authentication with new key */ + nvme_auth_reset(ctrl); + } + /* Start re-authentication */ + dev_info(ctrl->device, "re-authenticating controller\n"); + queue_work(nvme_wq, &ctrl->dhchap_auth_work); + + return count; +} +DEVICE_ATTR(dhchap_ctrl_secret, S_IRUGO | S_IWUSR, + nvme_ctrl_dhchap_ctrl_secret_show, nvme_ctrl_dhchap_ctrl_secret_store); +#endif + static struct attribute *nvme_dev_attrs[] = { &dev_attr_reset_controller.attr, &dev_attr_rescan_controller.attr, @@ -3515,6 +3634,10 @@ static struct attribute *nvme_dev_attrs[] = { &dev_attr_reconnect_delay.attr, &dev_attr_fast_io_fail_tmo.attr, &dev_attr_kato.attr, +#ifdef CONFIG_NVME_AUTH + &dev_attr_dhchap_secret.attr, + &dev_attr_dhchap_ctrl_secret.attr, +#endif NULL }; @@ -3538,6 +3661,10 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj, return 0; if (a == &dev_attr_fast_io_fail_tmo.attr && !ctrl->opts) return 0; +#ifdef CONFIG_NVME_AUTH + if (a == &dev_attr_dhchap_secret.attr && !ctrl->opts) + return 0; +#endif return a->mode; } @@ -4302,8 +4429,10 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result) * recovery actions from interfering with the controller's * firmware activation. */ - if (nvme_change_ctrl_state(ctrl, NVME_CTRL_RESETTING)) + if (nvme_change_ctrl_state(ctrl, NVME_CTRL_RESETTING)) { + nvme_auth_stop(ctrl); queue_work(nvme_wq, &ctrl->fw_act_work); + } break; #ifdef CONFIG_NVME_MULTIPATH case NVME_AER_NOTICE_ANA: @@ -4350,6 +4479,7 @@ EXPORT_SYMBOL_GPL(nvme_complete_async_event); void nvme_stop_ctrl(struct nvme_ctrl *ctrl) { nvme_mpath_stop(ctrl); + nvme_auth_stop(ctrl); nvme_stop_keep_alive(ctrl); nvme_stop_failfast_work(ctrl); flush_work(&ctrl->async_event_work); @@ -4404,6 +4534,8 @@ static void nvme_free_ctrl(struct device *dev) nvme_free_cels(ctrl); nvme_mpath_uninit(ctrl); + nvme_auth_stop(ctrl); + nvme_auth_free(ctrl); __free_page(ctrl->discard_page); if (subsys) { @@ -4494,6 +4626,7 @@ int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev, nvme_fault_inject_init(&ctrl->fault_inject, dev_name(ctrl->device)); nvme_mpath_init_ctrl(ctrl); + nvme_auth_init_ctrl(ctrl); return 0; out_free_name: diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index a1343a0790f6..0ac054f80a82 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -370,6 +370,7 @@ int nvmf_connect_admin_queue(struct nvme_ctrl *ctrl) union nvme_result res; struct nvmf_connect_data *data; int ret; + u32 result; cmd.connect.opcode = nvme_fabrics_command; cmd.connect.fctype = nvme_fabrics_type_connect; @@ -402,8 +403,25 @@ int nvmf_connect_admin_queue(struct nvme_ctrl *ctrl) goto out_free_data; } - ctrl->cntlid = le16_to_cpu(res.u16); - + result = le32_to_cpu(res.u32); + ctrl->cntlid = result & 0xFFFF; + if ((result >> 16) & 2) { + /* Authentication required */ + ret = nvme_auth_negotiate(ctrl, NVME_QID_ANY); + if (ret) { + dev_warn(ctrl->device, + "qid 0: authentication setup failed\n"); + ret = NVME_SC_AUTH_REQUIRED; + goto out_free_data; + } + ret = nvme_auth_wait(ctrl, NVME_QID_ANY); + if (ret) + dev_warn(ctrl->device, + "qid 0: authentication failed\n"); + else + dev_info(ctrl->device, + "qid 0: authenticated\n"); + } out_free_data: kfree(data); return ret; @@ -436,6 +454,7 @@ int nvmf_connect_io_queue(struct nvme_ctrl *ctrl, u16 qid) struct nvmf_connect_data *data; union nvme_result res; int ret; + u32 result; cmd.connect.opcode = nvme_fabrics_command; cmd.connect.fctype = nvme_fabrics_type_connect; @@ -461,6 +480,21 @@ int nvmf_connect_io_queue(struct nvme_ctrl *ctrl, u16 qid) nvmf_log_connect_error(ctrl, ret, le32_to_cpu(res.u32), &cmd, data); } + result = le32_to_cpu(res.u32); + if ((result >> 16) & 2) { + /* Authentication required */ + ret = nvme_auth_negotiate(ctrl, qid); + if (ret) { + dev_warn(ctrl->device, + "qid %d: authentication setup failed\n", qid); + ret = NVME_SC_AUTH_REQUIRED; + } else { + ret = nvme_auth_wait(ctrl, qid); + if (ret) + dev_warn(ctrl->device, + "qid %u: authentication failed\n", qid); + } + } kfree(data); return ret; } @@ -553,6 +587,8 @@ static const match_table_t opt_tokens = { { NVMF_OPT_TOS, "tos=%d" }, { NVMF_OPT_FAIL_FAST_TMO, "fast_io_fail_tmo=%d" }, { NVMF_OPT_DISCOVERY, "discovery" }, + { NVMF_OPT_DHCHAP_SECRET, "dhchap_secret=%s" }, + { NVMF_OPT_DHCHAP_CTRL_SECRET, "dhchap_ctrl_secret=%s" }, { NVMF_OPT_ERR, NULL } }; @@ -831,6 +867,34 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts, case NVMF_OPT_DISCOVERY: opts->discovery_nqn = true; break; + case NVMF_OPT_DHCHAP_SECRET: + p = match_strdup(args); + if (!p) { + ret = -ENOMEM; + goto out; + } + if (strlen(p) < 11 || strncmp(p, "DHHC-1:", 7)) { + pr_err("Invalid DH-CHAP secret %s\n", p); + ret = -EINVAL; + goto out; + } + kfree(opts->dhchap_secret); + opts->dhchap_secret = p; + break; + case NVMF_OPT_DHCHAP_CTRL_SECRET: + p = match_strdup(args); + if (!p) { + ret = -ENOMEM; + goto out; + } + if (strlen(p) < 11 || strncmp(p, "DHHC-1:", 7)) { + pr_err("Invalid DH-CHAP secret %s\n", p); + ret = -EINVAL; + goto out; + } + kfree(opts->dhchap_ctrl_secret); + opts->dhchap_ctrl_secret = p; + break; default: pr_warn("unknown parameter or missing value '%s' in ctrl creation request\n", p); @@ -949,6 +1013,7 @@ void nvmf_free_options(struct nvmf_ctrl_options *opts) kfree(opts->subsysnqn); kfree(opts->host_traddr); kfree(opts->host_iface); + kfree(opts->dhchap_secret); kfree(opts); } EXPORT_SYMBOL_GPL(nvmf_free_options); @@ -958,7 +1023,8 @@ EXPORT_SYMBOL_GPL(nvmf_free_options); NVMF_OPT_KATO | NVMF_OPT_HOSTNQN | \ NVMF_OPT_HOST_ID | NVMF_OPT_DUP_CONNECT |\ NVMF_OPT_DISABLE_SQFLOW | NVMF_OPT_DISCOVERY |\ - NVMF_OPT_FAIL_FAST_TMO) + NVMF_OPT_FAIL_FAST_TMO | NVMF_OPT_DHCHAP_SECRET |\ + NVMF_OPT_DHCHAP_CTRL_SECRET) static struct nvme_ctrl * nvmf_create_ctrl(struct device *dev, const char *buf) @@ -1175,7 +1241,14 @@ static void __exit nvmf_exit(void) BUILD_BUG_ON(sizeof(struct nvmf_connect_command) != 64); BUILD_BUG_ON(sizeof(struct nvmf_property_get_command) != 64); BUILD_BUG_ON(sizeof(struct nvmf_property_set_command) != 64); + BUILD_BUG_ON(sizeof(struct nvmf_auth_send_command) != 64); + BUILD_BUG_ON(sizeof(struct nvmf_auth_receive_command) != 64); BUILD_BUG_ON(sizeof(struct nvmf_connect_data) != 1024); + BUILD_BUG_ON(sizeof(struct nvmf_auth_dhchap_negotiate_data) != 8); + BUILD_BUG_ON(sizeof(struct nvmf_auth_dhchap_challenge_data) != 16); + BUILD_BUG_ON(sizeof(struct nvmf_auth_dhchap_reply_data) != 16); + BUILD_BUG_ON(sizeof(struct nvmf_auth_dhchap_success1_data) != 16); + BUILD_BUG_ON(sizeof(struct nvmf_auth_dhchap_success2_data) != 16); } MODULE_LICENSE("GPL v2"); diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h index c3203ff1c654..c2a03d99ac26 100644 --- a/drivers/nvme/host/fabrics.h +++ b/drivers/nvme/host/fabrics.h @@ -68,6 +68,8 @@ enum { NVMF_OPT_FAIL_FAST_TMO = 1 << 20, NVMF_OPT_HOST_IFACE = 1 << 21, NVMF_OPT_DISCOVERY = 1 << 22, + NVMF_OPT_DHCHAP_SECRET = 1 << 23, + NVMF_OPT_DHCHAP_CTRL_SECRET = 1 << 24, }; /** @@ -97,6 +99,9 @@ enum { * @max_reconnects: maximum number of allowed reconnect attempts before removing * the controller, (-1) means reconnect forever, zero means remove * immediately; + * @dhchap_secret: DH-HMAC-CHAP secret + * @dhchap_ctrl_secret: DH-HMAC-CHAP controller secret for bi-directional + * authentication * @disable_sqflow: disable controller sq flow control * @hdr_digest: generate/verify header digest (TCP) * @data_digest: generate/verify data digest (TCP) @@ -121,6 +126,8 @@ struct nvmf_ctrl_options { unsigned int kato; struct nvmf_host *host; int max_reconnects; + char *dhchap_secret; + char *dhchap_ctrl_secret; bool disable_sqflow; bool hdr_digest; bool data_digest; diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index b334af8aa264..740a2780a4d4 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -324,6 +324,15 @@ struct nvme_ctrl { struct work_struct ana_work; #endif +#ifdef CONFIG_NVME_AUTH + struct work_struct dhchap_auth_work; + struct list_head dhchap_auth_list; + struct mutex dhchap_auth_mutex; + struct nvme_dhchap_key *host_key; + struct nvme_dhchap_key *ctrl_key; + u16 transaction; +#endif + /* Power saving configuration */ u64 ps_max_latency_us; bool apst_enabled; @@ -910,6 +919,28 @@ static inline bool nvme_ctrl_sgl_supported(struct nvme_ctrl *ctrl) return ctrl->sgls & ((1 << 0) | (1 << 1)); } +#ifdef CONFIG_NVME_AUTH +void nvme_auth_init_ctrl(struct nvme_ctrl *ctrl); +void nvme_auth_stop(struct nvme_ctrl *ctrl); +int nvme_auth_negotiate(struct nvme_ctrl *ctrl, int qid); +int nvme_auth_wait(struct nvme_ctrl *ctrl, int qid); +void nvme_auth_reset(struct nvme_ctrl *ctrl); +void nvme_auth_free(struct nvme_ctrl *ctrl); +int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key); +#else +static inline void nvme_auth_init_ctrl(struct nvme_ctrl *ctrl) {}; +static inline void nvme_auth_stop(struct nvme_ctrl *ctrl) {}; +static inline int nvme_auth_negotiate(struct nvme_ctrl *ctrl, int qid) +{ + return -EPROTONOSUPPORT; +} +static inline int nvme_auth_wait(struct nvme_ctrl *ctrl, int qid) +{ + return NVME_SC_AUTH_REQUIRED; +} +static inline void nvme_auth_free(struct nvme_ctrl *ctrl) {}; +#endif + u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode); int nvme_execute_passthru_rq(struct request *rq); diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 850f84d204d0..a8db8ab87dbc 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -1199,6 +1199,7 @@ static void nvme_rdma_error_recovery_work(struct work_struct *work) struct nvme_rdma_ctrl *ctrl = container_of(work, struct nvme_rdma_ctrl, err_work); + nvme_auth_stop(&ctrl->ctrl); nvme_stop_keep_alive(&ctrl->ctrl); nvme_rdma_teardown_io_queues(ctrl, false); nvme_start_queues(&ctrl->ctrl); diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 33bc83d8d992..bd8c724b3d13 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -2096,6 +2096,7 @@ static void nvme_tcp_error_recovery_work(struct work_struct *work) struct nvme_tcp_ctrl, err_work); struct nvme_ctrl *ctrl = &tcp_ctrl->ctrl; + nvme_auth_stop(ctrl); nvme_stop_keep_alive(ctrl); nvme_tcp_teardown_io_queues(ctrl, false); /* unquiesce to fail fast pending requests */ diff --git a/drivers/nvme/host/trace.c b/drivers/nvme/host/trace.c index 2a89c5aa0790..1c36fcedea20 100644 --- a/drivers/nvme/host/trace.c +++ b/drivers/nvme/host/trace.c @@ -287,6 +287,34 @@ static const char *nvme_trace_fabrics_property_get(struct trace_seq *p, u8 *spc) return ret; } +static const char *nvme_trace_fabrics_auth_send(struct trace_seq *p, u8 *spc) +{ + const char *ret = trace_seq_buffer_ptr(p); + u8 spsp0 = spc[1]; + u8 spsp1 = spc[2]; + u8 secp = spc[3]; + u32 tl = get_unaligned_le32(spc + 4); + + trace_seq_printf(p, "spsp0=%02x, spsp1=%02x, secp=%02x, tl=%u", + spsp0, spsp1, secp, tl); + trace_seq_putc(p, 0); + return ret; +} + +static const char *nvme_trace_fabrics_auth_receive(struct trace_seq *p, u8 *spc) +{ + const char *ret = trace_seq_buffer_ptr(p); + u8 spsp0 = spc[1]; + u8 spsp1 = spc[2]; + u8 secp = spc[3]; + u32 al = get_unaligned_le32(spc + 4); + + trace_seq_printf(p, "spsp0=%02x, spsp1=%02x, secp=%02x, al=%u", + spsp0, spsp1, secp, al); + trace_seq_putc(p, 0); + return ret; +} + static const char *nvme_trace_fabrics_common(struct trace_seq *p, u8 *spc) { const char *ret = trace_seq_buffer_ptr(p); @@ -306,6 +334,10 @@ const char *nvme_trace_parse_fabrics_cmd(struct trace_seq *p, return nvme_trace_fabrics_connect(p, spc); case nvme_fabrics_type_property_get: return nvme_trace_fabrics_property_get(p, spc); + case nvme_fabrics_type_auth_send: + return nvme_trace_fabrics_auth_send(p, spc); + case nvme_fabrics_type_auth_receive: + return nvme_trace_fabrics_auth_receive(p, spc); default: return nvme_trace_fabrics_common(p, spc); } From patchwork Thu Dec 2 15:23:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652805 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E452C433EF for ; Thu, 2 Dec 2021 15:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358944AbhLBP1h (ORCPT ); Thu, 2 Dec 2021 10:27:37 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42126 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358940AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A89061FE02; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7IUvKHMStek2+HuUuu4fmmikA97g4NyN1IVLg+orHY=; b=unXND1JtM/3A18+gODr3TPF6qiNmeVVwJhq3oQxzGz5nb80o8UTZkwyQg8c1t/2i1awEuJ +cFjUN5nrNguLpaJF18EtqTN4IhR1Ta1akXqbyCNjpQiPkdTu6/uiItBJQyiB2c250czw0 Wp9Hh4nYOi1Wi0q+NhLC+fFZIdOkMFs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7IUvKHMStek2+HuUuu4fmmikA97g4NyN1IVLg+orHY=; b=a5dEQfbPSFmK20HOniw2O4nf03gRQWgWEHrR3YXbNRA1mqaV1fZz9Z6WwdIg31BN1qhhQE /90PoE3W7Ej8u7Cw== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 98258A3B8E; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 486C15191DF8; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Date: Thu, 2 Dec 2021 16:23:54 +0100 Message-Id: <20211202152358.60116-9-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Implement Diffie-Hellman key exchange using FFDHE groups for NVMe In-Band Authentication. Signed-off-by: Hannes Reinecke --- drivers/nvme/host/Kconfig | 1 + drivers/nvme/host/auth.c | 412 +++++++++++++++++++++++++++++++++++++- drivers/nvme/host/auth.h | 8 + 3 files changed, 415 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 49269c581ec4..0fab5684feca 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -90,6 +90,7 @@ config NVME_AUTH select CRYPTO_HMAC select CRYPTO_SHA256 select CRYPTO_SHA512 + select CRYPTO_FFDHE help This provides support for NVMe over Fabrics In-Band Authentication. diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c index 774085e4f400..e653ca90a531 100644 --- a/drivers/nvme/host/auth.c +++ b/drivers/nvme/host/auth.c @@ -22,6 +22,7 @@ struct nvme_dhchap_queue_context { struct work_struct auth_work; struct nvme_ctrl *ctrl; struct crypto_shash *shash_tfm; + struct crypto_kpp *dh_tfm; void *buf; size_t buf_size; int qid; @@ -37,6 +38,12 @@ struct nvme_dhchap_queue_context { u8 c2[64]; u8 response[64]; u8 *host_response; + u8 *ctrl_key; + int ctrl_key_len; + u8 *host_key; + int host_key_len; + u8 *sess_key; + int sess_key_len; }; u32 nvme_auth_get_seqnum(void) @@ -354,6 +361,218 @@ u8 *nvme_auth_transform_key(struct nvme_dhchap_key *key, char *nqn) } EXPORT_SYMBOL_GPL(nvme_auth_transform_key); +static int nvme_auth_hash_skey(int hmac_id, u8 *skey, size_t skey_len, u8 *hkey) +{ + const char *digest_name; + struct crypto_shash *tfm; + int ret; + + digest_name = nvme_auth_digest_name(hmac_id); + if (!digest_name) { + pr_debug("%s: failed to get digest for %d\n", __func__, + hmac_id); + return -EINVAL; + } + tfm = crypto_alloc_shash(digest_name, 0, 0); + if (IS_ERR(tfm)) + return -ENOMEM; + + ret = crypto_shash_tfm_digest(tfm, skey, skey_len, hkey); + if (ret < 0) + pr_debug("%s: Failed to hash digest len %zu\n", __func__, + skey_len); + + crypto_free_shash(tfm); + return ret; +} + +int nvme_auth_augmented_challenge(u8 hmac_id, u8 *skey, size_t skey_len, + u8 *challenge, u8 *aug, size_t hlen) +{ + struct crypto_shash *tfm; + struct shash_desc *desc; + u8 *hashed_key; + const char *hmac_name; + int ret; + + hashed_key = kmalloc(hlen, GFP_KERNEL); + if (!hashed_key) + return -ENOMEM; + + ret = nvme_auth_hash_skey(hmac_id, skey, + skey_len, hashed_key); + if (ret < 0) + goto out_free_key; + + hmac_name = nvme_auth_hmac_name(hmac_id); + if (!hmac_name) { + pr_warn("%s: invalid hash algoritm %d\n", + __func__, hmac_id); + ret = -EINVAL; + goto out_free_key; + } + + tfm = crypto_alloc_shash(hmac_name, 0, 0); + if (IS_ERR(tfm)) { + ret = PTR_ERR(tfm); + goto out_free_key; + } + + desc = kmalloc(sizeof(struct shash_desc) + crypto_shash_descsize(tfm), + GFP_KERNEL); + if (!desc) { + ret = -ENOMEM; + goto out_free_hash; + } + desc->tfm = tfm; + + ret = crypto_shash_setkey(tfm, hashed_key, hlen); + if (ret) + goto out_free_desc; + + ret = crypto_shash_init(desc); + if (ret) + goto out_free_desc; + + ret = crypto_shash_update(desc, challenge, hlen); + if (ret) + goto out_free_desc; + + ret = crypto_shash_final(desc, aug); +out_free_desc: + kfree_sensitive(desc); +out_free_hash: + crypto_free_shash(tfm); +out_free_key: + kfree_sensitive(hashed_key); + return ret; +} +EXPORT_SYMBOL_GPL(nvme_auth_augmented_challenge); + +int nvme_auth_gen_privkey(struct crypto_kpp *dh_tfm, u8 dh_gid) +{ + char *pkey; + int ret, pkey_len; + + if (dh_gid == NVME_AUTH_DHGROUP_2048 || + dh_gid == NVME_AUTH_DHGROUP_3072 || + dh_gid == NVME_AUTH_DHGROUP_4096 || + dh_gid == NVME_AUTH_DHGROUP_6144 || + dh_gid == NVME_AUTH_DHGROUP_8192) { + struct dh p = {0}; + int bits = nvme_auth_dhgroup_pubkey_size(dh_gid) << 3; + int dh_secret_len = 64; + u8 *dh_secret = kzalloc(dh_secret_len, GFP_KERNEL); + + if (!dh_secret) + return -ENOMEM; + + /* + * NVMe base spec v2.0: The DH value shall be set to the value + * of g^x mod p, where 'x' is a random number selected by the + * host that shall be at least 256 bits long. + * + * We will be using a 512 bit random number as private key. + * This is large enough to provide adequate security, but + * small enough such that we can trivially conform to + * NIST SB800-56A section 5.6.1.1.4 if + * we guarantee that the random number is not either + * all 0xff or all 0x00. But that should be guaranteed + * by the in-kernel RNG anyway. + */ + get_random_bytes(dh_secret, dh_secret_len); + + ret = crypto_ffdhe_params(&p, bits); + if (ret) { + kfree_sensitive(dh_secret); + return ret; + } + + p.key = dh_secret; + p.key_size = dh_secret_len; + + pkey_len = crypto_dh_key_len(&p); + pkey = kmalloc(pkey_len, GFP_KERNEL); + if (!pkey) { + kfree_sensitive(dh_secret); + return -ENOMEM; + } + + get_random_bytes(pkey, pkey_len); + ret = crypto_dh_encode_key(pkey, pkey_len, &p); + if (ret) { + pr_debug("failed to encode private key, error %d\n", + ret); + kfree_sensitive(dh_secret); + goto out; + } + } else { + pr_warn("invalid dh group %u\n", dh_gid); + return -EINVAL; + } + ret = crypto_kpp_set_secret(dh_tfm, pkey, pkey_len); + if (ret) + pr_debug("failed to set private key, error %d\n", ret); +out: + kfree_sensitive(pkey); + pkey = NULL; + return ret; +} +EXPORT_SYMBOL_GPL(nvme_auth_gen_privkey); + +int nvme_auth_gen_pubkey(struct crypto_kpp *dh_tfm, + u8 *host_key, size_t host_key_len) +{ + struct kpp_request *req; + struct crypto_wait wait; + struct scatterlist dst; + int ret; + + req = kpp_request_alloc(dh_tfm, GFP_KERNEL); + if (!req) + return -ENOMEM; + + crypto_init_wait(&wait); + kpp_request_set_input(req, NULL, 0); + sg_init_one(&dst, host_key, host_key_len); + kpp_request_set_output(req, &dst, host_key_len); + kpp_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG, + crypto_req_done, &wait); + + ret = crypto_wait_req(crypto_kpp_generate_public_key(req), &wait); + kpp_request_free(req); + return ret; +} +EXPORT_SYMBOL_GPL(nvme_auth_gen_pubkey); + +int nvme_auth_gen_shared_secret(struct crypto_kpp *dh_tfm, + u8 *ctrl_key, size_t ctrl_key_len, + u8 *sess_key, size_t sess_key_len) +{ + struct kpp_request *req; + struct crypto_wait wait; + struct scatterlist src, dst; + int ret; + + req = kpp_request_alloc(dh_tfm, GFP_KERNEL); + if (!req) + return -ENOMEM; + + crypto_init_wait(&wait); + sg_init_one(&src, ctrl_key, ctrl_key_len); + kpp_request_set_input(req, &src, ctrl_key_len); + sg_init_one(&dst, sess_key, sess_key_len); + kpp_request_set_output(req, &dst, sess_key_len); + kpp_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG, + crypto_req_done, &wait); + + ret = crypto_wait_req(crypto_kpp_compute_shared_secret(req), &wait); + + kpp_request_free(req); + return ret; +} +EXPORT_SYMBOL_GPL(nvme_auth_gen_shared_secret); + #define nvme_auth_flags_from_qid(qid) \ (qid == NVME_QID_ANY) ? 0 : BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED #define nvme_auth_queue_from_qid(ctrl, qid) \ @@ -479,6 +698,7 @@ static int nvme_auth_process_dhchap_challenge(struct nvme_ctrl *ctrl, struct nvmf_auth_dhchap_challenge_data *data = chap->buf; u16 dhvlen = le16_to_cpu(data->dhvlen); size_t size = sizeof(*data) + data->hl + dhvlen; + const char *gid_name = nvme_auth_dhgroup_name(data->dhgid); const char *hmac_name, *kpp_name; if (chap->buf_size < size) { @@ -549,15 +769,54 @@ static int nvme_auth_process_dhchap_challenge(struct nvme_ctrl *ctrl, "qid %d: invalid DH group id %d\n", chap->qid, data->dhgid); chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + /* Leave previous dh_tfm intact */ return NVME_SC_AUTH_REQUIRED; } + /* Clear host and controller key to avoid accidental reuse */ + kfree_sensitive(chap->host_key); + chap->host_key = NULL; + chap->host_key_len = 0; + kfree_sensitive(chap->ctrl_key); + chap->ctrl_key = NULL; + chap->ctrl_key_len = 0; + + if (chap->dhgroup_id == data->dhgid && + (data->dhgid == NVME_AUTH_DHGROUP_NULL || chap->dh_tfm)) { + dev_dbg(ctrl->device, + "qid %d: reuse existing DH group %s\n", + chap->qid, gid_name); + goto skip_kpp; + } + + /* Reset dh_tfm if it can't be reused */ + if (chap->dh_tfm) { + crypto_free_kpp(chap->dh_tfm); + chap->dh_tfm = NULL; + } + if (data->dhgid != NVME_AUTH_DHGROUP_NULL) { - dev_warn(ctrl->device, - "qid %d: unsupported DH group %s\n", - chap->qid, kpp_name); - chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; - return NVME_SC_AUTH_REQUIRED; + if (dhvlen == 0) { + dev_warn(ctrl->device, + "qid %d: empty DH value\n", + chap->qid); + chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + return NVME_SC_INVALID_FIELD; + } + + chap->dh_tfm = crypto_alloc_kpp(kpp_name, 0, 0); + if (IS_ERR(chap->dh_tfm)) { + int ret = PTR_ERR(chap->dh_tfm); + + dev_warn(ctrl->device, + "qid %d: error %d initializing DH group %s\n", + chap->qid, ret, gid_name); + chap->status = NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + chap->dh_tfm = NULL; + return NVME_SC_AUTH_REQUIRED; + } + dev_dbg(ctrl->device, "qid %d: selected DH group %s\n", + chap->qid, gid_name); } else if (dhvlen != 0) { dev_warn(ctrl->device, "qid %d: invalid DH value for NULL DH\n", @@ -567,8 +826,21 @@ static int nvme_auth_process_dhchap_challenge(struct nvme_ctrl *ctrl, } chap->dhgroup_id = data->dhgid; +skip_kpp: chap->s1 = le32_to_cpu(data->seqnum); memcpy(chap->c1, data->cval, chap->hash_len); + if (dhvlen) { + chap->ctrl_key = kmalloc(dhvlen, GFP_KERNEL); + if (!chap->ctrl_key) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + return NVME_SC_AUTH_REQUIRED; + } + chap->ctrl_key_len = dhvlen; + memcpy(chap->ctrl_key, data->cval + chap->hash_len, + dhvlen); + dev_dbg(ctrl->device, "ctrl public key %*ph\n", + (int)chap->ctrl_key_len, chap->ctrl_key); + } return 0; } @@ -581,6 +853,9 @@ static int nvme_auth_set_dhchap_reply_data(struct nvme_ctrl *ctrl, size += 2 * chap->hash_len; + if (chap->host_key_len) + size += chap->host_key_len; + if (chap->buf_size < size) { chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; return -EINVAL; @@ -591,7 +866,7 @@ static int nvme_auth_set_dhchap_reply_data(struct nvme_ctrl *ctrl, data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_REPLY; data->t_id = cpu_to_le16(chap->transaction); data->hl = chap->hash_len; - data->dhvlen = 0; + data->dhvlen = cpu_to_le16(chap->host_key_len); memcpy(data->rval, chap->response, chap->hash_len); if (ctrl->opts->dhchap_ctrl_secret) { get_random_bytes(chap->c2, chap->hash_len); @@ -606,6 +881,14 @@ static int nvme_auth_set_dhchap_reply_data(struct nvme_ctrl *ctrl, chap->s2 = 0; } data->seqnum = cpu_to_le32(chap->s2); + if (chap->host_key_len) { + dev_dbg(ctrl->device, "%s: qid %d host public key %*ph\n", + __func__, chap->qid, + chap->host_key_len, chap->host_key); + memcpy(data->rval + 2 * chap->hash_len, chap->host_key, + chap->host_key_len); + } + return size; } @@ -723,6 +1006,21 @@ static int nvme_auth_dhchap_setup_host_response(struct nvme_ctrl *ctrl, goto out; } + if (chap->dh_tfm) { + challenge = kmalloc(chap->hash_len, GFP_KERNEL); + if (!challenge) { + ret = -ENOMEM; + goto out; + } + ret = nvme_auth_augmented_challenge(chap->hash_id, + chap->sess_key, + chap->sess_key_len, + chap->c1, challenge, + chap->hash_len); + if (ret) + goto out; + } + shash->tfm = chap->shash_tfm; ret = crypto_shash_init(shash); if (ret) @@ -785,6 +1083,20 @@ static int nvme_auth_dhchap_setup_ctrl_response(struct nvme_ctrl *ctrl, goto out; } + if (chap->dh_tfm) { + challenge = kmalloc(chap->hash_len, GFP_KERNEL); + if (!challenge) { + ret = -ENOMEM; + goto out; + } + ret = nvme_auth_augmented_challenge(chap->hash_id, + chap->sess_key, + chap->sess_key_len, + chap->c2, challenge, + chap->hash_len); + if (ret) + goto out; + } dev_dbg(ctrl->device, "%s: qid %d ctrl response seq %u transaction %d\n", __func__, chap->qid, chap->s2, chap->transaction); dev_dbg(ctrl->device, "%s: qid %d challenge %*ph\n", @@ -857,8 +1169,82 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key) } EXPORT_SYMBOL_GPL(nvme_auth_generate_key); +static int nvme_auth_dhchap_exponential(struct nvme_ctrl *ctrl, + struct nvme_dhchap_queue_context *chap) +{ + int ret; + + if (chap->host_key && chap->host_key_len) { + dev_dbg(ctrl->device, + "qid %d: reusing host key\n", chap->qid); + goto gen_sesskey; + } + ret = nvme_auth_gen_privkey(chap->dh_tfm, chap->dhgroup_id); + if (ret < 0) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return ret; + } + + chap->host_key_len = + nvme_auth_dhgroup_pubkey_size(chap->dhgroup_id); + + chap->host_key = kzalloc(chap->host_key_len, GFP_KERNEL); + if (!chap->host_key) { + chap->host_key_len = 0; + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + return -ENOMEM; + } + ret = nvme_auth_gen_pubkey(chap->dh_tfm, + chap->host_key, chap->host_key_len); + if (ret) { + dev_dbg(ctrl->device, + "failed to generate public key, error %d\n", ret); + kfree(chap->host_key); + chap->host_key = NULL; + chap->host_key_len = 0; + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return ret; + } + +gen_sesskey: + chap->sess_key_len = chap->host_key_len; + chap->sess_key = kmalloc(chap->sess_key_len, GFP_KERNEL); + if (!chap->sess_key) { + chap->sess_key_len = 0; + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + return -ENOMEM; + } + + ret = nvme_auth_gen_shared_secret(chap->dh_tfm, + chap->ctrl_key, chap->ctrl_key_len, + chap->sess_key, chap->sess_key_len); + if (ret) { + dev_dbg(ctrl->device, + "failed to generate shared secret, error %d\n", ret); + kfree_sensitive(chap->sess_key); + chap->sess_key = NULL; + chap->sess_key_len = 0; + chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + return ret; + } + dev_dbg(ctrl->device, "shared secret %*ph\n", + (int)chap->sess_key_len, chap->sess_key); + return 0; +} + static void __nvme_auth_reset(struct nvme_dhchap_queue_context *chap) { + kfree_sensitive(chap->host_response); + chap->host_response = NULL; + kfree_sensitive(chap->host_key); + chap->host_key = NULL; + chap->host_key_len = 0; + kfree_sensitive(chap->ctrl_key); + chap->ctrl_key = NULL; + chap->ctrl_key_len = 0; + kfree_sensitive(chap->sess_key); + chap->sess_key = NULL; + chap->sess_key_len = 0; chap->status = 0; chap->error = 0; chap->s1 = 0; @@ -872,6 +1258,11 @@ static void __nvme_auth_free(struct nvme_dhchap_queue_context *chap) { if (chap->shash_tfm) crypto_free_shash(chap->shash_tfm); + if (chap->dh_tfm) + crypto_free_kpp(chap->dh_tfm); + kfree_sensitive(chap->ctrl_key); + kfree_sensitive(chap->host_key); + kfree_sensitive(chap->sess_key); kfree_sensitive(chap->host_response); kfree(chap->buf); kfree(chap); @@ -929,6 +1320,15 @@ static void __nvme_auth_work(struct work_struct *work) goto fail2; } + if (chap->ctrl_key_len) { + dev_dbg(ctrl->device, + "%s: qid %d DH exponential\n", + __func__, chap->qid); + ret = nvme_auth_dhchap_exponential(ctrl, chap); + if (ret) + goto fail2; + } + dev_dbg(ctrl->device, "%s: qid %d host response\n", __func__, chap->qid); ret = nvme_auth_dhchap_setup_host_response(ctrl, chap); diff --git a/drivers/nvme/host/auth.h b/drivers/nvme/host/auth.h index 2f39d17296d1..a266bd32147c 100644 --- a/drivers/nvme/host/auth.h +++ b/drivers/nvme/host/auth.h @@ -30,5 +30,13 @@ struct nvme_dhchap_key *nvme_auth_extract_key(unsigned char *secret, u8 key_hash); void nvme_auth_free_key(struct nvme_dhchap_key *key); u8 *nvme_auth_transform_key(struct nvme_dhchap_key *key, char *nqn); +int nvme_auth_augmented_challenge(u8 hmac_id, u8 *skey, size_t skey_len, + u8 *challenge, u8 *aug, size_t hlen); +int nvme_auth_gen_privkey(struct crypto_kpp *dh_tfm, u8 dh_gid); +int nvme_auth_gen_pubkey(struct crypto_kpp *dh_tfm, + u8 *host_key, size_t host_key_len); +int nvme_auth_gen_shared_secret(struct crypto_kpp *dh_tfm, + u8 *ctrl_key, size_t ctrl_key_len, + u8 *sess_key, size_t sess_key_len); #endif /* _NVME_AUTH_H */ From patchwork Thu Dec 2 15:23:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652791 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D14C4332F for ; Thu, 2 Dec 2021 15:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358901AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42100 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358939AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A6A8E1FE01; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UjO/egNmFWNNFKjv3uGJ3izNgDQ97ZLf0CHakF8xt+4=; b=iuC7kWVldIehjY/ZWSvG4WIETeDuDzlRdGp317DBRwDP+SHYUQ9c+wygrD7OCtjlyjyrHX C+eDiMGGLjGcyrTvWe7vPIrbox/wjhmmMnmxouIGgDXY8huf1YC/ztoI8mzZlTY3d8W4PK T/4JqpeH+u7YldjSt6RxVFYXgTfUcoM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UjO/egNmFWNNFKjv3uGJ3izNgDQ97ZLf0CHakF8xt+4=; b=SzZXbLUf5h7uTzYl4VcH1fqRp43iyDYDu4TDVmXEzNKrMy1Svs5GI8lf8ou4RjjvVNd372 ayofLEiLMXV4NsAA== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 984DAA3B8F; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 4C6605191DFA; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 09/12] nvmet: parse fabrics commands on io queues Date: Thu, 2 Dec 2021 16:23:55 +0100 Message-Id: <20211202152358.60116-10-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Some fabrics commands can be sent via io queues, so add a new function nvmet_parse_fabrics_io_cmd() and rename the existing nvmet_parse_fabrics_cmd() to nvmet_parse_fabrics_admin_cmd(). Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/core.c | 4 ++++ drivers/nvme/target/fabrics-cmd.c | 17 ++++++++++++++++- drivers/nvme/target/nvmet.h | 3 ++- 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 5119c687de68..745c4e28a845 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -863,8 +863,12 @@ static inline u16 nvmet_io_cmd_check_access(struct nvmet_req *req) static u16 nvmet_parse_io_cmd(struct nvmet_req *req) { + struct nvme_command *cmd = req->cmd; u16 ret; + if (nvme_is_fabrics(cmd)) + return nvmet_parse_fabrics_io_cmd(req); + ret = nvmet_check_ctrl_status(req); if (unlikely(ret)) return ret; diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c index 70fb587e9413..f23c28729908 100644 --- a/drivers/nvme/target/fabrics-cmd.c +++ b/drivers/nvme/target/fabrics-cmd.c @@ -82,7 +82,7 @@ static void nvmet_execute_prop_get(struct nvmet_req *req) nvmet_req_complete(req, status); } -u16 nvmet_parse_fabrics_cmd(struct nvmet_req *req) +u16 nvmet_parse_fabrics_admin_cmd(struct nvmet_req *req) { struct nvme_command *cmd = req->cmd; @@ -103,6 +103,21 @@ u16 nvmet_parse_fabrics_cmd(struct nvmet_req *req) return 0; } +u16 nvmet_parse_fabrics_io_cmd(struct nvmet_req *req) +{ + struct nvme_command *cmd = req->cmd; + + switch (cmd->fabrics.fctype) { + default: + pr_debug("received unknown capsule type 0x%x\n", + cmd->fabrics.fctype); + req->error_loc = offsetof(struct nvmf_common_command, fctype); + return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; + } + + return 0; +} + static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req) { struct nvmf_connect_command *c = &req->cmd->connect; diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index af193423c10b..496faea41149 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -418,7 +418,8 @@ u16 nvmet_file_parse_io_cmd(struct nvmet_req *req); u16 nvmet_bdev_zns_parse_io_cmd(struct nvmet_req *req); u16 nvmet_parse_admin_cmd(struct nvmet_req *req); u16 nvmet_parse_discovery_cmd(struct nvmet_req *req); -u16 nvmet_parse_fabrics_cmd(struct nvmet_req *req); +u16 nvmet_parse_fabrics_admin_cmd(struct nvmet_req *req); +u16 nvmet_parse_fabrics_io_cmd(struct nvmet_req *req); bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq, struct nvmet_sq *sq, const struct nvmet_fabrics_ops *ops); From patchwork Thu Dec 2 15:23:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652813 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FABC433EF for ; Thu, 2 Dec 2021 15:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358949AbhLBP1l (ORCPT ); Thu, 2 Dec 2021 10:27:41 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42158 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358930AbhLBP1d (ORCPT ); Thu, 2 Dec 2021 10:27:33 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id ABE231FE04; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DfzVlYbJL5zK/FKfFOv2mEfOhE+8n7iQR5eGFw9cx0E=; b=AJ20VL2Jm+Dk7mpKeR5lSY/qaUzmE0zK8GTdE0UvLv25F02SMCiUIXOtDtfoY3D57VMRIa nv497+Pu2yIr2Ta6nSZkgUuQR5Auc/2YaRfcLqGN8PxRPIYjPQAA29U3LA0uPyiJoOwuyF 3hqDGBr+wW6WxowvhKyJd7+ht3ue0zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DfzVlYbJL5zK/FKfFOv2mEfOhE+8n7iQR5eGFw9cx0E=; b=ipVTPQevJ+ZvHFzlgrXwb0oYl5lBTN2yLEHdtloc6hTNj8k+Ckr6U1zhnuYouXxq9B9KnM nTaqVSiqdjIirGBg== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 9ACB4A3B92; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 53E2E5191DFC; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 10/12] nvmet: Implement basic In-Band Authentication Date: Thu, 2 Dec 2021 16:23:56 +0100 Message-Id: <20211202152358.60116-11-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Implement NVMe-oF In-Band authentication according to NVMe TPAR 8006. This patch adds three additional configfs entries 'dhchap_key', 'dhchap_ctrl_key', and 'dhchap_hash' to the 'host' configfs directory. The 'dhchap_key' and 'dhchap_ctrl_key' entries need to be in the ASCII format as specified in NVMe Base Specification v2.0 section 8.13.5.8 'Secret representation'. 'dhchap_hash' defaults to 'hmac(sha256)', and can be written to to switch to a different HMAC algorithm. Signed-off-by: Hannes Reinecke --- drivers/nvme/target/Kconfig | 12 + drivers/nvme/target/Makefile | 1 + drivers/nvme/target/admin-cmd.c | 6 +- drivers/nvme/target/auth.c | 367 ++++++++++++++++++ drivers/nvme/target/configfs.c | 107 +++++- drivers/nvme/target/core.c | 11 + drivers/nvme/target/fabrics-cmd-auth.c | 491 +++++++++++++++++++++++++ drivers/nvme/target/fabrics-cmd.c | 38 +- drivers/nvme/target/nvmet.h | 62 ++++ 9 files changed, 1091 insertions(+), 4 deletions(-) create mode 100644 drivers/nvme/target/auth.c create mode 100644 drivers/nvme/target/fabrics-cmd-auth.c diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig index 973561c93888..e569319be679 100644 --- a/drivers/nvme/target/Kconfig +++ b/drivers/nvme/target/Kconfig @@ -83,3 +83,15 @@ config NVME_TARGET_TCP devices over TCP. If unsure, say N. + +config NVME_TARGET_AUTH + bool "NVMe over Fabrics In-band Authentication support" + depends on NVME_TARGET + depends on NVME_AUTH + select CRYPTO_HMAC + select CRYPTO_SHA256 + select CRYPTO_SHA512 + help + This enables support for NVMe over Fabrics In-band Authentication + + If unsure, say N. diff --git a/drivers/nvme/target/Makefile b/drivers/nvme/target/Makefile index 9837e580fa7e..c66820102493 100644 --- a/drivers/nvme/target/Makefile +++ b/drivers/nvme/target/Makefile @@ -13,6 +13,7 @@ nvmet-y += core.o configfs.o admin-cmd.o fabrics-cmd.o \ discovery.o io-cmd-file.o io-cmd-bdev.o nvmet-$(CONFIG_NVME_TARGET_PASSTHRU) += passthru.o nvmet-$(CONFIG_BLK_DEV_ZONED) += zns.o +nvmet-$(CONFIG_NVME_TARGET_AUTH) += fabrics-cmd-auth.o auth.o nvme-loop-y += loop.o nvmet-rdma-y += rdma.o nvmet-fc-y += fc.o diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 6fb24746de06..6b100c87d11d 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -1013,7 +1013,11 @@ u16 nvmet_parse_admin_cmd(struct nvmet_req *req) u16 ret; if (nvme_is_fabrics(cmd)) - return nvmet_parse_fabrics_cmd(req); + return nvmet_parse_fabrics_admin_cmd(req); + + if (unlikely(!nvmet_check_auth_status(req))) + return NVME_SC_AUTH_REQUIRED | NVME_SC_DNR; + if (nvmet_is_disc_subsys(nvmet_req_subsys(req))) return nvmet_parse_discovery_cmd(req); diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c new file mode 100644 index 000000000000..003c0faad7ff --- /dev/null +++ b/drivers/nvme/target/auth.c @@ -0,0 +1,367 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NVMe over Fabrics DH-HMAC-CHAP authentication. + * Copyright (c) 2020 Hannes Reinecke, SUSE Software Solutions. + * All rights reserved. + */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "nvmet.h" +#include "../host/auth.h" + +int nvmet_auth_set_key(struct nvmet_host *host, const char *secret, + bool set_ctrl) +{ + unsigned char key_hash; + char *dhchap_secret; + + if (sscanf(secret, "DHHC-1:%hhd:%*s", &key_hash) != 1) + return -EINVAL; + if (key_hash > 3) { + pr_warn("Invalid DH-HMAC-CHAP hash id %d\n", + key_hash); + return -EINVAL; + } + if (key_hash > 0) { + /* Validate selected hash algorithm */ + const char *hmac = nvme_auth_hmac_name(key_hash); + + if (!crypto_has_shash(hmac, 0, 0)) { + pr_err("DH-HMAC-CHAP hash %s unsupported\n", hmac); + return -ENOTSUPP; + } + } + dhchap_secret = kstrdup(secret, GFP_KERNEL); + if (!dhchap_secret) + return -ENOMEM; + if (set_ctrl) { + host->dhchap_ctrl_secret = strim(dhchap_secret); + host->dhchap_ctrl_key_hash = key_hash; + } else { + host->dhchap_secret = strim(dhchap_secret); + host->dhchap_key_hash = key_hash; + } + return 0; +} + +int nvmet_setup_auth(struct nvmet_ctrl *ctrl) +{ + int ret = 0; + struct nvmet_host_link *p; + struct nvmet_host *host = NULL; + const char *hash_name; + + down_read(&nvmet_config_sem); + if (nvmet_is_disc_subsys(ctrl->subsys)) + goto out_unlock; + + if (ctrl->subsys->allow_any_host) + goto out_unlock; + + list_for_each_entry(p, &ctrl->subsys->hosts, entry) { + pr_debug("check %s\n", nvmet_host_name(p->host)); + if (strcmp(nvmet_host_name(p->host), ctrl->hostnqn)) + continue; + host = p->host; + break; + } + if (!host) { + pr_debug("host %s not found\n", ctrl->hostnqn); + ret = -EPERM; + goto out_unlock; + } + + if (!host->dhchap_secret) { + pr_debug("No authentication provided\n"); + goto out_unlock; + } + + if (host->dhchap_hash_id == ctrl->shash_id) { + pr_debug("Re-use existing hash ID %d\n", + ctrl->shash_id); + } else { + hash_name = nvme_auth_hmac_name(host->dhchap_hash_id); + if (!hash_name) { + pr_warn("Hash ID %d invalid\n", host->dhchap_hash_id); + ret = -EINVAL; + goto out_unlock; + } + ctrl->shash_id = host->dhchap_hash_id; + } + + /* Skip the 'DHHC-1:XX:' prefix */ + nvme_auth_free_key(ctrl->host_key); + ctrl->host_key = nvme_auth_extract_key(host->dhchap_secret + 10, + host->dhchap_key_hash); + if (IS_ERR(ctrl->host_key)) { + ret = PTR_ERR(ctrl->host_key); + ctrl->host_key = NULL; + goto out_free_hash; + } + pr_debug("%s: using hash %s key %*ph\n", __func__, + ctrl->host_key->hash > 0 ? + nvme_auth_hmac_name(ctrl->host_key->hash) : "none", + (int)ctrl->host_key->len, ctrl->host_key->key); + + nvme_auth_free_key(ctrl->ctrl_key); + if (!host->dhchap_ctrl_secret) { + ctrl->ctrl_key = NULL; + goto out_unlock; + } + + ctrl->ctrl_key = nvme_auth_extract_key(host->dhchap_ctrl_secret + 10, + host->dhchap_ctrl_key_hash); + if (IS_ERR(ctrl->ctrl_key)) { + ret = PTR_ERR(ctrl->ctrl_key); + ctrl->ctrl_key = NULL; + } + pr_debug("%s: using ctrl hash %s key %*ph\n", __func__, + ctrl->ctrl_key->hash > 0 ? + nvme_auth_hmac_name(ctrl->ctrl_key->hash) : "none", + (int)ctrl->ctrl_key->len, ctrl->ctrl_key->key); + +out_free_hash: + if (ret) { + if (ctrl->host_key) { + nvme_auth_free_key(ctrl->host_key); + ctrl->host_key = NULL; + } + ctrl->shash_id = 0; + } +out_unlock: + up_read(&nvmet_config_sem); + + return ret; +} + +void nvmet_auth_sq_free(struct nvmet_sq *sq) +{ + kfree(sq->dhchap_c1); + sq->dhchap_c1 = NULL; + kfree(sq->dhchap_c2); + sq->dhchap_c2 = NULL; + kfree(sq->dhchap_skey); + sq->dhchap_skey = NULL; +} + +void nvmet_destroy_auth(struct nvmet_ctrl *ctrl) +{ + ctrl->shash_id = 0; + + if (ctrl->host_key) { + nvme_auth_free_key(ctrl->host_key); + ctrl->host_key = NULL; + } + if (ctrl->ctrl_key) { + nvme_auth_free_key(ctrl->ctrl_key); + ctrl->ctrl_key = NULL; + } +} + +bool nvmet_check_auth_status(struct nvmet_req *req) +{ + if (req->sq->ctrl->host_key && + !req->sq->authenticated) + return false; + return true; +} + +int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, + unsigned int shash_len) +{ + struct crypto_shash *shash_tfm; + struct shash_desc *shash; + struct nvmet_ctrl *ctrl = req->sq->ctrl; + const char *hash_name; + u8 *challenge = req->sq->dhchap_c1, *host_response; + u8 buf[4]; + int ret; + + hash_name = nvme_auth_hmac_name(ctrl->shash_id); + if (!hash_name) { + pr_warn("Hash ID %d invalid\n", ctrl->shash_id); + return -EINVAL; + } + + shash_tfm = crypto_alloc_shash(hash_name, 0, 0); + if (IS_ERR(shash_tfm)) { + pr_err("failed to allocate shash %s\n", hash_name); + return PTR_ERR(shash_tfm); + } + + if (shash_len != crypto_shash_digestsize(shash_tfm)) { + pr_debug("%s: hash len mismatch (len %d digest %d)\n", + __func__, shash_len, + crypto_shash_digestsize(shash_tfm)); + ret = -EINVAL; + goto out_free_tfm; + } + + host_response = nvme_auth_transform_key(ctrl->host_key, ctrl->hostnqn); + if (IS_ERR(host_response)) { + ret = PTR_ERR(host_response); + goto out_free_tfm; + } + + ret = crypto_shash_setkey(shash_tfm, host_response, + ctrl->host_key->len); + if (ret) + goto out_free_response; + + pr_debug("ctrl %d qid %d host response seq %u transaction %d\n", + ctrl->cntlid, req->sq->qid, req->sq->dhchap_s1, + req->sq->dhchap_tid); + + shash = kzalloc(sizeof(*shash) + crypto_shash_descsize(shash_tfm), + GFP_KERNEL); + if (!shash) { + ret = -ENOMEM; + goto out_free_response; + } + shash->tfm = shash_tfm; + ret = crypto_shash_init(shash); + if (ret) + goto out; + ret = crypto_shash_update(shash, challenge, shash_len); + if (ret) + goto out; + put_unaligned_le32(req->sq->dhchap_s1, buf); + ret = crypto_shash_update(shash, buf, 4); + if (ret) + goto out; + put_unaligned_le16(req->sq->dhchap_tid, buf); + ret = crypto_shash_update(shash, buf, 2); + if (ret) + goto out; + memset(buf, 0, 4); + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, "HostHost", 8); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->hostnqn, strlen(ctrl->hostnqn)); + if (ret) + goto out; + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->subsysnqn, + strlen(ctrl->subsysnqn)); + if (ret) + goto out; + ret = crypto_shash_final(shash, response); +out: + if (challenge != req->sq->dhchap_c1) + kfree(challenge); + kfree(shash); +out_free_response: + kfree_sensitive(host_response); +out_free_tfm: + crypto_free_shash(shash_tfm); + return 0; +} + +int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response, + unsigned int shash_len) +{ + struct crypto_shash *shash_tfm; + struct shash_desc *shash; + struct nvmet_ctrl *ctrl = req->sq->ctrl; + const char *hash_name; + u8 *challenge = req->sq->dhchap_c2, *ctrl_response; + u8 buf[4]; + int ret; + + hash_name = nvme_auth_hmac_name(ctrl->shash_id); + if (!hash_name) { + pr_warn("Hash ID %d invalid\n", ctrl->shash_id); + return -EINVAL; + } + + shash_tfm = crypto_alloc_shash(hash_name, 0, 0); + if (IS_ERR(shash_tfm)) { + pr_err("failed to allocate shash %s\n", hash_name); + return PTR_ERR(shash_tfm); + } + + if (shash_len != crypto_shash_digestsize(shash_tfm)) { + pr_debug("%s: hash len mismatch (len %d digest %d)\n", + __func__, shash_len, + crypto_shash_digestsize(shash_tfm)); + ret = -EINVAL; + goto out_free_tfm; + } + + ctrl_response = nvme_auth_transform_key(ctrl->ctrl_key, + ctrl->subsysnqn); + if (IS_ERR(ctrl_response)) { + ret = PTR_ERR(ctrl_response); + goto out_free_tfm; + } + + ret = crypto_shash_setkey(shash_tfm, ctrl_response, + ctrl->ctrl_key->len); + if (ret) + goto out_free_response; + + shash = kzalloc(sizeof(*shash) + crypto_shash_descsize(shash_tfm), + GFP_KERNEL); + if (!shash) { + ret = -ENOMEM; + goto out_free_response; + } + shash->tfm = shash_tfm; + + ret = crypto_shash_init(shash); + if (ret) + goto out; + ret = crypto_shash_update(shash, challenge, shash_len); + if (ret) + goto out; + put_unaligned_le32(req->sq->dhchap_s2, buf); + ret = crypto_shash_update(shash, buf, 4); + if (ret) + goto out; + put_unaligned_le16(req->sq->dhchap_tid, buf); + ret = crypto_shash_update(shash, buf, 2); + if (ret) + goto out; + memset(buf, 0, 4); + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, "Controller", 10); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->subsysnqn, + strlen(ctrl->subsysnqn)); + if (ret) + goto out; + ret = crypto_shash_update(shash, buf, 1); + if (ret) + goto out; + ret = crypto_shash_update(shash, ctrl->hostnqn, strlen(ctrl->hostnqn)); + if (ret) + goto out; + ret = crypto_shash_final(shash, response); +out: + if (challenge != req->sq->dhchap_c2) + kfree(challenge); + kfree(shash); +out_free_response: + kfree_sensitive(ctrl_response); +out_free_tfm: + crypto_free_shash(shash_tfm); + return 0; +} diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index 091a0ca16361..9fb52880aef5 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -11,8 +11,13 @@ #include #include #include +#include +#include #include "nvmet.h" +#ifdef CONFIG_NVME_TARGET_AUTH +#include "../host/auth.h" +#endif static const struct config_item_type nvmet_host_type; static const struct config_item_type nvmet_subsys_type; @@ -1698,10 +1703,102 @@ static const struct config_item_type nvmet_ports_type = { static struct config_group nvmet_subsystems_group; static struct config_group nvmet_ports_group; -static void nvmet_host_release(struct config_item *item) +#ifdef CONFIG_NVME_TARGET_AUTH +static ssize_t nvmet_host_dhchap_key_show(struct config_item *item, + char *page) +{ + u8 *dhchap_secret = to_host(item)->dhchap_secret; + + if (!dhchap_secret) + return sprintf(page, "\n"); + return sprintf(page, "%s\n", dhchap_secret); +} + +static ssize_t nvmet_host_dhchap_key_store(struct config_item *item, + const char *page, size_t count) +{ + struct nvmet_host *host = to_host(item); + int ret; + + ret = nvmet_auth_set_key(host, page, false); + /* + * Re-authentication is a soft state, so keep the + * current authentication valid until the host + * requests re-authentication. + */ + return ret < 0 ? ret : count; +} + +CONFIGFS_ATTR(nvmet_host_, dhchap_key); + +static ssize_t nvmet_host_dhchap_ctrl_key_show(struct config_item *item, + char *page) +{ + u8 *dhchap_secret = to_host(item)->dhchap_ctrl_secret; + + if (!dhchap_secret) + return sprintf(page, "\n"); + return sprintf(page, "%s\n", dhchap_secret); +} + +static ssize_t nvmet_host_dhchap_ctrl_key_store(struct config_item *item, + const char *page, size_t count) +{ + struct nvmet_host *host = to_host(item); + int ret; + + ret = nvmet_auth_set_key(host, page, true); + /* + * Re-authentication is a soft state, so keep the + * current authentication valid until the host + * requests re-authentication. + */ + return ret < 0 ? ret : count; +} + +CONFIGFS_ATTR(nvmet_host_, dhchap_ctrl_key); + +static ssize_t nvmet_host_dhchap_hash_show(struct config_item *item, + char *page) +{ + struct nvmet_host *host = to_host(item); + const char *hash_name = nvme_auth_hmac_name(host->dhchap_hash_id); + + return sprintf(page, "%s\n", hash_name ? hash_name : "none"); +} + +static ssize_t nvmet_host_dhchap_hash_store(struct config_item *item, + const char *page, size_t count) { struct nvmet_host *host = to_host(item); + u8 hmac_id; + hmac_id = nvme_auth_hmac_id(page); + if (hmac_id == NVME_AUTH_HASH_INVALID) + return -EINVAL; + if (!crypto_has_shash(nvme_auth_hmac_name(hmac_id), 0, 0)) + return -ENOTSUPP; + host->dhchap_hash_id = hmac_id; + return count; +} + +CONFIGFS_ATTR(nvmet_host_, dhchap_hash); + +static struct configfs_attribute *nvmet_host_attrs[] = { + &nvmet_host_attr_dhchap_key, + &nvmet_host_attr_dhchap_ctrl_key, + &nvmet_host_attr_dhchap_hash, + NULL, +}; +#endif /* CONFIG_NVME_TARGET_AUTH */ + +static void nvmet_host_release(struct config_item *item) +{ + struct nvmet_host *host = to_host(item); +#ifdef CONFIG_NVME_TARGET_AUTH + if (host->dhchap_secret) + kfree(host->dhchap_secret); +#endif kfree(host); } @@ -1711,6 +1808,9 @@ static struct configfs_item_operations nvmet_host_item_ops = { static const struct config_item_type nvmet_host_type = { .ct_item_ops = &nvmet_host_item_ops, +#ifdef CONFIG_NVME_TARGET_AUTH + .ct_attrs = nvmet_host_attrs, +#endif .ct_owner = THIS_MODULE, }; @@ -1723,6 +1823,11 @@ static struct config_group *nvmet_hosts_make_group(struct config_group *group, if (!host) return ERR_PTR(-ENOMEM); +#ifdef CONFIG_NVME_TARGET_AUTH + /* Default to SHA256 */ + host->dhchap_hash_id = NVME_AUTH_HASH_SHA256; +#endif + config_group_init_type_name(&host->group, name, &nvmet_host_type); return &host->group; diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 745c4e28a845..44f544356081 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -793,6 +793,7 @@ void nvmet_sq_destroy(struct nvmet_sq *sq) wait_for_completion(&sq->confirm_done); wait_for_completion(&sq->free_done); percpu_ref_exit(&sq->ref); + nvmet_auth_sq_free(sq); if (ctrl) { /* @@ -869,6 +870,9 @@ static u16 nvmet_parse_io_cmd(struct nvmet_req *req) if (nvme_is_fabrics(cmd)) return nvmet_parse_fabrics_io_cmd(req); + if (unlikely(!nvmet_check_auth_status(req))) + return NVME_SC_AUTH_REQUIRED | NVME_SC_DNR; + ret = nvmet_check_ctrl_status(req); if (unlikely(ret)) return ret; @@ -1273,6 +1277,11 @@ u16 nvmet_check_ctrl_status(struct nvmet_req *req) req->cmd->common.opcode, req->sq->qid); return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR; } + + if (unlikely(!nvmet_check_auth_status(req))) { + pr_warn("qid %d not authenticated\n", req->sq->qid); + return NVME_SC_AUTH_REQUIRED | NVME_SC_DNR; + } return 0; } @@ -1463,6 +1472,8 @@ static void nvmet_ctrl_free(struct kref *ref) flush_work(&ctrl->async_event_work); cancel_work_sync(&ctrl->fatal_err_work); + nvmet_destroy_auth(ctrl); + ida_simple_remove(&cntlid_ida, ctrl->cntlid); nvmet_async_events_free(ctrl); diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c new file mode 100644 index 000000000000..2a0fd2a400f2 --- /dev/null +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -0,0 +1,491 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NVMe over Fabrics DH-HMAC-CHAP authentication command handling. + * Copyright (c) 2020 Hannes Reinecke, SUSE Software Solutions. + * All rights reserved. + */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include +#include +#include +#include +#include "nvmet.h" +#include "../host/auth.h" + +void nvmet_init_auth(struct nvmet_ctrl *ctrl, struct nvmet_req *req) +{ + /* Initialize in-band authentication */ + req->sq->authenticated = false; + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE; + req->cqe->result.u32 |= 0x2 << 16; +} + +static u16 nvmet_auth_negotiate(struct nvmet_req *req, void *d) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + struct nvmf_auth_dhchap_negotiate_data *data = d; + int i, hash_id = 0, fallback_hash_id = 0, dhgid; + + pr_debug("%s: ctrl %d qid %d: data sc_d %d napd %d authid %d halen %d dhlen %d\n", + __func__, ctrl->cntlid, req->sq->qid, + data->sc_c, data->napd, data->auth_protocol[0].dhchap.authid, + data->auth_protocol[0].dhchap.halen, + data->auth_protocol[0].dhchap.dhlen); + req->sq->dhchap_tid = le16_to_cpu(data->t_id); + if (data->sc_c) + return NVME_AUTH_DHCHAP_FAILURE_CONCAT_MISMATCH; + + if (data->napd != 1) + return NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + + if (data->auth_protocol[0].dhchap.authid != + NVME_AUTH_DHCHAP_AUTH_ID) + return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + + for (i = 0; i < data->auth_protocol[0].dhchap.halen; i++) { + u8 host_hmac_id = data->auth_protocol[0].dhchap.idlist[i]; + + if (!fallback_hash_id && + crypto_has_shash(nvme_auth_hmac_name(host_hmac_id), 0, 0)) + fallback_hash_id = host_hmac_id; + if (ctrl->shash_id != host_hmac_id) + continue; + hash_id = ctrl->shash_id; + break; + } + if (hash_id == 0) { + if (fallback_hash_id == 0) { + pr_debug("%s: ctrl %d qid %d: no usable hash found\n", + __func__, ctrl->cntlid, req->sq->qid); + return NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + } + pr_debug("%s: ctrl %d qid %d: no usable hash found, falling back to %s\n", + __func__, ctrl->cntlid, req->sq->qid, + nvme_auth_hmac_name(fallback_hash_id)); + ctrl->shash_id = fallback_hash_id; + } + + dhgid = -1; + for (i = 0; i < data->auth_protocol[0].dhchap.dhlen; i++) { + int tmp_dhgid = data->auth_protocol[0].dhchap.idlist[i + 30]; + + if (tmp_dhgid == NVME_AUTH_DHGROUP_NULL) { + dhgid = tmp_dhgid; + break; + } + } + if (dhgid < 0) { + pr_debug("%s: ctrl %d qid %d: no usable DH group found\n", + __func__, ctrl->cntlid, req->sq->qid); + return NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + } + pr_debug("%s: ctrl %d qid %d: selected DH group %s (%d)\n", + __func__, ctrl->cntlid, req->sq->qid, + nvme_auth_dhgroup_name(dhgid), dhgid); + return 0; +} + +static u16 nvmet_auth_reply(struct nvmet_req *req, void *d) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + struct nvmf_auth_dhchap_reply_data *data = d; + u32 dhvlen = le32_to_cpu(data->dhvlen); + u8 *response; + + pr_debug("%s: ctrl %d qid %d: data hl %d cvalid %d dhvlen %u\n", + __func__, ctrl->cntlid, req->sq->qid, + data->hl, data->cvalid, dhvlen); + + if (dhvlen) { + return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + } + + response = kmalloc(data->hl, GFP_KERNEL); + if (!response) + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + + if (!ctrl->host_key) { + pr_warn("ctrl %d qid %d no host key\n", + ctrl->cntlid, req->sq->qid); + kfree(response); + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + } + if (nvmet_auth_host_hash(req, response, data->hl) < 0) { + pr_debug("ctrl %d qid %d host hash failed\n", + ctrl->cntlid, req->sq->qid); + kfree(response); + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + } + + if (memcmp(data->rval, response, data->hl)) { + pr_info("ctrl %d qid %d host response mismatch\n", + ctrl->cntlid, req->sq->qid); + kfree(response); + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + } + kfree(response); + pr_debug("%s: ctrl %d qid %d host authenticated\n", + __func__, ctrl->cntlid, req->sq->qid); + if (data->cvalid) { + req->sq->dhchap_c2 = kmalloc(data->hl, GFP_KERNEL); + if (!req->sq->dhchap_c2) + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + memcpy(req->sq->dhchap_c2, data->rval + data->hl, data->hl); + + pr_debug("%s: ctrl %d qid %d challenge %*ph\n", + __func__, ctrl->cntlid, req->sq->qid, data->hl, + req->sq->dhchap_c2); + req->sq->dhchap_s2 = le32_to_cpu(data->seqnum); + } else + req->sq->dhchap_c2 = NULL; + + return 0; +} + +static u16 nvmet_auth_failure2(struct nvmet_req *req, void *d) +{ + struct nvmf_auth_dhchap_failure_data *data = d; + + return data->rescode_exp; +} + +void nvmet_execute_auth_send(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + struct nvmf_auth_dhchap_success2_data *data; + void *d; + u32 tl; + u16 status = 0; + + if (req->cmd->auth_send.secp != NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_send_command, secp); + goto done; + } + if (req->cmd->auth_send.spsp0 != 0x01) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_send_command, spsp0); + goto done; + } + if (req->cmd->auth_send.spsp1 != 0x01) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_send_command, spsp1); + goto done; + } + tl = le32_to_cpu(req->cmd->auth_send.tl); + if (!tl) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_send_command, tl); + goto done; + } + if (!nvmet_check_transfer_len(req, tl)) { + pr_debug("%s: transfer length mismatch (%u)\n", __func__, tl); + return; + } + + d = kmalloc(tl, GFP_KERNEL); + if (!d) { + status = NVME_SC_INTERNAL; + goto done; + } + + status = nvmet_copy_from_sgl(req, 0, d, tl); + if (status) { + kfree(d); + goto done; + } + + data = d; + pr_debug("%s: ctrl %d qid %d type %d id %d step %x\n", __func__, + ctrl->cntlid, req->sq->qid, data->auth_type, data->auth_id, + req->sq->dhchap_step); + if (data->auth_type != NVME_AUTH_COMMON_MESSAGES && + data->auth_type != NVME_AUTH_DHCHAP_MESSAGES) + goto done_failure1; + if (data->auth_type == NVME_AUTH_COMMON_MESSAGES) { + if (data->auth_id == NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE) { + /* Restart negotiation */ + pr_debug("%s: ctrl %d qid %d reset negotiation\n", __func__, + ctrl->cntlid, req->sq->qid); + if (!req->sq->qid) { + status = nvmet_setup_auth(ctrl); + if (status < 0) { + pr_err("ctrl %d qid 0 failed to setup" + "re-authentication", + ctrl->cntlid); + goto done_failure1; + } + } + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE; + } else if (data->auth_id != req->sq->dhchap_step) + goto done_failure1; + /* Validate negotiation parameters */ + status = nvmet_auth_negotiate(req, d); + if (status == 0) + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE; + else { + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_FAILURE1; + req->sq->dhchap_status = status; + status = 0; + } + goto done_kfree; + } + if (data->auth_id != req->sq->dhchap_step) { + pr_debug("%s: ctrl %d qid %d step mismatch (%d != %d)\n", + __func__, ctrl->cntlid, req->sq->qid, + data->auth_id, req->sq->dhchap_step); + goto done_failure1; + } + if (le16_to_cpu(data->t_id) != req->sq->dhchap_tid) { + pr_debug("%s: ctrl %d qid %d invalid transaction %d (expected %d)\n", + __func__, ctrl->cntlid, req->sq->qid, + le16_to_cpu(data->t_id), + req->sq->dhchap_tid); + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_FAILURE1; + req->sq->dhchap_status = + NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + goto done_kfree; + } + + switch (data->auth_id) { + case NVME_AUTH_DHCHAP_MESSAGE_REPLY: + status = nvmet_auth_reply(req, d); + if (status == 0) + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1; + else { + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_FAILURE1; + req->sq->dhchap_status = status; + status = 0; + } + goto done_kfree; + break; + case NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2: + req->sq->authenticated = true; + pr_debug("%s: ctrl %d qid %d ctrl authenticated\n", + __func__, ctrl->cntlid, req->sq->qid); + goto done_kfree; + break; + case NVME_AUTH_DHCHAP_MESSAGE_FAILURE2: + status = nvmet_auth_failure2(req, d); + if (status) { + pr_warn("ctrl %d qid %d: authentication failed (%d)\n", + ctrl->cntlid, req->sq->qid, status); + req->sq->dhchap_status = status; + status = 0; + } + goto done_kfree; + break; + default: + req->sq->dhchap_status = + NVME_AUTH_DHCHAP_FAILURE_INCORRECT_MESSAGE; + req->sq->dhchap_step = + NVME_AUTH_DHCHAP_MESSAGE_FAILURE2; + goto done_kfree; + break; + } +done_failure1: + req->sq->dhchap_status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_MESSAGE; + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_FAILURE2; + +done_kfree: + kfree(d); +done: + pr_debug("%s: ctrl %d qid %d dhchap status %x step %x\n", __func__, + ctrl->cntlid, req->sq->qid, + req->sq->dhchap_status, req->sq->dhchap_step); + if (status) + pr_debug("%s: ctrl %d qid %d nvme status %x error loc %d\n", + __func__, ctrl->cntlid, req->sq->qid, + status, req->error_loc); + req->cqe->result.u64 = 0; + nvmet_req_complete(req, status); + if (req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2 && + req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) + return; + /* Final states, clear up variables */ + nvmet_auth_sq_free(req->sq); + if (req->sq->dhchap_step == NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) + nvmet_ctrl_fatal_error(ctrl); +} + +static int nvmet_auth_challenge(struct nvmet_req *req, void *d, int al) +{ + struct nvmf_auth_dhchap_challenge_data *data = d; + struct nvmet_ctrl *ctrl = req->sq->ctrl; + int ret = 0; + int hash_len = nvme_auth_hmac_hash_len(ctrl->shash_id); + int data_size = sizeof(*d) + hash_len; + + if (al < data_size) { + pr_debug("%s: buffer too small (al %d need %d)\n", __func__, + al, data_size); + return -EINVAL; + } + memset(data, 0, data_size); + req->sq->dhchap_s1 = nvme_auth_get_seqnum(); + data->auth_type = NVME_AUTH_DHCHAP_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE; + data->t_id = cpu_to_le16(req->sq->dhchap_tid); + data->hashid = ctrl->shash_id; + data->hl = hash_len; + data->seqnum = cpu_to_le32(req->sq->dhchap_s1); + req->sq->dhchap_c1 = kmalloc(data->hl, GFP_KERNEL); + if (!req->sq->dhchap_c1) + return -ENOMEM; + get_random_bytes(req->sq->dhchap_c1, data->hl); + memcpy(data->cval, req->sq->dhchap_c1, data->hl); + pr_debug("%s: ctrl %d qid %d seq %u transaction %d hl %d dhvlen %u\n", + __func__, ctrl->cntlid, req->sq->qid, req->sq->dhchap_s1, + req->sq->dhchap_tid, data->hl, 0); + return ret; +} + +static int nvmet_auth_success1(struct nvmet_req *req, void *d, int al) +{ + struct nvmf_auth_dhchap_success1_data *data = d; + struct nvmet_ctrl *ctrl = req->sq->ctrl; + int hash_len = nvme_auth_hmac_hash_len(ctrl->shash_id); + + WARN_ON(al < sizeof(*data)); + memset(data, 0, sizeof(*data)); + data->auth_type = NVME_AUTH_DHCHAP_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1; + data->t_id = cpu_to_le16(req->sq->dhchap_tid); + data->hl = hash_len; + if (req->sq->dhchap_c2) { + if (!ctrl->ctrl_key) { + pr_warn("ctrl %d qid %d no ctrl key\n", + ctrl->cntlid, req->sq->qid); + return NVME_AUTH_DHCHAP_FAILURE_FAILED; + } + if (nvmet_auth_ctrl_hash(req, data->rval, data->hl)) + return NVME_AUTH_DHCHAP_FAILURE_HASH_UNUSABLE; + data->rvalid = 1; + pr_debug("ctrl %d qid %d response %*ph\n", + ctrl->cntlid, req->sq->qid, data->hl, data->rval); + } + return 0; +} + +static void nvmet_auth_failure1(struct nvmet_req *req, void *d, int al) +{ + struct nvmf_auth_dhchap_failure_data *data = d; + + WARN_ON(al < sizeof(*data)); + data->auth_type = NVME_AUTH_COMMON_MESSAGES; + data->auth_id = NVME_AUTH_DHCHAP_MESSAGE_FAILURE1; + data->t_id = cpu_to_le16(req->sq->dhchap_tid); + data->rescode = NVME_AUTH_DHCHAP_FAILURE_REASON_FAILED; + data->rescode_exp = req->sq->dhchap_status; +} + +void nvmet_execute_auth_receive(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + void *d; + u32 al; + u16 status = 0; + + if (req->cmd->auth_receive.secp != NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_receive_command, secp); + goto done; + } + if (req->cmd->auth_receive.spsp0 != 0x01) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_receive_command, spsp0); + goto done; + } + if (req->cmd->auth_receive.spsp1 != 0x01) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_receive_command, spsp1); + goto done; + } + al = le32_to_cpu(req->cmd->auth_receive.al); + if (!al) { + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + req->error_loc = + offsetof(struct nvmf_auth_receive_command, al); + goto done; + } + if (!nvmet_check_transfer_len(req, al)) { + pr_debug("%s: transfer length mismatch (%u)\n", __func__, al); + return; + } + + d = kmalloc(al, GFP_KERNEL); + if (!d) { + status = NVME_SC_INTERNAL; + goto done; + } + pr_debug("%s: ctrl %d qid %d step %x\n", __func__, + ctrl->cntlid, req->sq->qid, req->sq->dhchap_step); + switch (req->sq->dhchap_step) { + case NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE: + status = nvmet_auth_challenge(req, d, al); + if (status < 0) { + pr_warn("ctrl %d qid %d: challenge error (%d)\n", + ctrl->cntlid, req->sq->qid, status); + status = NVME_SC_INTERNAL; + break; + } + if (status) { + req->sq->dhchap_status = status; + nvmet_auth_failure1(req, d, al); + pr_warn("ctrl %d qid %d: challenge status (%x)\n", + ctrl->cntlid, req->sq->qid, + req->sq->dhchap_status); + status = 0; + break; + } + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_REPLY; + break; + case NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1: + status = nvmet_auth_success1(req, d, al); + if (status) { + req->sq->dhchap_status = status; + nvmet_auth_failure1(req, d, al); + pr_warn("ctrl %d qid %d: success1 status (%x)\n", + ctrl->cntlid, req->sq->qid, + req->sq->dhchap_status); + break; + } + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2; + break; + case NVME_AUTH_DHCHAP_MESSAGE_FAILURE1: + nvmet_auth_failure1(req, d, al); + pr_warn("ctrl %d qid %d failure1 (%x)\n", + ctrl->cntlid, req->sq->qid, req->sq->dhchap_status); + break; + default: + pr_warn("ctrl %d qid %d unhandled step (%d)\n", + ctrl->cntlid, req->sq->qid, req->sq->dhchap_step); + req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_FAILURE1; + req->sq->dhchap_status = NVME_AUTH_DHCHAP_FAILURE_FAILED; + nvmet_auth_failure1(req, d, al); + status = 0; + break; + } + + status = nvmet_copy_to_sgl(req, 0, d, al); + kfree(d); +done: + req->cqe->result.u64 = 0; + nvmet_req_complete(req, status); + if (req->sq->dhchap_step == NVME_AUTH_DHCHAP_MESSAGE_FAILURE1) { + nvmet_auth_sq_free(req->sq); + nvmet_ctrl_fatal_error(ctrl); + } +} diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c index f23c28729908..f91a56180d3d 100644 --- a/drivers/nvme/target/fabrics-cmd.c +++ b/drivers/nvme/target/fabrics-cmd.c @@ -93,6 +93,14 @@ u16 nvmet_parse_fabrics_admin_cmd(struct nvmet_req *req) case nvme_fabrics_type_property_get: req->execute = nvmet_execute_prop_get; break; +#ifdef CONFIG_NVME_TARGET_AUTH + case nvme_fabrics_type_auth_send: + req->execute = nvmet_execute_auth_send; + break; + case nvme_fabrics_type_auth_receive: + req->execute = nvmet_execute_auth_receive; + break; +#endif default: pr_debug("received unknown capsule type 0x%x\n", cmd->fabrics.fctype); @@ -108,6 +116,14 @@ u16 nvmet_parse_fabrics_io_cmd(struct nvmet_req *req) struct nvme_command *cmd = req->cmd; switch (cmd->fabrics.fctype) { +#ifdef CONFIG_NVME_TARGET_AUTH + case nvme_fabrics_type_auth_send: + req->execute = nvmet_execute_auth_send; + break; + case nvme_fabrics_type_auth_receive: + req->execute = nvmet_execute_auth_receive; + break; +#endif default: pr_debug("received unknown capsule type 0x%x\n", cmd->fabrics.fctype); @@ -188,6 +204,7 @@ static void nvmet_execute_admin_connect(struct nvmet_req *req) struct nvmf_connect_data *d; struct nvmet_ctrl *ctrl = NULL; u16 status = 0; + int ret; if (!nvmet_check_transfer_len(req, sizeof(struct nvmf_connect_data))) return; @@ -230,18 +247,32 @@ static void nvmet_execute_admin_connect(struct nvmet_req *req) uuid_copy(&ctrl->hostid, &d->hostid); + ret = nvmet_setup_auth(ctrl); + if (ret < 0) { + pr_err("Failed to setup authentication, error %d\n", ret); + nvmet_ctrl_put(ctrl); + if (ret == -EPERM) + status = (NVME_SC_CONNECT_INVALID_HOST | NVME_SC_DNR); + else + status = NVME_SC_INTERNAL; + goto out; + } + status = nvmet_install_queue(ctrl, req); if (status) { nvmet_ctrl_put(ctrl); goto out; } - pr_info("creating %s controller %d for subsystem %s for NQN %s%s.\n", + pr_info("creating %s controller %d for subsystem %s for NQN %s%s%s.\n", nvmet_is_disc_subsys(ctrl->subsys) ? "discovery" : "nvm", ctrl->cntlid, ctrl->subsys->subsysnqn, ctrl->hostnqn, - ctrl->pi_support ? " T10-PI is enabled" : ""); + ctrl->pi_support ? " T10-PI is enabled" : "", + nvmet_has_auth(ctrl) ? " with DH-HMAC-CHAP" : ""); req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid); + if (nvmet_has_auth(ctrl)) + nvmet_init_auth(ctrl, req); out: kfree(d); complete: @@ -301,6 +332,9 @@ static void nvmet_execute_io_connect(struct nvmet_req *req) req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid); pr_debug("adding queue %d to ctrl %d.\n", qid, ctrl->cntlid); + req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid); + if (nvmet_has_auth(ctrl)) + nvmet_init_auth(ctrl, req); out: kfree(d); diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 496faea41149..0a976cfd65df 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -108,6 +108,18 @@ struct nvmet_sq { u16 size; u32 sqhd; bool sqhd_disabled; +#ifdef CONFIG_NVME_TARGET_AUTH + bool authenticated; + u16 dhchap_tid; + u16 dhchap_status; + int dhchap_step; + u8 *dhchap_c1; + u8 *dhchap_c2; + u32 dhchap_s1; + u32 dhchap_s2; + u8 *dhchap_skey; + int dhchap_skey_len; +#endif struct completion free_done; struct completion confirm_done; }; @@ -209,6 +221,11 @@ struct nvmet_ctrl { u64 err_counter; struct nvme_error_slot slots[NVMET_ERROR_LOG_SLOTS]; bool pi_support; +#ifdef CONFIG_NVME_TARGET_AUTH + struct nvme_dhchap_key *host_key; + struct nvme_dhchap_key *ctrl_key; + u8 shash_id; +#endif }; struct nvmet_subsys { @@ -270,6 +287,12 @@ static inline struct nvmet_subsys *namespaces_to_subsys( struct nvmet_host { struct config_group group; + u8 *dhchap_secret; + u8 *dhchap_ctrl_secret; + u8 dhchap_key_hash; + u8 dhchap_ctrl_key_hash; + u8 dhchap_hash_id; + u8 dhchap_dhgroup_id; }; static inline struct nvmet_host *to_host(struct config_item *item) @@ -667,4 +690,43 @@ static inline void nvmet_req_bio_put(struct nvmet_req *req, struct bio *bio) bio_put(bio); } +#ifdef CONFIG_NVME_TARGET_AUTH +void nvmet_execute_auth_send(struct nvmet_req *req); +void nvmet_execute_auth_receive(struct nvmet_req *req); +int nvmet_auth_set_key(struct nvmet_host *host, const char *secret, + bool set_ctrl); +int nvmet_auth_set_host_hash(struct nvmet_host *host, const char *hash); +int nvmet_setup_auth(struct nvmet_ctrl *ctrl); +void nvmet_init_auth(struct nvmet_ctrl *ctrl, struct nvmet_req *req); +void nvmet_destroy_auth(struct nvmet_ctrl *ctrl); +void nvmet_auth_sq_free(struct nvmet_sq *sq); +bool nvmet_check_auth_status(struct nvmet_req *req); +int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, + unsigned int hash_len); +int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response, + unsigned int hash_len); +static inline bool nvmet_has_auth(struct nvmet_ctrl *ctrl) +{ + return ctrl->host_key != NULL; +} +#else +static inline int nvmet_setup_auth(struct nvmet_ctrl *ctrl) +{ + return 0; +} +static inline void nvmet_init_auth(struct nvmet_ctrl *ctrl, + struct nvmet_req *req) {}; +static inline void nvmet_destroy_auth(struct nvmet_ctrl *ctrl) {}; +static inline void nvmet_auth_sq_free(struct nvmet_sq *sq) {}; +static inline bool nvmet_check_auth_status(struct nvmet_req *req) +{ + return true; +} +static inline bool nvmet_has_auth(struct nvmet_ctrl *ctrl) +{ + return false; +} +static inline const char *nvmet_dhchap_dhgroup_name(u8 dhgid) { return NULL; } +#endif + #endif /* _NVMET_H */ From patchwork Thu Dec 2 15:23:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652801 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CFFC4321E for ; Thu, 2 Dec 2021 15:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358941AbhLBP1g (ORCPT ); Thu, 2 Dec 2021 10:27:36 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42144 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358943AbhLBP1c (ORCPT ); Thu, 2 Dec 2021 10:27:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AAA671FE03; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tgJQdu2fHu/UrFFrWJm/BDJyOUcD15d1QzIVrrg2B3c=; b=NANcX8o0Atg0hK0pgsdLCEHBrHOwSTZ4gJHzOa18V9pG2cAzu7Nd8uKkadowzuGpPIvb86 Z5FvirzJKFa5ggbSvh3fYpxvgiQ0lpbdk+XwwiSwS3EgmHxpgFG2CLEZr5HmfeLQoFyM/U RnjSPNJTz52HcGhL/2UTgDNOFGdmUjA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tgJQdu2fHu/UrFFrWJm/BDJyOUcD15d1QzIVrrg2B3c=; b=lTOBZy9KUzB+T8C1VedanbO3RWFMbl4G2hCD8N0aVp3kj+P/Wq3jfFaeUjNi/r2s5xBNHw +cP60CJRaOw16sBQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 9CA9DA3B94; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 57F835191DFE; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 11/12] nvmet-auth: Diffie-Hellman key exchange support Date: Thu, 2 Dec 2021 16:23:57 +0100 Message-Id: <20211202152358.60116-12-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Implement Diffie-Hellman key exchange using FFDHE groups for NVMe In-Band Authentication. This patch adds a new host configfs attribute 'dhchap_dhgroup' to select the FFDHE group to use. Signed-off-by: Hannes Reinecke --- drivers/nvme/target/Kconfig | 1 + drivers/nvme/target/auth.c | 155 +++++++++++++++++++++++++ drivers/nvme/target/configfs.c | 31 +++++ drivers/nvme/target/fabrics-cmd-auth.c | 41 +++++-- drivers/nvme/target/nvmet.h | 9 ++ 5 files changed, 229 insertions(+), 8 deletions(-) diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig index e569319be679..0aceb8f7cedf 100644 --- a/drivers/nvme/target/Kconfig +++ b/drivers/nvme/target/Kconfig @@ -91,6 +91,7 @@ config NVME_TARGET_AUTH select CRYPTO_HMAC select CRYPTO_SHA256 select CRYPTO_SHA512 + select CRYPTO_FFDHE help This enables support for NVMe over Fabrics In-band Authentication diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c index 003c0faad7ff..28b41edf0e2b 100644 --- a/drivers/nvme/target/auth.c +++ b/drivers/nvme/target/auth.c @@ -54,6 +54,71 @@ int nvmet_auth_set_key(struct nvmet_host *host, const char *secret, return 0; } +int nvmet_setup_dhgroup(struct nvmet_ctrl *ctrl, u8 dhgroup_id) +{ + const char *dhgroup_kpp; + int ret = 0; + + pr_debug("%s: ctrl %d selecting dhgroup %d\n", + __func__, ctrl->cntlid, dhgroup_id); + + if (ctrl->dh_tfm) { + if (ctrl->dh_gid == dhgroup_id) { + pr_debug("%s: ctrl %d reuse existing DH group %d\n", + __func__, ctrl->cntlid, dhgroup_id); + return 0; + } + crypto_free_kpp(ctrl->dh_tfm); + ctrl->dh_tfm = NULL; + ctrl->dh_gid = 0; + } + + if (dhgroup_id == NVME_AUTH_DHGROUP_NULL) + return 0; + + dhgroup_kpp = nvme_auth_dhgroup_kpp(dhgroup_id); + if (!dhgroup_kpp) { + pr_debug("%s: ctrl %d invalid DH group %d\n", + __func__, ctrl->cntlid, dhgroup_id); + return -EINVAL; + } + ctrl->dh_tfm = crypto_alloc_kpp(dhgroup_kpp, 0, 0); + if (IS_ERR(ctrl->dh_tfm)) { + pr_debug("%s: ctrl %d failed to setup DH group %d, err %ld\n", + __func__, ctrl->cntlid, dhgroup_id, + PTR_ERR(ctrl->dh_tfm)); + ret = PTR_ERR(ctrl->dh_tfm); + ctrl->dh_tfm = NULL; + ctrl->dh_gid = 0; + } else { + ctrl->dh_gid = dhgroup_id; + ctrl->dh_keysize = nvme_auth_dhgroup_pubkey_size(dhgroup_id); + pr_debug("%s: ctrl %d setup DH group %d\n", + __func__, ctrl->cntlid, ctrl->dh_gid); + ret = nvme_auth_gen_privkey(ctrl->dh_tfm, ctrl->dh_gid); + if (ret < 0) + pr_debug("%s: ctrl %d failed to generate private key, err %d\n", + __func__, ctrl->cntlid, ret); + kfree_sensitive(ctrl->dh_key); + ctrl->dh_key = kzalloc(ctrl->dh_keysize, GFP_KERNEL); + if (!ctrl->dh_key) { + pr_warn("ctrl %d failed to allocate public key\n", + ctrl->cntlid); + return -ENOMEM; + } + ret = nvme_auth_gen_pubkey(ctrl->dh_tfm, ctrl->dh_key, + ctrl->dh_keysize); + if (ret < 0) { + pr_warn("ctrl %d failed to generate public key\n", + ctrl->cntlid); + kfree(ctrl->dh_key); + ctrl->dh_key = NULL; + } + } + + return ret; +} + int nvmet_setup_auth(struct nvmet_ctrl *ctrl) { int ret = 0; @@ -81,6 +146,10 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl) goto out_unlock; } + ret = nvmet_setup_dhgroup(ctrl, host->dhchap_dhgroup_id); + if (ret < 0) + pr_warn("Failed to setup DH group"); + if (!host->dhchap_secret) { pr_debug("No authentication provided\n"); goto out_unlock; @@ -158,6 +227,14 @@ void nvmet_destroy_auth(struct nvmet_ctrl *ctrl) { ctrl->shash_id = 0; + if (ctrl->dh_tfm) { + crypto_free_kpp(ctrl->dh_tfm); + ctrl->dh_tfm = NULL; + ctrl->dh_gid = 0; + } + kfree_sensitive(ctrl->dh_key); + ctrl->dh_key = NULL; + if (ctrl->host_key) { nvme_auth_free_key(ctrl->host_key); ctrl->host_key = NULL; @@ -218,6 +295,21 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, if (ret) goto out_free_response; + if (ctrl->dh_gid != NVME_AUTH_DHGROUP_NULL) { + challenge = kmalloc(shash_len, GFP_KERNEL); + if (!challenge) { + ret = -ENOMEM; + goto out_free_response; + } + ret = nvme_auth_augmented_challenge(ctrl->shash_id, + req->sq->dhchap_skey, + req->sq->dhchap_skey_len, + req->sq->dhchap_c1, + challenge, shash_len); + if (ret) + goto out_free_response; + } + pr_debug("ctrl %d qid %d host response seq %u transaction %d\n", ctrl->cntlid, req->sq->qid, req->sq->dhchap_s1, req->sq->dhchap_tid); @@ -315,6 +407,21 @@ int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response, if (ret) goto out_free_response; + if (ctrl->dh_gid != NVME_AUTH_DHGROUP_NULL) { + challenge = kmalloc(shash_len, GFP_KERNEL); + if (!challenge) { + ret = -ENOMEM; + goto out_free_response; + } + ret = nvme_auth_augmented_challenge(ctrl->shash_id, + req->sq->dhchap_skey, + req->sq->dhchap_skey_len, + req->sq->dhchap_c2, + challenge, shash_len); + if (ret) + goto out_free_response; + } + shash = kzalloc(sizeof(*shash) + crypto_shash_descsize(shash_tfm), GFP_KERNEL); if (!shash) { @@ -365,3 +472,51 @@ int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response, crypto_free_shash(shash_tfm); return 0; } + +int nvmet_auth_ctrl_exponential(struct nvmet_req *req, + u8 *buf, int buf_size) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + int ret = 0; + + if (!ctrl->dh_key) { + pr_warn("ctrl %d no DH public key!\n", ctrl->cntlid); + return -ENOKEY; + } + if (buf_size != ctrl->dh_keysize) { + pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n", + ctrl->cntlid, ctrl->dh_keysize, buf_size); + ret = -EINVAL; + } else { + memcpy(buf, ctrl->dh_key, buf_size); + pr_debug("%s: ctrl %d public key %*ph\n", __func__, + ctrl->cntlid, (int)buf_size, buf); + } + + return ret; +} + +int nvmet_auth_ctrl_sesskey(struct nvmet_req *req, + u8 *pkey, int pkey_size) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + int ret; + + req->sq->dhchap_skey_len = + nvme_auth_dhgroup_privkey_size(ctrl->dh_gid); + req->sq->dhchap_skey = kzalloc(req->sq->dhchap_skey_len, GFP_KERNEL); + if (!req->sq->dhchap_skey) + return -ENOMEM; + ret = nvme_auth_gen_shared_secret(ctrl->dh_tfm, + pkey, pkey_size, + req->sq->dhchap_skey, + req->sq->dhchap_skey_len); + if (ret) + pr_debug("failed to compute shared secred, err %d\n", ret); + else + pr_debug("%s: shared secret %*ph\n", __func__, + (int)req->sq->dhchap_skey_len, + req->sq->dhchap_skey); + + return ret; +} diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index 9fb52880aef5..59b575fa3c97 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -1784,10 +1784,41 @@ static ssize_t nvmet_host_dhchap_hash_store(struct config_item *item, CONFIGFS_ATTR(nvmet_host_, dhchap_hash); +static ssize_t nvmet_host_dhchap_dhgroup_show(struct config_item *item, + char *page) +{ + struct nvmet_host *host = to_host(item); + const char *dhgroup = nvme_auth_dhgroup_name(host->dhchap_dhgroup_id); + + return sprintf(page, "%s\n", dhgroup ? dhgroup : "none"); +} + +static ssize_t nvmet_host_dhchap_dhgroup_store(struct config_item *item, + const char *page, size_t count) +{ + struct nvmet_host *host = to_host(item); + int dhgroup_id; + + dhgroup_id = nvme_auth_dhgroup_id(page); + if (dhgroup_id == NVME_AUTH_DHGROUP_INVALID) + return -EINVAL; + if (dhgroup_id != NVME_AUTH_DHGROUP_NULL) { + const char *kpp = nvme_auth_dhgroup_kpp(dhgroup_id); + + if (!crypto_has_kpp(kpp, 0, 0)) + return -EINVAL; + } + host->dhchap_dhgroup_id = dhgroup_id; + return count; +} + +CONFIGFS_ATTR(nvmet_host_, dhchap_dhgroup); + static struct configfs_attribute *nvmet_host_attrs[] = { &nvmet_host_attr_dhchap_key, &nvmet_host_attr_dhchap_ctrl_key, &nvmet_host_attr_dhchap_hash, + &nvmet_host_attr_dhchap_dhgroup, NULL, }; #endif /* CONFIG_NVME_TARGET_AUTH */ diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c index 2a0fd2a400f2..402f387eff4c 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -24,7 +24,7 @@ static u16 nvmet_auth_negotiate(struct nvmet_req *req, void *d) { struct nvmet_ctrl *ctrl = req->sq->ctrl; struct nvmf_auth_dhchap_negotiate_data *data = d; - int i, hash_id = 0, fallback_hash_id = 0, dhgid; + int i, hash_id = 0, fallback_hash_id = 0, dhgid, fallback_dhgid; pr_debug("%s: ctrl %d qid %d: data sc_d %d napd %d authid %d halen %d dhlen %d\n", __func__, ctrl->cntlid, req->sq->qid, @@ -66,22 +66,35 @@ static u16 nvmet_auth_negotiate(struct nvmet_req *req, void *d) } dhgid = -1; + fallback_dhgid = -1; for (i = 0; i < data->auth_protocol[0].dhchap.dhlen; i++) { int tmp_dhgid = data->auth_protocol[0].dhchap.idlist[i + 30]; - if (tmp_dhgid == NVME_AUTH_DHGROUP_NULL) { + if (tmp_dhgid != ctrl->dh_gid) { dhgid = tmp_dhgid; break; } + if (fallback_dhgid < 0) { + const char *kpp = nvme_auth_dhgroup_kpp(tmp_dhgid); + + if (crypto_has_kpp(kpp, 0, 0)) + fallback_dhgid = tmp_dhgid; + } } if (dhgid < 0) { - pr_debug("%s: ctrl %d qid %d: no usable DH group found\n", + if (fallback_dhgid < 0) { + pr_debug("%s: ctrl %d qid %d: no usable DH group found\n", __func__, ctrl->cntlid, req->sq->qid); - return NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + return NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; + } + pr_debug("%s: ctrl %d qid %d: configured DH group %s not found\n", + __func__, ctrl->cntlid, req->sq->qid, + nvme_auth_dhgroup_name(fallback_dhgid)); + ctrl->dh_gid = fallback_dhgid; } pr_debug("%s: ctrl %d qid %d: selected DH group %s (%d)\n", __func__, ctrl->cntlid, req->sq->qid, - nvme_auth_dhgroup_name(dhgid), dhgid); + nvme_auth_dhgroup_name(ctrl->dh_gid), ctrl->dh_gid); return 0; } @@ -97,7 +110,11 @@ static u16 nvmet_auth_reply(struct nvmet_req *req, void *d) data->hl, data->cvalid, dhvlen); if (dhvlen) { - return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + if (!ctrl->dh_tfm) + return NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; + if (nvmet_auth_ctrl_sesskey(req, data->rval + 2 * data->hl, + dhvlen) < 0) + return NVME_AUTH_DHCHAP_FAILURE_DHGROUP_UNUSABLE; } response = kmalloc(data->hl, GFP_KERNEL); @@ -325,6 +342,8 @@ static int nvmet_auth_challenge(struct nvmet_req *req, void *d, int al) int hash_len = nvme_auth_hmac_hash_len(ctrl->shash_id); int data_size = sizeof(*d) + hash_len; + if (ctrl->dh_tfm) + data_size += ctrl->dh_keysize; if (al < data_size) { pr_debug("%s: buffer too small (al %d need %d)\n", __func__, al, data_size); @@ -343,9 +362,15 @@ static int nvmet_auth_challenge(struct nvmet_req *req, void *d, int al) return -ENOMEM; get_random_bytes(req->sq->dhchap_c1, data->hl); memcpy(data->cval, req->sq->dhchap_c1, data->hl); - pr_debug("%s: ctrl %d qid %d seq %u transaction %d hl %d dhvlen %u\n", + if (ctrl->dh_tfm) { + data->dhgid = ctrl->dh_gid; + data->dhvlen = cpu_to_le32(ctrl->dh_keysize); + ret = nvmet_auth_ctrl_exponential(req, data->cval + data->hl, + ctrl->dh_keysize); + } + pr_debug("%s: ctrl %d qid %d seq %d transaction %d hl %d dhvlen %lu\n", __func__, ctrl->cntlid, req->sq->qid, req->sq->dhchap_s1, - req->sq->dhchap_tid, data->hl, 0); + req->sq->dhchap_tid, data->hl, ctrl->dh_keysize); return ret; } diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 0a976cfd65df..789ff858fb4f 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -225,6 +225,10 @@ struct nvmet_ctrl { struct nvme_dhchap_key *host_key; struct nvme_dhchap_key *ctrl_key; u8 shash_id; + struct crypto_kpp *dh_tfm; + u8 dh_gid; + u8 *dh_key; + size_t dh_keysize; #endif }; @@ -700,6 +704,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl); void nvmet_init_auth(struct nvmet_ctrl *ctrl, struct nvmet_req *req); void nvmet_destroy_auth(struct nvmet_ctrl *ctrl); void nvmet_auth_sq_free(struct nvmet_sq *sq); +int nvmet_setup_dhgroup(struct nvmet_ctrl *ctrl, u8 dhgroup_id); bool nvmet_check_auth_status(struct nvmet_req *req); int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, unsigned int hash_len); @@ -709,6 +714,10 @@ static inline bool nvmet_has_auth(struct nvmet_ctrl *ctrl) { return ctrl->host_key != NULL; } +int nvmet_auth_ctrl_exponential(struct nvmet_req *req, + u8 *buf, int buf_size); +int nvmet_auth_ctrl_sesskey(struct nvmet_req *req, + u8 *buf, int buf_size); #else static inline int nvmet_setup_auth(struct nvmet_ctrl *ctrl) { From patchwork Thu Dec 2 15:23:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12652809 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5CAC433FE for ; Thu, 2 Dec 2021 15:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358947AbhLBP1k (ORCPT ); Thu, 2 Dec 2021 10:27:40 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:46534 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358949AbhLBP1d (ORCPT ); Thu, 2 Dec 2021 10:27:33 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id AAEE5218A8; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0gC+n5kGXiVK8Yv5wKRmS0VeNtwuQBXl4WzNOjTjRac=; b=ep4hOx+A1UcmEDhJ2hkJwCJRRxJLWySR0mjkjAqTBvlbj50CI7ezkkdrKp8NerDTJ8Jb9Y ntrAz9ZVcX6u/M/rs4xgSRDwDnfoZCtGYGjxqa3nAOMBMA24Pe2WHMfZKWjQrj6PWo0uP0 pEcITcRtoNbP+RcdYRlzDVVXqoi+c3w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638458648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0gC+n5kGXiVK8Yv5wKRmS0VeNtwuQBXl4WzNOjTjRac=; b=jbv4UHRUQ0hH43w8BMD7IwjgogvzSCOCYdCcvjYAtwz0FPjahBXdvHR3KPWxYUA0dcpEMt DTo96qzuWsX1zsAQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 9E9F9A3B95; Thu, 2 Dec 2021 15:24:08 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 5C9B55191E00; Thu, 2 Dec 2021 16:24:07 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke Subject: [PATCH 12/12] nvmet-auth: expire authentication sessions Date: Thu, 2 Dec 2021 16:23:58 +0100 Message-Id: <20211202152358.60116-13-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211202152358.60116-1-hare@suse.de> References: <20211202152358.60116-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Each authentication step is required to be completed within the KATO interval (or two minutes if not set). So add a workqueue function to reset the transaction ID and the expected next protocol step; this will automatically the next authentication command referring to the terminated authentication. Signed-off-by: Hannes Reinecke --- drivers/nvme/target/auth.c | 1 + drivers/nvme/target/fabrics-cmd-auth.c | 20 +++++++++++++++++++- drivers/nvme/target/nvmet.h | 1 + 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c index 28b41edf0e2b..a04425a1eb1c 100644 --- a/drivers/nvme/target/auth.c +++ b/drivers/nvme/target/auth.c @@ -215,6 +215,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl) void nvmet_auth_sq_free(struct nvmet_sq *sq) { + cancel_delayed_work(&sq->auth_expired_work); kfree(sq->dhchap_c1); sq->dhchap_c1 = NULL; kfree(sq->dhchap_c2); diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c index 402f387eff4c..dd021f0f7a7d 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -12,9 +12,22 @@ #include "nvmet.h" #include "../host/auth.h" +static void nvmet_auth_expired_work(struct work_struct *work) +{ + struct nvmet_sq *sq = container_of(to_delayed_work(work), + struct nvmet_sq, auth_expired_work); + + pr_debug("%s: ctrl %d qid %d transaction %u expired, resetting\n", + __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid); + sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE; + sq->dhchap_tid = -1; +} + void nvmet_init_auth(struct nvmet_ctrl *ctrl, struct nvmet_req *req) { /* Initialize in-band authentication */ + INIT_DELAYED_WORK(&req->sq->auth_expired_work, + nvmet_auth_expired_work); req->sq->authenticated = false; req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE; req->cqe->result.u32 |= 0x2 << 16; @@ -326,8 +339,13 @@ void nvmet_execute_auth_send(struct nvmet_req *req) req->cqe->result.u64 = 0; nvmet_req_complete(req, status); if (req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2 && - req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) + req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) { + unsigned long auth_expire_secs = ctrl->kato ? ctrl->kato : 120; + + mod_delayed_work(system_wq, &req->sq->auth_expired_work, + auth_expire_secs * HZ); return; + } /* Final states, clear up variables */ nvmet_auth_sq_free(req->sq); if (req->sq->dhchap_step == NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 789ff858fb4f..81061aa8c6d3 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -109,6 +109,7 @@ struct nvmet_sq { u32 sqhd; bool sqhd_disabled; #ifdef CONFIG_NVME_TARGET_AUTH + struct delayed_work auth_expired_work; bool authenticated; u16 dhchap_tid; u16 dhchap_status;