From patchwork Thu Dec 2 16:06:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653011 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 073D4C433EF for ; Thu, 2 Dec 2021 16:08:48 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-219-99URha6VPm-JjB7fc5Jr5g-1; Thu, 02 Dec 2021 11:08:46 -0500 X-MC-Unique: 99URha6VPm-JjB7fc5Jr5g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 730756415E; Thu, 2 Dec 2021 16:08:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5481160C05; Thu, 2 Dec 2021 16:08:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2DCC41809C89; Thu, 2 Dec 2021 16:08:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7ZP4006825 for ; Thu, 2 Dec 2021 11:07:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id C51D82166B3F; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFDC12166B26 for ; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D61E980A0AB for ; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-Xp5Z9ZbMOE-oQQ8jD7oL9Q-1; Thu, 02 Dec 2021 11:07:31 -0500 X-MC-Unique: Xp5Z9ZbMOE-oQQ8jD7oL9Q-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C97C02177B; Thu, 2 Dec 2021 16:07:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9007213E82; Thu, 2 Dec 2021 16:07:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cBXhIEHvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:29 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:41 +0100 Message-Id: <20211202160652.4576-2-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7ZP4006825 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck Since f42d918 ("multipathd: Remove dependency on systemd-udev-settle.service"), multipathd has no dependencies on udev any more. In reality, multipathd depends quite heavily on udev. multipathd startup succeeds indeed if udevd isn't running. Connecting to the udev monitor netlink socket works, too, and if udevd is started later on, multipathd will receive events over this socket. multipathd doesn't connect to the udev control socket, but it does attempt to trigger uevents using sysfs. For these events to be processed, the udev kernel socket must be listening. For that, it's sufficient to depend on systemd-udevd-kernel.socket, which will start udevd on demand if it isn't running. Signed-off-by: Martin Wilck --- multipathd/multipathd.service | 2 ++ 1 file changed, 2 insertions(+) diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service index 87cb534..1919b38 100644 --- a/multipathd/multipathd.service +++ b/multipathd/multipathd.service @@ -2,6 +2,8 @@ Description=Device-Mapper Multipath Device Controller Before=iscsi.service iscsid.service lvm2-activation-early.service Before=local-fs-pre.target blk-availability.service shutdown.target +Wants=systemd-udevd-kernel.socket +After=systemd-udevd-kernel.socket After=multipathd.socket systemd-remount-fs.service DefaultDependencies=no Conflicts=shutdown.target From patchwork Thu Dec 2 16:06:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12652997 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FA02C433EF for ; Thu, 2 Dec 2021 16:07:49 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-WFw4xlqAPLmL8iq6q0sl2g-1; Thu, 02 Dec 2021 11:07:46 -0500 X-MC-Unique: WFw4xlqAPLmL8iq6q0sl2g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 667E2839A43; Thu, 2 Dec 2021 16:07:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB7FE60C7F; Thu, 2 Dec 2021 16:07:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D0A74BB7C; Thu, 2 Dec 2021 16:07:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7Xdp006791 for ; Thu, 2 Dec 2021 11:07:33 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7914914582F1; Thu, 2 Dec 2021 16:07:33 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 746CD14582F0 for ; Thu, 2 Dec 2021 16:07:33 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 599CD185A79C for ; Thu, 2 Dec 2021 16:07:33 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-vTTz9QS0OTaS_LcAw5ivyQ-1; Thu, 02 Dec 2021 11:07:31 -0500 X-MC-Unique: vTTz9QS0OTaS_LcAw5ivyQ-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 693681FDFB; Thu, 2 Dec 2021 16:07:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CEDA13E82; Thu, 2 Dec 2021 16:07:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QPXQCELvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:30 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:43 +0100 Message-Id: <20211202160652.4576-4-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7Xdp006791 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 02/11] multipath-tools: generate abi without version script X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck The purpose of the "abi" makefile target is to detect ABI changes. If using the version script the way we do (bumping major or minor versions), abigail detects a completely different ABI with every bump. This makes it very difficult to figure out actual changes in the code. This patch fixes that by using "versionless version scripts" for ABI generation. These version scripts just list all exported symbols, using just a single dummy version string. This is better than using no version script at all, because only exported symbols will be compared, whereas without a version script we'd be comparing non-exported symbols, too. Signed-off-by: Martin Wilck --- Makefile.inc | 1 + libdmmp/Makefile | 2 +- libmpathcmd/Makefile | 13 +++++++++++-- libmpathpersist/Makefile | 15 ++++++++++++--- libmpathvalid/Makefile | 16 +++++++++++++--- libmultipath/Makefile | 13 +++++++++++-- 6 files changed, 49 insertions(+), 11 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 17071ef..b340f2a 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -79,6 +79,7 @@ GZIP = gzip -9 -c RM = rm -f LN = ln -sf INSTALL_PROGRAM = install +NV_VERSION_SCRIPT = $(VERSION_SCRIPT:%.version=%-nv.version) # $(call TEST_CC_OPTION,option,fallback) # Test if the C compiler supports the option. diff --git a/libdmmp/Makefile b/libdmmp/Makefile index c91f0c3..de61668 100644 --- a/libdmmp/Makefile +++ b/libdmmp/Makefile @@ -58,7 +58,7 @@ uninstall: $(RM) $(DESTDIR)$(pkgconfdir)/$(PKGFILE) clean: dep_clean - $(RM) core *.a *.o *.gz *.so *.so.* *.abi + $(RM) core *.a *.o *.gz *.so *.so.* *.abi $(NV_VERSION_SCRIPT) $(RM) docs/man/*.gz $(MAKE) -C test clean diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile index 5a7a6e9..72cab1e 100644 --- a/libmpathcmd/Makefile +++ b/libmpathcmd/Makefile @@ -15,7 +15,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT) $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ -Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) -abi: $(LIBS:%.so.0=%.abi) +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT) + @printf 'NOVERSION {\nglobal:\n' >$@ + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@ + @printf 'local:\n\t*;\n};\n' >>$@ + +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) + +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi) $(DEVLIB): $(LIBS) $(LN) $(LIBS) $@ @@ -33,7 +42,7 @@ uninstall: $(RM) $(DESTDIR)$(includedir)/mpath_cmd.h clean: dep_clean - $(RM) core *.a *.o *.so *.so.* *.gz *.abi + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT) include $(wildcard $(OBJS:.o=.d)) diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile index d76918f..1e6399d 100644 --- a/libmpathpersist/Makefile +++ b/libmpathpersist/Makefile @@ -3,7 +3,7 @@ include ../Makefile.inc SONAME = 0 DEVLIB = libmpathpersist.so LIBS = $(DEVLIB).$(SONAME) -VERSION_SCRIPT := libmpathpersist.version +VERSION_SCRIPT:= libmpathpersist.version CFLAGS += $(LIB_CFLAGS) -I$(multipathdir) -I$(mpathpersistdir) -I$(mpathcmddir) LDFLAGS += -L$(multipathdir) -L$(mpathcmddir) @@ -18,7 +18,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT) $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ -Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) -abi: $(LIBS:%.so.0=%.abi) +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT) + @printf 'NOVERSION {\nglobal:\n' >$@ + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@ + @printf 'local:\n\t*;\n};\n' >>$@ + +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) + +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi) $(DEVLIB): $(LIBS) $(LN) $(LIBS) $@ @@ -46,7 +55,7 @@ uninstall: $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB) clean: dep_clean - $(RM) core *.a *.o *.so *.so.* *.gz *.abi + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT) include $(wildcard $(OBJS:.o=.d)) diff --git a/libmpathvalid/Makefile b/libmpathvalid/Makefile index b579535..dce2610 100644 --- a/libmpathvalid/Makefile +++ b/libmpathvalid/Makefile @@ -15,10 +15,20 @@ OBJS = mpath_valid.o all: $(LIBS) $(LIBS): $(OBJS) $(VERSION_SCRIPT) - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) -Wl,--version-script=libmpathvalid.version + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) \ + -Wl,--version-script=$(VERSION_SCRIPT) $(LN) $(LIBS) $(DEVLIB) -abi: $(LIBS:%.so.0=%.abi) +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT) + @printf 'NOVERSION {\nglobal:\n' >$@ + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@ + @printf 'local:\n\t*;\n};\n' >>$@ + +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) + +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi) install: $(LIBS) $(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(syslibdir) @@ -33,7 +43,7 @@ uninstall: $(RM) $(DESTDIR)$(includedir)/mpath_valid.h clean: dep_clean - $(RM) core *.a *.o *.so *.so.* *.gz *.abi + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT) include $(wildcard $(OBJS:.o=.d)) diff --git a/libmultipath/Makefile b/libmultipath/Makefile index e8fd749..d4af1a5 100644 --- a/libmultipath/Makefile +++ b/libmultipath/Makefile @@ -81,7 +81,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT) $(DEVLIB): $(LIBS) $(LN) $(LIBS) $@ -abi: $(LIBS:%.so.0=%.abi) +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT) + @printf 'NOVERSION {\nglobal:\n' >$@ + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@ + @printf 'local:\n\t*;\n};\n' >>$@ + +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \ + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS) + +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi) ../tests/$(LIBS): $(OBJS) $(VERSION_SCRIPT) $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=`basename $@` \ @@ -101,7 +110,7 @@ uninstall: $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB) clean: dep_clean - $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h + $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h $(NV_VERSION_SCRIPT) include $(wildcard $(OBJS:.o=.d)) From patchwork Thu Dec 2 16:06:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653003 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 826B8C433EF for ; Thu, 2 Dec 2021 16:08:08 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-OhfyVH2mPJiZQwVwb3UFjA-1; Thu, 02 Dec 2021 11:08:05 -0500 X-MC-Unique: OhfyVH2mPJiZQwVwb3UFjA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20A4583DD23; Thu, 2 Dec 2021 16:08:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03A6619729; Thu, 2 Dec 2021 16:08:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D21FB4CA93; Thu, 2 Dec 2021 16:07:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7kjT006921 for ; Thu, 2 Dec 2021 11:07:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3B5761121314; Thu, 2 Dec 2021 16:07:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 365AC1121318 for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A554800882 for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-442-UQ9ScJRCPgypPv8KREHBWw-1; Thu, 02 Dec 2021 11:07:32 -0500 X-MC-Unique: UQ9ScJRCPgypPv8KREHBWw-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF5E91FDFC; Thu, 2 Dec 2021 16:07:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7571313E82; Thu, 2 Dec 2021 16:07:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uNmPGkLvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:30 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:44 +0100 Message-Id: <20211202160652.4576-5-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7kjT006921 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 03/11] multipath-tools: github abi workflow: don't fail on reference branch X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck The download action will always retreive the result of the last successful workflow on the reference branch. If the workflow has failed there (because of a difference to the previous workflow), the results won't be used. Thus don't fail on the reference branch, even if there are differences. Signed-off-by: Martin Wilck --- .github/workflows/abi.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/abi.yaml b/.github/workflows/abi.yaml index 53f10d4..0a40104 100644 --- a/.github/workflows/abi.yaml +++ b/.github/workflows/abi.yaml @@ -50,5 +50,5 @@ jobs: name: abi-test path: abi-test - name: fail - if: ${{ steps.compare.outcome == 'failure' }} + if: ${{ env.ABI_BRANCH != github.ref_name && steps.compare.outcome == 'failure' }} run: false From patchwork Thu Dec 2 16:06:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12652999 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D567C433EF for ; Thu, 2 Dec 2021 16:08:01 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-7A5W9jerN0SSuNDTb8yCqw-1; Thu, 02 Dec 2021 11:07:57 -0500 X-MC-Unique: 7A5W9jerN0SSuNDTb8yCqw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 388DC1966320; Thu, 2 Dec 2021 16:07:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 167315F4E9; Thu, 2 Dec 2021 16:07:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DBD2C1809C89; Thu, 2 Dec 2021 16:07:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7aLI006832 for ; Thu, 2 Dec 2021 11:07:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1E9BD4047279; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AB5F4047272 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1F54800141 for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-qa8clCY0MEy07Y7jmTuwZw-1; Thu, 02 Dec 2021 11:07:32 -0500 X-MC-Unique: qa8clCY0MEy07Y7jmTuwZw-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 010B2218A4; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BCF9F13E82; Thu, 2 Dec 2021 16:07:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gGAWLELvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:30 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:45 +0100 Message-Id: <20211202160652.4576-6-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7aLI006832 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 04/11] multipath-tools: github workflows: rebuild containers for rolling distros X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck For Debian "sid" and alpine, using a pre-built container makes no sense if this container is rebuilt only once every few months. Rebuild these containers during the test. Also, add Fedora rawhide, which is likely to ship the latest compilers. Wrt stable distributions, replace fedora-34 with fedora-35 and add Debian 11 (bullseye). Signed-off-by: Martin Wilck --- .github/workflows/native.yaml | 62 +++++++++++++++++++++++++++++++++-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/.github/workflows/native.yaml b/.github/workflows/native.yaml index 2bb1886..19c9e29 100644 --- a/.github/workflows/native.yaml +++ b/.github/workflows/native.yaml @@ -8,15 +8,17 @@ on: pull_request: jobs: - build-and-test: + stable: runs-on: ubuntu-20.04 strategy: matrix: - os: [buster, jessie, sid, alpine, fedora-34] + os: [buster, jessie, bullseye, fedora-35] arch: ['', '-i386'] exclude: - os: fedora-34 arch: '-i386' + - os: fedora-35 + arch: '-i386' container: mwilck/multipath-build-${{ matrix.os }}${{ matrix.arch }} steps: - name: checkout @@ -30,3 +32,59 @@ jobs: CC: clang run: make test + rolling: + runs-on: ubuntu-20.04 + strategy: + matrix: + os: ['debian:sid', 'alpine', 'fedora:rawhide'] + arch: ['amd64', 'i386'] + exclude: + - os: 'fedora:rawhide' + arch: 'i386' + container: ${{ matrix.arch }}/${{ matrix.os }} + steps: + - name: update + if: ${{ matrix.os == 'debian:sid' }} + run: apt-get update + - name: dependencies-debian + if: ${{ matrix.os == 'debian:sid' }} + run: > + apt-get install --yes -o APT::Immediate-Configure=0 + gcc clang make pkg-config + libdevmapper-dev + libreadline-dev + libaio-dev + libudev-dev + libjson-c-dev + liburcu-dev + libcmocka-dev + - name: dependencies-alpine + if: ${{ matrix.os == 'alpine' }} + run: > + apk add make gcc clang cmocka + musl-dev lvm2-dev libaio-dev readline-dev ncurses-dev eudev-dev + userspace-rcu-dev json-c-dev cmocka-dev + - name: dependencies-fedora + if: ${{ matrix.os == 'fedora:rawhide' }} + run: > + dnf install -y + make clang gcc pkgconfig + libaio-devel + device-mapper-devel + libselinux-devel + libsepol-devel + readline-devel + ncurses-devel + userspace-rcu-devel + json-c-devel + libcmocka-devel + - name: checkout + uses: actions/checkout@v1 + - name: build and test + run: make test + - name: clean + run: make clean + - name: clang + env: + CC: clang + run: make test From patchwork Thu Dec 2 16:06:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653015 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ACCFC433EF for ; Thu, 2 Dec 2021 16:08:55 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-488-PLw08FdAPVCQojelc59zwA-1; Thu, 02 Dec 2021 11:08:50 -0500 X-MC-Unique: PLw08FdAPVCQojelc59zwA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 089AD196633D; Thu, 2 Dec 2021 16:08:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE9686F950; Thu, 2 Dec 2021 16:08:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 889041809CB7; Thu, 2 Dec 2021 16:08:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7aT4006838 for ; Thu, 2 Dec 2021 11:07:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 80AFF492CA3; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CC9D492C38 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 647FB181E065 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-qzMf7eS4NQKBnjzFb-8nIQ-1; Thu, 02 Dec 2021 11:07:32 -0500 X-MC-Unique: qzMf7eS4NQKBnjzFb-8nIQ-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B66C218A8; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1016A13E82; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cAHOAUPvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:31 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:46 +0100 Message-Id: <20211202160652.4576-7-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7aT4006838 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 05/11] multipath tools: github workflows: add coverity workflow X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck Add a workflow that triggers a coverity static analysis scan. For now, this will only be done on a special branch called "coverity". Pushing to that branch will trigger the workflow. For this to work, 3 secrets need to be set in the Github repository: COVERITY_SCAN_EMAIL: the email address for coverity/synopsis account COVERITY_SCAN_TOKEN: the coverity / synopsis access token COVERITY_SCAN_PROJECT: the coverity project, e.g. mwilck/multipath-tools The workflow succeeds if upload of the coverity results was successful. The analysis result will be emailed to the given address. Reviewed-by: Benjamin Marzinski Signed-off-by: Martin Wilck --- .github/workflows/coverity.yaml | 51 +++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 .github/workflows/coverity.yaml diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml new file mode 100644 index 0000000..a8b56d4 --- /dev/null +++ b/.github/workflows/coverity.yaml @@ -0,0 +1,51 @@ +name: coverity +on: + push: + branches: + - coverity + +jobs: + upload-coverity-scan: + runs-on: ubuntu-20.04 + steps: + - name: checkout + uses: actions/checkout@v2 + - name: dependencies + run: > + sudo apt-get install --yes + gcc make pkg-config + libdevmapper-dev libreadline-dev libaio-dev libsystemd-dev + libudev-dev libjson-c-dev liburcu-dev libcmocka-dev + - name: download coverity + run: > + curl -o cov-analysis-linux64.tar.gz + --form token="$COV_TOKEN" + --form project="$COV_PROJECT" + https://scan.coverity.com/download/cxx/linux64 + env: + COV_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }} + COV_PROJECT: ${{ secrets.COVERITY_SCAN_PROJECT }} + - name: unpack coverity + run: | + mkdir -p coverity + tar xfz cov-analysis-linux64.tar.gz --strip 1 -C coverity + - name: build with cov-build + run: > + PATH="$PWD/coverity/bin:$PATH" + cov-build --dir cov-int make -O -j"$(grep -c ^processor /proc/cpuinfo)" + - name: pack results + run: tar cfz multipath-tools.tgz cov-int + - name: submit results + run: > + curl + --form token="$COV_TOKEN" + --form email="$COV_EMAIL" + --form file="@multipath-tools.tgz" + --form version="${{ github.ref_name }}" + --form description="$(git describe --tags --match "0.*")" + --form project="$COV_PROJECT" + https://scan.coverity.com/builds + env: + COV_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }} + COV_PROJECT: ${{ secrets.COVERITY_SCAN_PROJECT }} + COV_EMAIL: ${{ secrets.COVERITY_SCAN_EMAIL }} From patchwork Thu Dec 2 16:06:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653013 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AA71C433F5 for ; Thu, 2 Dec 2021 16:08:53 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-304-Uf-U7FTRPvGObO8QI4R8Rw-1; Thu, 02 Dec 2021 11:08:48 -0500 X-MC-Unique: Uf-U7FTRPvGObO8QI4R8Rw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6F18D83DD20; Thu, 2 Dec 2021 16:08:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56B1F5D9D5; Thu, 2 Dec 2021 16:08:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 338221809C8A; Thu, 2 Dec 2021 16:08:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7aPw006839 for ; Thu, 2 Dec 2021 11:07:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 866FE401E2A; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82AE7401E5F for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B589185A7B2 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-238-J3QU93kXOm6s2_TZc_8ctw-1; Thu, 02 Dec 2021 11:07:33 -0500 X-MC-Unique: J3QU93kXOm6s2_TZc_8ctw-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 91FFA218A9; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 59EB013E82; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yFjVE0PvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:31 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:47 +0100 Message-Id: <20211202160652.4576-8-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7aPw006839 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 06/11] multipath-tools: .mailmap: add some more entries X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck Signed-off-by: Martin Wilck --- .mailmap | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.mailmap b/.mailmap index 2c04cb0..14996ab 100644 --- a/.mailmap +++ b/.mailmap @@ -9,9 +9,13 @@ # # Please keep this list dictionary sorted. # +Bart Van Assche +Bart Van Assche Benjamin Marzinski Benjamin Marzinski Benjamin Marzinski bmarzins@sourceware.org +Chongyun Wu Wuchongyun +Chongyun Wu Christophe Varoqui Christophe Varoqui Christophe Varoqui @@ -20,5 +24,8 @@ Christophe Varoqui root Christophe Varoqui root Christophe Varoqui root Christophe Varoqui +Hannes Reinecke +Hannes Reinecke Martin Wilck Martin Wilck +wei huang wei.huang From patchwork Thu Dec 2 16:06:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653009 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95908C433F5 for ; Thu, 2 Dec 2021 16:08:48 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-GVbhWaZWM3Wj-uKbNIR2YQ-1; Thu, 02 Dec 2021 11:08:44 -0500 X-MC-Unique: GVbhWaZWM3Wj-uKbNIR2YQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E412764149; Thu, 2 Dec 2021 16:08:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8DC8196F2; Thu, 2 Dec 2021 16:08:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A1C054CA9B; Thu, 2 Dec 2021 16:08:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7ZT8006803 for ; Thu, 2 Dec 2021 11:07:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0B41D492C3B; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07996492C38 for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E2940181E065 for ; Thu, 2 Dec 2021 16:07:34 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-242-Rr-aV-0OONupUPrRfRu8DA-1; Thu, 02 Dec 2021 11:07:33 -0500 X-MC-Unique: Rr-aV-0OONupUPrRfRu8DA-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DB4F31FE01; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A0B8213E82; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oC0XJUPvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:31 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:48 +0100 Message-Id: <20211202160652.4576-9-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7ZT8006803 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 07/11] libmultipath: make orphan_paths() static X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck This function is only used in structs_vec.c Signed-off-by: Martin Wilck --- libmultipath/libmultipath.version | 1 - libmultipath/structs_vec.c | 2 +- libmultipath/structs_vec.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version index 0c5417d..68db95f 100644 --- a/libmultipath/libmultipath.version +++ b/libmultipath/libmultipath.version @@ -129,7 +129,6 @@ global: need_io_err_check; normalize_timespec; orphan_path; - orphan_paths; parse_prkey_flags; pathcount; path_discovery; diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c index 61f8e1b..67d3504 100644 --- a/libmultipath/structs_vec.c +++ b/libmultipath/structs_vec.c @@ -300,7 +300,7 @@ void orphan_path(struct path *pp, const char *reason) uninitialize_path(pp); } -void orphan_paths(vector pathvec, struct multipath *mpp, const char *reason) +static void orphan_paths(vector pathvec, struct multipath *mpp, const char *reason) { int i; struct path * pp; diff --git a/libmultipath/structs_vec.h b/libmultipath/structs_vec.h index 2a0cbd1..fb0e3b4 100644 --- a/libmultipath/structs_vec.h +++ b/libmultipath/structs_vec.h @@ -15,8 +15,6 @@ void __set_no_path_retry(struct multipath *mpp, bool check_features); #define set_no_path_retry(mpp) __set_no_path_retry(mpp, true) int adopt_paths (vector pathvec, struct multipath * mpp); -void orphan_paths(vector pathvec, struct multipath *mpp, - const char *reason); void orphan_path (struct path * pp, const char *reason); void set_path_removed(struct path *pp); From patchwork Thu Dec 2 16:06:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653021 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C5EAC433EF for ; Thu, 2 Dec 2021 16:10:48 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-106-klPxbDKhMFOs7qzFBDPEJA-1; Thu, 02 Dec 2021 11:10:43 -0500 X-MC-Unique: klPxbDKhMFOs7qzFBDPEJA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16D631006AA2; Thu, 2 Dec 2021 16:10:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F228060622; Thu, 2 Dec 2021 16:10:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE6894A707; Thu, 2 Dec 2021 16:10:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7Z59006806 for ; Thu, 2 Dec 2021 11:07:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3617E401E56; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32882401E2A for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A4A7106655A for ; Thu, 2 Dec 2021 16:07:35 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-514-kE9M5noFN66H0SCGBGuLqw-1; Thu, 02 Dec 2021 11:07:33 -0500 X-MC-Unique: kE9M5noFN66H0SCGBGuLqw-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2E4231FE02; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E879B13E82; Thu, 2 Dec 2021 16:07:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +NGpNkPvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:31 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:49 +0100 Message-Id: <20211202160652.4576-10-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7Z59006806 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 08/11] libmultipath: make update_pathvec_from_dm() static X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck This function is called only in structs_vec.c. Signed-off-by: Martin Wilck --- libmultipath/libmultipath.version | 1 - libmultipath/structs_vec.c | 2 +- libmultipath/structs_vec.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version index 68db95f..a693933 100644 --- a/libmultipath/libmultipath.version +++ b/libmultipath/libmultipath.version @@ -197,7 +197,6 @@ global: update_mpp_paths; update_multipath_strings; update_multipath_table; - update_pathvec_from_dm; update_queue_mode_add_path; update_queue_mode_del_path; ux_socket_listen; diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c index 67d3504..cb0ebae 100644 --- a/libmultipath/structs_vec.c +++ b/libmultipath/structs_vec.c @@ -99,7 +99,7 @@ static bool guess_mpp_wwid(struct multipath *mpp) * - may set pp->wwid and / or mpp->wwid * - calls pathinfo() on existing paths is pathinfo_flags is not 0 */ -bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp, +static bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp, int pathinfo_flags) { int i, j; diff --git a/libmultipath/structs_vec.h b/libmultipath/structs_vec.h index fb0e3b4..d33fe98 100644 --- a/libmultipath/structs_vec.h +++ b/libmultipath/structs_vec.h @@ -19,8 +19,6 @@ void orphan_path (struct path * pp, const char *reason); void set_path_removed(struct path *pp); int verify_paths(struct multipath *mpp); -bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp, - int pathinfo_flags); int update_mpp_paths(struct multipath * mpp, vector pathvec); int update_multipath_strings (struct multipath *mpp, vector pathvec); void extract_hwe_from_path(struct multipath * mpp); From patchwork Thu Dec 2 16:06:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653001 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AC96C433F5 for ; Thu, 2 Dec 2021 16:08:06 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-uenbbcCAOjWixi9cSkGyEA-1; Thu, 02 Dec 2021 11:08:02 -0500 X-MC-Unique: uenbbcCAOjWixi9cSkGyEA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA70A10144E1; Thu, 2 Dec 2021 16:07:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1E3245D62; Thu, 2 Dec 2021 16:07:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8A83D4BB7C; Thu, 2 Dec 2021 16:07:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7gWv006911 for ; Thu, 2 Dec 2021 11:07:42 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3929A401E2D; Thu, 2 Dec 2021 16:07:42 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34F5D401E5D for ; Thu, 2 Dec 2021 16:07:42 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D8CA181E071 for ; Thu, 2 Dec 2021 16:07:42 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-twzNecYcPOmtAGEpoELK2A-1; Thu, 02 Dec 2021 11:07:34 -0500 X-MC-Unique: twzNecYcPOmtAGEpoELK2A-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7772B212C6; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C37713E82; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eFOMDETvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:32 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:50 +0100 Message-Id: <20211202160652.4576-11-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7gWv006911 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 09/11] libmultipath: remove recv_packet_from_client() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck This function became unused after the late uxlsnr patches. Signed-off-by: Martin Wilck --- libmultipath/libmultipath.version | 1 - libmultipath/uxsock.c | 5 ----- libmultipath/uxsock.h | 6 ------ 3 files changed, 12 deletions(-) diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version index a693933..941bd8f 100644 --- a/libmultipath/libmultipath.version +++ b/libmultipath/libmultipath.version @@ -140,7 +140,6 @@ global: _print_multipath_topology; pthread_cond_init_mono; recv_packet; - recv_packet_from_client; reinstate_paths; remember_wwid; remove_map; diff --git a/libmultipath/uxsock.c b/libmultipath/uxsock.c index 0ccd1fa..2135476 100644 --- a/libmultipath/uxsock.c +++ b/libmultipath/uxsock.c @@ -128,8 +128,3 @@ int recv_packet(int fd, char **buf, unsigned int timeout) { return _recv_packet(fd, buf, timeout, 0 /* no limit */); } - -int recv_packet_from_client(int fd, char **buf, unsigned int timeout) -{ - return _recv_packet(fd, buf, timeout, _MAX_CMD_LEN); -} diff --git a/libmultipath/uxsock.h b/libmultipath/uxsock.h index 8e7401d..e3d28cf 100644 --- a/libmultipath/uxsock.h +++ b/libmultipath/uxsock.h @@ -5,9 +5,3 @@ int recv_packet(int fd, char **buf, unsigned int timeout); #define _MAX_CMD_LEN 512 -/* - * Used for receiving socket command from untrusted socket client where data - * size is restricted to 512(_MAX_CMD_LEN) at most. - * Return -EINVAL if data length requested by client exceeded the _MAX_CMD_LEN. - */ -int recv_packet_from_client(int fd, char **buf, unsigned int timeout); From patchwork Thu Dec 2 16:06:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653017 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1E0FC433FE for ; Thu, 2 Dec 2021 16:08:56 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-353-7q2pR9ZmNoeBRrCgZoy0Lg-1; Thu, 02 Dec 2021 11:08:54 -0500 X-MC-Unique: 7q2pR9ZmNoeBRrCgZoy0Lg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8560A64A8E; Thu, 2 Dec 2021 16:08:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64AC25F4E7; Thu, 2 Dec 2021 16:08:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B9B74CA93; Thu, 2 Dec 2021 16:08:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7dmg006894 for ; Thu, 2 Dec 2021 11:07:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id B2F0B14582F1; Thu, 2 Dec 2021 16:07:39 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEE9114582F0 for ; Thu, 2 Dec 2021 16:07:39 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 96BAE801212 for ; Thu, 2 Dec 2021 16:07:39 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-176-4SVpD5ocOsWBveYeM3uRyA-1; Thu, 02 Dec 2021 11:07:34 -0500 X-MC-Unique: 4SVpD5ocOsWBveYeM3uRyA-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BE1D02177B; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8526A13E82; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YF9yHkTvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:32 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:51 +0100 Message-Id: <20211202160652.4576-12-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7dmg006894 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 10/11] libmultipath.version: drop some unused symbols X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck Remove some symbols that aren't used any more, and move symbols "only" used by checkers / prioritizers to their respective places in the file (this helps assessing which symbols are used). Signed-off-by: Martin Wilck --- libmultipath/libmultipath.version | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version index 941bd8f..7f845ed 100644 --- a/libmultipath/libmultipath.version +++ b/libmultipath/libmultipath.version @@ -48,7 +48,6 @@ global: checker_clear_message; checker_disable; checker_enable; - checker_is_sync; checker_message; checker_name; checker_state_name; @@ -209,10 +208,13 @@ global: verify_paths; /* checkers */ + checker_is_sync; sg_read; + start_checker_thread; /* prioritizers */ get_asymmetric_access_state; + get_next_string; get_prio_timeout; get_target_port_group; get_target_port_group_support; @@ -234,7 +236,6 @@ global: /* added in 2.1.0 */ libmp_dm_task_run; - cleanup_mutex; /* added in 2.2.0 */ libmp_get_multipath_config; @@ -257,15 +258,10 @@ global: dm_prereq; skip_libmp_dm_init; - /* added in 4.3.0 */ - start_checker_thread; - /* added in 4.4.0 */ - get_next_string; /* added in 4.5.0 */ get_vpd_sgio; - trigger_partitions_udev_change; /* added in 7.0.0 */ cleanup_charp; @@ -276,7 +272,6 @@ global: append_strbuf_str; get_strbuf_len; get_strbuf_str; - steal_strbuf_str; fill_strbuf; print_strbuf; truncate_strbuf; From patchwork Thu Dec 2 16:06:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 12653023 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C2E0C433F5 for ; Thu, 2 Dec 2021 16:10:51 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-3zoQ17NTNpC68SRNEkrIzA-1; Thu, 02 Dec 2021 11:10:46 -0500 X-MC-Unique: 3zoQ17NTNpC68SRNEkrIzA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D4C010144E3; Thu, 2 Dec 2021 16:10:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 144CD10016F5; Thu, 2 Dec 2021 16:10:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C3FD84A708; Thu, 2 Dec 2021 16:10:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2G7aBa006837 for ; Thu, 2 Dec 2021 11:07:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 671AE492C3B; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63403492C38 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B1F7185A7B2 for ; Thu, 2 Dec 2021 16:07:36 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-GeumzkesMZ6dtrVG3pLfVg-1; Thu, 02 Dec 2021 11:07:34 -0500 X-MC-Unique: GeumzkesMZ6dtrVG3pLfVg-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 12FA91FDFB; Thu, 2 Dec 2021 16:07:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CCBE913E82; Thu, 2 Dec 2021 16:07:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iI/vL0TvqGGnEgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 16:07:32 +0000 From: mwilck@suse.com To: Christophe Varoqui , Benjamin Marzinski Date: Thu, 2 Dec 2021 17:06:52 +0100 Message-Id: <20211202160652.4576-13-mwilck@suse.com> In-Reply-To: <20211202160652.4576-1-mwilck@suse.com> References: <20211202160652.4576-1-mwilck@suse.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1B2G7aBa006837 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com, Martin Wilck Subject: [dm-devel] [PATCH 11/11] libmultipath.version: sort symbols X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Martin Wilck Give up the habit of indicating in which library version the symbols were added, which has no real benefit. The only "sections" that are kept are those listing symbols that are only used by dlopen'd .so files. Signed-off-by: Martin Wilck --- libmultipath/libmultipath.version | 81 +++++++++++-------------------- 1 file changed, 28 insertions(+), 53 deletions(-) diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version index 7f845ed..9c7ffa7 100644 --- a/libmultipath/libmultipath.version +++ b/libmultipath/libmultipath.version @@ -43,8 +43,10 @@ global: alloc_path_layout; alloc_path_with_pathinfo; alloc_strvec; + append_strbuf_str; change_foreign; check_alias_settings; + check_daemon; checker_clear_message; checker_disable; checker_enable; @@ -52,7 +54,9 @@ global: checker_name; checker_state_name; check_foreign; + cleanup_charp; cleanup_lock; + cleanup_ucharp; close_fd; coalesce_paths; convert_dev; @@ -75,6 +79,7 @@ global: dm_is_mpath; dm_mapname; dm_map_present; + dm_prereq; dm_queue_if_no_path; dm_reassign; dm_reinstate_path; @@ -103,16 +108,21 @@ global: free_pathvec; free_strvec; get_monotonic_time; + get_multipath_config; get_multipath_layout; get_path_layout; get_pgpolicy_id; get_refwwid; get_state; + get_strbuf_len; + get_strbuf_str; get_udev_device; get_uid; get_used_hwes; + get_vpd_sgio; group_by_prio; init_checkers; + init_config; init_foreign; init_prio; io_err_stat_handle_pathfail; @@ -120,11 +130,18 @@ global: is_quote; libmp_dm_task_create; libmp_get_version; + libmp_get_multipath_config; + libmp_dm_task_run; + libmp_put_multipath_config; libmp_udev_set_sync_support; + libmp_verbosity; + libmultipath_exit; + libmultipath_init; load_config; log_thread_reset; log_thread_start; log_thread_stop; + logsink; need_io_err_check; normalize_timespec; orphan_path; @@ -137,7 +154,9 @@ global: print_all_paths; print_foreign_topology; _print_multipath_topology; + print_strbuf; pthread_cond_init_mono; + put_multipath_config; recv_packet; reinstate_paths; remember_wwid; @@ -147,6 +166,7 @@ global: remove_wwid; replace_wwids; reset_checker_classes; + reset_strbuf; select_all_tg_pt; select_action; select_find_multipaths_timeout; @@ -161,7 +181,9 @@ global: setup_map; setup_thread_attr; should_multipath; + skip_libmp_dm_init; snprint_blacklist_report; + __snprint_config; snprint_config; snprint_devices; snprint_foreign_multipaths; @@ -185,13 +207,17 @@ global: sysfs_attr_set_value; sysfs_get_size; sysfs_is_multipathed; + timespeccmp; timespecsub; trigger_paths_udev_change; + truncate_strbuf; + udev; uevent_dispatch; uevent_get_dm_str; uevent_get_env_positive_int; uevent_is_mpath; uevent_listen; + uninit_config; update_mpp_paths; update_multipath_strings; update_multipath_table; @@ -213,6 +239,7 @@ global: start_checker_thread; /* prioritizers */ + fill_strbuf; get_asymmetric_access_state; get_next_string; get_prio_timeout; @@ -223,6 +250,7 @@ global: libmp_nvme_identify_ns; log_nvme_errcode; nvme_id_ctrl_ana; + set_wakeup_fn; snprint_host_wwnn; snprint_host_wwpn; snprint_path_serial; @@ -234,59 +262,6 @@ global: free_scandir_result; sysfs_attr_get_value; - /* added in 2.1.0 */ - libmp_dm_task_run; - - /* added in 2.2.0 */ - libmp_get_multipath_config; - get_multipath_config; - libmp_put_multipath_config; - put_multipath_config; - init_config; - uninit_config; - - /* added in 2.3.0 */ - udev; - logsink; - libmultipath_init; - libmultipath_exit; - - /* added in 4.1.0 */ - libmp_verbosity; - - /* added in 4.2.0 */ - dm_prereq; - skip_libmp_dm_init; - - /* added in 4.4.0 */ - - /* added in 4.5.0 */ - get_vpd_sgio; - - /* added in 7.0.0 */ - cleanup_charp; - cleanup_ucharp; - - /* added in 8.1.0 */ - reset_strbuf; - append_strbuf_str; - get_strbuf_len; - get_strbuf_str; - fill_strbuf; - print_strbuf; - truncate_strbuf; - - /* added in 8.2.0 */ - check_daemon; - - /* added in 9.1.0 */ - timespeccmp; - - /* added in 10.0.0 */ - set_wakeup_fn; - - /* added in 10.1.0 */ - __snprint_config; local: *; };