From patchwork Fri Dec 3 12:03:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12655003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B5CFC433F5 for ; Fri, 3 Dec 2021 12:04:01 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237480.411876 (Exim 4.92) (envelope-from ) id 1mt7I2-0002Un-Hm; Fri, 03 Dec 2021 12:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237480.411876; Fri, 03 Dec 2021 12:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7I2-0002Ug-Ei; Fri, 03 Dec 2021 12:03:46 +0000 Received: by outflank-mailman (input) for mailman id 237480; Fri, 03 Dec 2021 12:03:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7I1-0002ST-DU for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:03:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1013ebcd-5431-11ec-976b-d102b41d0961; Fri, 03 Dec 2021 13:03:44 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-29-Bog92kQBPyaBRnbAxCAPLw-1; Fri, 03 Dec 2021 13:03:43 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec 2021 12:03:41 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021 12:03:41 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:20b:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:03:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1013ebcd-5431-11ec-976b-d102b41d0961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638533024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fuphnGsPrrpPYXSMHIcEABMTB/3qmzYatmHPuIsrm+E=; b=AjypZCwIacqcN3CuRRm65uv+u0/0I+iXXJ19sKuftldKJ9BYPiXeOQJiWee2nbqMxBhoEj 4z8r8lVCem0GmTUahXclFATA5qiCY6TnQokt3ZUzTwYnZDateT1T418eFI/JDYHCnzVFRS 50rfYFUxuKVeXDixoIdsSHCsVsjSpkY= X-MC-Unique: Bog92kQBPyaBRnbAxCAPLw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MmuV8VC2L4FoV4b/VDdNIFRLt5iFAwkl0kpn+WRgcBxuuzHfVOHH1KDcBO+62MT+f4lFaU07tq/y/U586BobRiBBb3rk4cpuDhWzdxk8dE0JCsH1yVGHKhKequOE+ioI6FLFj2Gm229PBAmXRKuyHLPVeUQmceIaezMYD1wavAndI8xMrBzt+UBmfkgTV2X4LimU1W8M8LNUH/08vnZtXywBbEtFeCzKMLTVu2JPTjn1AWtygOqYYm35S6Ll6GnjlQfFgM74QwVUW6NpjtIkFHjKEOVe4Ax/HoJ+UDNo7nq9YqFxk3QoVguVEvtt3P9Cl7rIq7M0NhDy6GZ1G9HzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fuphnGsPrrpPYXSMHIcEABMTB/3qmzYatmHPuIsrm+E=; b=GimHJ6/i3ROjsM4Jq/I/QdJOeYqGo8PlPgxZur6QvyNGIY+yszG4fZ2V+eXSTc898cLofLhC4MrF1fvEMFqCK0pJEtSre327TSX4j7TJTvlMqGAm5MC7/HDM0TrAeV7HQKSQ4BVTAExLFvJPhSH6AQWZ20/eKtZmiJaoiVCY/oLho2+tJgPhWjZbSq+wCjFw+FNSq3SPBCD/zky257dZF3rBK5wiAIySsSOT4LUVyzg4eiwoppyU7xcGrVSF9KtOgd8Ig67iUwXErSIanDkL1GW89oljCDgy1LRCBoe1X4RRgWzoKSRNZHXQEN2oW53vcLtzgvjriRm/pdhzzLDGQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22325915-c51c-a091-59e2-e6e214576f80@suse.com> Date: Fri, 3 Dec 2021 13:03:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH 1/5] perfc: conditionalize credit/credit2 counters Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> X-ClientProxiedBy: AM6PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:20b:c0::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1a81c85-d218-451b-f80d-08d9b654f269 X-MS-TrafficTypeDiagnostic: VI1PR04MB2958: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Dj7w4jnu5FJAQimA1BSCsu/wfRpyTlcUNDvsdLQpqZ1AafJOVTFT86Od7a1wNIg7kXaJ83Hpe0rHRdRuCJlV+yw12bn59+CqwS8ApS+zh0hEhEGlhWV4M1dM8dTT49qx+6zHyBHMyanK1s9fw4ZvH8MBZUU2l67nHopnNfqzlb8wwyLQIA1lM0aMyYp0V5mvU4vMjJM9KJTBB24cE6AkR3bmzIYy9HcsUYT+nejJRYtfwlXHxaevGcX2pVeqZHv+1cOzFRZX3zSS191ycedmMSPGKUgnJPzNBtL1JT4KoZP+C+NxIB4Ac+1FWODNiMGyeLlRK2/GRZwABL0tDCpHPHpV71w4fVgs0qZMpLlpndEt7AXIc8Z4aIR3B4/8JS7MtvJ0gqcVm2yapy9aCkNvn+tqf95sNH+QWjQvsuctqZWWaiJ36WLpItk2Jtt+AM/uNamXOsVHdmKJII6LaZ76q2FpR8wm/gCIDpnsk+0yiSetsuVvmBFObWV7vakqrgGZ6IJNOjNKEL4ssD7tOvaw3hEZz1zXaVJzzyCR/PTonoTpGCmVGcuLvr19WKI5bIHMER/56Qm/oEmN2/ts86sWv5ZUs4IHQrso3jKVc08+rW4SRd6yaITzhG5D6tlaWTHSoHEWjP7UviJRe7UV8Guf2fru3LLqTXhQrR4ArTtTrEgF3gcx9bEXVUicZIZzodJbsSPcm5iBSVaHLCjVYvF4b6GYcFgN0z3pyCbmf1B0DI4B3IZxXdSNqYS2zs3PMRT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(83380400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?z1MisFIg7zjhtzpyWcKwK3VkSmEO?= =?utf-8?q?FJ1UvgFPEyCRXWiCLSWTOYIfyAXC50pjIGtxflrhBNprfMR9Mp6ZDOf6oScQMD1fv?= =?utf-8?q?SDgiTIgqYf2saGilQ3punSSXlrcYOfx58E1qBl5Ke0NDFZ51MuRLOFBHEjpjipVGy?= =?utf-8?q?yQkT34Hrc9TLYB5GTjSBdXKZZ5pGSHUgRSa2zkHk0o/ldi4dEG5g2Q0gZSFJylr0o?= =?utf-8?q?e/IFGijAOgCXaVjeH8jaZiTpfHEko+6QMcJlYj4JkjUJ34rRD9e/PXaAZFoOS0jZD?= =?utf-8?q?BzICCx0g/P4HCg90PbKlwweGbd1azcS7t/7zpPaXLy0rfumyodH3DhSDRS+UMwiLl?= =?utf-8?q?tW2UQzSNfqI7DmLoaDh7UH0NJRY8aOC4jOvkTOjhEykbnpvr8ti84eT4UovrViISw?= =?utf-8?q?IHc3vg0g0h4nVvryaW4miYwM6rYSX/V5bEwLAKl348bfuFqvL2nTrydv8nI81xupr?= =?utf-8?q?FIlhjDHowlLAgfdwWoUI+I6SgjV/JyjHqdl/TpE8juFj+EwEJK08Hxfdzc2AtO8Au?= =?utf-8?q?2E4ADgCPJIj4P9P4wAVcDBfP42mWYcnwp56yV/p64gwOZ7ipp6jBKwom2jmidhnfy?= =?utf-8?q?tun19m6vZn1SGF513UiGiu0a437+MHiOA/Z6f4qqgi3x/7YwFtLGsnQ/+gWqbPxWZ?= =?utf-8?q?vNqr/g6WYQYYTri7t0k1MyNFl4eIdtiiPwlxSH5i9nOm4sip3fZnVON5g901f5Y0W?= =?utf-8?q?EOXVwYT+LvZu5z+ug0JZa+qnguR2DV1CayqTdNEq7NfkoLfTGUixj4CzgmRSgKKyb?= =?utf-8?q?6y9oS35OPA0DoR+lHswcuN0zbF0xVlbngR1cSM2Xn5lT4WXBFYH7EcIKJCkL9zImH?= =?utf-8?q?VJguAeQKyyhhYN41ltQbvYZdvvK35MVB09Y5cwD9FXqvpoWUw20LS3ZQPGBw8MqCu?= =?utf-8?q?F0Wk+bBiXWuy/Qruhu5LajmCfRHEB6ntfffbYet5ZRbhrodW+dKiea5hidQ5aWJnQ?= =?utf-8?q?dI3RfK+qWxeHsS8icIBwuL/VZ3v56q/lRlXc07qhbyK9itxLw8oqLRclO7lKPFugR?= =?utf-8?q?cjSkf1RTriYWJpI45w6ioX6XtLjAEomcaaNOystfmUh4UZVMpV9DpAxeKBTvblMWI?= =?utf-8?q?+VVp6BYZBlqa2akY5ixe2OHgTCsVjpOWHyoJsM4IZK/VEnbiELQNz02qjJwMr771B?= =?utf-8?q?F3TIrnBzWyY/7FbRfK7Y6GZdZYRB/3rJUgKwTnkGjggeLPjzuraV3DPlQwH+vi6ru?= =?utf-8?q?2MT9GxwCsc9mzT1kQy+2KCmbaIVkxYD0vRSvjAyvODGfLGY6RLJZZmlkQonLMj4Uv?= =?utf-8?q?4bsl9MfxkQczZyCNTj+4fvvw1+vXh7opdXxf5sgcq84cfZtqB9to9FeD1fXuDT0lm?= =?utf-8?q?mfJyCJnmZNDmAKPtaKez4nC2tlnySArsLBOT2o0Xol0/2pyieBh4Vas+2YFBQLxd7?= =?utf-8?q?GKmvlOrLKRczEeZK/yenPYBqmkBGzadr9Cz5sQVsplcAP7Yt3AMQ8BFqb3zGVRHXE?= =?utf-8?q?RXxNGzet8D2AZnG2y4Ts92kSLhhj83pNFUCe51Ds9FmYZq8Am7/6/PYAFiVdSgGTE?= =?utf-8?q?5EMmigVW0AGkcEBklRwXKcpJicIkpPCLPVfm9+5E5HJJF58ndWSzG9U=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1a81c85-d218-451b-f80d-08d9b654f269 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:03:41.1124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8hdu8D4Y1s9pcGvio7y3ZwnjyY2/IVqTLlysCORLki+BAfHqUhsint0CRRvm/Xl/D+ogny306MKmChfUR85PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958 There's no point including them when the respective scheduler isn't enabled in the build. Signed-off-by: Jan Beulich Reviewed-by: Luca Fancellu --- a/xen/include/xen/perfc_defn.h +++ b/xen/include/xen/perfc_defn.h @@ -37,6 +37,7 @@ PERFCOUNTER(tickled_busy_cpu, "sch PERFCOUNTER(unit_check, "sched: unit_check") /* credit specific counters */ +#ifdef CONFIG_SCHED_CREDIT PERFCOUNTER(delay_ms, "csched: delay") PERFCOUNTER(acct_run, "csched: acct_run") PERFCOUNTER(acct_no_work, "csched: acct_no_work") @@ -58,8 +59,10 @@ PERFCOUNTER(migrate_queued, "csc PERFCOUNTER(migrate_running, "csched: migrate_running") PERFCOUNTER(migrate_kicked_away, "csched: migrate_kicked_away") PERFCOUNTER(unit_hot, "csched: unit_hot") +#endif /* credit2 specific counters */ +#ifdef CONFIG_SCHED_CREDIT2 PERFCOUNTER(burn_credits_t2c, "csched2: burn_credits_t2c") PERFCOUNTER(acct_load_balance, "csched2: acct_load_balance") PERFCOUNTER(upd_max_weight_quick, "csched2: update_max_weight_quick") @@ -77,6 +80,7 @@ PERFCOUNTER(credit_reset, "csc PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu") PERFCOUNTER(tickled_cpu_overwritten,"csched2: tickled_cpu_overwritten") PERFCOUNTER(tickled_cpu_overridden, "csched2: tickled_cpu_overridden") +#endif PERFCOUNTER(need_flush_tlb_flush, "PG_need_flush tlb flushes") From patchwork Fri Dec 3 12:04:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12655005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC855C433EF for ; Fri, 3 Dec 2021 12:04:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237487.411886 (Exim 4.92) (envelope-from ) id 1mt7Ij-00033p-Qc; Fri, 03 Dec 2021 12:04:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237487.411886; Fri, 03 Dec 2021 12:04:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7Ij-00033i-Nd; Fri, 03 Dec 2021 12:04:29 +0000 Received: by outflank-mailman (input) for mailman id 237487; Fri, 03 Dec 2021 12:04:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7Ih-0002qC-Rk for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:04:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29a564c5-5431-11ec-b1df-f38ee3fbfdf7; Fri, 03 Dec 2021 13:04:27 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-LR79iWxJNseilWv7fZIBzQ-1; Fri, 03 Dec 2021 13:04:26 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec 2021 12:04:25 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021 12:04:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:20b:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend Transport; Fri, 3 Dec 2021 12:04:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29a564c5-5431-11ec-b1df-f38ee3fbfdf7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638533067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3+yaC36DqlsYgMBtQOA6Ygvl1IDjxBnVmeHuhg98YSw=; b=CvWZPOSsPsq7fU+h4k3ERFJ2VYiDRXcxCj8J7L2wy/d/1U3eYuaRHIhD+Io8/+IrLDsRuM 3E2yFvIOS4ArpWubtHUhKXVNjfkgAbcRH0gIitNTNisHwA10QbUFGCq/yzXBAFK7qQYGmZ USDn+XZH/m8kghIloZAnbahFTPL4VEg= X-MC-Unique: LR79iWxJNseilWv7fZIBzQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kMxaTo5j16RN5X8zgqO22CAtF9pOAKIXToGkYzxHYY5mp9jvuYdmke0CTrCQoaG2Z5wO7hBADLB+wX8kytYvjbpkIGDogu6OZmsM4ASZ0vgAZEMXlgaEJHgxWc3FqYkPaAiF9o4MAQuesTqOg9HvEjW4b/qQ4VELGElkRyWcwyig8uyQ0aE7nQRyd/XsqaT7QTp7PtFsHNwb/MywSAMxBzxWrj4h8L8yOe3oEDKIbj0XqC97WL1zI3iHtXBATVfbaxfyYe5GBPiGqcScH0h48n3G/xBHRzth9GESveQesAZQxG8VKyAydcjSysmUd/sUjZwq+QKmbxgQgooVqDoGew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+yaC36DqlsYgMBtQOA6Ygvl1IDjxBnVmeHuhg98YSw=; b=BNsB2S1hDC+n1GTCnC9+W+sqdG2R6CvrxPHlsrjEWTOZR6Q3ScDm2mLNTu0e+2VZgYKIs7FOknFzA4dCUF9rmpwECS7qmX0vZuvHxdiemFEcf39j+z9lHHov1dNFJg/CeEkjxpu5Cx7NRJOzW1ui/Qlt510NWaLbJUL5nXtiNuJMvWuOKdENL4fpnIKp5MOUbFV4RfT5q4Ys7B5uI4a9bo36/uX8Y2XjrN8Dvne49/3CllqzIyLAbp3vQ1wHYJJbNVrCCd32GVW5VuJvgVaHhm8GIsiPxT8oEcCwrqppwa8jzynexi3QFTCZ/j7bqiBvvF21xXycWdoyiJQgL/z8NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 3 Dec 2021 13:04:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH 2/5] x86/perfc: conditionalize HVM and shadow counters Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?utf-8?q?R?= =?utf-8?q?oger_Pau_Monn=C3=A9?= References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> X-ClientProxiedBy: AM6PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:20b:c0::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83757df3-360a-42a3-f0a6-08d9b6550ca2 X-MS-TrafficTypeDiagnostic: VI1PR04MB2958: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: duvvBCEKiXprorkxaxK+fmynmWcqjILkC1CRV8IYljMmwIyS9DCD+7cru5Ivv0dpgqiGOEajLeAg/QZAfhN5ZqF73VuX5hMPI0TdM4GR0Gkin+T2dQ4+7vGlcs3vmp3ZqwWnZ2fBuHVFqSssfKjQHwWZal82GNV/2ce0FNDETsnG1cINor6SAETOrwJUYYODy02/t5CeIla0PwooUYVcb/2A9ok0Gnbpm6RYvBhOtexHyEUPAq3sNBSBcRBYfVk0GMd6dygR3C4akwqqX+7nQLWa1hD4D51ZJV8vZlPM8aXnEgjzGWe6xY4ZwF50sRdLMNBGWmnCReIBUyLpS0J66NSktnqsRi1fd2n9bZ+rBgjxMhOtJ/t+EkHe/3wOJ+uh3kwhiM6t3u89RFEVa304lwmX8/3Frlta5w/bV4EMrRsF3WWMfnvrq67XiWwg4ig8rNs+gl+edgJkaJajKZocGOjpQn6TFCj7QSjBHbjIkmJl/eUSDKJ2mhmUHN4jpotbQdIVfRrmLQ30WuxxwqM34YrboiYYarKDGuljm6rQsRaypNJTeV/1x3ahJXCbvdd/4NdF6vdaVDCPN1b5PpulGJIRL+/d7SJ8FQCFpYPY1PqPR5tAXvTpbWZL4JJeVHniBzO1eqsLbgvLC/rJOul/jIjQjNBvzHOvTqkr0OeKApV6rVRY1hU5FQpiKNqqdXh6wPhbrtOlxIwTYOltys1FKtzCbzZ/BV4fUua3u1M5xKXVw1VcJ0f8MPwgC16++0RF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(6666004)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?EEyh33gaM7eTlUP57zshKtW1OQ/z?= =?utf-8?q?ZRhDYDaZH3KrcSVq9wOZduZaNnewN73HoZD3NCRvE17aity2MmzVA6Kq5hydJv9ll?= =?utf-8?q?hiXQtefFed5CuFIDYdKGpTPZ0gL3DQRz6IKRH2g+91nnG20tfLX7mwi9uDlLdtAqb?= =?utf-8?q?7tiTdmo4TAGD/RE/1erotF44//3lo3O5Hs4pTQu4AB/6dKiHi0iFhwuMaI5Sq9n5m?= =?utf-8?q?DZpYvlzDTJ+3jz65fwJSn5VjfSm3jbqfaRAOTRH1lIYefoacA/2S83P4NGtvNOpFk?= =?utf-8?q?c9opbB/ZCcrcl8J8gUrFv0YHu1XkmQYTamcPMwDiVd1Elx5QQMnJO41xkMT4wJ7lj?= =?utf-8?q?EbdMyVuXQZI74h8llohLGSgZDCRivPZOWywk8zWSWv22gs9thpQYcyYeohrwc3j1H?= =?utf-8?q?ecHjZq5cHRlVlnm7Sv90wIjY9Q6king8fF/lv6DwNvCy9EtBPtJR9xqmD5rinG3IU?= =?utf-8?q?C35JVR7zdTnJ+cLkLvxurOpo91frjaam2mXccd3m5tH5EAvN+EmH9qYPzQpZnYpIi?= =?utf-8?q?6hmEvyMjfoQc7mqO78vNy6bC74ssqPxCB4nJ/SOapr2Z184t8k2ukOPw7vIX0VghL?= =?utf-8?q?wWZWE45dFbjubznYVoJ7IF4MGqtQmtPs7j5/UkG6w0bzDpmKxgSXb/6HPvee5CfwS?= =?utf-8?q?eEo4ECj1ZfTihi5vFTBhNuY2Z082V6UkUfd3B/gzl1oSRhl2uwlMsH/F3xGHHHCKO?= =?utf-8?q?7TUlzVji+kdaxu04RMgatbiHrbJm2xg2cBJJpYHOqASeumImx0RIZqSlPoqu+Nzn8?= =?utf-8?q?h7dd6z4ZOpKqaz7zhIvGB4dd8NCS8++NUR+Ow9oHrVcBKjO7vpXta4Z7gMyQhzwPr?= =?utf-8?q?G3y+BvPsfxY0Ul/iUJjiPpRX3YzSavXDaJ/Wt6Enuu4mN26tRHgSg0bjyW1eMARQe?= =?utf-8?q?2sq8RKoZP0/Aa9mNNXqlcD9kfhQwYgDDtnY5Txa6KlyOlUJXsQUxXqc2nanQG2IIm?= =?utf-8?q?kixCihQGaACTDdP6EGK8Pwzms4z9lN74sSvNWAGbo+6VKMGOuEv59BSyYbGOStQ8g?= =?utf-8?q?vK/mZzZsna5lBbXY+K3jYgkXn+tx6Fi1P/b+K9fXp/Ptr9rjX6tnKdrETkJ4x64TF?= =?utf-8?q?GDWEglnlT4J+tbKGCO5g8wayuLJ6eJaDR4bt/fuPaoT2GXW2wexyE0KSAMsQN2YRP?= =?utf-8?q?TDsuk1T1naAi68jpjo7xzX0hXoRK99jiheSToGV0L7VEX1KUahCRh2ioMLR94luKf?= =?utf-8?q?CNNr+94Vr3mZ3tKCfVl3uhPKyH0xkni4NApweE/il7EvxLvdi8m2KulbYBnjl/liJ?= =?utf-8?q?6zZ86TRiiOFkkpXEr8cE4yd5FKrkwHmPZgeHI3v+xpwH21OwLHFsV6yR9oVBG2Zf0?= =?utf-8?q?E2xRo6yGl90Yz+DDxj/tXMBBs2WiVbZB2jL4ICVUU114tWGR2ljY55QiBN1NJSZbS?= =?utf-8?q?k4ZFRjj04embjJLgKsqnR7bHB6KBeDDLmiM8EfQMF3hURwrTChCHNRH1IEl3FaIdP?= =?utf-8?q?K35aXb6uGYYCdSBIZqvRobRpXWJPMLLeGXSa9NNSVxjwq72qHnCF6zAbtXjFK68gm?= =?utf-8?q?9ZOHlv7jJ3y6TRIfGzjjCahEitzbxkCeHvegpAm24IfYJaXK+tej6js=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83757df3-360a-42a3-f0a6-08d9b6550ca2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:04:25.1125 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ry14BUNpxSS5vItZ6Ocy7ZrT4ieHtt659dW8q4Qzn/lEWNt8FBKkUfnJvnS1l7Dn7veKwR+FmnoZW5UTKrN/eA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958 There's no point including them when the respective functionality isn't enabled in the build. Note that this covers only larger groups; more fine grained exclusion may want to be done later on. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/include/asm-x86/perfc_defn.h +++ b/xen/include/asm-x86/perfc_defn.h @@ -4,6 +4,8 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) +#ifdef CONFIG_HVM + #define VMX_PERF_EXIT_REASON_SIZE 56 #define VMX_PERF_VECTOR_SIZE 0x20 PERFCOUNTER_ARRAY(vmexits, "vmexits", VMX_PERF_EXIT_REASON_SIZE) @@ -13,6 +15,8 @@ PERFCOUNTER_ARRAY(cause_vector, #define SVM_PERF_EXIT_REASON_SIZE (1+141) PERFCOUNTER_ARRAY(svmexits, "SVMexits", SVM_PERF_EXIT_REASON_SIZE) +#endif /* CONFIG_HVM */ + PERFCOUNTER(seg_fixups, "segmentation fixups") PERFCOUNTER(apic_timer, "apic timer interrupts") @@ -37,6 +41,8 @@ PERFCOUNTER(exception_fixed, "pre PERFCOUNTER(guest_walk, "guest pagetable walks") /* Shadow counters */ +#ifdef CONFIG_SHADOW_PAGING + PERFCOUNTER(shadow_alloc, "calls to shadow_alloc") PERFCOUNTER(shadow_alloc_tlbflush, "shadow_alloc flushed TLBs") @@ -112,6 +118,8 @@ PERFCOUNTER(shadow_unsync, "shad PERFCOUNTER(shadow_unsync_evict, "shadow OOS evictions") PERFCOUNTER(shadow_resync, "shadow OOS resyncs") +#endif /* CONFIG_SHADOW_PAGING */ + PERFCOUNTER(realmode_emulations, "realmode instructions emulated") PERFCOUNTER(realmode_exits, "vmexits from realmode") From patchwork Fri Dec 3 12:05:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12655007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2089C433F5 for ; Fri, 3 Dec 2021 12:05:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237495.411898 (Exim 4.92) (envelope-from ) id 1mt7Jb-0003jS-8r; Fri, 03 Dec 2021 12:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237495.411898; Fri, 03 Dec 2021 12:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7Jb-0003jL-5m; Fri, 03 Dec 2021 12:05:23 +0000 Received: by outflank-mailman (input) for mailman id 237495; Fri, 03 Dec 2021 12:05:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7JZ-0002qC-OY for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:05:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49c332f6-5431-11ec-b1df-f38ee3fbfdf7; Fri, 03 Dec 2021 13:05:21 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-4aArlK__OeKx5HHZ9fkoig-1; Fri, 03 Dec 2021 13:05:20 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec 2021 12:05:19 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021 12:05:19 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6P191CA0106.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:05:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49c332f6-5431-11ec-b1df-f38ee3fbfdf7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638533120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xbkw59rq1m1qExzkUUzR8dD75QHb9SESG2q0qwJbyuw=; b=cnQoWFxtAl3GV3qYoaYb5hoR5esLESldkEhtGlnHValQH8yIwAfVIbCIT0HX+0o0Rc4abD KRc37Lav2nZqi1m03DRuEhpiTTNkXkXt696Krwk7DrKowb/H03jBYS1B7bvljUuqI12YKg 7kjlqGaRhf+mT7D0l9a2SQQZUfX/zTc= X-MC-Unique: 4aArlK__OeKx5HHZ9fkoig-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFkB0amN2zbx4hCmnZpBuluRFwAgHLjdVsE1haljjVLPHyXNE0SQc9IimNGldHAZ9sleuEgAWdz75I9UndAO1lYAZGek9+nt+IxBycZoCoj5siv6GkqoYEDE+BmEj9UUoQqH7gVzw4gEGmAOT8iV654DmT/pXNrnwwkxqgAkUi085KeFx2V2yQtQLd8xPN05VzxZJphNZA0VYw1l6mL2ySQa+NugsNPUfTQ0WkFe76zQ/gOpGFn9SbYgGJmWjkU7jjpvfw5jYPA2OnE9IJwxOfPiuUY+Czb/FX37sT8EvwpQVmh0Ch5chwueoinIKbl4P0ziZPlsQbAwUWbQnMR2Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xbkw59rq1m1qExzkUUzR8dD75QHb9SESG2q0qwJbyuw=; b=Jd9M4bL3YxbFrizf0YJAzMlT70UZzNabBtL1VyLnGBkLzvL9gqft1h/OR7EapE21PphuH1P3DiWBxgQJlVg7c7NzCoVifhMhVjMNGIkMe4VhH5PB6TRiIfnRNM2zZq1fxHfvLbiCWqifok3ghM7X6YYjKUF8yk1admlBvQ4NNKz2/oIQ8NYpIIruuexdD3yI2zunK0Arspuq+rg9dq75i4xx55qFNog/9Hi953MzsPNU5jubk1+8tpYiGU5velAjP3FurJGi3dFOGShIFakZuTi4Zm8MVVjk1xv66WJcibf9p5eoy++5x68LSVtXVtXWllpGyDq6bsG8Aj/kkv1cVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 3 Dec 2021 13:05:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH 3/5] VMX: sync VM-exit perf counters with known VM-exit reasons Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , Kevin Tian , Jun Nakajima , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> X-ClientProxiedBy: AM6P191CA0106.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::47) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b9a317e-6516-4be7-3bab-08d9b6552cbf X-MS-TrafficTypeDiagnostic: VI1PR04MB2958: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VQObLVjU2MPHfCKkf2NmKbKHhpe6yHq37qZIC4V62OHPt+OBX7fLD8sykMwzKLrWLmLdZEgmiD+Az16GvKKu5RwzfrUC3LmwXZ+O1YA6ll8PT/qapkxPAkk2ogDOG+YFyNTf23eCFevsdM244zdOhSfof54dQfkmeFoTnECjssZz62/lp5gW8GshAs+8Bfe68PljkxkBRGJx4C4fnaMgAwKz0YHOZcEpF2sqEAwsDxTrm5uyxZnpNSzv7znNCMNXoQl6zlYq3aHXWNClK8+sWanMv4dBCW0dzGzMwglQtgHdi8jZ+HtjXijd9Xk3/JgKDoY9Uc4Rtm8zHoUfkUu8O7uel94RbP+s2gMguM3qUvc0RTS1HQ/O+3e1Jl3PScIj0a0Y8WbJUtEJHiSalImaZlLsjXuEEvFu6JRRuoYDbT4jrarAm5guzeBemGkJvQD37Wz7kOp98Hs7wmJaqhD/LlUO9Ht6+YgN3SFADXnGFGoOw2H6T+4psWuvSN4Pn7me40XqwheE0io8A8/i9VXA8PyRi2O2BZ6UiyuTD26zds4Ti67Lxov34zZwcC7i1/r1AEOGwysr0s6SvfNC9yHdOqXOWlg7l7MfYqAWdf1eddoRZ9Zw7NVlb5SxMUZtp8zZjVWo1K3oOmkTWeb6J3kMWD6lnrdHzCIOOT7C/Xm5ZlSV8UMmPmI2SruUcRaB1O+qiS6LTSgxoswVlKM2rrVCtiTmEOQRAJJvn+uB6EaZzyDFMCoojbbrz1x04a/+x8sJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?bDPdLfdO2l88lTKHt2tNyzAoIEmD?= =?utf-8?q?zTzeHMTWNB9BxgQd4/Xpjsot6ZNnOYRRqRNSGN14+YmzXzDvn+i94nOPhZQqK6BNk?= =?utf-8?q?NTYoP44BBWdiYZsQpIh8YH8HeGLIrOFfF/cnU2YvL63wDy75BoDw5ImXy9VAPB48r?= =?utf-8?q?sqbUGc7VUNQD7CHJsdn7Ot0EKZFIH3dRVg3OWmTbhadRAjAxKFD8RCQa3lq8WU7ym?= =?utf-8?q?a0fZTaOS0hVzPgOHdWEHRcQpu3is2huWrJ6cl5FmFdILayuja6nm0YkLQIDWOfwpL?= =?utf-8?q?gyzGnZi1WlRzOeo+XMZTQn6msrPUKLp097m6Tg73gVygu4iRiLxUtY3V7JUi2/9T8?= =?utf-8?q?TyUe5maHEEbYRN2OPg3FYTRVLr6dUL9oMWanynYqE/mipT/KB5SaUb4w5HCkjLwfQ?= =?utf-8?q?Re2Pm+HSodscWZhA4VDUMleWrolZylPb5c/+YzNvrCrbhB6zrcrJJb1/MeL0a3Lr6?= =?utf-8?q?ePxvN/r/mDLI2WML8f27iXScEG44ayzkBr9nvw6FMG8gjhGRbRmyThPyCkV+hQR3k?= =?utf-8?q?mA/2H4MzEvvy4UYJM2lWfE/bfcjludiSOg+9a8RO6nhZFxxdywtyQ39BDAs6MQZ6H?= =?utf-8?q?PaXyAOMVYq7/TtmukJUBHEl1S2ySE6EOHAUXyf3MWhMk9ZvW7Y8pDbWIO3p71wAZU?= =?utf-8?q?B9U92jYtS/5ub13paNxO9Zhxyvr0tLhy9kaM34HefhDDfW8ObubMfnOccArECVmUL?= =?utf-8?q?6CZU1WjvwpABW0yTUaLQFPQWB/Lvo4vwjIuX95USceJYOLtKlVAiIe1NYPubZDvmn?= =?utf-8?q?a01FsNwEZxNyPahDivCeO92Wsd9Fv22WuerKnb5+7ew2AX/U56DeS94K/WfYamxQj?= =?utf-8?q?hQT1i1bGNA6lJgqDNY+luxmogn9AsEhxVUZxihg7mEDtKhbPQuMhhzny3pJZVeYaD?= =?utf-8?q?T67KXtY5wRAN/mPMo168RDPZDlHgLpuF4/yVQ7+kAy7CMlTepW9UN9Uc8FoFsAEoS?= =?utf-8?q?+lNodXcZkxTqqZFeimlNRv5ScLACiYtSTPeQfuIk6DuFqTrjsirnEl8AnXMTmSGSC?= =?utf-8?q?dPRhVoAUIQ3lsYO7/1PPbHoNu0CywVSTktNWUkj4bhHeMPkAUJznz2jIMNnzwld02?= =?utf-8?q?KPT0x2T/DNNGWi5zjwlHhCXYWthkWDpDtI6NFXxYA7t60vT9fbotYNZ9oEmkfkdHc?= =?utf-8?q?JyagzUr6lSNYHBTW/9jmStR0Q7sXrz5847LfJaycDvPfyZpXkuUP3cBcuG9Qo6uji?= =?utf-8?q?h4cJQorTHwc8rd9RNjCW8wpDSaEKtM2GifhKFhie9v9QsNrlASu6D0O7e7Dny8yng?= =?utf-8?q?uTKe2w0P8dyvhRXulNarRhS+4+osrVCiZzr9S4x+/mq2H7R2kEtwfYAzeaO1uamwD?= =?utf-8?q?uItqTIAxOcYyr4daoQLZFxCp6JozCxLx/ng0ttLzzrvr1FmdnoW7cyMFitPRHrtyY?= =?utf-8?q?rVmzzQBh6toblZ9anKpo3aD+pOD4EwPg5VPALDXrdcVvz/IT2eKAGUCDbc3UDkCVQ?= =?utf-8?q?qbQ8DV+pCZzsC0Nz4fuJsvX9+wgHfGnwYBD1Tp/8ur0PhjM9Acen557EE89+pOQbx?= =?utf-8?q?pXM8sCpDhMJNLnIPq2MQLMhE3vDT/Fj4LGZwVCmF8pmffS8h64Dn2U8=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9a317e-6516-4be7-3bab-08d9b6552cbf X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:05:18.9830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TTnF0JN7iTaZdOWRZ0IldTLjZ7T4brZhAPFgHhYYTduDHAEZP7mvRyFR8jW0iFpyxLESu1Pve/Ajo/2zID5Cpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958 This has gone out of sync over time. Introduce a simplistic mechanism to hopefully keep things in sync going forward. Signed-off-by: Jan Beulich --- I wasn't sure about the #ifdef: Using CONFIG_PERF_COUNTERS there would seem slightly odd next to a construct which specifically abstracts away this aspect. --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3869,7 +3869,10 @@ void vmx_vmexit_handler(struct cpu_user_ else HVMTRACE_ND(VMEXIT, 0, 1/*cycles*/, exit_reason, regs->eip); - perfc_incra(vmexits, exit_reason); +#ifdef VMX_PERF_EXIT_REASON_SIZE + BUILD_BUG_ON(VMX_PERF_EXIT_REASON_SIZE != EXIT_REASON_LAST + 1); +#endif + perfc_incra(vmexits, (uint16_t)exit_reason); /* Handle the interrupt we missed before allowing any more in. */ switch ( (uint16_t)exit_reason ) --- a/xen/include/asm-x86/hvm/vmx/vmx.h +++ b/xen/include/asm-x86/hvm/vmx/vmx.h @@ -220,6 +220,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 +#define EXIT_REASON_LAST EXIT_REASON_XRSTORS + /* * Interruption-information format */ --- a/xen/include/asm-x86/perfc_defn.h +++ b/xen/include/asm-x86/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 56 +#define VMX_PERF_EXIT_REASON_SIZE 65 #define VMX_PERF_VECTOR_SIZE 0x20 PERFCOUNTER_ARRAY(vmexits, "vmexits", VMX_PERF_EXIT_REASON_SIZE) PERFCOUNTER_ARRAY(cause_vector, "cause vector", VMX_PERF_VECTOR_SIZE) From patchwork Fri Dec 3 12:06:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12655009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF7A6C433EF for ; Fri, 3 Dec 2021 12:06:22 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237504.411920 (Exim 4.92) (envelope-from ) id 1mt7KP-0004rk-QN; Fri, 03 Dec 2021 12:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237504.411920; Fri, 03 Dec 2021 12:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7KP-0004rd-NA; Fri, 03 Dec 2021 12:06:13 +0000 Received: by outflank-mailman (input) for mailman id 237504; Fri, 03 Dec 2021 12:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7KO-0004Rn-Of for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:06:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66b24870-5431-11ec-976b-d102b41d0961; Fri, 03 Dec 2021 13:06:09 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-4QVetuCsOQ22W_Mt-roe_w-1; Fri, 03 Dec 2021 13:06:08 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec 2021 12:06:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021 12:06:06 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM6P194CA0083.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 12:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66b24870-5431-11ec-976b-d102b41d0961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638533169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lrCpsxf//rC38Yu1bAGmHgfd83NmkO7BJIS+XBF2CsI=; b=iUGyGd39fQx7XAt1YrDWM7G8y8erEwX9u97Wu+wYDj6RKbkTd+55IXBMKkgJqSy7mUyiuE DFiORNFOxFqEMXZQmn3zSzJgyPEJrMTpAVmrOYFTTEwJahctlqRN0yhqXoMfCHayLFkggR r25O9jR1szwRIzDY9QxJVk16SNRNEu4= X-MC-Unique: 4QVetuCsOQ22W_Mt-roe_w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1fVguAM5V8rx83t9IR/psERW/1mMT7Ma0P50Va4QH+bxVshLAa9wWHPvCyGdkBByN8DWEyuWNfyfROhdptYIb44Ne+QojjsdP/vZBf/t325IB2btsiUfnZBY9KHUoGo08Zk8c7lU0rerd292jWihxi3lh6lVyoLXoseyS2KIKV9MyEGzmZlPOt7LP+XMIY8r7rT5TXiR01xZwY8bwMWLbegSq8fOIBqtzMwqZJfm39ufinaCeopU9zLTJbLXoYRx1I2jnIYE+tASUQWi6AdHhkyPBCXCNp0cm+DhEZLiTlo/P7bvGmcOudbWrE2cqouRiSwGeQ6w5W/F96cIfKdgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lrCpsxf//rC38Yu1bAGmHgfd83NmkO7BJIS+XBF2CsI=; b=EIFiabaRuSdJ74uTdAWIrYqUwXOZWC9oHIhJuF1lF/evV0wdthMDVXr8m8DTVn5cAcNbjocO00BPhQayQhTeDqiYqDPEG6Izx1qRwloQv3jgm7rwVx/F6nl3FxFuFMq+DsySsQ2kMBdpibXU8npDpzqs8fKnfbj7ME6H2RjhQ9EklyJK1TEdY7DgJQ6ZWEe7ldaHuFtJx5WxXYjkiIqBUCdcaa8xXJYWBuyn/V+NuNOnEBQsDlhsLNf4jO8ajM02v8ZB/8L6eo5h2hR28P5FzzR/pZ5CS7upQfBlrjqdgn5pc+NvzLyW+yKMlnAOoWF/fmjSm0wGZ45omgvW7nrQzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 3 Dec 2021 13:06:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH 4/5] SVM: sync VM-exit perf counters with known VM-exit reasons Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?utf-8?q?R?= =?utf-8?q?oger_Pau_Monn=C3=A9?= References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> X-ClientProxiedBy: AM6P194CA0083.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 084287df-8497-4aca-636c-08d9b65548ee X-MS-TrafficTypeDiagnostic: VI1PR04MB4191: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CBdYD8brSmj+sXlIdI1900fIoJ4ZXlTSOX0qxa6umyea1KrNEqDF8cO7v+GC0exJ6I/rSfKld5ZmeFfBoVsfrzqTAlyZZ0K2sxIE2IeFrKokNnNgd19sX1TsWdQ0X7VF5pjI5YO6gICPq1sGaCFkZq1DJ+v+pJjMbAnQVo17jBnN8DdUHMk1DbKMhcKBZUnZaLVJGppkYqXToZf1r16lLK1MEqYV+zCE0pVfl7j0MT+e+LOtkJUue1CcU5R3IiocHhFOQI/qQc3NdTDa/LX9iEF4gW+CyiX7fD+dDYXQvC0opOsqHm+nqMl704iVu/nCbKI8k3k/pylEV6gifv0SuJ7JiD0BrNkYP7+K98+tXp+UmHHUBZzVIcg0xxQJSfQBuhyjCLkyQ9nc7dZRNYkeC9k803SXdmlFJIqYI0LR3+wf9fr8U06qZRWJwqw21u9yIQr7XNm90nbXsdjyTSd+Ul28ZLgwZDcXDT15wt1bJC0EhkYM8Qq5XiXxpaXnL2KLdxHVYkeIYU6vEb/Cj/g5xeULscNViV2Hkmxo2/fVU1CY56lmikd4xzOyf+URfQ7Mdqk7FqukWKjpYXg0+9t8K0Q6q+QU1KPLl3TvHC8kkCmqWWvfSf41cbsRNTpsU7pwOS9Y//FKtMRTEZkwPI4uj55rmc8kKrhot9pEfg9YiuicDk34rMoOH4AFzBjXvfN/wYHVtRZV0xkYz9xk/LnpYh10sB1JSHhyCFBvsbOsVmc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(8936002)(5660300002)(2906002)(4326008)(8676002)(83380400001)(508600001)(54906003)(6486002)(956004)(36756003)(2616005)(186003)(38100700002)(26005)(31696002)(66946007)(31686004)(66476007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2wd9iiL0Gqd8z/oEsR1RuPFFSKI9?= =?utf-8?q?s7zIUeBcb2yxm8WAGjySkHK61QIGgqKKctDx6PlROcA2xcwyD6ErGe2RUkWKFk+WW?= =?utf-8?q?5CCWg+tLli1mr4n62SmlJ+ZDg+HhD08MqW+X+9ZaCsUEb9KXQ2ih0OSbAyKX2dELW?= =?utf-8?q?cE9uYGl9rYkX6hVMK+JEmmJzvRrEknY28iZCSXnFndf64Ms3n4HEks/ItnW4tAxx2?= =?utf-8?q?xqdXN9CewjoyTJB3i2j28d9GPYH/IRgUdtQygoJ1O+Thjz/w/dX+k0MZd0E40AYjr?= =?utf-8?q?8UnEg4vCBG0R6ou1MiBzKH1F/r/qILRG5WXtguSwBVIgN/1SJU35XgYmqV0VjYwtw?= =?utf-8?q?gAayXdPP/qt1iL4yeVWIACdaepwHgSmw6VJku/MVaVvzocR/zuASJaBoUyK+1DjW0?= =?utf-8?q?geiikhGwIvXoj+94pPYoXCwLD0VAJV5skIEOVWusqXti+5cIA/kHKUrPGzAhB7EYi?= =?utf-8?q?rmTIFVMMHMYTMXPeNBw1XyraOWEEHDXqL+8ocsc+Wq/Talwvq8i1bqFSrvpfk0C03?= =?utf-8?q?9BFtRXfov/st383LSizj0ijY0gFD9JdrHTO1zVQEKUdSOj3o5ozAQuExgAuzifNBj?= =?utf-8?q?CVxpevtaAafVrmD7iUg6P7OgThX5NwZOF1jjw8mMG+Ai+M251xMr5IP59xIyAJ8AE?= =?utf-8?q?vpZsxN0pe/iLTNCpJAuPmL1b+ufdrLvGBc/002hpfpEjvVo+The+xxLyPprVvCl8q?= =?utf-8?q?pn/SI0YAzV0MIszpvBmzB6i+ULhafurXZTmkhATKMJGo8axa75RCFv28C7unzx6VI?= =?utf-8?q?sBZFPXBxe93WJDNuNTkk0iAX1kuHanAXbFWhAGNPIrenX1OFEAxkbebUJdiEwY9Pg?= =?utf-8?q?x3hHbPncdpyCxUJwC/MjFRUlYy+OJIfw/6ha5I2EbKpKtyNlglymiGZHHT/1yAlCB?= =?utf-8?q?Mdv1qBg2hjEjd/jBxWKCH/cwSn0CDhuK+lPX6tW+ZnDfYIH4wmiFs1zaXP912aO+5?= =?utf-8?q?+6KqnlJgVrhrZ6Uli55kOZeCCJkllPI1Km0HSeQCBeFz+zVJ3eppofp6OEUmYOvNw?= =?utf-8?q?xRtGIP7SnGq0ji7udu4/RjMasXijfCMyUtggHf8106aAzJ6maNjwc5WMHvYqCEQ6D?= =?utf-8?q?5N07b7xcUwF47ROOqLE3BS7MibDB7aurTrhbz3bqQ8793P28J/orZXHIvcll5RxZa?= =?utf-8?q?eG1KfP5GWuA/KuzSXib82Jdh2gxmBHZnDCLW208qMaSIr1eVQSMsscc1bS2l5zPz9?= =?utf-8?q?srqDDBVf9j0p1g5sxYh366i+fGb6IkCsjK+8n2sXHbmEgvgSwAM6cfK2NCitgs1hl?= =?utf-8?q?iSj8+d5cQx//66sI7kG8eiwmIPFjD6w4l0/BsFQ1GImviJB7U8o11xQ/U6pTSILzW?= =?utf-8?q?dCf1Q6/VFV6Q5lS/xRDRJaagPG6QMEG/7pkDUgxHd84P/429KzuSEKuZXeL3QijZ2?= =?utf-8?q?Ex3hxTg2oR0PIVRWJeaMuwR0SdQAOBVOD0hEVLYRBXdrjZ4MCaSjcmcFasmfVELnn?= =?utf-8?q?IVO3w1ncCehyvC/yIYCoy+bs2Ngg+ovmkBo8XJLWayEhl+mok98utKE4Xf+pH9ZDH?= =?utf-8?q?m8aASLuiWATp38p1ezqDaqa46AACOP7L1WJF4g4dYWct2Cikf9mdi6A=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 084287df-8497-4aca-636c-08d9b65548ee X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:06:06.2793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r9AYsZLSo+4t/iINfivrIxR5brrFFY01/R1rBmftFceYwH7kn4f3dPEEVwdS4HZaQigYTxB025JykEm0yqDpXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191 This has gone out of sync over time, resulting in NPF and XSETBV exits incrementing the same counter. Introduce a simplistic mechanism to hopefully keep things in better sync going forward. Signed-off-by: Jan Beulich --- Given their large (and growing) number, I wonder whether we shouldn't fold "SVMexits" and "vmexits". They can't both be active at the same time. I wasn't sure about the #ifdef: Using CONFIG_PERF_COUNTERS there would seem slightly odd next to a construct which specifically abstracts away this aspect. --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -2644,6 +2644,10 @@ void svm_vmexit_handler(struct cpu_user_ goto out; } + /* Note: "+2" to account for VMEXIT_NPF_PERFC. */ +#ifdef SVM_PERF_EXIT_REASON_SIZE + BUILD_BUG_ON(SVM_PERF_EXIT_REASON_SIZE != VMEXIT_LAST + 2); +#endif perfc_incra(svmexits, exit_reason); hvm_maybe_deassert_evtchn_irq(); --- a/xen/include/asm-x86/hvm/svm/vmcb.h +++ b/xen/include/asm-x86/hvm/svm/vmcb.h @@ -302,6 +302,7 @@ enum VMEXIT_EXITCODE VMEXIT_MWAIT_CONDITIONAL= 140, /* 0x8c */ VMEXIT_XSETBV = 141, /* 0x8d */ VMEXIT_RDPRU = 142, /* 0x8e */ +#define VMEXIT_LAST VMEXIT_RDPRU VMEXIT_NPF = 1024, /* 0x400, nested paging fault */ VMEXIT_INVALID = -1 }; --- a/xen/include/asm-x86/perfc_defn.h +++ b/xen/include/asm-x86/perfc_defn.h @@ -11,8 +11,8 @@ PERFCOUNTER_ARRAY(exceptions, PERFCOUNTER_ARRAY(vmexits, "vmexits", VMX_PERF_EXIT_REASON_SIZE) PERFCOUNTER_ARRAY(cause_vector, "cause vector", VMX_PERF_VECTOR_SIZE) -#define VMEXIT_NPF_PERFC 141 -#define SVM_PERF_EXIT_REASON_SIZE (1+141) +#define VMEXIT_NPF_PERFC 143 +#define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(svmexits, "SVMexits", SVM_PERF_EXIT_REASON_SIZE) #endif /* CONFIG_HVM */ From patchwork Fri Dec 3 12:07:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12655011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D05EC433F5 for ; Fri, 3 Dec 2021 12:07:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237512.411931 (Exim 4.92) (envelope-from ) id 1mt7Ld-0005kT-4m; Fri, 03 Dec 2021 12:07:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237512.411931; Fri, 03 Dec 2021 12:07:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7Ld-0005kM-1f; Fri, 03 Dec 2021 12:07:29 +0000 Received: by outflank-mailman (input) for mailman id 237512; Fri, 03 Dec 2021 12:07:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt7Lb-0004Rn-6z for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:07:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9482a559-5431-11ec-976b-d102b41d0961; Fri, 03 Dec 2021 13:07:26 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-5-FAZvQMsONi25VyTIfy6i3w-1; Fri, 03 Dec 2021 13:07:25 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec 2021 12:07:24 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021 12:07:24 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM5PR1001CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:07:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9482a559-5431-11ec-976b-d102b41d0961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638533246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ms0YHIDv5FBReZC9ySpmTf7afFn9dSpJLL3t23RnwNE=; b=bGnQWmiZTnPgU9kWETHVHSSbG/xU6V5Fz8Qb5ZBVMkCW/qHPTvjLp5AzsrKLvJzsdCsAmU qEw3kJ8MjdEDZD9bYLwO9eMZOUgrczOmUdnjj7+YU2YgzB6DFS9ppNVukkH9ewf1BzHcJv pWdQdoXrHjageyYyEiJAR595VCoOtWY= X-MC-Unique: FAZvQMsONi25VyTIfy6i3w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cR2ezW4bj9BBvDk1dLj+Iwniy+DMTauA4SLL+43kZXbVAB5OJo1vudK3a70zRykmztKTGr4AmmUosby1Fb3sw9Pdr2pyBi+T3n8BEtxRm9I+LJJrcZ+jJEdHG5BCJ6lipZAlQiYemaVVa7V7r4VXY/6tfRCEJj/+1vKPn0/j8q1hozVLTsTcaZsezi4/tSqZwkMSrwbZMQozdLiZJzIZbvgreUCr5aHAPUlKn6P5i8oa2AO0XQ/svq34YvFrjPeAMJzKKMh0LpiDjrgPQ0W/g/kIdRQRUy3cT5tLTRq6W6yHdeiTZEd57m9zeQzVMk5rqZfC/taksC5DLLBU6fHyHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ms0YHIDv5FBReZC9ySpmTf7afFn9dSpJLL3t23RnwNE=; b=DqxKR/X9lIIscjP9rs+vxRIKTipCqogWbuns3njs/koiS5wyqoUSzQm0L6v7M1VGwQPNOg96yJ6N2KT0wFOT8BFE4tG9/FvZUsHo+1QW/hb30fulx0pMuBIIWM8JQu06sGAHRLW07+RoHg9GL+ll3PFuQ2F2eHH4RYpX35iJ/Ma/mV1LLi3kJuACCDFZYau5qlJrsgkb4R5hmaSemEOFzer1ghb20erdYPOyIz4wU8I0/S0bXLlfNqdPTE4NfgLF5RJfvIHowIDe/iX7iw3R2/rBHhu2qBqxf023cYj30wCUte86SCDSzlUYbQZwqS1uk6WdxMjSXhESKVm1//zXfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 3 Dec 2021 13:07:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH 5/5] xenperf: name "newer" hypercalls Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Ian Jackson , Wei Liu References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com> X-ClientProxiedBy: AM5PR1001CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6d02cf6-7dfa-4641-c8d1-08d9b6557769 X-MS-TrafficTypeDiagnostic: VI1PR04MB4191: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ib0gUJMBMdgPLzuafH6a+RCwI2lLJjWdN9Bj/y7FT22ytfjoeFAnZKoq+VgUFwGvDqO/VTdqhgxph0vNGySH1X5AGR7doyOr/5Gj9V+Hg9MDo6b/yMDITFAtbXlCt0joWZJ/ETDIke+aV8iNApS6eULynpiXkOVD4OEVoRMjTbu1aD5Kx7LO4x+lH0UMZhx5N6W4tR+gG6nnLLXQN0VSdi3KawC4Hz837lQQv9lW7QQt5y2uMU8c9IC+rLzBBa5RzCLdjnXSIt3nBm4fEA0h4iulztX7aw8GMV7JsgKbU2JkPGnwkuTNAT61qogv2Dhxj3nz68nBoQ1F2g4fVggUMQhYedvOkUy4ehPjvaLAJjJlNDhBt78ErT9SyKw588rbMeZQs76a/g5v6DrpTTNAcu5pezXmkzW62BV1BOYAo7VYAWlEks6GGO/IeQhfrjcDIFuqsF4Q8K3wzYQ8tYrffqEo1zf9PRLaQuW6vy9ujujpBb5cjkrb20f270u4UEpLJgyxKYv0wPa++2zHi+crmqjgBKIkVPNAFpjpoGvdkG9vi2IKVsOzkpD3gf00VJ5K3yvbu8L0L5Wrp8ebbavwx0OVNi+vHnCCZSxP+9UVqxBF627UVw+wCSmvXiimSwqXnOKLqWU/CcAWc+d2rhfBEtDYvFdSANIFOYP0I/xduhwX1iKKO1Q+K8WBRy8QYPZ3+gZslXNAa/r21C7jX+NSI+7q2W3MJ7afLPuTsAh3s4w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(8936002)(5660300002)(2906002)(4326008)(8676002)(83380400001)(508600001)(54906003)(6486002)(956004)(36756003)(2616005)(186003)(38100700002)(26005)(31696002)(66946007)(4744005)(31686004)(66476007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QK+Iglee24MY8Zw9+4U67VX3kwok?= =?utf-8?q?V/0vbC7RP39EYmDTvgIPernqJlM8X6kt2jpvBc4r1Fn39quRAKCoAN3s5uM1S7xOk?= =?utf-8?q?KgIx8CCp3O24DsCRaBbEOckZtai9d5tyoIvkqtM9zUL/NrL8/I6WyuAagQJvGBe+L?= =?utf-8?q?nkLv62A5q9RvlNLaLMgI7Tpt0YDZDl3u9I+bGmR5sHRX/dc2Pdra0FWEUtSv3bun4?= =?utf-8?q?w+DAlnptoiJ6DY1dAlsGyzCR+H6xd94YCBfMv2GxWcl2WTEh6AzBY1oT8jttc65ju?= =?utf-8?q?UnYnwS2QoGuqQDUX+zES0WZ503oMDy87M6nuUBm61ViZwB+EZ4VNPH7+fE1pXzggi?= =?utf-8?q?ug7PMxsDko9B/2NRJr6Y+qiD7a5/o6gpyPqAU4j+Hpok8lX7DDifKTm0LjsWL1F3X?= =?utf-8?q?WUSOlUynE+H+oKVdrQFLQIydy2nPz1pAlgG/ga/roPY0a5vB4LldEOj/WynWnhltU?= =?utf-8?q?++nmXvZ7a6lpaXdvIVetmB0DCFHQu+8p1B+NQcNZvaJkK1Wu5939LlH6ywK8cABJD?= =?utf-8?q?WZMGVHuBf/6LVqP6DAPlDvGDenTLh4Cq1inBJKnJmSl2LwREUAIS5KAF7CRIdIz2j?= =?utf-8?q?B/FPT0h9lOFxx37Z00d+8Pfhm1ILZtBXqjDntkPShtrQRp573g6BVA+iGan4g+t5n?= =?utf-8?q?H8yLAHTSQtFLnbqMH4C5KQfKn7ct7KiZffmie2eBF5bW6pTvLTuIIFVO0l/5EMe8d?= =?utf-8?q?jXYOipNRW2t62hzuYGMSKbB3bhRNU4ZlWwnw7ONNAQNHV83ORx/DUcAT5ceFimmiL?= =?utf-8?q?y/oBGWoM6gDQkBpX4Ly3Sz4dbm/+Xiklxn7iMQY2zcj7y/9BBdP075jKYvhwGZK0N?= =?utf-8?q?0bMsFBoumHZVU18A2Nu2kCZZkSYzO86ILZmDweGeN9OcI+fmM5oCIAPPN1RgYOdxe?= =?utf-8?q?/u49ujp941TEw1Fv6xOI7igKGnYCSGBv9m7xp56HY8PWlhy4rK56N4mxOGU8CqWo0?= =?utf-8?q?nW9WWlgsjeKmBajJnFNDwkQwS67K4iRKa4tnMKTzhpJVrSmLqKOv4FG6bE3I4sXSR?= =?utf-8?q?37wwcasjbtVsH9N3XeUH2iOhn1YjxD+yH//kkA5zCKNAPu0ByDL9pP9XIy1L4PIhh?= =?utf-8?q?TtYRIueI2ShnZFC5Kq6oj2gqsjJPq9wTNVaWC2wUG9LbIwOPPkMwByzyO2+EnFIXt?= =?utf-8?q?gr9SbvvHrOAyUI6EFGFOG8g/JuSCCSUcqAMacM+c+N/edWbI6gu/Y4I0AxjIqW6ih?= =?utf-8?q?P6WXdq9ROezkxDs8ZpWj0y7qDXwug6tpSFQcq7W7e+KG8wWukUJniHS943nxaNZIX?= =?utf-8?q?Oo5NUtIbg0YqXG97/L+nCEh5XmX76bhXwrrIf1cTEhHBXPb6ic9bYMpVRecXcQros?= =?utf-8?q?HFXvqdUVkTzKO7HNn8c2IlYqo1bqsxr1KwKOmy+mbVBULke+IDwlK7JwrccEKUGGZ?= =?utf-8?q?N0M9ES02U1bEwZtakvJrp8PedsMCa77MaLXf9B73SkcRFA/GcJidBGLWsFtIMBnK+?= =?utf-8?q?PUf9D6gsuWcKQn866JATQVkMlkiO3cX2f7/H4AJ87paHzFw7M1c+oA+H5UrJhB+uT?= =?utf-8?q?5mkEjgIwdqBVZVuRRnxDUMZWqAtZj69tLu7C/i3/xGiyOJH70RIFQ6o=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6d02cf6-7dfa-4641-c8d1-08d9b6557769 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:07:24.2512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ixtlYJ56UE+a7ubUQfRnFBp54EwMArX1ODunnjrv1joCHt2NtlPCwXEpHfSJPY/m2uEJuP77cD3UrmLjjLwpXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191 This table must not have got updated in quite a while; tmem_op for example has managed to not only appear since then, but also disappear again (adding a name for it nevertheless, to make more obvious that something strange is going on if the slot would ever have a non-zero value). Signed-off-by: Jan Beulich --- I wasn't really sure about x86's real names for arch_0 and arch_1. The tool runs on the same host as the hypervisor, so __i386__ / __x86_64__ conditionals wouldn't be inappropriate to use ... --- a/tools/misc/xenperf.c +++ b/tools/misc/xenperf.c @@ -18,7 +18,7 @@ #include #define X(name) [__HYPERVISOR_##name] = #name -const char *hypercall_name_table[64] = +static const char *const hypercall_name_table[64] = { X(set_trap_table), X(mmu_update), @@ -57,6 +57,11 @@ const char *hypercall_name_table[64] = X(sysctl), X(domctl), X(kexec_op), + X(tmem_op), + X(argo_op), + X(xenpmu_op), + X(dm_op), + X(hypfs_op), X(arch_0), X(arch_1), X(arch_2),