From patchwork Mon Aug 6 23:20:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10558101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FB2613B4 for ; Mon, 6 Aug 2018 23:20:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B7D5294B5 for ; Mon, 6 Aug 2018 23:20:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5FA1F29530; Mon, 6 Aug 2018 23:20:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3492294B5 for ; Mon, 6 Aug 2018 23:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730444AbeHGBbh (ORCPT ); Mon, 6 Aug 2018 21:31:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58478 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730229AbeHGBbg (ORCPT ); Mon, 6 Aug 2018 21:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tQPbGnfklhqzNmoL6iyYyNoNlKJbsoDF7nXJ+DmiDWE=; b=XZbiP22HbqiRO1akxApZC/EAH NSCuRwS7P6RbWiPVfdR4luHuR68nVy98vPrygsglAOT9hPRmhZ4sC4fIM3fTxaCE80Ji3lEbjvm6m DmIbfqvtBVuC8Q08Bcaj4oXSgXc8qn7ovuMgAHh2HrdXOEMK6EVZl09mo1NQa4cdgw1CLDZSQm5o1 kSG7dq5YNXLWpW8+XJPJ2M33p7diaxohiD18Bo8ERiYIFIdk1a5FwXO7Ssecibf54GmCcGLr4YOQD UMTkw7Lb23jBVzjuThBvkpkHeAwFrTyHRUf8youwhyYOV7RpN9MVBomqR0FGMFY+hmZlmn3ztJKpF qtmyBEULA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fmonM-0006jJ-4P; Mon, 06 Aug 2018 23:20:12 +0000 To: linux-scsi , target-devel , "Nicholas A. Bellinger" , "Martin K. Petersen" , "James E.J. Bottomley" Cc: Bart Van Assche From: Randy Dunlap Subject: [PATCH v2] target: fix tcm_loop build errors when SCSI=m Message-ID: <24dc30ca-b558-fb6c-d478-967dbfa887c4@infradead.org> Date: Mon, 6 Aug 2018 16:20:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Language: en-US Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Fix build errors when CONFIG_SCSI=m and CONFIG_LOOPBACK_TARGET=y by making LOOPBACK_TARGET depend on SCSI. drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_link': tcm_loop.c:(.text+0x445): undefined reference to `scsi_add_device' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_remove': tcm_loop.c:(.text+0x55c): undefined reference to `scsi_remove_host' tcm_loop.c:(.text+0x564): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_submission_work': tcm_loop.c:(.text+0x7c4): undefined reference to `scmd_printk' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_probe': tcm_loop.c:(.text+0x7fb): undefined reference to `scsi_host_alloc' tcm_loop.c:(.text+0x85b): undefined reference to `scsi_add_host_with_dma' tcm_loop.c:(.text+0x896): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_unlink': tcm_loop.c:(.text+0x962): undefined reference to `scsi_device_lookup' tcm_loop.c:(.text+0x972): undefined reference to `scsi_remove_device' tcm_loop.c:(.text+0x97a): undefined reference to `scsi_device_put' drivers/target/loopback/tcm_loop.o:(.data+0x210): undefined reference to `scsi_change_queue_depth' Fixes: 3703b2c5d041 ("[SCSI] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module") Signed-off-by: Randy Dunlap Cc: "Nicholas A. Bellinger" Cc: linux-scsi@vger.kernel.org Cc: target-devel@vger.kernel.org Cc: Bart Van Assche Cc: stable@vger.kernel.org # 2.6.39++ --- v2: add Fixes: and Cc:stable drivers/target/loopback/Kconfig | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20180806.orig/drivers/target/loopback/Kconfig +++ linux-next-20180806/drivers/target/loopback/Kconfig @@ -1,5 +1,6 @@ config LOOPBACK_TARGET tristate "TCM Virtual SAS target and Linux/SCSI LDD fabric loopback module" + depends on SCSI help Say Y here to enable the TCM Virtual SAS target and Linux/SCSI LLD fabric loopback module.