From patchwork Tue Dec 7 07:27:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 12661187 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1AAAC433FE for ; Tue, 7 Dec 2021 07:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhLGHar (ORCPT ); Tue, 7 Dec 2021 02:30:47 -0500 Received: from bzq-84-110-109-230.cablep.bezeqint.net ([84.110.109.230]:49825 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230073AbhLGHar (ORCPT ); Tue, 7 Dec 2021 02:30:47 -0500 Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 0679C4406F1; Tue, 7 Dec 2021 09:26:59 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1638862019; bh=co7ghAu45Uvxw9aXKApsiTm/77awZeWU6WVNI0cLlpE=; h=From:To:Cc:Subject:Date:From; b=cRNjc412eTqk7F4ps/Qup/kdBDd0ShbP18FiWeO4wYFP6PruCv+8TzlGgVAyX+Cpc BCMIb0VEISIA04UPKwJ42yz+ufyH7YsRvlQfneBEHSOm2SOZHWwP+0oPJVC+FCO12P pd522aGNUIjVeTsM7py1bhx9f5Iqet89FPvvyEpb0Ku74aATCRuIs3Z+V94HQhRH73 iaOD4isOzAzZly5U0mwsQRDWu4goNuEyuoEYrh4MdTurD6ksBYbSxNBRcD9zKI6Jr6 Xfq6oGjYQSsNhmvrpu3W6I21unZhohCwP0A6bmGe0Za38x8NAp+X0ri7n9KtpOPp4S 5OSoIDJoDmudw== From: Baruch Siach To: Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Baruch Siach , Sricharan R Subject: [PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property Date: Tue, 7 Dec 2021 09:27:10 +0200 Message-Id: <8a744cfd96aff5754bfdcf7298d208ddca5b319a.1638862030.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org There must be three parameters in gpio-ranges property. Fixes this not very helpful error message: OF: /soc/pinctrl@1000000: (null) = 3 found 3 Fixes: 1e8277854b49 ("arm64: dts: Add ipq6018 SoC and CP01 board support") Cc: Sricharan R Signed-off-by: Baruch Siach Tested-by: Bryan O'Donoghue Tested-by: Bryan O'Donoghue --- The error message was improved in commit af3be70a321 ("of: Improve of_phandle_iterator_next() error message"), but there is evidently some more room for improvement. As I don't really understand the code, I added the commit author and the DT list to Cc. --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 6a22bb5f42f4..a717fc17523d 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -220,7 +220,7 @@ tlmm: pinctrl@1000000 { interrupts = ; gpio-controller; #gpio-cells = <2>; - gpio-ranges = <&tlmm 0 80>; + gpio-ranges = <&tlmm 0 0 80>; interrupt-controller; #interrupt-cells = <2>;