From patchwork Mon Aug 6 23:25:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558107 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8859E90E3 for ; Mon, 6 Aug 2018 23:26:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72AA1294C2 for ; Mon, 6 Aug 2018 23:26:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5372D29530; Mon, 6 Aug 2018 23:26:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E10F5294C2 for ; Mon, 6 Aug 2018 23:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731300AbeHGBhq (ORCPT ); Mon, 6 Aug 2018 21:37:46 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:37127 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731308AbeHGBhp (ORCPT ); Mon, 6 Aug 2018 21:37:45 -0400 Received: by mail-oi0-f66.google.com with SMTP id j205-v6so25289323oib.4; Mon, 06 Aug 2018 16:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2WXbpsYMTz/QG1vzL3x5MJRxezLdU4OG6c9SB+TpFWA=; b=KShT0vAS5hdq8cmK7p8xAxvFu3GTtkHqyiyOhMk3kF3ZqC81EslEflDrsAFnSN/YI/ BGa6s6HkJiekjU/j4+xd26gWrMfB2h0X1LB1J7dWFb/2aOs1MvDY88W4nn7ve0YW1pFW 8iJLbjZEVZzvg9Mz+Msi1vS5h5xZmdar9mebyCKKQKtCsHvhRegcKWVgPsWqrrFQfB+e J21rrtssA+i2kQQTZ9s54nt67p4nVvPs7PLLjo4TIsgb110om0+O2bdd4Rm5LMoy0bs/ jyRx9nCf94AG5R8OxEVd0bfFMBa8NUAfNnhhTTEsSEIVRDNGXyMmfxlF/OsyisXMh88p VCrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2WXbpsYMTz/QG1vzL3x5MJRxezLdU4OG6c9SB+TpFWA=; b=Un/bTc+XZbJ4UBBTjV2QBnj57I7OtqJ2CS1+ol8gZ0cgR/1fbhG96AdHrNK61QgaRP d5Ryp2Uh3LRMXVJE1nbDoZHC54mz9/m7uokIjG5zOR8pQpfgxS0pyE/CZmQeyAc1Eyde 9gIkzRXBrfkhHscX7kKoZKtZMk8M8WJk9vaG04YVackqQ4vtZYK6MTo2uFfE4Siij2Jg zWmLWeiOGq5UvPm17KhfjXDcU5PMsJ2JeQuDsvCSW8FIY2J/G+Kaf8SLkIPHYW/qBT0g +WpTaKKd87ow/EzzOoIrklWoKxysbp0yDwfxEhcoOUuAJr4BYJB2L0I178pOmWiMMXS5 +SHQ== X-Gm-Message-State: AOUpUlGNfA85gv+tJUdpuZKC5/Lg9h0fAL7xoAYe66NWANVqti63yrrB OPf1d/fAuF3izw78ukXAu0ou5VF2a+0= X-Google-Smtp-Source: AAOMgpcqOUA/kNzkVMbDdq5HkfCHfTJrwB4RWKrpc/P5ByRsBSjCYn4QtKuK5YdKRDODlfCDhs4ckQ== X-Received: by 2002:aca:a641:: with SMTP id p62-v6mr17010358oie.151.1533597981033; Mon, 06 Aug 2018 16:26:21 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:19 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 1/9] PCI: Check for PCIe downtraining conditions Date: Mon, 6 Aug 2018 18:25:35 -0500 Message-Id: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the system, and identifying this from userspace is neither intuitive, nor straightforward. The easiest way to detect this is with pcie_print_link_status(), since the bottleneck is usually the link that is downtrained. It's not a perfect solution, but it works extremely well in most cases. Signed-off-by: Alexandru Gagniuc Acked-by: David S. Miller --- drivers/pci/pci.c | 22 ++++++++++++++++++---- drivers/pci/probe.c | 21 +++++++++++++++++++++ include/linux/pci.h | 1 + 3 files changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 316496e99da9..414ad7b3abdb 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5302,14 +5302,15 @@ u32 pcie_bandwidth_capable(struct pci_dev *dev, enum pci_bus_speed *speed, } /** - * pcie_print_link_status - Report the PCI device's link speed and width + * __pcie_print_link_status - Report the PCI device's link speed and width * @dev: PCI device to query + * @verbose: Be verbose -- print info even when enough bandwidth is available. * * Report the available bandwidth at the device. If this is less than the * device is capable of, report the device's maximum possible bandwidth and * the upstream link that limits its performance to less than that. */ -void pcie_print_link_status(struct pci_dev *dev) +void __pcie_print_link_status(struct pci_dev *dev, bool verbose) { enum pcie_link_width width, width_cap; enum pci_bus_speed speed, speed_cap; @@ -5319,11 +5320,11 @@ void pcie_print_link_status(struct pci_dev *dev) bw_cap = pcie_bandwidth_capable(dev, &speed_cap, &width_cap); bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); - if (bw_avail >= bw_cap) + if (bw_avail >= bw_cap && verbose) pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); - else + else if (bw_avail < bw_cap) pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", bw_avail / 1000, bw_avail % 1000, PCIE_SPEED2STR(speed), width, @@ -5331,6 +5332,19 @@ void pcie_print_link_status(struct pci_dev *dev) bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); } + +/** + * pcie_print_link_status - Report the PCI device's link speed and width + * @dev: PCI device to query + * + * Report the available bandwidth at the device. If this is less than the + * device is capable of, report the device's maximum possible bandwidth and + * the upstream link that limits its performance to less than that. + */ +void pcie_print_link_status(struct pci_dev *dev) +{ + __pcie_print_link_status(dev, true); +} EXPORT_SYMBOL(pcie_print_link_status); /** diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 611adcd9c169..1c8c26dd2cb2 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2205,6 +2205,24 @@ static struct pci_dev *pci_scan_device(struct pci_bus *bus, int devfn) return dev; } +static void pcie_check_upstream_link(struct pci_dev *dev) +{ + if (!pci_is_pcie(dev)) + return; + + /* Look from the device up to avoid downstream ports with no devices. */ + if ((pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT) && + (pci_pcie_type(dev) != PCI_EXP_TYPE_LEG_END) && + (pci_pcie_type(dev) != PCI_EXP_TYPE_UPSTREAM)) + return; + + /* Multi-function PCIe share the same link/status. */ + if (PCI_FUNC(dev->devfn) != 0 || dev->is_virtfn) + return; + + __pcie_print_link_status(dev, false); +} + static void pci_init_capabilities(struct pci_dev *dev) { /* Enhanced Allocation */ @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct pci_dev *dev) /* Advanced Error Reporting */ pci_aer_init(dev); + /* Check link and detect downtrain errors */ + pcie_check_upstream_link(dev); + if (pci_probe_reset_function(dev) == 0) dev->reset_fn = 1; } diff --git a/include/linux/pci.h b/include/linux/pci.h index c133ccfa002e..d212de231259 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1087,6 +1087,7 @@ int pcie_set_mps(struct pci_dev *dev, int mps); u32 pcie_bandwidth_available(struct pci_dev *dev, struct pci_dev **limiting_dev, enum pci_bus_speed *speed, enum pcie_link_width *width); +void __pcie_print_link_status(struct pci_dev *dev, bool verbose); void pcie_print_link_status(struct pci_dev *dev); int pcie_flr(struct pci_dev *dev); int __pci_reset_function_locked(struct pci_dev *dev); From patchwork Mon Aug 6 23:25:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558109 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9D76613B4 for ; Mon, 6 Aug 2018 23:26:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CDA8293CC for ; Mon, 6 Aug 2018 23:26:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8012829530; Mon, 6 Aug 2018 23:26:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F53A293CC for ; Mon, 6 Aug 2018 23:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733257AbeHGBh4 (ORCPT ); Mon, 6 Aug 2018 21:37:56 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:38022 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731308AbeHGBhz (ORCPT ); Mon, 6 Aug 2018 21:37:55 -0400 Received: by mail-oi0-f67.google.com with SMTP id v8-v6so25265994oie.5; Mon, 06 Aug 2018 16:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mCBhyT7m82JCvv9Qmq19HGSyTY8I4ZV8neCBY0l2Uko=; b=iKwLYIWQXSuIciJDCA4EF5lho2Mo06rNV3Ln80Pj5ty6C8RTztYhy82u8itZUC7rpe Fr5HDzk2OBNwW1WwDZGVemoma9tapURt+rPrJW/K4ZSeDNCmHUWUxR3dPke3mLFCyd7v ckJZUB7NhFoH+2BA68IfDmIrQ1F1WvaBm8pULofjoJdYfGoCJZ9Fm74ag5MLyeNNP+eg qAy4bV1f9LCZx4/JUQhB+3VUtRMX/biFIKXkPrL+8avdGahINUb6Ri+tLwpl6oS1/EsP GE9DIXZD6bZDq4BFSTdvRg0BHCK6uYKUySxhgW2Ndl96g2ZyerSbDgn1PtGp0S+P0Ilz ZSJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mCBhyT7m82JCvv9Qmq19HGSyTY8I4ZV8neCBY0l2Uko=; b=OAedSC5GiHSQlWRKUcSRhqkncaqYSNHB65f+BnSxnWJNs/kgZZlTSnRP3tNNBPWPgH 5cFrHygIU9/3JUA/mJr6tyEjTDIsJMz+XjWsCUh++ec+nnrf5uXI54xm2ef17vMAihXP diV8OEs1B2WKyDr3wxdfKbbwEwosnOqqcedSoIwdA5KR8L+hq11w+kPZUXGDrxcTZpbO XogSCEu1iddyKpaANUxPuzJT7nkQFeJ3xGjnLN2ZHaON/aRkVJKtBZqdBuFOEEehEu3/ zF4UcBVpUi0Q+GbMBSVsZqUSBHekARHvdjnQfyRELd/QkyGX+9I6DyFDeJPqpd96QInl tkHQ== X-Gm-Message-State: AOUpUlEOcip1IDPWYLpVACEsiaLn3s13ux9vbey3vJaxgujV1Y4JFVyJ QwZsqZ6fUGICp8qjEGy89e+CfQACLQM= X-Google-Smtp-Source: AA+uWPyuPmBsvoqrTYHPT3nFTU2RL9puB9Bl5t/8AqCHT0iTvF/rFT8lnWVS4552IRzt15LXYv9Ebg== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17849769oig.325.1533597991176; Mon, 06 Aug 2018 16:26:31 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:30 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 2/9] bnx2x: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:36 -0500 Message-Id: <20180806232600.25694-2-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 57348f2b49a3..3eadd6201dff 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -14100,7 +14100,6 @@ static int bnx2x_init_one(struct pci_dev *pdev, board_info[ent->driver_data].name, (CHIP_REV(bp) >> 12) + 'A', (CHIP_METAL(bp) >> 4), dev->base_addr, bp->pdev->irq, dev->dev_addr); - pcie_print_link_status(bp->pdev); bnx2x_register_phc(bp); From patchwork Mon Aug 6 23:25:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558137 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1AEC13B4 for ; Mon, 6 Aug 2018 23:27:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 90C59293CC for ; Mon, 6 Aug 2018 23:27:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84DA129530; Mon, 6 Aug 2018 23:27:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E611293CC for ; Mon, 6 Aug 2018 23:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387582AbeHGBiB (ORCPT ); Mon, 6 Aug 2018 21:38:01 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34321 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387557AbeHGBiA (ORCPT ); Mon, 6 Aug 2018 21:38:00 -0400 Received: by mail-oi0-f67.google.com with SMTP id 13-v6so25306603ois.1; Mon, 06 Aug 2018 16:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dr6bD/jWDLVzyDzhBEQSjBVlycw+s4X4ei2OzivsGgY=; b=n8sdHqYAskbg7CtaoFIf/aRhbfv6sCO1+02+aW1s19U38v3nTSZMJzJC3ziw4IzRGp SsZAJ4+mYocxH6PNi3ZyYy/CHok1SZ1sMjAA3zpZk+L+BLilc0veqytXofjxLRFQPJG+ ysWAoQAgnms00rq2XfkbVMTbGrQBEo6fKzdxGmTQ+Kb20HMwaMjb8H3N2/Qoy9yKFHpa e0jysm4TAsQMkmHo+BBK4nDsEaV7iZiEaSUxb7w9XlCj5fygYlEkKPrXqHgnqWkb5wBL ZCthrWPN8sfrT7kPo8QUXpbsBZ/0p4Fsr83OTNBbqkpDJhnTNtiXkifwoIUHRWq6dnG6 OgmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dr6bD/jWDLVzyDzhBEQSjBVlycw+s4X4ei2OzivsGgY=; b=gz+UV3tHwghaEdenAcYJrUV1i0Dk1aauXMMUt2OBHMdQgd9ky4K73rrbPNzePMOAn/ I6UOFRCjdTKDbF8YEF4qtqjKSdh7iOBYxxDgGn5NZGO5RX+kTaSLVpdkKBb54rajn6VE 9jQDvE4Xy0gvrkSAT+3MNSMji2eTxn5dScVeCJyynmnWkSX/pjo7ZbEawgnAkcC8jkl2 WSBN1MEkqI+9680uyJjPvtkeRZBzAlU2O+UzaXGXIPVVwVdHGzd+UBWK6ZPXX+oY6ov4 c+9NZJ1ig2mg0ME1QOQHx7A7W8sK1xO+IfQVET6iUXnJ9unn1XIQ0UDSMpI+MaQ9XsMT Jdow== X-Gm-Message-State: AOUpUlEoJ+x77DAhjAoug50fTuzgxCUYW71hafxZ/b46d3M5Dk0cJrT3 j/SfL4r92wiu8chGxAH3WbKQjreijaQ= X-Google-Smtp-Source: AAOMgpeNTL+cRNAu8Zdz1+IUcwIa2wgZRxCGTZYNzLJLv3i0coa8OkRSkrx+LlQWL9pd9Wh5l/8prA== X-Received: by 2002:a54:4f94:: with SMTP id g20-v6mr17342767oiy.130.1533597996617; Mon, 06 Aug 2018 16:26:36 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:36 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 3/9] bnxt_en: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:37 -0500 Message-Id: <20180806232600.25694-3-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 4394c1162be4..4b3928c89076 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -8909,7 +8909,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) netdev_info(dev, "%s found at mem %lx, node addr %pM\n", board_info[ent->driver_data].name, (long)pci_resource_start(pdev, 0), dev->dev_addr); - pcie_print_link_status(pdev); return 0; From patchwork Mon Aug 6 23:25:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558135 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 012EA174A for ; Mon, 6 Aug 2018 23:27:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E384A293CC for ; Mon, 6 Aug 2018 23:27:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D6EC7294C2; Mon, 6 Aug 2018 23:27:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DDEE294C2 for ; Mon, 6 Aug 2018 23:27:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387695AbeHGBiH (ORCPT ); Mon, 6 Aug 2018 21:38:07 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36451 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387557AbeHGBiG (ORCPT ); Mon, 6 Aug 2018 21:38:06 -0400 Received: by mail-oi0-f66.google.com with SMTP id n21-v6so25323219oig.3; Mon, 06 Aug 2018 16:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4xvs0w0N34TXyC9C+D5prP5itXqvnv+RfR86wouk0kk=; b=jmHGRLdipkwGcIVNGZSA/5abo4KZz9QoJ2CujiDhYmjx7S5vhKy1m7EbttvWkFOSbI bQy7spZ0zFAnY1ajUUglsSasOpC5E8C3aLfZEoDIWQyK0xfJfgQxCUdldjL8RFzn3PJr O9oFhh4nqv7ZFEveR6ITOnOrHPHqyyJSg5QC9w6X6YJGDriaEzKO7KZtLSvAjb1hM8VK Bf4TS4Y/R3Kl5qHm836cnvbx6RNZcCouI47P3Q7/WC/MBXA5lsX2zaCrQMe4pkFmSAb/ 0deO0tGjHjOfPQd8elnfEbH+CShDPXrSUSobuEBjos8qwELw6Z/I0AzmhOScP/2aWEZg FbaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4xvs0w0N34TXyC9C+D5prP5itXqvnv+RfR86wouk0kk=; b=rbTSzrZf8c2dQlnDdUwoM7/vE57ccDEpxDFvnBaILHlJfVRRZKM5RyCWm8e+8FX/T+ QRPAlkLSXTTq40NaXQ7hQBYaZG91ErIprn7ywRjVrdAHzM5Bk46TcEABTNMREfLKLn0S 4+cdSf8ce9HGmH41xrtf/DI9TjybadMoyItLqGbFfsMhwTGWxh+xrF8zKYmTZgcgdIVP kWHT20B4FT54omqkHpsgg+TMKlQiKIdf0qnajOmU1YSDWSati0mP2QZkR+Oq6b2D4eYe GvG6gynl079LrRob2xcB7CB5IpYZcpeOyJ87c9o+1rnwbwcwJLaRbWtql0YHcMi7ED2h U5fg== X-Gm-Message-State: AOUpUlHFb17K96OpSgIRjzOnO4VTOqnPQtFDf2Oo21hu0a1OIZvh88zF fpSEK4eqhRJ843DXyZbE7m48HEH7DWs= X-Google-Smtp-Source: AA+uWPybWOBtCGsptH4SXYTvRhwz1Sf4nFnZmWUZ0PHWrU1XYI/lhZX1mdk+y8qbZ4ZWQgK8CEeCYw== X-Received: by 2002:aca:d0cc:: with SMTP id j73-v6mr15607295oiy.255.1533598002124; Mon, 06 Aug 2018 16:26:42 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:41 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 4/9] cxgb4: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:38 -0500 Message-Id: <20180806232600.25694-4-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index a8926e97935e..049958898c17 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -5726,9 +5726,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) free_msix_info(adapter); } - /* check for PCI Express bandwidth capabiltites */ - pcie_print_link_status(pdev); - err = init_rss(adapter); if (err) goto out_free_dev; From patchwork Mon Aug 6 23:25:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558113 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 05B9B157B for ; Mon, 6 Aug 2018 23:26:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8714293CC for ; Mon, 6 Aug 2018 23:26:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DCA9B29530; Mon, 6 Aug 2018 23:26:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96123293CC for ; Mon, 6 Aug 2018 23:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388099AbeHGBiM (ORCPT ); Mon, 6 Aug 2018 21:38:12 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:43531 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387557AbeHGBiM (ORCPT ); Mon, 6 Aug 2018 21:38:12 -0400 Received: by mail-oi0-f66.google.com with SMTP id b15-v6so25246120oib.10; Mon, 06 Aug 2018 16:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=iKmZIRGfXgDKB9oSLC7FEPEbdY/XzOBNWfksKcwspfJ5G7Rj0ZPEA24fwh7F08JdTw by4uoy2qnaqKaFsREEH4xw1aTdL4NRfNmjo3iA7nFqPjJoW441mfZu6d8ULQYeBNuOAl gt6dox8ESElqOEVmJGiw99dBhML/EdXhDoDKNVfXfxcV2TgCdqtmnhIpsT91jFKWJMeF m2ENA73PjomI14CCBJOULlPqd/BksSSbZ/1xLVua9M+VIrDFkJ5JTW0WCK6KIKIeDfXT QlUk8GbpW0SkEZLL+CqdC45lN5lTFMZKuVfNN697pbE8aSPYhvs0b5wNSvYQfVv3Y0p0 yzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=OI6oFEQNKIoukT4EHQU5f9OKsZxEqLHCxzvQ2NtCJs3TYh/Tujkbvc3V90Lu5gc9+E 3a/3VAXLzqYXcfIBAiHsheSsFGS0aRDh/Dfa0DIU6vro2s5fNzLtOxA5MlfZUAB7yufG w2QmA+N2PncL1OrP2EO77TGMZJ/Eg492k7d5rtLQwx1+O+JlXxvwBreEUsWPgBREHF53 0bKjjlu1jyQakxWmK+BkSUJsTKytcSDZXkiC+Jc0+dVqvjFUqMmNkFl0s1BeOfr2Gz7H oSOFbqlfaSV0Qx1eCVS/K+qIdrkOmDnyjWmGUAMxwOJzGUqJ8cvo9MtbiXWzRdph/2zK QBsg== X-Gm-Message-State: AOUpUlG2UJXfRxKuwzHKG45RoJpkDBqIl9YkbSEyyZwlNmYZ4m9lRmjE 7PF1vISzwiEhMEtyINcpfkTroxPsfAk= X-Google-Smtp-Source: AA+uWPyoIcpOy7uJom0I5L4MC7SyIt5AiuJTfORTCTbNw+SVMpFR6Ewwb3eRMyGLDbNmJ1wbBOxeJQ== X-Received: by 2002:aca:cf87:: with SMTP id f129-v6mr17472388oig.258.1533598007425; Mon, 06 Aug 2018 16:26:47 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:47 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 5/9] fm10k: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:39 -0500 Message-Id: <20180806232600.25694-5-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 15071e4adb98..079fd3c884ea 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -2224,9 +2224,6 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* kick off service timer now, even when interface is down */ mod_timer(&interface->service_timer, (HZ * 2) + jiffies); - /* print warning for non-optimal configurations */ - pcie_print_link_status(interface->pdev); - /* report MAC address for logging */ dev_info(&pdev->dev, "%pM\n", netdev->dev_addr); From patchwork Mon Aug 6 23:25:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558117 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0FAF13B4 for ; Mon, 6 Aug 2018 23:27:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F29B293CC for ; Mon, 6 Aug 2018 23:27:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 90DAB29530; Mon, 6 Aug 2018 23:27:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D161293CC for ; Mon, 6 Aug 2018 23:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388464AbeHGBiT (ORCPT ); Mon, 6 Aug 2018 21:38:19 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:40007 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387557AbeHGBiS (ORCPT ); Mon, 6 Aug 2018 21:38:18 -0400 Received: by mail-oi0-f66.google.com with SMTP id w126-v6so25262262oie.7; Mon, 06 Aug 2018 16:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UCl4Lu6W1ZfIHNMUiiyuRZb9LsAG6du1KMvhVVIhXLw=; b=LpOzeXpzqzwoDKrcKx07OhhdknYQUOCebniUOF5i8Iie9C1feMfGSE4gz2/l4Wautc V7wYz4A8AaNvSFxSUBwkiZZU4wC8PLBQ2bAHAb6ZvCWQTidvVLEYNso0vLxWPGJa5Uy4 tN2zGsfRJXKzvTQ7F5IzLo3QAcyMMY2bBRYhymx0/KVtnbDwM+goY0UInUz34iqaHBP2 rqdExl8EW9h0/CHNMDLIfAC5gu0PlKK2qsDDScKxPiUjKABLxko2+sq642Rwnx590LRE XHkKRvMcgosvUaAQfCEhOaMuTiIq52QzpMetsj6tNz0Pp/8geIVDitNSzbscPMi8b1Ms tO9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UCl4Lu6W1ZfIHNMUiiyuRZb9LsAG6du1KMvhVVIhXLw=; b=hr43Q9zt/rm4akWvwx7uSppxOdL+EBvjO/l/l1jGX8YYR32WA3/XEO9DiESy9Bjf7a Z2yZ2JyB4r4rc2OeC/nAB8cKB3b0GAQiKk3Ix3P/fVzf4sXuT4EG1J6FWTRmQt+6OO1a jdVoFQmrK7Ri7gx13k3GXm/irie1LiVPHup+l/U5RsLanndKbngN0lIUdznAdrBtuivs 5aeLCuJitiotNOi3ghO67A1HbSUDgJno/WwkRpjinXrqR2htu+70NpWCOBCea1CVF6zU vk9M/3+CtRET11zsrOUkjMLHQjnv8qQyeZxlPVtO5ahEAxYYvvGjq4wn06PnKTtQ4esW Otgg== X-Gm-Message-State: AOUpUlHuUGpZDSbZ1L+e0bsrcteT4AIH9f3Vl/ugfAdEIjCyjfH25N9T 0fUCaPiP+CQm2FOkbLohBCoPvxgU/U8= X-Google-Smtp-Source: AA+uWPyWBaHlOBuson6UpSvREg5kVhqrpQFG4HoivVCwQ0d/9xUL04GO5wOkJI4318I5BZFofZn3Sg== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17850955oig.325.1533598014177; Mon, 06 Aug 2018 16:26:54 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:53 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 6/9] ixgbe: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:40 -0500 Message-Id: <20180806232600.25694-6-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 62e57b05a0ae..7ecdc6c03a66 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -241,28 +241,6 @@ static inline bool ixgbe_pcie_from_parent(struct ixgbe_hw *hw) } } -static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter, - int expected_gts) -{ - struct ixgbe_hw *hw = &adapter->hw; - struct pci_dev *pdev; - - /* Some devices are not connected over PCIe and thus do not negotiate - * speed. These devices do not have valid bus info, and thus any report - * we generate may not be correct. - */ - if (hw->bus.type == ixgbe_bus_type_internal) - return; - - /* determine whether to use the parent device */ - if (ixgbe_pcie_from_parent(&adapter->hw)) - pdev = adapter->pdev->bus->parent->self; - else - pdev = adapter->pdev; - - pcie_print_link_status(pdev); -} - static void ixgbe_service_event_schedule(struct ixgbe_adapter *adapter) { if (!test_bit(__IXGBE_DOWN, &adapter->state) && @@ -10585,10 +10563,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } - /* don't check link if we failed to enumerate functions */ - if (expected_gts > 0) - ixgbe_check_minimum_link(adapter, expected_gts); - err = ixgbe_read_pba_string_generic(hw, part_str, sizeof(part_str)); if (err) strlcpy(part_str, "Unknown", sizeof(part_str)); From patchwork Mon Aug 6 23:25:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558129 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8837157B for ; Mon, 6 Aug 2018 23:27:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A833A293CC for ; Mon, 6 Aug 2018 23:27:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C36029530; Mon, 6 Aug 2018 23:27:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50D78293CC for ; Mon, 6 Aug 2018 23:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733047AbeHGBiZ (ORCPT ); Mon, 6 Aug 2018 21:38:25 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:41827 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731432AbeHGBiZ (ORCPT ); Mon, 6 Aug 2018 21:38:25 -0400 Received: by mail-oi0-f68.google.com with SMTP id k12-v6so25234080oiw.8; Mon, 06 Aug 2018 16:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2bZ3Se4cgyGCiwuPr3El/TGVU5z5CMKd0ds0GHiAfTw=; b=GuUdyovGPckoK8zDcbACzemz3VMUxYLJ4C8kkYY2IvYBB/q9CLbiHBQwwLpnA5uYvc 608LeCsU3olh0nPqNFfdnKFArd655QmiT+oDi7GvfuQCh/RrXPGK5cI2anlc6pUC+feW Mi3Pms71GszwJMcY3uuLewF3iBRjwKjsWit6BcLHqATJlgNSwzFr/t5gK4dhkp/w5mNu d7FdJpVQ2CgXhWfvGjPtKNHUTtXIQU8CVIhz/eSUsdyTvb1mSvb/GXReoggjQTK7D+0t 8y6njYZyCnRh3clmTbvqBCHIAgCczr7AlPaFhzrOU7vo/Rs6snCCb274UbX0hxjd/I21 Y3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2bZ3Se4cgyGCiwuPr3El/TGVU5z5CMKd0ds0GHiAfTw=; b=ZVhohLDg5wVEsYZh9Sks99gz+JIN16aBR4Y5EyP8LwWxsLHPY0OjAHR/sXpu09zTSv AsSV4KiPs6yVeF767BPZIg2RhBnb1IFL+mrHKlza1hc0/qvH62DCXCIB8rw+VHTjkInR IB+4QrzNAn7T3kblcfshUX7/el3KmJ8NL06f4Qp2UfR7Cn4FF09/RDeUwbk3VnIXWcwm s3uC7RtDP9D8kG+QpykAsKS0eVlC7QcXeDJZrSAjQBgqmd2ZPGcqzhvjwQM9JE/h2+/D lamc1U5KLvRKcLwCYnQEBObOycG57NPvyg/DNHY2EU5ZGK5ycoF+uiZ6m6k4BM6FofRr BMPw== X-Gm-Message-State: AOUpUlF6z7YPtGI/UtJL4ppF/9r+VdUlpQ3a34ZJfKG7RUrcl+ihWrGJ U3Jnjt3Y25L1mOGsxFil+82LL6gmZwM= X-Google-Smtp-Source: AAOMgpeGISPLlKhVIqJgDC21UC9nd5l+l/0Kp71SpYw3ac98GEdfCzo3mejCOWHDqAXHXDcJZ1eivA== X-Received: by 2002:aca:4204:: with SMTP id p4-v6mr15426647oia.242.1533598020198; Mon, 06 Aug 2018 16:27:00 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:59 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 7/9] net/mlx4: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:41 -0500 Message-Id: <20180806232600.25694-7-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Reviewed-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx4/main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 872014702fc1..da4d54195853 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -3398,13 +3398,6 @@ static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data, } } - /* check if the device is functioning at its maximum possible speed. - * No return code for this call, just warn the user in case of PCI - * express device capabilities are under-satisfied by the bus. - */ - if (!mlx4_is_slave(dev)) - pcie_print_link_status(dev->persist->pdev); - /* In master functions, the communication channel must be initialized * after obtaining its address from fw */ if (mlx4_is_master(dev)) { From patchwork Mon Aug 6 23:25:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558119 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68574157B for ; Mon, 6 Aug 2018 23:27:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57B3F293CC for ; Mon, 6 Aug 2018 23:27:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B45129530; Mon, 6 Aug 2018 23:27:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E9693293CC for ; Mon, 6 Aug 2018 23:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388559AbeHGBib (ORCPT ); Mon, 6 Aug 2018 21:38:31 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:45031 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731432AbeHGBia (ORCPT ); Mon, 6 Aug 2018 21:38:30 -0400 Received: by mail-oi0-f66.google.com with SMTP id s198-v6so25222481oih.11; Mon, 06 Aug 2018 16:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hmTl8/1fRiYZPHtNk6ThTZh2VqXnVbDxTlqsL3JkjaA=; b=vene/i5bbGvykssAvZFw0/PWoB9Ma7/wBHYXcIfp0z1kKroMtjf+bOoQLGEG8Mi638 WMqQEsBMrLA29DzYiEAHzGa2R+9DK5pc3kanO5o4hJRgRUhp9K4CSsqtePVYKQpWSLIa wY6KT6uEgzlqeqr+an8uf/yNWWIeGmOeg6cwIHWtrqPrxb0YSu9lvoZJfhYOKOzKfxfH ZfBrug+CTEsV2Od9lR3fYMcy5LLK3nn9Onag5rJjdyp6nFwqyuUitpI6YCfR+UN9g5UA wlEGJJh2Koa4NfgOjll3KZHO2s1eaDcxP8eZovRhh2vtGpAQOt0gcqb0hbJFjrlleUG3 4yJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hmTl8/1fRiYZPHtNk6ThTZh2VqXnVbDxTlqsL3JkjaA=; b=F8eV4ClJQGfxQYXfyT0AO3Ohne7C21Tp9ry8FdoPw7UwwmHyhE6m0UaXFbDIUIF7vO bH7hLSx2SYcbu5Bqo9AQQFOOMKCfAh+N/0ZEBLFRNIapKKtyOj40ZNvAGQxu2fTgfMxt 1OiA+CP98HexizRRkGbjVDGESPqWVvej1ux3TiG7ryw3OR3kdptvHyMTHFKEruwqHtjN PE7bB4Hl9FarKO73+d0D3r+hgbnzqDKNI0qM+PDoEBx+zMKCqAkS92rPFcOd/1vyct1x UNSH/J7EeYZVlhiZJ031EXvJWyKEe82t3eyuryco+5ivo7uuW7mjF4q8gQZ7AICwEJKn kkLQ== X-Gm-Message-State: AOUpUlHUEPyEr6epmN+BAEe0llTtBElko/RGU7F2VoC6dz6UO6CVNYAo nMk+O3ru+Ee1aTiYNWN9z7MF+FYOgUA= X-Google-Smtp-Source: AAOMgpewaBmZ3Hx9zpVKNq6Ibe5ag++4mpSRQyPOTkZUlk6p8Vmg8wWx1x+DWynbGTI7w4yAS9H9dw== X-Received: by 2002:aca:bec2:: with SMTP id o185-v6mr17721451oif.22.1533598025648; Mon, 06 Aug 2018 16:27:05 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.27.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:27:05 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 8/9] net/mlx5: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:42 -0500 Message-Id: <20180806232600.25694-8-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Reviewed-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 615005e63819..e10f9c2bea3b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -1045,10 +1045,6 @@ static int mlx5_load_one(struct mlx5_core_dev *dev, struct mlx5_priv *priv, dev_info(&pdev->dev, "firmware version: %d.%d.%d\n", fw_rev_maj(dev), fw_rev_min(dev), fw_rev_sub(dev)); - /* Only PFs hold the relevant PCIe information for this query */ - if (mlx5_core_is_pf(dev)) - pcie_print_link_status(dev->pdev); - /* on load removing any previous indication of internal error, device is * up */ From patchwork Mon Aug 6 23:25:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 10558123 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 369DC13B4 for ; Mon, 6 Aug 2018 23:27:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25988293CC for ; Mon, 6 Aug 2018 23:27:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19B2229530; Mon, 6 Aug 2018 23:27:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3925293CC for ; Mon, 6 Aug 2018 23:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388573AbeHGBig (ORCPT ); Mon, 6 Aug 2018 21:38:36 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:45296 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731432AbeHGBif (ORCPT ); Mon, 6 Aug 2018 21:38:35 -0400 Received: by mail-oi0-f66.google.com with SMTP id q11-v6so25217821oic.12; Mon, 06 Aug 2018 16:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/X5lGKWH77cyPJBOOmZPH/w7I6UAHHh4sZCzwZv18W0=; b=YOk4W9IjxiLVZkHPnCsVCW6pZQTlqCsPM3piMt++EZLeB1xyr7EHr0N6RBwh5mK/GE A1uuW77ZWCKJFsRmoncRcjJLm4L8QY8JByRFXvsepLQQ+QcLF7/MqwMPGHzdVWP6VbVP KbOqPr7yaHTBfGwCxr1H5CjlAct/PEmiDiCG3uwzUb10Czo2gZDpEiRN+qO6DkcNZrgA JsVysaJ3v/OF9h40p9Sp01SOKZhK+H5qG26qx2Z45mK7b2NCpaioPQx4MLJajDgb4ulp Cwnu6aTKIA8n+UlyjyAKdbpjSgttOUHJFPWEJldjffPE+1mh+1CDmz1bg6wzLFsBNAK/ q8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/X5lGKWH77cyPJBOOmZPH/w7I6UAHHh4sZCzwZv18W0=; b=V0YUnno89auKj1BsJKk6R04EPheV0J/XrD0eOqni6SvxpHtNuq0xkbCNW6n3Hrmktu 8SchCDoYVPcB4RQzz3/qN2H+9xTO99RPjUBr48NRz8JYxXfSVlbFkko4ZKKbp/aiza7o q2kukY7Vn09Tvi6Vnc+pU8rSjpWxa1a3co3kKmuJGq1eh2lB7e9PpdLi3fa+YjdlfjG3 IQbgaSmMvhcIZpsMaqpN2Xi6/lfhSwceL7bRPC/aJfhN612zTDh0rpSyvSbIqitV1R5w rLV1gooovA6Lw+2yM+y6b7glF4u2/HyLMneOVbK5MWgkT91o/XQUwlwqmF1WOi7rkyP3 wqYg== X-Gm-Message-State: AOUpUlF69VmmhYYkyf9ysQykqgaI/aNnIHVpijtf+qvyCTpg90Z2w0HI N/z5ju+broEYDaKaqAq+W/j4HS4AR9E= X-Google-Smtp-Source: AA+uWPyqepO3ACjQR+JzgMAiiErDXisUOThTd206MbmgwkSaf+BQ+HDjA/D/CYTgGPuwEQ1pJTCjcQ== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17851662oig.325.1533598030946; Mon, 06 Aug 2018 16:27:10 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.27.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:27:10 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH v6 9/9] nfp: Do not call pcie_print_link_status() Date: Mon, 6 Aug 2018 18:25:43 -0500 Message-Id: <20180806232600.25694-9-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c index 749655c329b2..0324f99bd1a7 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c @@ -1324,7 +1324,6 @@ struct nfp_cpp *nfp_cpp_from_nfp6000_pcie(struct pci_dev *pdev) /* Finished with card initialization. */ dev_info(&pdev->dev, "Netronome Flow Processor NFP4000/NFP6000 PCIe Card Probe\n"); - pcie_print_link_status(pdev); nfp = kzalloc(sizeof(*nfp), GFP_KERNEL); if (!nfp) {