From patchwork Thu Dec 20 20:31:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 10739573 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 43F016C5 for ; Thu, 20 Dec 2018 20:32:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33EAF28AFF for ; Thu, 20 Dec 2018 20:32:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 253D328CFD; Thu, 20 Dec 2018 20:32:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA15928AFF for ; Thu, 20 Dec 2018 20:32:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B21988E000D; Thu, 20 Dec 2018 15:32:14 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id ACFA98E0001; Thu, 20 Dec 2018 15:32:14 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C03F8E000D; Thu, 20 Dec 2018 15:32:14 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by kanga.kvack.org (Postfix) with ESMTP id 6C8A28E0001 for ; Thu, 20 Dec 2018 15:32:14 -0500 (EST) Received: by mail-qk1-f197.google.com with SMTP id a199so3064055qkb.23 for ; Thu, 20 Dec 2018 12:32:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=3KbUcF/61ap+Ec02cHiH+mAMooHTPMSIopsMW+QipbA=; b=Jp38P9vnNqZgrqQMigHy4mr1IIJKUiKTtfj0LIYqQMUmswEjRPofdyCGnrSvwXUr9U JTFPs9y0YD5zc1hnyRjI6kzWhPAeWEgaPWTTEjnTVPK/Mxuj3mAUZLLTNwxrfiX62Rwi CSkqkzO8fucsPb/CawFuTiwU/VXXSWrGQ5z3HkSdIsbSf4yfxCvIznVwfVHfk6v4sTU4 bbt5uGatY343kCHYlcM44SqveM7YEULAzfZMysMaFRlqBdOQx7R6VoEl6Q3x9Ip7EZEU Vm80cCDgufRXX+IXLey2ykcVwytW1MY8wzZwxzCIvBryXdDZ3XcQOjsaEwzVbxbVBvjQ 6wMQ== X-Gm-Message-State: AA+aEWZ4LRZpMAXoos60+dxx009PxW/g+89ehsZAWagq3LuCMIhQiacB kCrxGnwCb6kNBNRRV3k9bNP6JiezCzGKJtRl+UjE/u6wCO94qHm03xSpvVrAWVNuOFBh9wX7Wf7 I/+D4rmP04P4UA8fyVriK0nUWMkaxI6ylzA5wSahnME4Hq7JcupbjwCzzURrhyoo1Vl0bFNFd2B Qs0I+CCWXuoSqkshlrh1gVjZ5Nnj+tukgx7uud4Y4Ht2+x6fb2tsmaEMjjfcNH+c5VhxvvusbHQ D8EE+h2I/YHsURBvyb3UcN+GlYS14lzInT8otXLCpFuTb9NmM+sJnC2h02xVqAvvTrRnbpJDT52 h9Ls72y9KKpQjnx+X2mjcmahsV+I+8TCcPCH3wLkbCUXfKhIsSSKM19RgrEiewnvzrMbXxeLz9y j X-Received: by 2002:ac8:7644:: with SMTP id i4mr11702578qtr.293.1545337934169; Thu, 20 Dec 2018 12:32:14 -0800 (PST) X-Received: by 2002:ac8:7644:: with SMTP id i4mr11702527qtr.293.1545337933329; Thu, 20 Dec 2018 12:32:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545337933; cv=none; d=google.com; s=arc-20160816; b=YQ4vycd8xQfpJJP5N8r4wuP1iZJYiy9NyMx4d3SjqvTWI6UecWidLcV6rb6QHmEKXh Po76o91eX8mBTT10GB5uuef2LlkIbNglz1Hw3ORxaOFJwk/+bFxepd6eG9rRBgKNCQvN CktUPdZkPkhVugMEbyjTNLyHjw14O0HpLHbWN+2HCenyopLX2MYO13QyVsqeceMMdaEi 1nSKqGbEJ6SalyYP+QD/ONAfTR21DDeScVSEUIRi0b0YTC0JwLo2vv3o0kLFz3LHXQMj zVXY94/LAuvXugkEkYvw54Nqkvu3r8EMuQOx3OQw0pRpobppbedw0FvmsK0cWH7y+pz7 yAYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3KbUcF/61ap+Ec02cHiH+mAMooHTPMSIopsMW+QipbA=; b=h8/uFHJO7rKhYFd/xsb2vTBskQHatnYc50cTBdQmp3t1nnYq7pLJn7KUXYxkk+Hyc+ lUf/RLEJuW02iQRVigS9u+8Deeg8uwSFKnZGtAUfj2IA7FetyTndubGjcGvWsgHosPDc wlavZUITPYDzAFmM0OJv0v5F+nSl0oeGwu1VI2N8WRS+rY6WL0qTsAilbeTsfPV5P0nd zJRIeCnfOQc9XysCRqegsc2seRB8zgdYzLxpfRJVWexw3oXc634z79Q1dzGmfMdDDVML Dnw2z/p7J0s/WO8aGp6MlUejsK4bY0/1fyW7n3dySgyei7jC7uQlsYfZ3tnhNvqpvlIA 1t7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=DJ9thbX4; spf=pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) smtp.mailfrom=cai@lca.pw Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b6sor8610691qtq.6.2018.12.20.12.32.13 for (Google Transport Security); Thu, 20 Dec 2018 12:32:13 -0800 (PST) Received-SPF: pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=DJ9thbX4; spf=pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) smtp.mailfrom=cai@lca.pw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3KbUcF/61ap+Ec02cHiH+mAMooHTPMSIopsMW+QipbA=; b=DJ9thbX4dJu+ss6h9B0lnkIK7Fewk/C+ZdK+WW8jqjUwOdMHmXwgUI4Ie62OFdYYV5 jC7GLEL+8nox3a+cq4Ki2dOToQIBzZcf7p20Qv8KbqdZtgsCLmwGFzJI61dAEdGA1Ty+ ViRy0niaIwec5DC1yHFYaEKNtd3ryjQH7fxDbYVWB3z9Jwp4rDN7WPBo3ejwFvkE8wfZ zB02qONXvsWfX2nmNjTJOwG9uudLtL5ri5Ho0RSaGw5e2Nns0k0TixedJMtvUfNLNY7A MmP7Eb6akR+32tn6aqBuxKUNG+NouHS9bsw5PTsgN+x++XpSwgLTvK3y1FWF+aiAaJIf 3Cww== X-Google-Smtp-Source: AFSGD/UCarTPfH/DXw0wQohHHgM+PhqJB4pNNWO9W+wXszchfubFEMaJ6+5KDRtx7C2jbh2MsoscLA== X-Received: by 2002:ac8:7153:: with SMTP id h19mr26501039qtp.92.1545337933063; Thu, 20 Dec 2018 12:32:13 -0800 (PST) Received: from ovpn-120-55.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id e17sm4653345qte.12.2018.12.20.12.32.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 12:32:12 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: mhocko@suse.com, Pavel.Tatashin@microsoft.com, mingo@kernel.org, hpa@zytor.com, mgorman@techsingularity.net, iamjoonsoo.kim@lge.com, yang.shi@linaro.org, tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH v3] mm/page_owner: fix for deferred struct page init Date: Thu, 20 Dec 2018 15:31:56 -0500 Message-Id: <20181220203156.43441-1-cai@lca.pw> X-Mailer: git-send-email 2.17.2 (Apple Git-113) In-Reply-To: <20181220185031.43146-1-cai@lca.pw> References: <20181220185031.43146-1-cai@lca.pw> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP When booting a system with "page_owner=on", start_kernel page_ext_init invoke_init_callbacks init_section_page_ext init_page_owner init_early_allocated_pages init_zones_in_node init_pages_in_zone lookup_page_ext page_to_nid The issue here is that page_to_nid() will not work since some page flags have no node information until later in page_alloc_init_late() due to DEFERRED_STRUCT_PAGE_INIT. Hence, it could trigger an out-of-bounds access with an invalid nid. [ 8.666047] UBSAN: Undefined behaviour in ./include/linux/mm.h:1104:50 [ 8.672603] index 7 is out of range for type 'zone [5]' Also, kernel will panic since flags were poisoned earlier with, CONFIG_DEBUG_VM_PGFLAGS=y CONFIG_NODE_NOT_IN_PAGE_FLAGS=n start_kernel setup_arch pagetable_init paging_init sparse_init sparse_init_nid memblock_alloc_try_nid_raw Although later it tries to set page flags for pages in reserved bootmem regions, mm_init mem_init memblock_free_all free_low_memory_core_early reserve_bootmem_region there could still have some freed pages from the page allocator but yet to be initialized due to DEFERRED_STRUCT_PAGE_INIT. It have already been dealt with a bit in page_ext_init(). * Take into account DEFERRED_STRUCT_PAGE_INIT. */ if (early_pfn_to_nid(pfn) != nid) continue; However, it did not handle it well in init_pages_in_zone() which end up calling page_to_nid(). [ 11.917212] page:ffffea0004200000 is uninitialized and poisoned [ 11.917220] raw: ffffffffffffffff ffffffffffffffff ffffffffffffffff ffffffffffffffff [ 11.921745] raw: ffffffffffffffff ffffffffffffffff ffffffffffffffff ffffffffffffffff [ 11.924523] page dumped because: VM_BUG_ON_PAGE(PagePoisoned(p)) [ 11.926498] page_owner info is not active (free page?) [ 12.329560] kernel BUG at include/linux/mm.h:990! [ 12.337632] RIP: 0010:init_page_owner+0x486/0x520 Since there is no other routines depend on page_ext_init() in start_kernel(), just move it after page_alloc_init_late() to ensure that there is no deferred pages need to de dealt with. If deselected DEFERRED_STRUCT_PAGE_INIT, it is still better to call page_ext_init() earlier, so page owner could catch more early page allocation call sites. This gives us a good compromise between catching good and bad call sites (See the v1 patch [1]) in case of DEFERRED_STRUCT_PAGE_INIT. [1] https://lore.kernel.org/lkml/20181220060303.38686-1-cai@lca.pw/ Fixes: fe53ca54270 (mm: use early_pfn_to_nid in page_ext_init) Suggested-by: Michal Hocko Signed-off-by: Qian Cai Signed-off-by: Qian Cai Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- v3: still call page_ext_init() earlier if DEFERRED_STRUCT_PAGE_INIT=n. v2: postpone page_ext_init() to after page_alloc_init_late(). init/main.c | 5 +++++ mm/page_ext.c | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/init/main.c b/init/main.c index 2b7b7fe173c9..5d9904370f76 100644 --- a/init/main.c +++ b/init/main.c @@ -696,7 +696,9 @@ asmlinkage __visible void __init start_kernel(void) initrd_start = 0; } #endif +#ifndef CONFIG_DEFERRED_STRUCT_PAGE_INIT page_ext_init(); +#endif kmemleak_init(); setup_per_cpu_pageset(); numa_policy_init(); @@ -1147,6 +1149,9 @@ static noinline void __init kernel_init_freeable(void) sched_init_smp(); page_alloc_init_late(); +#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT + page_ext_init(); +#endif do_basic_setup(); diff --git a/mm/page_ext.c b/mm/page_ext.c index ae44f7adbe07..d76fd51e312a 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -399,9 +399,8 @@ void __init page_ext_init(void) * -------------pfn--------------> * N0 | N1 | N2 | N0 | N1 | N2|.... * - * Take into account DEFERRED_STRUCT_PAGE_INIT. */ - if (early_pfn_to_nid(pfn) != nid) + if (pfn_to_nid(pfn) != nid) continue; if (init_section_page_ext(pfn, nid)) goto oom;