From patchwork Fri Dec 21 12:52:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Yan X-Patchwork-Id: 10740407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E578414E2 for ; Fri, 21 Dec 2018 13:02:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D36E128755 for ; Fri, 21 Dec 2018 13:02:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C57DB2875A; Fri, 21 Dec 2018 13:02:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 077AD28755 for ; Fri, 21 Dec 2018 13:02:56 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 18419267AD1; Fri, 21 Dec 2018 13:53:19 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 41097267AD1; Fri, 21 Dec 2018 13:53:16 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by alsa0.perex.cz (Postfix) with ESMTP id D7130267AC5; Fri, 21 Dec 2018 13:53:10 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id b7so2571603pfi.8; Fri, 21 Dec 2018 04:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:date:mime-version :content-transfer-encoding; bh=J1m6x7pxDixJ9cXxtAdrjWbVk6gaNAzSRK15mjPZC0I=; b=cV0+Wr+/4u6syVNnmwktuqUMnohimQSyKVCVSOXmwNR4EzbElMPj95i5ef+v0i17uG NsPTRZcgTWrix6UxcmcrWi+7U+BwaYYp8OTb42P3AjFZ/BQFOpFeqfTYZgHCRLXcUPJi AUqEymRcSBwiXooAeZcvLo+f32SY2/sqWiTHCxb33ZOjzfx3BWe5hqrhj3u3AH1G44Vt r5/3L/oBXFH3mIhB6+BgQyAEO8HS9xhfwLLtF9rejCBPYfkPrZ5r9uZWVCAVls5z5jg7 /aN0o4KZm7Cg+sxtG9aHk8BWgpB+ekVTlxmUxga1SPov7+0ubnRqml2xwZn2FJl5Fnvz 5O4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:date:mime-version :content-transfer-encoding; bh=J1m6x7pxDixJ9cXxtAdrjWbVk6gaNAzSRK15mjPZC0I=; b=s9uvossC/zUOQy6dlraTCoo33nQnvk3DqGF/NHnIcH9QH26VaRx4dOP1kLv7VWzuGH TiMYZNz+cvTRKJyyJbd0qPCQqDzAoKLwUTM2MUg5WpFQSeKARSw8CSEyZfdmtXHFbXx5 5bMomgTzF+dbnk1WvfxaaEUKLJx1LEcZkVGvpzA3ptYxfp24sWpqmcMuEU5dpGs5C7df hn9c+YXJVnpK+7RO7awQHuXFEQQab/ov3BCRlEeoOXv88Sa/h4d6oZL+W/AxMTC5oVnp /lItllKfOtCRXsznKc/5xyz85kxqnw2UqcXgt8jaY/WgWEoIzEKNNl55I3HmiKjmQIkt eC+A== X-Gm-Message-State: AA+aEWasY3Eb+mXgHTks2oqO3eKsjIvQSQ7VdSyXzehmKejnak9rjBDb bQYmIX6PLNFomyaF2L8V8bjb3NTmos8= X-Google-Smtp-Source: AFSGD/Xs41+ptZypsb4p1HAJQQ5hdXGnZJVTlczzZy/3vOm3vhr6a1NO6a5noruoXcKJxp5NxdQPzg== X-Received: by 2002:a62:6ec8:: with SMTP id j191mr2414976pfc.198.1545396788728; Fri, 21 Dec 2018 04:53:08 -0800 (PST) Received: from localhost.localdomain (123202047155.ctinets.com. [123.202.47.155]) by smtp.gmail.com with ESMTPSA id d129sm35387904pfc.31.2018.12.21.04.53.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Dec 2018 04:53:08 -0800 (PST) Message-ID: <5c1ce234.1c69fb81.b937c.ee4a@mx.google.com> X-Google-Original-Message-ID: <20181221125257.1631-1-me> From: tom.ty89@gmail.com X-Google-Original-From: me To: patch@alsa-project.org Date: Fri, 21 Dec 2018 20:52:57 +0800 X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Tom Yan Subject: [alsa-devel] [PATCH 1/1] ALSA: oxygen: initialize spdif_playback_enable to 0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tom Yan There's no reason for us to do that while we initialize dac_mute to 1. Also oxygen_init() has been clearing the OXYGEN_SPDIF_OUT_ENABLE bit anyway. Signed-off-by: Tom Yan diff --git a/sound/pci/oxygen/oxygen_lib.c b/sound/pci/oxygen/oxygen_lib.c index b4ef5804212d..6a743c878415 100644 --- a/sound/pci/oxygen/oxygen_lib.c +++ b/sound/pci/oxygen/oxygen_lib.c @@ -373,7 +373,7 @@ static void oxygen_init(struct oxygen *chip) for (i = 0; i < 8; ++i) chip->dac_volume[i] = chip->model.dac_volume_min; chip->dac_mute = 1; - chip->spdif_playback_enable = 1; + chip->spdif_playback_enable = 0; chip->spdif_bits = OXYGEN_SPDIF_C | OXYGEN_SPDIF_ORIGINAL | (IEC958_AES1_CON_PCM_CODER << OXYGEN_SPDIF_CATEGORY_SHIFT); chip->spdif_pcm_bits = chip->spdif_bits;