From patchwork Fri Dec 17 18:47:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goffredo Baroncelli X-Patchwork-Id: 12685553 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26676C433F5 for ; Fri, 17 Dec 2021 18:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236736AbhLQSzf (ORCPT ); Fri, 17 Dec 2021 13:55:35 -0500 Received: from santino.mail.tiscali.it ([213.205.33.245]:54238 "EHLO smtp.tiscali.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234200AbhLQSze (ORCPT ); Fri, 17 Dec 2021 13:55:34 -0500 Received: from venice.bhome ([78.12.25.242]) by santino.mail.tiscali.it with id XWnC2600L5DQHji01WnDcv; Fri, 17 Dec 2021 18:47:14 +0000 x-auth-user: kreijack@tiscali.it From: Goffredo Baroncelli To: linux-btrfs@vger.kernel.org Cc: Zygo Blaxell , Josef Bacik , David Sterba , Sinnamohideen Shafeeq , Goffredo Baroncelli Subject: [PATCH 1/2] btrfs-progs: new "allocation_hint" property. Date: Fri, 17 Dec 2021 19:47:04 +0100 Message-Id: <21fcdf5d4186555b743190e62ad3011c08aaad9b.1639766708.git.kreijack@inwind.it> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Reply-To: Goffredo Baroncelli MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tiscali.it; s=smtp; t=1639766834; bh=EBQGw5ocCmllZyzg9Tx8p3jcFBIHoHjEuVDSBrSBC+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To; b=6NEoDNu62QLBTQmY9Vo1qB4A5W0QoagaIOFQFpabF9mXUESfZ8kn2ZE4sZ4trYNGV 7iR8dfm543wBZfMJl2q1gkRjzFDkDNjeTiR6bsWIQsPf1UIQB1dplGO24QLGUKmDuN 1zAdFeU7jH0vDAzkAOCke2BTibuyIl7x5jI25/WU= Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Goffredo Baroncelli Handle the property allocation_hint of a btrfs device. Below an example of use: $ # set a new value $ sudo btrfs property set /dev/vde allocation_hint DATA_ONLY $ # get the current value $ sudo btrfs property get /dev/vde allocation_hint devid=4, path=/dev/vde: allocation_hint=DATA_ONLY The following values are availables: - DATA_ONLY - PREFERRED_DATA (default) - PREFERRED_METADATA - METADATA_ONLY Root privileges are required. Signed-off-by: Goffredo Baroncelli --- cmds/property.c | 204 ++++++++++++++++++++++++++++++++++++++++++ kernel-shared/ctree.h | 13 +++ 2 files changed, 217 insertions(+) diff --git a/cmds/property.c b/cmds/property.c index 59ef997c..e6a38ee1 100644 --- a/cmds/property.c +++ b/cmds/property.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include "cmds/commands.h" @@ -30,6 +31,7 @@ #include "common/open-utils.h" #include "common/utils.h" #include "common/help.h" +#include "common/path-utils.h" #define XATTR_BTRFS_PREFIX "btrfs." #define XATTR_BTRFS_PREFIX_LEN (sizeof(XATTR_BTRFS_PREFIX) - 1) @@ -232,6 +234,202 @@ out: return ret; } +static int btrfs_find_devid_and_mnt(const char *devpath, int *devid, + char *path, int maxpath) +{ + int ret, i, fd; + DIR *dir; + struct stat stdevpath; + struct btrfs_ioctl_fs_info_args fi_args; + struct btrfs_ioctl_dev_info_args dev_info; + + ret = get_btrfs_mount(devpath, path, maxpath); + if (ret) + return ret; + + fd = btrfs_open_dir(path, &dir, 1); + if (fd < 0) + return fd; + + ret = stat(devpath, &stdevpath); + if (ret) { + error("cannot stat '%s'", devpath); + goto out; + } + + ret = ioctl(fd, BTRFS_IOC_FS_INFO, &fi_args); + if (ret < 0) { + if (errno == EPERM) + return -errno; + error("cannot get filesystem info: %m"); + ret = -10; + goto out; + } + + for (i = 0 ; i <= fi_args.max_id ; i++) { + struct stat st; + + memset(&dev_info, 0, sizeof(dev_info)); + ret = get_device_info(fd, i, &dev_info); + if (ret == -ENODEV) + continue; + if (ret) { + error("cannot get info about device devid=%d", i); + goto out; + } + + if (!dev_info.path) + /* missing devices */ + continue; + + ret = stat((char *)dev_info.path, &st); + if (ret) { + error("cannot stat '%s'", devpath); + goto out; + } + + if (major(st.st_rdev) == major(stdevpath.st_rdev) && + minor(st.st_rdev) == minor(stdevpath.st_rdev)) { + *devid = dev_info.devid; + ret = 0; + goto out; + } + } + + ret = -12; + +out: + close_file_or_dir(fd, dir); + return ret; +} + +static struct ull_charp_pair_t { + u64 value; + const char *descr; +} allocation_hint_description[] = { + {BTRFS_DEV_ALLOCATION_HINT_PREFERRED_METADATA, "PREFERRED_METADATA"}, + {BTRFS_DEV_ALLOCATION_HINT_METADATA_ONLY, "METADATA_ONLY"}, + {BTRFS_DEV_ALLOCATION_HINT_PREFERRED_DATA, "PREFERRED_DATA"}, + {BTRFS_DEV_ALLOCATION_HINT_DATA_ONLY, "DATA_ONLY"}, + {0, NULL} +}; + +static int prop_allocation_hint(enum prop_object_type type, + const char *object, + const char *name, + const char *value, + bool force) +{ + int ret, devid, fd, fd2; + char path[PATH_MAX]; + DIR *dir; + u8 fsid[BTRFS_UUID_SIZE]; + char fsid_str[BTRFS_UUID_UNPARSED_SIZE]; + char sysfs_file[PATH_MAX]; + char filename[PATH_MAX]; + int i; + u64 v, devtype; + char buf[1024]; + + ret = btrfs_find_devid_and_mnt(object, &devid, path, sizeof(path)); + if (ret) + return -5; + + fd = btrfs_open_dir(path, &dir, 1); + if (fd < 0) + return fd; + + ret = get_fsid_fd(fd, fsid); + if (ret < 0) + goto out; + + uuid_unparse(fsid, fsid_str); + sprintf(filename, "devinfo/%d/allocation_hint", devid); + + /* build /sys/fs/btrfs//devinfo//type */ + ret = path_cat3_out(sysfs_file, "/sys/fs/btrfs", fsid_str, filename); + if (ret < 0) + goto out; + + fd2 = open(sysfs_file, O_RDONLY); + if (fd2 < 0) { + error("'allocation_hint' property not available or accessible."); + ret = -errno; + goto out; + } + + ret = read(fd2, buf, sizeof(buf) - 1); + close(fd2); + if (ret < 0) { + error("Unable to read the 'allocation_hint' property."); + ret = -errno; + goto out; + } + + buf[sizeof(buf) - 1] = 0; + devtype = strtoull(buf, NULL, 0); + + if (!value) { + /* READ */ + for (i = 0 ; allocation_hint_description[i].descr ; i++) + if (devtype == allocation_hint_description[i].value) + break; + if (allocation_hint_description[i].descr) + printf("devid=%d, path=%s: allocation_hint=%s\n", + devid, object, + allocation_hint_description[i].descr); + else + printf("devid=%d, path=%s: allocation_hint=unknown:%llu\n", + devid, object, + devtype); + ret = 0; + } else { + /* WRITE */ + for (i = 0 ; allocation_hint_description[i].descr ; i++) + if (!strcmp(value, allocation_hint_description[i].descr)) + break; + + if (allocation_hint_description[i].descr) { + v = allocation_hint_description[i].value; + } else if (sscanf(value, "%llu", &v) != 1) { + error("Invalid value '%s'\n", value); + ret = -3; + goto out; + } + if (v & ~BTRFS_DEV_ALLOCATION_HINT_MASK) { + error("Invalid value '%s'\n", value); + ret = -3; + goto out; + } + + devtype &= ~BTRFS_DEV_ALLOCATION_HINT_MASK; + devtype |= (v & BTRFS_DEV_ALLOCATION_HINT_MASK); + + fd2 = open(sysfs_file, O_RDWR); + if (fd2 < 0) { + error("'allocation_hint' property not available or accessible for updating."); + ret = -errno; + goto out; + } + + sprintf(buf, "%llu", devtype); + + ret = write(fd2, buf, strlen(buf)); + close(fd2); + if (ret < 0) { + error("Unable to update 'allocation_hint' property."); + ret = -errno; + goto out; + } + + } + + ret = 0; +out: + close_file_or_dir(fd, dir); + return ret; +} + const struct prop_handler prop_handlers[] = { { .name ="ro", @@ -254,6 +452,12 @@ const struct prop_handler prop_handlers[] = { .types = prop_object_inode, .handler = prop_compression }, + { + .name = "allocation_hint", + .desc = "hint to store the data/metadata chunks", + .types = prop_object_dev, + .handler = prop_allocation_hint + }, {NULL, NULL, 0, 0, NULL} }; diff --git a/kernel-shared/ctree.h b/kernel-shared/ctree.h index 966490d3..adc869fe 100644 --- a/kernel-shared/ctree.h +++ b/kernel-shared/ctree.h @@ -213,6 +213,19 @@ struct btrfs_mapping_tree { struct cache_tree cache_tree; }; +/* btrfs chunk allocation hints */ +#define BTRFS_DEV_ALLOCATION_HINT_BIT_COUNT 2 +#define BTRFS_DEV_ALLOCATION_HINT_MASK ((1ULL << \ + BTRFS_DEV_ALLOCATION_HINT_BIT_COUNT) - 1) +/* preferred metadata chunk, but data chunk allowed */ +#define BTRFS_DEV_ALLOCATION_HINT_PREFERRED_METADATA (1ULL) +/* only metadata chunk are allowed */ +#define BTRFS_DEV_ALLOCATION_HINT_METADATA_ONLY (2ULL) +/* only data chunk allowed */ +#define BTRFS_DEV_ALLOCATION_HINT_DATA_ONLY (3ULL) +/* preferred data chunk, but metadata chunk allowed */ +#define BTRFS_DEV_ALLOCATION_HINT_PREFERRED_DATA (0ULL) + #define BTRFS_UUID_SIZE 16 struct btrfs_dev_item { /* the internal btrfs device id */ From patchwork Fri Dec 17 18:47:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goffredo Baroncelli X-Patchwork-Id: 12685551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9073C433EF for ; Fri, 17 Dec 2021 18:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236346AbhLQSze (ORCPT ); Fri, 17 Dec 2021 13:55:34 -0500 Received: from santino.mail.tiscali.it ([213.205.33.245]:54240 "EHLO smtp.tiscali.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231979AbhLQSze (ORCPT ); Fri, 17 Dec 2021 13:55:34 -0500 Received: from venice.bhome ([78.12.25.242]) by santino.mail.tiscali.it with id XWnC2600L5DQHji01WnEdP; Fri, 17 Dec 2021 18:47:14 +0000 x-auth-user: kreijack@tiscali.it From: Goffredo Baroncelli To: linux-btrfs@vger.kernel.org Cc: Zygo Blaxell , Josef Bacik , David Sterba , Sinnamohideen Shafeeq , Goffredo Baroncelli Subject: [PATCH 2/2] Update man page for allocator_hint property. Date: Fri, 17 Dec 2021 19:47:05 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Reply-To: Goffredo Baroncelli MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tiscali.it; s=smtp; t=1639766834; bh=Jd5xPTtdoX67h8gRtajlyKkX1TaVEszE7qOM3Yug2qU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To; b=iSq5uWGVGDUgY9eymbaS4P/37hpFddcGlv+7+Cn6um42pbcM13CSOLy7HYvaLn6n+ 526272zverjEtYtdUR1OqZW2UbG1ryy5qkQNh/9mveY5So+Sp+E4mDzhLME1kzeQnR HdxySCQTKGwvWoHkEp3yn/lZB3u7MeRzCshHz4N0= Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Goffredo Baroncelli Update the man page of the btrfs property subcommand to show the use of the device property "allocation_hint". Signed-off-by: Goffredo Baroncelli --- Documentation/btrfs-property.asciidoc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Documentation/btrfs-property.asciidoc b/Documentation/btrfs-property.asciidoc index b32d000e..d9e9c4b9 100644 --- a/Documentation/btrfs-property.asciidoc +++ b/Documentation/btrfs-property.asciidoc @@ -49,6 +49,23 @@ device as object. For a mounted filesystem, specify a mount point. compression:::: compression algorithm set for an inode, possible values: 'lzo', 'zlib', 'zstd'. To disable compression use "" (empty string), 'no' or 'none'. +allocation_hint:::: +a device property that instructs how and when the allocator should use a +block device. +Possible values are: +- 'PREFERRED_METADATA': the device has an higher priority when a new metadata +chunk is allocated. Data chunk is allowed only if there is no other possibility. +- 'METADATA_ONLY': the device is used only for metadata chunk. +Data chunk is never allowed. +- 'PREFERRED_DATA' (default): the device has an higher priority when a new data +chunk is allocated. Metadata chunk is allowed only if there is no other +possibility. +- 'DATA_ONLY': the device is used only for data chunk. +Metadata chunk is never allowed. + :::: +The default is 'PREFERRED_DATA'; if all the disks have this setting the +allocator uses all of them with the same priority. + *list* [-t ] :: Lists available properties with their descriptions for the given object.