From patchwork Mon Dec 20 12:17:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 12687733 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B84A7C433F5 for ; Mon, 20 Dec 2021 12:18:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 77A50C36AE9; Mon, 20 Dec 2021 12:18:31 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 7037FC36AE7 for ; Mon, 20 Dec 2021 12:18:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 7037FC36AE7 Authentication-Results: smtp.kernel.org; dmarc=none (p=none dis=none) header.from=esmil.dk Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f48.google.com with SMTP id x15so37561799edv.1 for ; Mon, 20 Dec 2021 04:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5MjoT1+0/DxfRaDrfHuq3G2Ro753TQHUQ3NJ1EInTB8=; b=asURLhslDYv8u0hz6/SuebhiWI//nat9NpB5kq+pN2d/aqhC5+afz5SOacZPovSP66 7cY7zLIL7S7AZJ9Dwaqg01QDZNhcAVYpCgHycHZ5TuxttzMBSIzFB6s2OPqebRYKMte+ erBqtVDd3un7xI5DwnjGoqu/g2okL212HUGUlP46zHzdyPIKIUy5l+6JhnVwuYBFtb4c 6aqv2eAsnBdz3AMcxQfBCKSWAyF6A8wPSPOQ5bajcTPybLum+4mbNpsYEzAbLZBSP1D7 P0zQ6emNdMHp7ZnzrzI9nf1KViTJOB/jP/vNcWELh0W/UaNwf0CKe6dkLCKMH8H9RL9f Yk9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=5MjoT1+0/DxfRaDrfHuq3G2Ro753TQHUQ3NJ1EInTB8=; b=L2Ec/5mh5q4vfQ1olaywFog08qQsG/KGxIayAFbDxcfmSGZbhx+mf2sqiW2qrYE/6D OfT3/3pqFdfr5m/+tNk6jGkCx5aKn1c9APD7vMU+ovgCaiz2WxLb4e8T9eWeOawJcgzy gTuUj6tRoE+WKF39Yrek6ZBkYH45/waERwwp15S5Ob5D/zIgcup2yIXqW6cEPkurG8RV h3cMQ4KMDMt8+4Svao6WzyNijRCNR3olqJSXfxLGfNn3VlWspPlTPxbNEwKcvBtDsGli zVvZMKCINZrWr/NtybH5VhRmy2+lzbI2AtO9yWJIQ2iBM3FRSQbZcQaFOhdw6voC3ySX UUWA== X-Gm-Message-State: AOAM5333FymSQ9Ty+KaGIdTqxQmItBqWsZEc3EmnlEYkiP2De13jt4aN JSWRRFNbYFR8j7ZH9wF0Gx3zKNGaVss= X-Google-Smtp-Source: ABdhPJwLa4NjwySpR/porApfQAJrCybZbduz+D2HcKXFHEdJNYhPN4f3H+xMJ0pPM2T94UiqCR4raQ== X-Received: by 2002:a17:907:6d99:: with SMTP id sb25mr7780586ejc.540.1640002707716; Mon, 20 Dec 2021 04:18:27 -0800 (PST) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id i22sm2549481ejw.75.2021.12.20.04.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 04:18:27 -0800 (PST) Sender: Emil Renner Berthing From: Emil Renner Berthing List-Id: To: soc@kernel.org Cc: Emil Renner Berthing , Linux Next Mailing List , Linux Kernel Mailing List , Arnd Bergmann , Geert Uytterhoeven , Randy Dunlap , Stephen Rothwell , Philipp Zabel Subject: [PATCH -next] reset: starfive-jh7100: Fix 32bit compilation Date: Mon, 20 Dec 2021 13:17:59 +0100 Message-Id: <20211220121800.760846-1-kernel@esmil.dk> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 We need to include linux/io-64-nonatomic-lo-hi.h or readq/writeq won't be defined when compiling on 32bit architectures: On i386: ../drivers/reset/reset-starfive-jh7100.c: In function ‘jh7100_reset_update’: ../drivers/reset/reset-starfive-jh7100.c:81:10: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration] value = readq(reg_assert); ^~~~~ ../drivers/reset/reset-starfive-jh7100.c:86:2: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration] writeq(value, reg_assert); ^~~~~~ On m68k: drivers/reset/reset-starfive-jh7100.c:81:17: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Werror=implicit-function-declaration] drivers/reset/reset-starfive-jh7100.c:86:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[3]: *** [scripts/Makefile.build:289: drivers/reset/reset-starfive-jh7100.o] Error 1 make[2]: *** [scripts/Makefile.build:572: drivers/reset] Error 2 make[1]: *** [Makefile:1969: drivers] Error 2 make: *** [Makefile:226: __sub-make] Error 2 Reported-by: Randy Dunlap Fixes: 0be3a1595bf8 ("reset: starfive-jh7100: Add StarFive JH7100 reset driver") Signed-off-by: Emil Renner Berthing Acked-by: Randy Dunlap # build-tested --- drivers/reset/reset-starfive-jh7100.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-starfive-jh7100.c b/drivers/reset/reset-starfive-jh7100.c index e28a19d271cb..fc44b2fb3e03 100644 --- a/drivers/reset/reset-starfive-jh7100.c +++ b/drivers/reset/reset-starfive-jh7100.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include