From patchwork Tue Dec 21 16:18:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ajit Kumar Pandey X-Patchwork-Id: 12690017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65015C433EF for ; Tue, 21 Dec 2021 16:19:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 07CF91715; Tue, 21 Dec 2021 17:18:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 07CF91715 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640103586; bh=utTvJ3o4izp4ncLUwVrSoz04CD72QRjWMbQHet3bhPI=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Jc95TSSNZFcgbhztkr82L0Km9PDPiDYq5btQlUGnNN8kc7BvKrosvnaPCJck55oXK jt5zVM7DmQjF/7b+xwIjMgNrcv+8x5GGfh4O+aCa3Atgi7mksuCc26ilnGz0VcuH+A QARECUDcwUCig93FcOf1SfGG959bWHLCed7lH/EU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7D224F8010B; Tue, 21 Dec 2021 17:18:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30220F80118; Tue, 21 Dec 2021 17:18:53 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 291CCF800B5; Tue, 21 Dec 2021 17:18:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 291CCF800B5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="I6zy5kTk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3WlC9nRJDT1HTrsxu9kgqCXtm3IUSnB32URbxRGy4o1oe5CIdl19b4wWImlpe+SUmGY/2/yGYlWdrmR0SVseoVkaMBUOWNk6lprdhyCykrDQK9y5VrefQqx+xm/6FMyKDmxeDunDx+qVWDTepEy/nygblAMc8rgsk54my1tb2IoKBjPxI6SRYL6Cw3uKUCOWGzbwWDymDEU1Tnl6uDTdVa50FWeDoiBja9ZH6AEezRAAPV3U43OjCRaCm1hFLrjhl6sp9lJjWC3UiCO4sqZKJ3FqgswUKaBELpWfrlIR1Gzjckxgz8BQ92i7vbCYElYZamQvSpnsmSMj6DOEghe+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0JhfL/tWlEZs/2BnC5c+vVm4l5UDvIAgDih3fuPBcY=; b=cKMNuo0yBzJIq/UjELknHr17qEcmK52v27XwZo0MdwSp1fGtPeVjkqg/beT4ynz4asd60VvIs4NJx8sJT3wkLQi0Q1oFPpwPwxDwOlJZd0LvT/6JFgcsQZBO+x2QKQwjDdoYh99CTf+1dQAl2nGPIwHb0lfHed6TvZYPgHKllc8dCGKuGuYVB5xWcfnROlkQKhieppChhb4lsfGPGubr4rpzf/sNFW7PlSAa0MlIDE+y8SL4N2gfIZqxd98ks3ezPG+FNCmzS1ESI3SKSgYFFF0IpWhphqib3B8a6eJXPgrypjulVn+joATxZXTo+dqPz2lyScHL8/hnrQjhA0SvXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0JhfL/tWlEZs/2BnC5c+vVm4l5UDvIAgDih3fuPBcY=; b=I6zy5kTkEkvgEKRGDDmwZC6GilUMBqz1dldbhRq4pTbJhJPV3SBkzoBK1flz3kyyAghiNh7AugWlYRCBt08oKXBILiYkfs9I0LOBXDgdR95Fzd2VET6IyPgBd/wuQR4xY4TE+Jh5nSaHK6mVQP933s9GzIqamOSIBJuUSdUpqDE= Received: from DM6PR05CA0050.namprd05.prod.outlook.com (2603:10b6:5:335::19) by BYAPR12MB2599.namprd12.prod.outlook.com (2603:10b6:a03:6b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec 2021 16:18:36 +0000 Received: from DM6NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:5:335:cafe::99) by DM6PR05CA0050.outlook.office365.com (2603:10b6:5:335::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.14 via Frontend Transport; Tue, 21 Dec 2021 16:18:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT018.mail.protection.outlook.com (10.13.172.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 16:18:36 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:34 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:33 -0600 Received: from chrome.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 21 Dec 2021 10:18:29 -0600 From: Ajit Kumar Pandey To: , Subject: [PATCH 1/3] ASoC: SOF: AMD: simplify return status handling Date: Tue, 21 Dec 2021 21:48:07 +0530 Message-ID: <20211221161814.236318-1-AjitKumar.Pandey@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd2e92c1-9e70-4153-5e33-08d9c49d8a78 X-MS-TrafficTypeDiagnostic: BYAPR12MB2599:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s0DUIgs1AIkZbEmIfIVkgxjJ/lKcOBwwI2dyDlcmeFTckD4AZs7wCr+tbMqke/YdP1fRtFWbswr6wuOpH5wVoSpNVPJO3cfXhcEmK/vX8/tlZzIibx5ZM2HfI72Mg8GZzhWCTenHRagqUAk3TI+sPNlwlcFgef8t8DH5CnVDbh+pg9Qr6D5gzCwc8omdz3fCIK1ARUjdbsyEwfzuAk17eNc1s+drWWRiUamuZi1yFP9xuaKalWjc8cBxBGrvJehtfOiUwUBYoC5GIJ9cqYYDrUCXdilW3BBX+vgfGbi3jO1UzjeGa8I7KKCkZrdU5TxKeipNA80bNhM1iO9gehbe+Vb3abX+KV3QLeweo26sIt7UaGCCLWmWdJmRCpzdez3l/iWJDEmlBswCL2uDR0O8zvJmR8dbQgT5wMMzbUsf4i5zJY2+tLnMKbitBKWXiYAC9D6TwaSebiFdfS85I6fqDbf1p7CP6AiJlRH1QQtp8Mv6Rf1WGhlBGUU7hhI91he6I0Y+t/tqbeQvNlaSkH3XRa6ntjqDXO4ZgzebOhkxmMCu0RvhebIFcj5zpiZJ/NXiT7CnL7q8sPPAN+ZRaOS1PqEeE5dwNg0waX0vF1yf9dxvdAKLCwPri5oeQ6NCZ4U+Po4zt85tfiTCC4RWNvdiaDppjwJRyTQXQ1Esnsa+6TD2sd544nIaLmHo4QdgqH8Vy5VrKh+9XA0EnjOXWM/B9SoIp01tt1VN9/d+ZYtwBoIQAEGjBrzW8GnFBvsSj6acJ/rK1avnRC5TPnkrP58ssZzwqOw0D6IDx9QFYHYFtSQ= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700002)(8936002)(336012)(40460700001)(426003)(70586007)(82310400004)(47076005)(70206006)(26005)(508600001)(1076003)(110136005)(8676002)(83380400001)(4326008)(316002)(54906003)(66574015)(6666004)(2616005)(186003)(2906002)(356005)(81166007)(7416002)(86362001)(5660300002)(36860700001)(36756003)(7696005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 16:18:36.0752 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd2e92c1-9e70-4153-5e33-08d9c49d8a78 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2599 Cc: Sunil-kumar.Dommati@amd.com, open list , Ajit Kumar Pandey , Kai Vehmanen , Daniel Baluta , Basavaraj.Hiregoudar@amd.com, Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Vijendar.Mukunda@amd.com, Alexander.Deucher@amd.com, Takashi Iwai , =?utf-8?q?P=C3=A9ter_Ujfalusi?= , Bard Liao , "moderated list:SOUND - SOUND OPEN FIRMWARE \(SOF\) DRIVERS" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Pierre-Louis Bossart cppcheck warning: sound/soc/sof/amd/acp.c:222:9: warning: Identical condition and return expression 'ret', return value is always 0 [identicalConditionAfterEarlyExit] return ret; ^ sound/soc/sof/amd/acp.c:213:6: note: If condition 'ret' is true, the function will return/exit if (ret) ^ sound/soc/sof/amd/acp.c:222:9: note: Returning identical expression 'ret' return ret; ^ Just return 0; on success. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi --- sound/soc/sof/amd/acp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index 4c5550e8d364..fe9b7dc5bc86 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -219,7 +219,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, return -EINVAL; } - return ret; + return 0; } int acp_dma_status(struct acp_dev_data *adata, unsigned char ch) From patchwork Tue Dec 21 16:18:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Kumar Pandey X-Patchwork-Id: 12690021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70EBDC433EF for ; Tue, 21 Dec 2021 16:20:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AA1371777; Tue, 21 Dec 2021 17:19:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AA1371777 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640103636; bh=S16gPPuGlUxa/fk0hqnBOJP0ohxQom1wD6mS5J7t6MM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MMUdIEbsY+z7CzmL/4kH32Lo+rrYiav/m3CgpYeuhthiWu6zFxXFl8nEOxpO9GcYd WXUTIahOAkoVnh25vQhlw0d/2pIlFF9lQuWxJYh5FsRdpM7xH5Ld72rqxlEQiAR7cc gxoo+yATWkMaSB/C9I5ZZrgLv4WMNZfm/hmJDtM8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 28C3DF804E4; Tue, 21 Dec 2021 17:19:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9527CF804D9; Tue, 21 Dec 2021 17:19:15 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8B3AFF8032B for ; Tue, 21 Dec 2021 17:19:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8B3AFF8032B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="uFuJBoJU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aeyppFu7rp7MaKmLyRHO6bhHhSonpTvX1tUiA2XYL3OKtl6cSh8wS2/uog13dCYF4z+j7iO3zpYCDZOIsviVaokGTghzsdel2soKl17CMWD23mNZJdj/pzCrQRzlnfSZp8Iw+mmcUbupalEYenoJ/Tv1j1KWa0r3skwyEawsmmdJgoldf8QxF3D2vbISHeFynfPZv+V2UUOYH8NAanJCf2dMsOLmg0s4YR0CSRpLiEips0t6y/z2rQEVx2FjPwaU7mYdPstkbsclKMWpfte0N4CDtuL6MTL3NpBQ4pnota7PnOtuYB8v/98F0umge9uapU27E5EjEBeXGFCs+0QnvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6HOPp8SIaCsf8ymzbSkTja/Ct8WQHh4JyKDf7i6huNo=; b=L1OsAErwNkYPZVnFtlpzD5P9tvr7qGsa3BGuIjL68v9ARQHf2JVdhV1FZc1ku5BpEvLreShtMFOuq9bhfRlK9YQVsmz/52Ikj53qzG1UigBc8+YIrFOeTLycZ8OUWAd+OCy1LnnI063UaFTlmkvNmFgFYSMgSVsVuH4HFtCG+3fWivGKSJcRPD+oCyKsz53MvMOMTjwWYc3c28ttDIVX4/26oNNEj+9+UEb1R4plpzCfH+kF5WnqWy++aQXYSntLXXac5xq/N9GnPz5PzpbwieeJ0qw58YRx8A1BRkC2AQQM8fbPfPgL2eT3VlGR7h+FqXnIYpqJWcoi8d1jGhP2rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6HOPp8SIaCsf8ymzbSkTja/Ct8WQHh4JyKDf7i6huNo=; b=uFuJBoJUhgklZPVQD8hv2EBuvCJlxIlZxgalDCcWODhkhZA9T6Lc039u/OKp8DKkPWkdrt8fV6xpd7GYiZ9TJx7pXFGTL5mICQCGLZ5pqTiOAIk6xVypreCc81t31nYVws/zz672B0UYzu4oK8pgNlq8hj2SHYZyyexPvbsZZYE= Received: from DM5PR20CA0028.namprd20.prod.outlook.com (2603:10b6:3:13d::14) by DM5PR1201MB0060.namprd12.prod.outlook.com (2603:10b6:4:51::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec 2021 16:19:03 +0000 Received: from DM6NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:3:13d:cafe::75) by DM5PR20CA0028.outlook.office365.com (2603:10b6:3:13d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend Transport; Tue, 21 Dec 2021 16:19:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT005.mail.protection.outlook.com (10.13.172.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 16:19:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:48 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:47 -0600 Received: from chrome.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 21 Dec 2021 10:18:44 -0600 From: Ajit Kumar Pandey To: , Subject: [PATCH 2/3] ASoC: amd: acp-config: Enable SOF audio for Google chrome boards. Date: Tue, 21 Dec 2021 21:48:08 +0530 Message-ID: <20211221161814.236318-2-AjitKumar.Pandey@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211221161814.236318-1-AjitKumar.Pandey@amd.com> References: <20211221161814.236318-1-AjitKumar.Pandey@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 055c6ac4-8d34-4cb5-b85a-08d9c49d9a9d X-MS-TrafficTypeDiagnostic: DM5PR1201MB0060:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LkpNjV8vp1jtrbPhfSi+6MY5yuV3CcIyZswRz+i/QHt/DvxB1JInp10Jr39vQPfc/yEDbl2y5/lcHobRU+hY3uZXih70L+YDTZp/NwK8SqQ4AoZKMYO9lAo0jkDeQ4sze6kT55JWa/LugCO9dj35Y+0D7ZYxCBaMlKnBYWk5zO9OP3T206gtIWF0SX7Lru2626EhLGQ1hirGLFPQQZWfnKwLjJgfLNqyubUmC3bMG/3Td8aDyuraG3gdVGARn0QbIAdWWP1Ba36bevbXGnaAWFYA1/1A85RlS8L89e1t571UmKG6aSWQP0D0ATaQg6qHIOMeeA2otMibe9w4z54qBAp5dN3JO2G3uMlLav3S2fUW+NCJCgUBozZYdRWYzkhqQ8RNQGYFUuggeJtiFbP73hWAKxEDghZdBKX+n2G2U1EQEFjP9YeHFPsBawbLlywJPLv/7bo6Cm5SIQ4N2W2kY6j3q8tegHWOIJ56Z2MsXd9e1O2vsKexmSODT0CW/lo1pmiZxBMYJqeccTnB0UKNavbiLatnWuD7doUpHz8MvDouo0gfnEiyve2b8iWT8vQu/yUPEfn98UdBlf/244x2si/wFOlFkf8c3zR+utIN76W/Ymwec/l0/gimK/Tvi6RAau5uO6d23YyJLgJ7dkSS7aBsvxUJXSmKNW/2nYzRkHrvoxbU4O9g/6mqVKFBhIdq650/bSCZhXJ/sc9YErJ05x+n5IBORRi9HlM6oxH0tFUA8PQyc5iym7/g1YjiBFmNtGnqq20vAX4cSy5vP0tskIYQjn+mLdjK62SUngevdFs= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(40470700002)(36840700001)(46966006)(82310400004)(110136005)(47076005)(86362001)(316002)(70586007)(1076003)(336012)(8676002)(4326008)(186003)(6666004)(36756003)(426003)(40460700001)(8936002)(2906002)(2616005)(26005)(70206006)(54906003)(508600001)(356005)(5660300002)(81166007)(36860700001)(7696005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 16:19:03.1774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 055c6ac4-8d34-4cb5-b85a-08d9c49d9a9d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0060 Cc: Sunil-kumar.Dommati@amd.com, Ajit Kumar Pandey , Kai Vehmanen , open list , Basavaraj.Hiregoudar@amd.com, Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , Vijendar.Mukunda@amd.com, Alexander.Deucher@amd.com, Daniel Baluta X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" We need to support sof audio on different variants of Google boards. Add new entry in dmi table to enable SOF flag on Google chrome boards. Also add newer machines to sof_machines list with codecs and amps acpi id check to register sof sound cards on different variants. Signed-off-by: Ajit Kumar Pandey Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen --- sound/soc/amd/acp-config.c | 53 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c index 1493d52c9290..c0bbcdb1761d 100644 --- a/sound/soc/amd/acp-config.c +++ b/sound/soc/amd/acp-config.c @@ -35,6 +35,18 @@ static const struct config_entry config_table[] = { {} }, }, + { + .flags = FLAG_AMD_SOF, + .device = ACP_PCI_DEV_ID, + .dmi_table = (const struct dmi_system_id []) { + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + }, + }, + {} + }, + }, }; int snd_amd_acp_find_config(struct pci_dev *pci) @@ -43,6 +55,10 @@ int snd_amd_acp_find_config(struct pci_dev *pci) u16 device = pci->device; int i; + /* Do not enable FLAGS on older platforms with Rev id zero */ + if (!pci->revision) + return 0; + for (i = 0; i < ARRAY_SIZE(config_table); i++, table++) { if (table->device != device) continue; @@ -56,7 +72,44 @@ int snd_amd_acp_find_config(struct pci_dev *pci) } EXPORT_SYMBOL(snd_amd_acp_find_config); +static struct snd_soc_acpi_codecs amp_rt1019 = { + .num_codecs = 1, + .codecs = {"10EC1019"} +}; + +static struct snd_soc_acpi_codecs amp_max = { + .num_codecs = 1, + .codecs = {"MX98360A"} +}; + struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[] = { + { + .id = "10EC5682", + .drv_name = "rt5682-rt1019", + .pdata = (void *)&acp_quirk_data, + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_rt1019, + .fw_filename = "sof-rn.ri", + .sof_tplg_filename = "sof-acp.tplg", + }, + { + .id = "10EC5682", + .drv_name = "rt5682-max", + .pdata = (void *)&acp_quirk_data, + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_max, + .fw_filename = "sof-rn.ri", + .sof_tplg_filename = "sof-acp.tplg", + }, + { + .id = "RTL5682", + .drv_name = "rt5682s-max", + .pdata = (void *)&acp_quirk_data, + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_max, + .fw_filename = "sof-rn.ri", + .sof_tplg_filename = "sof-acp.tplg", + }, { .id = "AMDI1019", .drv_name = "renoir-dsp", From patchwork Tue Dec 21 16:18:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Kumar Pandey X-Patchwork-Id: 12690019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F092C433F5 for ; Tue, 21 Dec 2021 16:20:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4F411174E; Tue, 21 Dec 2021 17:19:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4F411174E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640103623; bh=Ks/DPFfL2CzZD3Da1XlMEUHLgU4bsnHxrqz4hYKqSVM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=P7zPP964hYIS0ZwRg6RZm/flYcPxLQ7CdesrnFaqfebrWehQVDp17BOWc9jqRwvjd HTeulYYDsLLeTSBK9Kc/LY1gWIa9dPUk6+FNxxvXWqNwn+K6g2OaysiQmjlfhYcynY 07Y72tS0quXdEp4lamxWCbjQq+8b2yhr12ptBohY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 81703F804D9; Tue, 21 Dec 2021 17:19:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7EEB4F804E4; Tue, 21 Dec 2021 17:19:15 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2074.outbound.protection.outlook.com [40.107.95.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A67B5F804D9 for ; Tue, 21 Dec 2021 17:19:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A67B5F804D9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="WSvfVy83" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=abiVcQG3goz98yaSjG5ZbzWzbbgLBCUyX8Gr02ZWDH1qLDAavx8SU/kKCKzN1+r1fUmmvpa5o4GxeOAz3FMBGHd4FBrKEX92jZVMnXmdGgkf0Ra5AfRps4w8dskJjTd2rwBV0rbFp3oHE+mC8kpv2kZIzedH0tNfZcd+Qp5vJkp++bSGXEKL11tpGMA2ucMt+yT1MdURIhDbTX+KdC1U3LfFAM0q1wZJ6+3hI2DdpeqtuOmG3UmxGpjcEZu/bzw02ITuTvXiPXZMFmuzqNyr3kJ5jkU6g/mufKeYEhaTG92tZcMWZcv7YXSW/MphCV6aT1MKz/BBi0N6B+n18BcuZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rItwZkKUxti8nGR81PnvwHALhzE3fm9ukB6UAKqP8EM=; b=TBdZQ7DAZRBiPHjQGTp+4/8V4kLrhYhX/dvX4rjhcLxFYIBk0uu5xOkFhP4qnVVgFvbm8McbBi5NrYd5rNVUFP0/Vi8EF2/ePSFf3p7r1Xaoewdq7TvaQPOXfR1NdNFEOQYrw3qfLBHSGkyjCifjSydGc2SLvf09QOIKgYVkK+Ql8A88bUh9b4tYays6oJow0dMbiIKkzTATfKPzugmdS8d+7eSU6Nh23TvlYjviBKrCz9sF60mRgsYKRWjKV+de7NFyz/O69JEmANcO7Bg5NN6Yq383YCq0dn8x1BDSic5lmK7wr5lS60AiMvQL5ImasXZZrd00qrYqjtpBP63/Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rItwZkKUxti8nGR81PnvwHALhzE3fm9ukB6UAKqP8EM=; b=WSvfVy83DkEy78C+zMTWhUtwKMVm1ECkSf0OonkdJOV1WYIwSunKmhQiT61d7lwGUvzRWFVnOsLuNWzJDNwL5kbWTaMr2MzvZCdTSWB9A/+nNHzB3YiqEyCr1MoOhVKuZJxJnOABlZ4y13scqYc7CoKXLbVVMwnApvBIR6z1ZcA= Received: from DM5PR20CA0035.namprd20.prod.outlook.com (2603:10b6:3:13d::21) by MN2PR12MB3616.namprd12.prod.outlook.com (2603:10b6:208:cc::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec 2021 16:19:03 +0000 Received: from DM6NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:3:13d:cafe::d7) by DM5PR20CA0035.outlook.office365.com (2603:10b6:3:13d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 16:19:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT005.mail.protection.outlook.com (10.13.172.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 16:19:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:56 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 21 Dec 2021 10:18:56 -0600 Received: from chrome.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 21 Dec 2021 10:18:52 -0600 From: Ajit Kumar Pandey To: , Subject: [PATCH 3/3] ASoC: amd: acp-config: Update sof_tplg_filename for SOF machines Date: Tue, 21 Dec 2021 21:48:09 +0530 Message-ID: <20211221161814.236318-3-AjitKumar.Pandey@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211221161814.236318-1-AjitKumar.Pandey@amd.com> References: <20211221161814.236318-1-AjitKumar.Pandey@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc735b1c-97fb-4a97-7d77-08d9c49d9acb X-MS-TrafficTypeDiagnostic: MN2PR12MB3616:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wxR42KjH2bFGj0es0U5H0mv5X5Ij6JmeQ1M9IM5JQ05YF3Avcyg5nile003zvLjK77cSx1zoskguKPRo1Kd9YxAbFMrqjrkleVANuKEVLVHq8loeQRRTf6/IjbiTWT70tb6CruVwgSlSOB566DWiqxni6B+3+NgHNSWokcRukAzcI27+ervfEgrv0xUXHQFUBUYhpU57WBxPZFFSvAMkvuZ70caAePRCjxNjWFVO1z8VmcovG7dsuHX3HPqFnK0yqvheEllyhElbzI/wnp+FM+TEn6fiA4vDSmDUHgIVf3xd0SSpOjCrwivwLcT0kkdBkD2xM88hrxMWSIWEp89fGkGKl+WrSsFxDvHJ2zgEljBqVvkE0Hwmxm84hqtf8H7hq66tdxU8ZA8X/4ckFHGhNbK3kDbEZ7XH2LlcmT//TPhjttPN+FiXjsDMB3ZVYpBl5bNe1foou+c3fFRR8959phjlTD9B2bzargbAWMwhpPKRhU8t7OZlg1U4UZD0Fm2XXjwv7lDxhB2ciZ4sIAN8rboP2YdoJKwwuVX0jMqpEWNmqKdK0NeGBAJ9WpJoJEjD/K53cVRCtyT/+aL4CqmDEremonqR9g+NLR0AiFTS9rpKwlHXi+BDOgRWCChhO58k9VUSaKI4X1qvFLpSKsCVpZp4kmrRw3xJc9VTSYbiXT9rBlfDJEwVO1fPd6CVk1B/iOkPf8OgQghga1PIv7ZQCRg5i6NQSwXCxi5kjUWX1ZxmL15evAZodF4WpuB/pTM3o2jHZvHeIKmbu8/G9lkB6kNahvp5r7HMSMxXkfMjX88= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700002)(6666004)(2906002)(508600001)(4326008)(15650500001)(186003)(356005)(36756003)(40460700001)(8936002)(316002)(336012)(47076005)(86362001)(2616005)(7416002)(82310400004)(5660300002)(83380400001)(36860700001)(70206006)(110136005)(70586007)(54906003)(26005)(426003)(1076003)(81166007)(8676002)(7696005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 16:19:03.4774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc735b1c-97fb-4a97-7d77-08d9c49d9acb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3616 Cc: Sunil-kumar.Dommati@amd.com, Ajit Kumar Pandey , Curtis Malainey , open list , Basavaraj.Hiregoudar@amd.com, Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , Kai Vehmanen , Vijendar.Mukunda@amd.com, Alexander.Deucher@amd.com, Daniel Baluta X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" SOF machines support different codec end points and hence required different topologies configuration. Update tplg filename in machine struct to load different topology files for SOF machines. Signed-off-by: Ajit Kumar Pandey Reviewed-by: Curtis Malainey Reviewed-by: Pierre-Louis Bossart --- sound/soc/amd/acp-config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c index c0bbcdb1761d..c9e1c08364f3 100644 --- a/sound/soc/amd/acp-config.c +++ b/sound/soc/amd/acp-config.c @@ -90,7 +90,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[] = { .machine_quirk = snd_soc_acpi_codec_list, .quirk_data = &_rt1019, .fw_filename = "sof-rn.ri", - .sof_tplg_filename = "sof-acp.tplg", + .sof_tplg_filename = "sof-rn-rt5682-rt1019.tplg", }, { .id = "10EC5682", @@ -99,7 +99,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[] = { .machine_quirk = snd_soc_acpi_codec_list, .quirk_data = &_max, .fw_filename = "sof-rn.ri", - .sof_tplg_filename = "sof-acp.tplg", + .sof_tplg_filename = "sof-rn-rt5682-max98360.tplg", }, { .id = "RTL5682", @@ -108,7 +108,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_sof_machines[] = { .machine_quirk = snd_soc_acpi_codec_list, .quirk_data = &_max, .fw_filename = "sof-rn.ri", - .sof_tplg_filename = "sof-acp.tplg", + .sof_tplg_filename = "sof-rn-rt5682-max98360.tplg", }, { .id = "AMDI1019",