From patchwork Fri Dec 3 16:35:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Niedermaier X-Patchwork-Id: 12694727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34688C433F5 for ; Fri, 3 Dec 2021 16:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NcLgouhrICXvxEfS3VcJjxu8rO0vJfrohn0Wiljy/Ow=; b=hrjNlnC4Yr7ix1 TiRiyEelvFcg3PX7UQe/tetWol3Pm3OjkQPxW7L0WzXjBUADgf6oIav9ZJe7KVCyTmwuK62xYuAmw 8J1BGxQNL7l0Q2zNCNS5tkGKMvyiGOFMFiHS0CgzYRg8FVrmSizWEDidCKf8nRu7iscFWJ1A2eFGg 49Z9MpZuMwOy729Ux/CtDOq3vRNbUUom7ZBQ0rxs1BUaC64gkJvRGUow2oG/JKdqSl63dzpM19hRt 294lNVFvbCcltttZ4ma+29cvXCBRPdmO09Ki0qaUOTp0HMCr13cax/Pg0TwTGxqnje+EeNp/bz1z9 w7t1cG5kQpO2sPl7gZ1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtBZJ-00GY70-4T; Fri, 03 Dec 2021 16:37:53 +0000 Received: from mx3.securetransport.de ([116.203.31.6]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtBZE-00GY5g-QG for linux-arm-kernel@lists.infradead.org; Fri, 03 Dec 2021 16:37:50 +0000 Received: from mail.dh-electronics.com (business-24-134-97-169.pool2.vodafone-ip.de [24.134.97.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx3.securetransport.de (Postfix) with ESMTPSA id E70125DD16; Fri, 3 Dec 2021 17:37:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1638549453; bh=EWGgfdTrxQHtOQ9XgCk8+mx7RHRdPzCWWWuYARSdwak=; h=From:To:CC:Subject:Date:From; b=F/NkNAunOITjnXwU4+kw1fWmci4k7a2LNgxv6ldsJvutLc4WUrlNFKa0FnAgGDFa6 id9mS7m4zjVzmnE2CI25Gaa18lY1xijub6R+uXC8CWpOVGosgz7wuL3SvQFYCfkwuw lnIA2TxugRdyV01HUSOosewGY8plc8p/jl/fBUY3lEiuWkn+BldgGORNSkcKwaCeMq XyfopXMcnQ9ZI8Kshnq0LfhcxefJ3sFQDrLslfVqFnKm/fpNr40cPCfkC41Zv0poXd 7NqSGNXj/FGeneKmjA3wa4lrRPtfhUnhxSH2Fza7QPyuVr4Xr7bj0Ix49thZEBK7YJ 0ZzGPHa0iRalA== Received: from DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) by DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Fri, 3 Dec 2021 17:37:26 +0100 Received: from localhost.localdomain (172.16.51.18) by DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14 via Frontend Transport; Fri, 3 Dec 2021 17:37:25 +0100 From: Christoph Niedermaier To: CC: Christoph Niedermaier , "Support Opensource" , Adam Thomson , Wim Van Sebroeck , Guenter Roeck , Andrej Picej , , Subject: [RFC PATCH] watchdog: da9062: Correct the timeout values Date: Fri, 3 Dec 2021 17:35:39 +0100 Message-ID: <20211203163539.91870-1-cniedermaier@dh-electronics.com> X-Mailer: git-send-email 2.11.0 X-klartext: yes MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_083749_089218_FCA1C538 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I measured the timeout values of my DA9061 chip. According to the information in the data sheet the formula should be: timeout = 2.048 * 2^(regval - 1) But my measured values differ from that. Accoring to my measured values the formula must be: timeout = 3.2 * 2^(regval - 1) Is there something wrong with my chip, or has anyone else noticed this as well? Signed-off-by: Christoph Niedermaier Cc: Support Opensource Cc: Adam Thomson Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: Andrej Picej Cc: linux-watchdog@vger.kernel.org Cc: linux-kernel@vger.kernel.org To: linux-arm-kernel@lists.infradead.org --- drivers/watchdog/da9062_wdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c index f02cbd530538..d2576aba9ca5 100644 --- a/drivers/watchdog/da9062_wdt.c +++ b/drivers/watchdog/da9062_wdt.c @@ -20,7 +20,8 @@ #include #include -static const unsigned int wdt_timeout[] = { 0, 2, 4, 8, 16, 32, 65, 131 }; +static const unsigned int wdt_timeout[] = { 0, 3, 6, 12, 25, 51, 102, 204 }; + #define DA9062_TWDSCALE_DISABLE 0 #define DA9062_TWDSCALE_MIN 1 #define DA9062_TWDSCALE_MAX (ARRAY_SIZE(wdt_timeout) - 1)