From patchwork Mon Dec 6 18:52:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F27C1C433F5 for ; Mon, 6 Dec 2021 18:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ml5UERw0sqZ4DJ+CMJ+Pn41CQvjV7bekOCJvHBM7Afc=; b=BR4AQ+s7bbxKgb t7hRGCsEVq3LJkQjWIsnw64zZXiQpF9T3xIWljOdAoukI6h1Df9mwSZsFPjK/lTvwMuEr3e+TlIBY FhfcdUZjAarGyYpYvJcHoPRJjeW84RP+mYIn7E4JXCfVzrhyjpA0v646OZGh5YvATUlYCoNYUyTT9 IzsOGCw6z7jLSQwDWZGPsjXR4wVELoUHD/LrIOHZiNfWYZZcoP8ROqhkFhc7Sx1xDXZI0rSU3Khnf 25XZOjfIcXeMDnegvx67sIo6H58gwrGNGV8g4GIzdnSA2yJMmqQwX0EXqvtGi5ODH0TbRr5k6OxV6 6E5w9LgErSJ6GAkkN5kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6j-005PdP-V2; Mon, 06 Dec 2021 18:53:02 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6V-005PWE-8c for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:48 +0000 Received: by mail-pg1-x532.google.com with SMTP id f125so11409892pgc.0 for ; Mon, 06 Dec 2021 10:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qfMnWEkKpTQ6QyzDA+87Y6nTeMiakHXXBU0v7/zR+po=; b=lwQlBT2XtdjkhFGq110xFLLSv3rFV4syG4DdRKsnpE5CleEIZyr3U9GsSgAHjSh3j0 XpQN9s6pDc3+vQb+RcIBRbb+I2pdQ3mSNndV+jhKYeYQS0Q7+3YKAbrBltG7wu3Inzqs RCPRPNL24nKy/lzDxp+z12Y5Ney0viFenXIr0zxXI1wcMv9l17NJ/sFXk6t20qot3kOe AQjC09i1STzrGR3Mx+FcJYyr/IUkwIlUrZjWdjfd5qHXtn04aJFjXMZ8T8WqRRvAnV0U 5WMBZv4ACAT69I9QWcq6DaRxHiDMWiWBhXxxCpaT593hlej0vAVn3heDQ5gFcb3Jij8d JaoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qfMnWEkKpTQ6QyzDA+87Y6nTeMiakHXXBU0v7/zR+po=; b=Fc8J6eaRezgKfbVm+M87+PJxz4TQaRfV/le7bUTgFYlaItJv4PwKwjtlvdOvdExznm 2wPKl6mfvMvDGCCP6Q0RnkPOKL6KVivT2opnpJpojtXRHyylzaCaj7g52MWQyqxltpTn lS2JrSxfPj2umtBsW2wnwx6qSvdVfWDjME6cV7GyCf+9ym9Q6n39knVVYv1vG2QHURn0 rKz5jZ8B9N96mju8t3BIa5h4lmwVCn/CbQqyl/vzaLfZq5GUnFB1icpy2SEwW3qgsBpr 9qagZrn7DIyRdLC64zEaME7dJPJEbZNq6jPRf8jj1D/953gtCR8FdnyltS5Fn/K0UYHE pY/w== X-Gm-Message-State: AOAM533V4JaCLCttDu35l6ix/cVybZsoRepV9tMq1YvvpV03m1moRzIf CAu9v6Ho3LAu8g3WFmGqfGk= X-Google-Smtp-Source: ABdhPJzNLAa8kejzkcnP0+SD2XTXkPG6nhL2CuDsHdSdTXYFslofUOTdXcjDxHX0SYDhDZnFBglM7w== X-Received: by 2002:a63:540c:: with SMTP id i12mr2313489pgb.244.1638816766473; Mon, 06 Dec 2021 10:52:46 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:45 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/5] ARM: dts: Cygnus: Fixed iProc PCIe controller properties Date: Mon, 6 Dec 2021 10:52:38 -0800 Message-Id: <20211206185242.2098683-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105247_325251_201734A6 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rename the msi controller unit name to 'msi' to avoid collisions with the 'msi-controller' boolean property and add the missing 'interrupt-controller' property which is necessary. We also need to re-arrange the 'ranges' property to show the two cells as being separate instead of combined since the DT checker is not able to differentiate otherwise. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-cygnus.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi index 8ecb7861ce10..ea19d1b56400 100644 --- a/arch/arm/boot/dts/bcm-cygnus.dtsi +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi @@ -263,6 +263,7 @@ pcie0: pcie@18012000 { compatible = "brcm,iproc-pcie"; reg = <0x18012000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; @@ -274,8 +275,8 @@ pcie0: pcie@18012000 { #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0 0x28000000 0 0x00010000 - 0x82000000 0 0x20000000 0x20000000 0 0x04000000>; + ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, + <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; phys = <&pcie0_phy>; phy-names = "pcie-phy"; @@ -283,7 +284,7 @@ pcie0: pcie@18012000 { status = "disabled"; msi-parent = <&msi0>; - msi0: msi-controller { + msi0: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; @@ -298,6 +299,7 @@ pcie1: pcie@18013000 { compatible = "brcm,iproc-pcie"; reg = <0x18013000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>; @@ -309,8 +311,8 @@ pcie1: pcie@18013000 { #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0 0x48000000 0 0x00010000 - 0x82000000 0 0x40000000 0x40000000 0 0x04000000>; + ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, + <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; phys = <&pcie1_phy>; phy-names = "pcie-phy"; @@ -318,7 +320,7 @@ pcie1: pcie@18013000 { status = "disabled"; msi-parent = <&msi1>; - msi1: msi-controller { + msi1: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; From patchwork Mon Dec 6 18:52:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694974 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53D58C433F5 for ; Mon, 6 Dec 2021 18:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O8luXp6kh4JfBVY9BBgK5IzQsit6F7wdJNVlRLs1H3U=; b=V29zCOVvkjU6II kBKeBRsMn96KRfsCU+ZcpUMk32ketlLGavCv25WIsNUnfVPR1ExnrOKTowsY5fTD2Hw3MPHL27o4M k33fdR3shVd4nhjbgvLAxnZePw90gwGCGpJ9YW31sWF6mH9w5Wgwon0L0NSVc0xq5UlyjgOFR/GSv aydwoIMhISXW3K18CqDMAgKXFUzcZloZrK9UKrRbcJKlX42Ynlx48UDtCvkfBRU6EtDPWeDR1kGhL dp/2ntb1qnk8fVl62qELjmi1vTC/iAlKzcz0axcIyLND1r0RqPtcbR2WaAM3XKe4Fuq7Jo0AfJAT3 bFz9h8BbdXJCdLNOSv8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6v-005PhI-CK; Mon, 06 Dec 2021 18:53:14 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6W-005PWz-5e for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:49 +0000 Received: by mail-pg1-x536.google.com with SMTP id r138so11300640pgr.13 for ; Mon, 06 Dec 2021 10:52:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LnAQBRW/XPFSuQTMYCsaVUHc/hz2Ejomkgj8kU/9KMw=; b=AUSyKNocDDhvxw3qgxImNlXZDrs/lOwsmV+mEHz57mXOUlr9iagfHE9ZtjKkGagzg1 vIJnj0lFdCGjKesfi4X9uL0/Pc/8K0DLgxb6BUBBWOOcZeTpt6oKiRVtQUdvnHlBbufZ LKLUGQQXmLwTe/x1jZ/DnUmZFLFgBgziDtJHSttKS2tC8dPrml1AjTvD4y/SUS8WwROq OWd2W7PGIr5CgUJDvk1GEqGH5NC5pyX9nf01OhfRkrpoOV6VvfGcX5AfCIyY2v3L7RDh KbNQN/+b2BMCMg5rjoBP3OHNwxrH1hO2vaOc/AVVvcF94b0Vbbgi9LdsR+NgRuo52svI HIYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LnAQBRW/XPFSuQTMYCsaVUHc/hz2Ejomkgj8kU/9KMw=; b=5ojRc/Hx+dIsA+DIKcvkfFqufKG45gYTDFOxlSojRlUZv/WCgJ9mUOL+ej5KxX6Hi1 HNpno9YeUMnjqGYa0OW66V1luUmOAMgiLw3cVcEjbFSjVNqcJWNMjt761+bXo3FZkXs4 mIVZhTiw2Y/FJXSDn4TMJWgXOlBSSfwx+dglpMdpOA7FlcLpBy/f7u4Jp7AURxxb6Yty v/WeHyORD16oBFhM6dHsF6ys1zCuUIuYk6UJ56oNScyyGantrb20R4CuURMpfkZ4kU9K Bz+NFFoLOpRfnhmsbFwzvvOlS/QkZhf4Sn9YFs52jzxwHLZ0CBiLJ6/ggMUbBOwDxP54 ISPQ== X-Gm-Message-State: AOAM532P4i5EzmgVDbm0MdDee5uQ/0w2TYPC33Ds9WAbRIB3Cgf8BEpy pQ0j98yFeBszAteTYw5zjCw= X-Google-Smtp-Source: ABdhPJxk/NqcGi9fD4ygwQLfetE3jtuNqoqktZK3a/RoKr3r0q7PNqpAwS9aFTmp9/uqPw4jBdPdzg== X-Received: by 2002:a63:f749:: with SMTP id f9mr20041831pgk.330.1638816767624; Mon, 06 Dec 2021 10:52:47 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:47 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/5] ARM: dts: HR2: Fixed iProc PCIe controller properties Date: Mon, 6 Dec 2021 10:52:39 -0800 Message-Id: <20211206185242.2098683-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105248_248899_1A44677B X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rename the msi controller unit name to 'msi' to avoid collisions with the 'msi-controller' boolean property and add the missing 'interrupt-controller' property which is necessary. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-hr2.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm-hr2.dtsi b/arch/arm/boot/dts/bcm-hr2.dtsi index 84cda16f68a2..bd2f1d04161f 100644 --- a/arch/arm/boot/dts/bcm-hr2.dtsi +++ b/arch/arm/boot/dts/bcm-hr2.dtsi @@ -298,6 +298,7 @@ pcie0: pcie@18012000 { compatible = "brcm,iproc-pcie"; reg = <0x18012000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; @@ -318,7 +319,7 @@ pcie0: pcie@18012000 { status = "disabled"; msi-parent = <&msi0>; - msi0: msi-controller { + msi0: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; @@ -334,6 +335,7 @@ pcie1: pcie@18013000 { compatible = "brcm,iproc-pcie"; reg = <0x18013000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; @@ -354,7 +356,7 @@ pcie1: pcie@18013000 { status = "disabled"; msi-parent = <&msi1>; - msi1: msi-controller { + msi1: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; From patchwork Mon Dec 6 18:52:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CA66C433F5 for ; Mon, 6 Dec 2021 18:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5T3MpKhzdEARooIOJ5nKa0W1dO07Lj7tp2sEUkqDs0Y=; b=c3EWILrBrVJQ5Z eEAZLpBwMPwI3oqu7q/dgIf7i4dfUI68B8IsJusaC5yo7hmppfc1kOISueuRAekwds38JApDU1s5L MLIiyopzHMu6T06AMaRtc9S0qLFqDP76q2TnhSdb53mMVwllFzfssdMvedSCbgxzFuCL+O2+DCigC jpUZvxvtOsBj6EDqObQSttzgv8708nRTuD5sxNdnQOJVa8OBoC4ZmwvEqBEyLuZUaSJzYGs5G5qBu nNJ9tHv5bUQJk/YA7rIV3sjPECO0ySUKguFQHKSHv3hWIyarHDHQzgjRV4DgFe1b7owd/ZHeIBiks GiyMfnvbOPYC3Z2G+zkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ7C-005Pt9-Dm; Mon, 06 Dec 2021 18:53:30 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6X-005PXh-FM for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:50 +0000 Received: by mail-pl1-x636.google.com with SMTP id p18so7654477plf.13 for ; Mon, 06 Dec 2021 10:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fh6iQu7Naqo1ecQG71P7/0hN4M900Ip7WZ2Cnzd+y5A=; b=cgwXwUhK77JLryRHawrkiy3prn6iFO2VZ8UqOyYOY9+V0uOMYxcmitBEh/4ND8qfkx ASjC7jExOprIbx4y1QYcY5IhWR8N6jOTJLno6uuGbODNa82P855i5qPpJwKLrk/PCrlO o99riJKTyUgLBEvHYpNNMdUR8XNQ905zN18mxGnFOY/wJiIRmrHh+PsXcll0I1988Wx8 bB+zUgekmJuYR6RnqQBCfm74dO0RQcwz9yuDPh7+YzcZchiZTwbma+cuyte63oV8POJJ fuI6nztF3IZ17qjxWUEsNGAmpbE60HghXAsfItF5JsuwCeU/ZjECV8bIghPxTP8Nn6bp Zh8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fh6iQu7Naqo1ecQG71P7/0hN4M900Ip7WZ2Cnzd+y5A=; b=fTrC4YpZq5NmE1rUodZVgcYmH41zYyuWQZLY7NZclbzQQ8I08XK4yJUgmKoFHDw3xp ee3lzHADRvHy37f7yucn1aMJO1FJd5lWvVc5K3g0J6HA8EJygQK2zegyAokUQ/7lh5Ij o2gH4P62vouPN/fqK4YbdbyWA8sUL2jHwFPA2PIdvl3XXHYdt2lKHgp7Rd+2AI3ZV4fX +vWt/7YyskkvCQVm3FQHald4tCQYrLgZnJtPa58ZefaF6nj8PLlOJGBG47PNSUZakcVr /bVO1ZvXAwWLnmFdkc8c1VlaP763R+k8bHzLrMzZbVtPSWsl47Gwit0k7q0OxZCvNqpq dvzw== X-Gm-Message-State: AOAM530c7DF2Gl0J/vUBEO5iip2aNNn4+SzGq+BBFJm5PB0lpgE6zMwp xVG0rDbAc2k55H4J6MFsVlM= X-Google-Smtp-Source: ABdhPJxOn7G0JZM2hSYvs6pdIl01zXc5ZHUSGi30M90nHVjLsj3ybrhFDtuz11R3mHn6LhsmybXl2A== X-Received: by 2002:a17:903:11c4:b0:143:d220:9161 with SMTP id q4-20020a17090311c400b00143d2209161mr45516422plh.2.1638816768734; Mon, 06 Dec 2021 10:52:48 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:48 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 3/5] ARM: dts: NSP: Fixed iProc PCIe controller properties Date: Mon, 6 Dec 2021 10:52:40 -0800 Message-Id: <20211206185242.2098683-4-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105249_547245_9B6B105B X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rename the msi controller unit name to 'msi' to avoid collisions with the 'msi-controller' boolean property and add the missing 'interrupt-controller' property which is necessary. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 1c08daa18858..8c57e904be7b 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -566,6 +566,7 @@ pcie0: pcie@18012000 { compatible = "brcm,iproc-pcie"; reg = <0x18012000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; @@ -587,7 +588,7 @@ pcie0: pcie@18012000 { status = "disabled"; msi-parent = <&msi0>; - msi0: msi-controller { + msi0: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; @@ -603,6 +604,7 @@ pcie1: pcie@18013000 { compatible = "brcm,iproc-pcie"; reg = <0x18013000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>; @@ -624,7 +626,7 @@ pcie1: pcie@18013000 { status = "disabled"; msi-parent = <&msi1>; - msi1: msi-controller { + msi1: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; @@ -640,6 +642,7 @@ pcie2: pcie@18014000 { compatible = "brcm,iproc-pcie"; reg = <0x18014000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; @@ -661,7 +664,7 @@ pcie2: pcie@18014000 { status = "disabled"; msi-parent = <&msi2>; - msi2: msi-controller { + msi2: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; From patchwork Mon Dec 6 18:52:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694976 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B285C433F5 for ; Mon, 6 Dec 2021 18:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LVvwnHlSz7kYd7hhfUqzJf5RJWlsjQMlFm1C3ZQLfFw=; b=ib4mVj376Vk/oy AYc6c392Hn3n0VI1g1x7n027fQB50AUnt+2HLcwfEDBBDmcMMpZ4AgDkA+Nb3lkGOz2otPL/kS8rn hl04BRNKYZS/M3K/TJuoyPwEj6d/2dWpHr3RN2YKVpjKjnWOnEv432Ze1/TbMwZwGzNB4vuNkpWf/ +e1tn2ZWAVLdvl0ljBl8cp/9AnkroLJ62gmdO6dML1xaATnWGf6zihnuxgHbLoUGfQE1959Nql6ru 9ppdSwnTVcSfbYxq/lBVvCTrWsCO/rDiCm41PypG70bcT5YAGx1t+JckvDdxRtHY9PcLp0no/ILjW EowwrE9T1oJ7FqnzmUdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ7S-005Q10-Cd; Mon, 06 Dec 2021 18:53:46 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6Y-005PYS-GX for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:51 +0000 Received: by mail-pj1-x1036.google.com with SMTP id np6-20020a17090b4c4600b001a90b011e06so605359pjb.5 for ; Mon, 06 Dec 2021 10:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1kNfzxGCClPnpkpcKrueQLAKijX+MF7pULsui0hZ2MI=; b=XdJ2/UR+oBQgVKqQmg963h0ZjX4MNojQf9yfB2C7k8gkZrc8z5gI4RFiZjbIYAYShG NaDqNaE9RHQ4VXanSs9Rv8bT1BZXgnWBUPC38V3Z1773gu2+RgGBlTmcSdHx6lshyt6L 7RVpX0i3xitRtex3wljRMr3nSxp7proU0SLtOc117ZngWeJ3sXR6BAKaUuwUFLvJX3RP ARi/uz7de9UdN7L0NnNJ0BqoJT24lDIKSjEraT0REa6OTkITniODj4m6BkJwkoM13seD fcMW/UXAlZL4Y9zNF1aP5FwJEuGM2Didk7bE8/9/Y0IkovLv0k7f00Ch9zqgDvUADFtn fnSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1kNfzxGCClPnpkpcKrueQLAKijX+MF7pULsui0hZ2MI=; b=A3GHjTQbP7CAn3HXeYptKcJuWUlVaurzaXoE1XJ6t+LwLag2TjA35R7Vgm5Dml3LRG bhm87g93GPXFWb63A0nVMizFqNvUwoPn1tuZKmSxkEPMtRZnl3LnmYZC//c7ezuwTZLr 5jMAfFW+y2xphTb4JQZh43QAuZEGwkpohTbm9RSjGWSJEasuLzS68viH2tIDjKlRgFd1 8MQz6zIwyf+YdrZSD/Q7WQuwSds41kWgr9gMurNldqTFiZ4bB8HQPlm290hVviRhoLyb hdUxW+nBiJKLbifboqUI+KF5EfiWQmPW/0tf43cGI2B+JakIfmPvHUGgHG5yGgJAPUdp MSEg== X-Gm-Message-State: AOAM532YuoqA/i8VAnOnabBHndbgPUHloljR1RgoymGsWilRGl385VoQ ZF7bwuLZR9yjWWuNhMd9Fxk= X-Google-Smtp-Source: ABdhPJx2sR7cEAKdjOKkrChXCG/nIkaHE6d2lpyNWLZJGkWcWrvdJcSXZhiLevJll2TFV24bZBtb6A== X-Received: by 2002:a17:902:c643:b0:141:cf6b:6999 with SMTP id s3-20020a170902c64300b00141cf6b6999mr45772141pls.80.1638816769867; Mon, 06 Dec 2021 10:52:49 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:49 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/5] arm64: dts: ns2: Add missing interrupt-controller property Date: Mon, 6 Dec 2021 10:52:41 -0800 Message-Id: <20211206185242.2098683-5-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105250_597526_23FA444F X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the missing interrupt-controller property to the Northstar 2 iProc PCIe controller node(s) in preparation for validating the PCIe controller DT. Signed-off-by: Florian Fainelli --- arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi index 2cfeaf3b0a87..0e10d2dd38cf 100644 --- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi +++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi @@ -116,6 +116,7 @@ pcie0: pcie@20020000 { reg = <0 0x20020000 0 0x1000>; dma-coherent; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>; @@ -147,6 +148,7 @@ pcie4: pcie@50020000 { reg = <0 0x50020000 0 0x1000>; dma-coherent; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>; From patchwork Mon Dec 6 18:52:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD300C433EF for ; Mon, 6 Dec 2021 18:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P+4Ecs4eqmut+2FtmTQ8LOxZ0nDX8h8pxf2Fvv7Rn2Q=; b=MLp5ux1EFfsye+ wZMRRzEHThXthIpS7TthIjTr0rCQLEyq8mWGFWJI2CihyhECig7eJ3oROnXJFFw5KzlMAVY0lPrjY FGTA60UqzvckuUZgZ/JM92U6NPxuhSXF6nxb/lhi0QZ1gdwC0u2kQeX7FeLjKFr2RjiCBvzi2l5es sjitqUB4v84+vIKeLsoUxqpxWXZ0vAsVbMlsh4SHWXR4jqm8MZSgsLvGhENAuqcGKQfjY9IAuDBdT TQYSFVUg5ESkd/VhfhdEix+FfwtMO1V62pO77huelGcKpvIbltbvNVDgsLjhwEU57Y0uTsl1b4AEo TXbPMc+0iq0m5BF+C+eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ7p-005QBC-Am; Mon, 06 Dec 2021 18:54:09 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6Z-005PZF-Ow for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:53 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 8so11021200pfo.4 for ; Mon, 06 Dec 2021 10:52:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NUicZRNDgaoE71vCMOVgNc8juaJ8dU1evleMJPD6dKU=; b=FOtkIdQ5Th24VYtF6XtomX10wfRq6KSpOHFe4vlKd61+60s9hQrIVjqbUuLAuR6hef DqfDaCuBejTsliEPl7aN9klA4DKZNQ8h5hPQVqeXpoiKDvKuzauKkTr2NdoqX3klbBf7 jszlf/ZMDHCRpjMdSsAuLke1ObLT97VD5XkaoT0/inDCcYSPeFQwsZQPkug4qZ+NmDcD ySXJw6dVt52avrD83LGwdTRgHsCCw/wOSV4GyT/7jB2aAFBEHIZ2jhx4dJOq/K21KWmQ FCNtajrxnyyeBd5XAZ9kYrdS7d2Rs0T+I6HqR4XSKwe14WJMLc2DdrYoCmwKQXFHgJd5 5f+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NUicZRNDgaoE71vCMOVgNc8juaJ8dU1evleMJPD6dKU=; b=N3IFJXf77GAX8n5iat4POiXcermFQjNwiHGEkJV49Ymh4Nb5MV999GEY8MiBgs1Wio ygwDn10GoK/9z/c5dpisXpyzyw4KbDlLyB1bV/AHxawYo1O7TQvMOm4npVcafvOG08qw nIe2HMv1AkpbxOBHrMp3Yyi6Zc1KrbWmyAxnABqySsf9jHagCrjomYlVJis5GUHWymYK l2hIuoR23HkdLyaVHzG855/XQLmHqcZkW4KaYxtqJRZZ/WAM8BYaeZJBgS4v0An/bykH tRawzanmyKPXge0jk+awQXQG3xEDKoM04N0OaUEN/exXEuOJpQoKgxGFSlpSUPZpVAfG jivA== X-Gm-Message-State: AOAM530Shg0EDH9NQ8/wqe4DIAgXjnydXnQ+r0kKWgc+GK8Dw7gEetk6 YVBiHk4Xvlj26rDAUHxuHxU6t+4EYvg= X-Google-Smtp-Source: ABdhPJxbnbWrIn4kczcFNeJ79T5IugndGiJgXKRpoVp0v9IiKQypxv+bJYO2IQgeKZ4UA5TPwhAB2A== X-Received: by 2002:a65:5b85:: with SMTP id i5mr6865669pgr.155.1638816771094; Mon, 06 Dec 2021 10:52:51 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:50 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 5/5] dt-bindings: pci: Convert iProc PCIe to YAML Date: Mon, 6 Dec 2021 10:52:42 -0800 Message-Id: <20211206185242.2098683-6-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105251_846122_0CED05EE X-CRM114-Status: GOOD ( 26.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Conver the iProc PCIe controller Device Tree binding to YAML now that all DTS in arch/arm and arch/arm64 have been fixed to be compliant. Signed-off-by: Florian Fainelli --- .../bindings/pci/brcm,iproc-pcie.txt | 133 ------------- .../bindings/pci/brcm,iproc-pcie.yaml | 179 ++++++++++++++++++ 2 files changed, 179 insertions(+), 133 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt create mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt deleted file mode 100644 index df065aa53a83..000000000000 --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt +++ /dev/null @@ -1,133 +0,0 @@ -* Broadcom iProc PCIe controller with the platform bus interface - -Required properties: -- compatible: - "brcm,iproc-pcie" for the first generation of PAXB based controller, -used in SoCs including NSP, Cygnus, NS2, and Pegasus - "brcm,iproc-pcie-paxb-v2" for the second generation of PAXB-based -controllers, used in Stingray - "brcm,iproc-pcie-paxc" for the first generation of PAXC based -controller, used in NS2 - "brcm,iproc-pcie-paxc-v2" for the second generation of PAXC based -controller, used in Stingray - PAXB-based root complex is used for external endpoint devices. PAXC-based -root complex is connected to emulated endpoint devices internal to the ASIC -- reg: base address and length of the PCIe controller I/O register space -- #interrupt-cells: set to <1> -- interrupt-map-mask and interrupt-map, standard PCI properties to define the - mapping of the PCIe interface to interrupt numbers -- linux,pci-domain: PCI domain ID. Should be unique for each host controller -- bus-range: PCI bus numbers covered -- #address-cells: set to <3> -- #size-cells: set to <2> -- device_type: set to "pci" -- ranges: ranges for the PCI memory and I/O regions - -Optional properties: -- phys: phandle of the PCIe PHY device -- phy-names: must be "pcie-phy" -- dma-coherent: present if DMA operations are coherent -- dma-ranges: Some PAXB-based root complexes do not have inbound mapping done - by the ASIC after power on reset. In this case, SW is required to configure -the mapping, based on inbound memory regions specified by this property. - -- brcm,pcie-ob: Some iProc SoCs do not have the outbound address mapping done -by the ASIC after power on reset. In this case, SW needs to configure it - -If the brcm,pcie-ob property is present, the following properties become -effective: - -Required: -- brcm,pcie-ob-axi-offset: The offset from the AXI address to the internal -address used by the iProc PCIe core (not the PCIe address) - -MSI support (optional): - -For older platforms without MSI integrated in the GIC, iProc PCIe core provides -an event queue based MSI support. The iProc MSI uses host memories to store -MSI posted writes in the event queues - -On newer iProc platforms, gicv2m or gicv3-its based MSI support should be used - -- msi-map: Maps a Requester ID to an MSI controller and associated MSI -sideband data - -- msi-parent: Link to the device node of the MSI controller, used when no MSI -sideband data is passed between the iProc PCIe controller and the MSI -controller - -Refer to the following binding documents for more detailed description on -the use of 'msi-map' and 'msi-parent': - Documentation/devicetree/bindings/pci/pci-msi.txt - Documentation/devicetree/bindings/interrupt-controller/msi.txt - -When the iProc event queue based MSI is used, one needs to define the -following properties in the MSI device node: -- compatible: Must be "brcm,iproc-msi" -- msi-controller: claims itself as an MSI controller -- interrupts: List of interrupt IDs from its parent interrupt device - -Optional properties: -- brcm,pcie-msi-inten: Needs to be present for some older iProc platforms that -require the interrupt enable registers to be set explicitly to enable MSI - -Example: - pcie0: pcie@18012000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18012000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; - - linux,pci-domain = <0>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x28000000 0 0x00010000 - 0x82000000 0 0x20000000 0x20000000 0 0x04000000>; - - phys = <&phy 0 5>; - phy-names = "pcie-phy"; - - brcm,pcie-ob; - brcm,pcie-ob-axi-offset = <0x00000000>; - - msi-parent = <&msi0>; - - /* iProc event queue based MSI */ - msi0: msi@18012000 { - compatible = "brcm,iproc-msi"; - msi-controller; - interrupt-parent = <&gic>; - interrupts = , - , - , - , - }; - }; - - pcie1: pcie@18013000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18013000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; - - linux,pci-domain = <1>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x48000000 0 0x00010000 - 0x82000000 0 0x40000000 0x40000000 0 0x04000000>; - - phys = <&phy 1 6>; - phy-names = "pcie-phy"; - }; diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml new file mode 100644 index 000000000000..6d7853f572dd --- /dev/null +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml @@ -0,0 +1,179 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/brcm,iproc-pcie.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom iProc PCIe controller with the platform bus interface + +maintainers: + - Ray Jui + - Scott Branden + +allOf: + - $ref: /schemas/pci/pci-bus.yaml# + - $ref: /schemas/interrupt-controller/msi-controller.yaml# + +properties: + compatible: + items: + - enum: + # for the first generation of PAXB based controller, used in SoCs + # including NSP, Cygnus, NS2, and Pegasus + - brcm,iproc-pcie + # for the second generation of PAXB-based controllers, used in + # Stingray + - brcm,iproc-pcie-paxb-v2 + # For the first generation of PAXC based controller, used in NS2 + - brcm,iproc-pcie-paxc + # For the second generation of PAXC based controller, used in Stingray + - brcm,iproc-pcie-paxc-v2 + + reg: + maxItems: 1 + description: > + Base address and length of the PCIe controller I/O register space + + interrupt-map: true + + interrupt-map-mask: true + + "#interrupt-cells": + const: 1 + + ranges: + minItems: 1 + maxItems: 2 + description: > + Ranges for the PCI memory and I/O regions + + phys: + maxItems: 1 + + phy-names: + items: + - const: pcie-phy + + dma-coherent: true + + "brcm,pcie-ob": + type: boolean + description: > + Some iProc SoCs do not have the outbound address mapping done by the + ASIC after power on reset. In this case, SW needs to configure it + + "brcm,pcie-ob-axi-offset": + $ref: /schemas/types.yaml#/definitions/uint32 + description: > + The offset from the AXI address to the internal address used by the + iProc PCIe core (not the PCIe address) + + msi: + type: object + properties: + compatible: + items: + - const: brcm,iproc-msi + + msi-parent: true + + msi-controller: true + + "brcm,pcie-msi-inten": + type: boolean + description: > + Needs to be present for some older iProc platforms that require the + interrupt enable registers to be set explicitly to enable MSI + +dependencies: + "brcm,pcie-ob-axi-offset": ["brcm,pcie-ob"] + "brcm,pcie-msi-inten": [msi-controller] + +required: + - compatible + - reg + - ranges + +if: + properties: + compatible: + contains: + enum: + - brcm,iproc-pcie +then: + required: + - interrupt-controller + - interrupt-map + - interrupt-map-mask + +unevaluatedProperties: false + +examples: + - | + #include + + bus { + #address-cells = <1>; + #size-cells = <1>; + pcie0: pcie@18012000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18012000 0x1000>; + + interrupt-controller; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; + + linux,pci-domain = <0>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, + <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; + + phys = <&phy 0 5>; + phy-names = "pcie-phy"; + + brcm,pcie-ob; + brcm,pcie-ob-axi-offset = <0x00000000>; + + msi-parent = <&msi0>; + + /* iProc event queue based MSI */ + msi0: msi { + compatible = "brcm,iproc-msi"; + msi-controller; + interrupt-parent = <&gic>; + interrupts = , + , + , + ; + }; + }; + + pcie1: pcie@18013000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18013000 0x1000>; + + interrupt-controller; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; + + linux,pci-domain = <1>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, + <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; + + phys = <&phy 1 6>; + phy-names = "pcie-phy"; + }; + };