From patchwork Sun Dec 23 20:59:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 10741807 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1D656C2 for ; Sun, 23 Dec 2018 21:00:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82FAA28783 for ; Sun, 23 Dec 2018 21:00:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7661528790; Sun, 23 Dec 2018 21:00:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E24A428783 for ; Sun, 23 Dec 2018 21:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725851AbeLWVA1 (ORCPT ); Sun, 23 Dec 2018 16:00:27 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:34583 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbeLWVA1 (ORCPT ); Sun, 23 Dec 2018 16:00:27 -0500 Received: from localhost.localdomain ([37.4.249.153]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MW9zm-1guJD21QGw-00XZA3; Sun, 23 Dec 2018 21:59:58 +0100 From: Stefan Wahren To: Al Cooper , Adrian Hunter , Ulf Hansson Cc: Brian Norris , Gregory Fong , Florian Fainelli , Ray Jui , Scott Branden , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 2/2] mmc: sdhci-brcmstb: handle mmc_of_parse() errors during probe Date: Sun, 23 Dec 2018 21:59:18 +0100 Message-Id: <1545598758-4502-2-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> References: <1545598758-4502-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:8cal1Kc/nTZq3OJsN1s5PdEToRpB1EOEO5pTJg9AixhZByGmQEB hunFfgOWblA8zSFS1Jt5pnCnVnuGALKCrGncgBBQN1S9hLIGY6TPfI1wY4pOBagn3XgSFIb bVZ/oij85rCH5RlrNbX+Mr7i4p5rGHPDfaliJs0frw83q1KJT7dHH8NQo7ymipk8nthymme S1Loub+9o0xy9kFuFlnZg== X-UI-Out-Filterresults: notjunk:1;V03:K0:y/Cv1Tpp9og=:4ZIrDc4QvMd0Ux2f18Y1u8 rs+WcoiZZYc0UV9yrXjdKgkx8WJImfKy7OH8d2P9AxoUMBwR3SyH15NjFVNhln84V3r16FXG0 SJUe+tBXv2FAC5Cdj/UsUG7FVnfb8/O2H9rNuTgx0BHgt7lRsGY8XXYLdaZEZeuQUp8Qzb4a6 1OTJhX5HQMEA9OFRsEKq4YuWiVCt3Ne1dPdiBbvOtDNzl0Cd7o0qJno65lLxIPtX6Es8LHhDT MGLY6Krm8XGKWTRmZ3wRASN6kd1k0FpEb929XEqbT8smbFCyW1x8yohXYRBm/EIpctc/La7p8 TM/WF8VfuKtEY7A558NnWY2L3gTnbXgOCVF+lh18YvLWMZSLsWbfBZt9rKbgd+VdQEvBZNIEG zAtSPeS05lIgkEm5xb5uQm32yrMqQLKzaDrLcMZ/wl27ggJtm//wtwDsjoKeHxZbXoCoiNNkV CHSbqpXBbg/JI+tP36GMrgnjbfwRBP6nTwsUvCGQHnoKr38OjCbB4AHqghofnF+p1i0LA70GW tdEXUI6AkYHFUT5PDf8Zwrsib0Z495oVq5/g4Cogqy5pnxFtt64AsU/Z3K+6V7jzEBMrrrHJo p2SJCJtd7BD8gDOG3DNvSCXKS0LCoCqLTwVGoTwWKBp49BybC84CSUzQxy5Ufk2ZMaT5BBz25 /fPv3CGw36nDswU14qHqW8voPTyddPRr9GMbV5TeNS/fpV1tw2/cA00OYNpL89JRNazlsvLDk Ia5DluwPA5VuW7HhCENv4Udnt9sOIsxwRu3B1R7cLShDpmVjtRiyqnFNTx8= Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We need to handle mmc_of_parse() errors during probe otherwise the MMC driver could start without proper initialization (e.g. power sequence). Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs") Signed-off-by: Stefan Wahren --- Hi, since i don't have this hardware, so it is only compile tested. Would be nice to get a Tested-by. Regards Stefan drivers/mmc/host/sdhci-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c index 552bddc..1cd1035 100644 --- a/drivers/mmc/host/sdhci-brcmstb.c +++ b/drivers/mmc/host/sdhci-brcmstb.c @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev) } sdhci_get_of_property(pdev); - mmc_of_parse(host->mmc); + res = mmc_of_parse(host->mmc); + if (res) + goto err; /* * Supply the existing CAPS, but clear the UHS modes. This