From patchwork Thu Dec 30 19:53:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12701701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AB06C433FE for ; Thu, 30 Dec 2021 19:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=y/4OvmaT9Q1SwMq4A90QeEzf9b5Xa7R5v8+ZleCNB40=; b=KeVyn8vhubolJy KqGPdrawnizfrvvOrR4chou+mSb8XkuyRMmP5tVEWSDDQ2HkL1IDEsLymZg6OGCkl7z9pN6YMlA0O jDR/zkgX5QM91Cdb+Nr4hdXv+i7S0yj0rAGhJ79ikQHuXYMyAH4F073hyo4cNbL74FoR7oBgqSFaa Utk8Uu/aSi0acvZ39U0rQ+Ga4Bu4hdWI5W1at6r1NZlpkfebAbVT3x0mLhl0v9GokeszjJZmaNWkm uuIomnOVyDgjxps4LaQPODfzNFVSY1y7dNOj3PlDtic3V4+WgTbpUzgSEwh+Q1GzyAOnf35OH50jL 7LU6hwEHY/oOUBOfO2ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31Uj-005BOA-LS; Thu, 30 Dec 2021 19:53:49 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31Ug-005BLn-CR for linux-arm-kernel@lists.infradead.org; Thu, 30 Dec 2021 19:53:47 +0000 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id ED0423F17B for ; Thu, 30 Dec 2021 19:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894015; bh=IkNBdPvO0WBW1RMTehOrcXz9DKxSm9w/tT6yjAM5hts=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qb8e71SBcKeZl93uper2QUNJThRhb5KKYK0TVTY1ZcQOLJB7iONzoi26ehctJU8o/ KT2WlhPPpSs0odvGDf+ld1C1pTqqbanGVr/zAQKNfJbd/0CtTF8aY8ybtYRWIYGFDT oXGIo4KEmLgmFRuXU3AxMNU5DBCclpYMlMnvXzXiA3abxVBFM8Ho7c1hT1WwYNQag7 P+lSgq4cD6w8RHdeNRK+oE5XAiU8SP8LsoKLWEExqULigAgz++jbeToObrB1SsLZVW gQ+4SeCAXOZQ/NAeXJcC7tL/YbXKdqVa5KZzM+4gnXtE0PgCjVdUOtw6W4fcZ8KZG3 tvK02tCRNmk8g== Received: by mail-lj1-f197.google.com with SMTP id l6-20020a2e8686000000b0022d9a4d18d5so7497295lji.19 for ; Thu, 30 Dec 2021 11:53:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IkNBdPvO0WBW1RMTehOrcXz9DKxSm9w/tT6yjAM5hts=; b=FY+fsD95s8DA6m7WeK5RSSDoH9QFeEyAzB6IiwmfI75YKAi3At00ebgp+fs2WIUlDF v6mrFcKr6m3RLduqZtm7q39LyR/eMHpdn7dKJrxSIT+6JhQdys7HW98W2wyDlW748KvM +y7PmrhYpcnEeE3x066MFTJ9v6YL5pYUxI8lNf2oqkW4FAui4zJG6hcwKsf9KQmcVA/p 6ovYRsxIkExWvdajschWyTSIC0FH1qWVIpPTrm4jAjoacEM4HWC3wIkgyeL4u4JtH4Nn rW53JpnEBj0weR0KUYDZkp47chKAq2BM805qyTzPZaKxZLuXvjXOMK9XqWM1FWgjxc/C /gVA== X-Gm-Message-State: AOAM530YlBxfXNKoZiq5iMG3WLgzcR6CN/uWROeEZSBOg5A1C5VxYSPk nUd4ul39n3D6vAKOCiIIvmNxvTO0HTWCmRhGI2Io6mRH5blfuJYyYvRMcp18214pbdLCRm8YSli WSikuG0jjZD8dVK2q7rn8L3uFGJbYRNkDuQwl1vm5ZDaKZG664Ho0 X-Received: by 2002:a2e:b818:: with SMTP id u24mr20156775ljo.426.1640894015356; Thu, 30 Dec 2021 11:53:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCxn9v+74EYdO2VRQPTiHMdXaG/xqPgeB6RVZO0ch93m20tllLyIOYqIKVcNZ6kp/IBgkQ1w== X-Received: by 2002:a2e:b818:: with SMTP id u24mr20156769ljo.426.1640894015212; Thu, 30 Dec 2021 11:53:35 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:34 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki , stable@vger.kernel.org Subject: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Date: Thu, 30 Dec 2021 20:53:23 +0100 Message-Id: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_115346_585312_F9D1D5B2 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250, instead of proper pin gpa1-5. Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Marek Szyprowski --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index d31a68672bfa..d7d756614edd 100644 --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus { }; uart3_data: uart3-data { - samsung,pins = "gpa1-4", "gpa1-4"; + samsung,pins = "gpa1-4", "gpa1-5"; samsung,pin-function = ; samsung,pin-pud = ; samsung,pin-drv = ; From patchwork Thu Dec 30 19:53:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12701700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23437C433F5 for ; Thu, 30 Dec 2021 19:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oeTBf/z4mO54eumof/EskxWEqItHMmSiUUhxJUfCnn4=; b=FjyfBKXiIq0O65 F8Lm4lONnz1/05HewVQrAOAen8mz0G6wxjZSRQW60+do+vWb0szSttY2ax4MQb8zJqpAXL5KfK8jx vRqQFQilFF0zbKdeMRX21PDzNcOciasMdLIS7TbqS5lJsvB0OoG1hGWue1w0cdmfe9naYZspNtU0b cwnneO9FIGtRtuJIaagWGwCvh3w5d4ybttEajdpyMDCbW++P0BFgLGhGOMH8umJGEtgbykuh0S/xH 3CkdpXbSIdgmDNmSjxvgnNy1tT6plkJAmlyhxP+Kt4SS3whuplk2wjznbBQEMpSMfw5AxAfLiPJju J9Xh1OhoydwKI9ViMNtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31Ut-005BQ0-Jf; Thu, 30 Dec 2021 19:53:59 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31Ug-005BLm-Be for linux-arm-kernel@lists.infradead.org; Thu, 30 Dec 2021 19:53:47 +0000 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5453F3F1A2 for ; Thu, 30 Dec 2021 19:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894017; bh=QNADCpp7Mlh0tiTM/IZxnSD9jEJmVsO7Ez+VZPkoolk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FZLpCDxlQfhIZFka20t/7kQ05zL58oiE1XaQ5937izdJuHuNYZuNpECW51K5MwYIG j8oowMzlW2h6U0JuLxA0SeIkxq5XRylH2u/rUCFYQzkjaOvh72yE4IIG7BVSA8agF/ upIVb+ADPdFhY2HngydEb3B9s0yiAjK81W6h0lfZB/ZjNyGwDSIP0ziD4erP8yS5GU LxyLCmVHvjRmUo6RpbOgQ7zpMypVKCdHwFN+2ZIRMhOFn4wDai2uqaNqlN/+cqT4wm DPD6vyDdnLSweKH0/d3ul8rOwtXLxjHodAYb0fmmUabEl7ZZLAUyKEBxz6BIzyb6k+ miuCPeeaTd5eA== Received: by mail-lf1-f70.google.com with SMTP id n7-20020a056512388700b0042a063bb38cso1342746lft.14 for ; Thu, 30 Dec 2021 11:53:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QNADCpp7Mlh0tiTM/IZxnSD9jEJmVsO7Ez+VZPkoolk=; b=yPoEuFsNajh1HTdubPqxguw6pCvoK/dLkp4nbC9xSs4P02Du/hCIuk1AtAnRjJspJT wU0HVWCAu0gGuCyxUVfrpZgDk56ygvBJYVPUOewvBZt5eu6eTLUnmCLsGoQ/gtxJmfzs Pe5OuHoWPvXHRzzWWJB9+LQjhYwf/mwukDxMmsK8/eExIzz5vBU6/sHOD22sRilq4auP OPBeNKO7KyZi/GSOVseUR3sy1zuX0MM0jyRBhlhb/mr64G90kNhjkMvR1CoSwQAEqGaK QOLdI1CLfTfmRhUG1okeUc01K+r8Y8ZPGsKl00bJfeiVszrinuY13nF3hmLaqdhiijey EFqw== X-Gm-Message-State: AOAM533xWLQYfEDfMoLMh+bwfQjBdhgM/AB6RoVuprwFYCNSVQWHlWIm toMpBOsFDtLPb45+SuGKoDRog/XKmwaMnYSUs3n2zIfxI+z+3l0BPRE5y4rs+yoWA89xwmDWlmO 5dkUUDgV55PaJLc3OojiH/Rk3AivQ/JgpLrHAcUpfeskQ3qBkmCPc X-Received: by 2002:ac2:4e0f:: with SMTP id e15mr28637087lfr.352.1640894016663; Thu, 30 Dec 2021 11:53:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7O09tl2Ts7mTIWiy2LfEGqGyrflqLZ61fdbAegNO9XsZTDpgxdoRm8WI5V2+TWOtiW3DmOw== X-Received: by 2002:ac2:4e0f:: with SMTP id e15mr28637080lfr.352.1640894016500; Thu, 30 Dec 2021 11:53:36 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:36 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki , stable@vger.kernel.org Subject: [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Date: Thu, 30 Dec 2021 20:53:24 +0100 Message-Id: <20211230195325.328220-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> References: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_115346_566474_DF16853C X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Each pin configuration in pin controller should be a node with "samsung,pins" and other similar properties. However the macro PIN() (used for initial/sleep states) defines entire node, so PCIe WLAN pin configuration node was ignored. Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards") Cc: Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index cbcc01a66aab..c5054c7a9c03 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -1104,8 +1104,11 @@ &pinctrl_ese { pinctrl-names = "default"; pinctrl-0 = <&initial_ese>; - pcie_wlanen: pcie-wlanen { - PIN(INPUT, gpj2-0, UP, FAST_SR4); + pcie_wlanen: pcie-wlanen-pins { + samsung,pins = "gpj2-0"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; }; initial_ese: initial-state { From patchwork Thu Dec 30 19:53:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12701702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBCD1C433F5 for ; Thu, 30 Dec 2021 19:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U/zrJhjhyJ+IYmDdf4pdoa6bsYz5RmBoxd/fButbuIM=; b=ywUpP3JvoSdcUO jYK72ffbZoNl1F/qpubyFnkUMQ6vUqL4BBvasH2F7p4OlV8jBTwcv9Pa/QKwwYFcL4cKViJGLRxHF fQnsMOoPSijmSo9Njx4M9dQJG7gNzDFVnineFD3xBgtX316aPSmJ3+7uF7r2xAxDc65bdnCKUFwpp +IRqLheCXwOCQWGcxnrQSy6JF4/m+etNYmPgP6SQSagB7ev5IzyK1Gf8KzqTRj5tyInxcF4CnKV0R i+9lvc59zc1/id/oTJUAzW4SRrOpQR2AUCgZkAsVaYsurqLBC1QXrPGFR/S2/cVS2iPX38r98UeuF +n4b0ZPCNp95eKcWk46Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31V3-005BRq-MA; Thu, 30 Dec 2021 19:54:09 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n31Ug-005BLo-CP for linux-arm-kernel@lists.infradead.org; Thu, 30 Dec 2021 19:53:49 +0000 Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 77C194074F for ; Thu, 30 Dec 2021 19:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894018; bh=8uEPws7WapP8rUIPMK6UFetuvdb1C3w9FuCMI36coi0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MmvXfGOxbyaGvtXJH+Sm/7l6oHMOp9Nm421qB0UqutaS4GlO7Ci3kqa/NGfzEJMom tmsjDD/WeN2wdMmcs7jXeBUsay14cA9Ce7QyGoEH1RHMGxKW1gbtcnXUdHZreZ2iZn AdloX+fMtQqTDVW6lIqQACRSHun8Sxb490csBkNUBbbIdJ3a3pvJoJYww3AccrLBka UCemlxD675XkbQ1U7O9fklIA+cxWRO8y51KrbOJdB1cgLCjgVGHHUb7v0dl5DdkRvG zw5x3mhdAE9avfITYKjrS8kjtnhJKEM44r0As1YeCsHyvD6sfa3NFIRUUEhh0V29Sd 7tihllKzX1OvQ== Received: by mail-lj1-f199.google.com with SMTP id 83-20020a2e0956000000b0022d68f4a68aso8517637ljj.12 for ; Thu, 30 Dec 2021 11:53:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8uEPws7WapP8rUIPMK6UFetuvdb1C3w9FuCMI36coi0=; b=RAZMxTZ+LlidN2q2IIr+Ez8vh9/HhKJROS7KeDbCTGj6BdhHItVwPxRGIdahDZQn9F AQL9IiP3Fv3JkdSCauBLnEMsPxx0a2zpIlR1tQpy9euXdtAtjOROKUwRV3+k2/QCGKUF 9CBKXhVN1pzw+TcMrDi66fGp3lZT4/PwKTkMjrMIgEDT+ezgHwLuF5akQanEZcpL9R10 pXJ9fUwoGTY37B2orRYNlQdbKUdDnlLB/+lupo2ESq8NIrRNMgRPTjSNvFYmA17XvzfF 3XymoYuL04Js6TwPmB+AA8pIUmrWgSB7RGJQtwseWmC8D8nsv4JpBavOsTUWJk6VPm1P a0bQ== X-Gm-Message-State: AOAM5309a0gKF46vXh5lw6t5VF4fNnjobszMT+LB73Qcac8sgyJkLPhb dnL+CSBi9rACxTpZH4izRXbayawCtRx6ns6H1x7ZK+tZXfTbUugN2zm5CiRQplxEy5CAvyW4u/b TGfwrqPS8EUQHCkDxtai81jsdbEUBRMrSQQap4zOHW9PEGVuJfnIf X-Received: by 2002:a2e:a288:: with SMTP id k8mr14085914lja.204.1640894017918; Thu, 30 Dec 2021 11:53:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNHCKwtJ5UoHGrJtzXyOc5ie5RkA53X5zCoUxVYllNPxSfugxzeS6pBP++ALCmFSmUMlifTA== X-Received: by 2002:a2e:a288:: with SMTP id k8mr14085902lja.204.1640894017764; Thu, 30 Dec 2021 11:53:37 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:37 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki Subject: [RFT][PATCH 3/3] arm64: dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850 Date: Thu, 30 Dec 2021 20:53:25 +0100 Message-Id: <20211230195325.328220-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> References: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_115346_599793_E1F7A036 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The pin controller device node is expected to have one (optional) interrupt. Its pin banks capable of external interrupts, should define interrupts for each pin, unless a muxed interrupt is used. Exynos850 defined the second part - interrupt for each pin in wake-up pin controller - but also added these interrupts in main device node, which is not correct. Fixes: e3493220fd3e ("arm64: dts: exynos: Add initial Exynos850 SoC support") Signed-off-by: Krzysztof Kozlowski Tested-by: Sam Protsenko Reviewed-by: Sam Protsenko --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 40 ----------------------- 1 file changed, 40 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index 2abbb972b610..4f0a40de5e67 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -344,38 +344,6 @@ cmu_hsi: clock-controller@13400000 { pinctrl_alive: pinctrl@11850000 { compatible = "samsung,exynos850-pinctrl"; reg = <0x11850000 0x1000>; - interrupts = , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - ; wakeup-interrupt-controller { compatible = "samsung,exynos7-wakeup-eint"; @@ -385,14 +353,6 @@ wakeup-interrupt-controller { pinctrl_cmgp: pinctrl@11c30000 { compatible = "samsung,exynos850-pinctrl"; reg = <0x11c30000 0x1000>; - interrupts = , - , - , - , - , - , - , - ; wakeup-interrupt-controller { compatible = "samsung,exynos7-wakeup-eint";