From patchwork Mon Dec 24 22:07:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10742475 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E56E491E for ; Mon, 24 Dec 2018 22:13:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAC00289B8 for ; Mon, 24 Dec 2018 22:13:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B936D289C0; Mon, 24 Dec 2018 22:13:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47D47289B8 for ; Mon, 24 Dec 2018 22:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725806AbeLXWNw (ORCPT ); Mon, 24 Dec 2018 17:13:52 -0500 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:40138 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbeLXWNw (ORCPT ); Mon, 24 Dec 2018 17:13:52 -0500 X-Greylist: delayed 362 seconds by postgrey-1.27 at vger.kernel.org; Mon, 24 Dec 2018 17:13:51 EST Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id EA252C37 for ; Mon, 24 Dec 2018 22:07:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TI31gpa_T4Jy for ; Mon, 24 Dec 2018 16:07:48 -0600 (CST) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id AC260A16 for ; Mon, 24 Dec 2018 16:07:48 -0600 (CST) Received: by mail-io1-f72.google.com with SMTP id o22so14789454iob.13 for ; Mon, 24 Dec 2018 14:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=gKULAveRt1kNzkpVKLc/UkXJYbZ4gjKklLtzJ1WIMRo=; b=ORB8mYV3M1O3TPycZHMUe51VTXL+uF40KDc8OGuba7Wu8ADPowSCoWSPkjc0k4ck+F BSV7JcHPvtULQPvrRkZN8SWXD1B8OrwU4e0nICyCPkcCvKnV4u8YZLq/x2ysc3rCsWLg tV5ndElro+cXiPWePagBlfZ1H8WypBUISX5+qChz/JiGVIdV5sAcqcGHskQh2IlqH8my enj1HjOHoz/lnWNlCobAZbAoCCZJbGV/78eJnwqzpMHPhSytE/LrSDWX/X4h3HnqQtEk Up0w+Xdx65nfoamTCE6y75ATE5gCClTsqZN8w1Fnmhs98PcsXnmFvsJdkv1MLWWXFIPA MvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gKULAveRt1kNzkpVKLc/UkXJYbZ4gjKklLtzJ1WIMRo=; b=leHExuiOEkNQ5jS8NcbtsePZzdcgYcU/dM6LexHlVrWdVhJ5FCaCC9JyuWXNAbdVYC amWdW/ji3hE7XVzmJZMCGxI8YuGrPuC+lmTP3/egYhfgzoiwTTgBbCYYHhWcX2Zf2UHp 3DUut4Gz2ZFvrg6drRiWpnlCnawnc93VxLrlr/uYGtFpcksDgimN28bWcCofJiQyNyY9 TRMfg0WV3pCjhtkFNtValSkthOMVI8Ce5F3zoGIwmQ4SfODx5qbpvPt36IWmv8ZO0E56 Lm3mzOupEUR10yfsjcN0PuEbwweNQel6jLJeQ6ei7/o6kFhc3jq1fHqWMKWTBpLrq+r3 i87g== X-Gm-Message-State: AJcUukczDgjLsAkmVpjc2HDGHJi8CRHCKqOr7X/kS9RjC9MzI9zcqDow PNB9Nksnjwqt40SdV73pb/NWCVwO3rqBAEAWK67SwWRR/ZUeIWirpifLNTFWS/Sg/nPgYktnkXF SOZH0QtqqcyqgZs+5WKwxl+n3mTYq8lVKvbTPoA== X-Received: by 2002:a5d:8049:: with SMTP id b9mr10283733ior.108.1545689268318; Mon, 24 Dec 2018 14:07:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN44sgMAZcMb11JUAmPEbfVqfi28kZEPoYmRqxa0Vg6NVPyCr6XucIZiXdmKQunFXNeVuSnfYg== X-Received: by 2002:a5d:8049:: with SMTP id b9mr10283728ior.108.1545689268075; Mon, 24 Dec 2018 14:07:48 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id m20sm12614899itm.29.2018.12.24.14.07.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Dec 2018 14:07:47 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform: x86: Add check for led_classdev_register Date: Mon, 24 Dec 2018 16:07:37 -0600 Message-Id: <20181224220737.27539-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In function alienware_zone_init, the function led_classdev_register can return an error on failure. The fix checks the error and frees the allocated resources. Signed-off-by: Aditya Pakki --- drivers/platform/x86/alienware-wmi.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index f10af5c383c5..63ab6a2eb613 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -441,6 +441,7 @@ static int alienware_zone_init(struct platform_device *dev) u8 zone; char buffer[10]; char *name; + int ret; if (interface == WMAX) { lighting_control_state = WMAX_RUNNING; @@ -492,7 +493,17 @@ static int alienware_zone_init(struct platform_device *dev) zone_attrs[quirks->num_zones] = &dev_attr_lighting_control_state.attr; zone_attribute_group.attrs = zone_attrs; - led_classdev_register(&dev->dev, &global_led); + ret = led_classdev_register(&dev->dev, &global_led); + if (ret < 0) { + if (zone_dev_attrs) { + for (zone = 0; zone < quirks->num_zones; zone++) + kfree(zone_dev_attrs[zone].attr.name); + } + kfree(zone_dev_attrs); + kfree(zone_data); + kfree(zone_attrs); + return ret; + } return sysfs_create_group(&dev->dev.kobj, &zone_attribute_group); }