From patchwork Mon Jan 10 22:30:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 12709213 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CFFC433EF for ; Mon, 10 Jan 2022 22:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345458AbiAJWag (ORCPT ); Mon, 10 Jan 2022 17:30:36 -0500 Received: from mout.gmx.net ([212.227.17.20]:39123 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345433AbiAJWad (ORCPT ); Mon, 10 Jan 2022 17:30:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641853823; bh=pq3G8YNOhj4t7nDtwp3ftybIIxEtEenASnHUGrCP1U8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=IGZqpnN+CladoaCkxLf2HpZrldlIuveOyqE0zAtDlJQldI7ygcJBNewmaz/rx4OLU PvVAofhYcixo9Xs1X8rD5bOTzugb+szJrvzCN2m0jrDuX58YD/piMBIG1fQqiepYeC hlhUi/TxOLCGQRb7OOqzWxj8IEvef3UjAWQ9bSbg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.fritz.box ([62.216.209.151]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8obG-1mJz9V1rPS-015nmM; Mon, 10 Jan 2022 23:30:23 +0100 From: Peter Seiderer To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/5] ath5k: remove unused ah_txq_isr_qtrig member from struct ath5k_hw Date: Mon, 10 Jan 2022 23:30:17 +0100 Message-Id: <20220110223021.17655-1-ps.report@gmx.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:d5g9VGq2YYCdJZbuUoG8tfgp837QNFH7tHCixBv85xAi5Ge94DM PiKn7g8qPMv2zD0wvM8jRW0/cofi4jqQU0TUm9d8Dv0PWoyCk9YY/jf3QC9vlcgo5DqRTqu ys0lOqSXroVQdvNqBXhQClpcB1iDUvljHb7EoTFiMwE6+/hvVCNfTri9h95NYHWNdWaamwC 90dcwdtKLLE5JMhCVLQxA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Eo/s0/EISKw=:m6zrDnwVio5PNQiVTZNzvg 39OQXget1cXi7qp/NqgoQrqpSKOPD2FBkmfWAOqKD0l3IRLiqowk6GrCfXPUVF6i1tHKOKcHn tzSL5AEbXuLytt6NIfbCdb/+DSZeHfH6uRiNWTW3QBrCRGxtPMshpmdnGwcZa40omxuQtJGaB 87xqgyncBwjx6zxySnDKU7gGzwRx5dEZaYf0W4XyOedcK+5fBVR84oPKZyU8hHwXeeWfDr8iN r4EiemufDj9hQ4+AnmnoqAiKFgB/QHX0p3mcjnlLUED21dx9Zp3vjTYufk/MS9wItoC7ElOmr hHwqFXkOIZJtFx0R/BP4+OC1MSZVG1RXZRFlG+LaAlDuWpb5iFx0vj31K+YPtqS9OP5CbRyGh ZDCZxrvwKxm7fV2DyT0W8bQ9S5qC6MI5Lempa5HOhjCiGhvehEGDFx5y4B+vbeVNtKv65aTpi ElvRenR47BJnyQL86mDk0VBUVDXtLWGLme+bjt1ZKbFq1XmodGlpoxbmN9bWap9GBuDV/+C0H cg0ZRBH3Qhr72hwcaFAXODt7a1AZr82mg07JeMpLv9zHy/Wrl6sdlwGfULOk6arvlb+w9+cNR nzduFs0n7gYRPzRNbHFFIOQxnLzA3+DNoR2XWw6EOScrsjeLb6X5hq7P8rEBD0wehH4wweKW+ BO/673coT+yKxzxWO65yDykbjH3URt2cUWfcIsLB1keOaXTFqx9RB29lob3aYX6KEqPv7NDo2 bRtJlVuB2I3bbylvudhXJ2jerm6cclT1b+wPkp1CRZ6Wo8NOsREBVOjO1dE7+ZfTAvHcJ1dPm bTVI9gR5rJIA3+DaF7o7efd2AK5tldtZkFxo6ZzoXMHoF4bGd8P/p9q/I/CpiJYPGw3cYOo1Z VD9G2nIpMJ9z2CwHX7hGPrSS3IKqASyAxQD0+QbJDwysRxT/48QZLGyKWvzsb/TuxukwTNXN8 E33IzcCBAdGtrDXAr+rQGCGa8G5E2EiTf9RyjpoAVjMGEvUDfSJ5mnWomdNrdIF2IgMOD1Xy/ 38B7O8u/JoqS9cq7fteEf6uQoqLESHFr24ZD09yheQfpBxDC/URfim7/o6/GiIMXBGZswaoxJ fYuy259Q9KIBe4= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove unused ah_txq_isr_qtrig member from struct ath5k_hw (set in ath5k_hw_get_isr() but never used anywhere). Signed-off-by: Peter Seiderer --- drivers/net/wireless/ath/ath5k/ath5k.h | 1 - drivers/net/wireless/ath/ath5k/dma.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h index 234ea939d316..db6ba433c05d 100644 --- a/drivers/net/wireless/ath/ath5k/ath5k.h +++ b/drivers/net/wireless/ath/ath5k/ath5k.h @@ -1398,7 +1398,6 @@ struct ath5k_hw { u32 ah_txq_isr_txurn; u32 ah_txq_isr_qcborn; u32 ah_txq_isr_qcburn; - u32 ah_txq_isr_qtrig; u32 *ah_rf_banks; size_t ah_rf_banks_size; diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c index e6c52f7c26e7..78b87372da95 100644 --- a/drivers/net/wireless/ath/ath5k/dma.c +++ b/drivers/net/wireless/ath/ath5k/dma.c @@ -723,11 +723,8 @@ ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) } /* A queue got triggered */ - if (unlikely(pisr & (AR5K_ISR_QTRIG))) { + if (unlikely(pisr & (AR5K_ISR_QTRIG))) *interrupt_mask |= AR5K_INT_QTRIG; - ah->ah_txq_isr_qtrig |= AR5K_REG_MS(sisr4, - AR5K_SISR4_QTRIG); - } data = pisr; } From patchwork Mon Jan 10 22:30:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 12709210 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542CDC433EF for ; Mon, 10 Jan 2022 22:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345440AbiAJWae (ORCPT ); Mon, 10 Jan 2022 17:30:34 -0500 Received: from mout.gmx.net ([212.227.17.20]:48763 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345419AbiAJWad (ORCPT ); Mon, 10 Jan 2022 17:30:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641853824; bh=0v4YvqADVAYjymB3HVw6Y10EaBdeYrxs5ug8qzWR6Qg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=Sql3grBtskA4DwbZ8wOy8QlXOrsYADcf6l4rf/Se3PSgmOHnZ/wjNB8GKl5mzNrzL A3GhQLsMXdGl6hGVkqwB+loHAvDbk/QDTtcHFOawFdiA0aqYev32l+CZtpbqhqtkp2 2cyxJMnpHs3QloOmxBaIYgKwjYAGfCLtt4euQy9k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.fritz.box ([62.216.209.151]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MSc1B-1mwMqM40V7-00St49; Mon, 10 Jan 2022 23:30:24 +0100 From: Peter Seiderer To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/5] ath5k: remove unused ah_txq_isr_qcburn member from struct ath5k_hw Date: Mon, 10 Jan 2022 23:30:18 +0100 Message-Id: <20220110223021.17655-2-ps.report@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110223021.17655-1-ps.report@gmx.net> References: <20220110223021.17655-1-ps.report@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:3erQf5xbsLKf6pQyN6y96AR+2l2JqvlcvYy3sQSCCM4x5jdpeYc h73svbWvkbzqThogJSXp+Kkom7S57PNyLO6eO2mfV7Zhrx3EDaNUCGpv5FsG58gkwyvtmIV aGXSuy6pdeG6ldbbc+OV67ezRcjLeqZ/CPbFK6GPJdl8LpZuN+CW9wUrwpF02p7efIwTAEE sPXvlcDahR73dQUDam23w== X-UI-Out-Filterresults: notjunk:1;V03:K0:bVHFk1kJ6FA=:IKgbmY/PojXk7pyL3rD7Ns 6f6WVZxuoMpBu6MJNmkT/P0URYzLDkR63jn5fnDDcqV7wRavXXR5iwSlN/4+zC9FS4SRKX0tw eBiECQxMSUQFeiwtaFHapMXNrJYzO8tYCeRXZHYwidqqIb3IAdT9e0+g8cujMz/1LwhvfpL13 wIFowilSekOB6ivnQ2PwZ4Ta1Z93ajphoNGDLLn2NDtf6qDDaAHu4QWhoScf4dPS/S+yHO0An RffIIRTUizG/aikeoKrE8e0MfgJL5yHQRHO6EwKeuqlwg0Y8ocPK0FT0x9vYuIi3rmXq3seGf r8ogDUrISDshqYweYH0iKgYI5AwZwxcI164Z/v+01YBu0oA3H5Ap662iwfWdePRkmEv04jIPl yAKy606uINRudZkJtk6aGdkhrJH2492CFNaF7gqms6vk/7iw9S+JrPRbvEKEQ/eQx9H5wGYPT JTX/5ymkwpbByyP2ckbuHJii8z7vkzvBronj/gin3P4PIaVHBY3ukiPeYKcZuZPibS3g1W1Xr SotLelaagnxhcQbfj6EdQ2AoB+lhzNnQ1IkfbjHciM5U3cEOq4VfY3sYBUwEG4+HzMHv/reUD ZgHPeS5zN5cinBayghXhVVlvGngS6FQa2Uat+TmbloEL0sVz4szI0H/nTDrtjzTkduRQzYm9e lGue1iE5XDX6tiLzwvPVBtURpR8mW4Xnumj3WxiDyoTLLopiR5jZkinXvyRIHMzNSvCD9p1SL nAurY839OcsNNJ1Pcg5go7ZTSMiXDEzpYK4GsUHK2BBdStQ2B/Pvq9ysHdMMCmYlDLoppeBA0 hgrZ0XWRMXngopLS63SGQIL+wk7xtejtQIUys9TatLHUnueR1m/8Tm0tGKGUos5tJ8v6AXshp wQx9MZc9Aj67qSDBuqocc7leup99dBYbUjljbVDk/6lUWyFFR7wy31Lkl/Y0eR6hFSqghDx2M 5fBFbzFsh3UY0QL+pd3HGe3C2+fk1v1dm7AvueUnZ+ItZr9GosuRAEsKBL9XjMxdZ2V6VPFdB rpj/YC4FIQu+0hxIm7lAtoA8JpR8u0h0jCK+w7RMKWm5bgMCCGcmRYW0PKypHAIVp1/Acy0WB hHIeAyT/uIxTss= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove unused ah_txq_isr_qcburn member from struct ath5k_hw (set in ath5k_hw_get_isr() but never used anywhere). Signed-off-by: Peter Seiderer --- drivers/net/wireless/ath/ath5k/ath5k.h | 1 - drivers/net/wireless/ath/ath5k/dma.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h index db6ba433c05d..72ba36a04837 100644 --- a/drivers/net/wireless/ath/ath5k/ath5k.h +++ b/drivers/net/wireless/ath/ath5k/ath5k.h @@ -1397,7 +1397,6 @@ struct ath5k_hw { u32 ah_txq_isr_txok_all; u32 ah_txq_isr_txurn; u32 ah_txq_isr_qcborn; - u32 ah_txq_isr_qcburn; u32 *ah_rf_banks; size_t ah_rf_banks_size; diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c index 78b87372da95..faea3262368f 100644 --- a/drivers/net/wireless/ath/ath5k/dma.c +++ b/drivers/net/wireless/ath/ath5k/dma.c @@ -716,11 +716,8 @@ ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) } /* A queue got CBR underrun */ - if (unlikely(pisr & (AR5K_ISR_QCBRURN))) { + if (unlikely(pisr & (AR5K_ISR_QCBRURN))) *interrupt_mask |= AR5K_INT_QCBRURN; - ah->ah_txq_isr_qcburn |= AR5K_REG_MS(sisr3, - AR5K_SISR3_QCBRURN); - } /* A queue got triggered */ if (unlikely(pisr & (AR5K_ISR_QTRIG))) From patchwork Mon Jan 10 22:30:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 12709212 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5CDC43219 for ; Mon, 10 Jan 2022 22:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345452AbiAJWaf (ORCPT ); Mon, 10 Jan 2022 17:30:35 -0500 Received: from mout.gmx.net ([212.227.17.22]:57173 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345431AbiAJWad (ORCPT ); Mon, 10 Jan 2022 17:30:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641853824; bh=k/tTrIjFeCXvZqfaQTrSCH6RUwILOWRvkqA3YG0MfJ0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=RuY58ohDZI4IPDoL4HnzP+grczAjb5/IZBdJ7qHyT3A/4GAOpxLQOZP3N/DtfCw0d 0+qMkQM2pRSmdbBNV3Ues+UtzvORif4SDhlAWynaBRltZefHigbCGf58zKOpMhThtS 3VxN7+m0qPVN1zPgAdRIS0j+IrlldIygyEXbaD3Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.fritz.box ([62.216.209.151]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqs4f-1mcKwb1yJl-00mtqn; Mon, 10 Jan 2022 23:30:24 +0100 From: Peter Seiderer To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/5] ath5k: remove unused ah_txq_isr_qcborn member from struct ath5k_hw Date: Mon, 10 Jan 2022 23:30:19 +0100 Message-Id: <20220110223021.17655-3-ps.report@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110223021.17655-1-ps.report@gmx.net> References: <20220110223021.17655-1-ps.report@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:BDrmtIihdsTJpnywmYDxM9n1+px3iDoKOC1yRzRM2G0W3e3Bbgm /xgn7kL0NSXNIf64qiHCrg2XML7aKNSB4FKLZpiHdscygxsQkKsid6tXRq9Ocb8Xo93aXEo 1rwWEr0eZDjwMOsV3RuH0t2U7KwIQ8CjKbJBZ0aa7BJhZeloLast5DgKT/hsc+x7LhgtHeM XsOjDOrA697sGkTcGBcmw== X-UI-Out-Filterresults: notjunk:1;V03:K0:zplG+idIBZE=:+ccWOgDgT3zGeogJ2W5sxp dwXbIa2VF3mrs3iBy/8tpVpxGTMQYBMj6+66R6GziCJvETAEa0joxBQjbbqV01yzPgS32upub XFMSwqifOUb9pHR9QN1uhD4/JEXULi5YjIs2w6vdCPMrmQSaW9yTPJGceoEudChUUue4W0K7k aT7VoUJWD3MXcn7rrhcOVDnpXavRU8jnNHNIGOXijsIbG9sjN1RDLO4emA1zU2xxn4/Vo+WRt +p97zlY/4t+wYb02oo4B8zfdgvehLwR3w8njviKCPn90jkLRGYqeKbd3QNUpYbG6tDqELHOVX hsLuo0L0JxDOhjesSHnuHb95GOXUoc0ngr/IcasjXGAtSJj/7wipbfv3pCG+TT9XuFbi+qKy+ fdtlGH+qf0by/Olh3glsv9ML79hBPcHDIsEkBB/rrEQ/vQ+KHDOarL9xDVisp8HRkpdE5/ESV SVIJONnz1GfkLBNwxDGgpspXXacpNJGAqkDKEiGChPmfYO23+pa03Uuv18Vrw80jrCRJBQX8D YMvLgr2oJdUMNM4JAOd+w+CBhCeZwdn3MrHZoNQ/lyJBR5mnrsVY/2uJkwZysE2oWlKZnNOWA TF6KYUcosuDci810SPStmf6DnG8WobpxmZ49f3bfBY58vHuSGLR2QE+X4z/HrC0oOnSOylmVE vjCpyXvLco1ieY82GmzSAv83h/E75dO5J77QNYNsHUnpmeNCfZ5tozBAioooMLevXAqRiBZVX rCdNfqEF5D+Q/QzcoCI3e0Sv2gUgqHhZLKyCj72zSEdyyAUkvbUCcVGQPoUb6/O+heEkhDFFm 5WRjSipT6uHge3fEWTpNa+NTNgKwbKeKGDJcM/rbXFoMDtSEjHEmT3cB8hLRV/gIuWVIX23au YMIt+aFSBcZP4mss4GMo3HzXb8m3M4W24tKXkI1YBfR75luqymclAMlVl4nyl+TsFgqWxDFz3 iaTTzd+u8hy3mmdGCH0pAHMiOv5fvXw6A2vTgp5bwtrSqIA2P6te8Ksci7HeONUYEEpaF3Btz puT80G0CX3QaB1Xkf817yK+btz/fFOY/YD2k+bIh4fHOawo88qpF7zdzTgWxh0OHRQ9luOjRS 1HDCKt9XWSKfQQ= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove unused ah_txq_isr_qcborn member from struct ath5k_hw (set in ath5k_hw_get_isr() but never used anywhere). Signed-off-by: Peter Seiderer --- drivers/net/wireless/ath/ath5k/ath5k.h | 1 - drivers/net/wireless/ath/ath5k/dma.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h index 72ba36a04837..ac3211b1eb0c 100644 --- a/drivers/net/wireless/ath/ath5k/ath5k.h +++ b/drivers/net/wireless/ath/ath5k/ath5k.h @@ -1396,7 +1396,6 @@ struct ath5k_hw { u32 ah_txq_isr_txok_all; u32 ah_txq_isr_txurn; - u32 ah_txq_isr_qcborn; u32 *ah_rf_banks; size_t ah_rf_banks_size; diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c index faea3262368f..0ee46f8118bb 100644 --- a/drivers/net/wireless/ath/ath5k/dma.c +++ b/drivers/net/wireless/ath/ath5k/dma.c @@ -709,11 +709,8 @@ ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) *interrupt_mask |= AR5K_INT_BNR; /* A queue got CBR overrun */ - if (unlikely(pisr & (AR5K_ISR_QCBRORN))) { + if (unlikely(pisr & (AR5K_ISR_QCBRORN))) *interrupt_mask |= AR5K_INT_QCBRORN; - ah->ah_txq_isr_qcborn |= AR5K_REG_MS(sisr3, - AR5K_SISR3_QCBRORN); - } /* A queue got CBR underrun */ if (unlikely(pisr & (AR5K_ISR_QCBRURN))) From patchwork Mon Jan 10 22:30:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 12709214 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB97C433EF for ; Mon, 10 Jan 2022 22:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345444AbiAJWap (ORCPT ); Mon, 10 Jan 2022 17:30:45 -0500 Received: from mout.gmx.net ([212.227.17.21]:37767 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345434AbiAJWae (ORCPT ); Mon, 10 Jan 2022 17:30:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641853825; bh=+BEMjZgHov6GI+pbRQ/61AK7GFOe1ZiB6QyOW7gVx9Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=Dm92lJlco/v679Qp3Y0gIY74qDzvxTY+8cXYrHfhVSDesK22DxlOKyKLSFE+mWX2P vuSAGUQ+rPqFQa1wtETISXV0J9Md7IinaZWCTKl4OI1hWhSh6TOvTvbb4FoChov96z ThLerCFKzh0qvPkxMUm082quuIzguGu4bfD7oXsk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.fritz.box ([62.216.209.151]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MkYXm-1mdjzD04hq-00m3yc; Mon, 10 Jan 2022 23:30:25 +0100 From: Peter Seiderer To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 4/5] ath5k: remove unused ah_txq_isr_txurn member from struct ath5k_hw Date: Mon, 10 Jan 2022 23:30:20 +0100 Message-Id: <20220110223021.17655-4-ps.report@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110223021.17655-1-ps.report@gmx.net> References: <20220110223021.17655-1-ps.report@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:KQ19AMCrNOiO4RXxL9JHJN9emp9Al1pNhGS32fQHrDEywqhyOoR fB6QC0cnLpZxVzku75NnBIf2Y5fs5ZOv7ljHmUaIAuDwJbm0HsTZD28IsztP3rmOQdzOgi5 WfzamsdgUwCqR0EDRepXgyzUYNs2CGcgA0Yj5sa88xAH09FrYuR+fhrZOmxKy86ILYaYroQ 93h+mXhgd4kYV8PmsiGiw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Yf91gQZTrgQ=:rIznZJItYOCDika25WmZ5Z mWZnh/LZdI9EvRfSwUiQsCrH/BxDJ4Dh8q+pBEBD90+fKwfMJvA4c9wUefslqhly49Nw78p9x 5sMSym1Hr3ToHrDTlX/WN/FiDiD0ORsNsAHnDTG6GsvzYrQp/qUuiKSfr0U/86sip1jyEJWHC 4zbbrA+r09zzd1QQ/IrPAV0c7HtuIi6KWFujbDZ1u9iijA90Nz8fHPJ9cx3nfQ1vlE5t6NS8X lw20SfMDRhHDaO+Tf1Gfnycmi21Gy+zvFA1j3nXFNSTVZN0PHmSp6pSRh028WikKiatAi1U9c EjmsU/TyYgtN0K8DRSnDSIxb70mbVS2OG+oZn13vm9s4EJqPjiJ9CX0TGVqBp0Ho1rKAvizxe jRy0Zzbkn21bWTts/2cmSviAI5hJ7lLZt7Q2CPVPZm7lFkhz5Nj7LYeXNKUw2XKRc25EaTGJb /yo5IjyT3Zwgy3KLbyNnHnbegayzBHKZRHB4qEJMdDoC4JsTz/1blYZ5cAI/vnFzGkLDWqlPC pd2aS+utiji5/kbFpUcT8yBggFbOV/dJgjhNbOJhk/lGLfuon++V6wN5MyWXnlLdgrNENeX6p 8P31xXmQvMuA1o1dBNJc7z5vqZSaVlLlX1lFp2FivcG3SQbdJktGdnFmYCIcIsZRsw7Kh4EaK zXVkGH6wqiOULU+LweL8005iHY+Ge2g/NDKnR50CwMffPcUP679RVcl1f1yLByqWK8h7sJkxw UurENvKckkiaAoCg2pC8p5/HmdFFhm5rNsOvk16M3C05N1MA9PTM6lFPIWLtENjGQ0lj1ouE4 iFduqPfUqVWJ8KhkgEcQMIiMhAv3LgwB/bvBy0UZkYgySpLBX0hrYznHSnOud3A1z05E33/c9 Y9VRY1TiMBC9tPS7GEccSVKHH/g3Gl6VRRWw3X3/XQsI43r/6pkHsgq0wjCuDyP07LvZzGu3l OIFpXlbMJGzOqR+CD5B1GHxvo49bcQ9fngKguF2I+CpNladss/z+xwCJC1/f+JbKxm3J6UNIZ 3T8yKqtrYp1eUoxaGhWDADlfsCblx2A4N3hHFuxv/8q/XH+rpMF71LsH05rD7nZYMnIAnHWes dibVg9vg49qzMo= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove unused ah_txq_isr_txurn member from struct ath5k_hw (set in ath5k_hw_get_isr() but never used anywhere). Signed-off-by: Peter Seiderer --- drivers/net/wireless/ath/ath5k/ath5k.h | 1 - drivers/net/wireless/ath/ath5k/dma.c | 7 ------- 2 files changed, 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h index ac3211b1eb0c..f595204f493d 100644 --- a/drivers/net/wireless/ath/ath5k/ath5k.h +++ b/drivers/net/wireless/ath/ath5k/ath5k.h @@ -1395,7 +1395,6 @@ struct ath5k_hw { u32 ah_txq_imr_nofrm; u32 ah_txq_isr_txok_all; - u32 ah_txq_isr_txurn; u32 *ah_rf_banks; size_t ah_rf_banks_size; diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c index 0ee46f8118bb..2b135a6284a0 100644 --- a/drivers/net/wireless/ath/ath5k/dma.c +++ b/drivers/net/wireless/ath/ath5k/dma.c @@ -670,13 +670,6 @@ ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) ah->ah_txq_isr_txok_all |= AR5K_REG_MS(sisr1, AR5K_SISR1_QCU_TXEOL); - /* Currently this is not much useful since we treat - * all queues the same way if we get a TXURN (update - * tx trigger level) but we might need it later on*/ - if (pisr & AR5K_ISR_TXURN) - ah->ah_txq_isr_txurn |= AR5K_REG_MS(sisr2, - AR5K_SISR2_QCU_TXURN); - /* Misc Beacon related interrupts */ /* For AR5211 */ From patchwork Mon Jan 10 22:30:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 12709211 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96410C433FE for ; Mon, 10 Jan 2022 22:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345450AbiAJWae (ORCPT ); Mon, 10 Jan 2022 17:30:34 -0500 Received: from mout.gmx.net ([212.227.17.20]:59285 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345432AbiAJWad (ORCPT ); Mon, 10 Jan 2022 17:30:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641853825; bh=/vAc/cWpB6Hy72B79vKnewkrZjPB5a5e0t9n4ldSDgE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=kpnnFwt6pBnkle2F0xPbCcgsFrs2AI8du3+o3roXsD93oghPDI+kWXrkuUs7f9hWE OwkWyBxf/Yjd9z6boGau31/g0Bqq21ZYS+P0L8Y8xl30+OBzZFJjISVIL5d66KXvPB OeV+UZ0RVtO3ngBo1UmwoYY3rUAsjs1F+iN31wq4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.fritz.box ([62.216.209.151]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAci-1mVWVV23VA-00beNI; Mon, 10 Jan 2022 23:30:25 +0100 From: Peter Seiderer To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 5/5] ath5k: fix ah_txq_isr_txok_all setting Date: Mon, 10 Jan 2022 23:30:21 +0100 Message-Id: <20220110223021.17655-5-ps.report@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110223021.17655-1-ps.report@gmx.net> References: <20220110223021.17655-1-ps.report@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:Oaji8jUP8E5JVdmIs2XuC/fPruoDCWsfS+NAgngXlxs6gkmMvEr VEPKNHL7Xj40Kh3LcWiMCCBUoidxqK0D1IJYZ8Q9/fpx1cb8+ecFqAuxYmdY2UTw2Z8FOy2 NgwsWQ75tPHoiUUzz1jqCWkKdPNd9yD9A5YqxvL3ZfydgTICK9bWOPmPuG43KWha6NDVrdT Enkh1nKhfMFHi5XNZUe5Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:q+oAgThdpHU=:44G2nolYim/11OA13VZwFu fGirkj/4bvbtjyBz0gse7k0I2gVAbTFBiKD+rNnYZCFZXlRxIs370pjolWegwUBhLeCVJmAdY seezpECorwr8deHSw4W7GdTsg5L8WIbMNmC/8V5Qb+jxWN+iCZ5HAZZYxjK5VDZ9CIh06+6mY G5PZPE5fu0mspSlaZ7pzHbWppJqPf/6aQq1CZehpOrVE8PrRSsZQ8V+njPUBbTnWQpJ6NeRG7 5YS8pAboekHicOe56UZJpY/+OGz5OA2ZPJaTqvoTFxzsv3ozzLDNXGZD9QIkC40tD7bl+eHDy sZREGcQrL8BuXULP8lgOaRFckyMVDjqWYPScnEh2ZJIBaPMMbRfwN1Hq2MnLdYOwfBzSoJmhk +v2b0Q2FFal1g0bgfCgeSUICqQF/NiwmkLcndeHDjEjhKfX1o/1QaD0KsnBD4SSpuwJn6U/mX PU1cu+CuSdq2i6cWyBcKEMmJMjJ3FGDamsF45bxnxT8sJym7RsrJoPcb9vweNuxOyaKSmDxqT SsciNGABeVBrv+pusWxaE1fk0cS1NDJdOFK2vrQyqUycX2ie+WLVXomlLG8DubNs25EWPo6Q5 f7/08J1m8BbrdMmmk8Lxxc3hqQUWlEZe7MnT8AI4gTqQLGMaMcWAbeQKUI94Ih3voQGTHFun1 mTJr/pyw8uEb3ZKvAwaj1vaHzVXJeoiG7S/I6T+eNo4QAmqtIIcLybinJBySlCoViRgZQp1B0 EUho0ue0WWT1ANNBnjZMLsJYtMAzrrKku8IWG0htotucb+k6Ifufqm1Z8QskaZilw5lcny6I7 jxt2LQ+XjpTIA9HohFF22nlOM5bHqicKh5RH/0WIX8t6IbWvaQgpkyQx6OfNLm+Fq3abmF29j G5xzgmxG3go3wTW/eV064KS379CVq8hcfBlenW8BneTGCZzAHUJwBeX/YtUcsztz+eNxxkTlG aY0IL6DE33GQdZcTqMsTDB84EiadBFmxnUiP7K5xBGUlX2RZLBMkyrV6lHqa9IzS4mti++I8v odUshZdljdWlr6G+FEkMlI8VGRSYWFbLEe/ZZ/IsyxN6g4WMw8PeL16O7gKXhh3FkG89hft9f cmfSoCTn4aJAxI= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The struct ath5k_hw member ah_txq_isr_txok_all is never reset/assigned outside of ath5k_hw_get_isr() and with the used bitwise-or in the interrupt handling accumulates all ever set interrupt flags. Fix this by clearing ah_txq_isr_txok_all before assigning. Patch tested with Senao NMP-8602 card Qualcomm Atheros AR5413/AR5414 Wireless Network Adapter [AR5006X(S) 802.11abg] (rev 01) ath5k: phy6: Atheros AR5413 chip found (MAC: 0xa4, PHY: 0x61) running IBSS mode against Atheros (ath9k) card using ping and iperf traffic. Signed-off-by: Peter Seiderer --- drivers/net/wireless/ath/ath5k/dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c index 2b135a6284a0..d9e376eb040e 100644 --- a/drivers/net/wireless/ath/ath5k/dma.c +++ b/drivers/net/wireless/ath/ath5k/dma.c @@ -650,6 +650,7 @@ ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) */ *interrupt_mask = (pisr & AR5K_INT_COMMON) & ah->ah_imr; + ah->ah_txq_isr_txok_all = 0; /* We treat TXOK,TXDESC, TXERR and TXEOL * the same way (schedule the tx tasklet)